ai-developer-skill-os 7.0.2 → 7.5.1

package/skills/qk-ui-audit/references/anti-slop-checklist.md

@@ -0,0 +1,136 @@
+# Anti-Slop Checklist — 57 Points
+> Referenced by: `qk-ui-audit/SKILL.md`
+> Purpose: Full inspection checklist for detecting generic AI-generated UI
+
+---
+
+## Category P1: Accessibility (15 pts)
+
+| # | Check | Points | How to Verify |
+|---|-------|--------|---------------|
+| 1 | All images have `alt` text (non-empty, descriptive) | 2 | grep `alt=""` or `alt={` in JSX |
+| 2 | Color contrast ratio ≥ 4.5:1 (text) / 3:1 (large text) | 3 | Check computed HSL values vs background |
+| 3 | All interactive elements have `aria-label` if no visible text | 2 | grep for `<button>` without text content |
+| 4 | Focus states are visible — `outline: none` not used without replacement | 2 | Check CSS for `outline: none` |
+| 5 | Keyboard navigation works (Tab order logical) | 2 | `tabIndex` only for non-interactive elements |
+| 6 | `role` attributes used for non-semantic elements (div acting as button) | 2 | grep `onClick` on non-button elements |
+| 7 | Form inputs have associated `<label>` (htmlFor) | 2 | grep `<input` without surrounding `<label` |
+
+---
+
+## Category P2: Layout & Spacing (15 pts)
+
+| # | Check | Points | How to Verify |
+|---|-------|--------|---------------|
+| 8 | No hardcoded pixel spacing — uses design token scale (4, 8, 16, 24...) | 3 | grep `padding: [0-9]px` or `margin: [0-9]px` |
+| 9 | CSS Grid or Flexbox used — no `position: absolute` for layout | 2 | grep `position: absolute` in layout context |
+| 10 | Consistent spacing unit (not mixing 5px, 7px, 11px random values) | 2 | Check spacing values across components |
+| 11 | No `div` soup — semantic HTML used (article, section, nav, main, aside) | 2 | grep excessive `<div>` nesting |
+| 12 | Component has defined max-width (not stretching to 100vw on desktop) | 2 | Check container max-width |
+| 13 | Whitespace feels intentional — content is not cramped | 2 | Visual check or spacing scale adherence |
+| 14 | No horizontal overflow on mobile (320px viewport) | 2 | Check for `overflow-x: hidden` band-aids |
+
+---
+
+## Category P3: Typography & Colors (15 pts)
+
+| # | Check | Points | How to Verify |
+|---|-------|--------|---------------|
+| 15 | Font families from DESIGN.md only (no Times New Roman, Arial default) | 3 | grep `font-family:` vs DESIGN.md |
+| 16 | Font sizes use token scale — no arbitrary px values | 2 | grep `font-size: [0-9]` raw values |
+| 17 | Colors use DESIGN.md tokens — no hardcoded hex (#ff0000) or rgb() | 3 | grep `#[0-9a-fA-F]{3,6}` in CSS/JSX |
+| 18 | No pure black (#000000) or pure white (#ffffff) — use near-black/near-white | 2 | grep `#000\|#000000\|#fff\|#ffffff` |
+| 19 | Color palette is harmonious — not "rainbow slop" (5+ unrelated colors) | 2 | Count distinct hues in palette |
+| 20 | Heading hierarchy correct — one `<h1>` per page, no skipping levels | 1 | grep heading tags per page |
+| 21 | Line height appropriate (1.4–1.7 for body, 1.1–1.3 for headings) | 2 | Check `line-height` values |
+
+---
+
+## Category P4: Interactions & Animations (15 pts)
+
+| # | Check | Points | How to Verify |
+|---|-------|--------|---------------|
+| 22 | Every button has hover state — color shift OR shadow change | 2 | grep `:hover` for button styles |
+| 23 | Every button has focus-visible state | 2 | grep `:focus-visible` |
+| 24 | Active/pressed state exists for clickable elements | 1 | grep `:active` |
+| 25 | Transition duration from DESIGN.md — not raw `0.3s` everywhere | 2 | grep `transition:` vs token values |
+| 26 | No janky instant state changes — all transitions ≥ 100ms, ≤ 400ms | 2 | grep transition durations |
+| 27 | Animations respect `prefers-reduced-motion` | 2 | grep `prefers-reduced-motion` in CSS |
+| 28 | Links have hover underline OR color change (not just cursor pointer) | 2 | grep `a:hover` styles |
+| 29 | Form validation feedback uses animation (shake, pulse) not just color | 2 | Check error state CSS |
+
+---
+
+## Category P5: Anti-Slop Detection (15 pts)
+
+| # | Check | Points | How to Verify |
+|---|-------|--------|---------------|
+| 30 | No Bootstrap/generic UI kit classes (btn-primary, card, badge) | 2 | grep `class="btn\|card\|badge\|modal"` |
+| 31 | No Tailwind utility spam (> 15 classes on single element) | 2 | grep extremely long className strings |
+| 32 | No Lorem Ipsum or placeholder text in production UI | 3 | grep `Lorem ipsum\|placeholder text` |
+| 33 | Color palette is NOT blue-gray default (slop signature) | 2 | Check if primary color is `hsl(210, *)` Tailwind default |
+| 34 | Layout is NOT a simple centered card on white background (slop template) | 2 | Structural check |
+| 35 | Gradient usage is intentional — not `linear-gradient(to bottom, #fff, #f0f0f0)` | 2 | grep gradient definitions |
+| 36 | No `box-shadow: 0 2px 4px rgba(0,0,0,0.1)` everywhere (Bootstrap shadow) | 2 | grep this exact shadow pattern |
+
+---
+
+## Category P6: Performance & Best Practices (10 pts)
+
+| # | Check | Points | How to Verify |
+|---|-------|--------|---------------|
+| 37 | Images have `loading="lazy"` for below-fold content | 2 | grep `<img` without `loading` |
+| 38 | No `!important` overrides (except CSS reset) | 1 | grep `!important` in component CSS |
+| 39 | No inline styles except dynamic values | 2 | grep `style={{` in non-dynamic contexts |
+| 40 | Component file ≤ 300 lines | 1 | Line count check |
+| 41 | No unused CSS classes or dead styles | 1 | Visual code scan |
+| 42 | SVG icons used instead of emoji for UI elements | 1 | grep emoji characters in JSX |
+| 43 | `key` prop used correctly in lists (not index as key for dynamic lists) | 2 | grep `.map(` + check key prop |
+
+---
+
+## Category BONUS: Mobile & Cross-Browser (5 pts extra)
+
+| # | Check | Points | How to Verify |
+|---|-------|--------|---------------|
+| 44 | Touch targets ≥ 44×44px on mobile | 1 | Check button/link dimensions |
+| 45 | No hover-only interactions (mobile has no hover) | 1 | Check if critical info only on hover |
+| 46 | Custom fonts have system-ui fallback | 1 | Check font-family fallback stack |
+| 47 | Input types correct: email, tel, number, date (triggers correct mobile keyboard) | 1 | grep `<input type=` |
+| 48 | No `position: fixed` elements blocking content on small screens | 1 | Check fixed/sticky headers/footers |
+
+---
+
+## Extended Checks (9 additional points for comprehensive audit)
+
+| # | Check | Category |
+|---|-------|---------|
+| 49 | Loading skeleton matches actual content shape (not generic gray bars) | UX |
+| 50 | Empty state has illustration + helpful action button (not just "No data") | UX |
+| 51 | Error state specifies the error — not generic "Something went wrong" | UX |
+| 52 | Success feedback is clear — confirmation message or visual indicator | UX |
+| 53 | Destructive actions (delete) require confirmation dialog | Safety |
+| 54 | Modals/dialogs have accessible `role="dialog"` + focus trap | A11y |
+| 55 | Scrollable areas have visible scroll indicator | UX |
+| 56 | Data tables have sortable columns if > 10 rows | UX |
+| 57 | Forms have autofocus on first input (modal forms) | UX |
+
+---
+
+## Scoring Summary
+
+| Category | Max Points |
+|----------|-----------|
+| P1 Accessibility | 15 |
+| P2 Layout & Spacing | 15 |
+| P3 Typography & Colors | 15 |
+| P4 Interactions & Animations | 15 |
+| P5 Anti-Slop Detection | 15 |
+| P6 Performance | 10 |
+| **Base Total** | **85** |
+| BONUS Mobile | +5 |
+| Extended (49–57) | +9 |
+| **Maximum Possible** | **99** |
+
+**Pass threshold: ≥ 76 / 85 base (90%) — PASS**
+**Fail: < 76 / 85 — requires redesign, not patch**

package/skills/qk-ui-builder/SKILL.md

@@ -0,0 +1,447 @@
+---
+name: qk-ui-builder
+category: frontend
+version: 7.5.1
+description: "Xây dựng, sửa, audit, và học UI — từ Figma/ảnh, map API, fix bug UI, đến redesign cấu trúc."
+platforms: [antigravity, claude-code, cursor, windsurf, kilo-code]
+execution_mode: deterministic
+
+cost: high
+latency: slow
+risk: low
+side_effects: edit_files
+produces: [code, report]
+consumes: [design-md, design-asset, source-code, api-schema]
+
+token_budget:
+  max_files_read: 5
+  max_lines_per_read: 150
+  max_shell_commands: 0
+  stop_early: false
+
+exit_codes: [SUCCESS, BLOCKED, FAILED, PARTIAL]
+skill_version: 7.5.1
+runtime_version: 1
+schema_version: 2
+---
+
+# qk-ui-builder — UI Builder & Auditor
+
+> **Language rule:** Code, identifiers, file names → English. Explanations, summaries → Vietnamese.
+
+---
+
+## Verbs
+
+| Verb | Trigger | Behavior |
+|------|---------|----------|
+| *(default)* | `./qk-ui-builder` | Build or edit UI from design reference |
+| `--audit` | `./qk-ui-builder --audit` | Score UI against anti-slop checklist, no edits |
+| `--redesign` | `./qk-ui-builder --redesign` | Rebuild structure, keep copy/IA/brand |
+| `--study` | `./qk-ui-builder --study <screenshot\|URL>` | Extract design DNA → `design.md` |
+
+---
+
+## Preconditions
+- [ ] `DESIGN.md` exists with color tokens, spacing scale, typography
+- [ ] For default/edit: design reference or target component specified
+- [ ] For `--audit`: target UI file(s) specified
+- [ ] For `--redesign`: target page + brand/copy context provided
+- [ ] For `--study`: screenshot file or public URL provided
+
+```
+On missing precondition:
+  EXIT: BLOCKED
+  Message: "[Missing item]. See Escalation Rules."
+```
+
+---
+
+## Scope
+
+### Default verb
+- ✅ Build new UI from Figma/ảnh/design reference
+- ✅ Sửa text, thêm nội dung, map API key vào component
+- ✅ Fix UI bug: padding, màu, hiển thị, responsive
+- ✅ Generate strict UI từ DESIGN.md tokens
+
+### `--audit`
+- ✅ Score UI against anti-slop checklist (58 gates)
+- ✅ Detect generic AI aesthetics, hardcoded values
+- ✅ Verify ARIA, contrast, responsive states
+
+### `--redesign`
+- ✅ Thay đổi cấu trúc page, giữ nội dung/IA/brand
+- ✅ Pick new macrostructure + theme fingerprint
+
+### `--study`
+- ✅ Extract design DNA từ ảnh/Figma/URL
+- ✅ Emit portable `design.md` for handoff
+
+## Non-Goals
+- ❌ Invent design tokens not in DESIGN.md
+- ❌ Use hardcoded hex colors, px sizes not from token system
+- ❌ Copy generic Tailwind/Bootstrap templates
+- ❌ Skip loading/error/empty states
+- ❌ Clone paid templates or violate design copyright
+
+---
+
+## Priority Order
+
+| Priority | Task | Skip Threshold |
+|----------|------|----------------|
+| P1 | HTML structure + semantic markup | Never |
+| P2 | DESIGN.md token application (colors, spacing, typography) | Never |
+| P3 | Interactive states (hover, focus, active) | Budget < 30% |
+| P4 | Responsive breakpoints (mobile) | Budget < 50% |
+| P5 | Loading / error / empty states | Budget < 60% |
+| P6 | Animation / micro-interactions | Budget < 70% |
+| P7 | ARIA roles + keyboard navigation | Budget < 80% |
+
+---
+
+## Workflow
+
+### Phase 1 — Route by Verb
+
+**Decision:**
+```
+IF --audit
+  → Load slop-test gates → go to Audit phase
+
+ELSE IF --redesign
+  → Load macrostructure index → pick new fingerprint → go to Build phase
+
+ELSE IF --study
+  → Load study protocol → extract DNA → emit design.md → EXIT: SUCCESS
+
+ELSE (default: build/edit)
+  → go to Build phase
+```
+
+---
+
+### Phase 2 — Load Design Context (default/edit/redesign only)
+
+**Load Discipline (MANDATORY):**
+
+```
+EAGER (load every build):
+  - typography.md
+  - color.md
+  - layout-and-space.md
+  - copy.md
+  - anti-patterns.md
+
+INDEX-THEN-PICK (load index, choose ONE):
+  - macrostructures.md → pick ONE → load only that file
+
+CONDITIONAL (load only if needed):
+  - themes/[name].md → only if project has locked theme
+  - motion.md → only if animation requested
+  - interaction-and-states.md → only if complex interactions
+  - responsive.md → only if mobile breakpoints needed
+  - component-cookbook.md → only if building known archetype
+
+LOAD-AT-END (post-emit only):
+  - slop-test.md → run AFTER build completes
+```
+
+**Steps:**
+1. Read `DESIGN.md` → extract tokens: colors (HSL), spacing, fonts, radius, shadows
+2. Load eager references (typography, color, layout, copy, anti-patterns)
+3. Check `.agents/memory/ui-diversification.json` for last theme/macrostructure used
+4. If redesign: read `references/macrostructures.md` index → pick ONE different from last → load only that file
+5. If project has locked theme: load `references/themes/[name].md`
+
+**Diversification rule:** consecutive builds must use different theme + macrostructure from `ui-diversification.json`.
+
+---
+
+### Phase 3 — Build or Edit
+
+**Steps:**
+1. For new UI: create component from design reference using DESIGN.md tokens
+2. For edit: modify existing component per user request (text, API mapping, layout)
+3. Apply theme + macrostructure fingerprint
+4. Handle all 3 UI states: Loading, Success, Error
+
+**API mapping rule:**
+- Bind API response to component props via generated TypeScript interfaces
+- NEVER hardcode API URLs in component
+- Use existing API client pattern from project
+
+---
+
+### Phase 4 — Slop Test (post-emit)
+
+Load `references/slop-test.md` and verify all 58 gates pass.
+
+```
+IF all 58 gates pass
+  → EXIT: SUCCESS
+
+ELSE IF critical gate fails (hardcoded purple gradient, banned font)
+  → EXIT: FAILED — rebuild required
+```
+1. Read `references/macrostructures.md` (index only)
+2. Pick ONE macrostructure different from last build
+3. Load only that macrostructure file from `references/macrostructures/`
+
+---
+
+### Phase 3 — Build or Edit
+
+**Steps:**
+1. For new UI: create component from design reference using DESIGN.md tokens
+2. For edit: modify existing component per user request (text, API mapping, layout)
+3. Apply theme + macrostructure fingerprint
+4. Handle all 3 UI states: Loading, Success, Error
+
+**API mapping rule:**
+- Bind API response to component props via generated TypeScript interfaces
+- NEVER hardcode API URLs in component
+- Use existing API client pattern from project
+
+---
+
+### Phase 4 — Self-Audit (Anti-Slop Check)
+
+**Checklist (must pass ALL):**
+- [ ] No hardcoded colors — only DESIGN.md tokens
+- [ ] No font-size in px without token — use rem/token
+- [ ] No `margin: auto` soup — use proper grid/flex
+- [ ] All interactive elements have hover + focus state
+- [ ] Mobile viewport works (no horizontal overflow)
+- [ ] No `!important` overrides (except resets)
+- [ ] No inline styles except dynamic values
+- [ ] Loading state implemented (skeleton or spinner)
+- [ ] Error state implemented (clear message)
+- [ ] Empty state implemented (helpful illustration/text)
+
+**Decision:**
+```
+IF all checks pass
+  → EXIT: SUCCESS
+
+ELSE IF 1–2 minor fails
+  → Fix immediately, EXIT: SUCCESS
+
+ELSE IF > 2 fails OR hardcoded colors found
+  → Fix all, re-audit, EXIT: PARTIAL if still one gap
+```
+
+---
+
+### Phase 5 — Slop Test (post-emit)
+
+Load `references/slop-test.md` and verify all 58 gates pass.
+
+```
+IF all 58 gates pass
+  → EXIT: SUCCESS
+
+ELSE IF critical gate fails (hardcoded purple gradient, banned font)
+  → EXIT: FAILED — rebuild required
+```
+
+---
+
+## Confidence Model
+
+| Level | Condition | Action |
+|-------|-----------|--------|
+| HIGH | DESIGN.md complete, design reference clear, API schema provided | Build directly |
+| MEDIUM | Some tokens missing or design reference ambiguous | Note gaps, proceed |
+| LOW | DESIGN.md missing or design reference too vague | EXIT: BLOCKED |
+
+---
+
+## Severity
+
+| Level | Definition | Example |
+|-------|-----------|---------|
+| CRITICAL | Hardcoded API URL in component, banned font used | `axios.get("http://localhost")` in JSX |
+| HIGH | Missing error/loading state, hardcoded color not in DESIGN.md | No 500 handler |
+| MEDIUM | Missing hover state, spacing off by 1 unit | Button without focus ring |
+| LOW | Comment missing, minor naming inconsistency | `temp` variable name |
+
+---
+
+## Evidence Format
+
+```
+[SEVERITY] path/to/Component.tsx:LINE
+Category:   [TOKEN|SEMANTIC|INTERACTION|RESPONSIVE|STATE|ARIA|SLOP]
+Reason:     [specific violation]
+Confidence: HIGH
+Fix:        [one-line actionable suggestion]
+Points:     -N pts (for audit mode)
+```
+
+---
+
+## Retry Policy
+
+```
+Build/Edit fails
+  └─ Check failure type
+       ├─ Token missing → infer from DESIGN.md, note assumption
+       └─ Design reference unclear → EXIT: BLOCKED, ask user
+
+Slop test fails
+  └─ Critical gate (hardcoded color, banned font)
+       └─ EXIT: FAILED — do not ship, rebuild required
+```
+
+---
+
+## Escalation Rules
+
+```
+BLOCKED: DESIGN.md missing or design reference unclear
+Missing:
+  - DESIGN.md with color/spacing/typography tokens
+  - Design reference (Figma/ảnh/wireframe)
+  - For --study: screenshot or public URL
+Questions:
+  1. Bạn có DESIGN.md chưa? (chạy qk-project-bootstrap nếu chưa)
+  2. Design reference là gì? (Figma link / ảnh / mô tả)
+  3. Cho phép tạo DESIGN.md mới không?
+Recommended Assumptions (if proceeding):
+  - Use industry-standard: 8px spacing, Inter font, neutral gray palette
+```
+
+---
+
+## Handoff Contract
+
+### Consumes
+```json
+{
+  "from": "user or qk-orchestrator",
+  "required_fields": ["verb", "design_md_path"],
+  "optional_fields": ["design_reference", "target_component", "api_schema", "framework"]
+}
+```
+
+### Produces
+```json
+{
+  "to": "user or qk-ui-audit (if --audit)",
+  "output_fields": ["component_files", "tokens_used", "states_implemented", "slop_test_result", "exit_code"]
+}
+```
+
+---
+
+## Output Format
+
+### Default (build/edit)
+```
+🎨 UI Builder
+─────────────────────────────────────────────────
+Component:   [ComponentName]
+Theme:       [theme name from references/themes/]
+Macrostructure: [macrostructure name]
+
+States implemented:
+  ✅ Loading / ✅ Success / ✅ Error
+  ✅ Hover / ✅ Focus / ✅ Active / ✅ Disabled
+
+Tokens used:
+  - --color-primary-500, --space-4, --font-size-base
+
+API Mapping:
+  ✅ [endpoint → prop] mapped
+
+Exit Code:   [SUCCESS | PARTIAL | BLOCKED | FAILED]
+```
+
+### `--audit`
+```
+🎨 UI Audit Report
+─────────────────────────────────────────────────
+Component:   [path/to/component]
+Theme:       [N/A — read-only audit]
+
+Scores:
+  P1 Accessibility:  [X/15]
+  P2 Layout:         [X/15]
+  P3 Typography:     [X/15]
+  P4 Interactions:   [X/15]
+  P5 Anti-Slop:      [X/15]
+  P6 Performance:    [X/10]
+  ─────────────────
+  Total:             [X/85] → [PASS ≥ 90% | FAIL < 90%]
+
+Violations (top priority first):
+  [SEVERITY] file:LINE — reason — Fix: suggestion (-Xpts)
+
+Verdict:     [PASS | FAIL — requires redesign]
+Exit Code:   [SUCCESS | PARTIAL | FAILED]
+```
+
+### `--redesign`
+```
+🎨 UI Redesign
+─────────────────────────────────────────────────
+Component:   [ComponentName]
+Old macrostructure: [old name]
+New macrostructure: [new name]
+Old theme:   [old theme]
+New theme:   [new theme]
+
+Kept:
+  - Copy/IA structure
+  - Brand colors
+  - Primary user flow
+
+Changed:
+  - Layout fingerprint
+  - Section ordering
+  - Visual hierarchy
+
+Exit Code:   [SUCCESS | PARTIAL | BLOCKED | FAILED]
+```
+
+### `--study`
+```
+🎨 Design Study
+─────────────────────────────────────────────────
+Source:      [screenshot path | URL]
+DNA extracted:
+  - Macrostructure: [name]
+  - Theme axes: [paper band / display style / accent hue]
+  - Type pairing: [font1 + font2]
+  - Color anchor: [primary / secondary / accent]
+
+Output:      design.md written to [path]
+Next:        ./qk-ui-builder --redesign with extracted DNA
+
+Exit Code:   [SUCCESS | BLOCKED]
+```
+
+---
+
+## Exit Codes
+
+| Code | Meaning | When |
+|------|---------|------|
+| SUCCESS | Build/edit/audit/study completed successfully | All checks passed |
+| PARTIAL | Built with minor gaps or incomplete audit | Budget exhausted or 1-2 fixes pending |
+| BLOCKED | Missing DESIGN.md, design reference, or screenshot | Cannot proceed |
+| FAILED | Slop test critical failure or architectural conflict | Rebuild required |
+
+---
+
+## References
+
+- `references/themes/` — Theme catalog (20 themes)
+- `references/macrostructures/` — 21 page shapes
+- `references/slop-test.md` — 58 anti-slop gates
+- `references/anti-patterns.md` — Named tells to avoid
+
+---
+