ai-deslop 0.5.1 → 0.5.3

package/README.md

@@ -70,6 +70,7 @@ All rules below are enabled by the recommended config unless listed as opt-in.
 
 | Rule | Description |
 | --- | --- |
+| [`max-boolean-conditions`](docs/max-boolean-conditions.md) | Limits top-level terms in `if` and loop conditions. Supports a custom limit and message. No fixer. |
 | [`no-duplicate-consts`](docs/no-duplicate-consts.md) | Reports all-caps constants with the same static value in different files. |
 | [`no-duplicate-types`](docs/no-duplicate-types.md) | Reports exact duplicate object contracts. No fixer. |
 | [`no-pass-through-schema`](docs/no-pass-through-schema.md) | Reports const aliases that only rename known schemas. Supports Zod, ArkType, and configured imports. No fixer. |

package/dist/index.d.ts

@@ -1,5 +1,5 @@
 import { eslintCompatPlugin } from "@oxlint/plugins";
-/** Every `deslop/*` rule, plus selected standard rules, each set to `"error"`. Spread into the `rules` field of an oxlint config. */
+/** Recommended `deslop/*` rules, plus selected standard rules, each set to `"error"`. Spread into the `rules` field of an oxlint config. */
 export declare const recommendedRules: Record<string, "error" | ["error", {
     selector: string;
     message: string;

package/dist/index.js

@@ -26,8 +26,9 @@ import { noDuplicateTypesRule } from "./rules/no-duplicate-types.js";
 import { noDuplicateConstsRule } from "./rules/no-duplicate-consts.js";
 import { noRenamedImportsRule } from "./rules/no-renamed-imports.js";
 import { noReexportsOutsideEntrypointsRule } from "./rules/no-reexports-outside-entrypoints.js";
+import { maxBooleanConditionsRule } from "./rules/max-boolean-conditions.js";
 import { canonicalClassNames } from "./tailwind/rule.js";
-/** Every `deslop/*` rule, plus selected standard rules, each set to `"error"`. Spread into the `rules` field of an oxlint config. */
+/** Recommended `deslop/*` rules, plus selected standard rules, each set to `"error"`. Spread into the `rules` field of an oxlint config. */
 export const recommendedRules = {
     "deslop/no-array-filter-map": "error",
     "deslop/no-reduce-accumulator-copy": "error",
@@ -56,6 +57,8 @@ export const recommendedRules = {
     "typescript/no-floating-promises": "error",
     "typescript/await-thenable": "error",
     "typescript/no-unnecessary-condition": "error",
+    "typescript/switch-exhaustiveness-check": "error",
+    "typescript/no-inferrable-types": "error",
     "no-unreachable": "error",
     "deslop/no-restricted-syntax": [
         "error",
@@ -105,6 +108,7 @@ const deslopPlugin = eslintCompatPlugin({
         "no-duplicate-consts": noDuplicateConstsRule,
         "no-renamed-imports": noRenamedImportsRule,
         "no-reexports-outside-entrypoints": noReexportsOutsideEntrypointsRule,
+        "max-boolean-conditions": maxBooleanConditionsRule,
         // Opt-in: NOT in `recommendedRules`. Requires a `cssPath` option, so users add it manually.
         "canonical-class-names": canonicalClassNames,
     },

package/dist/rules/max-boolean-conditions.d.ts

@@ -0,0 +1,2 @@
+/** Limit top-level Boolean terms in control-flow conditions. */
+export declare const maxBooleanConditionsRule: import("@oxlint/plugins").Rule;

package/dist/rules/max-boolean-conditions.js

@@ -0,0 +1,58 @@
+import { defineRule } from "@oxlint/plugins";
+/** Limit top-level Boolean terms in control-flow conditions. */
+export const maxBooleanConditionsRule = defineRule({
+    meta: {
+        type: "suggestion",
+        docs: { description: "Limit top-level Boolean terms in control-flow conditions" },
+        messages: {
+            tooManyConditions: "This condition has {{count}} top-level terms (maximum {{max}}). Prefer a named variable that describes what these conditions mean.",
+        },
+        schema: [{
+                type: "object",
+                properties: {
+                    maxConditions: { type: "integer", minimum: 1 },
+                    message: { type: "string" },
+                },
+                additionalProperties: false,
+            }],
+    },
+    createOnce(context) {
+        let options;
+        function checkCondition(node) {
+            if (node.test === null)
+                return;
+            const pending = [node.test];
+            let count = 0;
+            while (pending.length > 0) {
+                const term = pending.pop();
+                const isGrouped = term !== node.test
+                    && context.sourceCode.getTokenBefore(term)?.value === "("
+                    && context.sourceCode.getTokenAfter(term)?.value === ")";
+                if (term.type === "LogicalExpression" && term.operator !== "??" && !isGrouped) {
+                    pending.push(term.left, term.right);
+                }
+                else {
+                    count++;
+                }
+            }
+            const max = options.maxConditions ?? 3;
+            if (count <= max)
+                return;
+            if (options.message !== undefined) {
+                context.report({ node: node.test, message: options.message });
+            }
+            else {
+                context.report({ node: node.test, messageId: "tooManyConditions", data: { count, max } });
+            }
+        }
+        return {
+            before() {
+                options = context.options[0] ?? {};
+            },
+            IfStatement: checkCondition,
+            WhileStatement: checkCondition,
+            DoWhileStatement: checkCondition,
+            ForStatement: checkCondition,
+        };
+    },
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ai-deslop",
-  "version": "0.5.1",
+  "version": "0.5.3",
   "description": "Opinionated Oxlint rules that reject low-evidence, low-signal, AI-slop code patterns.",
   "type": "module",
   "main": "./dist/index.js",