ai-consultants 2.25.1 → 2.25.2

package/CLAUDE.md

@@ -6,7 +6,7 @@ AI Consultants is a multi-model AI deliberation system that queries up to 11 AI
 
 **Self-Exclusion**: The invoking agent is automatically excluded from the panel to prevent self-consultation. Claude Code won't query Claude, Codex CLI won't query Codex, etc.
 
-**Version**: 2.25.1
+**Version**: 2.25.2
 
 ## Distribution
 
@@ -801,6 +801,10 @@ curl -fsSL https://raw.githubusercontent.com/matteoscurati/ai-consultants/main/s
 
 ## Changelog
 
+### v2.25.2
+- **`doctor`'s static ✓ was a false all-clear.** `check_cli_consultant` verifies `command -v` (installed) or key-present; neither confirms the consultant answers. So `✓ All systems healthy!` and JSON `status: "healthy"` were printed on installation state alone — a consultant with an expired key or spent quota passes every static check and fails the first real query. Surfaced concretely: static doctor called all 11 healthy; `doctor --live` showed 8/11 (Cursor usage limit, Qwen3 401, Grok bad xAI key returned as HTTP 400). Fix gates the word "healthy" on `LIVE_MODE`: a static-only clean run now prints "Static checks passed: CLIs installed, keys present … verify with doctor --live", and JSON reports `status: "static_ok"` + a new `verified: live|static` field; "healthy" now implies a live check backed it. `test_doctor.sh` asserts the invariant directly (a static-only run must never report `healthy`) rather than pinning a specific status, so it holds regardless of the test host's own consultant health. v2.18.0 added `--live` but left the default over-claiming; this closes that. `npm test` = 22 suites.
+- **Note (not shipped, local only)**: the 3 down consultants were all credentials, not code — Grok/Qwen3 keys refreshed and Cursor disabled in the maintainer's own `~/.config`, taking the local live panel to 10/10 (Cursor off by choice). Qwen locally points at Token Plan `qwen3.8-max-preview`; the shipped default stays `qwen3.7-max`.
+
 ### v2.25.1
 - **Six defects found by an independent review of the released v2.25.0** (Codex `gpt-5.6-sol`, effort high, read-only via the `sol-reviewer` profile). Five were reproduced locally by executing the shipped functions before accepting them; the bash 3.2 crash was verified by the reviewer against `/bin/bash 3.2.57`.
 - **`calculate_final_score` scored every consultant as a dissenter.** `calculate_weighted_recommendation` emitted `_map_sanitize_key`'s output (spaces and punctuation stripped) as the winner, while `calculate_final_score` compared the raw `.response.approach` against it. Unanimous multiword panels scored 2/10, single-word panels 10/10. Voting now keeps original strings in bash 3.2-compatible indexed arrays. **The shipped voting tests used single-word approaches, which is exactly why this survived every prior review** — when writing a voting fixture, use a realistic multiword approach.

package/README.md

@@ -1,8 +1,8 @@
-# AI Consultants v2.25.1
+# AI Consultants v2.25.2
 
 > **A harness for every question.** A panel of up to 11 frontier models that writes its own playbook per question — fan out, debate to convergence, cross-examine under adversarial review, or run a tournament — and checks its work before it reaches you.
 
-[![Version](https://img.shields.io/badge/version-2.25.1-blue.svg)](https://github.com/matteoscurati/ai-consultants)
+[![Version](https://img.shields.io/badge/version-2.25.2-blue.svg)](https://github.com/matteoscurati/ai-consultants)
 [![License](https://img.shields.io/badge/license-MIT-green.svg)](LICENSE)
 [![Claude Code Skill](https://img.shields.io/badge/Claude%20Code-Skill-orange.svg)](https://docs.anthropic.com/en/docs/claude-code/skills)
 [![GitHub stars](https://img.shields.io/github/stars/matteoscurati/ai-consultants?style=social)](https://github.com/matteoscurati/ai-consultants)

package/SKILL.md

@@ -5,10 +5,10 @@ license: MIT
 compatibility: Requires bash, jq, and at least 2 AI CLI tools (agy, codex, vibe, etc.). macOS and Linux.
 metadata:
   author: matteoscurati
-  version: 2.25.1
+  version: 2.25.2
 ---
 
-# AI Consultants v2.25.1 - AI Expert Panel
+# AI Consultants v2.25.2 - AI Expert Panel
 
 **A harness for every question.** Convene a panel of AI "consultants" for coding questions — and let the engine pick *how* they deliberate: a quick read, a convergence loop, an adversarial refutation gate, a tournament, or an exhaustive sweep. Each consultant has a **configurable persona** that shapes its analysis.
 

package/docs/COST_RATES.md

@@ -1,4 +1,4 @@
-# Cost Rates - AI Consultants v2.25.1
+# Cost Rates - AI Consultants v2.25.2
 
 This page documents the per-token rates used by the cost tracking system.
 

package/docs/cost_rates.json

@@ -1,5 +1,5 @@
 {
-  "version": "2.25.1",
+  "version": "2.25.2",
   "updated": "2026-07-16",
   "models": {
     "_comment_units": "All rates are USD per 1,000 tokens (per-1K). lib/costs.sh computes cost as (token_count / 1000) * rate, so every value here MUST be a per-1K rate = (provider $/1M price) / 1000. Do NOT paste $/MTok figures directly.",

package/docs/releases/v2.25.2.md

@@ -0,0 +1,53 @@
+# Release v2.25.2
+
+**Date:** 2026-07-22
+**Type:** Patch — `doctor` stops reporting health it hasn't verified
+**Previous:** v2.25.1
+
+## Highlights
+
+- `doctor` no longer prints "All systems healthy!" when it has only checked that CLIs are installed and keys are present.
+- "healthy" is now reserved for `doctor --live`, which sends a real query.
+- `--json` gains a `verified` field and a `static_ok` status so tooling can tell a real all-clear from an unverified one.
+
+## What's New
+
+### The static all-clear was false
+
+The default `doctor` confirms a consultant's CLI is installed and its key is present. Neither means the consultant can actually answer — a consultant with an expired key or an exhausted quota passes every static check and fails on the first real query.
+
+Measured on a real machine: static `doctor` reported all 11 consultants healthy, while `doctor --live` showed **8 of 11 actually respond** (the other three had a usage limit or a bad key). The static "healthy" gave a false all-clear.
+
+Now:
+
+- A clean static run prints, instead of "All systems healthy!":
+  > `✓ Static checks passed: CLIs installed, keys present.`
+  > `This does NOT confirm consultants can answer — verify with: doctor --live`
+- The word **"healthy" is reserved for a `--live` run** that pinged the consultants for real.
+- `--json` reports `status: "static_ok"` for a clean static run and gains a `verified: "live" | "static"` field. `status: "healthy"` now implies a live check backed it.
+
+`--live` is unchanged, and a plain `doctor` still makes no billed calls.
+
+## Breaking Changes
+
+None in behavior. One output-contract change worth noting for tooling: a clean **static** `doctor --json` now returns `status: "static_ok"` (with `verified: "static"`) instead of `"healthy"`. Consumers that checked for exactly `"healthy"` on a static run should accept `static_ok`, or run `--live` to get `"healthy"`.
+
+## Upgrade Guide
+
+```bash
+# If installed via git clone
+cd ~/.claude/skills/ai-consultants && git pull
+
+# If installed via curl | bash
+curl -fsSL https://raw.githubusercontent.com/matteoscurati/ai-consultants/main/scripts/install.sh | bash
+```
+
+No configuration changes required. To verify your consultants actually respond, run `ai-consultants doctor --live`.
+
+## Verification
+
+`npm test` = 22 suites. `test_doctor.sh` asserts the invariant that a static-only run never reports `healthy`.
+
+## Contributors
+
+- @matteoscurati

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ai-consultants",
-  "version": "2.25.1",
+  "version": "2.25.2",
   "description": "A harness for every question - a panel of up to 11 AI models that picks its own deliberation strategy per question (convergence, adversarial verification, tournament) and checks its work before answering",
   "bin": {
     "ai-consultants": "bin/ai-consultants"

package/scripts/config.sh

@@ -861,4 +861,4 @@ EOF
 # VERSION
 # =============================================================================
 
-AI_CONSULTANTS_VERSION="2.25.1"
+AI_CONSULTANTS_VERSION="2.25.2"

package/scripts/doctor.sh

@@ -637,10 +637,18 @@ print_summary() {
             --argjson issues_list "$issues_json" \
             --argjson warnings_list "$warnings_json" \
             --arg version "$AI_CONSULTANTS_VERSION" \
+            --arg verified "$([[ "$LIVE_MODE" == "true" ]] && echo live || echo static)" \
             '{
                 doctor: {
                     version: $version,
-                    status: (if $issues > 0 then "unhealthy" elif $warnings > 0 then "degraded" else "healthy" end),
+                    # "healthy" requires a live check. Static-only cannot see an
+                    # expired key or exhausted quota, so it reports "static_ok",
+                    # not "healthy". `verified` says which check backs the status.
+                    status: (if $issues > 0 then "unhealthy"
+                             elif $warnings > 0 then "degraded"
+                             elif $verified == "live" then "healthy"
+                             else "static_ok" end),
+                    verified: $verified,
                     checks: {
                         total: $total,
                         passed: $passed,
@@ -686,10 +694,22 @@ print_summary() {
         fi
 
         if [[ ${#ISSUES[@]} -eq 0 && ${#WARNINGS[@]} -eq 0 ]]; then
-            echo "  ✓ All systems healthy!"
+            # Do NOT claim "healthy" on static checks alone: they confirm a CLI is
+            # installed and a key is present, NOT that a consultant can actually
+            # answer. A consultant with an expired key or exhausted quota passes
+            # every static check and fails on the first real query. Only --live,
+            # which sends a real ping, earns the word "healthy".
+            if [[ "$LIVE_MODE" == "true" ]]; then
+                echo "  ✓ All checks passed — consultants verified responding (live)."
+            else
+                echo "  ✓ Static checks passed: CLIs installed, keys present."
+                echo "    This does NOT confirm consultants can answer — an expired key or"
+                echo "    used-up quota passes every static check. Verify with: doctor --live"
+            fi
             echo ""
         elif [[ ${#ISSUES[@]} -eq 0 ]]; then
             echo "  △ System operational with warnings"
+            [[ "$LIVE_MODE" != "true" ]] && echo "    (static only — run 'doctor --live' to confirm consultants answer)"
             echo ""
         else
             echo "  ✗ Issues found - run with --fix to attempt auto-repair"