ai-agent-skills 1.2.1 → 1.2.2

package/cli.js

@@ -202,7 +202,10 @@ function parseArgs(args) {
 
 // ============ SAFE FILE OPERATIONS ============
 
-function copyDir(src, dest, currentSize = { total: 0 }) {
+function copyDir(src, dest, currentSize = { total: 0 }, rootSrc = null) {
+  // Track root source to prevent path escape attacks
+  if (rootSrc === null) rootSrc = src;
+
   try {
     if (fs.existsSync(dest)) {
       fs.rmSync(dest, { recursive: true });
@@ -218,12 +221,25 @@ function copyDir(src, dest, currentSize = { total: 0 }) {
       // Skip unnecessary files/folders
       if (skipList.includes(entry.name)) continue;
 
+      // Skip symlinks to prevent path escape attacks
+      if (entry.isSymbolicLink()) {
+        warn(`Skipping symlink: ${entry.name}`);
+        continue;
+      }
+
       const srcPath = path.join(src, entry.name);
       const destPath = path.join(dest, entry.name);
 
+      // Verify resolved path stays within source directory (prevent path traversal)
+      const resolvedSrc = fs.realpathSync(srcPath);
+      if (!resolvedSrc.startsWith(fs.realpathSync(rootSrc))) {
+        warn(`Skipping file outside source directory: ${entry.name}`);
+        continue;
+      }
+
       if (entry.isDirectory()) {
-        copyDir(srcPath, destPath, currentSize);
-      } else {
+        copyDir(srcPath, destPath, currentSize, rootSrc);
+      } else if (entry.isFile()) {
         const stat = fs.statSync(srcPath);
         currentSize.total += stat.size;
 
@@ -233,6 +249,7 @@ function copyDir(src, dest, currentSize = { total: 0 }) {
 
         fs.copyFileSync(srcPath, destPath);
       }
+      // Skip any other special file types (sockets, devices, etc.)
     }
   } catch (e) {
     // Clean up partial install on failure
@@ -401,7 +418,6 @@ function getInstalledSkills(agent = 'claude') {
 function listInstalledSkills(agent = 'claude') {
   const installed = getInstalledSkills(agent);
   const destDir = AGENT_PATHS[agent] || AGENT_PATHS.claude;
-  const data = loadSkillsJson();
 
   if (installed.length === 0) {
     warn(`No skills installed for ${agent}`);
@@ -412,43 +428,12 @@ function listInstalledSkills(agent = 'claude') {
   log(`\n${colors.bold}Installed Skills${colors.reset} (${installed.length} for ${agent})\n`);
   log(`${colors.dim}Location: ${destDir}${colors.reset}\n`);
 
-  // Check for updates
-  let updatesAvailable = 0;
-
   installed.forEach(name => {
-    const skill = data.skills.find(s => s.name === name);
-    const hasUpdate = skill && skill.lastUpdated && isUpdateAvailable(name, agent, skill.lastUpdated);
-
-    if (hasUpdate) {
-      updatesAvailable++;
-      log(`  ${colors.green}${name}${colors.reset} ${colors.yellow}(update available)${colors.reset}`);
-    } else {
-      log(`  ${colors.green}${name}${colors.reset}`);
-    }
+    log(`  ${colors.green}${name}${colors.reset}`);
   });
 
-  if (updatesAvailable > 0) {
-    log(`\n${colors.yellow}${updatesAvailable} update(s) available.${colors.reset}`);
-    log(`${colors.dim}Run: npx ai-agent-skills update <name> --agent ${agent}${colors.reset}`);
-  }
-
-  log(`\n${colors.dim}Uninstall: npx ai-agent-skills uninstall <name> --agent ${agent}${colors.reset}`);
-}
-
-function isUpdateAvailable(skillName, agent, repoLastUpdated) {
-  // Simple check based on file modification time
-  const destDir = AGENT_PATHS[agent] || AGENT_PATHS.claude;
-  const skillPath = path.join(destDir, skillName, 'SKILL.md');
-
-  try {
-    if (!fs.existsSync(skillPath)) return false;
-    const stat = fs.statSync(skillPath);
-    const installedTime = stat.mtime.getTime();
-    const repoTime = new Date(repoLastUpdated).getTime();
-    return repoTime > installedTime;
-  } catch {
-    return false;
-  }
+  log(`\n${colors.dim}Update:    npx ai-agent-skills update <name> --agent ${agent}${colors.reset}`);
+  log(`${colors.dim}Uninstall: npx ai-agent-skills uninstall <name> --agent ${agent}${colors.reset}`);
 }
 
 function updateSkill(skillName, agent = 'claude', dryRun = false) {
@@ -779,13 +764,23 @@ function isGitHubUrl(source) {
          !source.startsWith('./') &&
          !source.startsWith('../') &&
          !source.startsWith('/') &&
-         !source.startsWith('~');
+         !source.startsWith('~') &&
+         !isWindowsPath(source);
+}
+
+function isWindowsPath(source) {
+  // Match Windows absolute paths like C:\, D:\, etc.
+  return /^[a-zA-Z]:[\\\/]/.test(source);
 }
 
 function isLocalPath(source) {
-  // Only explicit local paths: ./ or / or ~/
-  // NOT ../ (that's path traversal, should be rejected)
-  return source.startsWith('./') || source.startsWith('/') || source.startsWith('~/');
+  // Explicit local paths: ./ or / or ~/ or Windows paths like C:\
+  // Also accept ../ as local path (will be resolved)
+  return source.startsWith('./') ||
+         source.startsWith('../') ||
+         source.startsWith('/') ||
+         source.startsWith('~/') ||
+         isWindowsPath(source);
 }
 
 function expandPath(p) {
@@ -795,8 +790,23 @@ function expandPath(p) {
   return path.resolve(p);
 }
 
+// Validate GitHub owner/repo names (alphanumeric, hyphens, underscores, dots)
+function validateGitHubName(name, type = 'name') {
+  if (!name || typeof name !== 'string') {
+    throw new Error(`Invalid GitHub ${type}`);
+  }
+  // GitHub allows: alphanumeric, hyphens, underscores, dots (no leading/trailing dots for repos)
+  if (!/^[a-zA-Z0-9][a-zA-Z0-9._-]*$/.test(name)) {
+    throw new Error(`Invalid GitHub ${type}: "${name}" contains invalid characters`);
+  }
+  if (name.length > 100) {
+    throw new Error(`GitHub ${type} too long: ${name.length} > 100 characters`);
+  }
+  return true;
+}
+
 async function installFromGitHub(source, agent = 'claude', dryRun = false) {
-  const { execSync } = require('child_process');
+  const { execFileSync } = require('child_process');
 
   // Parse owner/repo format
   const parts = source.split('/');
@@ -809,6 +819,18 @@ async function installFromGitHub(source, agent = 'claude', dryRun = false) {
   const repo = parts[1];
   const skillName = parts[2]; // Optional specific skill
 
+  // Validate owner and repo to prevent injection attacks
+  try {
+    validateGitHubName(owner, 'owner');
+    validateGitHubName(repo, 'repository');
+    if (skillName) {
+      validateSkillName(skillName);
+    }
+  } catch (e) {
+    error(e.message);
+    return false;
+  }
+
   const repoUrl = `https://github.com/${owner}/${repo}.git`;
   const tempDir = path.join(os.tmpdir(), `ai-skills-${Date.now()}`);
 
@@ -822,7 +844,8 @@ async function installFromGitHub(source, agent = 'claude', dryRun = false) {
 
   try {
     info(`Cloning ${owner}/${repo}...`);
-    execSync(`git clone --depth 1 ${repoUrl} ${tempDir}`, { stdio: 'pipe' });
+    // Use execFileSync with args array to prevent shell injection
+    execFileSync('git', ['clone', '--depth', '1', repoUrl, tempDir], { stdio: 'pipe' });
 
     // Find skills in the cloned repo
     const skillsDir = fs.existsSync(path.join(tempDir, 'skills'))
@@ -853,7 +876,17 @@ async function installFromGitHub(source, agent = 'claude', dryRun = false) {
       info(`Location: ${destPath}`);
     } else if (isRootSkill) {
       // Repo itself is a single skill
-      const skillName = repo;
+      // Sanitize repo name to valid skill name (lowercase, alphanumeric + hyphens)
+      const skillName = repo.toLowerCase().replace(/[^a-z0-9-]/g, '-').replace(/-+/g, '-').replace(/^-|-$/g, '');
+
+      try {
+        validateSkillName(skillName);
+      } catch (e) {
+        error(`Cannot install: repo name "${repo}" cannot be converted to valid skill name`);
+        fs.rmSync(tempDir, { recursive: true });
+        return false;
+      }
+
       const destDir = AGENT_PATHS[agent] || AGENT_PATHS.claude;
       const destPath = path.join(destDir, skillName);
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ai-agent-skills",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "description": "Install curated AI agent skills with one command. Works with Claude Code, Cursor, Amp, VS Code, and all Agent Skills compatible tools.",
   "main": "cli.js",
   "bin": {
@@ -8,7 +8,7 @@
     "skills": "./cli.js"
   },
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=14.14.0"
   },
   "scripts": {
     "test": "node test.js",

package/skills.json

@@ -1,5 +1,5 @@
 {
-  "version": "1.2.1",
+  "version": "1.2.2",
   "updated": "2025-12-25T00:00:00Z",
   "total": 39,
   "skills": [

package/.cursor/skills/claude-expert-skill-creator/LICENSE

@@ -1,21 +0,0 @@
-MIT License
-
-Copyright (c) 2025 Vlad-Alexandru Nicolescu
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.

package/.cursor/skills/claude-expert-skill-creator/README.md

@@ -1,188 +0,0 @@
-# create-expert-skill
-
-> Transform expert conversations into production-grade Claude Skills. Whith this enhanced "skill-creator" skill you can capture domain knowledge and system-specific ontologies through structured roleplay. It also packages deterministic scripts alongside flexible guidance, and loads expertise progressively, turning AI assistants into specialists.
-
-## Why This Exists
-
-Anthropic released a basic "skill-creator", however, it doesn't utilize the entire range of what's possible within a Skill. This enhanced skill creator makes use of resources, examples, templates, scripts, progressive disclosure and system architecture knowledge to deliver elaborate skills, zipped and ready to upload.
-
-## Why the "Expert" Part Matters
-
-AI assistants struggle in production for two reasons:
-
-1. **Missing domain expertise** — Generic models don't know or aren't primed with your industry's edge cases, terminology, or unwritten rules.
-2. **Missing ontology understanding** — They don't grasp your specific data structures, entity relationships, or system constraints
-
-This skill solves both by helping you:
-- **Interview experts** (or yourself) to extract implicit domain knowledge
-- **Map system ontologies** — company-specific structures, codes, and relationships
-- **Separate deterministic work** (validation, parsing, math) from flexible interpretation
-- **Load knowledge progressively** — only what's needed, when it's needed
-
-The result: Claude works like a trained specialist who understands both the domain AND your specific systems.
-
-## Installation
-
-### Claude Desktop (Recommended)
-
-The packaged `.zip` file is included in this repository for easy installation:
-
-1. Download `create-expert-skill-v2.2.zip` from this repository
-2. Open Claude Desktop → **Settings** → **Capabilities**
-3. Under Skills, click **Upload Skill**
-4. Drag and drop the `.zip` file (no need to unzip)
-
-### Claude Code
-
-Skills can be installed at user or project level:
-
-**Personal skills** (available in all projects):
-```bash
-# Unzip and copy to your personal skills directory
-unzip create-expert-skill-v2.2.zip -d ~/.claude/skills/
-```
-
-**Project skills** (shared with team via git):
-```bash
-# Unzip into your project's .claude/skills/ directory
-unzip create-expert-skill-v2.2.zip -d ./.claude/skills/
-git add .claude/skills/create-expert-skill
-git commit -m "Add create-expert-skill"
-```
-
-Claude Code automatically discovers skills in these locations.
-
-### Claude Agent SDK
-
-For programmatic usage with the Agent SDK:
-
-1. Create skills directory in your project: `.claude/skills/`
-2. Unzip the skill into that directory
-3. Enable skills in your configuration by adding `"Skill"` to `allowed_tools`
-
-```python
-from claude_agent_sdk import query, ClaudeAgentOptions
-
-options = ClaudeAgentOptions(
-    allowed_tools=["Skill", "Read", "Write", "Bash"],
-    # Skills are auto-discovered from .claude/skills/
-)
-```
-
-See [Agent Skills in the SDK](https://platform.claude.com/docs/en/agent-sdk/skills) for full documentation.
-
-## Usage
-
-Start a conversation:
-> "I want to create a skill for validating LEDES billing files"
-
-Claude guides you through:
-```
-Assess  → Is this worth creating? (3+ uses, consistent procedure)
-Discover → What's the domain expertise? What are the system ontologies?
-Design  → What needs scripts vs guidance vs reference material?
-Create  → Generate the skill
-Refine  → Iterate until complete
-Ship    → Package for deployment
-```
-
-## How It Works
-
-### Two Knowledge Streams
-
-Production-ready skills require BOTH:
-
-**Domain Expertise** — Industry knowledge that applies universally:
-- Standards and their versions (e.g., LEDES 98B vs XML 2.0)
-- Professional conventions and edge cases
-- Validation rules from specifications
-
-**Ontology Understanding** — System-specific structures:
-- Company policies and constraints
-- Entity relationships (timekeepers → IDs → rates)
-- Data format variations unique to your systems
-
-### Progressive Disclosure Architecture
-
-Skills load knowledge in layers, not all at once:
-
-```
-Layer 0 (~25 tokens)   → Description only, always visible
-Layer 1 (~500 tokens)  → Core procedures in SKILL.md, loaded when triggered
-Layer 2 (~1000+ tokens) → Deep reference in resources/, loaded selectively
-```
-
-**Why this matters:** A 2,000-token skill that loads everything wastes context. A layered skill loads 25 tokens until needed, then 500, then more only if required.
-
-### Deterministic Scripts
-
-Anything that can be computed exactly should be:
-
-| Task | Without Script | With Script |
-|------|---------------|-------------|
-| Validate date format | LLM guesses (sometimes wrong) | `python validate.py` (always right) |
-| Sum line items | LLM approximates | Script calculates exactly |
-| Check against schema | LLM interprets | Script returns pass/fail |
-
-Scripts run at **zero token cost** — Claude executes them and uses the output.
-
-### Skill Structure
-
-```
-my-skill/
-├── SKILL.md              # Layer 1: Core procedures (300-500 tokens)
-├── scripts/              # Layer 0: Deterministic automation
-│   └── validate.py
-└── resources/            # Layer 2: Deep reference (loaded selectively)
-    ├── schemas/
-    └── ADVANCED.md
-```
-
-## Token Optimization
-
-| Technique | Before | After | Savings |
-|-----------|--------|-------|---------|
-| Scripts | 500 tokens explaining logic | `python scripts/validate.py` | ~450 |
-| Reference files | Inline schema (200 tokens) | Link to file | ~185 |
-| Layer 2 split | Everything in SKILL.md | Split to resources/ | ~750 |
-
-## Packaging
-
-**This skill includes an automated zipping procedure** In most cases, it runs on its own once the expert skill is finished, returning the plug-and-play .zip of the skill directly in conversation. If this doesn't run automatically, simply ask Claude to deliver the packaged skill.
-
-## Files
-
-```
-create-expert-skill/
-├── SKILL.md                          # Main skill (Layer 1)
-├── README.md                         # This file
-├── LICENSE                           # MIT
-├── create-expert-skill-v2.2.zip      # Ready-to-install package
-├── scripts/
-│   ├── package_skill.py              # Packaging automation
-│   └── README.md
-└── resources/
-    ├── templates/
-    │   └── TEMPLATES.md              # Skill templates (minimal/enhanced/script)
-    └── examples/
-        └── EXAMPLES.md               # Domain patterns (billing, API, schemas)
-```
-
-## Contributing
-
-Found a bug or want to improve the skill?
-- Open an issue for bugs or feature requests
-- PRs welcome for templates, examples, or documentation
-
-## License
-
-MIT — use freely, modify as needed.
-
-## Author
-
-[Vlad-Alexandru Nicolescu](https://github.com/vnicolescu)
-
----
-
-**Version:** 2.2
-**Tested with:** Claude Desktop

package/.cursor/skills/claude-expert-skill-creator/SKILL.md

@@ -1,131 +0,0 @@
----
-name: create-expert-skill
-description: Create production-ready skills from expert knowledge. Extracts domain expertise and system ontologies, uses scripts for deterministic work, loads knowledge progressively. Use when building skills that must work reliably in production.
-version: 2.2
----
-
-# Expert Skill Creation
-
-Transform expert knowledge into production-ready skills that combine domain expertise with system-specific understanding.
-
-## Why Skills Fail in Production
-
-AI assistants fail not because they lack intelligence, but because they lack:
-
-1. **Domain Expertise** — Industry-specific rules, edge cases, unwritten conventions
-2. **Ontology Understanding** — How YOUR systems, data structures, and workflows actually work
-
-**Both are required.** Domain knowledge without system context produces generic output. System knowledge without domain expertise produces structurally correct but semantically wrong results.
-
-## Workflow
-
-```
-Assess → Discover (Expertise + Ontology) → Design → Create → Refine → Ship
-```
-
-## Quick Assessment
-
-**Create a skill when:**
-- Used 3+ times (or will be)
-- Follows consistent procedure
-- Saves >300 tokens per use
-- Requires specialized knowledge not in Claude's training
-- Must produce trusted output (not "close enough")
-
-**Don't create for:** one-time tasks, basic knowledge Claude already has, rapidly changing content.
-
-## Discovery: Two Streams
-
-### Stream 1: Domain Expertise
-
-Deep knowledge that transcends any specific company:
-- Industry standards and their versions
-- Professional conventions and best practices
-- Edge cases only practitioners know
-- Validation rules from specifications
-
-*Example (LEDES validation):* LEDES 98B vs XML 2.0 formats, UTBMS code taxonomy, date format requirements, required vs optional fields.
-
-### Stream 2: Ontology Understanding
-
-How the skill maps to specific systems and organizations:
-- Company-specific policies and constraints
-- Data structures and identifiers unique to the system
-- Cross-references between entities (timekeepers → IDs → rates)
-- Workflow states and transitions
-
-*Example (LEDES validation):* Firm-specific timekeeper codes, matter numbering conventions, approved billing rates, outside counsel guideline requirements.
-
-### Discovery Questions
-
-When starting, I'll ask about:
-1. **Domain & Purpose** — What problem? What industry standards apply?
-2. **Ontology Requirements** — What system-specific structures must the skill understand?
-3. **Content Source** — Conversation, docs, specifications, or files to distill from?
-4. **Automation Potential** — What can be deterministic (scripts)? What needs interpretation (LLM)?
-5. **Complexity Level** — Simple (SKILL.md only), Enhanced (+scripts), or Full (+resources)?
-
-## Skill Architecture
-
-```
-skill-name/
-├── SKILL.md              # Layer 1: Core (300-500 tokens)
-├── scripts/              # Layer 0: Automation (0 tokens to run)
-│   └── validate.py
-└── resources/            # Layer 2: Details (loaded selectively)
-    └── ADVANCED.md
-```
-
-**Layer 0** (Scripts): Free execution, structured JSON output
-**Layer 1** (SKILL.md): Loaded when triggered - keep lean
-**Layer 2** (Resources): Fetched only when specific section needed
-
-## Token Optimization
-
-| Technique | Instead of | Do this | Savings |
-|-----------|-----------|---------|---------|
-| Scripts | 500 tokens explaining validation | `python scripts/validate.py` | ~450 tokens |
-| Reference | Inline schema (200 tokens) | Link to `resources/schema.json` | ~185 tokens |
-| Layer 2 | Everything in SKILL.md | Link to `resources/ADVANCED.md` | ~750 tokens |
-
-## Description Formula
-
-`<Action> <Object> for <Purpose>. Use when <Trigger>.`
-
-Example: "Validate billing data for system migration. Use before importing invoices."
-
-## Shipping
-
-When content is finalized:
-
-```bash
-python scripts/package_skill.py skill-name 1.0
-```
-
-Creates `skill-name-v1.0.zip` with:
-- DIRECTORY_STRUCTURE.txt (auto-generated)
-- README.md with deployment instructions
-- All skill files properly organized
-
-## Templates & Examples
-
-See `resources/templates/` for:
-- Minimal skill template
-- Enhanced skill template  
-- Script template
-
-See `resources/examples/` for domain-specific patterns.
-
-## Quality Checklist
-
-Before shipping:
-- [ ] Description <30 tokens
-- [ ] SKILL.md <500 tokens (Layer 1)
-- [ ] Scripts for deterministic operations
-- [ ] Advanced content in resources/ (Layer 2)
-- [ ] Version in frontmatter
-- [ ] All referenced files exist
-
----
-
-**Version:** 2.2 | **Target:** <500 tokens Layer 1