agy-squad 0.0.0-stage → 0.1.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.agents/skills/full-review/SKILL.md +89 -0
- package/.agents/skills/full-review/references/evidence-intake.md +146 -0
- package/.agents/skills/full-review/references/report-template.md +216 -0
- package/.agents/skills/full-review/references/review-roles.md +91 -0
- package/.agents/skills/pr-review/SKILL.md +60 -0
- package/.agents/skills/pr-review/references/pr-review-standard.md +163 -0
- package/.agents/skills/self-diagnosis/SKILL.md +63 -0
- package/.agents/skills/self-diagnosis/references/execution-and-teardown.md +71 -0
- package/.agents/skills/self-diagnosis/references/optimization-and-review-rubric.md +61 -0
- package/.agents/skills/self-diagnosis/resources/comparative-research-manifest.json +42 -0
- package/.agents/skills/self-diagnosis/resources/self-diagnosis-manifest.json +144 -0
- package/.agents/skills/self-diagnosis/scripts/diagnose.mjs +1971 -0
- package/.agents/skills/swarm-governance/SKILL.md +59 -0
- package/.agents/skills/swarm-governance/references/bundling-and-wire-format.md +88 -0
- package/.agents/skills/swarm-governance/references/intake-and-planning.md +120 -0
- package/.agents/skills/swarm-governance/references/large-swarms.md +39 -0
- package/CHANGELOG.md +16 -0
- package/LICENSE +21 -0
- package/README.md +156 -2
- package/bin/agy-squad.mjs +293 -0
- package/docs/assets/architecture-overview.svg +39 -0
- package/docs/assets/manifest-and-modes.svg +39 -0
- package/docs/assets/role-and-verdict-gate.svg +39 -0
- package/docs/assets/skill-role-workflows.svg +39 -0
- package/docs/assets/swarm-lifecycle.svg +39 -0
- package/docs/benchmarks.md +102 -0
- package/docs/concepts.md +81 -0
- package/docs/core-workflows.md +128 -0
- package/docs/getting-started.md +116 -0
- package/docs/index.md +47 -0
- package/docs/plans/LEDGER.md +24 -0
- package/docs/plans/comparative-harness-architecture-retest.md +1174 -0
- package/docs/plans/comparative-harness-architecture-teamwork.md +1170 -0
- package/docs/plans/comparative-harness-architecture.md +256 -0
- package/docs/plans/native-enforcement-ledger.md +126 -0
- package/docs/plans/pr3-option-b-fixes.md +803 -0
- package/docs/plans/wsl-cli-verification.md +55 -0
- package/docs/reviews/post-pr5-governance-review.md +221 -0
- package/docs/reviews/pr1-code-review-ledger.md +581 -0
- package/docs/reviews/pr1-production-readiness-review.md +764 -0
- package/docs/reviews/pr2-documentation-review-ledger.md +380 -0
- package/docs/reviews/pr3-squad-alignment-full-review.md +1021 -0
- package/docs/reviews/pr4-swarm-governance-pivot-review.md +593 -0
- package/docs/reviews/pr5-full-review-direction.md +330 -0
- package/docs/reviews/pr5-independent-review.md +266 -0
- package/docs/reviews/pr5-layered-swarm-review.md +513 -0
- package/docs/reviews/pr5-phase2-swarm-planner-review.md +470 -0
- package/docs/reviews/pr5-reconciled-review.md +573 -0
- package/docs/reviews/rebuild-wsl-dispatch-review-r2.md +427 -0
- package/docs/reviews/rebuild-wsl-dispatch-review.md +552 -0
- package/docs/roles-and-workflows.md +115 -0
- package/docs/stopping-agents.md +39 -0
- package/docs/tools.md +122 -0
- package/install.ps1 +5 -0
- package/install.sh +4 -0
- package/mcp/briefs.mjs +202 -0
- package/mcp/dispatch.mjs +280 -0
- package/mcp/handoffs.mjs +814 -0
- package/mcp/index.js +322 -0
- package/mcp/planner.mjs +755 -0
- package/mcp/verdicts.mjs +224 -0
- package/package.json +57 -4
- package/plugin.json +20 -0
- package/scripts/install-register.mjs +510 -0
- package/scripts/release-preflight.mjs +142 -0
|
@@ -0,0 +1,427 @@
|
|
|
1
|
+
# Agy-Squad PR Review Report (Follow-Up Re-Review & `/self-diagnosis` Ledger — R2..R5)
|
|
2
|
+
|
|
3
|
+
## 1. Review Metadata, Session Provenance, and Evidence Limits
|
|
4
|
+
|
|
5
|
+
- **Repository:** `/home/paragon-ux/Antigravity/Agy-Squad` (`paragon-ux/Agy-Squad` — https://github.com/paragon-ux/Agy-Squad)
|
|
6
|
+
- **PR URL:** https://github.com/paragon-ux/Agy-Squad/pull/1 (`rebuild/wsl-dispatch` -> `main`)
|
|
7
|
+
- **Review Date:** `2026-11-08`
|
|
8
|
+
- **Reviewer:** Antigravity (`pr-review` + `self-diagnosis` skills)
|
|
9
|
+
- **Standard Version:** `1.3.0` ([pr-review-standard.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/pr-review/references/pr-review-standard.md); established `1.1.0` in R1/R2, bumped to `1.2.0` in Wave R5, and formalized to `1.3.0` for `1 ID = 1 Row`, Session Provenance, Section 8 Residuals/Deferred, and Section 9 Cohort Ledger)
|
|
10
|
+
- **Base Ref / Merge Base SHA:** `main` — `ee10ebc255f0d52dc93b51d7cf8198bb069c4532`
|
|
11
|
+
- **Current Branch Head SHA + Working-Tree State:** `2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5` (`fix(self-diagnosis): prefer highest -r<N> review revision on fresh checkout`, parent `130a526086ef6a2d85d69a6176f7216e4f6dce85`; clean code tree — only this canonical review ledger `docs/reviews/rebuild-wsl-dispatch-review-r2.md` is updated in the final review commit).
|
|
12
|
+
- **Previous Reviews & External Artifacts Reconciled:**
|
|
13
|
+
- **R1 Review:** [rebuild-wsl-dispatch-review.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/docs/reviews/rebuild-wsl-dispatch-review.md) (`https://github.com/paragon-ux/Agy-Squad/pull/1#issuecomment-6719916015`, head `6d6ad31a9054a41ca5563b05dfff02ecdcf724d7`, *Request changes*: `2` P1, `10` P2, `1` P3, `2` gaps).
|
|
14
|
+
- **External Devin Artifacts:** `/home/paragon-ux/Antigravity/artifacts/devin-agy-squad-bugs-and-flags.md` (`RUN-003`, `SVC-003`, `RUN-004`, `SCRIPT-GAP-002`, `TEST-GAP-001`) and `/home/paragon-ux/Antigravity/artifacts/devin-agy-squad-issue-ledger.md`.
|
|
15
|
+
- **R6 Consolidation, Remediation & Reverification Ledgers:** [pr1-code-review-ledger.md](./pr1-code-review-ledger.md) (PR #1 R6 Devin + ChatGPT audit consolidation, remediation, and reverification) and [pr2-documentation-review-ledger.md](./pr2-documentation-review-ledger.md) (merged PR #2 documentation and benchmark consolidation ledger).
|
|
16
|
+
|
|
17
|
+
### Session Provenance
|
|
18
|
+
|
|
19
|
+
| Session # | Operator Conversation ID | Parent Session | Date | Base..Head + Working-Tree State | Skill / Topology Invoked |
|
|
20
|
+
| --- | --- | --- | --- | --- | --- |
|
|
21
|
+
| `S1 (R1)` | `Unrecorded (pre-v1.3.0; committed in e1fdb00)` | `None` | `2026-11-08` | `ee10ebc..6d6ad31` (clean) | `/pr-review` (`v1.1.0` initial PR #1 review) |
|
|
22
|
+
| `S2 (R2)` | `Unrecorded (pre-v1.3.0; child 1e211e57-a046-4b5a-8fdf-46a2dcd8a083)` | `None` | `2026-11-08` | `ee10ebc..45a66d1` + R2 Devin remediation delta | `/pr-review` (`v1.1.0` R2 re-review + 1-specialist live trial `live_pow_r2`) |
|
|
23
|
+
| `S3 (R3–R5)` | [`944c64a0-e4c9-4272-a701-e3a32108a31b`](conversation://944c64a0-e4c9-4272-a701-e3a32108a31b) | `None (primary operator thread)` | `2026-11-08` | `ee10ebc..2bdff1a` (clean code tree across `2b284f4..2bdff1a` + `/teamwork` A/B benchmark) | `/self-diagnosis` (`all_specialists` Wave R3 -> `all_l1` Waves R4 & R5) + `/pr-review` (`v1.2.0` -> `v1.3.0`) |
|
|
24
|
+
| `S3a (Side Audit)` | `ba959810-...` (read-only `/btw` side consultation) | [`944c64a0-e4c9-4272-a701-e3a32108a31b`](conversation://944c64a0-e4c9-4272-a701-e3a32108a31b) | `2026-11-08` | `ee10ebc..90485b2` + Wave R5 working-tree delta (no writes) | Design audit (`v1.3.0` `1 ID = 1 Row`, Section 8 Residuals, Section 9 Cohort Ledger) |
|
|
25
|
+
| `S4 (R6)` | [`944c64a0-e4c9-4272-a701-e3a32108a31b`](conversation://944c64a0-e4c9-4272-a701-e3a32108a31b) | `None (primary operator thread)` | `2026-11-09` | `ee10ebc..3df852b` + R6 PR1 remediation (`R6-SVC-01`, `R6-MCP-01`, `R6-MCP-02`, `R6-SCRIPT-01`, `R6-SVC-02`, `R6-TEST-01`, `R6-DOC-01`) | PR2/PR1 consolidation (`pr2-documentation-review-ledger.md` -> `pr1-code-review-ledger.md`) + flat specialist squad + `/self-diagnosis` reverification |
|
|
26
|
+
|
|
27
|
+
### Commit History Examined (`ee10ebc255f0d52dc93b51d7cf8198bb069c4532..2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5`)
|
|
28
|
+
1. `6d6ad31a9054a41ca5563b05dfff02ecdcf724d7` — `feat(wsl): rebuild staged squad dispatch and managed CLI launcher for WSL` (R1 head)
|
|
29
|
+
2. `e1fdb003b52e56b7c61afe8db228d3e0f5ca3f2c` — `docs(review): add PR #1 review report for rebuild/wsl-dispatch (ee10ebc..6d6ad31)`
|
|
30
|
+
3. `281c04ab2cb342f4e9ed754a1e08dae7673bb688` — `fix: remediate PR #1 review findings across dispatch, handoffs, MCP server, launcher, and docs` (GitHub merge commit `d718d7d219ce7c8682553ef6f88037c837c58ba7` tested in CI runs [`42468601060`](https://github.com/paragon-ux/Agy-Squad/actions/runs/42468601060), [`42468598397`](https://github.com/paragon-ux/Agy-Squad/actions/runs/42468598397), [`42468601065`](https://github.com/paragon-ux/Agy-Squad/actions/runs/42468601065), [`42468598360`](https://github.com/paragon-ux/Agy-Squad/actions/runs/42468598360))
|
|
31
|
+
4. `45a66d1ee720194c1b5416003ae819dcbed886ff` — `docs(review): add R2 follow-up review report closing all PR #1 findings (281c04a)`
|
|
32
|
+
5. `2b284f45d5750b6dab7e187de3f5ecdd78b4a3c3` — `fix(runtime): harden dispatch/handoff boundaries, launcher cleanup, and brief/IO hot paths`
|
|
33
|
+
6. `9776bbe30fdd654e6c2a1cf875ccc06eb72182f1` — `docs(contracts): align pr-review skill, tools reference, and LEDGER L41 with WSL runtime`
|
|
34
|
+
7. `90485b25a7272d4c65dcef183d0cb7ba5277f77b` — `feat(skills): add self-diagnosis skill with L41 teardown and multi-topology profiler`
|
|
35
|
+
8. `771b5d49c384f82dd80626dca0f50f7b508c998c` — `fix(runtime): harden lead/handoff validation, PTY wakeup, and stage/IO hot paths`
|
|
36
|
+
9. `9f9552df217ee92a3d08c4ccd652c3f8f006319d` — `feat(skills): enforce PR Review Standard v1.3.0 schema, ledger gate, and CLI/PTY tests`
|
|
37
|
+
10. `969a1b83acd1b5a8a498fdb4ac15fdd073889733` — `docs(review): normalize PR #1 R2..R5 review ledger to Standard v1.3.0`
|
|
38
|
+
11. `5b5ba4eb048de22ae6aaef90eab49773bd678288` — `fix(cli,docs): align makeProfile with Agy-Context-Saver and record /teamwork A/B benchmark`
|
|
39
|
+
12. `130a526086ef6a2d85d69a6176f7216e4f6dce85` — `docs(review): record Agy-Context-Saver integration and /teamwork A/B benchmark in PR #1 ledger`
|
|
40
|
+
13. `2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5` — `fix(self-diagnosis): prefer highest -r<N> review revision on fresh checkout`
|
|
41
|
+
|
|
42
|
+
### Evidence Available & Limits
|
|
43
|
+
- **Available:** Full git history `ee10ebc..2bdff1a`, [LEDGER.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/docs/plans/LEDGER.md), [wsl-cli-verification.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/docs/plans/wsl-cli-verification.md), R1 report, both Devin review artifacts, local WSL Node `v22.19.0` + Python `3.12` execution (`npm test`, `npm pack --dry-run --json`, `diagnose.mjs`), GitHub Actions CI logs at `281c04a`, 1-specialist live subagent trial (`1e211e57-...`), 6-specialist Flat Full Squad live pass + re-verify (Wave R3), and two 3-lead / 6-specialist Layered Full Squad live passes + same-squad re-verification (Waves R4 & R5).
|
|
44
|
+
- **Unavailable / Excluded:** Live multi-minute `agy chat` TUI launch via `bin/agy-squad.mjs --launch` against real quota-consuming `agy` CLI (`L7` keeps `npm test` subagent-free; `bin/terminal.py` PTY handshake is verified via deterministic Python PTY harnesses and tracked as non-blocking `SCRIPT-GAP-002`). External sibling repo `Agy-Context-Saver` (`L13–L15, L25–L27, L32–L34`) is out of scope.
|
|
45
|
+
|
|
46
|
+
---
|
|
47
|
+
|
|
48
|
+
## 2. File-to-Category Inventory and Coverage Matrix
|
|
49
|
+
|
|
50
|
+
### Changed-File Inventory (`ee10ebc..2bdff1a`)
|
|
51
|
+
|
|
52
|
+
| Path | Net Branch Status (`ee10ebc..2bdff1a`) | Primary Category | Cross-Referenced Categories | Review Status |
|
|
53
|
+
| --- | --- | --- | --- | --- |
|
|
54
|
+
| `docs/plans/LEDGER.md` | Modified (`L1`–`L41` reconciled) | `ARCH` | `DOC`, `SVC`, `RUN` | Reviewed & Rechecked (R1–R5) |
|
|
55
|
+
| `docs/plans/docker-sandbox-plan.md` | Deleted | `ARCH` | `DOC` | Reviewed |
|
|
56
|
+
| `docs/plans/wsl-cli-verification.md` | Added & Updated | `DOC` | `ARCH`, `TEST`, `SCRIPT` | Reviewed & Rechecked |
|
|
57
|
+
| `README.md` | Modified | `DOC` | `ARCH`, `DEP`, `TEST` | Reviewed |
|
|
58
|
+
| `docs/index.md` | Modified | `DOC` | `DEP` | Reviewed |
|
|
59
|
+
| `docs/tools.md` | Modified (Wave R5 contract parity) | `DOC` | `MCP`, `RUN`, `SVC` | Reviewed & Rechecked (R1–R5) |
|
|
60
|
+
| `docs/stopping-agents.md` | Modified | `DOC` | `SVC`, `SCRIPT` | Reviewed |
|
|
61
|
+
| `docs/architecture.md`, `docs/configuration.md`, `docs/getting-started.md`, `docs/troubleshooting.md` | Deleted (`4` legacy docs) | `DOC` | `ARCH`, `DEP`, `MCP` | Reviewed |
|
|
62
|
+
| `docs/reviews/rebuild-wsl-dispatch-review.md` | Added (`e1fdb00`) | `DOC` | `SKILL` | Retained R1 Record |
|
|
63
|
+
| `docs/reviews/rebuild-wsl-dispatch-review-r2.md` | Added (`45a66d1`) & Normalized (`v1.3.0`) | `DOC` | `SKILL`, `SVC` | Active Canonical PR Review Ledger |
|
|
64
|
+
| `skills/agy-squad/SKILL.md` | Deleted (legacy skill) | `SKILL` | `ARCH`, `MCP` | Reviewed |
|
|
65
|
+
| `.agents/skills/pr-review/SKILL.md` | Added & Updated (`v1.3.0`) | `SKILL` | `DOC`, `ARCH` | Reviewed & Rechecked (R3–R5) |
|
|
66
|
+
| `.agents/skills/pr-review/references/pr-review-standard.md` | Added & Updated (`v1.3.0`) | `SKILL` | `ARCH`, `DOC` | Reviewed & Rechecked (R3–R5) |
|
|
67
|
+
| `.agents/skills/self-diagnosis/SKILL.md` | Added (`90485b2`) & Updated (`v1.3.0`) | `SKILL` | `DOC`, `SVC`, `RUN` | Reviewed & Rechecked (R3–R5) |
|
|
68
|
+
| `.agents/skills/self-diagnosis/references/optimization-and-review-rubric.md` | Added (`90485b2`) & Updated (`v1.3.0`) | `DOC` | `SKILL`, `RUN`, `SVC` | Reviewed & Rechecked (R3–R5) |
|
|
69
|
+
| `.agents/skills/self-diagnosis/resources/self-diagnosis-manifest.json` | Added (`90485b2`) & Updated | `SKILL` | `RUN`, `SVC` | Reviewed & Rechecked (R3–R5) |
|
|
70
|
+
| `.agents/skills/self-diagnosis/scripts/diagnose.mjs` | Added (`90485b2`) & Updated (`v1.3.0`) | `SCRIPT` | `SKILL`, `DOC`, `SVC`, `RUN` | Reviewed & Rechecked (R3–R5) |
|
|
71
|
+
| `mcp/index.js` | Modified (JSON-RPC `2.0`, lazy `agentSchema`) | `MCP` | `RUN`, `SVC` | Reviewed & Rechecked (R1–R5) |
|
|
72
|
+
| `mcp/dispatch.mjs` | Modified (`resolveSquadLead`, `alreadyStaged`) | `RUN` | `MCP`, `SVC`, `ARCH` | Reviewed & Rechecked (R1–R5) |
|
|
73
|
+
| `mcp/briefs.mjs` | Modified (`TypeName`, `Workspace`, `scopeFiles`, case aliases) | `RUN` | `SKILL`, `DOC`, `MCP`, `ARCH` | Reviewed & Rechecked (R1–R5) |
|
|
74
|
+
| `mcp/handoffs.mjs` | Added & Hardened (`readSynthesis`, `verifiedDirs`, CLI `realpathSync`) | `SVC` | `RUN`, `ARCH`, `SCRIPT` | Reviewed & Rechecked (R1–R5) |
|
|
75
|
+
| `mcp/run-state.mjs` | Added & Hardened (`\` guard, `skipManifestPublish`) | `SVC` | `RUN`, `DB` | Reviewed & Rechecked (R1–R5) |
|
|
76
|
+
| `bin/agy-squad.mjs` | Added & Hardened (`hasEvidence`, `requireBinary`, `seenDirs`) | `SVC` | `SKILL`, `DEP`, `SCRIPT`, `ARCH` | Reviewed & Rechecked (R1–R5) |
|
|
77
|
+
| `bin/terminal.py` | Added & Hardened (`submitted` gate, `SIG_DFL`, pipe-woken `SIGKILL` escalation) | `SCRIPT` | `SVC`, `RUN`, `TEST` | Reviewed & Rechecked (R1–R5) |
|
|
78
|
+
| `tests/legacy/test-security-canary-re-trial.mjs`, `tests/test-briefs.mjs` | Deleted (`2` superseded suites) | `TEST` | `ARCH`, `RUN` | Reviewed |
|
|
79
|
+
| `tests/test-dispatch.mjs`, `tests/test-handoffs.mjs`, `tests/test-run.mjs`, `tests/test-server.mjs` | Modified / Added (`4` active suites) | `TEST` | `RUN`, `SVC`, `MCP`, `SCRIPT`, `SKILL` | Reviewed & Rechecked (R1–R5) |
|
|
80
|
+
| `.github/workflows/ci.yml` | Added | `TEST` | `DEP` | Reviewed |
|
|
81
|
+
| `.github/workflows/docs.yml`, `package.json`, `zensical.toml`, `.gitignore` | Modified (`4` packaging/config files) | `DEP` | `DOC`, `TEST`, `SVC` | Reviewed & Rechecked |
|
|
82
|
+
|
|
83
|
+
*Unchanged dependency examined:* `LICENSE` (`ISC` metadata -> `DEP`).
|
|
84
|
+
|
|
85
|
+
### Category Coverage Matrix
|
|
86
|
+
|
|
87
|
+
| Category ID | Category Name | Coverage | Open P1 | Open P2 | Residual Open P3 (Sec. 8) | Closed Across R1–R5 | Open Gaps | Category Verdict |
|
|
88
|
+
| --- | --- | --- | ---: | ---: | ---: | ---: | ---: | --- |
|
|
89
|
+
| `ARCH` | Architecture and contracts | `Complete` | `0` | `0` | `0` | `2` | `0` | **No findings within reviewed scope** |
|
|
90
|
+
| `DOC` | Documentation and change records | `Complete` | `0` | `0` | `0` | `8` | `0` | **No findings within reviewed scope** |
|
|
91
|
+
| `SKILL` | Skills and agent instructions | `Complete` | `0` | `0` | `0` | `12` | `0` | **No findings within reviewed scope** |
|
|
92
|
+
| `MCP` | MCP schemas and public API | `Complete` | `0` | `0` | `0` | `7` | `0` | **No findings within reviewed scope** |
|
|
93
|
+
| `RUN` | Core runtime, parsing, and validation | `Complete` | `0` | `0` | `0` | `12` | `0` | **No findings within reviewed scope** |
|
|
94
|
+
| `SVC` | Services, orchestration, and audit semantics | `Complete` | `0` | `0` | `0` | `16` | `0` | **No findings within reviewed scope** |
|
|
95
|
+
| `DB` | Database, migrations, replay, and concurrency | `Complete` (`N/A`) | `0` | `0` | `0` | `0` | `0` | **Not applicable** |
|
|
96
|
+
| `SCRIPT` | Scripts, evaluation, and developer tooling | `Complete` | `0` | `0` | `0` | `16` | `1` (`SCRIPT-GAP-002`) | **No findings within reviewed scope** |
|
|
97
|
+
| `TEST` | Tests and CI | `Complete` | `0` | `0` | `0` | `7` | `0` | **No findings within reviewed scope** |
|
|
98
|
+
| `DEP` | Dependencies, packaging, and configuration | `Complete` | `0` | `0` | `0` | `2` | `0` | **No findings within reviewed scope** |
|
|
99
|
+
|
|
100
|
+
---
|
|
101
|
+
|
|
102
|
+
## 3. Architecture-to-Implementation Trace
|
|
103
|
+
|
|
104
|
+
1. **Native Subagent Compilation & Preset Capabilities (`L3, L5, L6, L18, L19, L31`):** [`manifestSquads`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/dispatch.mjs#L43-L55) and [`resolveSquadLead`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/dispatch.mjs#L89-L170) reject reserved `"all_l1"`, mixed inline/`lead` definitions, and `children`+`specialists` conflicts across unmanaged and managed runs; [`buildSubagentSpec`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/briefs.mjs#L15-L115) enforces `TypeName !== "research"` (default `"self"`), `Workspace === "inherit"`, workspace-relative `scopeFiles`, and camelCase/PascalCase conflict rejection.
|
|
105
|
+
2. **Pointer-Over-Wire Receipts, Synthesis Verification & Bundle Integrity (`L1, L2, L29, L30`):** [`reconcileHandoffs`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/handoffs.mjs#L7-L56) enforces single-line `<= 500` UTF-8 byte `READY`/`PARTIAL`/`NO_REPORT` grammar (rejecting `\r`, `\n`, `\u2028`, `\u2029`); [`readSynthesis`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/handoffs.mjs#L193-L214) strips ```` ``` ````/`~~~` fences and CommonMark arbitrary-length backtick spans before requiring unambiguous `PASS` (`(?![-\w])`); `bundleReports`/`verifyBundle`/`pruneReports` enforce SHA-256 provenance before deleting loose specialist reports.
|
|
106
|
+
3. **Workspace & Descriptor Containment (`L1, L2, L17, L21, L40`):** [`readWorkspaceJson`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/dispatch.mjs#L21-L36) resolves intra-workspace manifest symlinks via `realpathSync` + `O_NOFOLLOW`/`O_NONBLOCK` + `/proc/self/fd/${fd}`; [`workspacePath`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/handoffs.mjs#L92-L112) and [`ensureDirectory`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/run-state.mjs#L6-L32) reject `\` separators and symlinks for reports/bundles; [`runSession`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/bin/agy-squad.mjs#L140-L152) deny-lists `write_file`/`edit_file` on pre-staged `manifest.json`.
|
|
107
|
+
4. **Managed WSL Launcher & PTY Handshake (`L7, L17`):** [`agy-squad.mjs`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/bin/agy-squad.mjs) validates binaries upfront, isolates `AGY_SQUAD_RUN_DIR`/`AGY_SQUAD_SESSION`, retains mutated profiles, and cleans up empty/failed run directories; [`terminal.py`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/bin/terminal.py) gates `stdin` forwarding on `submitted`, preserves pre-submission `\x03` `SIGINT`, resets child signal handlers to `SIG_DFL`, and escalates `SIGTERM -> SIGKILL` on shutdown.
|
|
108
|
+
5. **Self-Diagnosis Teardown & Durable Review Ledger Gate (`L7, L41`, Standard `v1.3.0`):** [`diagnose.mjs`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/scripts/diagnose.mjs) enforces `DOC-LEDGER-MISSING` / `DOC-LEDGER-SCHEMA` (`1 ID = 1 Row`, Section 1 Session Provenance, Section 8 Residuals/Deferred, Section 9 Cohort Ledger) and atomic 2-pass `teardownSelfDiagnosisDirs` (`L41`) before removing `scratch/agy-squad/squad-*` slots.
|
|
109
|
+
|
|
110
|
+
---
|
|
111
|
+
|
|
112
|
+
## 4. Category Sections
|
|
113
|
+
|
|
114
|
+
*(R1 findings rechecked in R2 retain full 10-field records in [rebuild-wsl-dispatch-review.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/docs/reviews/rebuild-wsl-dispatch-review.md); R2 Devin `P1` defects appear below; Wave R3–R5 `P1`/`P2` 10-field records appear in Section 9.2.1; post-remediation `Residual (Open)` and `Deferred` `P3`s appear in Section 8.)*
|
|
115
|
+
|
|
116
|
+
### 4.1 `ARCH` — Architecture and Contracts
|
|
117
|
+
1. **Scope:** [LEDGER.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/docs/plans/LEDGER.md), deleted `docs/plans/docker-sandbox-plan.md`, plus boundary hooks in `bin/agy-squad.mjs`, `mcp/dispatch.mjs`, `mcp/briefs.mjs`, and `mcp/handoffs.mjs`.
|
|
118
|
+
2. **Coverage:** `Complete` across `L1`–`L41`.
|
|
119
|
+
3. **P1 — high priority:** None identified within reviewed scope.
|
|
120
|
+
4. **P2 — medium priority:** None open (`2` closed: `ARCH-001` in `281c04a`; `R5-ARCH-P2-1` in Wave R5, see Section 9.2.1).
|
|
121
|
+
5. **P3 — low priority:** None identified within reviewed scope.
|
|
122
|
+
6. **Verification:** Executed [test-run.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-run.mjs) and [test-dispatch.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-dispatch.mjs); CI runs `42468601060`, `42468598397`; zero verification gaps.
|
|
123
|
+
7. **Verdict:** **No findings within reviewed scope**
|
|
124
|
+
- **Rechecked R1 Closure — `ARCH-001` (`P2`, `Closed` in `281c04a`):** Pre-staged `manifest.json` write/edit deny rules added in [`runSession`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/bin/agy-squad.mjs#L140-L152) and `L1, L2` receipt-vs-host boundary documented in [LEDGER.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/docs/plans/LEDGER.md#L7).
|
|
125
|
+
|
|
126
|
+
### 4.2 `DOC` — Documentation and Change Records
|
|
127
|
+
1. **Scope:** [README.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/README.md), [docs/index.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/docs/index.md), [docs/tools.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/docs/tools.md), [docs/stopping-agents.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/docs/stopping-agents.md), [wsl-cli-verification.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/docs/plans/wsl-cli-verification.md), [optimization-and-review-rubric.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/references/optimization-and-review-rubric.md), active review ledgers, and `4` deleted legacy docs.
|
|
128
|
+
2. **Coverage:** `Complete` across all active/deleted docs and Zensical config.
|
|
129
|
+
3. **P1 — high priority:** None identified within reviewed scope.
|
|
130
|
+
4. **P2 — medium priority:** None open (`3` closed: `DOC-001` in `281c04a`; `R5-DOC-P2-1`, `R5-DOC-P2-2` in Wave R5, see Section 9.2.1).
|
|
131
|
+
5. **P3 — low priority:** None open (`5` closed: `DOC-002` in `281c04a`, `R3-DOC-001`, `R3-DOC-002`, `R4-DOC-P3-1` in Section 9.2.2, `SD-R5-DOC-01` `Closed (Post-Remediation)` in Section 8; `1` `Deferred / Won't Fix`: `SD-OPT-03` in Section 8).
|
|
132
|
+
6. **Verification:** Zensical build verified in CI runs `42468601065` & `42468598360`; `diagnose.mjs` link & ledger schema checks executed locally; zero verification gaps.
|
|
133
|
+
7. **Verdict:** **No findings within reviewed scope**
|
|
134
|
+
- **Rechecked R1 Closures:** `DOC-001` (`P2`, `Closed` in `281c04a` — restored `L10, L12, L17, L30` in [LEDGER.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/docs/plans/LEDGER.md#L13-L19)); `DOC-002` (`P3`, `Closed` in `281c04a` — documented `manifest` parameter in [docs/tools.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/docs/tools.md#L9)).
|
|
135
|
+
|
|
136
|
+
### 4.3 `SKILL` — Skills and Agent Instructions
|
|
137
|
+
1. **Scope:** [pr-review/SKILL.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/pr-review/SKILL.md), [pr-review-standard.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/pr-review/references/pr-review-standard.md), [self-diagnosis/SKILL.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/SKILL.md), [self-diagnosis-manifest.json](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/resources/self-diagnosis-manifest.json), deleted `skills/agy-squad/SKILL.md`, and [`makeProfile`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/bin/agy-squad.mjs#L49-L56).
|
|
138
|
+
2. **Coverage:** `Complete` across frontmatter, progressive disclosure budgets, relative links, and manifest instructions.
|
|
139
|
+
3. **P1 — high priority:** None open (`1` closed: `R4-SKILL-LEDGER-GATE` in Wave R4, see Section 9.2.1).
|
|
140
|
+
4. **P2 — medium priority:** None open (`6` closed: `SKILL-001` in `281c04a`; `R4-SKILL-P2-1`, `R4-SKILL-P2-2`, `R5-SKILL-P2-1`, `R5-SKILL-P2-2`, `R5-SKILL-P2-3` in Section 9.2.1).
|
|
141
|
+
5. **P3 — low priority:** None open (`5` closed: `R3-SKILL-001`, `R3-SKILL-002`, `R5-SKILL-P3-1`, `R5-OPT-05` in Section 9.2.2, `SD-R5-SKILL-01` `Closed (Post-Remediation)` in Section 8).
|
|
142
|
+
6. **Verification:** Executed `diagnose.mjs --markdown` (`0` broken links, `pr-review` `10,084 B`, `self-diagnosis` `9,309 B`) and [test-run.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-run.mjs); zero verification gaps.
|
|
143
|
+
7. **Verdict:** **No findings within reviewed scope**
|
|
144
|
+
- **Rechecked R1 Closure — `SKILL-001` (`P2`, `Closed` in `281c04a`):** [`makeProfile`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/bin/agy-squad.mjs#L49-L56) allowlists current WSL CLI tool names (`read_file`, `write_file`, `edit_file`, `manage_task`) alongside IDE aliases.
|
|
145
|
+
|
|
146
|
+
### 4.4 `MCP` — MCP Schemas and Public API
|
|
147
|
+
1. **Scope:** [mcp/index.js](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/index.js) (`1–173`), cross-referenced with [test-server.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-server.mjs) and [docs/tools.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/docs/tools.md).
|
|
148
|
+
2. **Coverage:** `Complete` across JSON-RPC `2.0` framing, byte limits, session gating, `.mcp-ready`, and `TOOLS[0].inputSchema`.
|
|
149
|
+
3. **P1 — high priority:** None identified within reviewed scope.
|
|
150
|
+
4. **P2 — medium priority:** None open (`4` closed: `MCP-001`, `MCP-002`, `MCP-003` in `281c04a`; `R4-MCP-P2-1` in Section 9.2.1).
|
|
151
|
+
5. **P3 — low priority:** None open (`4` closed: `R3-MCP-1`, `R3-MCP-2`, `R4-MCP-P3-1`, `R5-MCP-P3-1` in Section 9.2.2; `1` `Deferred / Won't Fix`: `OPT-MCP-SCHEMA` in Section 8).
|
|
152
|
+
6. **Verification:** Executed [test-server.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-server.mjs) locally and in CI runs `42468601060` & `42468598397`; zero verification gaps.
|
|
153
|
+
7. **Verdict:** **No findings within reviewed scope**
|
|
154
|
+
- **Rechecked R1 Closures (`281c04a`):** `MCP-001` (`P2`, `Closed` — JSON-RPC request shape validation, `-32700`/`-32600`/`-32601`/`-32603` separation, `Buffer.byteLength` 10MB guard); `MCP-002` (`P2`, `Closed` — `minLength: 1`, `minProperties: 1`, `workspace: { enum: ["inherit"] }`); `MCP-003` (`P2`, `Closed` — `realpathSync` fallback on `AGY_SQUAD_WORKSPACE` before `.mcp-ready` `publish`).
|
|
155
|
+
|
|
156
|
+
### 4.5 `RUN` — Core Runtime, Parsing, and Validation
|
|
157
|
+
1. **Scope:** [mcp/dispatch.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/dispatch.mjs) and [mcp/briefs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/briefs.mjs).
|
|
158
|
+
2. **Coverage:** `Complete` across manifest containment, stage compilation, prompt construction, and input normalization.
|
|
159
|
+
3. **P1 — high priority:** None open (`3` closed: `RUN-001` in `281c04a`; `RUN-003`, `RUN-004` below).
|
|
160
|
+
4. **P2 — medium priority:** None open (`5` closed: `RUN-002` in `281c04a`; `R3-RUN-1`, `R3-RUN-2`, `R4-RUN-P2-1`, `R5-RUN-P2-1` in Section 9.2.1).
|
|
161
|
+
5. **P3 — low priority:** None open (`5` closed: `R4-RUN-P3-1`, `R3-OPT-B1`..`B3`, `R5-OPT-01`, `R5-OPT-03` in Section 9.2.2; `1` `Deferred / Won't Fix`: `OPT-BRIEF-BOILERPLATE` in Section 8).
|
|
162
|
+
6. **Verification:** Executed [test-dispatch.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-dispatch.mjs) + live cohorts R2–R5; zero verification gaps.
|
|
163
|
+
7. **Verdict:** **No findings within reviewed scope**
|
|
164
|
+
- **Rechecked R1 Closures (`281c04a`):** `RUN-001` (`P1`, `Closed` — rejects `"all_l1"` in `manifestSquads`); `RUN-002` (`P2`, `Closed` — isolates `squad.lead` from squad root properties and validates specialists during `all_l1`).
|
|
165
|
+
- **R2 Finding Records (`10`-Field):**
|
|
166
|
+
- **`RUN-003` (`P1`, `Closed`):**
|
|
167
|
+
- **Title, priority, status:** `RUN-003` — Default unmanaged specialists receive read-only `TypeName: "research"` (`P1`, `Closed`).
|
|
168
|
+
- **Contract provenance:** Pointer-Over-Wire write requirement ([docs/tools.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/docs/tools.md#L17-L44)) and `L6` ([LEDGER.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/docs/plans/LEDGER.md#L10)).
|
|
169
|
+
- **Source evidence:** [`buildSubagentSpec`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/briefs.mjs#L62-L67).
|
|
170
|
+
- **Trigger:** Unmanaged `dispatch_squad` call with specialist omitting `typeName`.
|
|
171
|
+
- **Expected / actual:** Expected writable `TypeName: "self"` default and rejection of `"research"`; pre-fix code defaulted unmanaged specialists to read-only `"research"` (source + live trial confirmed).
|
|
172
|
+
- **Impact:** Default unmanaged specialists could not write `report.md`.
|
|
173
|
+
- **Required remediation:** Default `TypeName` to `"self"` and reject `"research"` across unmanaged and managed modes.
|
|
174
|
+
- **Acceptance evidence:** [test-dispatch.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-dispatch.mjs#L42-L46) and live specialist [`1e211e57-a046-4b5a-8fdf-46a2dcd8a083`](conversation://1e211e57-a046-4b5a-8fdf-46a2dcd8a083).
|
|
175
|
+
- **Root cause / related IDs:** Managed/unmanaged parity gap in `mcp/briefs.mjs`; related to `RUN-004`.
|
|
176
|
+
- **Closure:** Closed in `2b284f4` (`9776bbe` docs); rechecked in Waves R3–R5 (`0` residual limits).
|
|
177
|
+
- **`RUN-004` (`P1`, `Closed`):**
|
|
178
|
+
- **Title, priority, status:** `RUN-004` — Unmanaged `buildSubagentSpec` permits `Workspace !== "inherit"` (`P1`, `Closed`).
|
|
179
|
+
- **Contract provenance:** Shared-workspace slot invariant ([docs/tools.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/docs/tools.md#L21)) and `L1, L2`.
|
|
180
|
+
- **Source evidence:** [`buildSubagentSpec`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/briefs.mjs#L65-L67) and `agentSchema` ([mcp/index.js](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/index.js#L25-L35)).
|
|
181
|
+
- **Trigger:** Unmanaged manifest specifying `workspace: "branch"` or `"share"`.
|
|
182
|
+
- **Expected / actual:** Expected `Workspace !== "inherit"` rejection in all modes; pre-fix code gated check on `if (reportRoot && ...)` (observed reproduction).
|
|
183
|
+
- **Impact:** Reports written in isolated branch workspaces were invisible to parent `handoffs.mjs` reconciliation.
|
|
184
|
+
- **Required remediation:** Enforce `payload.Workspace !== "inherit"` unconditionally and restrict schema enum to `["inherit"]`.
|
|
185
|
+
- **Acceptance evidence:** [test-dispatch.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-dispatch.mjs#L92-L95) and [test-server.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-server.mjs#L91).
|
|
186
|
+
- **Root cause / related IDs:** Managed/unmanaged parity gap in `mcp/briefs.mjs`; related to `RUN-003`.
|
|
187
|
+
- **Closure:** Closed in `2b284f4`; rechecked in Waves R3–R5 (`0` residual limits).
|
|
188
|
+
|
|
189
|
+
### 4.6 `SVC` — Services, Orchestration, and Audit Semantics
|
|
190
|
+
1. **Scope:** [mcp/handoffs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/handoffs.mjs), [mcp/run-state.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/run-state.mjs), and [bin/agy-squad.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/bin/agy-squad.mjs).
|
|
191
|
+
2. **Coverage:** `Complete` across receipt reconciliation, synthesis gating, atomic `publish()`, bundle verification/pruning, and run-directory lifecycle.
|
|
192
|
+
3. **P1 — high priority:** None open (`2` closed: `SVC-001` in `281c04a`; `SVC-003` below).
|
|
193
|
+
4. **P2 — medium priority:** None open (`2` closed: `SVC-002` in `281c04a`; `R4-SVC-P2-1` in Section 9.2.1).
|
|
194
|
+
5. **P3 — low priority:** None open (`14` closed: `R3-SVC-1`, `R3-SVC-2`, `R3-OPT-IO1`..`IO4`, `R4-SVC-P3-1`, `R4-SVC-P3-2`, `R4-OPT-01`, `R5-SVC-P3-2`, `R5-SVC-P3-3`, `R5-OPT-02`, `R5-OPT-04` in Section 9.2.2, `SVC-P3-02r` `Closed (Post-Remediation)` in Section 8; `1` `Closed (By Design)`: `SVC-P3-01` and `1` `Deferred / Won't Fix`: `OPT-SVC-003` in Section 8).
|
|
195
|
+
6. **Verification:** Executed [test-handoffs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-handoffs.mjs) (including 2-process concurrency race) and [test-run.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-run.mjs); zero verification gaps (`SVC-GAP-001` closed in `281c04a`).
|
|
196
|
+
7. **Verdict:** **No findings within reviewed scope**
|
|
197
|
+
- **Rechecked R1 Closures (`281c04a`):** `SVC-001` (`P1`, `Closed` — `publish(..., true)` atomic replacement on re-bundle + strict `verifiedFiles` plain-object & self-hash rejection); `SVC-002` (`P2`, `Closed` — `hasEvidence` cleanup of failed `--manifest` run directories).
|
|
198
|
+
- **R2 Finding Record (`10`-Field) — `SVC-003` (`P1`, `Closed`):**
|
|
199
|
+
- **Title, priority, status:** `SVC-003` — `bundleReports` and `verifyBundle` trust `record.verdict === "PASS"` without inspecting `lead/report.md` (`P1`, `Closed`).
|
|
200
|
+
- **Contract provenance:** `L1, L2` ([LEDGER.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/docs/plans/LEDGER.md#L7)) and [docs/tools.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/docs/tools.md#L62-L64).
|
|
201
|
+
- **Source evidence:** [`readSynthesis`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/handoffs.mjs#L193-L214), `bundleReports`, and `verifyBundleInternal`.
|
|
202
|
+
- **Trigger:** Call `bundleReports` or `verifyBundle` when `lead/report.md` contains `FAIL`/`BLOCKED` or omits `PASS`.
|
|
203
|
+
- **Expected / actual:** Expected deterministic rejection unless `lead/report.md` records an unambiguous `PASS`; pre-fix code bundled failed synthesis reports and allowed `pruneReports` to delete specialist evidence (observed reproduction).
|
|
204
|
+
- **Impact:** Premature deletion of specialist reports on failed/blocked cohorts.
|
|
205
|
+
- **Required remediation:** Parse `lead/report.md` in `readSynthesis` (stripping fenced/inline code) and enforce unambiguous `PASS` across both `bundleReports` and `verifyBundle`.
|
|
206
|
+
- **Acceptance evidence:** [test-handoffs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-handoffs.mjs#L79-L99) and live cohort bundles across R2–R5.
|
|
207
|
+
- **Root cause / related IDs:** Over-reliance on caller metadata without synthesis content check; hardened further in `R3-RUN-2`, `R4-SVC-P2-1`, and `R5-RUN-P2-1`.
|
|
208
|
+
- **Closure:** Closed in `2b284f4` + Wave R5 working tree; rechecked across Waves R3–R5 (`0` residual limits).
|
|
209
|
+
|
|
210
|
+
### 4.7 `DB` — Database, Migrations, Replay, and Concurrency
|
|
211
|
+
1. **Scope:** Repository-wide persistence check (`Agy-Squad` has zero SQL/ORM/migration files; filesystem staging in `mcp/run-state.mjs` and `mcp/handoffs.mjs` is audited under `SVC`).
|
|
212
|
+
2. **Coverage:** `Complete`.
|
|
213
|
+
3. **P1 — high priority:** None identified within reviewed scope.
|
|
214
|
+
4. **P2 — medium priority:** None identified within reviewed scope.
|
|
215
|
+
5. **P3 — low priority:** None identified within reviewed scope.
|
|
216
|
+
6. **Verification:** Confirmed zero database dependencies in `package.json`; filesystem concurrency verified under `SVC`.
|
|
217
|
+
7. **Verdict:** **Not applicable** (no database or migration layer exists in `Agy-Squad`).
|
|
218
|
+
|
|
219
|
+
### 4.8 `SCRIPT` — Scripts, Evaluation, and Developer Tooling
|
|
220
|
+
1. **Scope:** [bin/terminal.py](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/bin/terminal.py), [diagnose.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/scripts/diagnose.mjs), and CLI entrypoints in `bin/agy-squad.mjs` and `mcp/handoffs.mjs`.
|
|
221
|
+
2. **Coverage:** `Complete`.
|
|
222
|
+
3. **P1 — high priority:** None open (`1` closed: `R3-SCRIPT-1` in Section 9.2.1).
|
|
223
|
+
4. **P2 — medium priority:** None open (`11` closed: `SCRIPT-001` in `281c04a`; `R3-SCRIPT-2`..`4`, `R4-SCRIPT-P2-1`..`3`, `R5-SCRIPT-P2-1`..`4` in Section 9.2.1).
|
|
224
|
+
5. **P3 — low priority:** None open (`5` closed: `R4-OPT-03`, `R5-SCRIPT-P3-1`, `R5-SCRIPT-P3-2`, `R5-OPT-06` in Section 9.2.2, `SCRIPT-P3-01r` `Closed (Post-Remediation)` in Section 8).
|
|
225
|
+
6. **Verification:** Executed PTY signal/stdin harnesses and `diagnose.mjs` CLI negative/positive probes in [test-run.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-run.mjs) and `handoffs.mjs` CLI subprocess tests in [test-handoffs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-handoffs.mjs). Remaining non-blocking gap: `SCRIPT-GAP-002` (live `agy chat` TUI banner drift check).
|
|
226
|
+
7. **Verdict:** **No findings within reviewed scope**
|
|
227
|
+
- **Rechecked R1 Closure — `SCRIPT-001` (`P2`, `Closed` in `281c04a` + `R4-SCRIPT-P2-1`):** `terminal.py` gates operator keystrokes until `submitted == True` while forwarding pre-submission `\x03` `SIGINT`.
|
|
228
|
+
|
|
229
|
+
### 4.9 `TEST` — Tests and CI
|
|
230
|
+
1. **Scope:** [test-dispatch.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-dispatch.mjs), [test-handoffs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-handoffs.mjs), [test-run.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-run.mjs), [test-server.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-server.mjs), [.github/workflows/ci.yml](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.github/workflows/ci.yml), and `2` deleted legacy suites.
|
|
231
|
+
2. **Coverage:** `Complete`.
|
|
232
|
+
3. **P1 — high priority:** None open (`1` closed: `R3-TEST-1` in Section 9.2.1).
|
|
233
|
+
4. **P2 — medium priority:** None open (`2` closed: `TEST-001` in `281c04a`; `R3-TEST-2` in Section 9.2.1).
|
|
234
|
+
5. **P3 — low priority:** None open (`4` closed: `R3-TEST-3`, `R3-TEST-4`, `R5-TEST-P3-1` in Section 9.2.2, `TEST-P3-01r` `Closed (Post-Remediation)` in Section 8).
|
|
235
|
+
6. **Verification:** `npm test` (`4/4` suites) executed locally on WSL Node `v22.19.0` and on `ubuntu-latest` Node 22 & 24 in CI runs `42468601060` & `42468598397`; `TEST-GAP-001` closed by live trials across R2–R5.
|
|
236
|
+
7. **Verdict:** **No findings within reviewed scope**
|
|
237
|
+
- **Rechecked R1 Closure — `TEST-001` (`P2`, `Closed` in `281c04a`):** [test-server.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-server.mjs) exercises managed-run `.mcp-ready`, `AGY_SQUAD_SESSION` neighbor rejection, and inline `manifest` staging.
|
|
238
|
+
|
|
239
|
+
### 4.10 `DEP` — Dependencies, Packaging, and Configuration
|
|
240
|
+
1. **Scope:** [.gitignore](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.gitignore), [package.json](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/package.json), [zensical.toml](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/zensical.toml), [.github/workflows/docs.yml](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.github/workflows/docs.yml), and `LICENSE`.
|
|
241
|
+
2. **Coverage:** `Complete`.
|
|
242
|
+
3. **P1 — high priority:** None identified within reviewed scope.
|
|
243
|
+
4. **P2 — medium priority:** None open (`1` closed: `DEP-001` in `281c04a`).
|
|
244
|
+
5. **P3 — low priority:** None open (`1` closed: `R3-DEP-1` in Section 9.2.2; `1` `Informational`: `DEP-P3-01` in Section 8).
|
|
245
|
+
6. **Verification:** `npm pack --dry-run --json` (`11` packaged runtime/doc files, `0` dependencies) and `git check-ignore` verified locally and in CI; zero verification gaps.
|
|
246
|
+
7. **Verdict:** **No findings within reviewed scope**
|
|
247
|
+
- **Rechecked R1 Closure — `DEP-001` (`P2`, `Closed` in `281c04a`):** [.gitignore](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.gitignore#L4-L5) ignores transient `.agents/plugins/agy-squad-*/` and `.agents/agents/agy-squad-*.md` while preserving tracked `.agents/skills/`.
|
|
248
|
+
|
|
249
|
+
---
|
|
250
|
+
|
|
251
|
+
## 5. Cross-Category Root Causes and Rationale for Remediation Order
|
|
252
|
+
|
|
253
|
+
1. **Managed vs. Unmanaged Validation Parity (`RUN-003`, `RUN-004`, `R4-MCP-P2-1`, `R5-ARCH-P2-1`):** Early iterations validated managed runs more strictly than unmanaged or single-squad paths; unified in `resolveSquadLead`, `specialistAssignments`, and `buildSubagentSpec` first because compilation feeds every downstream boundary.
|
|
254
|
+
2. **Markdown-Aware Verdict & Link Parsing (`SVC-003`, `R3-RUN-2`, `R4-SVC-P2-1`, `R5-RUN-P2-1`, `R5-SCRIPT-P2-1`):** Naive regexes over Markdown misread fenced/multi-backtick spans and hyphenated words (`fail-safe`); hardened with CommonMark backtick-span stripping before synthesis bundling and skill link checks.
|
|
255
|
+
3. **Filesystem & PTY Lifecycle Hygiene (`ARCH-001`, `SVC-001`, `SVC-002`, `R3-SCRIPT-1..4`, `R5-SCRIPT-P2-3`):** Enforced descriptor-verified writes (`publish()`), upfront binary checks, PTY signal resets, non-empty evidence retention, and atomic 2-pass `L41` teardown.
|
|
256
|
+
4. **Durable Audit Provenance & Anti-Compression (`R4-SKILL-LEDGER-GATE`, `v1.3.0` Standard):** Because `prune` and `--teardown` delete `scratch/` artifacts (`L41`), `docs/reviews/` is the sole surviving record—requiring pre-remediation export, Session Provenance (Section 1), mandatory residual/deferred sink (Section 8), and `1 ID = 1 Row` wave ledgers (Section 9) before remediating the final `5` `P3` residuals.
|
|
257
|
+
|
|
258
|
+
---
|
|
259
|
+
|
|
260
|
+
## 6. Verification Record and Remaining Gaps
|
|
261
|
+
|
|
262
|
+
### Executed Checks
|
|
263
|
+
|
|
264
|
+
| Check / Command | Environment | Target Revision | Result | Notes |
|
|
265
|
+
| --- | --- | --- | --- | --- |
|
|
266
|
+
| `npm test` (`test-dispatch`, `test-handoffs`, `test-run`, `test-server`) | Local WSL (`node v22.19.0`, `python3 3.12`) | `9f9552d` (`771b5d4`..`9f9552d`) | **PASS (`4/4` suites)** | Includes 2-process race, `handoffs.mjs` symlink CLI, PTY `Ctrl-C`, profile mutation retention, and `diagnose.mjs` CLI guards |
|
|
267
|
+
| `node .agents/skills/self-diagnosis/scripts/diagnose.mjs --markdown` | Local WSL (`node v22.19.0`) | `9f9552d` | **PASS (`HEALTHY`)** | Validates `v1.3.0` ledger schema, `0` broken links, brief/schema byte budgets, and canary `bundle -> verify -> prune` |
|
|
268
|
+
| Live `/self-diagnosis` cohorts: Wave R3 (`all_specialists`) & Waves R4–R5 (`all_l1` + same-squad re-verify) | Antigravity live subagents (Section 9.1) | `45a66d1 -> 9f9552d` | **PASS (`0` P1, `0` P2)** | Cryptographically bundled (`report.sources.json`), verified, torn down (`--teardown all`), and subagents terminated |
|
|
269
|
+
| 1-specialist live subagent trial (`live_pow_r2`, [`1e211e57-...`](conversation://1e211e57-a046-4b5a-8fdf-46a2dcd8a083)) | Antigravity live subagent | `45a66d1` + R2 delta | **PASS** | Verified `TypeName: "self"`, `272 B` `READY` receipt, `bundle -> verify -> prune` |
|
|
270
|
+
| `npm pack --dry-run --json` & GitHub Actions `CI` / `Documentation` | Local WSL & `ubuntu-latest` (`42468601060`..`42489923799`) | `281c04a` (`d718d7d`)..`5b5ba4e` | **PASS** | Node 22 & Node 24 matrix + Zensical clean docs build |
|
|
271
|
+
| Controlled A/B benchmark: `Agy-Squad` + `Agy-Context-Saver 1.8.1` (`rtk 0.51.0`) vs. `/teamwork` (`[skip-interview]`) | Sequential live cohorts (`f1465008-...` vs. `d00a4261-...`) | `5b5ba4e` | **PASS (`6/6` needles both arms)** | `Agy-Squad`: `6m 15s` active (`4.2x` faster), `3` vs. `8` agents, `64` vs. `645` steps (`-90.1%`), `148.2 KB` vs. `817.4 KB` transcripts (`-81.9%`), `1` (`249 B`) vs. `5` (`4,940 B`) parent wakeups (`-95.0%`), `0` vs. `41` (`207.9 KB`) leftover `.agents/teamwork/` files |
|
|
272
|
+
|
|
273
|
+
### Verification Gaps Ledger
|
|
274
|
+
|
|
275
|
+
| Gap ID | Category | Description | Status | Resolution / Remaining Requirement |
|
|
276
|
+
| --- | --- | --- | --- | --- |
|
|
277
|
+
| `SVC-GAP-001` | `SVC` / `TEST` | Two-process concurrent race test on `stagePlan` / `publish` | **Closed** | Closed in `281c04a` ([test-handoffs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-handoffs.mjs#L118-L135)) |
|
|
278
|
+
| `SCRIPT-GAP-001` | `SCRIPT` / `TEST` | Subprocess CLI test for `node mcp/handoffs.mjs` | **Closed** | Closed in `281c04a` + symlink CLI test in Wave R5 ([test-handoffs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-handoffs.mjs)) |
|
|
279
|
+
| `TEST-GAP-001` | `TEST` / `DOC` | Live subagent verification of `squad-<id>` slots, `<= 500 B` receipts, and `bundle`/`verify`/`prune` | **Closed** | Closed in R2 (`1e211e57-...`) and expanded across 6-agent flat (R3) & 9-agent layered (R4, R5) live cohorts |
|
|
280
|
+
| `SCRIPT-GAP-002` | `SCRIPT` / `TEST` | `bin/terminal.py` startup banner screen-scraping (`? for shortcuts`) against live `agy chat` TUI | **Open (Non-blocking per `L7`)** | Keep `npm test` subagent-free (`L7`); re-verify manually only if `agy` CLI TUI startup chrome changes |
|
|
281
|
+
|
|
282
|
+
---
|
|
283
|
+
|
|
284
|
+
## 7. Overall Disposition and Finding Closure Table
|
|
285
|
+
|
|
286
|
+
- **Review Coverage:** **Complete (`100%`)** across all 10 required categories (`9` active categories; `DB` `Not applicable`), R1/R2 reviews, both external Devin artifacts, and `/self-diagnosis` Waves R3–R5.
|
|
287
|
+
- **Merge Disposition:** **Approve** (`0` open `P1`, `0` open `P2`, and `0` open `P3` residuals across all 10 categories; all `5` Wave R5 post-remediation `P3` residuals in Section 8 are remediated and verified `Closed (Post-Remediation)`).
|
|
288
|
+
|
|
289
|
+
### R1 & R2 Baseline Finding Closure Table (`17` Findings — All `Closed`)
|
|
290
|
+
|
|
291
|
+
| Finding ID | Primary Category | Priority | Title | Status | Fix Revision | Verification & Closure Evidence |
|
|
292
|
+
| --- | --- | --- | --- | --- | --- | --- |
|
|
293
|
+
| `RUN-001` | `RUN` | **P1** | `manifestSquads` allows reserved `"all_l1"` as a squad key | **Closed** | `281c04a` | [dispatch.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/dispatch.mjs#L48-L50), [test-dispatch.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-dispatch.mjs#L85-L88) |
|
|
294
|
+
| `SVC-001` | `SVC` | **P1** | Re-bundling fails with `EEXIST` and `verifyFiles` accepts malformed `verifiedFiles` | **Closed** | `281c04a` | [handoffs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/handoffs.mjs#L130-L245), [test-handoffs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-handoffs.mjs#L77-L95) |
|
|
295
|
+
| `RUN-003` | `RUN` | **P1** | Unmanaged specialists without `typeName` default to read-only `"research"` | **Closed** | `2b284f4` | [briefs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/briefs.mjs#L62-L67), [test-dispatch.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-dispatch.mjs#L42-L46), live `1e211e57-...` |
|
|
296
|
+
| `RUN-004` | `RUN` | **P1** | Unmanaged `buildSubagentSpec` permits `Workspace !== "inherit"` | **Closed** | `2b284f4` | [briefs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/briefs.mjs#L65-L67), [test-dispatch.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-dispatch.mjs#L92-L95) |
|
|
297
|
+
| `SVC-003` | `SVC` | **P1** | `bundleReports` / `verifyBundle` trust `record.verdict` without `readSynthesis` check | **Closed** | `2b284f4` | [handoffs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/handoffs.mjs#L193-L214), [test-handoffs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-handoffs.mjs#L79-L99) |
|
|
298
|
+
| `ARCH-001` | `ARCH` | **P2** | `L1, L2` boundary claim vs. writable pre-staged `manifest.json` | **Closed** | `281c04a` | [agy-squad.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/bin/agy-squad.mjs#L140-L152), [LEDGER.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/docs/plans/LEDGER.md#L7) |
|
|
299
|
+
| `DOC-001` | `DOC` | **P2** | `LEDGER.md` drops `L10, L12, L17, L30` | **Closed** | `281c04a` | [LEDGER.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/docs/plans/LEDGER.md#L13-L19), CI runs `42468601065`, `42468598360` |
|
|
300
|
+
| `SKILL-001` | `SKILL` | **P2** | `makeProfile` omits current WSL CLI tool names | **Closed** | `281c04a` | [agy-squad.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/bin/agy-squad.mjs#L49-L56), [test-run.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-run.mjs#L144-L153) |
|
|
301
|
+
| `MCP-001` | `MCP` | **P2** | Non-object JSON-RPC handling, error codes, and UTF-16 length check in `mcp/index.js` | **Closed** | `281c04a` | [index.js](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/index.js#L70-L168), [test-server.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-server.mjs) |
|
|
302
|
+
| `MCP-002` | `MCP` | **P2** | `dispatch_squad` schema omits `minLength`, `minProperties`, and `workspace` enum | **Closed** | `281c04a`, `2b284f4` | [index.js](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/index.js#L15-L65), [test-server.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-server.mjs#L91) |
|
|
303
|
+
| `MCP-003` | `MCP` | **P2** | `.mcp-ready` fails when `AGY_SQUAD_WORKSPACE` is unset or symlinked | **Closed** | `281c04a` | [index.js](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/index.js#L140-L148), [test-server.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-server.mjs) |
|
|
304
|
+
| `RUN-002` | `RUN` | **P2** | `all_l1` leaks squad fields into `lead` and skips unmanaged specialist validation | **Closed** | `281c04a` | [dispatch.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/dispatch.mjs#L150-L170), [test-dispatch.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-dispatch.mjs) |
|
|
305
|
+
| `SVC-002` | `SVC` | **P2** | Pre-staged `manifest.json` blocks empty-run cleanup on failed launch | **Closed** | `281c04a` | [agy-squad.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/bin/agy-squad.mjs#L89-L98), [test-run.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-run.mjs#L171-L180) |
|
|
306
|
+
| `SCRIPT-001` | `SCRIPT` | **P2** | `bin/terminal.py` forwards `stdin` before prompt submission | **Closed** | `281c04a` | [terminal.py](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/bin/terminal.py#L58-L95) |
|
|
307
|
+
| `TEST-001` | `TEST` | **P2** | Managed-run session gate and `.mcp-ready` untested in `test-server.mjs` | **Closed** | `281c04a` | [test-server.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-server.mjs#L55-L104) |
|
|
308
|
+
| `DEP-001` | `DEP` | **P2** | `.gitignore` omits transient `.agents/plugins/agy-squad-*/` and `.agents/agents/agy-squad-*.md` | **Closed** | `281c04a` | [.gitignore](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.gitignore#L4-L5) |
|
|
309
|
+
| `DOC-002` | `DOC` | **P3** | `docs/tools.md` parameter table omits `manifest` | **Closed** | `281c04a` | [docs/tools.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/docs/tools.md#L9) |
|
|
310
|
+
|
|
311
|
+
*(Note: `17` rows above represent the `14` R1 findings [`2` P1, `11` P2, `1` P3] + `3` Devin `P1` findings [`RUN-003`, `RUN-004`, `SVC-003`], where `MCP-002` spans `281c04a` + R2 schema enum; Devin artifact cross-references map `1-to-1` onto these IDs plus `SCRIPT-GAP-001`, `SCRIPT-GAP-002`, `SVC-GAP-001`, and `TEST-GAP-001` in Section 6.)*
|
|
312
|
+
|
|
313
|
+
---
|
|
314
|
+
|
|
315
|
+
## 8. Post-Remediation Residuals & Deferred Dispositions
|
|
316
|
+
|
|
317
|
+
Every post-remediation advisory surfaced during same-squad re-verification, every intentionally deferred optimization proposal, and every `Closed (By Design)` / `Informational` observation across Waves R3–R5 is recorded below as its own atomic `1 ID = 1 Row` entry (never buried inside `Closed` rows or omitted).
|
|
318
|
+
|
|
319
|
+
| ID | Wave/Session | Cat | Status | Source | Defect / Proposal | Disposition / Fix | Verification & Bundle SHA |
|
|
320
|
+
| --- | --- | --- | --- | --- | --- | --- | --- |
|
|
321
|
+
| `SD-R5-SKILL-01` | `R5` / `S3 (944c64a0)` | `SKILL` | **Closed (Post-Remediation)** | [self-diagnosis-manifest.json](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/resources/self-diagnosis-manifest.json#L6-L101) | `skill_and_pr_review_audit.lead.objective` cited `v1.1.0` (`runtime_and_contract_diagnosis` cited `v1.2.0`) and lead `instructions` lacked an anti-compression rule before `prune`. | Updated manifest objectives to `v1.3.0` and added explicit `1 ID = 1 Finding` anti-compression instructions before `prune` across all 3 Squad Leads (`lines 6, 13, 46, 56, 101`, `9f9552d`). | Surfaced in `ec511d82...`; verified via `diagnose.mjs --markdown` (`Status: HEALTHY`, `0` findings) |
|
|
322
|
+
| `SD-R5-DOC-01` | `R5` / `S3 (944c64a0)` | `DOC` | **Closed (Post-Remediation)** | [optimization-and-review-rubric.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/references/optimization-and-review-rubric.md#L41) | Inline backticked `` `\le 3,200` `` rendered literal `\le` instead of math syntax. | Replaced backticked `\le` with KaTeX `($\le 3,200$ UTF-8 bytes managed)` at `optimization-and-review-rubric.md:41` (`9f9552d`). | Surfaced in `ec511d82...`; verified via `diagnose.mjs` link/markdown audit |
|
|
323
|
+
| `SVC-P3-02r` | `R5` / `S3 (944c64a0)` | `SVC` | **Closed (Post-Remediation)** | [briefs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/briefs.mjs#L50-L51), [docs/tools.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/docs/tools.md#L44) | `buildSubagentSpec` split `scopeFiles` on `/[\\/]/` without rejecting interior `\`, deferring failure until `handoffs.mjs` / `run-state.mjs`. | Rejected `trimmed.includes("\\")` upfront in `mcp/briefs.mjs:50`, documented `\` rejection in `docs/tools.md:44`, and added `"src\\a.js"` test in [test-dispatch.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-dispatch.mjs#L124-L127) (`771b5d4`). | Surfaced in `2c148268...`; verified via `npm test` (`test-dispatch.mjs` exit `0`) |
|
|
324
|
+
| `SCRIPT-P3-01r` | `R5` / `S3 (944c64a0)` | `SCRIPT` | **Closed (Post-Remediation)** | [terminal.py](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/bin/terminal.py#L29-L66) | Post-submission `select(..., None)` auto-retried `EINTR` (PEP 475); if child ignored `SIGTERM`, `terminating = True` did not wake `select()` to reach `SIGKILL` escalation. | Added non-blocking `os.pipe()` (`wake_r, wake_w`) signaled in `terminate()` and polled in `select.select` (`bin/terminal.py:30-66`) so `SIGTERM`/`SIGINT` immediately enters `SIGKILL` escalation (`771b5d4`). | Surfaced in `2c148268...`; verified via `postTermRes` (`SIG_IGN` child -> `SIGKILL` `137`) in [test-run.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-run.mjs#L337-L392) |
|
|
325
|
+
| `SD-AB-SVC-01` | `AB-1` / `S3 (944c64a0)` | `SVC` | **Closed (Post-Remediation)** | [agy-squad.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/bin/agy-squad.mjs#L45-L55), [docs/index.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/docs/index.md#L7-L16) | `makeProfile` set `inheritCustomizations: true` during shell-off preview (`!launch`), colliding with `Agy-Context-Saver` `read_file -> rtk read` routing, and omitted `schedule`/`call_mcp_tool` on `--launch`; docs lacked the 4-stage `Agy-Context-Saver` link. | Set `inheritCustomizations: Boolean(launch)`, added `schedule` & `call_mcp_tool` on `--launch`, provisioned `rtk 0.51.0` via `sync_installation`, and documented the 4-stage link & `/teamwork` A/B benchmark (`5b5ba4e`). | Verified via [test-run.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-run.mjs#L144-L160) & A/B bundle `418d7ccb...` |
|
|
326
|
+
| `TEST-P3-01r` | `R5` / `S3 (944c64a0)` | `TEST` | **Closed (Post-Remediation)** | [terminal.py](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/bin/terminal.py#L49-L51), [test-run.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-run.mjs#L302-L465) | Startup deadline timeout + `SIGKILL` escalation and failed `--launch` positive retention of non-empty `report.md` were unmocked in CI. | Added `AGY_SQUAD_STARTUP_TIMEOUT` / `AGY_SQUAD_KILL_GRACE` env overrides in `bin/terminal.py` and added CI tests for startup timeout `SIGKILL`, post-submission `SIGTERM` `SIGKILL`, failed-run non-empty `report.md` retention, and `DOC-LEDGER-SCHEMA` in `tests/test-run.mjs` (`771b5d4`, `9f9552d`). | Surfaced in `2c148268...`; verified via `npm test` (`4/4` suites exit `0`) |
|
|
327
|
+
| `SVC-P3-01` | `R5` / `S3 (944c64a0)` | `SVC` | **Closed (By Design)** | [dispatch.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/dispatch.mjs#L21-L36), [handoffs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/handoffs.mjs#L92-L112) | Intra-workspace symlinked manifests are permitted (`realpathSync` + `O_NOFOLLOW` + `/proc/self/fd` containment), while reports/bundles reject all intra-workspace symlinks. | Intentional boundary asymmetry documented in `pr-review/SKILL.md` Boundary 2: operator-authored manifests may be workspace symlinks, whereas subagent output slots must never traverse symlinks. | [test-dispatch.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-dispatch.mjs#L155); bundle `e4e2fffd...` -> `2c148268...` |
|
|
328
|
+
| `DEP-P3-01` | `R5` / `S3 (944c64a0)` | `DEP` | **Informational** | [package.json](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/package.json#L1-L21), [agy-squad.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/bin/agy-squad.mjs#L99-L115) | Zero external npm dependencies; managed CLI mode requires host POSIX `pty`, `python3`, and `agy` binary on `PATH` (`L1`, `L17`). | Non-defect architecture confirmation; `requireBinary` deterministically checks `python3` and `agy` before creating `run.directory`. | `npm pack --dry-run --json`; bundle `e4e2fffd...` -> `2c148268...` |
|
|
329
|
+
| `OPT-MCP-SCHEMA` | `R5` / `S3 (944c64a0)` | `MCP` | **Deferred / Won't Fix** | [index.js](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/index.js#L15-L60) | Deduplicate `lead`/`specialists`/`children` subschemas in `TOOLS[0].inputSchema` via local JSON Schema `{ $ref: "#/$defs/agent" }` (`~1,001 B` managed `tools/list` reduction). | Applied lazy `agentSchema` (`503 B` unmanaged `tools/list`, well below `2,048 B` budget); skipped local `$ref` because some MCP clients do not dereference `$defs` and [test-server.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-server.mjs#L91) traverses inline `lead.properties.workspace.enum`. | Evaluated in bundle `d104a49c...` -> `8c657cc6...` (`12823ed4-...`) |
|
|
330
|
+
| `OPT-BRIEF-BOILERPLATE` | `R5` / `S3 (944c64a0)` | `RUN` | **Deferred / Won't Fix** | [briefs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/briefs.mjs#L67-L115) | Compress compiled specialist/lead prompt prose further (`-1,233..-2,025 B` per `all_l1` cohort). | Deferred because Wave R3 already reduced brief overhead `-21.6%..-27.2%` (`772–2,255 B`, comfortably under rubric budgets) and `test-dispatch.mjs` / `test-run.mjs` assert exact guardrail substrings. | Evaluated in bundle `d104a49c...` -> `8c657cc6...` (`12823ed4-...`) |
|
|
331
|
+
| `OPT-SVC-003` | `R5` / `S3 (944c64a0)` | `SVC` | **Deferred / Won't Fix** | [handoffs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/handoffs.mjs#L345-L379) | Add combined single-process `verify --prune` CLI flag in `mcp/handoffs.mjs`. | Deferred to preserve the explicit two-step primary-acceptance gate (`verify <bundle>` -> primary accepts -> `prune <bundle> <accepted-sha256>`) in [docs/tools.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/docs/tools.md#L63-L64). | Evaluated in bundle `d104a49c...` -> `8c657cc6...` (`12823ed4-...`) |
|
|
332
|
+
| `SD-OPT-03` | `R5` / `S3 (944c64a0)` | `DOC` | **Deferred / Won't Fix** | [pr-review-standard.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/pr-review/references/pr-review-standard.md#L43-L55) | Compress the 10-row normative category table in `references/pr-review-standard.md`. | Deferred because `references/pr-review-standard.md` is lazy-loaded on demand (`SKILL.md` entry share `39% <= 70%`) and serves as the authoritative standard specification. | Evaluated in bundle `de2d3e1f...` -> `ec511d82...` (`df461fa2-...`) |
|
|
333
|
+
|
|
334
|
+
---
|
|
335
|
+
|
|
336
|
+
## 9. `/self-diagnosis` Cohort & Bundle Ledger
|
|
337
|
+
|
|
338
|
+
### 9.1 Cohort Provenance
|
|
339
|
+
|
|
340
|
+
| Wave | Session ID | Stage | Subagent IDs | Pre-Fix Bundle SHA | Re-Verify Bundle SHA | Teardown |
|
|
341
|
+
| --- | --- | --- | --- | --- | --- | --- |
|
|
342
|
+
| `R3` | [`944c64a0-...`](conversation://944c64a0-e4c9-4272-a701-e3a32108a31b) | `all_specialists` (`skill_and_pr_review_audit`) | S1 [`81209cde-30a4-4041-af80-4392643a8fd5`](conversation://81209cde-30a4-4041-af80-4392643a8fd5), S2 [`b917c585-bfba-47d8-b81f-a6df6f745650`](conversation://b917c585-bfba-47d8-b81f-a6df6f745650) | `adcd3da3c0ff24258fb7cb1271cdad3457249a3d10d92e8fb09ab71c1f40b990` | `ecad6a81d4a72c032ca3ac7bb66f677cd322f84f8bf608ab8f15c03cb57372d2` | `TORN_DOWN` (`L41`) & `killed` |
|
|
343
|
+
| `R3` | [`944c64a0-...`](conversation://944c64a0-e4c9-4272-a701-e3a32108a31b) | `all_specialists` (`runtime_and_contract_diagnosis`) | S1 [`32cbed59-0a15-45c7-abf9-28a3d31ef004`](conversation://32cbed59-0a15-45c7-abf9-28a3d31ef004), S2 [`13edc973-cd08-4434-99d4-8823ef9824d3`](conversation://13edc973-cd08-4434-99d4-8823ef9824d3) | `f391ce9529ff62100e4f7d828bd56982078073fdad84852ddbfaa86bbbc1d3fd` | `2a4427b37f65c2da65537438de2a22d383fcb70de0c438a453d8b4523035420a` | `TORN_DOWN` (`L41`) & `killed` |
|
|
344
|
+
| `R3` | [`944c64a0-...`](conversation://944c64a0-e4c9-4272-a701-e3a32108a31b) | `all_specialists` (`token_and_execution_optimization`) | S1 [`e59db864-503a-410f-b11b-4beed35038a4`](conversation://e59db864-503a-410f-b11b-4beed35038a4), S2 [`b7796d3e-bbb5-45b7-892f-deb67606b097`](conversation://b7796d3e-bbb5-45b7-892f-deb67606b097) | `06f7074e6c96306e90531510ba1086a073eb9fb22f7443547b451f980e8daaf5` | `55ae969ee3d1503e72db4e284a2835614306134e452366942f8f72169391abf2` | `TORN_DOWN` (`L41`) & `killed` |
|
|
345
|
+
| `R4` | [`944c64a0-...`](conversation://944c64a0-e4c9-4272-a701-e3a32108a31b) | `all_l1` (`skill_and_pr_review_audit`) | Pass-1 Lead [`5b6714c7-61c9-4e68-8d74-5455c9b7e14e`](conversation://5b6714c7-61c9-4e68-8d74-5455c9b7e14e); Re-Verify Lead [`df461fa2-...`](conversation://df461fa2-c290-402a-8c85-c9ff0a7800aa) (`c4a2bcc3-...`, `9c852437-...`) | `64b429bc...` (`5b6714c7` Pass 1) | `de2d3e1fc9ba66e76dc7e53f2f82e43421a4b686a442419eb592d3a8a05d1527` | Carried into `R5` -> `TORN_DOWN` |
|
|
346
|
+
| `R4` | [`944c64a0-...`](conversation://944c64a0-e4c9-4272-a701-e3a32108a31b) | `all_l1` (`runtime_and_contract_diagnosis`) | Pass-1 Lead [`ea03994d-25f2-40ac-bf91-e69019370e83`](conversation://ea03994d-25f2-40ac-bf91-e69019370e83); Re-Verify Lead [`cf9154ea-...`](conversation://cf9154ea-7006-413a-8633-51a7d69b4dfd) (`e550107f-...`, `9a75bd6f-...`) | `87075ed6...` (`ea03994d` Pass 1) | `e4e2fffded420e64a27eac6d9cae598054a24c0bfe874b09c633c6a714bcbd7e` | Carried into `R5` -> `TORN_DOWN` |
|
|
347
|
+
| `R4` | [`944c64a0-...`](conversation://944c64a0-e4c9-4272-a701-e3a32108a31b) | `all_l1` (`token_and_execution_optimization`) | Pass-1 Lead [`33c3f9c7-6a47-4518-a220-397ffc65055c`](conversation://33c3f9c7-6a47-4518-a220-397ffc65055c); Re-Verify Lead [`12823ed4-...`](conversation://12823ed4-8327-47d8-898f-0111658446d7) (`3eb6a22a-...`, `9712fd55-...`) | `c65509de...` (`33c3f9c7` Pass 1) | `d104a49c2ef2aea6c54c2c0527149bc681233bd3dcccfefd48bc99e71b3a598a` | Carried into `R5` -> `TORN_DOWN` |
|
|
348
|
+
| `R5` | [`944c64a0-...`](conversation://944c64a0-e4c9-4272-a701-e3a32108a31b) | `all_l1` (`skill_and_pr_review_audit`, same-squad) | Lead [`df461fa2-c290-402a-8c85-c9ff0a7800aa`](conversation://df461fa2-c290-402a-8c85-c9ff0a7800aa), S1 [`c4a2bcc3-d172-43a9-9159-66712afbb860`](conversation://c4a2bcc3-d172-43a9-9159-66712afbb860), S2 [`9c852437-eb95-4c38-a46b-a952a404f01b`](conversation://9c852437-eb95-4c38-a46b-a952a404f01b) | `de2d3e1fc9ba66e76dc7e53f2f82e43421a4b686a442419eb592d3a8a05d1527` | `ec511d82b57556860f5367e4eea0232982e42730ad20fdd825a6267c5598de79` | `TORN_DOWN` (`L41`) & `killed` |
|
|
349
|
+
| `R5` | [`944c64a0-...`](conversation://944c64a0-e4c9-4272-a701-e3a32108a31b) | `all_l1` (`runtime_and_contract_diagnosis`, same-squad) | Lead [`cf9154ea-7006-413a-8633-51a7d69b4dfd`](conversation://cf9154ea-7006-413a-8633-51a7d69b4dfd), S1 [`e550107f-e62e-40f9-b67f-ce1961b4a631`](conversation://e550107f-e62e-40f9-b67f-ce1961b4a631), S2 [`9a75bd6f-c654-44d4-9b1c-1750f157f4c8`](conversation://9a75bd6f-c654-44d4-9b1c-1750f157f4c8) | `e4e2fffded420e64a27eac6d9cae598054a24c0bfe874b09c633c6a714bcbd7e` | `2c148268adbcbaf8f1ea0902d28017bec88c31222d1d10679c440c60416831bf` | `TORN_DOWN` (`L41`) & `killed` |
|
|
350
|
+
| `R5` | [`944c64a0-...`](conversation://944c64a0-e4c9-4272-a701-e3a32108a31b) | `all_l1` (`token_and_execution_optimization`, same-squad) | Lead [`12823ed4-8327-47d8-898f-0111658446d7`](conversation://12823ed4-8327-47d8-898f-0111658446d7), S1 [`3eb6a22a-9cdb-4444-91f5-ec37042432f2`](conversation://3eb6a22a-9cdb-4444-91f5-ec37042432f2), S2 [`9712fd55-209d-46cd-9dd3-a8af87856ca9`](conversation://9712fd55-209d-46cd-9dd3-a8af87856ca9) | `d104a49c2ef2aea6c54c2c0527149bc681233bd3dcccfefd48bc99e71b3a598a` | `8c657cc6c0d98c8c856b95394b15a9a8651850b23e6842bb68f81c5033a75830` | `TORN_DOWN` (`L41`) & `killed` |
|
|
351
|
+
| `AB-1` | [`944c64a0-...`](conversation://944c64a0-e4c9-4272-a701-e3a32108a31b) | `all_l1` (`ab_audit` vs. `/teamwork` control [`d00a4261-...`](conversation://d00a4261-5d7c-4edd-bb27-8a1f277a5420)) | Lead [`f1465008-b194-4217-b103-07bfb98d9454`](conversation://f1465008-b194-4217-b103-07bfb98d9454), S1 [`5f8a9dd9-42cd-4331-9307-4edd8e02aa54`](conversation://5f8a9dd9-42cd-4331-9307-4edd8e02aa54), S2 [`472dbd4c-0f4c-45bf-8b24-ec69923d913f`](conversation://472dbd4c-0f4c-45bf-8b24-ec69923d913f) | `N/A (blinded A/B fixture)` | `418d7ccbade0a14a5b2e165b706adf45275e7b20604df1dfe03c41a012abc945` | `TORN_DOWN` (`L41`) & `killed` |
|
|
352
|
+
|
|
353
|
+
### 9.2 Wave Finding Ledger (`1 ID = 1 Row`)
|
|
354
|
+
|
|
355
|
+
#### 9.2.1 Concise `10`-Field Records for Wave `P1` & `P2` Defects (`28` Closed Defects)
|
|
356
|
+
|
|
357
|
+
- **`R3-SCRIPT-1` (`P1`, `SCRIPT`, `Closed`):** Provenance: `L17, L41` | Source: [bin/agy-squad.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/bin/agy-squad.mjs#L178-L185) (`runSession`) | Trigger: Inline-task `--launch` (`!options.manifest`) fails after MCP staging without writing `report.md` | Expected/Actual: Remove `run.directory` when `!keptEvidence`; pre-fix left `run-<uuid>` directory behind (observed) | Impact: Orphans `scratch/agy-squad/run-*` directories | Remediation: Gate cleanup solely on `!keptEvidence` | Acceptance: [test-run.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-run.mjs#L177-L180) | Related: `SVC-002` | Closure: Fixed in `2b284f4`, re-verified by `13edc973-...` (`2a4427b3...`).
|
|
358
|
+
- **`R3-TEST-1` (`P1`, `TEST`, `Closed`):** Provenance: `L7, L41` | Source: [diagnose.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/scripts/diagnose.mjs#L25-L30), [test-run.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-run.mjs#L193-L201) | Trigger: Running `npm test` concurrently with an active live squad cohort | Expected/Actual: Isolate test scratch root; pre-fix asserted `repoRoot/scratch` non-existence directly (observed failure mid-cohort) | Impact: False CI/local test failure during live dogfooding | Remediation: Honor `AGY_SQUAD_SCRATCH_ROOT` in `diagnose.mjs` and `test-run.mjs` | Acceptance: `test-run.mjs:193-201` | Related: `R5-SKILL-P2-2` | Closure: Fixed in `90485b2`, re-verified by `13edc973-...` (`2a4427b3...`).
|
|
359
|
+
- **`R4-SKILL-LEDGER-GATE` (`P1`, `SKILL`, `Closed`):** Provenance: Operator requirement & `L41` | Source: [self-diagnosis/SKILL.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/SKILL.md#L52-L60), [diagnose.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/scripts/diagnose.mjs#L55-L360) | Trigger: Running `/self-diagnosis` remediation or `--teardown` without updating `docs/reviews/` | Expected/Actual: Durable pre-remediation/pre-teardown ledger export required; pre-fix skill lacked gate (observed) | Impact: Cohort provenance and findings lost when `scratch/` is torn down | Remediation: Enforce Step 2.3 gate + `DOC-LEDGER-MISSING` / `mtimeMs` / `v1.3.0` schema checks | Acceptance: `diagnose.mjs` + `test-run.mjs` | Related: `R5-SCRIPT-P2-3` | Closure: Closed in `9f9552d`, re-verified in `ec511d82...`.
|
|
360
|
+
- **`R3-RUN-1` (`P2`, `RUN`, `Closed`):** Provenance: `L4, L17` | Source: [`resolveReportRoot`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/handoffs.mjs#L116-L130) | Trigger: Calling `bundle`/`verify`/`prune` on managed-run slot `scratch/agy-squad/run-<uuid>/plan-<hash>/squad-<id>/...` | Expected/Actual: Accept managed report roots; pre-fix hardcoded `scratch/agy-squad/squad-<id>` (observed) | Impact: Managed cohorts could not bundle reports | Remediation: Resolve dynamic managed `reportRoot` prefix | Acceptance: [test-handoffs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-handoffs.mjs#L137-L159) | Related: `SVC-001` | Closure: Fixed in `2b284f4`, re-verified in `2a4427b3...`.
|
|
361
|
+
- **`R3-RUN-2` (`P2`, `RUN`, `Closed`):** Provenance: `L1, L2` | Source: [`readSynthesis`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/handoffs.mjs#L193-L214) | Trigger: `lead/report.md` containing `"Pass the arguments"` or inline `` `FAIL` `` | Expected/Actual: Case-sensitive uppercase token check outside code spans; pre-fix matched case-insensitively and inside single backticks (observed) | Impact: False accept/reject on valid synthesis prose | Remediation: Strip code spans and match uppercase verdict tokens | Acceptance: `test-handoffs.mjs:84-90` | Related: `SVC-003`, `R4-SVC-P2-1`, `R5-RUN-P2-1` | Closure: Fixed in `2b284f4`, re-verified in `2a4427b3...`.
|
|
362
|
+
- **`R3-SCRIPT-2` (`P2`, `SCRIPT`, `Closed`):** Provenance: `L17` | Source: [bin/terminal.py](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/bin/terminal.py#L65-L95) | Trigger: Operator presses `Ctrl+C` (`\x03`) during 15s startup wait while `stdin` is raw | Expected/Actual: Forward `SIGINT` immediately; pre-fix swallowed `\x03` until prompt submission (source + PTY repro) | Impact: Uninterruptible 15s hang on startup | Remediation: Detect `b"\x03"` pre-submission and signal child | Acceptance: `test-run.mjs:220-258` | Related: `SCRIPT-001`, `R4-SCRIPT-P2-1` | Closure: Fixed in `2b284f4`, re-verified in `2a4427b3...`.
|
|
363
|
+
- **`R3-SCRIPT-3` (`P2`, `SCRIPT`, `Closed`):** Provenance: `L17` | Source: [bin/terminal.py](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/bin/terminal.py#L48-L75) | Trigger: PTY chunks split `agent` name and `"? for shortcuts"` across `4096 B` reads | Expected/Actual: Sticky latch flags across `16 KiB` rolling window; pre-fix required both in one `4096 B` slice | Impact: Startup timeout on fragmented TUI output | Remediation: Track `seen_agent` / `seen_shortcuts` latches | Acceptance: `test-run.mjs` | Related: `SCRIPT-GAP-002` | Closure: Fixed in `2b284f4`, re-verified in `2a4427b3...`.
|
|
364
|
+
- **`R3-SCRIPT-4` (`P2`, `SCRIPT`, `Closed`):** Provenance: `L7, L41` | Source: [bin/agy-squad.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/bin/agy-squad.mjs#L178-L185) | Trigger: Payload-preview run (`!options.launch`) exits `0` | Expected/Actual: Remove empty preview `run-<uuid>` dir; pre-fix retained dir on status `0` | Impact: `scratch/agy-squad/run-*` accumulation | Remediation: Clean up `run.directory` whenever `!options.launch && !keptEvidence` | Acceptance: `test-run.mjs:147` | Related: `R3-SCRIPT-1` | Closure: Fixed in `2b284f4`, re-verified in `2a4427b3...`.
|
|
365
|
+
- **`R3-TEST-2` (`P2`, `TEST`, `Closed`):** Provenance: `L7, L17` | Source: [tests/test-run.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-run.mjs#L145-L190) | Trigger: Regressions in preview/failed-inline cleanup or invalid CLI flags (`--mode`, `--manifest` without `--squad`, control chars) | Expected/Actual: Direct CLI assertions required; pre-fix lacked coverage | Impact: Launcher regressions could ship silently | Remediation: Add negative CLI and cleanup assertions in `test-run.mjs` | Acceptance: `test-run.mjs:147,177-190` | Related: `R3-SCRIPT-1`, `R3-SCRIPT-4` | Closure: Fixed in `2b284f4`, re-verified in `2a4427b3...`.
|
|
366
|
+
- **`R4-MCP-P2-1` (`P2`, `MCP`, `Closed`):** Provenance: `L3, L5` | Source: [mcp/dispatch.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/dispatch.mjs#L89-L170) | Trigger: Managed single-squad dispatch (`squadId !== "all_l1"`) with invalid `lead` or sibling squad | Expected/Actual: Validate all staged squads uniformly; Wave R4 fixed `squad.lead !== undefined` and Wave R5 closed inline-lead symmetry | Impact: Malformed sibling/inline lead staged onto disk | Remediation: Full validation in `resolveSquadLead` + `specialistAssignments` | Acceptance: `test-dispatch.mjs:128-147` | Related: `R5-ARCH-P2-1` | Closure: Closed via `R5-ARCH-P2-1` in `771b5d4` (`ec511d82...`, `2c148268...`).
|
|
367
|
+
- **`R4-RUN-P2-1` (`P2`, `RUN`, `Closed`):** Provenance: `L1, L21` | Source: [`buildSubagentSpec`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/briefs.mjs#L44-L55) | Trigger: `scopeFiles` containing `/etc/passwd`, `C:\foo`, or `./a/./b` | Expected/Actual: Reject absolute paths and `.` segments (allowing `"."`); pre-fix only checked `..` and newlines | Impact: Out-of-workspace scope instructions compiled into prompts | Remediation: Reject leading `/`, `\`, drive letters, and `.` segments | Acceptance: `test-dispatch.mjs` | Related: `R3-MCP-2`, `SVC-P3-02r` | Closure: Closed in `771b5d4`, re-verified in `2c148268...`.
|
|
368
|
+
- **`R4-SVC-P2-1` (`P2`, `SVC`, `Closed`):** Provenance: `L1, L2` | Source: [`readSynthesis`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/handoffs.mjs#L193-L214) | Trigger: `~~~` tilde code fences, `: fail` lowercase prose, or `| FAIL |` Markdown table verdicts in `lead/report.md` | Expected/Actual: Strip `~~~` fences and detect table/prose `FAIL`/`BLOCKED` without false-positiving lowercase prose | Impact: Verdict misparse during `bundle`/`verify` | Remediation: Strip `~~~` fences and anchor uppercase `PASS`/`FAIL`/`BLOCKED` patterns | Acceptance: `test-handoffs.mjs` | Related: `R5-RUN-P2-1` | Closure: Closed in `771b5d4`, re-verified in `2c148268...`.
|
|
369
|
+
- **`R4-SCRIPT-P2-1` (`P2`, `SCRIPT`, `Closed`):** Provenance: `L17` | Source: [bin/terminal.py](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/bin/terminal.py#L75-L95) | Trigger: Operator types non-`\x03` bytes during startup after `\x03` branch added in `R3-SCRIPT-2` | Expected/Actual: Drop/hold non-`\x03` bytes until `submitted == True`; R3 fix wrote read `stdin` chunk to `master` | Impact: Premature keystroke injection into TUI | Remediation: Gate `os.write(master, data)` on `if submitted:` | Acceptance: `terminal.py` + `test-run.mjs` | Related: `R3-SCRIPT-2` | Closure: Closed in `771b5d4`, re-verified in `2c148268...`.
|
|
370
|
+
- **`R4-SCRIPT-P2-2` (`P2`, `SCRIPT`, `Closed`):** Provenance: `SKILL` link integrity | Source: [`checkRelativeLinks`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/scripts/diagnose.mjs#L389-L405) | Trigger: Relative links with backticked labels `` [`code`](./target.md) `` | Expected/Actual: Validate link target while ignoring links inside code spans; R4 regex bridged across two code spans on one line | Impact: Missed broken relative links in `SKILL.md` | Remediation: Replace balanced CommonMark backtick spans `(`+)([^\r\n]*?)\1` with `"CODE"` | Acceptance: `diagnose.mjs` (`9/9` links) | Related: `R5-SCRIPT-P2-1` | Closure: Closed via `R5-SCRIPT-P2-1` in `9f9552d` (`ec511d82...`).
|
|
371
|
+
- **`R4-SCRIPT-P2-3` (`P2`, `SCRIPT`, `Closed`):** Provenance: Deterministic CLI tooling | Source: [`parseCliArgs`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/scripts/diagnose.mjs#L890-L960) | Trigger: Mutually exclusive flags (`--markdown --teardown`) or dangling option values | Expected/Actual: Deterministic exit `1`; pre-fix silently ignored conflicting flags | Impact: Misleading CLI execution | Remediation: Strict mode exclusivity, single-dash value rejection, and `--parent-id` validation | Acceptance: `test-run.mjs:202-213` | Related: `R5-SCRIPT-P2-4` | Closure: Closed via `R5-SCRIPT-P2-4` (`ec511d82...`).
|
|
372
|
+
- **`R4-SKILL-P2-1` (`P2`, `SKILL`, `Closed`):** Provenance: [LEDGER.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/docs/plans/LEDGER.md) | Source: [pr-review/SKILL.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/pr-review/SKILL.md#L32) | Trigger: Reviewing `L18–L20` status in `pr-review/SKILL.md` | Expected/Actual: Mark `L18–L20` as passed WSL trial checks; pre-fix labeled them awaiting re-verification | Impact: False review findings against `LEDGER.md` | Remediation: Align `L18–L20, L22–L24, L28, L37, L39` classification | Acceptance: Source reconciliation | Related: `R5-SKILL-P3-1` | Closure: Closed in `9f9552d` (`ec511d82...`).
|
|
373
|
+
- **`R4-SKILL-P2-2` (`P2`, `SKILL`, `Closed`):** Provenance: Rubric & synthesis gate | Source: [diagnose.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/scripts/diagnose.mjs#L465-L475), [self-diagnosis-manifest.json](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/resources/self-diagnosis-manifest.json#L13) | Trigger: Skill drift check or non-`PASS` cohort bundling | Expected/Actual: Enforce `SKILL-DRIFT-*` check and conditional `PASS`-only bundling in manifest lead prompts | Impact: Unflagged retired-API drift or failed bundle attempts | Remediation: Add `SKILL-DRIFT-*` detector and conditional `PASS` bundling rule | Acceptance: `diagnose.mjs` | Related: `SVC-003` | Closure: Closed in `9f9552d` (`ec511d82...`).
|
|
374
|
+
- **`R5-ARCH-P2-1` (`ARCH-001` / `MCP-P2-01`) (`P2`, `ARCH`, `Closed`):** Provenance: `L3, L5` | Source: [`resolveSquadLead`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/dispatch.mjs#L89-L170) | Trigger: Squad omits `squad.lead` and supplies invalid inline top-level `typeName: "research"`, `workspace: "branch"`, or mixed `lead` + top-level lead fields | Expected/Actual: Uniform validation across inline and nested leads in unmanaged and managed modes; pre-fix bypassed `buildSubagentSpec` when `squad.lead === undefined` during single-squad dispatch | Impact: Invalid inline lead staged onto disk, failing later on `all_l1` | Remediation: Validate inline/nested leads uniformly via `resolveSquadLead` and reject mixed lead fields | Acceptance: [test-dispatch.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-dispatch.mjs#L128-L147) | Related: `R4-MCP-P2-1` | Closure: Closed in `771b5d4`, re-verified by `df461fa2-...` & `cf9154ea-...` (`ec511d82...`, `2c148268...`).
|
|
375
|
+
- **`R5-RUN-P2-1` (`P2`, `RUN`, `Closed`):** Provenance: `L1, L2` | Source: [`readSynthesis`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/handoffs.mjs#L193-L214) | Trigger: `lead/report.md` containing double-backtick `` `` `FAIL` `` `` or hyphenated `"result is fail-safe"` / `"status: fail-fast"` | Expected/Actual: Strip arbitrary-length backtick spans and require `(PASS|FAIL|BLOCKED)(?![-\w])`; pre-fix falsely rejected valid `PASS` reports | Impact: Valid lead syntheses blocked from bundling | Remediation: Use CommonMark backtick regex `(`+)([^\r\n]*?)\1` and `(?![-\w])` lookahead | Acceptance: [test-handoffs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-handoffs.mjs#L91-L95) | Related: `SVC-003`, `R4-SVC-P2-1` | Closure: Closed in `771b5d4` (`2c148268...`).
|
|
376
|
+
- **`R5-SKILL-P2-1` (`P2`, `SKILL`, `Closed`):** Provenance: Runtime boundary parity | Source: [pr-review/SKILL.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/pr-review/SKILL.md#L70-L75), [pr-review-standard.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/pr-review/references/pr-review-standard.md#L119-L123) | Trigger: Auditing Boundaries 1–3 against Wave R4/R5 runtime guards | Expected/Actual: Reflect `jsonrpc === "2.0"`, `run-state.mjs` directory checks, and `briefs.mjs` `scopeFiles`/alias guards | Impact: Stale review checklist | Remediation: Update Boundaries 1–3 in both files | Acceptance: Source reconciliation | Related: `R4-MCP-P3-1`, `R4-RUN-P3-1` | Closure: Closed in `9f9552d` (`ec511d82...`).
|
|
377
|
+
- **`R5-SKILL-P2-2` (`P2`, `SKILL`, `Closed`):** Provenance: `L7, L41` | Source: [diagnose.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/scripts/diagnose.mjs#L535-L568) | Trigger: Specialist runs `diagnose.mjs` mid-cohort while `scratch/agy-squad/squad-*` is legitimately active | Expected/Actual: Provide `--allow-active-cohort` downgrading active slots to `P3` while keeping strict `P2` post-cohort default | Impact: Mid-cohort self-diagnosis exited `1` (`CHANGES_REQUIRED`) | Remediation: Add `--allow-active-cohort` flag across CLI, `SKILL.md`, and manifest | Acceptance: [test-run.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-run.mjs#L214-L217) | Related: `R3-TEST-1` | Closure: Closed in `9f9552d` (`ec511d82...`).
|
|
378
|
+
- **`R5-SKILL-P2-3` (`SD-SKILL-02`) (`P2`, `SKILL`, `Closed`):** Provenance: Rubric threshold parity | Source: [diagnose.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/scripts/diagnose.mjs#L493-L499) | Trigger: `SKILL-SHARE-*` message vs. rubric `> 70%` when skill `> 8 KiB` rule | Expected/Actual: Exact threshold text match (`<= 70% when skill > 8 KB`) | Impact: Diagnostic message mismatch with rubric | Remediation: Align `SKILL-SHARE-*` summary and rubric wording | Acceptance: Source reconciliation | Related: `R5-DOC-P2-2` | Closure: Closed in `9f9552d` (`ec511d82...`).
|
|
379
|
+
- **`R5-DOC-P2-1` (`P2`, `DOC`, `Closed`):** Provenance: Standard Section 0 governance | Source: [pr-review-standard.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/pr-review/references/pr-review-standard.md#L1-L13) | Trigger: Modifying normative review boundaries/rules without bumping `Version` | Expected/Actual: Bump version (`1.1.0 -> 1.2.0`, and `-> 1.3.0` on report-structure update) with `Change history` row | Impact: Silent contract drift across skills and reports | Remediation: Bump version across standard, skills, rubric, `diagnose.mjs`, and ledger | Acceptance: `diagnose.mjs` + source check | Related: `SD-R5-SKILL-01` | Closure: Closed in `9f9552d` (`ec511d82...`).
|
|
380
|
+
- **`R5-DOC-P2-2` (`SD-DOC-01`) (`P2`, `DOC`, `Closed`):** Provenance: Rubric completeness | Source: [optimization-and-review-rubric.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/references/optimization-and-review-rubric.md#L41) | Trigger: `diagnose.mjs` checks `MCP-BUDGET-SCHEMA` (`> 4,096 B`) without a corresponding row in Section 2 of `rubric.md` | Expected/Actual: Every `diagnose.mjs` budget check documented in `rubric.md` | Impact: Undocumented profiler threshold | Remediation: Add `MCP tools/list Schema Response` row (`<= 2,048 B` target, `> 4,096 B` warning) | Acceptance: Source reconciliation | Related: `SD-R5-DOC-01` | Closure: Closed in `9f9552d` (`ec511d82...`).
|
|
381
|
+
- **`R5-SCRIPT-P2-1` (`SD-SCRIPT-01`) (`P2`, `SCRIPT`, `Closed`):** Provenance: CommonMark link validation | Source: [`checkRelativeLinks`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/scripts/diagnose.mjs#L389-L405) | Trigger: Line containing two inline code spans around a real Markdown link | Expected/Actual: Strip ```` ``` ````/`~~~` fences and replace balanced inline code spans `(`+)([^\r\n]*?)\1` with `"CODE"` | Impact: Real broken links between two code spans skipped | Remediation: Implement CommonMark backtick-span replacement in `checkRelativeLinks` | Acceptance: `diagnose.mjs` (`0` broken links across `11` skill links) | Related: `R4-SCRIPT-P2-2` | Closure: Closed in `9f9552d` (`ec511d82...`).
|
|
382
|
+
- **`R5-SCRIPT-P2-2` (`SD-SCRIPT-02`) (`P2`, `SCRIPT`, `Closed`):** Provenance: YAML frontmatter spec | Source: [`parseFrontmatter`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/scripts/diagnose.mjs#L375-L387) | Trigger: Quoted `name: "self-diagnosis"` or colon inside inline `description: Use when: ...` | Expected/Actual: Strip matching outer quotes on `name` and anchor next-key truncation to `\r?\n[a-zA-Z0-9_-]+:` | Impact: Valid YAML frontmatter falsely flagged as `SKILL-FM-*` `P1` | Remediation: Harden `parseFrontmatter` quote and multiline key handling | Acceptance: Source + `diagnose.mjs` | Related: `SKILL` audit | Closure: Closed in `9f9552d` (`ec511d82...`).
|
|
383
|
+
- **`R5-SCRIPT-P2-3` (`SD-SCRIPT-03`) (`P2`, `SCRIPT`, `Closed`):** Provenance: `L41` atomic teardown | Source: [`teardownSelfDiagnosisDirs`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/scripts/diagnose.mjs#L298-L373) | Trigger: `--teardown all` fails validation on squad 2 after deleting squad 1, or `--teardown all --accept <sha>` passed | Expected/Actual: Validate all target squads (`validatedDirs`) before any `fs.rmSync`, and reject `--accept` with `all` | Impact: Partial non-atomic directory deletion | Remediation: Two-pass validate-then-delete + `--accept` guard | Acceptance: [test-run.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-run.mjs#L208-L210) | Related: `R4-SKILL-LEDGER-GATE` | Closure: Closed in `9f9552d` (`ec511d82...`).
|
|
384
|
+
- **`R5-SCRIPT-P2-4` (`SD-SCRIPT-04`) (`P2`, `SCRIPT`, `Closed`):** Provenance: Deterministic CLI parsing | Source: [`parseCliArgs`](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/scripts/diagnose.mjs#L890-L960) | Trigger: Single-dash flag swallowed as option value (`--parent-id -h`) or `--ledger` combined with `--print-dispatch` | Expected/Actual: Reject `next.startsWith("-")`, validate `--parent-id` (`/^[A-Za-z0-9._:-]+$/`), and reject incompatible mode flags | Impact: Corrupted parent ID or silent flag ignore | Remediation: Harden `parseCliArgs` value/mode checks | Acceptance: [test-run.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-run.mjs#L205-L213) | Related: `R4-SCRIPT-P2-3` | Closure: Closed in `9f9552d` (`ec511d82...`).
|
|
385
|
+
|
|
386
|
+
#### 9.2.2 Atomic Wave `P3` Advisory & Optimization Closure Table (`38` Rows — `1 ID = 1 Row`)
|
|
387
|
+
|
|
388
|
+
| ID | Wave/Session | Cat | Status | Source | Defect / Proposal | Disposition / Fix | Verification & Bundle SHA |
|
|
389
|
+
| --- | --- | --- | --- | --- | --- | --- | --- |
|
|
390
|
+
| `R3-MCP-1` | `R3` / `S3` | `MCP` | **Closed** | [briefs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/briefs.mjs#L58-L67) | `buildSubagentSpec` did not trim `" research "` or whitespace-only `expectedDeliverable` (`P3`). | Trimmed `typeName` and `expectedDeliverable` prior to validation (`2b284f4`). | `test-dispatch.mjs:96-115`; `2a4427b3...` |
|
|
391
|
+
| `R3-MCP-2` | `R3` / `S3` | `MCP` | **Closed** | [briefs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/briefs.mjs#L46-L55) | `buildSubagentSpec` permitted `..` segments and embedded newlines in `scopeFiles` (`P3`). | Rejected `..` path segments and `/[\r\n]/` in `scopeFiles` (`2b284f4`). | `test-dispatch.mjs:104-111`; `2a4427b3...` |
|
|
392
|
+
| `R3-SVC-1` | `R3` / `S3` | `SVC` | **Closed** | [dispatch.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/dispatch.mjs#L25-L36) | `readWorkspaceJson` opened resolved manifest path without `O_NOFOLLOW`/`O_NONBLOCK` (`P3`). | Added `O_NOFOLLOW`/`O_NONBLOCK` + `/proc/self/fd/${fd}` regular-file verification (`2b284f4`). | `test-dispatch.mjs`; `2a4427b3...` |
|
|
393
|
+
| `R3-SVC-2` | `R3` / `S3` | `SVC` | **Closed** | [handoffs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/handoffs.mjs#L215-L260) | `bundleReports` / `inspectReports` lacked null/plain-object guards on `record` and `reports[]` (`P3`). | Added deterministic object/array shape guards (`2b284f4`). | `test-handoffs.mjs`; `2a4427b3...` |
|
|
394
|
+
| `R3-DEP-1` | `R3` / `S3` | `DEP` | **Closed** | [agy-squad.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/bin/agy-squad.mjs#L99-L115), [terminal.py](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/bin/terminal.py#L24-L30) | `run.directory` created before checking `python3`/`agy` on `PATH`; `terminal.py` caught only `FileNotFoundError` (`P3`). | Added upfront `requireBinary` check and `except OSError:` in child exec (`2b284f4`). | `test-run.mjs`; `2a4427b3...` |
|
|
395
|
+
| `R3-TEST-3` | `R3` / `S3` | `TEST` | **Closed** | [test-dispatch.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-dispatch.mjs#L96-L127) | Missing adversarial assertions for lead `typeName`/`workspace` and `scopeFiles` traversal (`P3`). | Added lead capability and `scopeFiles` traversal tests (`2b284f4`). | `test-dispatch.mjs:96-127`; `2a4427b3...` |
|
|
396
|
+
| `R3-TEST-4` | `R3` / `S3` | `TEST` | **Closed** | [test-handoffs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-handoffs.mjs#L137-L159), [test-server.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/tests/test-server.mjs) | Missing assertions for managed-slot bundling and JSON-RPC parse error framing (`P3`). | Added managed-slot lifecycle and malformed JSON-RPC tests (`2b284f4`). | `test-handoffs.mjs`, `test-server.mjs`; `2a4427b3...` |
|
|
397
|
+
| `R3-SKILL-001` | `R3` / `S3` | `SKILL` | **Closed** | [pr-review/SKILL.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/pr-review/SKILL.md#L71) | Boundary 2 blurred manifest internal symlink resolution vs. report symlink rejection (`P3`). | Documented exact `dispatch.mjs` vs. `handoffs.mjs` symlink rules (`9776bbe`). | `ecad6a81...` (`b917c585-...`) |
|
|
398
|
+
| `R3-SKILL-002` | `R3` / `S3` | `SKILL` | **Closed** | [self-diagnosis/SKILL.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/SKILL.md#L62) | Completed subagents remained `idle` after cohort closure without explicit termination step (`P3`). | Added mandatory Step 2.5 `manage_subagents(Action='kill')` rule (`90485b2`). | `ecad6a81...` (`81209cde-...`) |
|
|
399
|
+
| `R3-DOC-001` | `R3` / `S3` | `DOC` | **Closed** | [pr-review-standard.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/pr-review/references/pr-review-standard.md#L145-L155) | Missing `2026-11-08` Agy-Squad adaptation entry in `Change history` (`P3`). | Added `2026-11-08` `Change history` entry (`9776bbe`). | `ecad6a81...` (`b917c585-...`) |
|
|
400
|
+
| `R3-DOC-002` | `R3` / `S3` | `DOC` | **Closed** | [docs/tools.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/docs/tools.md#L10-L30) | `structuredContent.manifestPath` and reserved `all_l1` key undocumented in `docs/tools.md` (`P3`). | Documented both contracts in `docs/tools.md` (`9776bbe`). | `ecad6a81...` (`b917c585-...`) |
|
|
401
|
+
| `R3-OPT-B1` | `R3` / `S3` | `RUN` | **Closed** | [briefs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/briefs.mjs#L15-L40) | Verbose `superviseCohort` unmanaged lead prompt template (`P3` Optimization). | Compacted `superviseCohort` (`-21.6%` unmanaged lead bytes, `2b284f4`). | `55ae969e...` (`e59db864-...`) |
|
|
402
|
+
| `R3-OPT-B2` | `R3` / `S3` | `RUN` | **Closed** | [briefs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/briefs.mjs#L67-L115) | Verbose `managedCohort` & `buildSubagentSpec` specialist prompt boilerplate (`P3` Optimization). | Compacted specialist & managed lead templates (`-25.0%` unmanaged specialist, `2b284f4`). | `55ae969e...` (`e59db864-...`) |
|
|
403
|
+
| `R3-OPT-B3` | `R3` / `S3` | `SKILL` | **Closed** | [self-diagnosis-manifest.json](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/resources/self-diagnosis-manifest.json) | Redundant lead prompt prose across `self-diagnosis-manifest.json` (`P3` Optimization). | Trimmed manifest prompts (`-27.2%` across 3L+6S cohort, `90485b2`). | `ecad6a81...`, `55ae969e...` |
|
|
404
|
+
| `R3-OPT-IO1` | `R3` / `S3` | `SVC` | **Closed** | [handoffs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/handoffs.mjs#L230-L265) | `bundleReports` re-ran full `verifyBundle` disk re-read immediately after writing bundle (`P3` Optimization). | Eliminated redundant re-read in `bundleReports` (`145 -> 85` syscalls, `-41.4%`, `2b284f4`). | `55ae969e...` (`b7796d3e-...`) |
|
|
405
|
+
| `R3-OPT-IO2` | `R3` / `S3` | `SVC` | **Closed** | [handoffs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/handoffs.mjs#L135-L175) | `publish(..., true)` rewrote temp file + `fsyncSync` even when target bytes were identical (`P3` Optimization). | Short-circuited identical `publish()` writes (`2b284f4`). | `55ae969e...` (`b7796d3e-...`) |
|
|
406
|
+
| `R3-OPT-IO3` | `R3` / `S3` | `SVC` | **Closed** | [handoffs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/handoffs.mjs#L193-L255) | `bundleReports` opened and read `lead/report.md` twice (`readSynthesis` + `fingerprint`) (`P3` Optimization). | Reused opened synthesis buffer (`2b284f4`). | `55ae969e...` (`b7796d3e-...`) |
|
|
407
|
+
| `R3-OPT-IO4` | `R3` / `S3` | `SVC` | **Closed** | [run-state.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/run-state.mjs#L6-L32) | Repeated `lstatSync`/`realpathSync` walks on already-verified directories (`P3` Optimization). | Cached `verifiedDirs` per stage (`all_l1` syscalls `205 -> 52`, `-74.6%`, `2b284f4`). | `55ae969e...` (`b7796d3e-...`) |
|
|
408
|
+
| `R4-MCP-P3-1` | `R4` / `S3` | `MCP` | **Closed** | [index.js](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/index.js#L78-L82) | `mcp/index.js` did not reject requests omitting `jsonrpc: "2.0"` (`P3`). | Enforced `request.jsonrpc === "2.0"` (`-32600 Invalid Request`) (`771b5d4`). | `test-server.mjs`; `2c148268...` |
|
|
409
|
+
| `R4-RUN-P3-1` | `R4` / `S3` | `RUN` | **Closed** | [briefs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/briefs.mjs#L24-L38) | Conflicting `camelCase`/`PascalCase` field pairs (`role` + `Role`) silently picked one (`P3`). | Added explicit conflict rejection across all 8 agent properties (`771b5d4`). | `test-dispatch.mjs`; `2c148268...` |
|
|
410
|
+
| `R4-SVC-P3-1` | `R4` / `S3` | `SVC` | **Closed** | [handoffs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/handoffs.mjs#L10-L14) | `reconcileHandoffs` checked `\r\n` but allowed Unicode line separators `\u2028`/`\u2029` (`P3`). | Updated single-line receipt check to `/[\r\n\u2028\u2029]/` (`771b5d4`). | `test-handoffs.mjs`; `2c148268...` |
|
|
411
|
+
| `R4-SVC-P3-2` | `R4` / `S3` | `SVC` | **Closed** | [handoffs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/handoffs.mjs#L60-L66) | `reportPath` did not reject `0`, negative, or non-integer `specialistNumber` (`P3`). | Enforced positive safe integer validation on `specialistNumber` (`771b5d4`). | `test-handoffs.mjs`; `2c148268...` |
|
|
412
|
+
| `R4-OPT-01` | `R4` / `S3` | `SVC` | **Closed** | [handoffs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/handoffs.mjs#L215-L310) | Redundant buffer reads across `inspectReports` and `verifyBundleInternal` (`P3` Optimization). | Reused report buffers and verified loose paths in `bundle`/`prune` (`771b5d4`). | `8c657cc6...` (`12823ed4-...`) |
|
|
413
|
+
| `R4-OPT-03` | `R4` / `S3` | `SCRIPT` | **Closed** | [diagnose.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/scripts/diagnose.mjs#L1070-L1078) | `--markdown` output omitted per-squad handoff latency (`perSquadHandoffMs`) (`P3` Optimization). | Added `perSquadHandoffMs` to Markdown telemetry header (`9f9552d`). | `ec511d82...` (`df461fa2-...`) |
|
|
414
|
+
| `R4-DOC-P3-1` | `R4` / `S3` | `DOC` | **Closed** | [self-diagnosis/SKILL.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/SKILL.md#L44) | `skill_and_pr_review_audit` stage table omitted `SCRIPT` category (`diagnose.mjs`) (`P3`). | Added `SCRIPT` to `skill_and_pr_review_audit` table and manifest (`9f9552d`). | `ec511d82...` (`df461fa2-...`) |
|
|
415
|
+
| `R5-MCP-P3-1` | `R5` / `S3` | `MCP` | **Closed** | [dispatch.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/dispatch.mjs#L70-L88), [docs/tools.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/docs/tools.md#L20-L32) | Squads defining both `children` and `specialists` (or non-array `children`) silently ignored `children` (`P3`). | Rejected simultaneous `children` + `specialists` and non-array `children`; documented in `docs/tools.md` (`771b5d4`). | `test-dispatch.mjs`; `2c148268...` |
|
|
416
|
+
| `R5-SVC-P3-2` | `R5` / `S3` | `SVC` | **Closed** | [handoffs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/handoffs.mjs#L96), [run-state.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/run-state.mjs#L7) | POSIX `\` filename segments accepted by `workspacePath`/`ensureDirectory` and symlinked `handoffs.mjs` CLI skipped main guard (`P3`). | Rejected `\` in `handoffs.mjs` & `run-state.mjs` and used `realpathSync` (`realOrSelf`) on CLI entry guard (`771b5d4`). | `test-handoffs.mjs`; `2c148268...` |
|
|
417
|
+
| `R5-SCRIPT-P3-1` | `R5` / `S3` | `SCRIPT` | **Closed** | [terminal.py](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/bin/terminal.py#L20-L34) | Non-interactive shells passed `SIG_IGN` into PTY child and lacked `SIGKILL` escalation on shutdown (`P3`). | Reset `SIGHUP`/`SIGINT`/`SIGTERM` to `SIG_DFL` in child and added 2.0s `WNOHANG` -> `SIGKILL` escalation (`771b5d4`). | `test-run.mjs:220-258`; `2c148268...` |
|
|
418
|
+
| `R5-SVC-P3-3` | `R5` / `S3` | `SVC` | **Closed** | [agy-squad.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/bin/agy-squad.mjs#L89-L98), [diagnose.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/scripts/diagnose.mjs#L43-L53) | Whitespace-only `report.md` counted as valid evidence in `hasEvidence` (`P3`). | Required `fs.readFileSync(target, "utf8").trim().length > 0` in both `hasEvidence` helpers (`771b5d4`, `9f9552d`). | `test-run.mjs:270-300`; `2c148268...` |
|
|
419
|
+
| `R5-SCRIPT-P3-2` | `R5` / `S3` | `SCRIPT` | **Closed** | [diagnose.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/scripts/diagnose.mjs#L55-L88) | `resolveTargetReviewLedger` lacked `realpathSync` containment on `docs/reviews/` and omitted `proseShareOfMarkdown` (`P3`). | Enforced `path.dirname(real) === reviewsReal` containment and added `proseShareOfMarkdown` telemetry (`9f9552d`). | `diagnose.mjs`; `ec511d82...` |
|
|
420
|
+
| `R5-SKILL-P3-1` | `R5` / `S3` | `SKILL` | **Closed** | [pr-review/SKILL.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/pr-review/SKILL.md#L32-L60) | `SKILL.md:32` grouped WSL-trial-passed IDs with superseded Windows/Docker IDs and repeated empty-bucket prose (`P3`). | Split sub-clauses in Step 2 and factored shared empty-bucket rule in Step 4 (`9f9552d`). | `ec511d82...` (`9c852437-...`) |
|
|
421
|
+
| `R5-TEST-P3-1` | `R5` / `S3` | `TEST` | **Closed** | `tests/test-dispatch.mjs`, `tests/test-handoffs.mjs`, `tests/test-run.mjs`, `tests/test-server.mjs` | Wave R4/R5 edge guards needed dedicated adversarial regression assertions (`P3`). | Added assertions for inline/mixed leads, `children`+`specialists`, double-backticks, `fail-safe`, symlink CLI, `\`, `jsonrpc`, `Ctrl-C`, and mutated profile retention (`771b5d4`, `9f9552d`). | `npm test` (`4/4` pass); `2c148268...` |
|
|
422
|
+
| `R5-OPT-01` | `R5` / `S3` | `RUN` | **Closed** | [dispatch.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/dispatch.mjs#L138-L185), [run-state.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/run-state.mjs#L33-L74) | Managed child leads recompiled all sibling squads and re-published `manifest.json` when `alreadyStaged` (`P3` Optimization). | Skipped sibling recompilation + added `skipManifestPublish` & pre-seeded `verifiedDirs` (`-56%..-69%` spec builds, `-37.1%` syscalls) (`771b5d4`). | `8c657cc6...` (`3eb6a22a-...`, `9712fd55-...`) |
|
|
423
|
+
| `R5-OPT-02` | `R5` / `S3` | `SVC` | **Closed** | [handoffs.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/handoffs.mjs#L92-L192) | Double `workspacePath` checks in `publish()`, uncached parent dirs, duplicate `fingerprint()`, and non-fatal UTF-8 decode (`P3` Optimization). | Added `verifiedDirs`, `readOpenedFile`, deduplicated `fingerprint()`, and fatal `TextDecoder` (`-41.7%` `fingerprint` syscalls, `-58.3%` `realpathSync`) (`771b5d4`). | `8c657cc6...` (`9712fd55-...`) |
|
|
424
|
+
| `R5-OPT-03` | `R5` / `S3` | `RUN` | **Closed** | [index.js](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/mcp/index.js#L15-L65) | Unmanaged `tools/list` allocated `agentSchema` needlessly (`P3` Optimization). | Made `agentSchema` lazy (`managedRun ? ... : null`) and tightened descriptions (`503 B` unmanaged `tools/list`) (`771b5d4`). | `8c657cc6...` (`3eb6a22a-...`) |
|
|
425
|
+
| `R5-OPT-04` | `R5` / `S3` | `SVC` | **Closed** | [agy-squad.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/bin/agy-squad.mjs#L99-L170) | Duplicate `PATH` scans in `requireBinary` and uncached directory checks during session setup (`P3` Optimization). | Deduplicated `PATH` entries and shared `seenDirs` across session setup (`-100%` redundant `realpathSync`) (`771b5d4`). | `8c657cc6...` (`9712fd55-...`) |
|
|
426
|
+
| `R5-OPT-05` | `R5` / `S3` | `SKILL` | **Closed** | [self-diagnosis/SKILL.md](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/SKILL.md) | `self-diagnosis/SKILL.md` progressive disclosure tightening (`P3` Optimization). | Reduced entry prose (`9,080 B -> 7,646 B` in R5; `9,309 B` / `12%` entry share with `v1.3.0` rules) (`9f9552d`). | `ec511d82...`, `8c657cc6...` |
|
|
427
|
+
| `R5-OPT-06` | `R5` / `S3` | `SCRIPT` | **Closed** | [diagnose.mjs](https://github.com/paragon-ux/Agy-Squad/blob/2bdff1a9bd52230be931a0d9433cc6fcfd06b8c5/.agents/skills/self-diagnosis/scripts/diagnose.mjs#L620-L680) | `handoffPipelineMs` included canary fixture setup writes (`P3` Optimization). | Isolated pure `inspect -> bundle -> verify -> prune` timing (`perSquadHandoffMs`) (`9f9552d`). | `8c657cc6...` (`9712fd55-...`) |
|