agrs-sequelize-sdk 1.4.37 → 1.4.38

package/models/ApiAuditLog.js

@@ -61,6 +61,35 @@ module.exports = (sequelize, DataTypes) => {
         allowNull: false,
         defaultValue: false,
       },
+      // Client-supplied or middleware-minted X-Request-Id. Enables 1:1
+      // joins to app logs, Cloud Run traces, CampaignCreationLogsV2, and
+      // most importantly ends body_hash+30s guessing when clustering
+      // retries (the exact gap that made the 7/9 triage so slow).
+      // Nullable so the ALTER stays metadata-only on the existing rows.
+      request_id: {
+        type: DataTypes.STRING(64),
+        allowNull: true,
+      },
+      // End-to-end request duration in milliseconds, computed as
+      // Date.now() - startedAt in the res.on('finish' | 'close')
+      // handler. Replaces the imprecise (createdAt - ts) subtraction we
+      // fell back to during the 7/9 investigation. Nullable because old
+      // rows have no measurement — filling those with (createdAt - ts)
+      // would reproduce the exact signal we're trying to leave behind.
+      duration_ms: {
+        type: DataTypes.INTEGER,
+        allowNull: true,
+      },
+      // Normalized endpoint identifier (e.g. "post_adsets_bulk_pause").
+      // Every dashboard query wants to GROUP BY endpoint class, but `path`
+      // has adset/campaign ids baked in — at 14M rows GROUP BY path is
+      // useless and `path LIKE '%bulk/pause%'` is fragile + slow. Computed
+      // from req.route?.path + req.method in the audit handler; falls back
+      // to a normalized req.originalUrl when the route didn't match.
+      endpoint_family: {
+        type: DataTypes.STRING(30),
+        allowNull: true,
+      },
     },
     {
       tableName: "ApiAuditLog",
@@ -68,6 +97,20 @@ module.exports = (sequelize, DataTypes) => {
         { fields: [{ name: "user_id" }, { name: "ts", order: "DESC" }] },
         { fields: [{ name: "token_id" }, { name: "ts", order: "DESC" }] },
         { fields: ["resource_type", "resource_id"] },
+        // Primary incident-triage entry point — "give me every audit row
+        // for this X-Request-Id" is the first query in every ticket. Not
+        // unique because a retry that reuses the same id is exactly the
+        // signal we want to see.
+        { fields: ["request_id"] },
+        // Primary dashboard GROUP BY axis — replaces regex-over-path
+        // patterns. `ts DESC` because every query is a recent-window
+        // scan ("last 1h/24h by endpoint_family").
+        {
+          fields: [
+            { name: "endpoint_family" },
+            { name: "ts", order: "DESC" },
+          ],
+        },
       ],
     }
   );

package/models/PublicApiIdempotencyCache.js

@@ -0,0 +1,117 @@
+module.exports = (sequelize, DataTypes) => {
+  const PublicApiIdempotencyCache = sequelize.define(
+    "PublicApiIdempotencyCache",
+    {
+      id: {
+        type: DataTypes.UUID,
+        defaultValue: DataTypes.UUIDV4,
+        primaryKey: true,
+      },
+      // Scope every cached response to the buyer's user. Two different
+      // buyers using the same Idempotency-Key value must NOT collide, so
+      // the uniqueness index below is (user_id, key), not (key) alone.
+      user_id: {
+        type: DataTypes.UUID,
+        allowNull: false,
+        references: {
+          model: "Users",
+          key: "id",
+        },
+      },
+      // Which specific token issued the original request. Useful for
+      // support/debug ("was it the same token retrying?") but not part
+      // of uniqueness — a buyer rotating tokens mid-retry should still
+      // hit the cached response.
+      token_id: {
+        type: DataTypes.UUID,
+        allowNull: true,
+        references: {
+          model: "ApiToken",
+          key: "id",
+        },
+      },
+      // Client-supplied Idempotency-Key header. Buyer controls the value;
+      // we just store it and dedupe on it.
+      key: {
+        type: DataTypes.STRING(255),
+        allowNull: false,
+      },
+      // SHA-256 hex of the canonicalized request body. Used to reject
+      // "same key + different body" (Stripe-style strict mode) with 422.
+      // Canonicalization = JSON.stringify with sorted keys, so field-order
+      // differences don't cause a false conflict.
+      request_hash: {
+        type: DataTypes.STRING(64),
+        allowNull: false,
+      },
+      // HTTP method + path recorded for debug + admin views. Not used for
+      // dedup logic — dedup is by (user_id, key). Different endpoints
+      // reusing the same key is a client bug we surface via debug, not
+      // silently accommodate.
+      method: {
+        type: DataTypes.STRING(10),
+        allowNull: false,
+      },
+      path: {
+        type: DataTypes.STRING,
+        allowNull: false,
+      },
+      // NULL while the original request is still in-flight. Set to the
+      // final HTTP status on completion. A row with status_code IS NULL
+      // that hasn't expired means "another instance is currently
+      // processing this key" → we return 409 idempotency_inflight to
+      // the second caller so they retry after a beat.
+      status_code: {
+        type: DataTypes.INTEGER,
+        allowNull: true,
+      },
+      // Cached response body — replayed verbatim on retry hit.
+      response_body: {
+        type: DataTypes.JSONB,
+        allowNull: true,
+      },
+      // Cached response headers we want to replay (e.g. X-Request-Id
+      // from the original, Location, etc). Optional — most replays are
+      // fine without.
+      response_headers: {
+        type: DataTypes.JSONB,
+        allowNull: true,
+      },
+      // Explicit expiry column so the TTL-sweep cron/pg_cron can
+      // `DELETE WHERE expires_at < NOW()` without computing from
+      // created_at. Defaults to created_at + 24h; controller sets this
+      // when inserting so we don't rely on a DB trigger.
+      expires_at: {
+        type: DataTypes.DATE,
+        allowNull: false,
+      },
+    },
+    {
+      tableName: "PublicApiIdempotencyCache",
+      indexes: [
+        // Primary lookup: (user_id, key). UNIQUE so INSERT ... ON CONFLICT
+        // DO NOTHING atomically claims the key for the first caller — the
+        // "9 concurrent retries" burst case where only ONE request should
+        // execute the underlying work.
+        { unique: true, fields: ["user_id", "key"] },
+        // Sweep index — cron does `DELETE WHERE expires_at < NOW()`. Not
+        // partial (would need to update after every insert); regular
+        // btree is fine for the sweep pattern.
+        { fields: ["expires_at"] },
+      ],
+    }
+  );
+
+  PublicApiIdempotencyCache.associate = (models) => {
+    PublicApiIdempotencyCache.belongsTo(models.Users, {
+      foreignKey: "user_id",
+      as: "user",
+    });
+    PublicApiIdempotencyCache.belongsTo(models.ApiToken, {
+      foreignKey: "token_id",
+      as: "token",
+    });
+  };
+
+  return PublicApiIdempotencyCache;
+};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agrs-sequelize-sdk",
-  "version": "1.4.37",
+  "version": "1.4.38",
   "main": "index.js",
   "scripts": {
     "start": "node index.js",

package/.impeccable/hook.cache.json

@@ -1 +0,0 @@
-{"version":1,"sessions":{"194829a9-fb06-4c43-91c6-7f93260cdcc7":{"updatedAt":1782999300075,"files":{"/Users/yuvalbader/Developer/args-dashboard/agrs-sequelize/models/AdAccount.js":{"editCount":1,"findings":[]}}}}}

package/.worktrees/ad-review-status/LICENSE

@@ -1,21 +0,0 @@
-MIT License
-
-Copyright (c) 2024 Agressive Scale LTD
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.

package/.worktrees/ad-review-status/README.md

@@ -1,179 +0,0 @@
-# agrs-sequelize SDK
-
-The `agrs-sequelize` SDK provides a structured way to manage your database models using Sequelize ORM. It allows you to easily add, update, and manage models, with support for publishing updates to NPM and pushing changes to GitHub.
-
-## Table of Contents
-
-- [Prerequisites](#prerequisites)
-- [Installation](#installation)
-- [Usage](#usage)
-  - [Adding or Modifying Models](#adding-or-modifying-models)
-  - [Model Loading](#model-loading)
-- [Publishing Changes](#publishing-changes)
-  - [Using PowerShell (Windows)](#using-powershell-windows)
-  - [Using Bash (Linux/macOS)](#using-bash-linuxmacos)
-- [Script Details](#script-details)
-  - [run.ps1 (PowerShell Script for Windows)](#runps1-powershell-script-for-windows)
-  - [run.sh (Bash Script for Linux/macOS)](#runsh-bash-script-for-linuxmacos)
-- [Example Model File](#example-model-file)
-- [Versioning](#versioning)
-- [Troubleshooting](#troubleshooting)
-- [License](#license)
-
-## Prerequisites
-
-Ensure the following dependencies are installed on your system:
-
-- **Node.js**: [Download Node.js](https://nodejs.org/)
-- **Sequelize**: Used for database interaction.
-- **Git**: Required for version control and publishing changes to GitHub.
-- **npm**: For managing and publishing packages.
-- **PowerShell** (Windows) or **Bash** (Linux/macOS): For running automation scripts.
-
-## Installation
-
-1. **Clone the Repository:**
-
-   ```bash
-   git clone https://github.com/your-repo/agrs-sequelize.git
-   cd agrs-sequelize
-    ```
-
-2. **Install Dependencies:**
-
-   ```bash
-        npm install
-    ```
-
-
-# Usage
-
-## Adding or Modifying Models
-To add or modify models in the agrs-sequelize SDK:
-
-1. **Create or Edit a Model:**
-
-    - Add a new model file inside the models directory or edit an existing one.
-    - Each model file should export a function that initializes the model with Sequelize.
-
-```javascript
-// models/YourModel.js
-module.exports = (sequelize, DataTypes) => {
-  const YourModel = sequelize.define('YourModel', {
-    fieldName: {
-      type: DataTypes.STRING,
-      allowNull: false,
-    },
-  });
-
-  // Define associations (optional)
-  YourModel.associate = (models) => {
-    YourModel.hasMany(models.OtherModel);
-  };
-
-  return YourModel;
-}; 
-```
-
-2. **Define Associations (if required):**
-
-    Use the associate method to define relationships with other models.
-    Associations like hasMany, belongsTo, etc., are supported.
-### Model Loading
-    Models are automatically loaded when initializing Sequelize.
-    The index.js file ensures all models in the models directory are properly loaded and associated.
-
-## Publishing Changes
- After modifying or adding models, publish the changes to NPM and GitHub.
-
-### Using PowerShell (Windows)
-Open PowerShell as Administrator.
-
-Run the Script:
-
-```powershell
-./run.ps1
-```
-The script will:
-
-- Check for jq installation.
-- Bump the version in package.json.
-- Publish to NPM.
-- Commit and push changes to GitHub.
-
-### Using Bash (Linux/macOS)
-Open a Bash Terminal.
-
-Run the Script:
-
-```bash
-./run.sh
-```
-The script performs the same tasks as the PowerShell script, tailored for Bash environments.
-
-## Script Details
-### run.ps1 (PowerShell Script for Windows)
-Automates the publishing process:
-
-- Ensures jq is installed.
-- Increments the version in package.json.
-- Publishes the package to NPM.
-- Commits and pushes changes to GitHub.
-
-### run.sh (Bash Script for Linux/macOS)
-Provides similar functionality:
-
-- Checks for jq installation.
-- Bumps the package version.
-= Publishes to NPM.
-= Commits and pushes to GitHub.
-
-## Example Model File
-```javascript
-Copy code
-// models/YourModel.js
-module.exports = (sequelize, DataTypes) => {
-  const YourModel = sequelize.define('YourModel', {
-    name: {
-      type: DataTypes.STRING,
-      allowNull: false,
-    },
-  });
-
-  // Define associations (optional)
-  YourModel.associate = (models) => {
-    YourModel.hasMany(models.OtherModel);
-  };
-
-  return YourModel;
-};
-```
-In this example:
-
-YourModel has a name field.
-It has a hasMany association with OtherModel.
-## Versioning
-Versioning is handled automatically:
-
-- The scripts increment the version in package.json.
-- Follows semantic versioning (major, minor, patch).
-- Updated versions are published to NPM and committed to the repository.
-
-## Troubleshooting
-- ### Permission Issues:
-
-   - Linux/macOS: Ensure scripts have execute permissions (chmod +x run.sh).
-- ### NPM Login Errors:
-
-   - The script will prompt for NPM login if not already logged in.
-   - Verify NPM account credentials.
-
-- ### Missing Dependencies:
-
-   - The script checks for jq and installs it if missing.
-## License
-This project is licensed under the MIT License. See the LICENSE file for details.
-
-
-
-

package/.worktrees/ad-review-status/index.js

@@ -1,169 +0,0 @@
-const Sequelize = require("sequelize");
-const path = require("path");
-const fs = require("fs");
-
-// const env = process.env.NODE_ENV || "development";
-class DBModels {
-  constructor(config) {
-    this.config = config;
-    this.db = {};
-
-    // Initialize Sequelize
-    const sequelize = new Sequelize(
-      this.config.database,
-      this.config.username,
-      this.config.password,
-      {
-        host: this.config.host,
-        dialect: this.config.dialect,
-        port: this.config.port,
-        logging: false, // Enable logging to console
-        dialectOptions: {
-          ssl: {
-            require: true, // Require SSL
-            rejectUnauthorized: false, // For self-signed or unverified certificates
-          },
-        },
-        pool: {
-          max: 200, // Increase from 50, but stay under max_connections (200)
-          min: 5, // Increase minimum connections
-          acquire: 60000, // Double acquire timeout
-          idle: 30000, // Align with idle_in_transaction_session_timeout
-        },
-
-        retry: {
-          max: 5,
-          timeout: 60000,
-          match: [
-            /Connection terminated/,
-            /Connection timed out/,
-            /Operation timeout/,
-            /password authentication failed/,
-            /canceling authentication/,
-          ],
-        },
-      }
-    );
-
-    // Load all models
-    fs.readdirSync(path.join(__dirname, "models"))
-      .filter((file) => {
-        return file.indexOf(".") !== 0 && file.slice(-3) === ".js";
-      })
-      .forEach((file) => {
-        const model = require(path.join(__dirname, "models", file))(
-          sequelize,
-          Sequelize.DataTypes
-        );
-        this.db[model.name] = model;
-      });
-
-    // Set up associations
-    Object.keys(this.db).forEach((modelName) => {
-      if (this.db[modelName].associate) {
-        this.db[modelName].associate(this.db);
-      }
-    });
-
-    // Export the db object with Sequelize and models
-    this.db.sequelize = sequelize;
-    this.db.Sequelize = Sequelize;
-  }
-}
-
-module.exports = DBModels;
-
-// const Sequelize = require("sequelize");
-// const path = require("path");
-// const fs = require("fs");
-
-// class DBModels {
-//   constructor(config) {
-//     this.config = config;
-//     this.db = {};
-
-//     const sequelize = new Sequelize(
-//       this.config.database,
-//       this.config.username,
-//       this.config.password,
-//       {
-//         host: this.config.host,
-//         dialect: this.config.dialect,
-//         port: this.config.port,
-//         logging: false,
-//         dialectOptions: {
-//           ssl: {
-//             require: true,
-//             rejectUnauthorized: false,
-//           },
-//           statement_timeout: 30000,
-//           idle_in_transaction_session_timeout: 30000,
-//           connectTimeout: 30000,
-//         },
-//         pool: {
-//           max: 50, // Quarter of max connections (200)
-//           min: 0, // Start from 0 and scale up as needed
-//           acquire: 30000, // Maximum time to wait for a connection
-//           idle: 10000, // How long a connection can remain idle
-//         },
-//         retry: {
-//           max: 3,
-//           timeout: 20000,
-//           match: [
-//             /Connection terminated/,
-//             /Connection timed out/,
-//             /Operation timeout/,
-//             /ECONNRESET/,
-//             /PROTOCOL_CONNECTION_LOST/,
-//           ],
-//         },
-//       }
-//     );
-
-//     // Add connection monitoring listeners
-//     sequelize.connectionManager.on("acquire", function (connection) {
-//       console.log("Connection %d acquired", connection.threadId);
-//     });
-
-//     sequelize.connectionManager.on("release", function (connection) {
-//       console.log("Connection %d released", connection.threadId);
-//     });
-
-//     // Load all models
-//     fs.readdirSync(path.join(__dirname, "models"))
-//       .filter((file) => {
-//         return file.indexOf(".") !== 0 && file.slice(-3) === ".js";
-//       })
-//       .forEach((file) => {
-//         const model = require(path.join(__dirname, "models", file))(
-//           sequelize,
-//           Sequelize.DataTypes
-//         );
-//         this.db[model.name] = model;
-//       });
-
-//     // Set up associations
-//     Object.keys(this.db).forEach((modelName) => {
-//       if (this.db[modelName].associate) {
-//         this.db[modelName].associate(this.db);
-//       }
-//     });
-
-//     // Export the db object with Sequelize and models
-//     this.db.sequelize = sequelize;
-//     this.db.Sequelize = Sequelize;
-//   }
-
-//   // Add method for pool monitoring
-//   async getConnectionPoolStats() {
-//     const pool = this.db.sequelize.connectionManager.pool;
-//     return {
-//       all: pool.size,
-//       available: pool.available,
-//       borrowed: pool.borrowed,
-//       pending: pool.pending,
-//     };
-//   }
-// }
-
-// module.exports = DBModels;

package/.worktrees/ad-review-status/migrations/2026-05-17-PIXELS-FOLLOWUP.md

@@ -1,85 +0,0 @@
-# Platform column normalization — follow-on work
-
-## Tables skipped from the 2026-05-17 platform rollout
-
-The following 4 tables were intentionally OMITTED from the 2026-05-17 platform-column
-rollout because each already has a `platform` column of type VARCHAR with
-capitalized values (e.g. "Facebook"). Adding an ENUM column with the same name
-would either fail outright or destructively override existing data.
-
-| Table                          | Existing column type | Existing values seen                                   |
-|--------------------------------|----------------------|--------------------------------------------------------|
-| `Pixels`                       | varchar              | "Facebook", "Tiktok", "Taboola", "Outbrain", "Yahoo"   |
-| `CampaignCreationLogs`         | varchar(50)          | "Facebook", "fb", NULL                                 |
-| `CampaignCreationLogsV2`       | varchar(50)          | "Facebook", "fb", NULL                                 |
-| `rsoc_feed_campaigns`          | varchar              | "Facebook", "fb"                                       |
-
-The rest of the rollout uses lowercase short codes: `fb`, `tt`, `snp`.
-
-## Why we did not "just add another column"
-
-A naive `addColumn("platform")` collides with the existing column name. A naive
-`UPDATE` to lowercase the values would touch production data and is destructive.
-Both violate the safety constraint of this rollout (additive only).
-
-## Recommended path (separate plan)
-
-For each of the 4 tables:
-
-1. Add a new column `platform_code` ENUM('fb','tt','snp','tab','out','yh') NOT NULL DEFAULT 'fb'
-2. Backfill in a single transaction. Example for Pixels:
-   ```sql
-   UPDATE "Pixels" SET platform_code = CASE platform
-     WHEN 'Facebook' THEN 'fb'
-     WHEN 'Tiktok'   THEN 'tt'
-     WHEN 'Taboola'  THEN 'tab'
-     WHEN 'Outbrain' THEN 'out'
-     WHEN 'Yahoo'    THEN 'yh'
-     ELSE 'fb'
-   END;
-   ```
-   For CampaignCreationLogs / CampaignCreationLogsV2 / rsoc_feed_campaigns the
-   backfill is simpler:
-   ```sql
-   UPDATE "CampaignCreationLogs" SET platform_code = CASE LOWER(COALESCE(platform, 'fb'))
-     WHEN 'facebook' THEN 'fb'
-     WHEN 'fb'       THEN 'fb'
-     WHEN 'tiktok'   THEN 'tt'
-     WHEN 'tt'       THEN 'tt'
-     ELSE 'fb'
-   END;
-   ```
-3. Update server code to read `platform_code` for new logic; leave the legacy
-   `platform` column untouched for backward compat.
-4. Eventually deprecate the legacy `platform` column and rename `platform_code`
-   → `platform` once all callers have migrated. That happens in a separate,
-   later cleanup plan.
-
-## Until then
-
-The dashboard's platform adapter (created in the Phase 0 backend plan) MUST
-normalize legacy `platform` values when comparing to the canonical fb/tt/snp
-codes. Example normalizer:
-
-```javascript
-function normalizeLegacyPlatform(legacy) {
-  if (!legacy) return "fb";
-  const map = {
-    Facebook: "fb",
-    facebook: "fb",
-    FB: "fb",
-    fb: "fb",
-    Tiktok: "tt",
-    TikTok: "tt",
-    tiktok: "tt",
-    tt: "tt",
-    Snapchat: "snp",
-    snapchat: "snp",
-    snp: "snp",
-    Taboola: "tab",
-    Outbrain: "out",
-    Yahoo: "yh",
-  };
-  return map[legacy] || "fb";
-}
-```

package/.worktrees/ad-review-status/migrations/2026-05-17-add-platform-to-ad.js

@@ -1,19 +0,0 @@
-"use strict";
-
-module.exports = {
-  up: async (queryInterface, Sequelize) => {
-    await queryInterface.addColumn("Ad", "platform", {
-      type: Sequelize.ENUM("fb", "tt", "snp"),
-      allowNull: false,
-      defaultValue: "fb",
-      comment: "Ad platform identifier: fb=Facebook, tt=TikTok, snp=Snapchat",
-    });
-  },
-
-  down: async (queryInterface, Sequelize) => {
-    await queryInterface.removeColumn("Ad", "platform");
-    await queryInterface.sequelize.query(
-      'DROP TYPE IF EXISTS "enum_Ad_platform";'
-    );
-  },
-};

package/.worktrees/ad-review-status/migrations/2026-05-17-add-platform-to-adaccount.js

@@ -1,19 +0,0 @@
-"use strict";
-
-module.exports = {
-  up: async (queryInterface, Sequelize) => {
-    await queryInterface.addColumn("AdAccount", "platform", {
-      type: Sequelize.ENUM("fb", "tt", "snp"),
-      allowNull: false,
-      defaultValue: "fb",
-      comment: "Ad platform identifier: fb=Facebook, tt=TikTok, snp=Snapchat",
-    });
-  },
-
-  down: async (queryInterface, Sequelize) => {
-    await queryInterface.removeColumn("AdAccount", "platform");
-    await queryInterface.sequelize.query(
-      'DROP TYPE IF EXISTS "enum_AdAccount_platform";'
-    );
-  },
-};