agroptima-design-system 0.28.5-beta.3 → 0.28.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agroptima-design-system",
-  "version": "0.28.5-beta.3",
+  "version": "0.28.5",
   "scripts": {
     "dev": "npm run storybook",
     "storybook": "storybook dev -p 6006 --ci",

package/src/atoms/Modal/Modal.tsx

@@ -24,7 +24,6 @@ export interface ModalProps {
   id: string
   title: string
   variant?: Variant
-  closeButton?: boolean
   scrollable?: boolean
   className?: string
   onClose?: () => void
@@ -46,22 +45,23 @@ export function Modal({
   buttons,
   onClose,
   children,
-  closeButton = false,
   variant = 'details',
   ...props
 }: ModalProps) {
+  const isDetails = variant === 'details'
+  const showCloseButton = onClose && isDetails
   return (
     <ModalDialog
       aria-labelledby={`${id}-title`}
       aria-describedby={`${id}-body`}
       onClose={onClose}
-      details={variant === 'details'}
+      details={isDetails}
       {...props}
     >
       <ModalHeader>
         {ICONS[variant]}
         <ModalTitle id={`${id}-title`}>{title}</ModalTitle>
-        {closeButton && <ModalCloseButton onClick={onClose} />}
+        {showCloseButton && <ModalCloseButton onClick={onClose} />}
       </ModalHeader>
       <ModalBody id={`${id}-body`}>{children}</ModalBody>
       <ModalFooter>

package/src/stories/Changelog.mdx

@@ -4,6 +4,11 @@ import { Meta } from "@storybook/blocks";
 
 # Changelog
 
+## 0.28.5
+
+* Remove closeButton property to Modal component.
+
+
 ## 0.28.4
 
 * Update Modal component to adapt to the content height.

package/src/stories/Modal.stories.js

@@ -46,9 +46,6 @@ const meta = {
     onClose: {
       description: 'Function to be called when the modal is closed',
     },
-    closeButton: {
-      description: 'If the modal should have a close button',
-    },
   },
   parameters: figmaPrimaryDesign,
 }
@@ -158,7 +155,6 @@ export const DeleteOrDiscard = {
 export const LargeModal = () => (
   <Modal
     title="Large Modal"
-    closeButton
     onClose={() => alert('Close')}
     buttons={[
       { label: 'Close', variant: 'neutral', onClick: () => alert('Close') },
@@ -273,7 +269,6 @@ export const FormModal = () => (
   >
     <Modal
       title="Form Modal"
-      closeButton
       onClose={() => alert('Close')}
       buttons={[
         {