agl 21.0.0 → 21.0.2

package/dist_ts/interfaces.gitreversion.d.ts

@@ -4,7 +4,7 @@ export type TGitReversionDirection = 'undo' | 'redo';
 export type TGitReversionSideName = 'before' | 'after';
 export type TGitReversionWalPhase = 'intent' | 'preflighted' | 'applying' | 'targetVerified' | 'decision' | 'committed' | 'compensating' | 'compensated' | 'fenced';
 export type TGitReversionWorktreeState = 'intent' | 'created' | 'registered' | 'active' | 'removing' | 'retainedDirty' | 'removed' | 'fenced';
-export type TGitReversionFaultPoint = 'intent.before-fsync' | 'intent.after-fsync' | 'intent.before-ref-cas' | 'intent.after-ref-cas' | 'intent.before-commit-fsync' | 'intent.after-commit-fsync' | 'intent.before-remove' | 'intent.after-remove' | 'atomic.after-rename-before-directory-fsync' | 'capture.after-before-scan' | 'capture.before-finalize-record' | 'capture.after-finalize-record-fsync' | 'capture.after-staging-repository' | 'capture.after-intent-repository' | 'capture.after-state-repository' | 'capture.after-manifest-repository' | 'capture.before-store-create' | 'capture.after-store-create' | 'capture.before-generation-enrollment' | 'capture.after-generation-enrollment' | 'capture.after-publication-fsync' | 'capture.before-root-delete' | 'capture.after-root-delete' | 'capture.after-root-delete-fsync' | 'apply.after-intent' | 'apply.after-preflight' | 'apply.after-source-pack-import' | 'apply.after-source-pack-fsync' | 'apply.after-repository' | 'apply.after-target-verification' | 'apply.after-decision-repository' | 'apply.after-decision' | 'apply.after-state-repository' | 'apply.during-compensation' | 'apply.before-source-keep-remove' | 'apply.after-source-keep-quarantine' | 'apply.after-source-keep-remove' | 'apply.after-source-keep-remove-fsync' | 'worktree.after-intent' | 'worktree.after-create' | 'worktree.after-removed-record' | 'index.before-sidecar-fsync' | 'index.after-sidecar-fsync' | 'index.after-link' | 'index.after-link-fsync' | 'index.after-rename' | 'index.after-rename-fsync' | 'index.after-cleanup' | 'index.after-cleanup-fsync';
+export type TGitReversionFaultPoint = 'intent.before-fsync' | 'intent.after-fsync' | 'intent.before-ref-cas' | 'intent.after-ref-cas' | 'intent.before-commit-fsync' | 'intent.after-commit-fsync' | 'intent.before-remove' | 'intent.after-remove' | 'atomic.after-rename-before-directory-fsync' | 'capture.after-before-scan' | 'capture.before-finalize-record' | 'capture.after-finalize-record-fsync' | 'capture.after-staging-repository' | 'capture.after-intent-repository' | 'capture.after-state-repository' | 'capture.after-manifest-repository' | 'capture.before-store-create' | 'capture.after-store-create' | 'capture.before-generation-enrollment' | 'capture.after-generation-enrollment' | 'capture.after-publication-fsync' | 'capture.before-root-delete' | 'capture.after-root-delete' | 'capture.after-root-delete-fsync' | 'apply.after-intent' | 'apply.after-preflight' | 'apply.after-source-pack-import' | 'apply.after-source-pack-fsync' | 'apply.after-repository' | 'apply.after-target-verification' | 'apply.after-decision-repository' | 'apply.after-decision' | 'apply.after-state-repository' | 'apply.during-compensation' | 'apply.before-source-keep-remove' | 'apply.after-source-keep-quarantine' | 'apply.after-source-keep-remove' | 'apply.after-source-keep-remove-fsync' | 'worktree.after-intent' | 'worktree.after-create' | 'worktree.after-removed-record' | 'worktree.record-read.after-open' | 'index.before-sidecar-fsync' | 'index.after-sidecar-fsync' | 'index.after-link' | 'index.after-link-fsync' | 'index.after-rename' | 'index.after-rename-fsync' | 'index.after-cleanup' | 'index.after-cleanup-fsync';
 export type TGitReversionReference = {
     schemaVersion: 1;
     captureKey: string;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agl",
-  "version": "21.0.0",
+  "version": "21.0.2",
   "controllerUpgradeManagementVersion": 2,
   "private": false,
   "description": "Agent Gateway Layer for OpenCode and FlexHarness sessions",
@@ -18,7 +18,7 @@
   "dependencies": {
     "@api.global/typedrequest": "8.0.2",
     "@api.global/typedrequest-interfaces": "7.1.0",
-    "@api.global/typedserver": "11.0.0",
+    "@api.global/typedserver": "11.1.0",
     "@api.global/typedsocket": "8.0.0",
     "@design.estate/dees-catalog": "6.10.1",
     "@design.estate/dees-element": "2.4.0",
@@ -34,7 +34,7 @@
     "@push.rocks/smartdb": "5.2.1",
     "@push.rocks/smartfs": "1.7.0",
     "@push.rocks/smartsecret": "1.6.0",
-    "@push.rocks/smartserve": "6.0.0",
+    "@push.rocks/smartserve": "6.0.1",
     "@push.rocks/smartshell": "4.1.0",
     "@simplewebauthn/browser": "13.3.0",
     "@simplewebauthn/server": "13.3.2",

package/ts/00_commitinfo_data.ts

@@ -3,6 +3,6 @@
  */
 export const commitinfo = {
   name: 'agl',
-  version: '21.0.0',
+  version: '21.0.2',
   description: 'Agent Gateway Layer for OpenCode and FlexHarness sessions'
 }

package/ts/classes.gitreversion.ts

@@ -665,6 +665,13 @@ class GitReversionInjectedFaultError extends Error {
   }
 }
 
+class GitReversionConcurrentRecordReadError extends Error {
+  constructor(messageArg: string) {
+    super(messageArg);
+    this.name = 'GitReversionConcurrentRecordReadError';
+  }
+}
+
 class GitReversionSourceKeepOwnershipError extends GitReversionFencedError {
   constructor(messageArg: string, optionsArg?: ErrorOptions) {
     super(messageArg, optionsArg);
@@ -3182,6 +3189,8 @@ export class ControllerGitReversion {
     descriptionArg: string,
     signalArg?: AbortSignal,
     requirePrivateModeArg = false,
+    detectConcurrentReplacementArg = false,
+    afterOpenArg?: () => Promise<void>,
   ): Promise<Buffer> {
     let handle: plugins.fs.promises.FileHandle;
     try {
@@ -3196,7 +3205,13 @@ export class ControllerGitReversion {
       throw new Error(`${descriptionArg} could not be opened safely.`, { cause: errorArg });
     }
     try {
+      await afterOpenArg?.();
       const before = await handle.stat();
+      if (detectConcurrentReplacementArg && before.nlink === 0) {
+        throw new GitReversionConcurrentRecordReadError(
+          `${descriptionArg} was replaced while it was opened.`,
+        );
+      }
       if (
         !before.isFile()
         || (requirePrivateModeArg && before.nlink !== 1)
@@ -3222,12 +3237,46 @@ export class ControllerGitReversion {
         if (total > maximumBytesArg) throw new Error(`${descriptionArg} exceeds its byte limit.`);
       }
       const after = await handle.stat();
+      if (detectConcurrentReplacementArg && after.nlink === 0) {
+        throw new GitReversionConcurrentRecordReadError(
+          `${descriptionArg} was replaced while it was read.`,
+        );
+      }
       if (
         before.dev !== after.dev
         || before.ino !== after.ino
         || before.size !== after.size
         || total !== before.size
+        || !after.isFile()
+        || (requirePrivateModeArg && after.nlink !== 1)
+        || (requirePrivateModeArg && (after.mode & 0o077) !== 0)
+        || (typeof process.getuid === 'function' && after.uid !== process.getuid())
       ) throw new Error(`${descriptionArg} changed while it was read.`);
+      if (detectConcurrentReplacementArg) {
+        let pathAfter: plugins.fs.Stats;
+        try {
+          pathAfter = await plugins.fs.promises.lstat(pathArg);
+        } catch (errorArg) {
+          if ((errorArg as NodeJS.ErrnoException).code === 'ENOENT') {
+            throw new GitReversionConcurrentRecordReadError(
+              `${descriptionArg} was removed while it was read.`,
+            );
+          }
+          throw errorArg;
+        }
+        if (
+          !pathAfter.isFile()
+          || pathAfter.isSymbolicLink()
+          || pathAfter.nlink !== 1
+          || (pathAfter.mode & 0o077) !== 0
+          || (typeof process.getuid === 'function' && pathAfter.uid !== process.getuid())
+        ) throw new Error(`${descriptionArg} pathname is not an exact owned regular file.`);
+        if (pathAfter.dev !== after.dev || pathAfter.ino !== after.ino) {
+          throw new GitReversionConcurrentRecordReadError(
+            `${descriptionArg} was replaced while its pathname was revalidated.`,
+          );
+        }
+      }
       return Buffer.concat(chunks, total);
     } finally {
       await handle.close();
@@ -12121,18 +12170,34 @@ export class ControllerGitReversion {
 
   private async readWorktreeRecordByRef<T>(refArg: string): Promise<{ oid: string; value: T } | undefined> {
     const path = this.worktreeRecordPathForRef(refArg);
-    let bytes: Buffer;
-    try {
-      bytes = await this.readBoundedRegularFile(
-        path,
-        this.limits.maximumMetadataRecordBytes,
-        'Private worktree record',
-        undefined,
-        true,
+    let bytes: Buffer | undefined;
+    let concurrentReadError: GitReversionConcurrentRecordReadError | undefined;
+    for (let attempt = 0; attempt < 4; attempt += 1) {
+      try {
+        bytes = await this.readBoundedRegularFile(
+          path,
+          this.limits.maximumMetadataRecordBytes,
+          'Private worktree record',
+          undefined,
+          true,
+          true,
+          () => this.fault({ point: 'worktree.record-read.after-open', ref: refArg }),
+        );
+        break;
+      } catch (errorArg) {
+        if ((errorArg as NodeJS.ErrnoException).code === 'ENOENT') return undefined;
+        if (errorArg instanceof GitReversionConcurrentRecordReadError) {
+          concurrentReadError = errorArg;
+          continue;
+        }
+        throw errorArg;
+      }
+    }
+    if (!bytes) {
+      throw new GitReversionFencedError(
+        'The private worktree record changed repeatedly while it was read.',
+        { cause: concurrentReadError },
       );
-    } catch (errorArg) {
-      if ((errorArg as NodeJS.ErrnoException).code === 'ENOENT') return undefined;
-      throw errorArg;
     }
     let value: unknown;
     try {

package/ts/interfaces.gitreversion.ts

@@ -64,6 +64,7 @@ export type TGitReversionFaultPoint =
   | 'worktree.after-intent'
   | 'worktree.after-create'
   | 'worktree.after-removed-record'
+  | 'worktree.record-read.after-open'
   | 'index.before-sidecar-fsync'
   | 'index.after-sidecar-fsync'
   | 'index.after-link'

package/ts_web/00_commitinfo_data.ts

@@ -3,6 +3,6 @@
  */
 export const commitinfo = {
   name: 'agl',
-  version: '21.0.0',
+  version: '21.0.2',
   description: 'Agent Gateway Layer for OpenCode and FlexHarness sessions'
 }