agileflow 2.99.8 → 3.0.0

package/scripts/agileflow-welcome.js

@@ -13,7 +13,7 @@
 
 const fs = require('fs');
 const path = require('path');
-const { execFileSync, spawnSync } = require('child_process');
+const { executeCommandSync, git, spawnBackground } = require('../lib/process-executor');
 
 // Shared utilities
 const { c, box } = require('../lib/colors');
@@ -30,23 +30,7 @@ const { readJSONCached, readFileCached } = require('../lib/file-cache');
 // Session manager path (relative to script location)
 const SESSION_MANAGER_PATH = path.join(__dirname, 'session-manager.js');
 
-// Story claiming module
-let storyClaiming;
-try {
-  storyClaiming = require('./lib/story-claiming.js');
-} catch (e) {
-  // Story claiming not available
-}
-
-// Story state machine (for epic completion check)
-let storyStateMachine;
-try {
-  storyStateMachine = require('./lib/story-state-machine.js');
-} catch (e) {
-  // Story state machine not available
-}
-
-// Hook metrics module
+// Hook metrics module (kept at top level - needed early for timer)
 let hookMetrics;
 try {
   hookMetrics = require('./lib/hook-metrics.js');
@@ -54,58 +38,9 @@ try {
   // Hook metrics not available
 }
 
-// File tracking module
-let fileTracking;
-try {
-  fileTracking = require('./lib/file-tracking.js');
-} catch (e) {
-  // File tracking not available
-}
-
-// Ideation sync module
-let syncIdeationStatus;
-try {
-  syncIdeationStatus = require('./lib/sync-ideation-status.js');
-} catch (e) {
-  // Ideation sync not available
-}
-
-// Automation registry and runner
-let automationRegistry, automationRunner;
-try {
-  automationRegistry = require('./lib/automation-registry.js');
-  automationRunner = require('./lib/automation-runner.js');
-} catch (e) {
-  // Automation system not available
-}
-
-// Update checker module
-let updateChecker;
-try {
-  updateChecker = require('./check-update.js');
-} catch (e) {
-  // Update checker not available
-}
-
-// Process cleanup module (duplicate Claude detection)
-let processCleanup;
-try {
-  processCleanup = require('./lib/process-cleanup.js');
-} catch (e) {
-  // Process cleanup not available
-}
-
-// Feature flags module (Agent Teams detection)
-let featureFlags;
-try {
-  featureFlags = require('../lib/feature-flags');
-} catch (e) {
-  // Feature flags not available
-}
-
 /**
  * PERFORMANCE OPTIMIZATION: Load all project files using LRU cache
- * Uses file-cache module for automatic caching with 30s TTL.
+ * Uses file-cache module for automatic caching with 15s TTL.
  * Files are cached across script invocations within TTL window.
  * Estimated savings: 60-120ms on cache hits
  */
@@ -177,17 +112,16 @@ function detectPlatform() {
  * Returns object with availability info and platform-specific install suggestion
  */
 function checkTmuxAvailability() {
-  try {
-    execFileSync('which', ['tmux'], { encoding: 'utf8', stdio: 'pipe' });
+  const result = executeCommandSync('which', ['tmux'], { fallback: null });
+  if (result.data !== null) {
     return { available: true };
-  } catch (e) {
-    const platform = detectPlatform();
-    return {
-      available: false,
-      platform,
-      noSudoCmd: 'conda install -c conda-forge tmux',
-    };
   }
+  const platform = detectPlatform();
+  return {
+    available: false,
+    platform,
+    noSudoCmd: 'conda install -c conda-forge tmux',
+  };
 }
 
 /**
@@ -196,21 +130,11 @@ function checkTmuxAvailability() {
  * Estimated savings: 20-40ms
  */
 function getGitInfo(rootDir) {
-  try {
-    const output = execFileSync(
-      'bash',
-      ['-c', 'git branch --show-current && git rev-parse --short HEAD && git log -1 --format="%s"'],
-      { cwd: rootDir, encoding: 'utf8', timeout: 5000 }
-    );
-    const lines = output.trim().split('\n');
-    return {
-      branch: lines[0] || 'unknown',
-      commit: lines[1] || 'unknown',
-      lastCommit: lines[2] || '',
-    };
-  } catch (e) {
-    return { branch: 'unknown', commit: 'unknown', lastCommit: '' };
-  }
+  const opts = { cwd: rootDir, timeout: 5000, fallback: 'unknown' };
+  const branch = git(['branch', '--show-current'], opts).data;
+  const commit = git(['rev-parse', '--short', 'HEAD'], opts).data;
+  const lastCommit = git(['log', '-1', '--format=%s'], { ...opts, fallback: '' }).data;
+  return { branch, commit, lastCommit };
 }
 
 function getProjectInfo(rootDir, cache = null) {
@@ -376,15 +300,13 @@ function runArchival(rootDir, cache = null) {
 
     if (toArchiveCount > 0) {
       // Run archival
-      try {
-        execFileSync('bash', ['scripts/archive-completed-stories.sh'], {
-          cwd: rootDir,
-          encoding: 'utf8',
-          stdio: 'pipe',
-        });
+      const archiveResult = executeCommandSync('bash', ['scripts/archive-completed-stories.sh'], {
+        cwd: rootDir,
+      });
+      if (archiveResult.ok) {
         result.archived = toArchiveCount;
         result.remaining -= toArchiveCount;
-      } catch (e) {}
+      }
     }
   } catch (e) {}
 
@@ -492,69 +414,68 @@ function checkParallelSessions(rootDir) {
     // Try to use combined full-status command (saves ~200ms vs 3 separate calls)
     const scriptPath = fs.existsSync(managerPath) ? managerPath : SESSION_MANAGER_PATH;
 
-    try {
-      // PERFORMANCE: Single subprocess call instead of 3 (register + count + status)
-      const fullStatusOutput = execFileSync('node', [scriptPath, 'full-status'], {
-        cwd: rootDir,
-        encoding: 'utf8',
-        stdio: ['pipe', 'pipe', 'pipe'],
-      });
-      const data = JSON.parse(fullStatusOutput);
-
-      result.registered = data.registered;
-      result.currentId = data.id;
-      result.otherActive = data.otherActive || 0;
-      result.cleaned = data.cleaned || 0;
-      result.cleanedSessions = data.cleanedSessions || [];
-
-      if (data.current) {
-        result.isMain = data.current.is_main === true;
-        result.nickname = data.current.nickname;
-        result.branch = data.current.branch;
-        result.sessionPath = data.current.path;
-      }
-    } catch (e) {
-      // Fall back to individual calls if full-status not available (older version)
+    // PERFORMANCE: Single subprocess call instead of 3 (register + count + status)
+    const fullStatusResult = executeCommandSync('node', [scriptPath, 'full-status'], {
+      cwd: rootDir, fallback: null,
+    });
+
+    if (fullStatusResult.data) {
       try {
-        const registerOutput = execFileSync('node', [scriptPath, 'register'], {
-          cwd: rootDir,
-          encoding: 'utf8',
-          stdio: ['pipe', 'pipe', 'pipe'],
-        });
-        const registerData = JSON.parse(registerOutput);
-        result.registered = true;
-        result.currentId = registerData.id;
+        const data = JSON.parse(fullStatusResult.data);
+        result.registered = data.registered;
+        result.currentId = data.id;
+        result.otherActive = data.otherActive || 0;
+        result.cleaned = data.cleaned || 0;
+        result.cleanedSessions = data.cleanedSessions || [];
+
+        if (data.current) {
+          result.isMain = data.current.is_main === true;
+          result.nickname = data.current.nickname;
+          result.branch = data.current.branch;
+          result.sessionPath = data.current.path;
+        }
       } catch (e) {
-        // Registration failed
+        // JSON parse failed, fall through to individual calls
+        fullStatusResult.data = null;
       }
+    }
 
-      try {
-        const countOutput = execFileSync('node', [scriptPath, 'count'], {
-          cwd: rootDir,
-          encoding: 'utf8',
-          stdio: ['pipe', 'pipe', 'pipe'],
-        });
-        const countData = JSON.parse(countOutput);
-        result.otherActive = countData.count || 0;
-      } catch (e) {
-        // Count failed
+    if (!fullStatusResult.data) {
+      // Fall back to individual calls if full-status not available (older version)
+      const registerResult = executeCommandSync('node', [scriptPath, 'register'], {
+        cwd: rootDir, fallback: null,
+      });
+      if (registerResult.data) {
+        try {
+          const registerData = JSON.parse(registerResult.data);
+          result.registered = true;
+          result.currentId = registerData.id;
+        } catch (e) {}
       }
 
-      try {
-        const statusOutput = execFileSync('node', [scriptPath, 'status'], {
-          cwd: rootDir,
-          encoding: 'utf8',
-          stdio: ['pipe', 'pipe', 'pipe'],
-        });
-        const statusData = JSON.parse(statusOutput);
-        if (statusData.current) {
-          result.isMain = statusData.current.is_main === true;
-          result.nickname = statusData.current.nickname;
-          result.branch = statusData.current.branch;
-          result.sessionPath = statusData.current.path;
-        }
-      } catch (e) {
-        // Status failed
+      const countResult = executeCommandSync('node', [scriptPath, 'count'], {
+        cwd: rootDir, fallback: null,
+      });
+      if (countResult.data) {
+        try {
+          const countData = JSON.parse(countResult.data);
+          result.otherActive = countData.count || 0;
+        } catch (e) {}
+      }
+
+      const statusCmdResult = executeCommandSync('node', [scriptPath, 'status'], {
+        cwd: rootDir, fallback: null,
+      });
+      if (statusCmdResult.data) {
+        try {
+          const statusData = JSON.parse(statusCmdResult.data);
+          if (statusData.current) {
+            result.isMain = statusData.current.is_main === true;
+            result.nickname = statusData.current.nickname;
+            result.branch = statusData.current.branch;
+            result.sessionPath = statusData.current.path;
+          }
+        } catch (e) {}
       }
     }
   } catch (e) {
@@ -1008,6 +929,8 @@ async function checkUpdates() {
     changelog: [],
   };
 
+  let updateChecker;
+  try { updateChecker = require('./check-update.js'); } catch (e) {}
   if (!updateChecker) return result;
 
   try {
@@ -1076,42 +999,36 @@ function getChangelogEntries(version) {
 // DEPRECATED: Use spawnAutoUpdateInBackground() instead for non-blocking updates
 async function runAutoUpdate(rootDir, fromVersion, toVersion) {
   const runUpdate = () => {
-    // Use stdio: 'pipe' to capture output instead of showing everything
-    return execFileSync('npx', ['agileflow@latest', 'update', '--force'], {
-      cwd: rootDir,
-      encoding: 'utf8',
-      stdio: 'pipe',
-      timeout: 120000, // 2 minute timeout
+    return executeCommandSync('npx', ['agileflow@latest', 'update', '--force'], {
+      cwd: rootDir, timeout: 120000,
     });
   };
 
-  try {
-    console.log(
-      `${c.skyBlue}Updating AgileFlow${c.reset} ${c.dim}v${fromVersion} → v${toVersion}${c.reset}`
-    );
-    // Use --force to skip prompts for non-interactive auto-update
-    runUpdate();
+  console.log(
+    `${c.skyBlue}Updating AgileFlow${c.reset} ${c.dim}v${fromVersion} → v${toVersion}${c.reset}`
+  );
+  const result = runUpdate();
+  if (result.ok) {
     console.log(`${c.mintGreen}✓ Update complete${c.reset}`);
     return true;
-  } catch (e) {
-    // Check if this is a stale npm cache issue (ETARGET = version not found)
-    if (e.message && (e.message.includes('ETARGET') || e.message.includes('notarget'))) {
-      console.log(`${c.dim}  Clearing npm cache and retrying...${c.reset}`);
-      try {
-        execFileSync('npm', ['cache', 'clean', '--force'], { stdio: 'pipe', timeout: 30000 });
-        runUpdate();
-        console.log(`${c.mintGreen}✓ Update complete${c.reset}`);
-        return true;
-      } catch (retryError) {
-        console.log(`${c.peach}Auto-update failed after cache clean${c.reset}`);
-        console.log(`${c.dim}  Run manually: npx agileflow update${c.reset}`);
-        return false;
-      }
+  }
+
+  // Check if this is a stale npm cache issue (ETARGET = version not found)
+  if (result.error && (result.error.includes('ETARGET') || result.error.includes('notarget'))) {
+    console.log(`${c.dim}  Clearing npm cache and retrying...${c.reset}`);
+    executeCommandSync('npm', ['cache', 'clean', '--force'], { timeout: 30000 });
+    const retryResult = runUpdate();
+    if (retryResult.ok) {
+      console.log(`${c.mintGreen}✓ Update complete${c.reset}`);
+      return true;
     }
-    console.log(`${c.peach}Auto-update failed${c.reset}`);
+    console.log(`${c.peach}Auto-update failed after cache clean${c.reset}`);
     console.log(`${c.dim}  Run manually: npx agileflow update${c.reset}`);
     return false;
   }
+  console.log(`${c.peach}Auto-update failed${c.reset}`);
+  console.log(`${c.dim}  Run manually: npx agileflow update${c.reset}`);
+  return false;
 }
 
 /**
@@ -1123,8 +1040,6 @@ async function runAutoUpdate(rootDir, fromVersion, toVersion) {
  * @param {string} toVersion - Target version
  */
 function spawnAutoUpdateInBackground(rootDir, fromVersion, toVersion) {
-  const { spawn } = require('child_process');
-
   // Track pending update in session-state.json
   try {
     const sessionStatePath = getSessionStatePath(rootDir);
@@ -1143,16 +1058,7 @@ function spawnAutoUpdateInBackground(rootDir, fromVersion, toVersion) {
   }
 
   // Create detached subprocess that survives parent exit
-  // Use shell: true to handle npx properly across platforms
-  const child = spawn('npx', ['agileflow@latest', 'update', '--force'], {
-    cwd: rootDir,
-    detached: true,
-    stdio: 'ignore', // Don't inherit stdout/stderr - prevents output after hook returns
-    shell: true,
-  });
-
-  // Allow parent to exit independently
-  child.unref();
+  spawnBackground('npx', ['agileflow@latest', 'update', '--force'], { cwd: rootDir });
 
   console.log(`${c.dim}  Auto-update starting in background...${c.reset}`);
 }
@@ -1387,7 +1293,8 @@ function formatTable(
   updateInfo = {},
   expertise = {},
   damageControl = {},
-  agentTeamsInfo = {}
+  agentTeamsInfo = {},
+  scaleDetection = {}
 ) {
   const W = 58; // inner width (total table = W + 2 = 60)
   const R = W - 25; // right column width (33 chars) to match total of 60
@@ -1528,6 +1435,8 @@ function formatTable(
   // System section (colorful labels like obtain-context)
   if (archival.disabled) {
     lines.push(row('Auto-archival', 'disabled', c.lavender, c.slate));
+  } else if (archival.skippedByScale) {
+    lines.push(row('Auto-archival', 'skipped (small project)', c.lavender, c.dim));
   } else {
     const archivalStatus =
       archival.archived > 0 ? `archived ${archival.archived} stories` : `nothing to archive`;
@@ -1616,6 +1525,22 @@ function formatTable(
     lines.push(row('Agent Teams', `${agentTeamsInfo.value}`, c.lavender, c.dim));
   }
 
+  // Scale detection (EP-0033)
+  if (scaleDetection && scaleDetection.scale) {
+    const scaleColors = {
+      micro: c.cyan, small: c.teal, medium: c.mintGreen,
+      large: c.peach, enterprise: c.coral,
+    };
+    const scaleIcons = {
+      micro: '◦', small: '○', medium: '◎', large: '●', enterprise: '◉',
+    };
+    const scale = scaleDetection.scale;
+    const icon = scaleIcons[scale] || '◎';
+    const label = scale.charAt(0).toUpperCase() + scale.slice(1);
+    const cacheNote = scaleDetection.fromCache ? '' : ` (${scaleDetection.detection_ms}ms)`;
+    lines.push(row('Scale', `${icon} ${label}${cacheNote}`, c.lavender, scaleColors[scale] || c.dim));
+  }
+
   lines.push(divider());
 
   // Current story (colorful like obtain-context)
@@ -1693,7 +1618,29 @@ async function main() {
   // All fast operations - no network, no auto-update
   // ============================================
   const info = getProjectInfo(rootDir, cache);
-  const archival = runArchival(rootDir, cache);
+
+  // Smart hook scheduling: skip archival for micro/small projects (EP-0033)
+  // Scale detection is done early to inform hook scheduling
+  let earlyScale = null;
+  try {
+    const scaleDetector = require('./lib/scale-detector');
+    // Check cache only (fast path, no full detection yet)
+    earlyScale = scaleDetector.detectScale({
+      rootDir,
+      statusJson: cache?.status,
+      sessionState: cache?.sessionState,
+    });
+  } catch (e) {
+    // Scale detection not available
+  }
+
+  const scaleRecommendations = earlyScale ? (() => {
+    try { return require('./lib/scale-detector').getScaleRecommendations(earlyScale.scale); } catch { return null; }
+  })() : null;
+
+  const archival = (scaleRecommendations && scaleRecommendations.skipArchival)
+    ? { ran: false, threshold: 0, archived: 0, remaining: 0, skippedByScale: true }
+    : runArchival(rootDir, cache);
   const session = clearActiveCommands(rootDir, cache);
   const precompact = checkPreCompact(rootDir, cache);
   const parallelSessions = checkParallelSessions(rootDir);
@@ -1702,7 +1649,12 @@ async function main() {
   const expertise = getExpertiseCountFast(rootDir);
   const damageControl = checkDamageControl(rootDir, cache);
 
+  // Use early scale detection result (already computed for hook scheduling)
+  const scaleDetection = earlyScale || { scale: 'medium' };
+
   // Agent Teams feature flag detection
+  let featureFlags;
+  try { featureFlags = require('../lib/feature-flags'); } catch (e) {}
   let agentTeamsInfo = {};
   if (featureFlags) {
     try {
@@ -1794,7 +1746,8 @@ async function main() {
       updateInfo,
       expertise,
       damageControl,
-      agentTeamsInfo
+      agentTeamsInfo,
+      scaleDetection
     )
   );
 
@@ -1822,12 +1775,18 @@ async function main() {
       }
 
       // Mark current version as seen to track for next update
+      let updateChecker;
+      try { updateChecker = require('./check-update.js'); } catch (e) {}
       if (freshUpdateInfo.justUpdated && updateChecker) {
         updateChecker.markVersionSeen(info.version);
       }
-    } else if (updateChecker) {
+    } else {
       // Mark current version as seen (for "just updated" case)
-      updateChecker.markVersionSeen(info.version);
+      let updateChecker;
+      try { updateChecker = require('./check-update.js'); } catch (e) {}
+      if (updateChecker) {
+        updateChecker.markVersionSeen(info.version);
+      }
     }
   } catch (e) {
     // Update check failed - continue without it (non-critical)
@@ -1910,13 +1869,12 @@ async function main() {
   // === SESSION HEALTH WARNINGS ===
   // Check for forgotten sessions with uncommitted changes, stale sessions, orphaned entries
   try {
-    const healthResult = spawnSync('node', [SESSION_MANAGER_PATH, 'health'], {
-      encoding: 'utf8',
-      timeout: 10000,
+    const healthResult = executeCommandSync('node', [SESSION_MANAGER_PATH, 'health'], {
+      timeout: 10000, fallback: null,
     });
 
-    if (healthResult.stdout) {
-      const health = JSON.parse(healthResult.stdout);
+    if (healthResult.data) {
+      const health = JSON.parse(healthResult.data);
       const hasIssues =
         health.uncommitted.length > 0 ||
         health.stale.length > 0 ||
@@ -1963,6 +1921,8 @@ async function main() {
 
   // === DUPLICATE CLAUDE PROCESS DETECTION ===
   // Check for multiple Claude processes in the same working directory
+  let processCleanup;
+  try { processCleanup = require('./lib/process-cleanup.js'); } catch (e) {}
   if (processCleanup) {
     try {
       // Auto-kill is explicitly opt-in at runtime.
@@ -2015,6 +1975,8 @@ async function main() {
   }
 
   // Story claiming: cleanup stale claims and show warnings
+  let storyClaiming;
+  try { storyClaiming = require('./lib/story-claiming.js'); } catch (e) {}
   if (storyClaiming) {
     try {
       // Clean up stale claims (dead PIDs, expired TTL)
@@ -2040,6 +2002,8 @@ async function main() {
   }
 
   // File tracking: cleanup stale touches and show overlap warnings
+  let fileTracking;
+  try { fileTracking = require('./lib/file-tracking.js'); } catch (e) {}
   if (fileTracking) {
     try {
       // Clean up stale file touches (dead PIDs, expired TTL)
@@ -2063,6 +2027,8 @@ async function main() {
   }
 
   // Epic completion check: auto-complete epics where all stories are done
+  let storyStateMachine;
+  try { storyStateMachine = require('./lib/story-state-machine.js'); } catch (e) {}
   if (storyStateMachine && cache.status) {
     try {
       const statusPath = getStatusPath(rootDir);
@@ -2091,6 +2057,8 @@ async function main() {
   }
 
   // Ideation sync: mark ideas as implemented when linked epics complete
+  let syncIdeationStatus;
+  try { syncIdeationStatus = require('./lib/sync-ideation-status.js'); } catch (e) {}
   if (syncIdeationStatus) {
     try {
       const syncResult = syncIdeationStatus.syncImplementedIdeas(rootDir);
@@ -2105,6 +2073,13 @@ async function main() {
 
   // === SCHEDULED AUTOMATIONS ===
   // Check for and run due automations (non-blocking)
+  let automationRegistry, automationRunner;
+  try {
+    automationRegistry = require('./lib/automation-registry.js');
+    automationRunner = require('./lib/automation-runner.js');
+  } catch (e) {
+    // Automation system not available
+  }
   if (automationRegistry && automationRunner) {
     try {
       const registry = automationRegistry.getAutomationRegistry({ rootDir });
@@ -2125,17 +2100,11 @@ async function main() {
 
         // Run due automations in background (spawn detached process)
         // This prevents blocking the welcome hook
-        const { spawn } = require('child_process');
         const runnerScriptPath = path.join(__dirname, 'automation-run-due.js');
 
         // Only spawn if the runner script exists
         if (fs.existsSync(runnerScriptPath)) {
-          const child = spawn('node', [runnerScriptPath], {
-            cwd: rootDir,
-            detached: true,
-            stdio: 'ignore',
-          });
-          child.unref();
+          spawnBackground('node', [runnerScriptPath], { cwd: rootDir });
           console.log(`${c.dim}   Running in background...${c.reset}`);
         } else {
           console.log(`${c.slate}   Run: ${c.skyBlue}/agileflow:automate ACTION=run-due${c.reset}`);

package/scripts/auto-self-improve.js

@@ -24,7 +24,7 @@ const { execFileSync } = require('child_process');
 // Shared utilities
 const { c } = require('../lib/colors');
 const { getProjectRoot } = require('../lib/paths');
-const { safeReadJSON, safeReadFile, safeWriteFile } = require('../lib/errors');
+const { safeReadJSON, safeReadFile, safeWriteFile, tryOptional } = require('../lib/errors');
 
 // Agents that have expertise files
 const AGENTS_WITH_EXPERTISE = [
@@ -114,7 +114,7 @@ function getGitDiff(rootDir) {
     // Get diff stats
     let additions = 0;
     let deletions = 0;
-    try {
+    tryOptional(() => {
       const stats = execFileSync('git', ['diff', '--shortstat', 'HEAD'], {
         cwd: rootDir,
         encoding: 'utf8',
@@ -124,7 +124,7 @@ function getGitDiff(rootDir) {
       const delMatch = stats.match(/(\d+) deletion/);
       if (addMatch) additions = parseInt(addMatch[1]);
       if (delMatch) deletions = parseInt(delMatch[1]);
-    } catch (e) {}
+    }, 'git diff stats');
 
     return {
       files: allFiles,