agileflow 2.94.0 → 2.95.0

package/scripts/damage-control/bash-tool-damage-control.js

@@ -1,258 +1,22 @@
 #!/usr/bin/env node
 
 /**
- * bash-tool-damage-control.js - Validate bash commands against security patterns
+ * bash-tool-damage-control.js - PreToolUse hook for Bash tool
  *
- * This PreToolUse hook runs before every Bash tool execution.
- * It checks the command against patterns.yaml to block or ask for
- * confirmation on dangerous commands.
+ * Validates bash commands against patterns in damage-control-patterns.yaml
+ * before execution. Part of AgileFlow's damage control system.
  *
  * Exit codes:
- *   0 = Allow command to proceed (or ask with JSON output)
- *   2 = Block command
+ *   0 - Allow command (or ask via JSON output)
+ *   2 - Block command
  *
- * For ask confirmation, outputs JSON:
- *   {"result": "ask", "message": "Reason for asking"}
+ * For "ask" response, output JSON to stdout:
+ *   { "result": "ask", "message": "Confirm this action?" }
  *
- * Usage (as PreToolUse hook):
- *   node .claude/hooks/damage-control/bash-tool-damage-control.js
- *
- * Environment:
- *   CLAUDE_TOOL_INPUT - JSON string with tool input (contains "command")
- *   CLAUDE_PROJECT_DIR - Project root directory
- */
-
-const fs = require('fs');
-const path = require('path');
-
-// ANSI colors for output
-const c = {
-  reset: '\x1b[0m',
-  bold: '\x1b[1m',
-  red: '\x1b[31m',
-  yellow: '\x1b[33m',
-  cyan: '\x1b[36m',
-};
-
-// Exit codes
-const EXIT_ALLOW = 0;
-const EXIT_BLOCK = 2;
-
-/**
- * Load patterns from YAML file
- * Falls back to built-in patterns if YAML parsing fails
- */
-function loadPatterns(projectDir) {
-  const locations = [
-    path.join(projectDir, '.claude/hooks/damage-control/patterns.yaml'),
-    path.join(projectDir, '.agileflow/hooks/damage-control/patterns.yaml'),
-    path.join(projectDir, 'patterns.yaml'),
-  ];
-
-  for (const loc of locations) {
-    if (fs.existsSync(loc)) {
-      try {
-        const content = fs.readFileSync(loc, 'utf8');
-        // Simple YAML parsing for our specific structure
-        return parseSimpleYaml(content);
-      } catch (e) {
-        console.error(`Warning: Could not parse ${loc}: ${e.message}`);
-      }
-    }
-  }
-
-  // Return built-in defaults if no file found
-  return getDefaultPatterns();
-}
-
-/**
- * Simple YAML parser for patterns.yaml structure
- * Only handles the specific structure we use (arrays of objects with pattern/reason/ask)
- */
-function parseSimpleYaml(content) {
-  const patterns = {
-    bashToolPatterns: [],
-    askPatterns: [],
-    agileflowPatterns: [],
-  };
-
-  let currentSection = null;
-  let currentItem = null;
-
-  const lines = content.split('\n');
-
-  for (const line of lines) {
-    // Skip comments and empty lines
-    if (line.trim().startsWith('#') || line.trim() === '') continue;
-
-    // Check for section headers
-    if (line.match(/^bashToolPatterns:/)) {
-      currentSection = 'bashToolPatterns';
-      continue;
-    }
-    if (line.match(/^askPatterns:/)) {
-      currentSection = 'askPatterns';
-      continue;
-    }
-    if (line.match(/^agileflowPatterns:/)) {
-      currentSection = 'agileflowPatterns';
-      continue;
-    }
-    if (line.match(/^(zeroAccessPaths|readOnlyPaths|noDeletePaths|config):/)) {
-      currentSection = null; // Skip non-pattern sections
-      continue;
-    }
-
-    // Parse pattern items
-    if (currentSection && patterns[currentSection]) {
-      const patternMatch = line.match(/^\s+-\s*pattern:\s*['"]?(.+?)['"]?\s*$/);
-      if (patternMatch) {
-        currentItem = { pattern: patternMatch[1] };
-        patterns[currentSection].push(currentItem);
-        continue;
-      }
-
-      const reasonMatch = line.match(/^\s+reason:\s*['"]?(.+?)['"]?\s*$/);
-      if (reasonMatch && currentItem) {
-        currentItem.reason = reasonMatch[1];
-        continue;
-      }
-
-      const askMatch = line.match(/^\s+ask:\s*(true|false)\s*$/);
-      if (askMatch && currentItem) {
-        currentItem.ask = askMatch[1] === 'true';
-        continue;
-      }
-    }
-  }
-
-  return patterns;
-}
-
-/**
- * Built-in default patterns (used if patterns.yaml not found)
- */
-function getDefaultPatterns() {
-  return {
-    bashToolPatterns: [
-      { pattern: '\\brm\\s+-[rRf]', reason: 'rm with recursive or force flags' },
-      { pattern: 'DROP\\s+(TABLE|DATABASE)', reason: 'DROP commands are destructive' },
-      { pattern: 'DELETE\\s+FROM\\s+\\w+\\s*;', reason: 'DELETE without WHERE clause' },
-      { pattern: 'TRUNCATE\\s+(TABLE\\s+)?\\w+', reason: 'TRUNCATE removes all data' },
-      {
-        pattern: 'git\\s+push\\s+.*--force',
-        reason: 'Force push can overwrite history',
-        ask: true,
-      },
-      { pattern: 'git\\s+reset\\s+--hard', reason: 'Hard reset discards changes', ask: true },
-    ],
-    askPatterns: [
-      { pattern: 'DELETE\\s+FROM\\s+\\w+\\s+WHERE', reason: 'Confirm record deletion' },
-      { pattern: 'npm\\s+publish', reason: 'Publishing to npm is permanent' },
-    ],
-    agileflowPatterns: [
-      { pattern: 'rm.*\\.agileflow', reason: 'Deleting .agileflow breaks installation' },
-      { pattern: 'rm.*\\.claude', reason: 'Deleting .claude breaks configuration' },
-    ],
-  };
-}
-
-/**
- * Check command against patterns
- * Returns: { blocked: boolean, ask: boolean, reason: string }
- */
-function checkCommand(command, patterns) {
-  // Combine all pattern sources
-  const allPatterns = [...(patterns.bashToolPatterns || []), ...(patterns.agileflowPatterns || [])];
-
-  // Check block/ask patterns
-  for (const p of allPatterns) {
-    try {
-      const regex = new RegExp(p.pattern, 'i');
-      if (regex.test(command)) {
-        if (p.ask) {
-          return { blocked: false, ask: true, reason: p.reason };
-        }
-        return { blocked: true, ask: false, reason: p.reason };
-      }
-    } catch (e) {
-      // Invalid regex, skip
-      console.error(`Warning: Invalid regex pattern: ${p.pattern}`);
-    }
-  }
-
-  // Check ask-only patterns
-  for (const p of patterns.askPatterns || []) {
-    try {
-      const regex = new RegExp(p.pattern, 'i');
-      if (regex.test(command)) {
-        return { blocked: false, ask: true, reason: p.reason };
-      }
-    } catch (e) {
-      // Invalid regex, skip
-    }
-  }
-
-  return { blocked: false, ask: false, reason: null };
-}
-
-/**
- * Main entry point
+ * Usage: Configured as PreToolUse hook in .claude/settings.json
  */
-function main() {
-  // Get tool input from environment
-  const toolInput = process.env.CLAUDE_TOOL_INPUT;
-  const projectDir = process.env.CLAUDE_PROJECT_DIR || process.cwd();
-
-  if (!toolInput) {
-    // No input, allow by default
-    process.exit(EXIT_ALLOW);
-  }
-
-  let input;
-  try {
-    input = JSON.parse(toolInput);
-  } catch (e) {
-    console.error('Error parsing CLAUDE_TOOL_INPUT:', e.message);
-    process.exit(EXIT_ALLOW);
-  }
-
-  const command = input.command;
-  if (!command) {
-    process.exit(EXIT_ALLOW);
-  }
-
-  // Load patterns
-  const patterns = loadPatterns(projectDir);
-
-  // Check command
-  const result = checkCommand(command, patterns);
-
-  if (result.blocked) {
-    // Block the command
-    console.error(`${c.red}${c.bold}BLOCKED${c.reset}: ${result.reason}`);
-    console.error(`${c.yellow}Command: ${command}${c.reset}`);
-    console.error(`${c.cyan}This command was blocked by damage control.${c.reset}`);
-    process.exit(EXIT_BLOCK);
-  }
-
-  if (result.ask) {
-    // Ask for confirmation
-    const response = {
-      result: 'ask',
-      message: `${result.reason}\n\nCommand: ${command}\n\nProceed with this command?`,
-    };
-    console.log(JSON.stringify(response));
-    process.exit(EXIT_ALLOW);
-  }
-
-  // Allow the command
-  process.exit(EXIT_ALLOW);
-}
 
-// Run if called directly
-if (require.main === module) {
-  main();
-}
+const { createBashHook } = require('../lib/damage-control-utils');
 
-module.exports = { checkCommand, loadPatterns, parseSimpleYaml };
+// Run the hook using factory
+createBashHook()();

package/scripts/damage-control/edit-tool-damage-control.js

@@ -1,259 +1,19 @@
 #!/usr/bin/env node
 
 /**
- * edit-tool-damage-control.js - Enforce path protection for Edit tool
+ * edit-tool-damage-control.js - PreToolUse hook for Edit tool
  *
- * This PreToolUse hook runs before every Edit tool execution.
- * It checks the file path against patterns.yaml to block edits
- * to protected paths.
- *
- * Path protection levels:
- *   zeroAccessPaths: Cannot read, write, edit, or delete
- *   readOnlyPaths: Can read, cannot modify or delete
- *   noDeletePaths: Can read and modify, cannot delete (Edit is allowed)
+ * Validates file paths against access control patterns in damage-control-patterns.yaml
+ * before allowing file edits. Part of AgileFlow's damage control system.
  *
  * Exit codes:
- *   0 = Allow edit to proceed
- *   2 = Block edit
- *
- * Usage (as PreToolUse hook):
- *   node .claude/hooks/damage-control/edit-tool-damage-control.js
+ *   0 - Allow operation
+ *   2 - Block operation
  *
- * Environment:
- *   CLAUDE_TOOL_INPUT - JSON string with tool input (contains "file_path")
- *   CLAUDE_PROJECT_DIR - Project root directory
- */
-
-const fs = require('fs');
-const path = require('path');
-
-// ANSI colors for output
-const c = {
-  reset: '\x1b[0m',
-  bold: '\x1b[1m',
-  red: '\x1b[31m',
-  yellow: '\x1b[33m',
-  cyan: '\x1b[36m',
-};
-
-// Exit codes
-const EXIT_ALLOW = 0;
-const EXIT_BLOCK = 2;
-
-/**
- * Load path protection rules from patterns.yaml
- */
-function loadPathRules(projectDir) {
-  const locations = [
-    path.join(projectDir, '.claude/hooks/damage-control/patterns.yaml'),
-    path.join(projectDir, '.agileflow/hooks/damage-control/patterns.yaml'),
-    path.join(projectDir, 'patterns.yaml'),
-  ];
-
-  for (const loc of locations) {
-    if (fs.existsSync(loc)) {
-      try {
-        const content = fs.readFileSync(loc, 'utf8');
-        return parsePathRules(content);
-      } catch (e) {
-        console.error(`Warning: Could not parse ${loc}: ${e.message}`);
-      }
-    }
-  }
-
-  return getDefaultPathRules();
-}
-
-/**
- * Parse path rules from YAML content
+ * Usage: Configured as PreToolUse hook in .claude/settings.json
  */
-function parsePathRules(content) {
-  const rules = {
-    zeroAccessPaths: [],
-    readOnlyPaths: [],
-    noDeletePaths: [],
-  };
-
-  let currentSection = null;
-
-  const lines = content.split('\n');
-
-  for (const line of lines) {
-    if (line.trim().startsWith('#') || line.trim() === '') continue;
-
-    if (line.match(/^zeroAccessPaths:/)) {
-      currentSection = 'zeroAccessPaths';
-      continue;
-    }
-    if (line.match(/^readOnlyPaths:/)) {
-      currentSection = 'readOnlyPaths';
-      continue;
-    }
-    if (line.match(/^noDeletePaths:/)) {
-      currentSection = 'noDeletePaths';
-      continue;
-    }
-    if (line.match(/^(bashToolPatterns|askPatterns|agileflowPatterns|config):/)) {
-      currentSection = null;
-      continue;
-    }
-
-    if (currentSection && rules[currentSection]) {
-      const pathMatch = line.match(/^\s+-\s*['"]?(.+?)['"]?\s*$/);
-      if (pathMatch) {
-        rules[currentSection].push(pathMatch[1]);
-      }
-    }
-  }
-
-  return rules;
-}
-
-/**
- * Default path rules if patterns.yaml not found
- */
-function getDefaultPathRules() {
-  return {
-    zeroAccessPaths: ['~/.ssh/', '~/.aws/credentials', '.env', '.env.local', '.env.production'],
-    readOnlyPaths: ['/etc/', '~/.bashrc', '~/.zshrc', 'package-lock.json', 'yarn.lock', '.git/'],
-    noDeletePaths: ['.agileflow/', '.claude/', 'docs/09-agents/status.json', 'CLAUDE.md'],
-  };
-}
-
-/**
- * Expand home directory in path
- */
-function expandHome(filePath) {
-  if (filePath.startsWith('~/')) {
-    return path.join(process.env.HOME || '', filePath.slice(2));
-  }
-  return filePath;
-}
-
-/**
- * Check if a file path matches a pattern
- * Supports:
- *   - Exact paths
- *   - Directory prefixes (ending with /)
- *   - Glob wildcards (**)
- */
-function pathMatches(filePath, pattern) {
-  const expandedPattern = expandHome(pattern);
-  const normalizedFile = path.normalize(filePath);
-  const normalizedPattern = path.normalize(expandedPattern);
-
-  // Exact match
-  if (normalizedFile === normalizedPattern) return true;
-
-  // Directory prefix match (pattern ends with /)
-  if (pattern.endsWith('/')) {
-    if (normalizedFile.startsWith(normalizedPattern)) return true;
-  }
-
-  // Glob pattern (**/)
-  if (pattern.includes('**/')) {
-    const globPart = pattern.split('**/')[1];
-    if (normalizedFile.includes(globPart)) return true;
-  }
-
-  // Simple wildcard at end
-  if (pattern.endsWith('*')) {
-    const prefix = normalizedPattern.slice(0, -1);
-    if (normalizedFile.startsWith(prefix)) return true;
-  }
-
-  // Basename match (for patterns like .env)
-  if (!pattern.includes('/') && !pattern.includes(path.sep)) {
-    const basename = path.basename(normalizedFile);
-    if (basename === pattern) return true;
-    // Pattern like .env* matching .env.local
-    if (pattern.endsWith('*')) {
-      const patternBase = pattern.slice(0, -1);
-      if (basename.startsWith(patternBase)) return true;
-    }
-  }
-
-  return false;
-}
-
-/**
- * Check if file path is protected
- * Returns: { blocked: boolean, reason: string, level: string }
- */
-function checkPath(filePath, rules) {
-  // Check zero access paths (blocked completely)
-  for (const pattern of rules.zeroAccessPaths) {
-    if (pathMatches(filePath, pattern)) {
-      return {
-        blocked: true,
-        reason: `Path is in zero-access protected list: ${pattern}`,
-        level: 'zero-access',
-      };
-    }
-  }
-
-  // Check read-only paths (cannot edit)
-  for (const pattern of rules.readOnlyPaths) {
-    if (pathMatches(filePath, pattern)) {
-      return {
-        blocked: true,
-        reason: `Path is read-only: ${pattern}`,
-        level: 'read-only',
-      };
-    }
-  }
-
-  // noDeletePaths allows editing, so we don't block here
-  // (deletion is handled by a different mechanism or file watcher)
-
-  return { blocked: false, reason: null, level: null };
-}
-
-/**
- * Main entry point
- */
-function main() {
-  const toolInput = process.env.CLAUDE_TOOL_INPUT;
-  const projectDir = process.env.CLAUDE_PROJECT_DIR || process.cwd();
-
-  if (!toolInput) {
-    process.exit(EXIT_ALLOW);
-  }
-
-  let input;
-  try {
-    input = JSON.parse(toolInput);
-  } catch (e) {
-    console.error('Error parsing CLAUDE_TOOL_INPUT:', e.message);
-    process.exit(EXIT_ALLOW);
-  }
-
-  const filePath = input.file_path;
-  if (!filePath) {
-    process.exit(EXIT_ALLOW);
-  }
-
-  // Resolve to absolute path
-  const absolutePath = path.isAbsolute(filePath) ? filePath : path.join(projectDir, filePath);
-
-  // Load rules
-  const rules = loadPathRules(projectDir);
-
-  // Check path
-  const result = checkPath(absolutePath, rules);
-
-  if (result.blocked) {
-    console.error(`${c.red}${c.bold}BLOCKED${c.reset}: ${result.reason}`);
-    console.error(`${c.yellow}File: ${filePath}${c.reset}`);
-    console.error(`${c.cyan}This file is protected by damage control (${result.level}).${c.reset}`);
-    process.exit(EXIT_BLOCK);
-  }
-
-  process.exit(EXIT_ALLOW);
-}
 
-if (require.main === module) {
-  main();
-}
+const { createPathHook } = require('../lib/damage-control-utils');
 
-module.exports = { checkPath, loadPathRules, pathMatches };
+// Run the hook using factory
+createPathHook('edit')();