agileflow 2.89.3 → 2.90.0

package/tools/cli/commands/doctor.js

@@ -28,6 +28,8 @@ const {
   isRecoverable,
 } = require('../../../lib/error-codes');
 const { safeDump } = require('../../../lib/yaml-utils');
+const { IdeRegistry } = require('../lib/ide-registry');
+const { formatKeyValue, formatList, isTTY } = require('../../../lib/table-formatter');
 
 const installer = new Installer();
 
@@ -239,8 +241,8 @@ module.exports = {
         ideManager.setDocsFolder(status.docsFolder || 'docs');
 
         for (const ide of status.ides) {
-          const configPath = getIdeConfigPath(directory, ide);
-          const ideName = formatIdeName(ide);
+          const configPath = IdeRegistry.getConfigPath(ide, directory);
+          const ideName = IdeRegistry.getDisplayName(ide);
 
           if (await fs.pathExists(configPath)) {
             // Count files in config
@@ -265,14 +267,14 @@ module.exports = {
 
       // Check for orphaned configs
       console.log(chalk.bold('\nOrphan Check:'));
-      const allIdes = ['claude-code', 'cursor', 'windsurf'];
+      const allIdes = IdeRegistry.getAll();
       let orphansFound = false;
 
       for (const ide of allIdes) {
         if (!status.ides || !status.ides.includes(ide)) {
-          const configPath = getIdeConfigPath(directory, ide);
+          const configPath = IdeRegistry.getConfigPath(ide, directory);
           if (await fs.pathExists(configPath)) {
-            const ideName = formatIdeName(ide);
+            const ideName = IdeRegistry.getDisplayName(ide);
             warning(`${ideName}: Config exists but not in manifest`);
             orphansFound = true;
             warnings++;
@@ -367,36 +369,6 @@ function compareVersions(a, b) {
   return 0;
 }
 
-/**
- * Get IDE config path
- * @param {string} projectDir - Project directory
- * @param {string} ide - IDE name
- * @returns {string}
- */
-function getIdeConfigPath(projectDir, ide) {
-  const paths = {
-    'claude-code': '.claude/commands/agileflow',
-    cursor: '.cursor/rules/agileflow',
-    windsurf: '.windsurf/workflows/agileflow',
-  };
-
-  return path.join(projectDir, paths[ide] || '');
-}
-
-/**
- * Format IDE name for display
- * @param {string} ide - IDE name
- * @returns {string}
- */
-function formatIdeName(ide) {
-  const names = {
-    'claude-code': 'Claude Code',
-    cursor: 'Cursor',
-    windsurf: 'Windsurf',
-  };
-
-  return names[ide] || ide;
-}
 
 /**
  * Count files in directory recursively
@@ -420,7 +392,7 @@ async function countFilesInDir(dirPath) {
 }
 
 /**
- * Print summary
+ * Print summary using formatKeyValue for consistent output
  * @param {number} issues - Issue count
  * @param {number} warnings - Warning count
  */
@@ -430,9 +402,17 @@ function printSummary(issues, warnings) {
   if (issues === 0 && warnings === 0) {
     console.log(chalk.green.bold('No issues found.\n'));
   } else if (issues === 0) {
-    console.log(chalk.yellow(`${warnings} warning(s), no critical issues.\n`));
+    console.log(formatKeyValue({
+      Warnings: chalk.yellow(warnings),
+      Issues: chalk.green('0'),
+    }, { separator: ':', alignValues: false }));
+    console.log();
   } else {
-    console.log(chalk.red(`${issues} issue(s), ${warnings} warning(s) found.\n`));
+    console.log(formatKeyValue({
+      Issues: chalk.red(issues),
+      Warnings: chalk.yellow(warnings),
+    }, { separator: ':', alignValues: false }));
+    console.log();
   }
 }
 

package/tools/cli/commands/list.js

@@ -13,6 +13,7 @@ const { displayLogo, displaySection, success, warning, info } = require('../lib/
 const {
   parseFrontmatter: parseYamlFrontmatter,
 } = require('../../../scripts/lib/frontmatter-parser');
+const { formatList, formatKeyValue, formatHeader, isTTY } = require('../../../lib/table-formatter');
 
 const installer = new Installer();
 
@@ -300,73 +301,84 @@ function extractFirstLine(content) {
 }
 
 /**
- * Display compact output
+ * Display compact output using formatKeyValue
  */
 function displayCompact(result, showCommands, showAgents, showSkills, showExperts) {
+  const data = {};
+
   if (showCommands && result.commands?.length > 0) {
-    console.log(chalk.bold('Commands:'), result.commands.map(c => c.name).join(', '));
+    data.Commands = result.commands.map(c => c.name).join(', ');
   }
 
   if (showAgents && result.agents?.length > 0) {
-    console.log(chalk.bold('Agents:'), result.agents.map(a => a.name).join(', '));
+    data.Agents = result.agents.map(a => a.name).join(', ');
   }
 
   if (showSkills && result.skills?.length > 0) {
-    console.log(chalk.bold('Skills:'), result.skills.map(s => s.name).join(', '));
+    data.Skills = result.skills.map(s => s.name).join(', ');
   }
 
   if (showExperts && result.experts?.length > 0) {
-    console.log(chalk.bold('Experts:'), result.experts.map(e => e.name).join(', '));
+    data.Experts = result.experts.map(e => e.name).join(', ');
+  }
+
+  if (Object.keys(data).length > 0) {
+    console.log(formatKeyValue(data, { alignValues: false }));
   }
 }
 
 /**
- * Display full output with descriptions
+ * Display full output with descriptions using formatList
  */
 function displayFull(result, showCommands, showAgents, showSkills, showExperts) {
-  if (showCommands && result.commands?.length > 0) {
-    displaySection(`Commands (${result.commands.length})`);
+  const { BRAND_HEX } = require('../../../lib/colors');
 
-    for (const cmd of result.commands) {
-      console.log(chalk.hex('#e8683a')(`  ${cmd.name}`));
-      console.log(chalk.dim(`    ${cmd.description}`));
-    }
+  if (showCommands && result.commands?.length > 0) {
+    console.log(formatHeader(`Commands (${result.commands.length})`));
+    const items = result.commands.map(cmd => ({
+      text: `${chalk.hex(BRAND_HEX)(cmd.name)}\n      ${chalk.dim(cmd.description)}`,
+      status: 'active',
+    }));
+    console.log(formatList(items, { indent: '  ' }));
   }
 
   if (showAgents && result.agents?.length > 0) {
-    displaySection(`Agents (${result.agents.length})`);
-
-    for (const agent of result.agents) {
+    console.log(formatHeader(`Agents (${result.agents.length})`));
+    const items = result.agents.map(agent => {
       const modelBadge = agent.model !== 'default' ? chalk.dim(` [${agent.model}]`) : '';
-      console.log(chalk.hex('#e8683a')(`  ${agent.name}`) + modelBadge);
-      console.log(chalk.dim(`    ${agent.description}`));
-    }
+      return {
+        text: `${chalk.hex(BRAND_HEX)(agent.name)}${modelBadge}\n      ${chalk.dim(agent.description)}`,
+        status: 'active',
+      };
+    });
+    console.log(formatList(items, { indent: '  ' }));
   }
 
   if (showSkills && result.skills?.length > 0) {
-    displaySection(`Skills (${result.skills.length})`);
-
-    for (const skill of result.skills) {
-      console.log(chalk.hex('#e8683a')(`  ${skill.name}`));
-      console.log(chalk.dim(`    ${skill.description}`));
+    console.log(formatHeader(`Skills (${result.skills.length})`));
+    const items = result.skills.map(skill => {
+      let desc = chalk.dim(skill.description);
       if (skill.triggers?.length > 0) {
-        console.log(
-          chalk.dim(
-            `    Triggers: ${skill.triggers.slice(0, 3).join(', ')}${skill.triggers.length > 3 ? '...' : ''}`
-          )
-        );
+        desc += `\n      ${chalk.dim(`Triggers: ${skill.triggers.slice(0, 3).join(', ')}${skill.triggers.length > 3 ? '...' : ''}`)}`;
       }
-    }
+      return {
+        text: `${chalk.hex(BRAND_HEX)(skill.name)}\n      ${desc}`,
+        status: 'active',
+      };
+    });
+    console.log(formatList(items, { indent: '  ' }));
   }
 
   if (showExperts && result.experts?.length > 0) {
-    displaySection(`Experts (${result.experts.length})`);
-
-    for (const expert of result.experts) {
+    console.log(formatHeader(`Experts (${result.experts.length})`));
+    const items = result.experts.map(expert => {
       const versionBadge = expert.version !== 'unknown' ? chalk.dim(` v${expert.version}`) : '';
-      console.log(chalk.hex('#e8683a')(`  ${expert.name}`) + versionBadge);
-      console.log(chalk.dim(`    ${expert.description}`));
-    }
+      return {
+        text: `${chalk.hex(BRAND_HEX)(expert.name)}${versionBadge}\n      ${chalk.dim(expert.description)}`,
+        status: 'active',
+      };
+    });
+    console.log(formatList(items, { indent: '  ' }));
   }
 
   console.log(); // Final newline

package/tools/cli/commands/status.js

@@ -11,6 +11,8 @@ const ora = require('ora');
 const { Installer } = require('../installers/core/installer');
 const { displayLogo, displaySection, success, warning, info } = require('../lib/ui');
 const { checkForUpdate } = require('../lib/version-checker');
+const { IdeRegistry } = require('../lib/ide-registry');
+const { formatKeyValue, formatList, isTTY } = require('../../../lib/table-formatter');
 
 const installer = new Installer();
 
@@ -33,14 +35,18 @@ module.exports = {
         process.exit(0);
       }
 
-      // Show installation info
-      console.log(chalk.bold('Location:    '), status.path);
-      console.log(chalk.bold('Version:     '), status.version);
+      // Show installation info using formatKeyValue
+      console.log(formatKeyValue({
+        Location: status.path,
+        Version: status.version,
+      }));
 
       // Count installed items
       const counts = await installer.countInstalledItems(status.path);
 
-      console.log(chalk.bold('\nCore:        '), chalk.green('✓ Installed'));
+      console.log(formatKeyValue({
+        '\nCore': chalk.green('✓ Installed'),
+      }, { alignValues: false }));
       info(`${counts.agents} agents`);
       info(`${counts.commands} commands`);
       info(`${counts.skills} skills`);
@@ -50,13 +56,13 @@ module.exports = {
         console.log(chalk.bold('\nConfigured IDEs:'));
         for (const ide of status.ides) {
           // Check if IDE config exists
-          const ideConfigPath = getIdeConfigPath(directory, ide);
+          const ideConfigPath = IdeRegistry.getConfigPath(ide, directory);
           const exists = await fs.pathExists(ideConfigPath);
 
           if (exists) {
-            success(formatIdeName(ide));
+            success(IdeRegistry.getDisplayName(ide));
           } else {
-            warning(`${formatIdeName(ide)} (config missing)`);
+            warning(`${IdeRegistry.getDisplayName(ide)} (config missing)`);
           }
         }
       }
@@ -87,33 +93,3 @@ module.exports = {
   },
 };
 
-/**
- * Get IDE config path
- * @param {string} projectDir - Project directory
- * @param {string} ide - IDE name
- * @returns {string}
- */
-function getIdeConfigPath(projectDir, ide) {
-  const paths = {
-    'claude-code': '.claude/commands/agileflow',
-    cursor: '.cursor/rules/agileflow',
-    windsurf: '.windsurf/workflows/agileflow',
-  };
-
-  return path.join(projectDir, paths[ide] || '');
-}
-
-/**
- * Format IDE name for display
- * @param {string} ide - IDE name
- * @returns {string}
- */
-function formatIdeName(ide) {
-  const names = {
-    'claude-code': 'Claude Code',
-    cursor: 'Cursor',
-    windsurf: 'Windsurf',
-  };
-
-  return names[ide] || ide;
-}

package/tools/cli/commands/uninstall.js

@@ -11,6 +11,7 @@ const { Installer } = require('../installers/core/installer');
 const { IdeManager } = require('../installers/ide/manager');
 const { displayLogo, displaySection, success, warning, error, confirm } = require('../lib/ui');
 const { ErrorHandler } = require('../lib/error-handler');
+const { IdeRegistry } = require('../lib/ide-registry');
 
 const installer = new Installer();
 const ideManager = new IdeManager();
@@ -40,17 +41,17 @@ module.exports = {
       // Check if removing just one IDE
       if (options.ide) {
         const ideName = options.ide.toLowerCase();
-        displaySection('Removing IDE Configuration', `IDE: ${formatIdeName(ideName)}`);
+        displaySection('Removing IDE Configuration', `IDE: ${IdeRegistry.getDisplayName(ideName)}`);
 
         if (!status.ides || !status.ides.includes(ideName)) {
-          warning(`${formatIdeName(ideName)} is not configured in this installation`);
+          warning(`${IdeRegistry.getDisplayName(ideName)} is not configured in this installation`);
           console.log(chalk.dim(`Configured IDEs: ${(status.ides || []).join(', ') || 'none'}\n`));
           process.exit(0);
         }
 
         // Confirm removal
         if (!options.force) {
-          const proceed = await confirm(`Remove ${formatIdeName(ideName)} configuration?`, false);
+          const proceed = await confirm(`Remove ${IdeRegistry.getDisplayName(ideName)} configuration?`, false);
           if (!proceed) {
             console.log(chalk.dim('\nCancelled\n'));
             process.exit(0);
@@ -60,10 +61,10 @@ module.exports = {
         console.log();
 
         // Remove the IDE configuration
-        const configPath = getIdeConfigPath(directory, ideName);
+        const configPath = IdeRegistry.getConfigPath(ideName, directory);
         if (await fs.pathExists(configPath)) {
           await fs.remove(configPath);
-          success(`Removed ${formatIdeName(ideName)} configuration`);
+          success(`Removed ${IdeRegistry.getDisplayName(ideName)} configuration`);
         }
 
         // Also remove spawnable agents for claude-code
@@ -87,7 +88,7 @@ module.exports = {
           success('Updated manifest');
         }
 
-        console.log(chalk.green(`\n${formatIdeName(ideName)} has been removed.\n`));
+        console.log(chalk.green(`\n${IdeRegistry.getDisplayName(ideName)} has been removed.\n`));
         if (status.ides.length > 1) {
           console.log(
             chalk.dim(`Remaining IDEs: ${status.ides.filter(i => i !== ideName).join(', ')}\n`)
@@ -114,10 +115,10 @@ module.exports = {
       // Remove IDE configurations
       if (status.ides && status.ides.length > 0) {
         for (const ide of status.ides) {
-          const configPath = getIdeConfigPath(directory, ide);
+          const configPath = IdeRegistry.getConfigPath(ide, directory);
           if (await fs.pathExists(configPath)) {
             await fs.remove(configPath);
-            success(`Removed ${formatIdeName(ide)} configuration`);
+            success(`Removed ${IdeRegistry.getDisplayName(ide)} configuration`);
           }
           // Also remove spawnable agents for claude-code
           if (ide === 'claude-code') {
@@ -150,33 +151,3 @@ module.exports = {
   },
 };
 
-/**
- * Get IDE config path
- * @param {string} projectDir - Project directory
- * @param {string} ide - IDE name
- * @returns {string}
- */
-function getIdeConfigPath(projectDir, ide) {
-  const paths = {
-    'claude-code': '.claude/commands/agileflow',
-    cursor: '.cursor/rules/agileflow',
-    windsurf: '.windsurf/workflows/agileflow',
-  };
-
-  return path.join(projectDir, paths[ide] || '');
-}
-
-/**
- * Format IDE name for display
- * @param {string} ide - IDE name
- * @returns {string}
- */
-function formatIdeName(ide) {
-  const names = {
-    'claude-code': 'Claude Code',
-    cursor: 'Cursor',
-    windsurf: 'Windsurf',
-  };
-
-  return names[ide] || ide;
-}

package/tools/cli/installers/core/installer.js

@@ -17,6 +17,7 @@ const {
   getErrorCodeFromError,
   attachErrorCode,
 } = require('../../../../lib/error-codes');
+const { setSecurePermissions, SECURE_FILE_MODE } = require('../../../../lib/smart-json-file');
 
 const TEXT_EXTENSIONS = new Set(['.md', '.yaml', '.yml', '.txt', '.json']);
 
@@ -504,6 +505,8 @@ class Installer {
       };
 
       await fs.writeFile(configPath, safeDump(config), 'utf8');
+      // Security: Set secure permissions (0o600) on config file
+      setSecurePermissions(configPath);
       return;
     }
 
@@ -531,6 +534,8 @@ class Installer {
       };
 
       await fs.writeFile(configPath, safeDump(next), 'utf8');
+      // Security: Set secure permissions (0o600) on config file
+      setSecurePermissions(configPath);
     } catch (err) {
       // If it's a typed parse error and not forcing, re-throw
       if (err.errorCode === 'EPARSE' && !options.force) {
@@ -547,6 +552,8 @@ class Installer {
         };
 
         await fs.writeFile(configPath, safeDump(config), 'utf8');
+        // Security: Set secure permissions (0o600) on config file
+        setSecurePermissions(configPath);
       }
     }
   }
@@ -578,6 +585,8 @@ class Installer {
       };
 
       await fs.writeFile(manifestPath, safeDump(manifest), 'utf8');
+      // Security: Set secure permissions (0o600) on manifest file
+      setSecurePermissions(manifestPath);
       return;
     }
 
@@ -608,6 +617,8 @@ class Installer {
       };
 
       await fs.writeFile(manifestPath, safeDump(manifest), 'utf8');
+      // Security: Set secure permissions (0o600) on manifest file
+      setSecurePermissions(manifestPath);
     } catch (err) {
       // If it's a typed parse error and not forcing, re-throw
       if (err.errorCode === 'EPARSE' && !options.force) {
@@ -627,6 +638,8 @@ class Installer {
         };
 
         await fs.writeFile(manifestPath, safeDump(manifest), 'utf8');
+        // Security: Set secure permissions (0o600) on manifest file
+        setSecurePermissions(manifestPath);
       }
     }
   }