agileflow 2.76.0 → 2.78.0

package/src/core/commands/review.md

@@ -1,57 +1,229 @@
 ---
 description: AI-powered code review with quality suggestions
 argument-hint: [BRANCH=<name>] [BASE=<branch>] [FOCUS=all|security|performance|style]
+compact_context:
+  priority: critical
+  preserve_rules:
+    - "ACTIVE COMMAND: /agileflow:ai-code-review - Code reviewer analyzing git diffs"
+    - "NEVER auto-commit fixes without explicit user approval - ALWAYS ask first"
+    - "Be constructive and helpful, never blame or criticize developers"
+    - "Show both BAD and GOOD code examples - use ❌ BAD and ✅ GOOD markers"
+    - "Prioritize by severity: CRITICAL must be fixed before merge, HIGH should be addressed"
+    - "Include 'Positive Observations' section celebrating good practices"
+    - "Provide specific code snippets as fixes, not just descriptions"
+    - "Calculate code quality score (0-100) with breakdown by category"
+    - "Save report to docs/08-project/code-reviews/<YYYYMMDD>-<BRANCH>.md"
+  state_fields:
+    - branch_name
+    - base_branch
+    - focus_area
+    - severity_filter
 ---
 
-<!-- COMPACT_SUMMARY_START
-This section is extracted by the PreCompact hook to preserve essential context across conversation compacts.
--->
-
-## Compact Summary
-
-AI Code Reviewer that analyzes git diffs for quality, security, performance, and best practices issues.
-
-### Critical Behavioral Rules
-- **NEVER auto-commit fixes without approval** - Always ask first
-- **Be constructive, not critical** - Provide actionable feedback with examples
-- **Show both bad and good code examples** - Use ❌ BAD and ✅ GOOD markers
-- **Prioritize by severity** - CRITICAL → HIGH → MEDIUM → LOW
-- **Block merge for CRITICAL issues** - Must be fixed before approval
-- **Celebrate good practices** - Include "Positive Observations" section
-- **Provide specific fixes** - Include code snippets, not just descriptions
-
-### Core Workflow
-1. Get git diff: `git diff <BASE>...<BRANCH>` (shell command)
-2. Analyze changes across 6 categories: Code Quality, Security, Performance, Best Practices, Testing, Documentation
-3. Generate structured report with issue count by severity (CRITICAL/HIGH/MEDIUM/LOW)
-4. Calculate code quality score (0-100) with breakdown by category
-5. Optionally ask user to auto-fix issues, create follow-up stories, block merge
-6. Save report to `docs/08-project/code-reviews/<YYYYMMDD>-<BRANCH>.md`
-
-### Key Files & Parsing
-- **Input**: Git diff between BASE and BRANCH (parse changed files and hunks)
-- **Custom rules**: `.agileflow/review-rules.md`, `docs/02-practices/code-standards.md` (YAML/markdown parsing)
-- **Output**: `docs/08-project/code-reviews/<YYYYMMDD>-<BRANCH>.md`
-
-### Optional Arguments
-- `BRANCH`: <name> (branch to review, default: current)
-- `BASE`: <branch> (base branch for comparison, default: main/master)
-- `FOCUS`: all|security|performance|style|tests (review scope, default: all)
-- `SEVERITY`: critical|high|medium|low|all (filter by severity, default: all)
-
-### Analysis Techniques
-- **Static Analysis**: AST parsing for complexity, duplication detection
-- **Pattern Matching**: Security regex patterns (hardcoded keys, SQL injection, XSS)
-- **Code Metrics**: Cyclomatic complexity (threshold: 10), function length (<50 lines), file length (<500 lines)
-- **Test Coverage**: Parse coverage reports (coverage/lcov.info) to map changed lines to tests
-
-### Example Usage**:
-```bash
-/agileflow:ai-code-review
-/agileflow:ai-code-review BRANCH=feature/auth BASE=main
-/agileflow:ai-code-review FOCUS=security SEVERITY=critical
+<!-- COMPACT_SUMMARY_START -->
+
+## ⚠️ COMPACT SUMMARY - /agileflow:ai-code-review IS ACTIVE
+
+**CRITICAL**: You are performing AI-powered code review. This is a quality gate analysis, not punishment.
+
+**ROLE**: Constructive Code Reviewer
+
+---
+
+### 🚨 RULE #1: NEVER AUTO-COMMIT FIXES (NEVER)
+
+**NEVER auto-fix code without explicit approval.**
+
+Always ask: "Would you like me to auto-fix these issues? (YES/NO)"
+
+Examples of auto-fixable issues:
+- ESLint/Prettier style issues
+- Missing imports
+- Type annotation fixes
+
+Examples NOT auto-fixable without approval:
+- Logic changes
+- Architecture refactoring
+- Security fixes
+
+---
+
+### 🚨 RULE #2: BE CONSTRUCTIVE, NOT CRITICAL
+
+**Frame feedback helpfully:**
+
+❌ WRONG: "This code is terrible and violates X pattern"
+✅ RIGHT: "This could be improved by using X pattern because it would benefit Y"
+
+**Include Positive Observations section:**
+- ✅ Good use of TypeScript strict mode
+- ✅ Well-structured error handling
+- ✅ Clear variable naming conventions
+
+---
+
+### 🚨 RULE #3: SHOW BAD AND GOOD CODE EXAMPLES
+
+For every issue, provide both:
+
+```typescript
+// ❌ BAD
+const query = `SELECT * FROM users WHERE id = ${userId}`;
+
+// ✅ GOOD
+const query = "SELECT * FROM users WHERE id = ?";
+db.query(query, [userId]);
 ```
 
+Never just describe - show actual code.
+
+---
+
+### 🚨 RULE #4: PRIORITIZE BY SEVERITY
+
+| Severity | Action | Blocks Merge? |
+|----------|--------|---------------|
+| CRITICAL | Must fix before merge | YES - fail PR check |
+| HIGH | Should fix before merge | Warn, but reviewable |
+| MEDIUM | Consider fixing | Optional |
+| LOW | Nice to have | Suggest follow-up story |
+
+---
+
+### 🚨 RULE #5: CALCULATE CODE QUALITY SCORE
+
+Calculate 0-100 score with breakdown:
+
+```
+Code Quality Score: 72/100
+
+Breakdown:
+- Security: 40/100 (2 critical issues)
+- Performance: 75/100 (1 N+1 query)
+- Maintainability: 80/100 (some complexity)
+- Testing: 65/100 (coverage gaps)
+- Style: 90/100 (mostly consistent)
+```
+
+---
+
+### 🚨 RULE #6: SAVE REPORT TO FILE
+
+Always save to: `docs/08-project/code-reviews/<YYYYMMDD>-<BRANCH>.md`
+
+Include:
+- Branch name
+- Base branch
+- Files changed
+- Lines added/removed
+- All issues grouped by severity
+- Quality score
+- Recommendations
+
+---
+
+### ANTI-PATTERNS (DON'T DO THESE)
+
+❌ Auto-fix without asking
+❌ Use harsh language or blame
+❌ Only show bad code examples
+❌ Miss positive observations
+❌ Treat MEDIUM issues as CRITICAL
+❌ Provide feedback without code examples
+
+### DO THESE INSTEAD
+
+✅ Always ask before auto-fixing
+✅ Frame feedback constructively
+✅ Show both BAD and GOOD examples
+✅ Celebrate good practices
+✅ Correct severity assessment
+✅ Include specific code snippets
+
+---
+
+### ANALYSIS CATEGORIES
+
+| Category | What to Check | Tools |
+|----------|---------------|-------|
+| **Code Quality** | Complexity, duplication, naming, function length | Cyclomatic complexity, AST analysis |
+| **Security** | SQL injection, XSS, hardcoded secrets, input validation | Pattern matching, regex |
+| **Performance** | N+1 queries, inefficient algorithms, memory leaks | Database query analysis |
+| **Best Practices** | Error handling, logging, type safety, DRY | Code pattern matching |
+| **Testing** | Coverage gaps, missing tests, flaky tests | Coverage reports, test analysis |
+| **Documentation** | Missing JSDoc, outdated comments, API docs | Comment analysis |
+
+---
+
+### THRESHOLDS
+
+| Metric | Acceptable | Warning | Critical |
+|--------|-----------|---------|----------|
+| Cyclomatic Complexity | <10 | 10-15 | >15 |
+| Function Length | <50 lines | 50-100 | >100 |
+| File Length | <500 lines | 500-1000 | >1000 |
+| Test Coverage | >80% | 60-80% | <60% |
+| Code Quality Score | >80 | 60-80 | <60 |
+
+---
+
+### WORKFLOW
+
+1. **Get git diff**: `git diff <BASE>...<BRANCH>` (parse changed files)
+2. **Analyze changes**: Run 6-category analysis
+3. **Identify issues**: Group by severity (CRITICAL/HIGH/MEDIUM/LOW)
+4. **Generate report**: Create structured markdown with examples
+5. **Calculate score**: 0-100 with category breakdown
+6. **Include positives**: Celebrate good practices
+7. **Ask about fixes**: "Auto-fix these issues? (YES/NO)"
+8. **Save report**: To `docs/08-project/code-reviews/<YYYYMMDD>-<BRANCH>.md`
+
+---
+
+### TOOL USAGE EXAMPLES
+
+**TodoWrite** (to track review progress):
+```xml
+<invoke name="TodoWrite">
+<parameter name="content">1. Get git diff between BASE and BRANCH
+2. Analyze code for 6 categories
+3. Identify issues and prioritize by severity
+4. Generate code review report with examples
+5. Calculate code quality score
+6. Ask about auto-fixes
+7. Save report to file</parameter>
+<parameter name="status">in-progress</parameter>
+</invoke>
+```
+
+**AskUserQuestion** (for auto-fix approval):
+```xml
+<invoke name="AskUserQuestion">
+<parameter name="questions">[{
+  "question": "Auto-fix these issues?",
+  "header": "Code Review",
+  "multiSelect": false,
+  "options": [
+    {"label": "Auto-fix all (Recommended)", "description": "Fix 8 style issues automatically"},
+    {"label": "Review each one", "description": "Show diffs for approval"},
+    {"label": "Skip auto-fixes", "description": "Just report, no changes"}
+  ]
+}]</parameter>
+</invoke>
+```
+
+---
+
+### REMEMBER AFTER COMPACTION
+
+- `/agileflow:ai-code-review` IS ACTIVE
+- NEVER auto-fix without explicit approval
+- Be constructive - include positive observations
+- Show both BAD and GOOD code examples
+- Prioritize by severity (CRITICAL blocks merge)
+- Calculate 0-100 quality score
+- Save report to docs/08-project/code-reviews/
+
 <!-- COMPACT_SUMMARY_END -->
 
 # ai-code-review

package/src/core/commands/session/end.md

@@ -1,6 +1,19 @@
 ---
 description: Cleanly end session and record summary
 argument-hint: (no arguments)
+compact_context:
+  priority: high
+  preserve_rules:
+    - "ACTIVE COMMAND: /agileflow:session:end - Terminate current session"
+    - "Gets current session, prompts for end/delete/cancel options"
+    - "Only deletes worktree if not main session (is_main: false)"
+    - "Updates registry to mark session inactive, removes lock file"
+    - "Main session can only be marked inactive, not deleted"
+    - "Use AskUserQuestion to let user choose option"
+  state_fields:
+    - current_session
+    - is_main_session
+    - user_choice
 ---
 
 # /agileflow:session:end
@@ -100,3 +113,199 @@ The main project is not a worktree and cannot be removed.
 - `/agileflow:session:new` - Create new session
 - `/agileflow:session:resume` - Switch sessions
 - `/agileflow:session:status` - View all sessions
+
+---
+
+<!-- COMPACT_SUMMARY_START -->
+
+## ⚠️ COMPACT SUMMARY - /agileflow:session:end IS ACTIVE
+
+**CRITICAL**: This command terminates the current session. It MUST handle three cases: main session / non-main session / cancel.
+
+---
+
+### 🚨 RULE #1: CHECK IF MAIN SESSION FIRST
+
+Before doing anything, determine if current session is main:
+```bash
+node .agileflow/scripts/session-manager.js status
+# If is_main: true → can only mark inactive
+# If is_main: false → can delete worktree
+```
+
+---
+
+### 🚨 RULE #2: USE AskUserQuestion FOR OPTIONS
+
+**For MAIN session** (only 2 options):
+```xml
+<invoke name="AskUserQuestion">
+<parameter name="questions">[{
+  "question": "End Session 1 (main)?",
+  "header": "End session",
+  "multiSelect": false,
+  "options": [
+    {"label": "Yes, end session",
+     "description": "Mark session inactive (keep project for later)"},
+    {"label": "Cancel",
+     "description": "Keep session active"}
+  ]
+}]</parameter>
+</invoke>
+```
+
+**For NON-MAIN session** (3 options):
+```xml
+<invoke name="AskUserQuestion">
+<parameter name="questions">[{
+  "question": "End Session 2 \"auth\"?",
+  "header": "End session",
+  "multiSelect": false,
+  "options": [
+    {"label": "Yes, end session",
+     "description": "Mark session inactive (keep worktree for later)"},
+    {"label": "End and delete worktree",
+     "description": "Remove session and its directory completely"},
+    {"label": "Cancel",
+     "description": "Keep session active"}
+  ]
+}]</parameter>
+</invoke>
+```
+
+---
+
+### 🚨 RULE #3: HANDLE EACH USER CHOICE
+
+**If "Yes, end session" selected:**
+```bash
+node .agileflow/scripts/session-manager.js unregister {session_id}
+```
+Display:
+```
+✓ Session {id} ended
+
+  Branch: {branch}
+  Story:  {story_id} (status unchanged)
+  Worktree kept at: {path}
+
+To resume later: cd {path} && claude
+```
+
+**If "End and delete worktree" selected** (non-main only):
+```bash
+node .agileflow/scripts/session-manager.js delete {session_id} --remove-worktree
+```
+Display:
+```
+✓ Session {id} ended and removed
+
+  Branch: {branch}
+  Worktree removed: {path}
+
+💡 The branch still exists. To delete it:
+   git branch -d {branch}
+```
+
+**If "Cancel" selected:**
+```
+Session remains active.
+```
+
+---
+
+### 🚨 RULE #4: MAIN SESSION WARNING
+
+If session is main (is_main: true):
+```
+⚠️ This is the main project session.
+
+You can only end this session (mark inactive), not delete the directory.
+The main project is not a worktree and cannot be removed.
+```
+
+Then show the 2-option prompt (end or cancel).
+
+---
+
+### 🚨 RULE #5: BRANCH MANAGEMENT NOTE
+
+When deleting worktree, remind user the branch persists:
+```
+💡 The branch still exists. To delete it:
+   git branch -d {branch}
+```
+
+This is important because users might want to keep branch history.
+
+---
+
+### KEY FILES TO REMEMBER
+
+| File | Purpose |
+|------|---------|
+| `.agileflow/sessions/registry.json` | Session registry |
+| `.agileflow/sessions/{id}.lock` | Removed when session ends |
+| `.agileflow/scripts/session-manager.js` | Unregister and delete |
+
+---
+
+### WORKFLOW
+
+1. **Get current session** → `session-manager.js status`
+2. **Check is_main** → Determine option set
+3. **If main** → Show warning + 2 options
+4. **If not main** → Show no warning + 3 options
+5. **User selects** → Handle choice
+6. **Execute** → Call manager script
+7. **Display result** → Show success/failure
+
+---
+
+### SESSION DATA STRUCTURE
+
+From `session-manager.js status`:
+```json
+{
+  "id": 1,
+  "path": "/home/user/project",
+  "branch": "main",
+  "status": "active",
+  "is_main": true,
+  "is_current": true,
+  "created": "2025-12-20T10:00:00Z",
+  "last_active": "2025-12-20T10:30:00Z"
+}
+```
+
+---
+
+### ANTI-PATTERNS (DON'T DO THESE)
+
+❌ Show delete option for main session
+❌ Unregister without checking is_main
+❌ Don't warn about main session status
+❌ Don't mention branch deletion after worktree removal
+❌ Use different prompts for main vs non-main
+
+### DO THESE INSTEAD
+
+✅ Always check is_main first
+✅ Show appropriate options (2 for main, 3 for non-main)
+✅ Warn if main session
+✅ Remind about branch deletion
+✅ Use consistent prompt format
+
+---
+
+### REMEMBER AFTER COMPACTION
+
+- `/agileflow:session:end` IS ACTIVE
+- ALWAYS check is_main before prompting
+- Main: 2 options (end / cancel)
+- Non-main: 3 options (end / delete / cancel)
+- Warn if main session
+- Remind about branch deletion after worktree removal
+- Use AskUserQuestion for all options
+
+<!-- COMPACT_SUMMARY_END -->