agile-context-engineering 0.3.0 → 0.5.1

package/{commands/ace/review-story.md → skills/review-story/SKILL.md}

@@ -1,109 +1,99 @@
----
-name: ace:review-story
-description: Standalone code review — performs 3-level artifact verification, anti-pattern detection, coding standards enforcement, and tech debt discovery against a story's implementation
-argument-hint: "story=<file-path|github-url>"
-allowed-tools:
-  - Read
-  - Bash
-  - Glob
-  - Grep
----
-
-```xml
-<command>
-
-    <execution-time>
-        <runs-after>
-            <trigger>After /ace:execute-story — to re-run code review after manual changes</trigger>
-            <trigger>Anytime — to review a story implementation standalone</trigger>
-        </runs-after>
-        <use-when>
-            <condition>A story has been implemented and needs code review</condition>
-            <condition>Re-checking after manual changes post-execution</condition>
-            <condition>Verifying stories implemented outside ACE</condition>
-            <condition>Pre-merge quality gate</condition>
-        </use-when>
-    </execution-time>
-
-    <input>
-        <flags>
-        </flags>
-
-        <parameters>
-            <required>
-                <param name="story" type="file | github-url">
-                    Story source — can be either:
-                    - **File path**: Path to a fully-planned story markdown file
-                      (must have AC + Technical Solution sections)
-                    - **GitHub URL or issue number**: GitHub story reference
-                    Must be a valid, accessible file or GitHub issue.
-                    The story MUST have Acceptance Criteria and Technical Solution.
-                </param>
-            </required>
-        </parameters>
-    </input>
-
-    <execution-context>
-        <review-story-workflow>@~/.claude/agile-context-engineering/workflows/review-story.xml</review-story-workflow>
-        <story-template>@~/.claude/agile-context-engineering/templates/product/story.xml</story-template>
-        <ui-formatting>@~/.claude/agile-context-engineering/utils/ui-formatting.md</ui-formatting>
-    </execution-context>
-
-    <output>
-        <objective>
-            Review a story's implementation directly (the session IS the reviewer):
-            1. Load story context (AC, Technical Solution, Out of Scope)
-            2. Identify changed/created files related to the story
-            3. Run 3-level artifact verification (EXISTS → SUBSTANTIVE → WIRED)
-            4. Detect anti-patterns (dead code, stubs, TODOs, hardcoded values)
-            5. Enforce coding standards (mandatory, blocker-level)
-            6. Check AC coverage (all Gherkin scenarios implemented)
-            7. Discover pre-existing tech debt in touched files
-            8. Report results with structured format
-        </objective>
-
-        <artifacts>
-            No files modified — this command is read-only.
-            Outputs a structured review report to the conversation.
-        </artifacts>
-    </output>
-
-    <process>
-        For this command use the `ace-code-reviewer` agent
-        that's specialized in code review.
-
-        Execute the review-story workflow from
-        `@~/.claude/agile-context-engineering/workflows/review-story.xml` end-to-end.
-
-        **CRITICAL REQUIREMENTS:**
-        - Story MUST have Acceptance Criteria — STOP if missing
-        - Story MUST have Technical Solution — STOP if missing
-        - This is a READ-ONLY command — do NOT modify any code
-        - Coding standards violations are BLOCKERS, not warnings
-        - Dead code and backwards-compatible shims must be flagged for DELETION
-    </process>
-
-    <example-usage>
-        ```
-        # Review a story from a file path
-        /ace:review-story \
-          story=.ace/artifacts/product/e1-auth/f3-oauth/s1-buttons/s1-buttons.md
-
-        # Review from a GitHub issue
-        /ace:review-story \
-          story=https://github.com/owner/repo/issues/95
-
-        # With just an issue number
-        /ace:review-story story=#95
-        ```
-    </example-usage>
-
-    <next-steps>
-        **After this command:**
-        - `/ace:execute-story story=...` — Re-execute to fix reported issues
-        - `/ace:review-story story=...` — Re-run review after fixes
-        - `/ace:help` — Check project status
-    </next-steps>
-
-</command>
-```
+---
+name: review-story
+description: Standalone code review -- performs 3-level artifact verification, anti-pattern detection, coding standards enforcement, and tech debt discovery against a story's implementation
+argument-hint: "story=<file-path|github-url>"
+disable-model-invocation: true
+allowed-tools: Read, Bash, Glob, Grep
+model: sonnet
+effort: high
+context: fork
+agent: ace-code-reviewer
+---
+
+## Environment Context (preprocessed)
+
+!`node "${CLAUDE_SKILL_DIR}/script.js" init "$ARGUMENTS" 2>/dev/null`
+
+## Supporting Resources (auto-loaded)
+
+!`cat "${CLAUDE_SKILL_DIR}/workflow.xml"`
+
+!`cat "${CLAUDE_SKILL_DIR}/story-template.xml"`
+
+!`cat "${CLAUDE_SKILL_DIR}/../../shared/utils/ui-formatting.md"`
+
+```xml
+<command>
+
+    <execution-time>
+        <runs-after>
+            <trigger>After /ace:execute-story — to re-run code review after manual changes</trigger>
+            <trigger>Anytime — to review a story implementation standalone</trigger>
+        </runs-after>
+        <use-when>
+            <condition>A story has been implemented and needs code review</condition>
+            <condition>Re-checking after manual changes post-execution</condition>
+            <condition>Verifying stories implemented outside ACE</condition>
+            <condition>Pre-merge quality gate</condition>
+        </use-when>
+    </execution-time>
+
+    <input>
+        <flags>
+        </flags>
+
+        <parameters>
+            <required>
+                <param name="story" type="file | github-url">
+                    Story source — can be either:
+                    - **File path**: Path to a fully-planned story markdown file
+                      (must have AC + Technical Solution sections)
+                    - **GitHub URL or issue number**: GitHub story reference
+                    Must be a valid, accessible file or GitHub issue.
+                    The story MUST have Acceptance Criteria and Technical Solution.
+                </param>
+            </required>
+        </parameters>
+    </input>
+
+    <execution-context>
+        <!-- All supporting files are auto-loaded in the Supporting Resources section above.
+             The model does NOT need to Read these files — they are already in context. -->
+    </execution-context>
+
+    <output>
+        <objective>
+            Review a story's implementation directly (the session IS the reviewer):
+            1. Load story context (AC, Technical Solution, Out of Scope)
+            2. Identify changed/created files related to the story
+            3. Run 3-level artifact verification (EXISTS → SUBSTANTIVE → WIRED)
+            4. Detect anti-patterns (dead code, stubs, TODOs, hardcoded values)
+            5. Enforce coding standards (mandatory, blocker-level)
+            6. Check AC coverage (all Gherkin scenarios implemented)
+            7. Discover pre-existing tech debt in touched files
+            8. Report results with structured format
+        </objective>
+
+        <artifacts>
+            No files modified — this command is read-only.
+            Outputs a structured review report to the conversation.
+        </artifacts>
+    </output>
+
+    <process>
+        For this command use the `ace-code-reviewer` agent
+        that's specialized in code review.
+
+        Execute the review-story workflow from
+        `workflow.xml` end-to-end.
+
+        **CRITICAL REQUIREMENTS:**
+        - Story MUST have Acceptance Criteria — STOP if missing
+        - Story MUST have Technical Solution — STOP if missing
+        - This is a READ-ONLY command — do NOT modify any code
+        - Coding standards violations are BLOCKERS, not warnings
+        - Dead code and backwards-compatible shims must be flagged for DELETION
+    </process>
+
+    <example-usage>
+        ```

package/skills/review-story/script.js

@@ -0,0 +1,249 @@
+#!/usr/bin/env node
+
+/**
+ * review-story skill script — Entry point for ace-tools operations
+ * needed by the review-story skill.
+ *
+ * Subcommands:
+ *   init [story-param]        Environment detection for review-story workflow
+ *
+ * Usage: node script.js <subcommand> [args] [--raw]
+ */
+
+const fs = require('fs');
+const path = require('path');
+
+const {
+  loadConfig, pathExists, safeReadFile, loadSettings, resolveModel,
+  execCommand, output, error, runSkillScript,
+} = require('../../shared/lib/ace-core');
+
+const {
+  classifyStoryParam, extractStoryMetadata, extractStoryRequirements,
+  extractMarkdownSection, extractIssueNumber, extractIssueNumberFromFile,
+  computeStoryPaths,
+} = require('../../shared/lib/ace-story');
+
+// ─── CLI Dispatch ────────────────────────────────────────────────────────────
+
+runSkillScript({
+  init: cmdInit,
+});
+
+// ─── Init: Execute/Review Story ─────────────────────────────────────────────
+
+/**
+ * Environment detection for the review-story workflow.
+ *
+ * Replicates cmdInitExecuteStory from ace-tools.js:
+ * 1. loadConfig, detect git/gh CLI/settings/agent_teams
+ * 2. classifyStoryParam
+ * 3. Load story content
+ * 4. extractStoryMetadata, extractStoryRequirements
+ * 5. Detect key sections (AC, technical solution, wiki refs, coding standards)
+ * 6. computeStoryPaths
+ * 7. Output JSON with all data
+ */
+function cmdInit(cwd, raw, args, parsed) {
+  const storyParam = parsed.story || parsed._positional || null;
+  const config = loadConfig(cwd);
+
+  // ── Environment detection ──
+  const has_git = pathExists(cwd, '.git');
+  const has_gh_cli = (() => {
+    try {
+      const { execSync } = require('child_process');
+      execSync('gh --version', { stdio: 'pipe' });
+      return true;
+    } catch { return false; }
+  })();
+  const settings = loadSettings(cwd);
+  const github_project = settings.github_project;
+
+  // ── Agent teams detection (sync from runtime settings) ──
+  // RUNTIME_CONFIG_DIR is not in shared libs — detect inline
+  // Try runtime settings files that can carry ACE agent-team state.
+  let agent_teams = settings.agent_teams || false;
+  for (const configDir of ['.claude', '.codex', '.opencode']) {
+    const claudeSettingsPath = path.join(cwd, configDir, 'settings.json');
+    try {
+      const claudeRaw = fs.readFileSync(claudeSettingsPath, 'utf-8');
+      const claudeSettings = JSON.parse(claudeRaw);
+      const val = claudeSettings?.env?.CLAUDE_CODE_EXPERIMENTAL_AGENT_TEAMS;
+      if (val === '1' || val === 'true') {
+        agent_teams = true;
+      }
+      break; // found a settings file, stop looking
+    } catch {}
+  }
+
+  // ── Classify the story parameter ──
+  const classified = classifyStoryParam(storyParam);
+
+  // Early exit if invalid
+  if (classified.type === null || classified.type === 'invalid') {
+    output({
+      executor_model: resolveModel(cwd, 'ace-executor'),
+      reviewer_model: resolveModel(cwd, 'ace-code-reviewer'),
+      commit_docs: config.commit_docs,
+      has_git, has_gh_cli, github_project, agent_teams,
+      story_source: null,
+      story_valid: false,
+      story_error: classified.reason || 'No story parameter provided',
+      story_content: null,
+      story: { id: null, title: null, status: null, size: null },
+      feature: { id: null, title: null },
+      epic: { id: null, title: null },
+      has_acceptance_criteria: false,
+      acceptance_criteria_count: 0,
+      has_technical_solution: false,
+      has_wiki_refs: false,
+      has_coding_standards: false,
+      paths: null,
+    }, raw);
+    return;
+  }
+
+  // ── Load story content ──
+  let storyContent = null;
+  let storySource = classified.type === 'file' ? 'file' : 'github';
+  let storyError = null;
+  let storyFilePath = null;
+
+  if (classified.type === 'file') {
+    const resolvedPath = path.isAbsolute(classified.filePath)
+      ? classified.filePath
+      : path.join(cwd, classified.filePath);
+    if (!pathExists(cwd, classified.filePath)) {
+      storyError = `Story file not found: ${classified.filePath}`;
+    } else {
+      storyContent = safeReadFile(resolvedPath);
+      storyFilePath = classified.filePath;
+      if (!storyContent) storyError = `Could not read story file: ${classified.filePath}`;
+    }
+  } else {
+    // github-url or issue-number
+    if (!has_gh_cli) {
+      storyError = 'GitHub CLI (gh) not installed. Cannot fetch GitHub issues.';
+    } else {
+      const repo = classified.repo || (github_project.repo || null);
+      if (!repo) {
+        storyError = 'No repository configured. Provide a full GitHub URL or configure github_project.repo in settings.';
+      } else {
+        const ghResult = execCommand(
+          `gh issue view ${classified.issueNumber} --repo ${repo} --json title,body,labels,state`,
+          cwd
+        );
+        if (!ghResult) {
+          storyError = `Could not fetch GitHub issue #${classified.issueNumber} from ${repo}.`;
+        } else {
+          try {
+            const issue = JSON.parse(ghResult);
+            storyContent = issue.body || '';
+            if (storyContent && !storyContent.match(/^#\s+/m)) {
+              storyContent = `# ${issue.title}\n\n${storyContent}`;
+            }
+          } catch {
+            storyError = `Failed to parse GitHub issue response for #${classified.issueNumber}.`;
+          }
+        }
+      }
+    }
+  }
+
+  // ── Extract metadata & requirements ──
+  const metadata = extractStoryMetadata(storyContent);
+  const requirements = extractStoryRequirements(storyContent);
+
+  // ── Detect key sections ──
+  const has_acceptance_criteria = requirements.acceptance_criteria_count > 0;
+  const has_technical_solution = storyContent
+    ? !!extractMarkdownSection(storyContent, 'Technical Solution', 2)
+    : false;
+  const has_wiki_refs = storyContent
+    ? !!extractMarkdownSection(storyContent, 'Relevant Wiki', 2)
+    : false;
+  const has_coding_standards = pathExists(cwd, '.docs/wiki/system-wide/coding-standards.md');
+
+  // ── Compute paths ──
+  let paths = null;
+  let has_story_file = false;
+
+  if (storyFilePath) {
+    const resolvedPath = path.isAbsolute(storyFilePath)
+      ? storyFilePath
+      : path.join(cwd, storyFilePath);
+    const storyDir = path.dirname(resolvedPath);
+    const relStoryDir = path.relative(cwd, storyDir).replace(/\\/g, '/');
+    const storySlug = path.basename(storyDir);
+    const featureDir = path.dirname(storyDir);
+    const relFeatureDir = path.relative(cwd, featureDir).replace(/\\/g, '/');
+    const featureSlug = path.basename(featureDir);
+
+    paths = {
+      epic_slug: null,
+      feature_slug: featureSlug,
+      story_slug: storySlug,
+      story_dir: relStoryDir,
+      story_file: storyFilePath.replace(/\\/g, '/'),
+      external_analysis_file: `${relStoryDir}/external-analysis.md`,
+      integration_analysis_file: `${relStoryDir}/integration-analysis.md`,
+      feature_dir: relFeatureDir,
+      feature_file: `${relFeatureDir}/${featureSlug}.md`,
+      product_backlog: '.ace/artifacts/product/product-backlog.md',
+      coding_standards: '.docs/wiki/system-wide/coding-standards.md',
+    };
+    has_story_file = true;
+  } else if (metadata.epic.id && metadata.feature.id && metadata.id) {
+    const computed = computeStoryPaths(
+      metadata.epic.id, metadata.epic.title || '',
+      metadata.feature.id, metadata.feature.title || '',
+      metadata.id, metadata.title || ''
+    );
+    if (computed) {
+      paths = {
+        ...computed,
+        product_backlog: '.ace/artifacts/product/product-backlog.md',
+        coding_standards: '.docs/wiki/system-wide/coding-standards.md',
+      };
+      has_story_file = pathExists(cwd, paths.story_file);
+    }
+  }
+
+  // ── Extract GitHub issue numbers ──
+  const storyIssueNumber = extractIssueNumber(metadata.link);
+  const featureIssueNumber = paths ? extractIssueNumberFromFile(cwd, paths.feature_file) : null;
+
+  // ── Build result ──
+  const result = {
+    executor_model: resolveModel(cwd, 'ace-executor'),
+    reviewer_model: resolveModel(cwd, 'ace-code-reviewer'),
+    commit_docs: config.commit_docs,
+    has_git, has_gh_cli, github_project, agent_teams,
+    story_source: storySource,
+    story_valid: storyContent !== null && storyError === null,
+    story_error: storyError,
+    story_content: storyContent,
+    story: {
+      id: metadata.id,
+      title: metadata.title,
+      status: metadata.status,
+      size: metadata.size,
+      issue_number: storyIssueNumber,
+    },
+    feature: {
+      ...metadata.feature,
+      issue_number: featureIssueNumber,
+    },
+    epic: metadata.epic,
+    has_acceptance_criteria,
+    acceptance_criteria_count: requirements.acceptance_criteria_count,
+    has_technical_solution,
+    has_wiki_refs,
+    has_coding_standards,
+    paths,
+    has_story_file,
+  };
+
+  output(result, raw);
+}

package/skills/review-story/script.test.js

@@ -0,0 +1,169 @@
+const { describe, it, before, after } = require('node:test');
+const assert = require('node:assert');
+const { execSync } = require('child_process');
+const fs = require('fs');
+const path = require('path');
+const os = require('os');
+
+const SCRIPT = path.join(__dirname, 'script.js');
+
+/**
+ * Create a minimal ACE project structure in a temp directory.
+ */
+function createTestProject() {
+  const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ace-test-'));
+
+  // .ace/config.json
+  const aceDir = path.join(tmpDir, '.ace');
+  fs.mkdirSync(aceDir, { recursive: true });
+  fs.writeFileSync(path.join(aceDir, 'config.json'), JSON.stringify({
+    version: '0.1.0',
+    projectName: 'test-project',
+    model_profile: 'quality',
+    commit_docs: true,
+    github: { enabled: false },
+  }, null, 2));
+
+  // .ace/settings.json
+  fs.writeFileSync(path.join(aceDir, 'settings.json'), JSON.stringify({
+    model_profile: 'quality',
+    commit_docs: true,
+    agent_teams: false,
+    github_project: { enabled: false, gh_installed: false, repo: '', project_number: null, owner: '' },
+  }, null, 2));
+
+  return tmpDir;
+}
+
+/**
+ * Create a story file in the test project.
+ */
+function createStoryFile(tmpDir, relPath, content) {
+  const fullPath = path.join(tmpDir, relPath);
+  fs.mkdirSync(path.dirname(fullPath), { recursive: true });
+  fs.writeFileSync(fullPath, content, 'utf-8');
+  return relPath;
+}
+
+function runScript(subcommand, args, cwd) {
+  return execSync(`node "${SCRIPT}" ${subcommand} ${args}`, {
+    cwd,
+    encoding: 'utf-8',
+    timeout: 10000,
+  });
+}
+
+function cleanup(tmpDir) {
+  fs.rmSync(tmpDir, { recursive: true, force: true });
+}
+
+// ─── Tests ───────────────────────────────────────────────────────────────────
+
+describe('review-story script', () => {
+
+  describe('init', () => {
+    let tmpDir;
+
+    before(() => { tmpDir = createTestProject(); });
+    after(() => { cleanup(tmpDir); });
+
+    it('returns valid JSON with environment detection for a story file', () => {
+      const storyContent = [
+        '# S1: Add Login Button',
+        '**Feature**: F1 User Auth | **Epic**: E1 Platform',
+        '**Status**: Todo | **Size**: 3 | **Sprint**: — | **Link**: —',
+        '',
+        '## User Story',
+        '',
+        '> As a user,',
+        '> I want to click a login button,',
+        '> so that I can access my account.',
+        '',
+        '## Description',
+        '',
+        'Adds a login button to the header.',
+        '',
+        '## Acceptance Criteria',
+        '',
+        '### Scenario: Click login button',
+        '',
+        '**Given** the user is on the homepage',
+        '**When** they click "Login"',
+        '**Then** they see the login form',
+        '',
+        '## Technical Solution',
+        '',
+        'Add a LoginButton component to the header.',
+      ].join('\n');
+
+      const storyPath = createStoryFile(
+        tmpDir,
+        '.ace/artifacts/product/e1-platform/f1-user-auth/s1-add-login-button/s1-add-login-button.md',
+        storyContent
+      );
+
+      const result = JSON.parse(runScript('init', storyPath, tmpDir));
+
+      assert.ok(result.executor_model, 'should have executor_model');
+      assert.ok(result.reviewer_model, 'should have reviewer_model');
+      assert.strictEqual(result.story_valid, true, 'story should be valid');
+      assert.strictEqual(result.story_source, 'file');
+      assert.strictEqual(result.story.id, 'S1');
+      assert.strictEqual(result.story.title, 'Add Login Button');
+      assert.strictEqual(result.story.status, 'Todo');
+      assert.strictEqual(result.has_acceptance_criteria, true);
+      assert.strictEqual(result.acceptance_criteria_count, 1);
+      assert.strictEqual(result.has_technical_solution, true);
+      assert.ok(result.paths, 'should have computed paths');
+      assert.ok(result.paths.story_file.includes('s1-add-login-button'));
+      assert.strictEqual(result.has_story_file, true);
+      assert.strictEqual(typeof result.commit_docs, 'boolean');
+      assert.strictEqual(typeof result.has_git, 'boolean');
+      assert.strictEqual(typeof result.agent_teams, 'boolean');
+      assert.ok(result.story_content, 'should include story_content');
+    });
+
+    it('errors on init without story param', () => {
+      const result = JSON.parse(runScript('init', '', tmpDir));
+      assert.strictEqual(result.story_valid, false);
+    });
+
+    it('handles non-existent story file gracefully', () => {
+      const result = JSON.parse(runScript('init', 'nonexistent/story.md', tmpDir));
+      assert.strictEqual(result.story_valid, false);
+      assert.ok(result.story_error.includes('not found'));
+    });
+
+    it('detects missing technical solution section', () => {
+      const storyContent = [
+        '# S2: Simple Story',
+        '**Feature**: F1 Test | **Epic**: E1 Test',
+        '**Status**: Todo | **Size**: 1 | **Sprint**: — | **Link**: —',
+        '',
+        '## Description',
+        '',
+        'A simple story without technical solution.',
+      ].join('\n');
+
+      const storyPath = createStoryFile(
+        tmpDir,
+        '.ace/artifacts/product/e1-test/f1-test/s2-simple-story/s2-simple-story.md',
+        storyContent
+      );
+
+      const result = JSON.parse(runScript('init', storyPath, tmpDir));
+
+      assert.strictEqual(result.story_valid, true);
+      assert.strictEqual(result.has_technical_solution, false);
+      assert.strictEqual(result.has_acceptance_criteria, false);
+    });
+  });
+
+  describe('error handling', () => {
+    it('errors on unknown command', () => {
+      assert.throws(() => {
+        execSync(`node "${SCRIPT}" bogus`, { encoding: 'utf-8', stdio: 'pipe' });
+      });
+    });
+  });
+});