agentxchain 2.155.71 → 2.155.73

package/src/lib/turn-result-validator.js

@@ -138,7 +138,7 @@ export function validateStagedTurnResult(root, state, config, opts = {}) {
   }
 
   // ── Stage C: Artifact Validation ───────────────────────────────────────
-  const artifactResult = validateArtifact(turnResult, config);
+  const artifactResult = validateArtifact(turnResult, config, state);
   if (artifactResult.errors.length > 0) {
     return result('artifact', 'artifact_error', artifactResult.errors, artifactResult.warnings);
   }
@@ -670,7 +670,7 @@ function validateAssignment(tr, state) {
 
 // ── Stage C: Artifact Validation ─────────────────────────────────────────────
 
-function validateArtifact(tr, config) {
+function validateArtifact(tr, config, state = null) {
   const errors = [];
   const warnings = [];
 
@@ -699,6 +699,11 @@ function validateArtifact(tr, config) {
         `Artifact type "workspace" requires authoritative write authority, but role "${tr.role}" has "${writeAuthority}".`
       );
     }
+    if ((tr.files_changed || []).length === 0 && !hasCheckpointableProducedFiles(tr)) {
+      errors.push(
+        'artifact.type: "workspace" but files_changed is empty. Use artifact type "review" for no-edit turns, or declare checkpointable verification.produced_files entries with disposition "artifact".'
+      );
+    }
   }
 
   // Check for reserved path modifications
@@ -722,9 +727,17 @@ function validateArtifact(tr, config) {
     }
   }
 
-  // Warn if files_changed is empty for authoritative + completed turns
-  if (writeAuthority === 'authoritative' && tr.status === 'completed' && (tr.files_changed || []).length === 0) {
-    warnings.push('Authoritative role completed with no files_changed — is this intentional?');
+  // Implementation-phase completion must be backed by actual product code
+  // changes. Planning/review artifacts are supplementary and should not satisfy
+  // the implementation_complete gate by themselves.
+  if (writeAuthority === 'authoritative' && state?.phase === 'implementation' && tr.status === 'completed') {
+    const productFiles = (tr.files_changed || []).filter(f => isProductChangePath(f));
+    if (productFiles.length === 0) {
+      errors.push(
+        `Role "${tr.role}" completed an implementation turn without product code changes in files_changed. ` +
+        'Implementation-phase completion requires at least one non-planning, non-review repo path; planning artifacts alone are not sufficient.'
+      );
+    }
   }
 
   // Validate proposed_changes for proposed runtimes that cannot write repo files directly.
@@ -772,6 +785,24 @@ function isAllowedReviewPath(filePath) {
   return filePath.startsWith('.planning/') || filePath.startsWith('.agentxchain/reviews/');
 }
 
+function isProductChangePath(filePath) {
+  return typeof filePath === 'string'
+    && filePath.trim().length > 0
+    && !isAllowedReviewPath(filePath)
+    && !filePath.startsWith('.agentxchain/staging/');
+}
+
+function hasCheckpointableProducedFiles(tr) {
+  return Array.isArray(tr.verification?.produced_files)
+    && tr.verification.produced_files.some((entry) => (
+      entry
+      && typeof entry === 'object'
+      && typeof entry.path === 'string'
+      && entry.path.trim()
+      && (entry.disposition == null || entry.disposition === 'artifact')
+    ));
+}
+
 // ── Stage D: Verification Validation ─────────────────────────────────────────
 
 function validateVerification(tr) {
@@ -1488,7 +1519,12 @@ export function normalizeTurnResult(tr, config, context = {}) {
     && !Array.isArray(normalized.artifact)
     && normalized.artifact.type === 'workspace'
     && filesChangedIsEmpty
-    && (context.forceReviewArtifact || hasExplicitNoEditLifecycleSignal)
+    && !hasCheckpointableProducedFiles(normalized)
+    && (
+      context.forceReviewArtifact
+      || hasExplicitNoEditLifecycleSignal
+      || (normalized.status === 'needs_human' && normalized.proposed_next_role === 'human')
+    )
   ) {
     normalized.artifact = {
       ...normalized.artifact,

package/src/lib/vision-reader.js

@@ -15,6 +15,13 @@ import { existsSync, readFileSync, readdirSync, statSync } from 'node:fs';
 import { join, resolve as pathResolve, isAbsolute } from 'node:path';
 import { createHash } from 'node:crypto';
 
+const ROADMAP_TRACKING_ANNOTATION_PATTERN = /<!--\s*tracking\s*:[\s\S]*?-->/i;
+
+export function stripRoadmapTrackingAnnotations(text) {
+  if (typeof text !== 'string') return '';
+  return text.replace(ROADMAP_TRACKING_ANNOTATION_PATTERN, '').replace(/\s+/g, ' ').trim();
+}
+
 // ---------------------------------------------------------------------------
 // Parsing
 // ---------------------------------------------------------------------------
@@ -259,8 +266,10 @@ export function deriveRoadmapCandidates(root, roadmapPath = '.planning/ROADMAP.m
 
     const uncheckedMatch = line.match(/^\s*[-*]\s+\[\s\]\s+(.+?)\s*$/);
     if (!uncheckedMatch || !currentMilestone) continue;
+    if (ROADMAP_TRACKING_ANNOTATION_PATTERN.test(line)) continue;
 
-    const goal = uncheckedMatch[1].trim();
+    const goal = stripRoadmapTrackingAnnotations(uncheckedMatch[1]);
+    if (!goal) continue;
     const combinedGoal = `${currentMilestone}: ${goal}`;
     if (isGoalAddressed(combinedGoal, allSignals) || isGoalAddressed(goal, allSignals)) {
       continue;
@@ -484,6 +493,7 @@ export function detectRoadmapExhaustedVisionOpen(root, visionPath, roadmapPath =
       continue;
     }
     if (currentMilestone && /^\s*[-*]\s+\[\s\]/.test(line)) {
+      if (ROADMAP_TRACKING_ANNOTATION_PATTERN.test(line)) continue;
       hasUnchecked = true;
     }
   }