agentxchain 2.155.47 → 2.155.49

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agentxchain",
-  "version": "2.155.47",
+  "version": "2.155.49",
   "description": "CLI for AgentXchain — governed multi-agent software delivery",
   "type": "module",
   "bin": {

package/src/lib/dispatch-bundle.js

@@ -491,8 +491,12 @@ function renderPrompt(role, roleId, turn, state, config, root) {
   lines.push('- `schema_version`: always `"1.0"`');
   lines.push('- `run_id`, `turn_id`, `role`, `runtime_id`: must match the values above exactly');
   lines.push('- `status`: one of `completed`, `blocked`, `needs_human`, `failed`. Do NOT use `complete`, `success`, `done`, or any other synonym — use the exact enum value `completed`.');
-  lines.push('- `summary`: concise description of what you did this turn');
-  lines.push('- `files_changed`: array of **strings** (file paths only). Do NOT use objects like `{path, change_type}` — just the path string (e.g. `["src/cli.js", "tests/smoke.mjs"]`).');
+  lines.push('- `decisions`: REQUIRED array. Use `[]` when no new decisions were made; do not omit the field.');
+  lines.push('- `objections`: REQUIRED array. Use `[]` when no objections are raised; review_only roles must include at least one objection.');
+  lines.push('- `summary`: **REQUIRED** non-empty string. Do NOT omit this field.');
+  lines.push('- `runtime_id`: **REQUIRED**. Must match the runtime_id provided above exactly.');
+  lines.push('- `files_changed`: **REQUIRED** array of **strings** (file paths only). Do NOT use `files_modified` — the field name is `files_changed`. Do NOT use objects like `{path, change_type}` — just the path string (e.g. `["src/cli.js", "tests/smoke.mjs"]`).');
+  lines.push('- `proposed_next_role`: **REQUIRED**. Must be in allowed_next_roles for the current phase, or `"human"`.');
   lines.push('- `decisions[].id`: pattern `DEC-NNN` where NNN is digits only (e.g. `DEC-001`, `DEC-002`). Do NOT use `D1`, `D2`, or freeform IDs.');
   lines.push('- `decisions[].statement`: non-empty string describing the decision. Do NOT use `decision` or `description` as the field name — the field is `statement`.');
   lines.push('- `decisions[].category`: one of `implementation`, `architecture`, `scope`, `process`, `quality`, `release`');
@@ -506,7 +510,6 @@ function renderPrompt(role, roleId, turn, state, config, root) {
   lines.push('- If you make zero repo file edits, set `artifact.type` to `"review"` and `files_changed` to `[]`.');
   lines.push('- Only set `artifact.type` to `"workspace"` when you actually modified repo files and listed every changed path in `files_changed`.');
   lines.push('- Every `objections[]` item must include a non-empty `statement`; do not use `summary` or `detail` as a substitute.');
-  lines.push('- `proposed_next_role`: must be in allowed_next_roles for current phase, or `human`');
   if (role.write_authority === 'review_only') {
     lines.push('- `objections`: **must be non-empty** (challenge requirement for review_only roles)');
   }

package/src/lib/turn-result-validator.js

@@ -85,6 +85,9 @@ export function validateStagedTurnResult(root, state, config, opts = {}) {
     if (activeTurn) {
       const roleKey = activeTurn.assigned_role || activeTurn.role;
       normContext.assignedRole = roleKey;
+      if (activeTurn.runtime_id) {
+        normContext.runtimeId = activeTurn.runtime_id;
+      }
       const roleConfig = config?.roles?.[roleKey];
       if (roleConfig) {
         normContext.writeAuthority = roleConfig.write_authority;
@@ -1002,6 +1005,21 @@ export function normalizeTurnResult(tr, config, context = {}) {
   }
 
   const normalized = { ...tr };
+
+  // ── BUG-95: rename synonym fields before variable computation ────────
+  // files_modified is an unambiguous synonym for files_changed.
+  if (!('files_changed' in normalized) && Array.isArray(normalized.files_modified)) {
+    corrections.push('files_changed: renamed from synonym files_modified');
+    normalizationEvents.push({
+      field: 'files_changed',
+      original_value: null,
+      normalized_value: '(renamed from files_modified)',
+      rationale: 'files_modified_renamed_to_files_changed',
+    });
+    normalized.files_changed = normalized.files_modified;
+    delete normalized.files_modified;
+  }
+
   const routing = config?.routing;
   const phaseNames = routing ? Object.keys(routing) : [];
   const currentPhase = context.phase;
@@ -1018,6 +1036,92 @@ export function normalizeTurnResult(tr, config, context = {}) {
   const hasExplicitNoEditLifecycleSignal = normalized.run_completion_request === true
     || (typeof normalized.phase_transition_request === 'string' && normalized.phase_transition_request.trim().length > 0);
 
+  // ── BUG-94: default missing top-level required arrays ────────────────
+  // Empty decisions/objections are schema-valid. Review-only challenge
+  // requirements remain enforced later by protocol validation.
+  if (!('decisions' in normalized)) {
+    corrections.push('decisions: defaulted missing required array to []');
+    normalizationEvents.push({
+      field: 'decisions',
+      original_value: null,
+      normalized_value: [],
+      rationale: 'missing_decisions_array_defaulted',
+    });
+    normalized.decisions = [];
+  }
+  if (!('objections' in normalized)) {
+    corrections.push('objections: defaulted missing required array to []');
+    normalizationEvents.push({
+      field: 'objections',
+      original_value: null,
+      normalized_value: [],
+      rationale: 'missing_objections_array_defaulted',
+    });
+    normalized.objections = [];
+  }
+
+  // ── BUG-95: default missing runtime_id from dispatch context ─────────
+  if (!normalized.runtime_id && context.runtimeId) {
+    corrections.push(`runtime_id: defaulted from dispatch context "${context.runtimeId}"`);
+    normalizationEvents.push({
+      field: 'runtime_id',
+      original_value: null,
+      normalized_value: context.runtimeId,
+      rationale: 'missing_runtime_id_defaulted_from_context',
+    });
+    normalized.runtime_id = context.runtimeId;
+  }
+
+  // ── BUG-95: synthesize missing summary from available fields ─────────
+  if (!normalized.summary || (typeof normalized.summary === 'string' && !normalized.summary.trim())) {
+    const alt = (typeof normalized.milestone_title === 'string' && normalized.milestone_title.trim())
+      ? normalized.milestone_title.trim()
+      : (typeof normalized.milestone === 'string' && normalized.milestone.trim())
+        ? `${normalized.role || 'agent'} turn for ${normalized.milestone.trim()}`
+        : `${normalized.role || 'agent'} turn completed`;
+    const src = (typeof normalized.milestone_title === 'string' && normalized.milestone_title.trim()) ? 'milestone_title'
+      : (typeof normalized.milestone === 'string' && normalized.milestone.trim()) ? 'milestone' : 'fallback';
+    corrections.push(`summary: synthesized from ${src}`);
+    normalizationEvents.push({
+      field: 'summary',
+      original_value: normalized.summary ?? null,
+      normalized_value: alt,
+      rationale: `missing_summary_synthesized_from_${src}`,
+    });
+    normalized.summary = alt;
+  }
+
+  // ── BUG-95: default missing artifact object ────────────────────────────
+  if (!normalized.artifact || typeof normalized.artifact !== 'object' || Array.isArray(normalized.artifact)) {
+    const hasFiles = Array.isArray(normalized.files_changed) && normalized.files_changed.length > 0;
+    const inferredArtifact = { type: hasFiles ? 'workspace' : 'review' };
+    corrections.push(`artifact: inferred ${JSON.stringify(inferredArtifact)} from files_changed`);
+    normalizationEvents.push({
+      field: 'artifact',
+      original_value: normalized.artifact ?? null,
+      normalized_value: inferredArtifact,
+      rationale: 'missing_artifact_inferred_from_files_changed',
+    });
+    normalized.artifact = inferredArtifact;
+  }
+
+  // ── BUG-95: default missing proposed_next_role ─────────────────────────
+  if (!normalized.proposed_next_role) {
+    let inferredRole = null;
+    if (allowedNextRoles.length > 0) {
+      inferredRole = allowedNextRoles.find(r => r !== assignedRole) || allowedNextRoles[0];
+    }
+    if (!inferredRole) inferredRole = 'pm';
+    corrections.push(`proposed_next_role: defaulted to "${inferredRole}"`);
+    normalizationEvents.push({
+      field: 'proposed_next_role',
+      original_value: null,
+      normalized_value: inferredRole,
+      rationale: 'missing_proposed_next_role_defaulted',
+    });
+    normalized.proposed_next_role = inferredRole;
+  }
+
   // ── BUG-90: normalize status synonyms ────────────────────────────────
   const STATUS_SYNONYMS = { complete: 'completed', success: 'completed', done: 'completed', error: 'failed', failure: 'failed' };
   if (typeof normalized.status === 'string' && !VALID_STATUSES.includes(normalized.status)) {