agentvibes 5.6.9 → 5.7.0

package/src/installer.js

@@ -4570,9 +4570,8 @@ async function handleMcpConfiguration(targetDir, options) {
  * @param {string} targetDir - Base installation directory to validate bmadPath is within
  */
 async function processBmadTtsInjections(bmadPath, targetDir) {
-  // Security: Validate bmadPath is within targetDir (not process.cwd() which may differ
-  // when called from BMAD's installer via npx with a different cwd)
-  if (!isPathSafe(bmadPath, targetDir)) {
+  // Security: bmadPath must be within targetDir OR home dir (BMAD may be installed globally at ~/_bmad)
+  if (!isPathSafe(bmadPath, targetDir) && !isPathSafe(bmadPath, os.homedir())) {
     console.error(chalk.red('⚠️  Security: Invalid BMAD path detected'));
     return;
   }
@@ -4841,14 +4840,17 @@ async function handleBmadIntegration(targetDir, options = {}) {
   }
 
   // Process TTS_INJECTION markers in BMAD files if they exist
-  // This handles the case where BMAD was installed before AgentVibes
-  await processBmadTtsInjections(bmadDetection.bmadPath, targetDir);
+  // Skip for global home-dir BMAD installs — only inject into project-local BMAD
+  if (!bmadDetection.isGlobal) {
+    await processBmadTtsInjections(bmadDetection.bmadPath, targetDir);
+  }
 
   // Create default voice assignments if they don't exist
   await createDefaultBmadVoiceAssignmentsProactive(targetDir);
 
   // Prompt user to inject TTS into BMAD agents (or auto-inject with --yes flag)
-  let enableTtsInjection = options.yes; // Auto-enable with --yes flag
+  // Skip injection prompt for global BMAD — modifying shared ~/.bmad files from a project install is wrong
+  let enableTtsInjection = bmadDetection.isGlobal ? false : options.yes;
 
   if (!options.yes) {
     console.log(''); // Add spacing
@@ -5047,7 +5049,7 @@ async function updateCommandFiles(targetDir, spinner) {
  * on every `npx agentvibes update` regardless of target directory.
  */
 const CRITICAL_HOOKS = ['stop-tts.sh', 'stop.sh', 'play-tts.sh', 'play-tts-piper.sh', 'audio-processor.sh', 'session-start-tts.sh', 'bmad-party-speak.sh'];
-const CRITICAL_HOOKS_WINDOWS = ['play-tts.ps1', 'play-tts-piper.ps1', 'audio-processor.ps1', 'session-start-tts.ps1', 'bmad-speak.ps1', 'bmad-party-speak.ps1'];
+const CRITICAL_HOOKS_WINDOWS = ['play-tts.ps1', 'play-tts-piper.ps1', 'audio-processor.ps1', 'session-start-tts.ps1', 'bmad-speak.ps1', 'bmad-party-speak.ps1', 'tts-watcher.ps1'];
 
 /**
  * Update critical hooks in the global ~/.claude/hooks/ directory if it exists.
@@ -5094,6 +5096,59 @@ async function updateGlobalHooks(srcHooksDir, homeDirOverride) {
   return updated;
 }
 
+/**
+ * Restart the AgentVibes TTS queue watcher on Windows after an update.
+ * Only runs if the watcher is already installed (~/.agentvibes/tts-watcher.ps1 exists),
+ * meaning the user previously ran setup-ssh-receiver.ps1.  Silently skips for users
+ * who don't use the SSH remote receiver.
+ * @param {string} [homeDirOverride] - Override home dir (for testing only)
+ * @returns {Promise<boolean>} true if watcher was restarted, false if skipped
+ */
+async function restartWatcherIfInstalled(homeDirOverride) {
+  if (!isNativeWindows()) return false;
+
+  const homeDir = homeDirOverride || os.homedir();
+  const watcherDest = path.join(homeDir, '.agentvibes', 'tts-watcher.ps1');
+  const vbsLauncher = path.join(homeDir, '.agentvibes', 'start-watcher.vbs');
+
+  // Only act if the user has the SSH receiver set up
+  try {
+    await fs.access(watcherDest);
+  } catch {
+    return false;
+  }
+
+  const { spawnSync, spawn } = require('child_process');
+
+  // Kill old watcher — use array args to avoid quoting issues
+  spawnSync('powershell.exe', [
+    '-NoProfile', '-Command',
+    'Get-CimInstance Win32_Process | Where-Object { $_.CommandLine -like \'*tts-watcher.ps1*\' } | ForEach-Object { Stop-Process -Id $_.ProcessId -Force -ErrorAction SilentlyContinue }'
+  ], { stdio: 'ignore', timeout: 8000 });
+
+  // Copy updated watcher from global hooks to the deployed location
+  const watcherSrc = path.join(homeDir, '.claude', 'hooks-windows', 'tts-watcher.ps1');
+  try {
+    await fs.copyFile(watcherSrc, watcherDest);
+  } catch {
+    // src may not exist on a fresh install path — skip copy, the file was already
+    // put there by updateGlobalHooks() earlier in the same run
+  }
+
+  // Restart via VBS launcher (hidden, no console flash) or fall back to direct spawn
+  try {
+    await fs.access(vbsLauncher);
+    spawnSync('wscript.exe', [vbsLauncher], { stdio: 'ignore' });
+  } catch {
+    const ps = spawn('powershell.exe', [
+      '-NoProfile', '-ExecutionPolicy', 'Bypass', '-WindowStyle', 'Hidden', '-File', watcherDest
+    ], { detached: true, stdio: 'ignore' });
+    ps.unref();
+  }
+
+  return true;
+}
+
 /**
  * Perform all update operations
  * @param {string} targetDir - Target installation directory
@@ -5120,6 +5175,14 @@ async function performUpdateOperations(targetDir, spinner) {
     console.log(chalk.green(`✓ Updated ${globalHooksUpdated} critical scripts in ~/.claude/hooks/`));
   }
 
+  // On Windows: restart the TTS queue watcher if it was previously installed via
+  // setup-ssh-receiver.ps1.  This propagates hook updates without requiring the
+  // user to manually run update-watcher.ps1 after every `npx agentvibes update`.
+  const watcherRestarted = await restartWatcherIfInstalled();
+  if (watcherRestarted) {
+    console.log(chalk.green('✓ TTS watcher restarted with updated scripts'));
+  }
+
   // Update personalities
   spinner.text = 'Updating personality templates...';
   const srcPersonalitiesDir = path.join(__dirname, '..', '.claude', 'personalities');

package/src/services/agent-voice-store.js

@@ -109,9 +109,17 @@ export function isSingleVoiceProvider(provider) {
  */
 export function parseBmadManifest(projectRoot) {
   const safeRoot = path.resolve(projectRoot ?? process.cwd());
-  const manifestPath = path.resolve(safeRoot, '_bmad', '_config', 'agent-manifest.csv');
-
-  if (!fs.existsSync(manifestPath)) return [];
+  // Check project-local first, then home dir (global BMAD install)
+  const roots = [safeRoot];
+  const homeDir = os.homedir();
+  if (safeRoot !== homeDir) roots.push(homeDir);
+
+  let manifestPath = null;
+  for (const root of roots) {
+    const candidate = path.resolve(root, '_bmad', '_config', 'agent-manifest.csv');
+    if (fs.existsSync(candidate)) { manifestPath = candidate; break; }
+  }
+  if (!manifestPath) return [];
 
   try {
     const raw = fs.readFileSync(manifestPath, 'utf8');
@@ -196,11 +204,32 @@ export function scanBmadAgents(projectRoot) {
   const fromManifest = parseBmadManifest(projectRoot);
   if (fromManifest.length > 0) return fromManifest;
 
-  // Fallback: directory scan
+  // Fallback: directory scan — check project-local then home dir
   const safeRoot = path.resolve(projectRoot ?? process.cwd());
+  const homeDir2 = os.homedir();
+
+  // v6.6+: agents under .claude/skills/*/agents/ — collect all such dirs
+  const skillsAgentDirs = [];
+  for (const root of (safeRoot !== homeDir2 ? [safeRoot, homeDir2] : [safeRoot])) {
+    const skillsDir = path.resolve(root, '.claude', 'skills');
+    if (fs.existsSync(skillsDir)) {
+      try {
+        for (const skill of fs.readdirSync(skillsDir)) {
+          const agentsDir = path.resolve(skillsDir, skill, 'agents');
+          if (fs.existsSync(agentsDir)) skillsAgentDirs.push(agentsDir);
+        }
+      } catch { /* skip */ }
+    }
+  }
+
   const candidateDirs = [
     path.resolve(safeRoot, '_bmad', 'bmm', 'agents'),
     path.resolve(safeRoot, '.bmad', 'agents'),
+    ...(safeRoot !== homeDir2 ? [
+      path.resolve(homeDir2, '_bmad', 'bmm', 'agents'),
+      path.resolve(homeDir2, '.bmad', 'agents'),
+    ] : []),
+    ...skillsAgentDirs,
   ];
 
   for (const dir of candidateDirs) {
@@ -232,15 +261,33 @@ export function scanBmadAgents(projectRoot) {
  */
 export function isBmadDetected(projectRoot) {
   const safeRoot = path.resolve(projectRoot ?? process.cwd());
-  const manifestPath = path.resolve(safeRoot, '_bmad', '_config', 'agent-manifest.csv');
-  if (fs.existsSync(manifestPath)) return true;
+  const homeDir = os.homedir();
 
-  // Fallback checks
-  const dirs = [
-    path.resolve(safeRoot, '_bmad', 'bmm', 'agents'),
-    path.resolve(safeRoot, '.bmad', 'agents'),
-  ];
-  return dirs.some(d => fs.existsSync(d));
+  // Check project-local first, then home-dir (BMAD can be installed globally at ~/_bmad)
+  const roots = safeRoot !== homeDir ? [safeRoot, homeDir] : [safeRoot];
+
+  for (const root of roots) {
+    // v6.x: agent-manifest.csv; v6.6+: manifest.yaml only (no agent-manifest.csv)
+    if (fs.existsSync(path.resolve(root, '_bmad', '_config', 'agent-manifest.csv'))) return true;
+    if (fs.existsSync(path.resolve(root, '_bmad', '_config', 'manifest.yaml'))) return true;
+
+    const dirs = [
+      path.resolve(root, '_bmad', 'bmm', 'agents'),
+      path.resolve(root, '.bmad', 'agents'),
+    ];
+    if (dirs.some(d => fs.existsSync(d))) return true;
+
+    // v6.6+: agents live under .claude/skills/*/agents/
+    const skillsDir = path.resolve(root, '.claude', 'skills');
+    if (fs.existsSync(skillsDir)) {
+      try {
+        const skills = fs.readdirSync(skillsDir);
+        if (skills.some(s => fs.existsSync(path.resolve(skillsDir, s, 'agents')))) return true;
+      } catch { /* skip */ }
+    }
+  }
+
+  return false;
 }
 
 // ---------------------------------------------------------------------------