agentvibes 5.15.1 → 5.15.2

package/README.md

@@ -58,7 +58,13 @@ New here? The [**Quick Start guide**](docs/quick-start.md) walks you through you
 
 ---
 
-## 🆕 Know where your preview plays (v5.15.1)
+## 🆕 Fixes for the preview indicators (v5.15.2)
+
+- **Fixed a TUI crash** — filtering/favoriting a track while a preview was playing could rebuild the list under the indicator and crash; it can't now.
+- **Honest per-agent badge** — the voice picker shows **(remotely via SSH)** vs **(locally)** from your real routing, not a partial guess.
+- **BMAD agents show their real names** (Mary, Winston…) even when a skill file lacks the `Name — Title` heading; plus small preview/onboarding polish.
+
+### v5.15.1 — Know where your preview plays
 
 - **Every preview shows where it plays** — voice and music previews now display **(locally)** or **(remotely via SSH)** right on the row you're auditioning, so you're never guessing (or hearing silence on a headless box).
 - **Preview standardized across the app** — the voice pickers (Kokoro, Piper, ElevenLabs, per-agent BMAD) and the Music page all show the same indicator; music previews now follow a project's remote receiver too.
@@ -272,7 +278,7 @@ anything (no new network calls, no behavior change) for every current install.
 
 ## About
 
-**AgentVibes** · v5.15.1 · Licensed under [Apache-2.0](LICENSE)
+**AgentVibes** · v5.15.2 · Licensed under [Apache-2.0](LICENSE)
 
 Built by **Paul Preibisch** — [@997Fire on X](https://x.com/997Fire) · [agentvibes.org](https://agentvibes.org) · [github.com/paulpreibisch/AgentVibes](https://github.com/paulpreibisch/AgentVibes)
 

package/RELEASE_NOTES.md

@@ -1,5 +1,24 @@
 # AgentVibes Release Notes
 
+## v5.15.2 — Fixes for the preview indicators
+
+**Released:** 2026-07-22 · `npm install agentvibes@latest`
+
+Follow-up fixes for the 5.15.1 preview work, from an adversarial code review:
+
+- **Fixed a crash** — filtering or favoriting a track *while a preview was
+  playing* could rebuild the list out from under the indicator and take the whole
+  TUI down. It can't anymore.
+- **The badge tells the truth** — the per-agent voice picker now shows
+  **(remotely via SSH)** vs **(locally)** based on your actual routing (provider
+  file or remote receiver), not a partial guess.
+- **Your BMAD agents show their real names** — the Agents tab reads the persona
+  name (Mary, Winston, Amelia…) even on installs whose skill files don't use the
+  `Name — Title` heading format.
+- **Smaller polish** — a remote voice-preview error no longer leaves a stuck
+  spinner, the onboarding "re-check" hint is translated in all languages, and the
+  onboarding screen keeps keyboard focus after a re-check.
+
 ## v5.15.1 — Know where your preview plays
 
 **Released:** 2026-07-21 · `npm install agentvibes@latest`

package/package.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/package.json",
   "name": "agentvibes",
-  "version": "5.15.1",
+  "version": "5.15.2",
   "description": "Now your AI Agents can finally talk back! Professional TTS voice for Claude Code, Claude Desktop (via MCP), and Clawdbot with multi-provider support.",
   "homepage": "https://agentvibes.org",
   "keywords": [

package/src/console/preview-transport.js

@@ -53,22 +53,6 @@ export function previewRowContent(frameChar, remote, stopHint = 'Space to stop')
   return `{cyan-fg}${frameChar} Previewing {/cyan-fg}${transportBadge(remote)}{cyan-fg}  (${stopHint}){/cyan-fg}`;
 }
 
-/**
- * Preview indicator APPENDED after a row's existing label (keepLabel mode).
- * Used where replacing the label would be jarring — e.g. the Music tab, whose
- * rows carry emoji: keeping the name in place avoids a perceived "jump", and
- * only the trailing spinner char changes per frame so blessed never re-diffs the
- * (wide) emoji cell.
- * @param {string} baseRow - the row's normal content (with its label/emoji)
- * @param {string} frameChar
- * @param {boolean} remote
- * @param {string} [stopHint]
- * @returns {string}
- */
-export function previewRowAppend(baseRow, frameChar, remote, stopHint = 'Space to stop') {
-  return `${baseRow}   {cyan-fg}${frameChar}{/cyan-fg} ${transportBadge(remote)}{cyan-fg}  (${stopHint}){/cyan-fg}`;
-}
-
 /**
  * Attach an animated preview indicator to the SELECTED row of a blessed list.
  * Generalizes the Kokoro picker's row spinner so every picker behaves identically.
@@ -88,16 +72,7 @@ export function createRowSpinner(list, screen, renderItem, opts = {}) {
   const now = opts.now ?? (() => Date.now());
   const intervalMs = opts.intervalMs ?? 80;
   const minVisibleMs = opts.minVisibleMs ?? 1100;
-  // fullRedraw: force a complete repaint (realloc) instead of a diff render.
-  // Needed for lists containing double-width emoji (the Music tab): blessed's
-  // diff render desyncs the terminal cursor around wide chars during rapid
-  // in-place updates, corrupting rows — even though the internal buffer is
-  // correct. A realloc rewrites the terminal from that correct buffer.
-  const fullRedraw = opts.fullRedraw ?? false;
-  // keepLabel: append the indicator after the row's existing label instead of
-  // replacing it (avoids a perceived "jump" on emoji rows — see previewRowAppend).
-  const keepLabel = opts.keepLabel ?? false;
-  // isStatic: write the indicator ONCE (no animation). Needed for lists with
+  // isStatic: write the indicator ONCE (no animation). Used for lists with
   // double-width emoji (the Music tab): repeated in-place mutation of emoji rows
   // desyncs blessed's terminal output. One write + full-width space padding is
   // the least-fragile option there. A frozen "♪" stands in for the spinner.
@@ -110,17 +85,18 @@ export function createRowSpinner(list, screen, renderItem, opts = {}) {
   let remote = false;
   let startTs = 0;
 
-  // full=true forces a complete repaint (realloc) — used ONCE on start and stop
-  // to fix the wide-char cursor desync from the emoji-row→spinner transition (and
-  // stale decorations). Per-frame renders are plain diffs: the spinner row has no
-  // wide chars, so animating it is clean AND doesn't shimmer the whole screen.
-  function _render(full) {
-    if (full && fullRedraw && typeof screen.realloc === 'function') { try { screen.realloc(); } catch { /* ignore */ } }
-    screen.render();
+  // Guard: blessed's List.setItem dereferences this.items[i] unchecked, so a
+  // stale idx (e.g. the list was rebuilt shorter by a filter while a preview was
+  // active) would throw an uncaught TypeError and kill the whole TUI. Only touch
+  // a row that still exists. list.items is an array on a real list; the test stub
+  // uses a plain object, so treat "not an array" as always-in-range.
+  function _inRange(i) {
+    if (i < 0) return false;
+    return Array.isArray(list.items) ? i < list.items.length : true;
   }
 
-  function _paint(full) {
-    if (idx < 0) return;
+  function _paint() {
+    if (!_inRange(idx)) return;
     // Pad to the widest reliable measure so the row fully overwrites the previous
     // (longer) content. list.width may still be a percentage string pre-layout, so
     // fall back to the screen width; over-padding is clipped by the non-wrapping list.
@@ -128,19 +104,16 @@ export function createRowSpinner(list, screen, renderItem, opts = {}) {
     const sw = (screen && typeof screen.width === 'number' && screen.width > 0) ? screen.width : 0;
     const w = Math.max(lw, sw, 80);
     const spin = isStatic ? '♪' : SPIN_FRAMES[frame++ % SPIN_FRAMES.length];
-    const content = keepLabel
-      ? previewRowAppend(renderItem(idx), spin, remote)
-      : previewRowContent(spin, remote);
-    list.setItem(idx, padTaggedTo(content, w));
-    _render(full);
+    list.setItem(idx, padTaggedTo(previewRowContent(spin, remote), w));
+    screen.render();
   }
 
   function stop() {
     if (floor) { clearTimeout(floor); floor = null; }
     if (timer) { clearInterval(timer); timer = null; }
-    if (idx >= 0 && !isClosed()) {
+    if (_inRange(idx) && !isClosed()) {
       list.setItem(idx, renderItem(idx));
-      _render(true);   // one full repaint to clear the wide-char desync on restore
+      screen.render();
     }
     idx = -1;
   }
@@ -152,9 +125,9 @@ export function createRowSpinner(list, screen, renderItem, opts = {}) {
       frame = 0;
       remote = !!isRemote;
       startTs = now();
-      _paint(fullRedraw);   // one repaint (realloc only if fullRedraw) fixes the transition
+      _paint();
       if (isStatic) return; // static indicator: written once, no animation loop
-      timer = setInterval(() => { if (isClosed()) { stop(); return; } _paint(false); }, intervalMs);
+      timer = setInterval(() => { if (isClosed()) { stop(); return; } _paint(); }, intervalMs);
       // A UI spinner must never keep the process alive (blessed's stdin does that
       // in the real TUI); unref so a leaked spinner can't hang node --test on exit.
       if (timer.unref) timer.unref();

package/src/console/tabs/agents-tab.js

@@ -21,6 +21,7 @@ import {
 } from './voices-tab.js';
 import { buildAudioEnv, detectWavPlayer, detectRemoteLlm } from '../audio-env.js';
 import { createRowSpinner } from '../preview-transport.js';
+import { resolveMusicProvider } from '../music-preview.js';
 import { voicesForProvider } from '../../services/provider-voice-catalog.js';
 import { destroyList } from '../widgets/destroy-list.js';
 import { BRAND_PINK } from '../brand-colors.js';
@@ -335,7 +336,11 @@ ${_tl('bmadDesc')}
 
   // Manual re-check: after installing BMAD from a separate terminal, Enter
   // re-scans without leaving the tab. (Switching tabs also re-scans via onFocus.)
-  onboardingBox.key(['enter'], () => { refreshDisplay(); });
+  // If BMAD now shows up, move focus to the roster (else keys go to the hidden box).
+  onboardingBox.key(['enter'], () => {
+    refreshDisplay();
+    if (_bmadDetected) { agentList.focus(); screen.render(); }
+  });
 
   // -------------------------------------------------------------------------
   // BMAD state — section header
@@ -1135,13 +1140,18 @@ ${_tl('bmadDesc')}
 
       const phrase = previewPhrase(voiceId);
       const _isWin = process.platform === 'win32' && !process.env.WSL_DISTRO_NAME;
+      // Badge must match where play-tts actually routes: remote if the provider
+      // file is ssh-remote/agentvibes-receiver OR a transport-config entry is
+      // mode=remote. resolveMusicProvider is the shared transport resolver (both
+      // signals) — don't re-derive routing here (CLAUDE.md invariant #1).
+      const _isRemote = resolveMusicProvider(path.dirname(_pkgClaudeDir)).remote;
 
       if (_isWin) {
         // Windows: route through play-tts.ps1 (same pattern as non-Windows bash route)
         const playTtsScript = _hookScript('hooks-windows', 'play-tts.ps1');
         if (!fs.existsSync(playTtsScript)) return;
         _previewVoiceId = voiceId;
-        if (!_vpClosed) { _vpSpin.start(vpList.selected, false); }
+        if (!_vpClosed) { _vpSpin.start(vpList.selected, _isRemote); }
         _previewProc = spawn('powershell', [ // NOSONAR
           '-NoProfile', '-ExecutionPolicy', 'Bypass', '-File', playTtsScript, phrase, voiceId,
         ], { stdio: 'ignore', detached: false, windowsHide: true,
@@ -1176,7 +1186,7 @@ ${_tl('bmadDesc')}
         cwd: _projectRoot,
       });
       _previewVoiceId = voiceId;
-      if (!_vpClosed) { _vpSpin.start(vpList.selected, !!remoteLlm); }
+      if (!_vpClosed) { _vpSpin.start(vpList.selected, _isRemote); }
 
       const _clearAfterMinDisplay = () => {
         if (_previewVoiceId === voiceId) {

package/src/console/tabs/music-tab.js

@@ -765,8 +765,26 @@ export function createMusicTab(screen, services) {
     });
   }
 
+  // Stop any in-flight preview (local player, remote receiver, and the row
+  // spinner). Used before a list rebuild so a stale spinner index can't crash
+  // blessed's setItem, and so a preview can't be left "playing" invisibly.
+  function _stopAnyPreview() {
+    if (_remotePlayingTrackId) {
+      const mp = resolveMusicProvider(_PKG_ROOT);
+      if (mp.remote) _sendMusicRemote(mp, { stop: true });
+      _remotePlayingTrackId = null;
+    }
+    _killPlayingProcess();
+    _playingTrackId = null;
+    _trackSpin.stop();
+  }
+
   function refreshDisplay() {
     _refreshing = true;
+    // A rebuild (setItems) invalidates the spinner's row index and wipes its
+    // indicator — stop any active preview first (guarded, so a normal refresh with
+    // no preview is a no-op). Prevents a stale-index crash and a stuck preview.
+    if (_trackSpin.isActive()) _stopAnyPreview();
     const savedIdx = trackList.selected ?? 0;
 
     _allTracks = _buildAllTracks();

package/src/console/tabs/setup-tab.js

@@ -4261,7 +4261,7 @@ export function createSetupTab(screen, services) {
             _vpSpin.stopWithFloor();
           }
         });
-        rProc.on('error', () => { _previewProc = null; _previewVoiceId = null; });
+        rProc.on('error', () => { _previewProc = null; _previewVoiceId = null; _vpSpin.stop(); });
         return;
       }
 

package/src/i18n/de.js

@@ -198,6 +198,6 @@ export default {
   helpSearchLabel: "Suche:",
   readmeScrollMore: "↓ Scrollen für mehr Inhalt ↓",
   readmeNotFound: "*(Keine README.md im aktuellen Verzeichnis gefunden)*",
-  bmadFooterNobmad: "[Tab] Tab wechseln  [Q] Beenden",
+  bmadFooterNobmad: "[Enter] Erneut prüfen  [Tab] Tab wechseln  [Q] Beenden",
   bmadFooterBmad: "[↑↓/jk] Navigieren  [Space] Vorschau  [Enter] Konfigurieren  [A] Auto-zuweisen  [B] Stapel  [Del] Zurücksetzen  [Q] Beenden",
 };

package/src/i18n/en.js

@@ -200,4 +200,4 @@ export default {
   readmeNotFound: "*(No README.md found in current directory)*",
   bmadFooterNobmad: "[Enter] Re-check  [Tab] Switch Tab  [Q] Quit",
   bmadFooterBmad: "[↑↓/jk] Navigate  [Space] Preview  [Enter] Configure  [A] Auto-assign  [B] Bulk  [Del] Reset  [Q] Quit",
-};
+};

package/src/i18n/es.js

@@ -198,6 +198,6 @@ export default {
   helpSearchLabel: "Buscar:",
   readmeScrollMore: "↓ Desplázate para ver más ↓",
   readmeNotFound: "*(No se encontró README.md en el directorio actual)*",
-  bmadFooterNobmad: "[Tab] Cambiar Pestaña  [Q] Salir",
+  bmadFooterNobmad: "[Enter] Volver a comprobar  [Tab] Cambiar Pestaña  [Q] Salir",
   bmadFooterBmad: "[↑↓/jk] Navegar  [Space] Previsualizar  [Enter] Configurar  [A] Auto-asignar  [B] Masivo  [Del] Restablecer  [Q] Salir",
 };

package/src/i18n/fr.js

@@ -198,6 +198,6 @@ export default {
   helpSearchLabel: "Recherche:",
   readmeScrollMore: "↓ Défiler pour plus de contenu ↓",
   readmeNotFound: "*(Aucun README.md trouvé dans le répertoire actuel)*",
-  bmadFooterNobmad: "[Tab] Changer d'onglet  [Q] Quitter",
+  bmadFooterNobmad: "[Enter] Revérifier  [Tab] Changer d'onglet  [Q] Quitter",
   bmadFooterBmad: "[↑↓/jk] Naviguer  [Space] Aperçu  [Enter] Configurer  [A] Auto-assigner  [B] Lot  [Del] Réinitialiser  [Q] Quitter",
 };

package/src/i18n/hi.js

@@ -198,6 +198,6 @@ export default {
   helpSearchLabel: "खोजें:",
   readmeScrollMore: "↓ अधिक सामग्री के लिए स्क्रॉल करें ↓",
   readmeNotFound: "*(वर्तमान निर्देशिका में README.md नहीं मिला)*",
-  bmadFooterNobmad: "[Tab] टैब बदलें  [Q] बाहर",
+  bmadFooterNobmad: "[Enter] फिर से जाँचें  [Tab] टैब बदलें  [Q] बाहर",
   bmadFooterBmad: "[↑↓/jk] नेविगेट  [Space] प्रीव्यू  [Enter] कॉन्फ़िगर  [A] ऑटो-असाइन  [B] बल्क  [Del] रीसेट  [Q] बाहर",
 };

package/src/i18n/ja.js

@@ -198,6 +198,6 @@ export default {
   helpSearchLabel: "検索：",
   readmeScrollMore: "↓ スクロールして続きを見る ↓",
   readmeNotFound: "*(現在のディレクトリにREADME.mdが見つかりません)*",
-  bmadFooterNobmad: "[Tab] タブ切替  [Q] 終了",
+  bmadFooterNobmad: "[Enter] 再確認  [Tab] タブ切替  [Q] 終了",
   bmadFooterBmad: "[↑↓/jk] 移動  [Space] プレビュー  [Enter] 設定  [A] 自動割当  [B] 一括  [Del] リセット  [Q] 終了",
 };

package/src/i18n/ko.js

@@ -198,6 +198,6 @@ export default {
   helpSearchLabel: "검색:",
   readmeScrollMore: "↓ 아래로 스크롤하여 더 보기 ↓",
   readmeNotFound: "*(현재 디렉토리에서 README.md를 찾을 수 없습니다)*",
-  bmadFooterNobmad: "[Tab] 탭 전환  [Q] 나가기",
+  bmadFooterNobmad: "[Enter] 다시 확인  [Tab] 탭 전환  [Q] 나가기",
   bmadFooterBmad: "[↑↓/jk] 탐색  [Space] 미리보기  [Enter] 설정  [A] 자동배정  [B] 일괄  [Del] 초기화  [Q] 나가기",
 };

package/src/i18n/pt.js

@@ -198,6 +198,6 @@ export default {
   helpSearchLabel: "Buscar:",
   readmeScrollMore: "↓ Role para mais conteúdo ↓",
   readmeNotFound: "*(Nenhum README.md encontrado no diretório atual)*",
-  bmadFooterNobmad: "[Tab] Mudar Aba  [Q] Sair",
+  bmadFooterNobmad: "[Enter] Verificar novamente  [Tab] Mudar Aba  [Q] Sair",
   bmadFooterBmad: "[↑↓/jk] Navegar  [Space] Visualizar  [Enter] Configurar  [A] Auto-atribuir  [B] Lote  [Del] Redefinir  [Q] Sair",
 };

package/src/i18n/zh-CN.js

@@ -198,6 +198,6 @@ export default {
   helpSearchLabel: "搜索：",
   readmeScrollMore: "↓ 向下滚动查看更多 ↓",
   readmeNotFound: "*(当前目录中未找到README.md)*",
-  bmadFooterNobmad: "[Tab] 切换标签  [Q] 退出",
+  bmadFooterNobmad: "[Enter] 重新检查  [Tab] 切换标签  [Q] 退出",
   bmadFooterBmad: "[↑↓/jk] 导航  [Space] 预览  [Enter] 配置  [A] 自动分配  [B] 批量  [Del] 重置  [Q] 退出",
 };

package/src/services/agent-voice-store.js

@@ -228,18 +228,31 @@ function _findBmadAgentSkills(root) {
  * heading ("# Mary — Business Analyst") for the persona name + title. Falls back
  * to a title-cased id when the heading is missing/unreadable.
  */
+// Generic section words that a bare "# Word" heading might be (not a persona).
+const _GENERIC_HEADING = /^(overview|about|usage|conventions|activation|role|purpose|description|instructions)$/i;
+
 function _agentFromSkill(id, skillDir) {
   let displayName = _titleCaseId(id);
   let title = '';
   try {
     const md = fs.readFileSync(path.resolve(skillDir, 'SKILL.md'), 'utf8');
-    // Persona heading format: "# Mary — Business Analyst" (name <dash> title).
-    // Require the spaced dash so a generic section heading like "# Overview" is
-    // skipped and we fall back to the title-cased id instead of mislabeling.
-    const m = md.match(/^#\s+([^\n]+?)\s+[—–-]\s+([^\n]+?)\s*$/m); // em / en / hyphen
-    if (m) {
-      displayName = m[1].trim() || displayName;
-      title = m[2].trim();
+    // 1) Preferred: "# Mary — Business Analyst" (name <dash> title).
+    const dash = md.match(/^#\s+([^\n]+?)\s+[—–-]\s+([^\n]+?)\s*$/m); // em / en / hyphen
+    if (dash) {
+      displayName = dash[1].trim() || displayName;
+      title = dash[2].trim();
+    } else {
+      // 2) Frontmatter description often names the persona: "...talk to Mary...".
+      const desc = md.match(/^description:\s*(.+)$/mi);
+      const talk = desc && desc[1].match(/talk to ([A-Z][\w'’-]+)/);
+      if (talk) {
+        displayName = talk[1];
+      } else {
+        // 3) A bare "# Mary" heading — but skip generic section headings so a
+        // skill without a persona heading (e.g. "# Overview") falls back to the id.
+        const h1 = md.match(/^#\s+([A-Z][\w'’-]*)\s*$/m);
+        if (h1 && !_GENERIC_HEADING.test(h1[1])) displayName = h1[1];
+      }
     }
   } catch { /* use derived displayName */ }
   return { id, displayName, title, icon: '', module: 'bmm' };