agentvibes 5.13.1 → 5.15.0

package/src/installer.js

@@ -2874,7 +2874,7 @@ async function collectConfiguration(options = {}) {
     // Navigation with page titles
     const navChoices = [];
     if (currentPage < totalPages - 1) {
-      const nextPageTitle = getPageTitle(currentPage + 1).replace(/[🔧🎙️🎤😎💧🔊]\s*/, ''); // Remove emoji
+      const nextPageTitle = getPageTitle(currentPage + 1).replace(/(?:🔧|🎙️|🎤|😎|💧|🔊)\s*/u, ''); // Remove emoji (alternation: 🎙️ is a combined char)
       navChoices.push({ name: chalk.green('Next →') + chalk.gray(` (${nextPageTitle})`), value: 'next' });
     } else {
       navChoices.push({ name: chalk.cyan('✓ Continue to Installation'), value: 'continue' });
@@ -2884,7 +2884,7 @@ async function collectConfiguration(options = {}) {
     if (currentPage === 0) {
       navChoices.push({ name: chalk.magentaBright('← Back to Welcome'), value: 'back' });
     } else {
-      const prevPageTitle = getPageTitle(currentPage - 1).replace(/[🔧🎙️🎤😎💧🔊]\s*/, ''); // Remove emoji
+      const prevPageTitle = getPageTitle(currentPage - 1).replace(/(?:🔧|🎙️|🎤|😎|💧|🔊)\s*/u, ''); // Remove emoji (alternation: 🎙️ is a combined char)
       navChoices.push({ name: chalk.magentaBright('← Previous') + chalk.gray(` (${prevPageTitle})`), value: 'prev' });
     }
 
@@ -3192,16 +3192,40 @@ function execScript(scriptPath, options = {}) {
   const scriptFile = parts[0];
   const args = parts.slice(1);
 
-  // Validate that the script file doesn't contain shell metacharacters
-  if (scriptFile.match(/[;&|`$(){}[\]<>'"\\]/)) {
+  // Validate that the script file doesn't contain shell metacharacters.
+  // NOTE: `\` and `:` are deliberately NOT in this class — the script is run via
+  // execFileSync(..., { shell: false }) at the bottom of this function, so the
+  // path never reaches a shell and backslashes are not a metacharacter. Rejecting
+  // `\` made EVERY Windows path ("C:\Users\...") throw before the directory check
+  // was even reached. The real control is the allow-list below.
+  if (scriptFile.match(/[;&|`$(){}[\]<>'"]/)) {
     throw new Error('Invalid characters in script path');
   }
 
-  // Validate path is within expected directory (defense in depth)
+  // Validate the path is under a directory we're willing to execute from.
+  //
+  // This used to allow ONLY the *package's own* .claude/hooks. But every install
+  // caller passes a path under the TARGET project (targetDir/.claude/hooks/...),
+  // and under npx/global installs the package dir is never the target dir — so
+  // the check threw for every real user. The throw was swallowed by each caller's
+  // catch and surfaced as "Piper installation failed or was cancelled" / "Voice
+  // download failed", blaming the script for something we never ran. It only
+  // worked in a linked dev checkout, where package === target. Callers now pass
+  // the base they legitimately execute from.
+  const pkgRoot = path.resolve(__dirname, '..');
+  const allowedDirs = [
+    path.join(pkgRoot, '.claude', 'hooks'),
+    path.join(pkgRoot, 'bin'),
+    ...(options.allowedDirs || []).map((d) => path.resolve(d)),
+  ];
   const resolvedPath = path.resolve(scriptFile);
-  const allowedDir = path.resolve(__dirname, '..', '.claude', 'hooks');
-  if (!resolvedPath.startsWith(allowedDir + path.sep) && resolvedPath !== allowedDir) {
-    throw new Error('Script path outside allowed directory');
+  const permitted = allowedDirs.some(
+    (dir) => resolvedPath === dir || resolvedPath.startsWith(dir + path.sep)
+  );
+  if (!permitted) {
+    throw new Error(
+      `Script path outside allowed directories: ${resolvedPath}\n  allowed: ${allowedDirs.join(', ')}`
+    );
   }
 
   // Security: Validate shell and shellConfig don't contain dangerous characters
@@ -3233,8 +3257,10 @@ function execScript(scriptPath, options = {}) {
   // Note: This means shell aliases/functions won't be available, but that's safer
   // S8701: scriptFile is validated to live under .claude/hooks (above), args are
   // passed as an array and shell:false disables shell interpretation. Risk handled.
+  // allowedDirs is ours, not execFileSync's — strip it before handing options on.
+  const { allowedDirs: _ignored, ...execOptions } = options;
   return execFileSync(scriptFile, args, { // NOSONAR
-    ...options,
+    ...execOptions,
     shell: false  // Don't use shell to avoid injection risks
   });
 }
@@ -4172,33 +4198,41 @@ async function copyCodexFiles(targetDir, spinner) {
   const srcCodexDir = path.join(__dirname, '..', '.codex');
   const destCodexDir = path.join(targetDir, '.codex');
 
+  const codexManifestPath = getProjectManifestPath(targetDir);
+  const codexManifest = await loadManifest(codexManifestPath);
+  const codexManifestUpdates = { ...codexManifest };
+
   let copiedFiles = [];
   try {
     await fs.mkdir(destCodexDir, { recursive: true });
     await fs.mkdir(path.join(destCodexDir, 'hooks'), { recursive: true });
 
-    // Copy AGENTS.md
-    const agentsSrc = path.join(srcCodexDir, 'AGENTS.md');
-    try {
-      const content = await fs.readFile(agentsSrc, 'utf8');
-      await fs.writeFile(path.join(destCodexDir, 'AGENTS.md'), content);
-      copiedFiles.push('.codex/AGENTS.md');
-    } catch { /* source not found */ }
-
-    // Copy hook scripts
-    for (const hookFile of ['init-agentvibes.sh', 'init-agentvibes.ps1']) {
-      const hookSrc = path.join(srcCodexDir, 'hooks', hookFile);
+    // Non-Destructive Configuration Rule: a user-edited AGENTS.md or Codex hook
+    // must survive re-install/update. manifestSafeCopy skips (and .user.bak's) a
+    // file the user changed instead of rewriting it from the template every run.
+    const codexTargets = [
+      { src: path.join(srcCodexDir, 'AGENTS.md'), dest: path.join(destCodexDir, 'AGENTS.md'), label: '.codex/AGENTS.md', exec: false },
+      { src: path.join(srcCodexDir, 'hooks', 'init-agentvibes.sh'), dest: path.join(destCodexDir, 'hooks', 'init-agentvibes.sh'), label: '.codex/hooks/init-agentvibes.sh', exec: true },
+      { src: path.join(srcCodexDir, 'hooks', 'init-agentvibes.ps1'), dest: path.join(destCodexDir, 'hooks', 'init-agentvibes.ps1'), label: '.codex/hooks/init-agentvibes.ps1', exec: false },
+    ];
+
+    for (const { src, dest, label, exec } of codexTargets) {
       try {
-        const content = await fs.readFile(hookSrc, 'utf8');
-        const destPath = path.join(destCodexDir, 'hooks', hookFile);
-        await fs.writeFile(destPath, content);
-        if (hookFile.endsWith('.sh')) {
-          try { await fs.chmod(destPath, 0o750); } catch { /* Windows */ }
+        const result = await manifestSafeCopy(src, dest, codexManifest);
+        // src missing → nothing copied and nothing at dest; only such a skip has no hash.
+        if (result.action === 'skipped' && !result.hash) continue;
+        if (exec && result.action !== 'unchanged') {
+          try { await fs.chmod(dest, 0o750); } catch { /* Windows */ }
+        }
+        if (result.hash && result.action !== 'skipped') {
+          codexManifestUpdates[dest] = { hash: result.hash, installedAt: new Date().toISOString() };
         }
-        copiedFiles.push(`.codex/hooks/${hookFile}`);
+        copiedFiles.push(label);
       } catch { /* source not found */ }
     }
 
+    await saveManifest(codexManifestPath, codexManifestUpdates).catch(() => { /* best effort */ });
+
     if (copiedFiles.length > 0) {
       spinner.succeed(chalk.green(`Installed ${copiedFiles.length} Codex file${copiedFiles.length === 1 ? '' : 's'}!\n`));
       copiedFiles.forEach(file => {
@@ -4341,11 +4375,23 @@ async function configurePartyModeHook(targetDir, spinner, homeDirOverride) {
     const srcScript = path.join(__dirname, '..', '.claude', hooksSubdir, scriptName);
     const destScript = path.join(globalHooksDir, scriptName);
 
-    // Copy script to global hooks dir (create dir if needed)
+    // Copy script to global hooks dir (create dir if needed). Non-Destructive
+    // Configuration Rule: a user-modified bmad-party-speak script must survive an
+    // update, so go through manifestSafeCopy (which .user.bak's and skips a file
+    // the user changed) instead of an unconditional overwrite. The sibling
+    // updateGlobalHooks path for this same file is already manifest-guarded.
     await fs.mkdir(globalHooksDir, { recursive: true });
-    await fs.copyFile(srcScript, destScript);
-    if (!isNativeWindows()) {
-      await fs.chmod(destScript, 0o750);
+    const scriptManifestPath = getGlobalManifestPath(homeDir);
+    const scriptManifest = await loadManifest(scriptManifestPath);
+    const scriptCopy = await manifestSafeCopy(srcScript, destScript, scriptManifest);
+    if (scriptCopy.action !== 'skipped') {
+      if (!isNativeWindows() && scriptCopy.action !== 'unchanged') {
+        await fs.chmod(destScript, 0o750);
+      }
+      if (scriptCopy.hash) {
+        scriptManifest[destScript] = { hash: scriptCopy.hash, installedAt: new Date().toISOString() };
+        await saveManifest(scriptManifestPath, scriptManifest).catch(() => { /* best effort */ });
+      }
     }
 
     // Build the PostToolUse hook command
@@ -4480,7 +4526,8 @@ async function offerLibriTTSDownload(piperDownloadPath, options) {
   try {
     execScript(`${piperDownloadPath} --libritts --yes`, {
       stdio: 'inherit',
-      env: process.env
+      env: process.env,
+      allowedDirs: [path.dirname(piperDownloadPath)]
     });
     console.log(chalk.green('\n✅ LibriTTS voices downloaded! Browse with /agent-vibes:list\n'));
   } catch {
@@ -4531,7 +4578,8 @@ async function checkAndInstallPiper(targetDir, options) {
         if (fsSync.existsSync(piperDownloadPath)) {
           execScript(`${piperDownloadPath} --yes`, {
             stdio: options.silent ? 'pipe' : 'inherit',
-            env: process.env
+            env: process.env,
+            allowedDirs: [path.dirname(piperDownloadPath)]
           });
           console.log(chalk.green('\n✅ Voice models downloaded successfully!\n'));
         } else {
@@ -4576,7 +4624,8 @@ async function checkAndInstallPiper(targetDir, options) {
         try {
           execScript(`${piperInstallerPath} --non-interactive`, {
             stdio: options.silent ? 'pipe' : 'inherit',
-            env: process.env
+            env: process.env,
+            allowedDirs: [path.dirname(piperInstallerPath)]
           });
           console.log(chalk.green('\n✅ Piper TTS installed successfully!\n'));
         } catch (error) {
@@ -5393,8 +5442,13 @@ async function updateCommandFiles(targetDir, spinner) {
  * These hooks contain bug fixes (e.g. markdown stripping) that must propagate
  * on every `npx agentvibes update` regardless of target directory.
  */
-const CRITICAL_HOOKS = ['stop-tts.sh', 'stop.sh', 'play-tts.sh', 'play-tts-piper.sh', 'audio-processor.sh', 'session-start-tts.sh', 'bmad-party-speak.sh'];
-const CRITICAL_HOOKS_WINDOWS = ['play-tts.ps1', 'play-tts-piper.ps1', 'audio-processor.ps1', 'session-start-tts.ps1', 'bmad-speak.ps1', 'bmad-party-speak.ps1', 'tts-watcher.ps1'];
+// agentvibes-session-id.{sh,ps1} are listed because play-tts.{sh,ps1} SHELL OUT to
+// them to expand a {{session}} pretext. They were absent here, so on a global
+// install the global-update path never shipped them and the self-ID silently
+// degraded to an empty string forever — the callers fail soft by design, so the
+// omission produced no error, just a feature that never worked.
+const CRITICAL_HOOKS = ['stop-tts.sh', 'stop.sh', 'play-tts.sh', 'play-tts-piper.sh', 'audio-processor.sh', 'session-start-tts.sh', 'bmad-party-speak.sh', 'agentvibes-session-id.sh'];
+const CRITICAL_HOOKS_WINDOWS = ['play-tts.ps1', 'play-tts-piper.ps1', 'audio-processor.ps1', 'session-start-tts.ps1', 'bmad-speak.ps1', 'bmad-party-speak.ps1', 'tts-watcher.ps1', 'agentvibes-session-id.ps1'];
 
 /**
  * Update critical hooks in the global ~/.claude/hooks/ directory if it exists.
@@ -6785,8 +6839,11 @@ program
   .command('agentvibes-mcp-server')
   .description('Start AgentVibes MCP server')
   .action(async () => {
-    // Run the bash wrapper script
-    const mcpServerScript = path.join(__dirname, '..', 'bin', 'mcp-server');
+    // Run the bash wrapper script. NOTE: 'bin/mcp-server' (no extension) has
+    // never existed — bin/ ships mcp-server.sh and mcp-server.js. Combined with
+    // the catch below exiting silently, this subcommand failed with no output at
+    // all for every user who tried it.
+    const mcpServerScript = path.join(__dirname, '..', 'bin', 'mcp-server.sh');
 
     try {
       execScript(mcpServerScript, {
@@ -6794,6 +6851,9 @@ program
         env: process.env
       });
     } catch (error) {
+      // Never exit silently — say why.
+      console.error(chalk.red(`\n❌ Could not start the MCP server: ${error.message}`));
+      console.error(chalk.gray(`   Script: ${mcpServerScript}`));
       process.exit(error.status || 1);
     }
   });
@@ -7116,6 +7176,7 @@ export {
   // Manifest utilities (used by tests and external tooling)
   getProjectManifestPath, getGlobalManifestPath,
   loadManifest, saveManifest, computeFileHash, manifestSafeCopy, backupUserFile, removeManifestFiles,
+  execScript,
   // Pure helper functions exported for testing
   readJsonConfigSafe, backupConfigFile,
   isPiperProvider, supportsEmoji, getPersonalityIcon,

package/src/services/language-service.js

@@ -1,47 +1,47 @@
-/**
- * LanguageService — single source of truth for the selected UI language.
- *
- * Persists the selection to ~/.claude/config/language.txt so it survives
- * process restarts.  Notifies registered listeners on every change so the
- * TUI can re-render dynamic labels immediately.
- */
-
-import fs from 'node:fs';
-import path from 'node:path';
-import os from 'node:os';
-import { t, SUPPORTED_LANGUAGES } from '../i18n/strings.js';
-
-const LANG_FILE = path.join(os.homedir(), '.claude', 'config', 'language.txt');
-const VALID_LANGS = new Set(SUPPORTED_LANGUAGES.map(l => l.value));
-
-export class LanguageService {
-  constructor() {
-    this._lang = this._load();
-    this._listeners = [];
-  }
-
-  _load() {
-    try {
-      const val = fs.readFileSync(LANG_FILE, 'utf8').trim();
-      return VALID_LANGS.has(val) ? val : 'en';
-    } catch {
-      return 'en';
-    }
-  }
-
-  getLang() { return this._lang; }
-
-  setLang(lang) {
-    if (!VALID_LANGS.has(lang)) return;
-    this._lang = lang;
-    try {
-      fs.mkdirSync(path.dirname(LANG_FILE), { recursive: true });
-      fs.writeFileSync(LANG_FILE, lang, { mode: 0o600 });
-    } catch { /* non-fatal */ }
-    this._listeners.forEach(fn => fn(lang));
-  }
-
-  onChange(fn) { this._listeners.push(fn); }
-
-  t(key) { return t(this._lang, key); }
-}
+/**
+ * LanguageService — single source of truth for the selected UI language.
+ *
+ * Persists the selection to ~/.claude/config/language.txt so it survives
+ * process restarts.  Notifies registered listeners on every change so the
+ * TUI can re-render dynamic labels immediately.
+ */
+
+import fs from 'node:fs';
+import path from 'node:path';
+import os from 'node:os';
+import { t, SUPPORTED_LANGUAGES } from '../i18n/strings.js';
+
+const LANG_FILE = path.join(os.homedir(), '.claude', 'config', 'language.txt');
+const VALID_LANGS = new Set(SUPPORTED_LANGUAGES.map(l => l.value));
+
+export class LanguageService {
+  constructor() {
+    this._lang = this._load();
+    this._listeners = [];
+  }
+
+  _load() {
+    try {
+      const val = fs.readFileSync(LANG_FILE, 'utf8').trim();
+      return VALID_LANGS.has(val) ? val : 'en';
+    } catch {
+      return 'en';
+    }
+  }
+
+  getLang() { return this._lang; }
+
+  setLang(lang) {
+    if (!VALID_LANGS.has(lang)) return;
+    this._lang = lang;
+    try {
+      fs.mkdirSync(path.dirname(LANG_FILE), { recursive: true });
+      fs.writeFileSync(LANG_FILE, lang, { mode: 0o600 });
+    } catch { /* non-fatal */ }
+    this._listeners.forEach(fn => fn(lang));
+  }
+
+  onChange(fn) { this._listeners.push(fn); }
+
+  t(key) { return t(this._lang, key); }
+}

package/src/services/llm-provider-service.js

@@ -964,7 +964,10 @@ export function saveLlmConfigSync(llmKey, config, targetDir) {
   const cfgKey = `llm:${llmKey}`;
   // Sanitize user-editable fields: strip pipe chars (config delimiter) and newlines
   // (newlines could inject extra rows into the pipe-delimited config file)
-  const sanitize = (v) => (v || '').replace(/[\|\n\r\x00]/g, '');
+  // Strip the pipe delimiter and any control character (newlines/NUL could inject
+  // extra rows). Done via a char filter rather than control chars in a regex
+  // literal (Sonar S6324 flags regex control chars).
+  const sanitize = (v) => Array.from(String(v || '')).filter(ch => ch !== '|' && ch.charCodeAt(0) >= 0x20).join('');
   const cfgLine = `${cfgKey}|${sanitize(config.effects)}|${sanitize(config.bgTrack)}|${sanitize(config.bgVolume)}|${sanitize(config.voice)}|${sanitize(config.pretext)}|${sanitize(config.ttsEngine)}`;
   const resolvedTargetDir = targetDir || process.env.INIT_CWD || process.cwd();
   // When targetDir is explicitly passed, always write to the project dir — never follow

package/src/services/provider-voice-catalog.js

@@ -33,12 +33,16 @@ export { ELEVENLABS_VOICES, KOKORO_VOICE_IDS, kokoroGender };
  * Verified against a real Windows 11 install (System.Speech GetInstalledVoices).
  * The receiver remains authoritative — this is UI convenience, not inventory SSOT.
  */
+// Only the classic SAPI5 "Desktop" voices are listed. The modern OneCore voices
+// ("Microsoft David/Mark/Zira" WITHOUT "Desktop") are NOT selectable via
+// System.Speech in a spawned process — the receiver's player is spawned, so
+// SelectVoice throws "No matching voice is installed" and silently falls back to
+// the default (David, male). That made e.g. "Microsoft Zira" play as a MALE voice.
+// David Desktop + Zira Desktop are present on every Windows 10/11 and select
+// reliably in any process/bitness, so they are the safe curated set.
 const WINDOWS_SAPI_VOICES = [
-  { id: 'Microsoft David Desktop', name: 'David (Desktop)', gender: 'Male',   lang: 'en-US' },
-  { id: 'Microsoft Zira Desktop',  name: 'Zira (Desktop)',  gender: 'Female', lang: 'en-US' },
-  { id: 'Microsoft David',         name: 'David',           gender: 'Male',   lang: 'en-US' },
-  { id: 'Microsoft Mark',          name: 'Mark',            gender: 'Male',   lang: 'en-US' },
-  { id: 'Microsoft Zira',          name: 'Zira',            gender: 'Female', lang: 'en-US' },
+  { id: 'Microsoft David Desktop', name: 'David', gender: 'Male',   lang: 'en-US' },
+  { id: 'Microsoft Zira Desktop',  name: 'Zira',  gender: 'Female', lang: 'en-US' },
 ];
 
 const MACOS_VOICES = [