agentvibes 5.11.2 → 5.12.0-alpha.0

package/src/console/app.js

@@ -899,8 +899,19 @@ export class AgentVibesConsole {
   // Private: Global keyboard handlers
 
   _registerHandlers() {
-    // Q or Ctrl+C → clean exit (no zombie processes)
-    this.screen.key(['q', 'Q', 'C-c'], () => {
+    // Q or Ctrl+C → clean exit (no zombie processes).
+    // Guarded by isModalOpen(): blessed fires screen-level key handlers
+    // before focused-element handlers, so without this guard 'q' here would
+    // always win over a picker/modal's own Esc/q close binding — e.g. typing
+    // 'q' to jump to a voice named "Quinn" would kill the whole TUI instead
+    // of just being handled by the picker. Ctrl+C always force-quits (it's
+    // the universal "get me out" signal and has no in-modal meaning).
+    this.screen.key(['q', 'Q', 'C-c'], (ch, key) => {
+      const isCtrlC = key?.ctrl && key?.name === 'c';
+      if (!isCtrlC && this.navigationService?.isModalOpen()) {
+        // Let the focused modal/picker's own key handler deal with it.
+        return;
+      }
       this.screen.destroy();
       process.exit(0);
     });

package/src/console/brand-colors.js

@@ -1,13 +1,13 @@
-/**
- * AgentVibes TUI — Brand Color Constants
- *
- * Single source of truth for the two primary brand colors.
- * Change BRAND_PINK or BRAND_BLUE here to update every modal title,
- * button, and the "Vibes" logotype across the entire TUI.
- */
-
-/** Magenta-pink used for modal titles and the "Vibes" logotype. */
-export const BRAND_PINK = '#f06292';  // Light magenta — Pink 300
-
-/** Indigo blue used for default button backgrounds and primary accents. */
-export const BRAND_BLUE = '#3949ab';
+/**
+ * AgentVibes TUI — Brand Color Constants
+ *
+ * Single source of truth for the two primary brand colors.
+ * Change BRAND_PINK or BRAND_BLUE here to update every modal title,
+ * button, and the "Vibes" logotype across the entire TUI.
+ */
+
+/** Magenta-pink used for modal titles and the "Vibes" logotype. */
+export const BRAND_PINK = '#f06292';  // Light magenta — Pink 300
+
+/** Indigo blue used for default button backgrounds and primary accents. */
+export const BRAND_BLUE = '#3949ab';

package/src/console/constants/personalities.js

@@ -1,44 +1,44 @@
-/**
- * AgentVibes — Canonical personality constants.
- *
- * Single source of truth for personality names and their associated emoji
- * glyphs.  All TUI modules (settings-tab, agents-tab, personality-picker …)
- * import from here; src/installer.js maintains its own copy because it
- * predates the TUI and uses a different module-load path.
- *
- * Exported:
- *   PERSONALITY_EMOJIS  — Map of personality name → emoji string
- *   PERSONALITIES       — Ordered array of personality names (canonical order
- *                         used for picker lists)
- */
-
-export const PERSONALITY_EMOJIS = Object.freeze({
-  angry:        '😠',
-  annoying:     '😤',
-  crass:        '🤬',
-  dramatic:     '🎭',
-  'dry-humor':  '😐',
-  flirty:       '😘',
-  funny:        '😂',
-  grandpa:      '👴',
-  millennial:   '🙄',
-  moody:        '😒',
-  none:         '😊',
-  normal:       '😊',
-  pirate:       '⚓',
-  poetic:       '📜',
-  professional: '👔',
-  rapper:       '🎤',
-  robot:        '🤖',
-  sarcastic:    '😏',
-  sassy:        '💁',
-  'surfer-dude':'🏄',
-  zen:          '🧘',
-});
-
-export const PERSONALITIES = Object.freeze([
-  'none', 'angry', 'annoying', 'crass', 'dramatic', 'dry-humor',
-  'flirty', 'funny', 'grandpa', 'millennial', 'moody', 'normal',
-  'pirate', 'poetic', 'professional', 'rapper', 'robot', 'sarcastic',
-  'sassy', 'surfer-dude', 'zen',
-]);
+/**
+ * AgentVibes — Canonical personality constants.
+ *
+ * Single source of truth for personality names and their associated emoji
+ * glyphs.  All TUI modules (settings-tab, agents-tab, personality-picker …)
+ * import from here; src/installer.js maintains its own copy because it
+ * predates the TUI and uses a different module-load path.
+ *
+ * Exported:
+ *   PERSONALITY_EMOJIS  — Map of personality name → emoji string
+ *   PERSONALITIES       — Ordered array of personality names (canonical order
+ *                         used for picker lists)
+ */
+
+export const PERSONALITY_EMOJIS = Object.freeze({
+  angry:        '😠',
+  annoying:     '😤',
+  crass:        '🤬',
+  dramatic:     '🎭',
+  'dry-humor':  '😐',
+  flirty:       '😘',
+  funny:        '😂',
+  grandpa:      '👴',
+  millennial:   '🙄',
+  moody:        '😒',
+  none:         '😊',
+  normal:       '😊',
+  pirate:       '⚓',
+  poetic:       '📜',
+  professional: '👔',
+  rapper:       '🎤',
+  robot:        '🤖',
+  sarcastic:    '😏',
+  sassy:        '💁',
+  'surfer-dude':'🏄',
+  zen:          '🧘',
+});
+
+export const PERSONALITIES = Object.freeze([
+  'none', 'angry', 'annoying', 'crass', 'dramatic', 'dry-humor',
+  'flirty', 'funny', 'grandpa', 'millennial', 'moody', 'normal',
+  'pirate', 'poetic', 'professional', 'rapper', 'robot', 'sarcastic',
+  'sassy', 'surfer-dude', 'zen',
+]);

package/src/console/tabs/agents-tab.js

@@ -176,6 +176,33 @@ function createTestStub() {
 /**
  * Create the Agents tab component.
  */
+// Module-level so the process 'exit'/'SIGINT' handlers are registered EXACTLY
+// once per process, no matter how many times createAgentsTab() is called (the
+// test suite creates many). Registering them per-call leaked listeners
+// (MaxListenersExceededWarning) and left stale SIGINT handlers that each called
+// process.exit(). Each tab adds its patched-files map here; the single handler
+// restores every registered map.
+const _allPatchedConfigMaps = new Set();
+let _patchHandlersRegistered = false;
+function _restoreAllRegisteredPatchedConfigMaps() {
+  for (const map of _allPatchedConfigMaps) {
+    for (const filePath of [...map.keys()]) {
+      const original = map.get(filePath);
+      try {
+        if (original !== null) fs.writeFileSync(filePath, original);
+        else fs.unlinkSync(filePath);
+      } catch { /* best-effort restore */ }
+      map.delete(filePath);
+    }
+  }
+}
+function _ensurePatchExitHandlers() {
+  if (_patchHandlersRegistered) return;
+  _patchHandlersRegistered = true;
+  process.on('exit', _restoreAllRegisteredPatchedConfigMaps);
+  process.on('SIGINT', () => { _restoreAllRegisteredPatchedConfigMaps(); process.exit(130); });
+}
+
 export function createAgentsTab(screen, services) {
   if (IS_TEST) return createTestStub();
 
@@ -208,6 +235,37 @@ ${_tl('bmadDesc')}
   // Capture cwd once at construction (L1 fix)
   const _projectRoot = process.cwd();
 
+  // Story 8.3 fix: Windows agent-preview temp-patches config files (personality.txt,
+  // reverb-level.txt) to apply per-agent settings during a preview. Track every
+  // patched file + its pre-patch content here so ALL of them can be restored —
+  // not just on normal preview completion, but also on abnormal exit (Ctrl+C,
+  // crash, or quitting mid-preview). Non-Destructive Configuration Rule: a
+  // preview must never permanently mutate the user's config.
+  const _patchedConfigFiles = new Map(); // filePath -> original content (string) | null (file did not exist)
+
+  /** Record a file's pre-patch content the first time it's touched (idempotent). */
+  function _trackPatchedConfigFile(filePath, originalContent) {
+    if (!_patchedConfigFiles.has(filePath)) _patchedConfigFiles.set(filePath, originalContent);
+  }
+
+  /** Restore a single tracked file to its pre-patch state (or remove it if it didn't exist before). */
+  function _restorePatchedConfigFile(filePath) {
+    if (!_patchedConfigFiles.has(filePath)) return;
+    const original = _patchedConfigFiles.get(filePath);
+    try {
+      if (original !== null) fs.writeFileSync(filePath, original);
+      else fs.unlinkSync(filePath);
+    } catch { /* best-effort restore */ }
+    _patchedConfigFiles.delete(filePath);
+  }
+
+  // Abnormal-exit safety net: if the process dies mid-preview (Ctrl+C, crash,
+  // or the TUI quitting before the preview process's own 'exit' handler runs),
+  // still restore any temp-patched config files. Registered once per process
+  // via a module-level registry (see top of file) to avoid listener leaks.
+  _allPatchedConfigMaps.add(_patchedConfigFiles);
+  _ensurePatchExitHandlers();
+
   let _bmadDetected = false;
   let _agents = [];
   let _playingProcess = null;
@@ -1425,10 +1483,14 @@ ${_tl('bmadDesc')}
     }
 
     try {
-      if (profile.personality && profile.personality !== 'none')
+      if (profile.personality && profile.personality !== 'none') {
+        _trackPatchedConfigFile(personalityFile, origPersonality);
         fs.writeFileSync(personalityFile, profile.personality);
-      if (profile.reverbPreset)
+      }
+      if (profile.reverbPreset) {
+        _trackPatchedConfigFile(reverbFile, origReverb);
         fs.writeFileSync(reverbFile, profile.reverbPreset);
+      }
     } catch { /* degrade gracefully */ }
 
     const voiceId = profile.voice || '';
@@ -1440,16 +1502,21 @@ ${_tl('bmadDesc')}
     });
     _playingProcess = proc;
 
+    // Restore BOTH temp-patched files (personality + reverb) — transactional:
+    // whichever files were actually patched above get restored/unlinked here.
+    // Also covered by the module-level process 'exit'/SIGINT handlers if the
+    // process dies before this fires (see the module-level exit/SIGINT handler).
     function _restore() {
-      try {
-        if (origPersonality !== null) fs.writeFileSync(personalityFile, origPersonality);
-        else try { fs.unlinkSync(personalityFile); } catch {}
-        if (origReverb !== null) fs.writeFileSync(reverbFile, origReverb);
-      } catch {}
+      _restorePatchedConfigFile(personalityFile);
+      _restorePatchedConfigFile(reverbFile);
     }
 
-    proc.on('exit', () => { if (gen === _playGeneration) { _playingProcess = null; _stopSpinner(); } _restore(); if (onComplete) onComplete(); });
-    proc.on('error', () => { if (gen === _playGeneration) { _playingProcess = null; _stopSpinner(); } _restore(); if (onComplete) onComplete(); });
+    // Gate restore + onComplete behind the generation check too: a superseded
+    // preview's late exit must NOT restore config (it would clobber the newer
+    // preview's in-flight patch and fire onComplete out of order). The current
+    // generation's process — or the module-level exit/SIGINT handler — restores.
+    proc.on('exit', () => { if (gen === _playGeneration) { _playingProcess = null; _stopSpinner(); _restore(); if (onComplete) onComplete(); } });
+    proc.on('error', () => { if (gen === _playGeneration) { _playingProcess = null; _stopSpinner(); _restore(); if (onComplete) onComplete(); } });
   }
 
   // -------------------------------------------------------------------------
@@ -1627,9 +1694,15 @@ ${_tl('bmadDesc')}
     function _closeMenu(callback) {
       if (_menuClosed) return;
       _menuClosed = true;
+      navigationService?.closeModal();
       destroyList(menuList, screen, callback);
     }
 
+    // Register as an open modal so the global 'q' quit guard (app.js) blocks
+    // quit while this menu is up — otherwise 'q' falls through and exits the
+    // whole TUI instead of closing the menu.
+    navigationService?.openModal(null, () => _closeMenu(() => { agentList.focus(); screen.render(); }));
+
     menuList.key(['enter'], () => {
       const action = BULK_ACTIONS[menuList.selected];
       if (!action) return;