agentvibes 5.1.3 → 5.2.0

package/src/services/llm-provider-service.js

@@ -27,8 +27,66 @@ export const PROVIDERS = [
     name: 'OpenAI Codex',
     desc: 'OpenAI CLI agent — .codex/config.toml + AGENTS.md',
   },
+  {
+    id: 'default',
+    name: 'Default (Fallback)',
+    desc: 'Used when any tool calls TTS without identifying its LLM',
+    // No install/uninstall — this is a config-only entry
+    isDefault: true,
+  },
 ];
 
+const DEFAULT_LLM_CONFIGS = {
+  // Fallback used when play-tts is invoked with no -llm flag.  Pretext is
+  // empty by default — users edit it via Setup → Default → Configure.  When
+  // empty, no prefix is prepended at all.
+  default: {
+    effects: 'light',
+    bgTrack: '',
+    bgVolume: '0.15',
+    voice: 'en_US-lessac-high',
+    pretext: '',
+    ttsEngine: 'piper',
+  },
+  'claude-code': {
+    effects: 'light',
+    bgTrack: 'agent_vibes_chillwave_v2_loop.mp3',
+    bgVolume: '0.15',
+    voice: 'en_US-lessac-high',
+    pretext: 'Claude Code here',
+    ttsEngine: 'piper',
+  },
+  copilot: {
+    effects: 'light',
+    bgTrack: 'agent_vibes_bossa_nova_v2_loop.mp3',
+    bgVolume: '0.15',
+    voice: 'en_US-libritts-high::Anna-11',
+    pretext: 'Copilot here',
+    ttsEngine: 'piper',
+  },
+  codex: {
+    effects: 'light',
+    bgTrack: 'agent_vibes_chillwave_v2_loop.mp3',
+    bgVolume: '0.15',
+    // NOTE: lessac-medium appears to silently fail to synthesize on some
+    // Windows Piper installs (loads the model, exits with no output).
+    // lessac-high works reliably, so use it as the default for codex.
+    voice: 'en_US-lessac-high',
+    pretext: 'Codex here',
+    ttsEngine: 'piper',
+  },
+};
+
+function ensureDefaultLlmConfigSync(llmKey, targetDir) {
+  const existing = loadLlmConfigSync(llmKey, targetDir);
+  if (existing.sourcePath) return;
+
+  const defaults = DEFAULT_LLM_CONFIGS[llmKey];
+  if (!defaults) return;
+
+  saveLlmConfigSync(llmKey, defaults, targetDir);
+}
+
 // ── Provider install-checks ─────────────────────────────────────────────────
 
 export async function checkClaudeInstalled(targetDir) {
@@ -73,12 +131,24 @@ export async function checkCodexInstalled(targetDir) {
 export async function installClaudeMcp(targetDir) {
   const mcpConfigPath = path.join(targetDir, '.mcp.json');
 
+  // The agentvibes server entry for Claude Code's .mcp.json.
+  //
+  // IMPORTANT: no `env.AGENTVIBES_LLM` block here.  GitHub Copilot CLI
+  // also reads project-level `.mcp.json` with precedence over its own
+  // `~/.copilot/mcp-config.json` — so if we set `AGENTVIBES_LLM=claude-code`
+  // in `.mcp.json`, Copilot CLI picks up that value too and mis-routes.
+  // Instead, the MCP server (mcp-server/server.py) auto-detects Claude
+  // Code via the `CLAUDECODE=1` env var that Claude Code sets on every
+  // subprocess it spawns.  Copilot CLI does NOT set that var, so its
+  // spawned MCP server correctly falls back to its own config.
+  const agentvibesServer = {
+    command: 'npx',
+    args: ['-y', '--package=agentvibes', 'agentvibes-mcp-server'],
+  };
+
   const mcpConfig = {
     mcpServers: {
-      agentvibes: {
-        command: 'npx',
-        args: ['-y', '--package=agentvibes', 'agentvibes-mcp-server'],
-      },
+      agentvibes: agentvibesServer,
     },
   };
 
@@ -86,15 +156,15 @@ export async function installClaudeMcp(targetDir) {
     let mcpCreated = false;
     try {
       await fs.access(mcpConfigPath);
-      // Already exists — merge agentvibes key if missing
+      // Already exists — merge / upgrade the agentvibes entry.  This also
+      // STRIPS any stale AGENTVIBES_LLM env block left over from v5.1.2..4
+      // so Copilot CLI stops mis-routing.
       try {
         const existing = JSON.parse(await fs.readFile(mcpConfigPath, 'utf8'));
-        if (!existing.mcpServers?.agentvibes) {
-          existing.mcpServers = existing.mcpServers || {};
-          existing.mcpServers.agentvibes = mcpConfig.mcpServers.agentvibes;
-          await fs.writeFile(mcpConfigPath, JSON.stringify(existing, null, 2) + '\n');
-          mcpCreated = true;
-        }
+        existing.mcpServers = existing.mcpServers || {};
+        existing.mcpServers.agentvibes = { ...agentvibesServer };
+        await fs.writeFile(mcpConfigPath, JSON.stringify(existing, null, 2) + '\n');
+        mcpCreated = true;
       } catch { /* parse error — don't corrupt */ }
     } catch {
       // File doesn't exist — create it
@@ -112,6 +182,7 @@ export async function installClaudeMcp(targetDir) {
     await installer.copyPluginFiles(targetDir, silentSpinner);
     await installer.copyBmadConfigFiles(targetDir, silentSpinner);
     await installer.copyBackgroundMusicFiles(targetDir, silentSpinner);
+    ensureDefaultLlmConfigSync('claude-code', targetDir);
 
     return { success: true, mcpCreated };
   } catch (err) {
@@ -247,6 +318,37 @@ export async function installCopilotMcp(targetDir) {
 
     mcpConfig.servers.agentvibes = agentvibesServer;
     await fs.writeFile(mcpJsonPath, JSON.stringify(mcpConfig, null, 2) + '\n');
+
+    // Also write ~/.copilot/mcp-config.json so the GitHub Copilot CLI
+    // (different product from VS Code Copilot Chat!) can find the
+    // agentvibes MCP server.  VS Code reads .vscode/mcp.json, but the
+    // CLI reads ONLY from ~/.copilot/mcp-config.json per docs:
+    // https://docs.github.com/en/copilot/how-tos/copilot-cli/customize-copilot/add-mcp-servers
+    try {
+      const copilotHome = process.env.COPILOT_HOME ||
+        path.join(process.env.USERPROFILE || process.env.HOME || '', '.copilot');
+      const copilotMcpPath = path.join(copilotHome, 'mcp-config.json');
+      await fs.mkdir(copilotHome, { recursive: true });
+      let cliConfig = { mcpServers: {} };
+      try {
+        const existingCli = await fs.readFile(copilotMcpPath, 'utf8');
+        const parsedCli = JSON.parse(existingCli);
+        if (parsedCli && typeof parsedCli === 'object') {
+          cliConfig = parsedCli;
+          if (!cliConfig.mcpServers) cliConfig.mcpServers = {};
+        }
+      } catch { /* new file */ }
+      cliConfig.mcpServers.agentvibes = {
+        type: 'local',
+        command: 'npx',
+        args: ['-y', '--package=agentvibes', 'agentvibes-mcp-server'],
+        env: { AGENTVIBES_LLM: 'copilot' },
+        tools: ['*'],
+      };
+      await fs.writeFile(copilotMcpPath, JSON.stringify(cliConfig, null, 2) + '\n');
+    } catch { /* best effort — CLI might not be installed */ }
+
+    ensureDefaultLlmConfigSync('copilot', targetDir);
     return { success: true };
   } catch (err) {
     return { success: false, error: err.message };
@@ -300,6 +402,7 @@ export async function installCodexMcp(targetDir) {
     try { existing = await fs.readFile(tomlPath, 'utf8'); } catch { /* new file */ }
     const content = buildCodexToml(existing);
     await fs.writeFile(tomlPath, content);
+    ensureDefaultLlmConfigSync('codex', targetDir);
     return { success: true };
   } catch (err) {
     return { success: false, error: err.message };

package/src/services/verbosity-service.js

@@ -1,157 +1,159 @@
-/**
- * AgentVibes VerbosityService
- * Epic 10: Stories 10.1-10.4
- *
- * Centralises verbosity logic for 5 levels: minimal, low, medium, high, custom.
- *
- * Hook types:
- *   - 'prompt-submit'     — fires when user submits a prompt
- *   - 'response-complete' — fires when Claude finishes responding
- */
-
-// ---------------------------------------------------------------------------
-
-/**
- * Ordered verbosity levels from quietest to most verbose.
- * @type {string[]}
- */
-export const VERBOSITY_LEVELS = Object.freeze(['minimal', 'low', 'medium', 'high', 'custom']);
-
-// Per-level shouldSpeak configuration (fixed levels only; custom reads from config)
-const LEVEL_SPEAK = Object.freeze({
-  minimal: { 'prompt-submit': false, 'response-complete': true },
-  low:     { 'prompt-submit': false, 'response-complete': true },
-  medium:  { 'prompt-submit': true,  'response-complete': true },
-  high:    { 'prompt-submit': true,  'response-complete': true },
-});
-
-// Per-level static messages (null = use hook default message)
-const LEVEL_MESSAGES = Object.freeze({
-  minimal: {
-    'prompt-submit':     null,
-    'response-complete': 'Claude is ready for your input',
-  },
-  low: {
-    'prompt-submit':     null,
-    'response-complete': null,  // built dynamically: "Done. <summary>"
-  },
-  medium:  { 'prompt-submit': null, 'response-complete': null },
-  high:    { 'prompt-submit': null, 'response-complete': null },
-});
-
-// ---------------------------------------------------------------------------
-
-export class VerbosityService {
-  /**
-   * @param {object} configService - AgentVibes ConfigService instance
-   */
-  constructor(configService) {
-    this._config = configService;
-    this._migrated = false;  // tracks whether migration ran in this session
-  }
-
-  /**
-   * Returns the current verbosity level.
-   * Defaults to 'high' if not configured or unrecognised.
-   * @returns {'minimal'|'low'|'medium'|'high'|'custom'}
-   */
-  getLevel() {
-    const cfg = this._config.getConfig();
-    const level = cfg.verbosity;
-    return VERBOSITY_LEVELS.includes(level) ? level : 'high';
-  }
-
-  /**
-   * Returns whether TTS should speak for the given hook type.
-   *
-   * @param {'prompt-submit'|'response-complete'} hookType
-   * @returns {boolean}
-   */
-  shouldSpeak(hookType) {
-    const level = this.getLevel();
-    if (level === 'custom') {
-      return this._customShouldSpeak(hookType);
-    }
-    const table = LEVEL_SPEAK[level] ?? LEVEL_SPEAK.high;
-    return table[hookType] ?? true;
-  }
-
-  /**
-   * Returns the message for the given hook type and context.
-   * Returns null to use the hook's own default message.
-   *
-   * @param {'prompt-submit'|'response-complete'} hookType
-   * @param {object} context - { summary?: string }
-   * @returns {string|null}
-   */
-  getMessage(hookType, context) {
-    const level = this.getLevel();
-    if (level === 'high' || level === 'medium') return null;
-
-    if (level === 'low' && hookType === 'response-complete') {
-      const summary = context?.summary ?? '';
-      const trimmed = summary.slice(0, 30);
-      return trimmed.length > 0 ? `Done. ${trimmed}` : 'Done';
-    }
-
-    if (level === 'custom') return null;  // custom uses hook defaults
-
-    return LEVEL_MESSAGES[level]?.[hookType] ?? null;
-  }
-
-  /**
-   * Checks if migration is needed (old 'low' → 'medium').
-   * If needed and not already done, performs migration and returns true.
-   * @returns {boolean} true if migration was performed, false otherwise
-   */
-  checkMigration() {
-    const cfg = this._config.getConfig();
-    if (cfg.verbosityMigrated) return false;
-    if (cfg.verbosity !== 'low') return false;
-
-    // Migrate: old 'low' users get 'medium' in new system
-    this._config.set('verbosity', 'medium');
-    this._config.set('verbosityMigrated', true);
-    this._migrated = true;
-    return true;
-  }
-
-  /**
-   * Returns true if a migration notice should be shown to the user.
-   * @returns {boolean}
-   */
-  needsMigrationNotice() {
-    if (!this._migrated) return false;
-    const cfg = this._config.getConfig();
-    return !cfg.migrationNoticeDismissed;
-  }
-
-  /**
-   * Marks the migration notice as dismissed.
-   */
-  dismissMigrationNotice() {
-    this._config.set('migrationNoticeDismissed', true);
-  }
-
-  // ---------------------------------------------------------------------------
-  // Private
-
-  /**
-   * shouldSpeak for CUSTOM level — reads per-hook toggles from config.customVerbosity.
-   * @param {string} hookType
-   * @returns {boolean}
-   */
-  _customShouldSpeak(hookType) {
-    const cfg = this._config.getConfig();
-    const custom = cfg.customVerbosity ?? {};
-    const keyMap = {
-      'prompt-submit':     'promptSubmit',
-      'response-complete': 'responseComplete',
-    };
-    const key = keyMap[hookType];
-    if (key === undefined) return true;
-    return custom[key] !== false;  // default true if not configured
-  }
-}
-
-export default VerbosityService;
+/**
+ * AgentVibes VerbosityService
+ * Epic 10: Stories 10.1-10.4
+ *
+ * Centralises verbosity logic for 5 levels: minimal, low, medium, high, custom.
+ *
+ * Hook types:
+ *   - 'prompt-submit'     — fires when user submits a prompt
+ *   - 'response-complete' — fires when Claude finishes responding
+ */
+
+// ---------------------------------------------------------------------------
+
+/**
+ * Ordered verbosity levels from quietest to most verbose.
+ * @type {string[]}
+ */
+export const VERBOSITY_LEVELS = Object.freeze(['minimal', 'low', 'medium', 'high', 'caveman', 'custom']);
+
+// Per-level shouldSpeak configuration (fixed levels only; custom reads from config)
+const LEVEL_SPEAK = Object.freeze({
+  minimal: { 'prompt-submit': false, 'response-complete': true },
+  low:     { 'prompt-submit': false, 'response-complete': true },
+  medium:  { 'prompt-submit': true,  'response-complete': true },
+  high:    { 'prompt-submit': true,  'response-complete': true },
+  caveman: { 'prompt-submit': true,  'response-complete': true },
+});
+
+// Per-level static messages (null = use hook default message)
+const LEVEL_MESSAGES = Object.freeze({
+  minimal: {
+    'prompt-submit':     null,
+    'response-complete': 'Claude is ready for your input',
+  },
+  low: {
+    'prompt-submit':     null,
+    'response-complete': null,  // built dynamically: "Done. <summary>"
+  },
+  medium:  { 'prompt-submit': null, 'response-complete': null },
+  high:    { 'prompt-submit': null, 'response-complete': null },
+  caveman: { 'prompt-submit': null, 'response-complete': null },
+});
+
+// ---------------------------------------------------------------------------
+
+export class VerbosityService {
+  /**
+   * @param {object} configService - AgentVibes ConfigService instance
+   */
+  constructor(configService) {
+    this._config = configService;
+    this._migrated = false;  // tracks whether migration ran in this session
+  }
+
+  /**
+   * Returns the current verbosity level.
+   * Defaults to 'high' if not configured or unrecognised.
+   * @returns {'minimal'|'low'|'medium'|'high'|'custom'}
+   */
+  getLevel() {
+    const cfg = this._config.getConfig();
+    const level = cfg.verbosity;
+    return VERBOSITY_LEVELS.includes(level) ? level : 'high';
+  }
+
+  /**
+   * Returns whether TTS should speak for the given hook type.
+   *
+   * @param {'prompt-submit'|'response-complete'} hookType
+   * @returns {boolean}
+   */
+  shouldSpeak(hookType) {
+    const level = this.getLevel();
+    if (level === 'custom') {
+      return this._customShouldSpeak(hookType);
+    }
+    const table = LEVEL_SPEAK[level] ?? LEVEL_SPEAK.high;
+    return table[hookType] ?? true;
+  }
+
+  /**
+   * Returns the message for the given hook type and context.
+   * Returns null to use the hook's own default message.
+   *
+   * @param {'prompt-submit'|'response-complete'} hookType
+   * @param {object} context - { summary?: string }
+   * @returns {string|null}
+   */
+  getMessage(hookType, context) {
+    const level = this.getLevel();
+    if (level === 'high' || level === 'medium' || level === 'caveman') return null;
+
+    if (level === 'low' && hookType === 'response-complete') {
+      const summary = context?.summary ?? '';
+      const trimmed = summary.slice(0, 30);
+      return trimmed.length > 0 ? `Done. ${trimmed}` : 'Done';
+    }
+
+    if (level === 'custom') return null;  // custom uses hook defaults
+
+    return LEVEL_MESSAGES[level]?.[hookType] ?? null;
+  }
+
+  /**
+   * Checks if migration is needed (old 'low' → 'medium').
+   * If needed and not already done, performs migration and returns true.
+   * @returns {boolean} true if migration was performed, false otherwise
+   */
+  checkMigration() {
+    const cfg = this._config.getConfig();
+    if (cfg.verbosityMigrated) return false;
+    if (cfg.verbosity !== 'low') return false;
+
+    // Migrate: old 'low' users get 'medium' in new system
+    this._config.set('verbosity', 'medium');
+    this._config.set('verbosityMigrated', true);
+    this._migrated = true;
+    return true;
+  }
+
+  /**
+   * Returns true if a migration notice should be shown to the user.
+   * @returns {boolean}
+   */
+  needsMigrationNotice() {
+    if (!this._migrated) return false;
+    const cfg = this._config.getConfig();
+    return !cfg.migrationNoticeDismissed;
+  }
+
+  /**
+   * Marks the migration notice as dismissed.
+   */
+  dismissMigrationNotice() {
+    this._config.set('migrationNoticeDismissed', true);
+  }
+
+  // ---------------------------------------------------------------------------
+  // Private
+
+  /**
+   * shouldSpeak for CUSTOM level — reads per-hook toggles from config.customVerbosity.
+   * @param {string} hookType
+   * @returns {boolean}
+   */
+  _customShouldSpeak(hookType) {
+    const cfg = this._config.getConfig();
+    const custom = cfg.customVerbosity ?? {};
+    const keyMap = {
+      'prompt-submit':     'promptSubmit',
+      'response-complete': 'responseComplete',
+    };
+    const key = keyMap[hookType];
+    if (key === undefined) return true;
+    return custom[key] !== false;  // default true if not configured
+  }
+}
+
+export default VerbosityService;

package/templates/agentvibes-receiver.sh

@@ -201,8 +201,9 @@ if [[ -z "$TEXT" ]]; then
   exit 1
 fi
 
-# SECURITY: Validate voice format (alphanumeric, hyphens, underscores only)
-if [[ ! "$VOICE" =~ ^[a-zA-Z0-9_-]+$ ]]; then
+# SECURITY: Validate voice format (allow :: for multi-speaker, . for locale, space for names)
+_voice_re='^[a-zA-Z0-9_.:  -]+$'
+if [[ ! "$VOICE" =~ $_voice_re ]]; then
   echo "Error: Invalid voice format" >&2
   exit 1
 fi