agentvibes 4.2.0 → 4.4.0

package/src/utils/preview-list-prompt.js

@@ -1,136 +1,136 @@
-/**
- * Custom Inquirer List Prompt with Spacebar Preview
- * Uses wrapper approach with readline keypress events
- */
-
-import readline from 'node:readline';
-import { execSync } from 'node:child_process';
-
-/**
- * Wrapper for inquirer list prompt that adds spacebar preview
- * @param {Object} inquirer - Inquirer instance
- * @param {Object} config - Prompt configuration
- * @param {Function} config.onPreview - Callback for preview (receives selected value)
- * @returns {Promise} Inquirer prompt promise
- */
-export async function createPreviewListPrompt(inquirer, config) {
-  const { onPreview, ...promptConfig } = config;
-
-  // Set up keypress listener
-  let keypressListener = null;
-
-  // Track playing state
-  let currentlyPlaying = null;
-  let audioProcess = null;
-
-  // Initialize currentSelection to match the default value
-  let currentSelection = 0;
-  if (promptConfig.default) {
-    const defaultIndex = promptConfig.choices.findIndex(c => c.value === promptConfig.default);
-    if (defaultIndex !== -1) {
-      currentSelection = defaultIndex;
-    }
-  }
-
-  // Function to stop currently playing audio
-  const stopAudio = () => {
-    // Kill the specific process if we have it
-    // SECURITY: Only kill our own process, never use pkill which affects all users
-    if (audioProcess) {
-      try {
-        audioProcess.kill('SIGKILL');
-        audioProcess = null;
-      } catch (e) {
-        // Process might have already finished or already killed
-      }
-    }
-
-    currentlyPlaying = null;
-  };
-
-  if (onPreview && process.stdin.isTTY) {
-    readline.emitKeypressEvents(process.stdin);
-    // SECURITY: Wrap in try-catch to prevent terminal corruption on error
-    try {
-      if (process.stdin.setRawMode) {
-        process.stdin.setRawMode(true);
-      }
-    } catch (e) {
-      // Failed to set raw mode, continue without it
-    }
-
-    keypressListener = async (str, key) => {
-      // Track current selection based on arrow keys
-      if (key && key.name === 'down') {
-        currentSelection = Math.min(currentSelection + 1, promptConfig.choices.length - 1);
-      } else if (key && key.name === 'up') {
-        currentSelection = Math.max(currentSelection - 1, 0);
-      }
-
-      if (key && key.name === 'space') {
-        // Get the current item (don't filter - use actual index)
-        const currentChoice = promptConfig.choices[currentSelection];
-
-        // Only preview if it's a valid choice (not separator, not special item)
-        if (currentChoice && currentChoice.value && !currentChoice.value.startsWith('__')) {
-
-          // Toggle: if same voice pressed twice, stop it
-          if (currentlyPlaying === currentChoice.value) {
-            stopAudio();
-            return;
-          }
-
-          // CRITICAL: Stop previous voice BEFORE starting new one
-          if (currentlyPlaying) {
-            stopAudio();
-            // Small delay to ensure kill takes effect
-            await new Promise(resolve => setTimeout(resolve, 100));
-          }
-
-          currentlyPlaying = currentChoice.value;
-
-          // Call onPreview and store process handle immediately
-          try {
-            const result = await onPreview(currentChoice.value);
-            // Store the process handle - onPreview should return the spawn() result
-            audioProcess = result;
-          } catch (err) {
-            console.error(`[Preview] Error playing sample:`, err.message);
-            currentlyPlaying = null;
-            audioProcess = null;
-          }
-        }
-      }
-    };
-
-    process.stdin.on('keypress', keypressListener);
-  }
-
-  try {
-    // Run the standard list prompt
-    const result = await inquirer.prompt([{
-      ...promptConfig,
-      type: 'list'
-    }]);
-
-    return result;
-  } finally {
-    // Stop any playing audio
-    stopAudio();
-
-    // Clean up keypress listener
-    if (keypressListener) {
-      process.stdin.removeListener('keypress', keypressListener);
-      // SECURITY: Wrap in try-catch to ensure cleanup always completes
-      try {
-        if (process.stdin.setRawMode) {
-          process.stdin.setRawMode(false);
-        }
-      } catch (e) {
-        // Failed to restore raw mode, but we're exiting anyway
-      }
-    }
-  }
-}
-
-export default createPreviewListPrompt;
+/**
+ * Custom Inquirer List Prompt with Spacebar Preview
+ * Uses wrapper approach with readline keypress events
+ */
+
+import readline from 'node:readline';
+import { execSync } from 'node:child_process';
+
+/**
+ * Wrapper for inquirer list prompt that adds spacebar preview
+ * @param {Object} inquirer - Inquirer instance
+ * @param {Object} config - Prompt configuration
+ * @param {Function} config.onPreview - Callback for preview (receives selected value)
+ * @returns {Promise} Inquirer prompt promise
+ */
+export async function createPreviewListPrompt(inquirer, config) {
+  const { onPreview, ...promptConfig } = config;
+
+  // Set up keypress listener
+  let keypressListener = null;
+
+  // Track playing state
+  let currentlyPlaying = null;
+  let audioProcess = null;
+
+  // Initialize currentSelection to match the default value
+  let currentSelection = 0;
+  if (promptConfig.default) {
+    const defaultIndex = promptConfig.choices.findIndex(c => c.value === promptConfig.default);
+    if (defaultIndex !== -1) {
+      currentSelection = defaultIndex;
+    }
+  }
+
+  // Function to stop currently playing audio
+  const stopAudio = () => {
+    // Kill the specific process if we have it
+    // SECURITY: Only kill our own process, never use pkill which affects all users
+    if (audioProcess) {
+      try {
+        audioProcess.kill('SIGKILL');
+        audioProcess = null;
+      } catch (e) {
+        // Process might have already finished or already killed
+      }
+    }
+
+    currentlyPlaying = null;
+  };
+
+  if (onPreview && process.stdin.isTTY) {
+    readline.emitKeypressEvents(process.stdin);
+    // SECURITY: Wrap in try-catch to prevent terminal corruption on error
+    try {
+      if (process.stdin.setRawMode) {
+        process.stdin.setRawMode(true);
+      }
+    } catch (e) {
+      // Failed to set raw mode, continue without it
+    }
+
+    keypressListener = async (str, key) => {
+      // Track current selection based on arrow keys
+      if (key && key.name === 'down') {
+        currentSelection = Math.min(currentSelection + 1, promptConfig.choices.length - 1);
+      } else if (key && key.name === 'up') {
+        currentSelection = Math.max(currentSelection - 1, 0);
+      }
+
+      if (key && key.name === 'space') {
+        // Get the current item (don't filter - use actual index)
+        const currentChoice = promptConfig.choices[currentSelection];
+
+        // Only preview if it's a valid choice (not separator, not special item)
+        if (currentChoice && currentChoice.value && !currentChoice.value.startsWith('__')) {
+
+          // Toggle: if same voice pressed twice, stop it
+          if (currentlyPlaying === currentChoice.value) {
+            stopAudio();
+            return;
+          }
+
+          // CRITICAL: Stop previous voice BEFORE starting new one
+          if (currentlyPlaying) {
+            stopAudio();
+            // Small delay to ensure kill takes effect
+            await new Promise(resolve => setTimeout(resolve, 100));
+          }
+
+          currentlyPlaying = currentChoice.value;
+
+          // Call onPreview and store process handle immediately
+          try {
+            const result = await onPreview(currentChoice.value);
+            // Store the process handle - onPreview should return the spawn() result
+            audioProcess = result;
+          } catch (err) {
+            console.error(`[Preview] Error playing sample:`, err.message);
+            currentlyPlaying = null;
+            audioProcess = null;
+          }
+        }
+      }
+    };
+
+    process.stdin.on('keypress', keypressListener);
+  }
+
+  try {
+    // Run the standard list prompt
+    const result = await inquirer.prompt([{
+      ...promptConfig,
+      type: 'list'
+    }]);
+
+    return result;
+  } finally {
+    // Stop any playing audio
+    stopAudio();
+
+    // Clean up keypress listener
+    if (keypressListener) {
+      process.stdin.removeListener('keypress', keypressListener);
+      // SECURITY: Wrap in try-catch to ensure cleanup always completes
+      try {
+        if (process.stdin.setRawMode) {
+          process.stdin.setRawMode(false);
+        }
+      } catch (e) {
+        // Failed to restore raw mode, but we're exiting anyway
+      }
+    }
+  }
+}
+
+export default createPreviewListPrompt;

package/src/utils/provider-validator.js

@@ -62,10 +62,11 @@ export async function validateProvider(providerName) {
       return await validatePiperInstallation();
     case 'macos':
       return await validateMacOSProvider();
+    case 'sapi':
     case 'windows-sapi':
       return await validateWindowsSAPI();
     case 'windows-piper':
-      return await validatePiperInstallation();
+      return await validateWindowsPiperInstallation();
     case 'termux-ssh':
     case 'ssh-remote':
     case 'ssh-pulseaudio':
@@ -111,7 +112,10 @@ async function validatePipxProvider(providerName, packageName) {
   checkedLocations.push('pipx venv');
 
   // Check Python package installations (comprehensive version detection)
-  const pythonCommands = ['python3', 'python', 'python3.12', 'python3.11', 'python3.10', 'python3.9', 'python3.8'];
+  // On Windows, 'py' is the standard Python launcher and often the only one in PATH
+  const pythonCommands = process.platform === 'win32'
+    ? ['py', 'python', 'python3', 'python3.12', 'python3.11', 'python3.10', 'python3.9', 'python3.8']
+    : ['python3', 'python', 'python3.12', 'python3.11', 'python3.10', 'python3.9', 'python3.8'];
 
   for (const pythonCmd of pythonCommands) {
     try {
@@ -210,6 +214,43 @@ export async function validateWindowsSAPI() {
   return { installed: true, message: 'Windows SAPI available' };
 }
 
+/**
+ * Validate Windows Piper TTS installation
+ * Checks for piper.exe at the standard Windows install location
+ * @returns {Promise<{installed: boolean, message: string, checkedLocations?: string[], error?: string}>}
+ */
+export async function validateWindowsPiperInstallation() {
+  if (process.platform !== 'win32') {
+    return await validatePiperInstallation(); // Fall back to Unix checks
+  }
+
+  const checkedLocations = [];
+
+  // Check the standard Windows install path
+  const localAppData = process.env.LOCALAPPDATA ||
+    (process.env.USERPROFILE ? path.join(process.env.USERPROFILE, 'AppData', 'Local') : null);
+  if (localAppData) {
+    const piperExe = path.join(localAppData, 'Programs', 'Piper', 'piper.exe');
+    checkedLocations.push(piperExe);
+    if (fs.existsSync(piperExe)) {
+      return { installed: true, message: 'Piper TTS detected (Windows exe)', checkedLocations };
+    }
+  }
+
+  // Also check PATH in case user installed it differently
+  if (commandExistsInPath('piper')) {
+    return { installed: true, message: 'Piper TTS detected (in PATH)', checkedLocations: ['PATH'] };
+  }
+  checkedLocations.push('PATH');
+
+  return {
+    installed: false,
+    message: `Piper TTS is not installed on your system (checked: ${checkedLocations.join(', ')})`,
+    error: 'WINDOWS_PIPER_NOT_FOUND',
+    checkedLocations
+  };
+}
+
 /**
  * Test if a provider works at runtime (more thorough check)
  * Attempts to actually use the provider for a brief moment
@@ -328,10 +369,11 @@ export function getProviderInstallCommand(providerName) {
  * @returns {object} {success: boolean, message: string, command?: string, verified?: boolean}
  */
 export async function attemptProviderInstallation(providerName) {
-  // Whitelist approach - only allow known providers (MEDIUM #1 fix)
+  // Whitelist approach - only allow known providers
   const providers = {
     soprano: 'soprano-tts',
-    piper: 'piper-tts'
+    piper: 'piper-tts',
+    'windows-piper': 'piper-windows-exe'
   };
 
   const pkgName = providers[providerName];
@@ -339,9 +381,22 @@ export async function attemptProviderInstallation(providerName) {
     return { success: false, message: `Unknown provider: ${providerName}` };
   }
 
+  // Windows Piper: download exe instead of pip install
+  // The actual download is handled by checkAndInstallPiperWindows() in installer.js.
+  // Signal success here so the installer flow continues to that function.
+  if (providerName === 'windows-piper') {
+    return {
+      success: true,
+      message: 'Windows Piper will be downloaded during installation',
+      command: 'checkAndInstallPiperWindows()',
+      verified: false // Verification happens after the actual download
+    };
+  }
+
+  const isWindows = process.platform === 'win32' && !process.env.WSL_DISTRO_NAME;
+
   // Strategy 1: Try regular pip install (using spawnSync for correct API usage)
   try {
-    // Show installation in progress
     console.log(`   Attempting: pip install ${pkgName}...`);
     const result = spawnSync('pip', ['install', pkgName], {
       stdio: 'inherit',
@@ -351,7 +406,6 @@ export async function attemptProviderInstallation(providerName) {
     if (result.error || result.status !== 0) {
       // Strategy 1 failed - continue to Strategy 2
     } else {
-      // Verify installation actually worked (proves it's installed)
       const validation = await validateProvider(providerName);
       if (validation.installed) {
         return {
@@ -377,9 +431,8 @@ export async function attemptProviderInstallation(providerName) {
     });
 
     if (result.error || result.status !== 0) {
-      // Both strategies failed
+      // Strategy 2 failed
     } else {
-      // Verify installation actually worked (proves it's installed)
       const validation = await validateProvider(providerName);
       if (validation.installed) {
         return {
@@ -393,11 +446,41 @@ export async function attemptProviderInstallation(providerName) {
       return { success: true, message: `Successfully installed via pipx`, command: `pipx install ${pkgName}` };
     }
   } catch (error) {
-    // Both strategies failed
+    // Strategy 2 failed
+  }
+
+  // Strategy 3 (Windows only): Try 'py -m pip' which is the standard Windows Python launcher
+  if (isWindows) {
+    try {
+      console.log(`   Attempting: py -m pip install ${pkgName}...`);
+      const result = spawnSync('py', ['-m', 'pip', 'install', pkgName], {
+        stdio: 'inherit',
+        timeout: 60000
+      });
+
+      if (!result.error && result.status === 0) {
+        const validation = await validateProvider(providerName);
+        if (validation.installed) {
+          return {
+            success: true,
+            message: `Successfully installed via py -m pip`,
+            command: `py -m pip install ${pkgName}`,
+            verified: true
+          };
+        }
+
+        return { success: true, message: `Successfully installed via py -m pip`, command: `py -m pip install ${pkgName}` };
+      }
+    } catch (error) {
+      // Strategy 3 failed
+    }
   }
 
-  // Both strategies failed - consistent error message (MEDIUM #2 fix)
-  return { success: false, message: `Installation failed. Please install manually:\n   pip install ${pkgName}\n   or\n   pipx install ${pkgName}` };
+  // All strategies failed
+  const installHint = isWindows
+    ? `Installation failed. Please install manually:\n   py -m pip install ${pkgName}\n   or\n   pip install ${pkgName}`
+    : `Installation failed. Please install manually:\n   pip install ${pkgName}\n   or\n   pipx install ${pkgName}`;
+  return { success: false, message: installHint };
 }
 
 /**
@@ -460,8 +543,9 @@ export function getProviderDisplayName(providerName) {
     soprano: 'Soprano TTS',
     piper: 'Piper TTS',
     macos: 'macOS Say',
+    sapi: 'Windows SAPI',
     'windows-sapi': 'Windows SAPI',
-    'windows-piper': 'Windows Piper TTS'
+    'windows-piper': 'Piper TTS'
   };
 
   return names[providerName] || providerName;