agentvibes 4.0.0 → 4.2.0

package/.claude/config/audio-effects.cfg

@@ -25,7 +25,7 @@ Winston|reverb 40 50 90 gain -2|agentvibes_soft_flamenco_loop.mp3|0.25
 Amelia|compand 0.3,1 6:-70,-60,-20|agentvibes_soft_flamenco_loop.mp3|0.25
 |||
 # Business Analyst Mary - warm, analytical|||
-Mary|equalizer 200 1q +3 equalizer 2500 1q -2|agentvibes_soft_flamenco_loop.mp3|0.25
+Mary|reverb 70 50 100 equalizer 200 1q +3 equalizer 2500 1q -2|agentvibes_soft_flamenco_loop.mp3|0.25
 |||
 # Scrum Master Bob - refined, organized|||
 Bob|reverb 30 40 70 compand 0.2,0.5 6:-70,-60,-20|agentvibes_soft_flamenco_loop.mp3|0.25
@@ -49,4 +49,5 @@ BMad Master|reverb 50 60 100 pitch -100|agentvibes_soft_flamenco_loop.mp3|0.30
 _party_mode|compand 0.3,1 6:-70,-60,-20|agent_vibes_dark_chill_step_loop.mp3|0.40
 |||
 # Default (no agent specified) - clean with Bachata background|||
-default|reverb 40 50 70|agent_vibes_celtic_harp_v1_loop.mp3|0.30
+default|reverb 40 50 70|agentvibes_soft_flamenco_loop.mp3|0.30
+analyst|reverb 70 50 100|agentvibes_soft_flamenco_loop.mp3|0.30

package/.claude/config/background-music-position.txt

@@ -1 +1 @@
-agent_vibes_celtic_harp_v1_loop.mp3:12.341678
+agent_vibes_celtic_harp_v1_loop.mp3:.00000000000000000012190647

package/.claude/hooks/audio-processor.sh

@@ -34,6 +34,7 @@ PROJECT_ROOT="$(cd "$SCRIPT_DIR/../.." && pwd)"
 INPUT_FILE="${1:-}"
 AGENT_NAME="${2:-default}"
 OUTPUT_FILE="${3:-}"
+AGENT_PROFILE_FILE="${4:-}"  # Optional: path to per-agent profile JSON (from bmad-speak.sh)
 
 # Config and directories (resolve to absolute paths)
 CONFIG_FILE="$(cd "$SCRIPT_DIR/.." && pwd)/config/audio-effects.cfg"
@@ -140,9 +141,11 @@ apply_sox_effects() {
 
 # Position tracking file for continuous playback
 POSITION_FILE="$SCRIPT_DIR/../config/background-music-position.txt"
+# Lock file for position file — prevents race conditions in party mode with concurrent agents
+POSITION_LOCK="/tmp/agentvibes-bgpos-$(id -u).lock"
 
 # @function get_background_position
-# @intent Get saved position for a background track
+# @intent Get saved position for a background track (caller must hold POSITION_LOCK)
 # @param $1 Background file path
 # @returns Position in seconds (or 0 if not found)
 get_background_position() {
@@ -158,7 +161,7 @@ get_background_position() {
 }
 
 # @function save_background_position
-# @intent Save position for a background track
+# @intent Save position for a background track (caller must hold POSITION_LOCK)
 # @param $1 Background file path
 # @param $2 New position in seconds
 save_background_position() {
@@ -173,7 +176,8 @@ save_background_position() {
     local tmp_pos
     tmp_pos=$(mktemp "${POSITION_FILE}.XXXXXX")
     if [[ -f "$POSITION_FILE" ]]; then
-        grep -v "^${bg_name}:" "$POSITION_FILE" > "$tmp_pos" 2>/dev/null || true
+        # SECURITY: Use grep -F for fixed string matching (#134)
+        grep -vF "${bg_name}:" "$POSITION_FILE" > "$tmp_pos" 2>/dev/null || true
     fi
     echo "${bg_name}:${position}" >> "$tmp_pos"
     mv "$tmp_pos" "$POSITION_FILE"
@@ -216,48 +220,58 @@ mix_background() {
     bg_duration=$(ffprobe -v error -show_entries format=duration -of default=noprint_wrappers=1:nokey=1 "$background" 2>/dev/null)
     bg_duration=${bg_duration:-0}
 
-    # Get saved position for this track (continuous playback)
+    # Read the start position and pre-compute the new position atomically under flock.
+    # This prevents party-mode race conditions where concurrent agents both read the
+    # same position, compute independently, and overwrite each other's updates.
     local start_pos
-    start_pos=$(get_background_position "$background")
-
-    # Validate start_pos: if too small (floating point error) or invalid, reset to 0
-    if command -v bc &> /dev/null; then
-        if ! [[ "$start_pos" =~ ^[0-9]+\.?[0-9]*$ ]] || (( $(echo "$start_pos < 0.001" | bc -l) )); then
-            start_pos="0"
-        fi
-    else
-        # Without bc, just check if it's a valid number
-        if ! [[ "$start_pos" =~ ^[0-9]+\.?[0-9]*$ ]]; then
-            start_pos="0"
+    local new_pos
+    local total_duration
+    {
+        flock -x 200
+
+        # Get saved position for this track (continuous playback)
+        start_pos=$(get_background_position "$background")
+
+        # Validate start_pos: if too small (floating point error) or invalid, reset to 0
+        if command -v bc &> /dev/null; then
+            if ! [[ "$start_pos" =~ ^[0-9]+\.?[0-9]*$ ]] || (( $(echo "$start_pos < 0.001" | bc -l) )); then
+                start_pos="0"
+            fi
+        else
+            # Without bc, just check if it's a valid number
+            if ! [[ "$start_pos" =~ ^[0-9]+\.?[0-9]*$ ]]; then
+                start_pos="0"
+            fi
         fi
-    fi
 
-    # If position exceeds track length, wrap around
-    if command -v bc &> /dev/null && [[ -n "$bg_duration" ]]; then
-        if (( $(echo "$start_pos >= $bg_duration" | bc -l) )); then
-            start_pos=$(echo "$start_pos % $bg_duration" | bc -l)
+        # If position exceeds track length, wrap around
+        if command -v bc &> /dev/null && [[ -n "$bg_duration" ]]; then
+            if (( $(echo "$start_pos >= $bg_duration" | bc -l) )); then
+                start_pos=$(echo "$start_pos % $bg_duration" | bc -l)
+            fi
         fi
-    fi
 
-    # Extend total duration by 2 seconds for background music fade out
-    local total_duration
-    if command -v bc &> /dev/null; then
-        total_duration=$(echo "$duration + 2" | bc -l)
-    else
-        total_duration=$(awk "BEGIN {print $duration + 2}")
-    fi
+        # Extend total duration by 2 seconds for background music fade out
+        if command -v bc &> /dev/null; then
+            total_duration=$(echo "$duration + 2" | bc -l)
+        else
+            total_duration=$(awk "BEGIN {print $duration + 2}")
+        fi
 
-    # Calculate new position after this clip (including fade out time)
-    local new_pos
-    if command -v bc &> /dev/null; then
-        new_pos=$(echo "$start_pos + $total_duration" | bc -l)
-        # Wrap around if needed
-        if [[ -n "$bg_duration" ]] && (( $(echo "$new_pos >= $bg_duration" | bc -l) )); then
-            new_pos=$(echo "$new_pos % $bg_duration" | bc -l)
+        # Calculate new position after this clip (including fade out time)
+        if command -v bc &> /dev/null; then
+            new_pos=$(echo "$start_pos + $total_duration" | bc -l)
+            # Wrap around if needed
+            if [[ -n "$bg_duration" ]] && (( $(echo "$new_pos >= $bg_duration" | bc -l) )); then
+                new_pos=$(echo "$new_pos % $bg_duration" | bc -l)
+            fi
+        else
+            new_pos="0"
         fi
-    else
-        new_pos="0"
-    fi
+
+        # Claim the new position immediately so concurrent agents advance past it
+        save_background_position "$background" "$new_pos"
+    } 200>"$POSITION_LOCK"
 
     # Mix: Seek to position in background, apply volume and fades
     # Background fades in at start (0.3s), continues under speech, then fades out over 2s after speech ends
@@ -302,9 +316,6 @@ mix_background() {
         cp "$voice" "$output"
         return
     }
-
-    # Save new position for next time
-    save_background_position "$background" "$new_pos"
 }
 
 # Main processing
@@ -318,6 +329,25 @@ main() {
     # Parse config (format: NAME|EFFECTS|BACKGROUND|VOLUME)
     IFS='|' read -r _ sox_effects background_file bg_volume <<< "$config"
 
+    # Per-agent background music override from bmad-speak.sh profile JSON (takes priority over cfg).
+    # The profile file is a PID-scoped temp file written by bmad-speak.sh; no env var leakage.
+    if [[ -n "$AGENT_PROFILE_FILE" ]] && [[ -f "$AGENT_PROFILE_FILE" ]]; then
+        # SECURITY: Pass profile path via env var to avoid shell injection in node -e string
+        local _prof_track _prof_vol _prof_enabled
+        _prof_track=$(_AV_PROF="$AGENT_PROFILE_FILE" node -e "try{const p=JSON.parse(require('fs').readFileSync(process.env._AV_PROF,'utf8'));process.stdout.write(p.backgroundMusic?.track??'')}catch{process.stdout.write('')}" 2>/dev/null || true)
+        _prof_vol=$(_AV_PROF="$AGENT_PROFILE_FILE" node -e "try{const p=JSON.parse(require('fs').readFileSync(process.env._AV_PROF,'utf8'));process.stdout.write(String(p.backgroundMusic?.volume??''))}catch{process.stdout.write('')}" 2>/dev/null || true)
+        _prof_enabled=$(_AV_PROF="$AGENT_PROFILE_FILE" node -e "try{const p=JSON.parse(require('fs').readFileSync(process.env._AV_PROF,'utf8'));process.stdout.write(String(p.backgroundMusic?.enabled??''))}catch{process.stdout.write('')}" 2>/dev/null || true)
+        if [[ "$_prof_enabled" == "true" ]] && [[ -n "$_prof_track" ]]; then
+            background_file="$_prof_track"
+            # Convert percentage volume (0-100) to decimal (0.0-1.0) for ffmpeg
+            if [[ "$_prof_vol" =~ ^[0-9]+$ ]]; then
+                bg_volume=$(awk "BEGIN{printf \"%.2f\", ${_prof_vol}/100}")
+            else
+                bg_volume="0.70"
+            fi
+        fi
+    fi
+
     # SECURITY: Use secure temp directory per CLAUDE.md guidelines
     # Prefer XDG_RUNTIME_DIR (user-owned, restricted permissions)
     # Fall back to user-specific directory in /tmp
@@ -338,7 +368,10 @@ main() {
     chmod 700 "$TEMP_DIR"
 
     # SECURITY: Verify ownership of temp directory
-    if [[ "$(stat -c '%u' "$TEMP_DIR" 2>/dev/null || stat -f '%u' "$TEMP_DIR" 2>/dev/null)" != "$(id -u)" ]]; then
+    # SECURITY: Handle stat failure explicitly (#134)
+    local _dir_uid
+    _dir_uid=$(stat -c '%u' "$TEMP_DIR" 2>/dev/null || stat -f '%u' "$TEMP_DIR" 2>/dev/null)
+    if [[ -z "$_dir_uid" ]] || [[ "$_dir_uid" != "$(id -u)" ]]; then
         echo "Error: Temp directory not owned by current user: $TEMP_DIR" >&2
         exit 1
     fi
@@ -369,8 +402,19 @@ main() {
         background_path="$BACKGROUNDS_DIR/$background_file"
     fi
 
+    # Per-agent profile enables music independently of the global flag.
+    local _bg_allowed=false
+    if is_background_music_enabled; then
+        _bg_allowed=true
+    elif [[ -n "$AGENT_PROFILE_FILE" ]] && [[ -f "$AGENT_PROFILE_FILE" ]]; then
+        # A valid agent profile with enabled=true overrides the global off switch.
+        local _check_enabled
+        _check_enabled=$(_AV_PROF="$AGENT_PROFILE_FILE" node -e "try{const p=JSON.parse(require('fs').readFileSync(process.env._AV_PROF,'utf8'));process.stdout.write(String(p.backgroundMusic?.enabled??''))}catch{process.stdout.write('')}" 2>/dev/null || true)
+        [[ "$_check_enabled" == "true" ]] && _bg_allowed=true
+    fi
+
     local used_background=""
-    if is_background_music_enabled && [[ -n "$background_path" ]] && [[ -f "$background_path" ]] && [[ "${bg_volume:-0}" != "0" ]] && [[ "${bg_volume:-0}" != "0.0" ]]; then
+    if [[ "$_bg_allowed" == "true" ]] && [[ -n "$background_path" ]] && [[ -f "$background_path" ]] && [[ "${bg_volume:-0}" != "0" ]] && [[ "${bg_volume:-0}" != "0.0" ]]; then
         echo "  → Mixing background: $background_file at ${bg_volume} volume" >&2
         mix_background "$temp_effects" "$background_path" "$bg_volume" "$temp_final"
         used_background="$background_path"  # Return full path instead of just filename

package/.claude/hooks/bmad-speak.sh

@@ -28,6 +28,10 @@ DIALOGUE="$2"
 DIALOGUE="${DIALOGUE//\\!/!}"
 DIALOGUE="${DIALOGUE//\\\$/\$}"
 
+# Strip markdown formatting — prevent Piper from speaking "asterisk asterisk" literally.
+# play-tts-piper.sh also strips via perl, but do it here early as defense-in-depth.
+DIALOGUE=$(printf '%s' "$DIALOGUE" | sed 's/\*\*//g; s/\*//g; s/`//g; s/^[[:space:]]*#\+[[:space:]]*//')
+
 # Check if party mode is enabled
 if [[ -f "$PROJECT_ROOT/.agentvibes/bmad/bmad-party-mode-disabled.flag" ]]; then
   exit 0
@@ -38,40 +42,110 @@ if [[ ! -f "$PROJECT_ROOT/_bmad/_config/agent-manifest.csv" ]]; then
   exit 0
 fi
 
-# Map display name to agent ID, OR pass through if already an agent ID
+# ---------------------------------------------------------------------------
+# Per-agent profile reader — reads from ~/.agentvibes/bmad-voice-map.json
+# Uses node for reliable JSON parsing (jq may not be installed)
+# Returns empty string if field not found or file missing
+
+VOICE_MAP_FILE="$HOME/.agentvibes/bmad-voice-map.json"
+
+# Read a field from the per-agent profile in bmad-voice-map.json
+# Usage: read_agent_profile <agent_id> <field>
+# Fields: voice, pretext, reverbPreset, personality, backgroundMusic.track, backgroundMusic.volume
+read_agent_profile() {
+  local agent_id="$1"
+  local field="$2"
+
+  if [[ ! -f "$VOICE_MAP_FILE" ]]; then
+    echo ""
+    return
+  fi
+
+  # Validate agent_id format (prevent injection)
+  if [[ ! "$agent_id" =~ ^[a-zA-Z0-9_-]+$ ]]; then
+    echo ""
+    return
+  fi
+
+  # Use node for JSON parsing (always available in AgentVibes projects)
+  # SECURITY: Pass values via env vars to prevent shell injection
+  _VOICE_MAP="$VOICE_MAP_FILE" _AGENT_ID="$agent_id" _FIELD="$field" node -e "
+    try {
+      const d = JSON.parse(require('fs').readFileSync(process.env._VOICE_MAP,'utf8'));
+      const a = d.agents?.[process.env._AGENT_ID] ?? {};
+      const f = process.env._FIELD;
+      if (f.includes('.')) {
+        const [k1, k2] = f.split('.');
+        process.stdout.write(String(a[k1]?.[k2] ?? ''));
+      } else {
+        process.stdout.write(String(a[f] ?? ''));
+      }
+    } catch { process.stdout.write(''); }
+  " 2>/dev/null || echo ""
+}
+
+# Read all profile fields in a single Node.js invocation to avoid ~900ms of overhead.
+# Returns: voice|pretext|reverbPreset|personality|backgroundMusic.track|backgroundMusic.volume
+# Outputs `|||||` if the file is missing or the agent is not found.
+# SECURITY: Pass values via env vars to prevent shell injection
+read_agent_profile_all() {
+  local agent_id="$1"
+
+  # Validate agent_id format (prevent injection)
+  if [[ ! "$agent_id" =~ ^[a-zA-Z0-9_-]+$ ]]; then
+    echo "|||||"
+    return
+  fi
+
+  if [[ ! -f "$VOICE_MAP_FILE" ]]; then
+    echo "||||||"
+    return
+  fi
+
+  _VOICE_MAP="$VOICE_MAP_FILE" _AGENT_ID="$agent_id" node -e "
+    try {
+      const d = JSON.parse(require('fs').readFileSync(process.env._VOICE_MAP,'utf8'));
+      const a = d.agents?.[process.env._AGENT_ID] ?? {};
+      const fields = [
+        String(a.voice ?? ''),
+        String(a.pretext ?? ''),
+        String(a.reverbPreset ?? ''),
+        String(a.personality ?? ''),
+        String(a.backgroundMusic?.track ?? ''),
+        String(a.backgroundMusic?.volume ?? ''),
+        String(a.backgroundMusic?.enabled ?? ''),
+      ];
+      process.stdout.write(fields.join('|'));
+    } catch { process.stdout.write('||||||'); }
+  " 2>/dev/null || echo "||||||"
+}
+
+# ---------------------------------------------------------------------------
+# Map display name to agent ID
+
 map_to_agent_id() {
   local name_or_id="$1"
 
   # If it looks like a file path (.bmad/*/agents/*.md), extract the agent ID
-  # Example: .bmad/bmm/agents/pm.md -> pm
   if [[ "$name_or_id" =~ _?\.?bmad/.*/agents/([^/]+)\.md$ ]]; then
     echo "${BASH_REMATCH[1]}"
     return
   fi
 
   # First check if it's already an agent ID (column 1 of manifest)
-  # CSV format: name,displayName,title,icon,role,...
   local direct_match=$(grep -i "^\"*${name_or_id}\"*," "$PROJECT_ROOT/_bmad/_config/agent-manifest.csv" | head -1)
   if [[ -n "$direct_match" ]]; then
-    # Already an agent ID, pass through
     echo "$name_or_id"
     return
   fi
 
   # Otherwise map display name to agent ID (for party mode)
-  # Extract 'name' (column 1) where displayName (column 2) contains the name
-  # displayName format in CSV: "John", "Mary", "Winston", etc. (first word before any parentheses)
   local agent_id=$(awk -F',' -v name="$name_or_id" '
     BEGIN { IGNORECASE=1 }
     NR > 1 {
-      # Extract displayName (column 2)
       display = $2
-      gsub(/^"|"$/, "", display)  # Remove surrounding quotes
-
-      # Check if display name starts with the search name (case-insensitive)
-      # This handles both "John" and "John (Product Manager)"
+      gsub(/^"|"$/, "", display)
       if (tolower(display) ~ "^" tolower(name) "($| |\\()") {
-        # Extract agent ID (column 1)
         agent = $1
         gsub(/^"|"$/, "", agent)
         print agent
@@ -83,30 +157,113 @@ map_to_agent_id() {
   echo "$agent_id"
 }
 
-# Get agent ID
+# ---------------------------------------------------------------------------
+# Resolve agent profile
+
 AGENT_ID=$(map_to_agent_id "$AGENT_NAME_OR_ID")
 
-# Get agent's voice and intro text
-AGENT_VOICE=""
-AGENT_INTRO=""
-if [[ -n "$AGENT_ID" ]] && [[ -f "$SCRIPT_DIR/bmad-voice-manager.sh" ]]; then
-  AGENT_VOICE=$(cd "$PROJECT_ROOT" && "$SCRIPT_DIR/bmad-voice-manager.sh" get-voice "$AGENT_ID" 2>/dev/null)
-  AGENT_INTRO=$(cd "$PROJECT_ROOT" && "$SCRIPT_DIR/bmad-voice-manager.sh" get-intro "$AGENT_ID" 2>/dev/null)
+# Read per-agent profile from bmad-voice-map.json (takes priority)
+PROFILE_VOICE=""
+PROFILE_PRETEXT=""
+PROFILE_REVERB=""
+PROFILE_PERSONALITY=""
+PROFILE_MUSIC_TRACK=""
+PROFILE_MUSIC_VOLUME=""
+PROFILE_MUSIC_ENABLED=""
+
+if [[ -n "$AGENT_ID" ]] && [[ -f "$VOICE_MAP_FILE" ]]; then
+  # Single Node.js call for all fields — avoids ~900ms of per-call startup overhead
+  _ALL_FIELDS=$(read_agent_profile_all "$AGENT_ID")
+  IFS='|' read -r PROFILE_VOICE PROFILE_PRETEXT PROFILE_REVERB PROFILE_PERSONALITY PROFILE_MUSIC_TRACK PROFILE_MUSIC_VOLUME PROFILE_MUSIC_ENABLED <<< "$_ALL_FIELDS"
+fi
+
+# Fallback to bmad-voice-manager.sh if no profile voice found
+AGENT_VOICE="$PROFILE_VOICE"
+AGENT_INTRO="$PROFILE_PRETEXT"
+
+if [[ -z "$AGENT_VOICE" ]] && [[ -n "$AGENT_ID" ]] && [[ -f "$SCRIPT_DIR/bmad-voice-manager.sh" ]]; then
+  AGENT_VOICE=$(cd "$PROJECT_ROOT" && "$SCRIPT_DIR/bmad-voice-manager.sh" get-voice "$AGENT_ID" 2>/dev/null || true)
+fi
+
+if [[ -z "$AGENT_INTRO" ]] && [[ -n "$AGENT_ID" ]] && [[ -f "$SCRIPT_DIR/bmad-voice-manager.sh" ]]; then
+  AGENT_INTRO=$(cd "$PROJECT_ROOT" && "$SCRIPT_DIR/bmad-voice-manager.sh" get-intro "$AGENT_ID" 2>/dev/null || true)
+fi
+
+# ---------------------------------------------------------------------------
+# Write PID-scoped temp profile file for per-agent overrides
+# play-tts-enhanced.sh and queue worker read this for reverb/personality/music
+
+TEMP_PROFILE=""
+if [[ -n "$PROFILE_REVERB" ]] || [[ -n "$PROFILE_PERSONALITY" ]] || [[ -n "$PROFILE_MUSIC_TRACK" ]]; then
+  PROFILE_DIR="${XDG_RUNTIME_DIR:-/tmp}/agentvibes-$(id -u)"
+  mkdir -p "$PROFILE_DIR"
+  chmod 700 "$PROFILE_DIR"
+  TEMP_PROFILE="$PROFILE_DIR/agent-profile-$$.json"
+
+  # Write profile as JSON for reliable parsing downstream
+  # SECURITY: Pass values via env vars to prevent shell injection
+  _P_REVERB="$PROFILE_REVERB" _P_PERSONALITY="$PROFILE_PERSONALITY" \
+  _P_MUSIC_TRACK="$PROFILE_MUSIC_TRACK" _P_MUSIC_VOL="${PROFILE_MUSIC_VOLUME:-70}" \
+  _P_MUSIC_ENABLED="$PROFILE_MUSIC_ENABLED" \
+  _P_OUTFILE="$TEMP_PROFILE" node -e "
+    const p = {};
+    if (process.env._P_REVERB) p.reverbPreset = process.env._P_REVERB;
+    if (process.env._P_PERSONALITY) p.personality = process.env._P_PERSONALITY;
+    if (process.env._P_MUSIC_TRACK) p.backgroundMusic = {
+      track: process.env._P_MUSIC_TRACK,
+      volume: parseInt(process.env._P_MUSIC_VOL) || 70,
+      enabled: process.env._P_MUSIC_ENABLED === 'true'
+    };
+    require('fs').writeFileSync(process.env._P_OUTFILE, JSON.stringify(p), { mode: 0o600 });
+  " 2>/dev/null || true
+
+  # NOTE: Do NOT clean up temp profile here — the queue worker processes it
+  # asynchronously and cleans it up after use (see tts-queue-worker.sh).
+  # Removing it here would race with the background queue consumer.
 fi
 
-# Prepend intro text if configured (e.g., "John, Product Manager here. [dialogue]")
+# ---------------------------------------------------------------------------
+# Build full text with intro/pretext
+
 FULL_TEXT="$DIALOGUE"
 if [[ -n "$AGENT_INTRO" ]]; then
   FULL_TEXT="${AGENT_INTRO}. ${DIALOGUE}"
 fi
 
-# Speak with agent's voice using queue system (non-blocking for Claude)
-# Queue system ensures sequential playback while allowing Claude to continue
-# Pass agent display name for unique background music per agent (audio-effects.cfg)
-# Output from play-tts.sh will be displayed by the queue worker (GitHub Issue #39)
+
+# Serialize speech — prevents overlap when Claude fires parallel calls
+# Uses mkdir as a portable atomic lock (works on Linux, macOS, WSL)
+SPEECH_LOCK="${XDG_RUNTIME_DIR:-/tmp}/agentvibes-speech.lock"
+
+# Acquire lock (wait up to 120s, retry every 0.5s)
+# Clean up stale file locks from older flock-based version
+[[ -f "$SPEECH_LOCK" ]] && rm -f "$SPEECH_LOCK"
+_WAIT=0
+while ! mkdir "$SPEECH_LOCK" 2>/dev/null; do
+  if [[ -e "$SPEECH_LOCK" ]]; then
+    _LOCK_AGE=$(( $(date +%s) - $(stat -c '%Y' "$SPEECH_LOCK" 2>/dev/null || stat -f '%m' "$SPEECH_LOCK" 2>/dev/null || echo 0) ))
+    [[ $_LOCK_AGE -gt 60 ]] && { rm -rf "$SPEECH_LOCK" 2>/dev/null || true; continue; }
+  fi
+  sleep 0.5
+  _WAIT=$((_WAIT + 1))
+  [[ $_WAIT -gt 240 ]] && break
+done
+trap 'rmdir "$SPEECH_LOCK" 2>/dev/null' EXIT
+
+# Speak with agent's voice, passing the temp profile path as arg 3 so
+# play-tts-piper.sh → audio-processor.sh can read per-agent music settings
+# without any env vars (safe for concurrent multi-project use).
 if [[ -n "$AGENT_VOICE" ]]; then
-  bash "$SCRIPT_DIR/tts-queue.sh" add "$FULL_TEXT" "$AGENT_VOICE" "$AGENT_NAME_OR_ID" &
+  bash "$SCRIPT_DIR/play-tts.sh" "$FULL_TEXT" "$AGENT_VOICE" "$TEMP_PROFILE"
 else
-  # Fallback to default voice, still pass agent name for background music
-  bash "$SCRIPT_DIR/tts-queue.sh" add "$FULL_TEXT" "" "$AGENT_NAME_OR_ID" &
+  bash "$SCRIPT_DIR/play-tts.sh" "$FULL_TEXT" "" "$TEMP_PROFILE"
+fi
+
+# Release lock
+rmdir "$SPEECH_LOCK" 2>/dev/null || true
+trap - EXIT
+
+# Clean up temp profile after use
+if [[ -n "$TEMP_PROFILE" ]] && [[ -f "$TEMP_PROFILE" ]]; then
+  rm -f "$TEMP_PROFILE"
 fi

package/.claude/hooks/play-tts-enhanced.sh

@@ -31,16 +31,51 @@ if [[ "${AGENTVIBES_PARTY_MODE:-false}" == "true" ]]; then
     CONFIG_KEY="_party_mode"
 fi
 
+# ---------------------------------------------------------------------------
+# Per-agent profile overrides (from bmad-voice-map.json via bmad-speak.sh)
+# If AGENTVIBES_AGENT_PROFILE is set and the file exists, apply reverb/personality/music
+# overrides by temporarily setting effects-manager config for this agent
+AGENT_PROFILE="${AGENTVIBES_AGENT_PROFILE:-}"
+
+if [[ -n "$AGENT_PROFILE" ]] && [[ -f "$AGENT_PROFILE" ]]; then
+    # Read profile fields using node (reliable JSON parsing)
+    # SECURITY: Pass values via env vars to prevent shell injection
+    _PROFILE_REVERB=$(_APFILE="$AGENT_PROFILE" node -e "try{const p=JSON.parse(require('fs').readFileSync(process.env._APFILE,'utf8'));process.stdout.write(p.reverbPreset||'')}catch{}" 2>/dev/null || true)
+    _PROFILE_MUSIC_TRACK=$(_APFILE="$AGENT_PROFILE" node -e "try{const p=JSON.parse(require('fs').readFileSync(process.env._APFILE,'utf8'));process.stdout.write(p.backgroundMusic?.track||'')}catch{}" 2>/dev/null || true)
+    _PROFILE_MUSIC_VOL=$(_APFILE="$AGENT_PROFILE" node -e "try{const p=JSON.parse(require('fs').readFileSync(process.env._APFILE,'utf8'));process.stdout.write(String(p.backgroundMusic?.volume||''))}catch{}" 2>/dev/null || true)
+
+    # Apply per-agent reverb via effects-manager (scoped to this agent's config key)
+    if [[ -n "$_PROFILE_REVERB" ]] && [[ -f "$SCRIPT_DIR/effects-manager.sh" ]]; then
+        bash "$SCRIPT_DIR/effects-manager.sh" set-reverb "$_PROFILE_REVERB" "$CONFIG_KEY" 2>/dev/null || true
+    fi
+
+    # Override background music track/volume for this invocation via env vars
+    if [[ -n "$_PROFILE_MUSIC_TRACK" ]]; then
+        export AGENTVIBES_BG_TRACK="$_PROFILE_MUSIC_TRACK"
+    fi
+    if [[ -n "$_PROFILE_MUSIC_VOL" ]]; then
+        export AGENTVIBES_BG_VOLUME="$_PROFILE_MUSIC_VOL"
+    fi
+fi
+
 # Step 1: Generate TTS WITHOUT playback
 export AGENTVIBES_NO_PLAYBACK=true
-OUTPUT=$("$SCRIPT_DIR/play-tts.sh" "$TEXT" "$VOICE_OVERRIDE" 2>&1)
+export AGENTVIBES_WAV_OUTPATH="${XDG_RUNTIME_DIR:-/tmp}/agentvibes-last-wav-$$.txt"
 
-# Extract the generated file path from output
-GENERATED_FILE=$(echo "$OUTPUT" | grep "Saved to:" | sed 's/.*Saved to: //')
+# Cleanup temp outpath file on exit
+trap 'rm -f "$AGENTVIBES_WAV_OUTPATH"' EXIT
+"$SCRIPT_DIR/play-tts.sh" "$TEXT" "$VOICE_OVERRIDE"
+
+# Read the generated file path (written by play-tts-piper.sh via AGENTVIBES_WAV_OUTPATH)
+GENERATED_FILE=""
+if [[ -f "$AGENTVIBES_WAV_OUTPATH" ]]; then
+    GENERATED_FILE=$(cat "$AGENTVIBES_WAV_OUTPATH")
+    rm -f "$AGENTVIBES_WAV_OUTPATH"
+fi
+unset AGENTVIBES_WAV_OUTPATH
 
 if [[ -z "$GENERATED_FILE" ]] || [[ ! -f "$GENERATED_FILE" ]]; then
-    echo "Error: Failed to generate TTS audio" >&2
-    echo "$OUTPUT" >&2
+    echo "Error: Could not find generated audio file" >&2
     exit 1
 fi
 

package/.claude/hooks/play-tts-macos.sh

@@ -48,6 +48,17 @@ fi
 TEXT="$1"
 VOICE_OVERRIDE="$2"  # Optional: voice name (e.g., "Samantha", "Daniel")
 
+# Strip emojis, asterisks, and markdown formatting
+TEXT=$(printf '%s' "$TEXT" | perl -CSD -pe '
+  s/[\x{1F300}-\x{1F9FF}]//g;
+  s/[\x{2600}-\x{27BF}]//g;
+  s/[\x{FE00}-\x{FE0F}]//g;
+  s/[\x{200D}]//g;
+  s/[\x{2500}-\x{257F}]//g;
+  s/[\x{2580}-\x{259F}]//g;
+  s/\*+//g; s/#+\s*//g; s/`//g; s/~+//g; s/^\s*[-]\s*//g;
+')
+
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 
 # Source audio cache utilities
@@ -168,10 +179,9 @@ fi
 
 mkdir -p "$AUDIO_DIR"
 
-# Generate unique filename
-TIMESTAMP=$(date +%s)
-TEMP_FILE="$AUDIO_DIR/tts-${TIMESTAMP}.aiff"
-FINAL_FILE="$AUDIO_DIR/tts-padded-${TIMESTAMP}.wav"
+# SECURITY: Use mktemp for unpredictable filenames (#130)
+TEMP_FILE=$(mktemp "$AUDIO_DIR/tts-XXXXXX.aiff")
+FINAL_FILE=$(mktemp "$AUDIO_DIR/tts-padded-XXXXXX.wav")
 
 # @function get_speech_rate
 # @intent Determine speech rate for synthesis
@@ -226,14 +236,27 @@ if command -v ffmpeg &> /dev/null; then
   fi
 else
   # No ffmpeg - use AIFF directly (rename for consistency)
-  FINAL_FILE="$AUDIO_DIR/tts-padded-${TIMESTAMP}.aiff"
+  FINAL_FILE=$(mktemp "$AUDIO_DIR/tts-padded-XXXXXX.aiff")
   mv "$TEMP_FILE" "$FINAL_FILE"
   TEMP_FILE="$FINAL_FILE"
 fi
 
 # @function play_audio
 # @intent Play generated audio - via PulseAudio tunnel for SSH, afplay for local
-LOCK_FILE="/tmp/agentvibes-audio.lock"
+# SECURITY: Use user-isolated lock directory (#129)
+_LOCK_DIR="${XDG_RUNTIME_DIR:-/tmp/agentvibes-$(id -u)}"
+mkdir -p "$_LOCK_DIR"
+chmod 700 "$_LOCK_DIR"
+LOCK_FILE="$_LOCK_DIR/agentvibes-audio.lock"
+
+# Auto-remove stale lock files (older than 30 seconds)
+if [ -f "$LOCK_FILE" ]; then
+  _lock_mtime=$(stat -f %m "$LOCK_FILE" 2>/dev/null || echo 0)
+  _lock_age=$(( $(date +%s) - _lock_mtime ))
+  if [[ $_lock_age -gt 30 ]]; then
+    rm -f "$LOCK_FILE"
+  fi
+fi
 
 # Wait for previous audio to finish (max 30 seconds)
 for i in {1..60}; do