agentvibes 3.5.5 → 3.5.8

package/bin/agent-vibes

@@ -16,30 +16,25 @@ const __dirname = path.dirname(__filename);
 // Check if we're running in an npx temporary directory
 const isNpxExecution = __dirname.includes('_npx') || __dirname.includes('.npm');
 
-// If running via npx, we need to handle things differently
-if (isNpxExecution) {
-  const arguments_ = process.argv.slice(2);
-
-  // Use the installer for all commands
-  const installerPath = path.join(__dirname, '..', 'src', 'installer.js');
-
-  if (!fs.existsSync(installerPath)) {
-    console.error('Error: Could not find installer.js at', installerPath);
-    console.error('Current directory:', __dirname);
-    process.exit(1);
-  }
-
-  try {
-    // Security: Use execFileSync with array args to prevent command injection
-    // Arguments are passed as array elements, not string interpolation
-    execFileSync('node', [installerPath, ...arguments_], {
-      stdio: 'inherit',
-      cwd: path.dirname(__dirname),
-    });
-  } catch (error) {
-    process.exit(error.status || 1);
-  }
-} else {
-  // Local execution - use installer directly
-  import('../src/installer.js');
+// Get CLI arguments
+const arguments_ = process.argv.slice(2);
+
+// Use the installer for all commands
+const installerPath = path.join(__dirname, '..', 'src', 'installer.js');
+
+if (!fs.existsSync(installerPath)) {
+  console.error('Error: Could not find installer.js at', installerPath);
+  console.error('Current directory:', __dirname);
+  process.exit(1);
+}
+
+try {
+  // Security: Use execFileSync with array args to prevent command injection
+  // Arguments are passed as array elements, not string interpolation
+  execFileSync('node', [installerPath, ...arguments_], {
+    stdio: 'inherit',
+    cwd: isNpxExecution ? path.dirname(__dirname) : process.cwd(),
+  });
+} catch (error) {
+  process.exit(error.status || 1);
 }

package/package.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/package.json",
   "name": "agentvibes",
-  "version": "3.5.5",
+  "version": "3.5.8",
   "description": "Now your AI Agents can finally talk back! Professional TTS voice for Claude Code, Claude Desktop (via MCP), and Clawdbot with multi-provider support.",
   "homepage": "https://agentvibes.org",
   "keywords": [

package/setup-windows.ps1

@@ -330,6 +330,13 @@ Write-Ok "Installed $CopiedCount TTS scripts"
 
 Write-Section "Choose Your TTS Provider"
 
+# Check if pip is available
+$PipAvailable = $false
+try {
+    $pipTest = & pip --version 2>$null
+    if ($pipTest) { $PipAvailable = $true }
+} catch {}
+
 # Check Soprano availability
 $SopranoAvailable = $false
 try {
@@ -341,12 +348,14 @@ try {
     if ($response.StatusCode -eq 200) { $SopranoAvailable = $true }
 } catch {}
 
-# Check if pip has soprano-tts
+# Check if pip has soprano-tts (only if pip is available)
 $SopranoInstalled = $false
-try {
-    $pipResult = & pip show soprano-tts 2>$null
-    if ($pipResult) { $SopranoInstalled = $true }
-} catch {}
+if ($PipAvailable) {
+    try {
+        $pipResult = & pip show soprano-tts 2>$null
+        if ($pipResult) { $SopranoInstalled = $true }
+    } catch {}
+}
 
 if (-not $Provider) {
     Write-Host "    [1] Soprano  (Best Quality)" -ForegroundColor White
@@ -407,15 +416,54 @@ if ($Provider -eq "soprano") {
         Write-Info "Start it with: soprano-tts --share"
         Write-Info "Or run it in WSL and forward port 7860"
     } else {
-        Write-Warn "Soprano not detected"
-        Write-Host ""
-        Write-Host "    To install Soprano:" -ForegroundColor White
-        Write-Host "      pip install soprano-tts" -ForegroundColor Cyan
+        Write-Warn "Soprano TTS not detected"
         Write-Host ""
-        Write-Host "    Or use Soprano in WSL with port forwarding:" -ForegroundColor White
-        Write-Host "      ssh -L 7860:localhost:7860 your-wsl-host" -ForegroundColor Cyan
-        Write-Host ""
-        Write-Info "AgentVibes will work once Soprano is accessible on port 7860"
+
+        if (-not $PipAvailable) {
+            Write-Error "pip is not available on this system"
+            Write-Info "Please install Python 3 with pip, then run:"
+            Write-Host "      pip install soprano-tts" -ForegroundColor Cyan
+            Write-Host ""
+        } else {
+            # Offer to install Soprano
+            $installChoice = Read-Host "Would you like to install Soprano now? (y/n, default: y)"
+
+            if ($installChoice -eq "" -or $installChoice -eq "y" -or $installChoice -eq "Y") {
+                Write-Info "Installing Soprano TTS..."
+                Write-Host ""
+
+                try {
+                    & pip install soprano-tts 2>&1 | Tee-Object -Variable pipOutput | Write-Host
+
+                    # Re-check if installation succeeded
+                    $SopranoInstalled = $false
+                    try {
+                        $pipResult = & pip show soprano-tts 2>$null
+                        if ($pipResult) { $SopranoInstalled = $true }
+                    } catch {}
+
+                    if ($SopranoInstalled) {
+                        Write-Ok "Soprano TTS installed successfully!"
+                        Write-Info "Start it with: soprano-tts --share"
+                    } else {
+                        Write-Error "Installation may have failed. Please check the output above."
+                        Write-Info "You can try installing manually: pip install soprano-tts"
+                    }
+                } catch {
+                    Write-Error "Installation failed: $_"
+                    Write-Info "Please install manually: pip install soprano-tts"
+                }
+            } else {
+                Write-Host ""
+                Write-Host "    To install Soprano manually:" -ForegroundColor White
+                Write-Host "      pip install soprano-tts" -ForegroundColor Cyan
+                Write-Host ""
+                Write-Host "    Or use Soprano in WSL with port forwarding:" -ForegroundColor White
+                Write-Host "      ssh -L 7860:localhost:7860 your-wsl-host" -ForegroundColor Cyan
+                Write-Host ""
+                Write-Info "AgentVibes will work once Soprano is accessible on port 7860"
+            }
+        }
     }
 }
 

package/src/installer.js

@@ -61,6 +61,12 @@ import {
   assignVoice,
   resetBmadVoices,
 } from './commands/bmad-voices.js';
+import {
+  validateProvider,
+  getProviderInstallCommand,
+  getProviderDisplayName,
+  attemptProviderInstallation,
+} from './utils/provider-validator.js';
 
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = path.dirname(__filename);
@@ -869,6 +875,78 @@ async function collectConfiguration(options = {}) {
         return null;
       }
 
+      // Validate provider installation before accepting selection
+      console.log(chalk.gray(`\n   Checking for ${getProviderDisplayName(provider)}...`));
+      const validation = await validateProvider(provider);
+
+      if (!validation.installed) {
+        const displayName = getProviderDisplayName(provider);
+        console.log(chalk.yellow(`\n⚠️  ${validation.message}`));
+
+        const { action } = await inquirer.prompt([{
+          type: 'list',
+          name: 'action',
+          message: 'What would you like to do?',
+          choices: [
+            { name: chalk.green('Install now (recommended)'), value: 'install' },
+            { name: 'Choose a different provider', value: 'back' },
+            { name: 'I\'ll install it myself later', value: 'skip' }
+          ]
+        }]);
+
+        if (action === 'install') {
+          console.log(chalk.cyan(`\n📦 Installing ${displayName}...\n`));
+
+          // Use smart installation with fallbacks
+          const installResult = await attemptProviderInstallation(provider);
+
+          if (installResult.success && installResult.verified) {
+            // Installation succeeded AND verified
+            console.log(chalk.green(`\n✓ ${displayName} installed and verified!\n`));
+            console.log(chalk.gray(`   Method: ${installResult.command}`));
+            console.log(chalk.green(`   Status: Ready to use\n`));
+          } else if (installResult.success) {
+            // Installation command ran but verification failed
+            console.log(chalk.yellow(`\n⚠️  Installation command completed, but verification failed\n`));
+            console.log(chalk.gray(`   The installation may have been blocked by system protection (PEP 668).\n`));
+            console.log(chalk.cyan(`   Try one of these solutions:\n`));
+            console.log(chalk.gray(`   1. Use pipx (avoids system protection):\n      pipx install soprano-tts\n`));
+            console.log(chalk.gray(`   2. Create a virtual environment:\n      python3 -m venv ~/my-env\n      ~/my-env/bin/pip install soprano-tts\n`));
+
+            // Pause before returning to provider selection
+            await inquirer.prompt([{
+              type: 'confirm',
+              name: 'continue',
+              message: 'Press Enter to go back to provider selection',
+              default: true
+            }]);
+
+            return null; // Go back to provider selection
+          } else {
+            console.log(chalk.red(`\n❌ ${installResult.message}\n`));
+
+            // Pause before returning to provider selection
+            await inquirer.prompt([{
+              type: 'confirm',
+              name: 'continue',
+              message: 'Press Enter to go back to provider selection',
+              default: true
+            }]);
+
+            return null; // Go back to provider selection
+          }
+        } else if (action === 'back') {
+          // Go back to provider selection
+          return null;
+        } else if (action === 'skip') {
+          console.log(chalk.yellow(`\n⚠️  No problem! You can set it up anytime with:\n   ${getProviderInstallCommand(provider)}\n`));
+        }
+      } else {
+        // Provider detected and ready to use
+        const displayName = getProviderDisplayName(provider);
+        console.log(chalk.green(`\n✓ ${displayName} Detected and selected!\n`));
+      }
+
       config.provider = provider;
 
       // Handle special receiver mode for Termux
@@ -1602,20 +1680,17 @@ function showWelcome() {
  * Shown during install and update commands
  */
 function getReleaseInfoBoxen() {
-  return chalk.cyan.bold('📦 AgentVibes v3.5.5 - Native Windows Support: Soprano, Piper & SAPI\n\n') +
+  return chalk.cyan.bold('📦 AgentVibes v3.5.8 - Provider Validation Security & UX Improvements\n\n') +
     chalk.green.bold('🎙️ WHAT\'S NEW:\n\n') +
-    chalk.cyan('AgentVibes v3.5.5 brings native Windows support with three TTS providers (Soprano neural,\n') +
-    chalk.cyan('Piper offline, Windows SAPI), background music selection from 16 genre tracks, reverb effects\n') +
-    chalk.cyan('via ffmpeg, and verbosity control. Includes 8 Windows hook scripts, beautiful PowerShell\n') +
-    chalk.cyan('installer with figlet banner, and 46 new Windows-specific unit tests.\n\n') +
-    chalk.yellow('🙏 Thanks to @nathanchase (Soprano), @alexeyv (Windows SAPI), @bmadcode (BMAD Method)!\n\n') +
+    chalk.cyan('Critical security and reliability update for provider detection. Fixes command injection\n') +
+    chalk.cyan('vulnerabilities, prevents HOME directory injection attacks, and improves UX with explicit\n') +
+    chalk.cyan('provider detection messaging. Soprano TTS installed via pipx now correctly detected.\n\n') +
     chalk.green.bold('✨ KEY HIGHLIGHTS:\n\n') +
-    chalk.gray('   🖥️ Native Windows TTS - Soprano, Piper, and Windows SAPI providers. No WSL needed!\n') +
-    chalk.gray('   🎵 Background Music - 16 genre tracks (Bachata, Flamenco, Bossa Nova, City Pop, and more)\n') +
-    chalk.gray('   🎛️ Reverb & Effects - 5 reverb levels via ffmpeg aecho filter\n') +
-    chalk.gray('   🔊 Verbosity Control - High, Medium, or Low transparency levels\n') +
-    chalk.gray('   🎨 Beautiful Installer - Figlet banner, directory explanations, provider detection\n') +
-    chalk.gray('   🧪 93/93 Tests Passing - 46 Windows + 47 cross-platform\n\n') +
+    chalk.gray('   🔐 Security Fixes - Fixed command injection, HOME injection prevention, path traversal\n') +
+    chalk.gray('   ✅ Provider Detection - Soprano via pipx now correctly detected\n') +
+    chalk.gray('   💬 Better Messaging - Explicit detection confirmation, detailed error messages\n') +
+    chalk.gray('   🧪 Enhanced Tests - Verification of actual detection values\n') +
+    chalk.gray('   🐛 Debug Support - Added logging for troubleshooting\n\n') +
     chalk.gray('📖 Full Release Notes: RELEASE_NOTES.md\n') +
     chalk.gray('🌐 Website: https://agentvibes.org\n') +
     chalk.gray('📦 Repository: https://github.com/paulpreibisch/AgentVibes\n\n') +