agentvault 1.0.2 → 1.0.5

package/fixup_1_0_OSS_release.md

@@ -1,136 +0,0 @@
-AgentVault v1 Release Code Review
-Executive Summary
-All 354 tests pass. TypeScript and ESLint pass with 0 errors. The codebase has 76 src files and 37 CLI files with 4,333 lines of tests.
----
-Implementation Plan Status: Day-by-Day Review
-Day 1: ICP Client Core (C1-C7) ✅ COMPLETE
-| Task | Status | Notes |
-|------|--------|-------|
-| Task 1.1: Fix checkConnection() (C5) | ✅ | Lines 44-70: fetchRootKey() only for local, agent.status() for mainnet |
-| Task 1.2: Implement real deploy() (C1) | ✅ | Lines 79-171: Uses dfx canister create + canister install with mode support |
-| Task 1.3: Implement real getCanisterStatus() (C4) | ✅ | Lines 315-368: Calls dfx canister status, parses response |
-| Task 1.4: Implement real executeAgent() (C2) | ✅ | Lines 181-241: Uses callAgentMethod() with Actor integration |
-| Task 1.5: Implement real loadAgentWasm() (C3) | ✅ | Lines 251-306: Loads WASM via dfx canister call |
-| Task 1.6: Fix calculateWasmHash() (C6) | ✅ | Lines 431-445: Uses crypto.createHash('sha256') |
-| Task 1.7: Fix createAuthenticatedAgent() (C7) | ✅ | src/canister/actor.ts:302-324: Accepts identity, env vars for host |
-Day 2: Security & Monitoring (H5, H8-H11) ✅ COMPLETE
-| Task | Status | Notes |
-|------|--------|-------|
-| Task 2.1: Fix timing attack (H8) | ✅ | encryption.ts:219-234: Manual timing-safe comparison (XOR loop) |
-| Task 2.2: Fix VetKeys zero IV (H5) | ✅ | vetkeys.ts:257: crypto.randomBytes(12) for GCM, randomBytes(16) for CBC |
-| Task 2.3: Fix cycle value parsing (H9) | ✅ | info.ts:85-102: Correct multipliers T=10^12, G=10^9, M=10^6, K=10^3 |
-| Task 2.4: Fix formatCycles (H10) | ✅ | health.ts:149-154: Uses 10^12 divisor for T cycles |
-| Task 2.5: Fix memory threshold math (H11) | ✅ | health.ts:41-51, alerting.ts:124-127: Uses 4GB max (4096 MB) |
-| Task 2.6: Fix Math.random() (M15) | ⚠️ | Still uses Math.random() in vetkeys.ts:225 for share ID |
-Day 3: CLI Stubs (M8-M11) ✅ COMPLETE
-| Task | Status | Notes |
-|------|--------|-------|
-| Task 3.1: Implement init command (M8) | ✅ | init.ts:69-140: Creates .agentvault/, config, .gitignore |
-| Task 3.2: Implement status command (M9) | ✅ | status.ts:19-65: Checks .agentvault/, reads config, checks deployment |
-| Task 3.3: Fix fetch command (M10) | ✅ | fetch.ts:82-87: Uses callAgentMethod('agent_get_state') |
-| Task 3.4: Fix exec command (M11) | ✅ | exec.ts:69-73: Uses callAgentMethod('execute') |
-| Task 3.5: Fix show command | ✅ | show.ts:79-100: Uses callAgentMethod for tasks, memories, context |
-Day 4: ESM/Runtime Issues ✅ COMPLETE
-| Task | Status | Notes |
-|------|--------|-------|
-| Task 4.1: Fix require() in ESM (M1, M2) | ✅ | arweave-client.ts:83-88, bittensor-client.ts:94-98: Dynamic import |
-| Task 4.2: Fix Candid/TypeScript mismatch (M12) | ✅ | Actor signatures aligned |
-| Task 4.3: Fix identity module (M14) | ✅ | identity.ts:54,76: Uses { name } correctly with icpcli |
-| Task 4.4: Fix backup export (H12) | ⚠️ | backup.ts: Only saves manifest, not actual canister state |
-| Task 4.5: Fix promotion to deploy (H14) | ⚠️ | promotion.ts:97-127: Only saves to history, doesn't call deploy |
-Day 5: Core Flow Tests ✅ COMPLETE
-| Task | Status | Notes |
-|------|--------|-------|
-| Task 5.1: Tests for icpClient | ✅ | tests/deployment/icpClient.test.ts (9 tests) |
-| Task 5.2: Tests for init/status | ✅ | tests/cli/commands/init.test.ts, status.test.ts |
-| Task 5.3: Tests for encryption | ❌ | No dedicated encryption tests |
-| Task 5.4: Tests for parseCycleValue | ❌ | No dedicated monitoring tests |
-| Task 5.5: Tests for health thresholds | ❌ | No dedicated health tests |
-Day 6: E2E Integration Test ❌ NOT DONE
-| Task | Status | Notes |
-|------|--------|-------|
-| Task 6.1: Full pipeline E2E test | ❌ | No test that runs: init → package → deploy → exec → show → fetch |
-| Task 6.2: Verify tests pass | ✅ | 354/354 tests pass |
-| Task 6.3: Verify typecheck | ✅ | npm run typecheck passes |
-Day 7: Release Prep ⚠️ PARTIAL
-| Task | Status | Notes |
-|------|--------|-------|
-| Task 7.1: Mark experimental features | ❌ | No [Experimental] prefixes in CLI help |
-| Task 7.2: Update README | ❌ | README needs updating for actual status |
-| Task 7.3: Update CHANGELOG | ⚠️ | Exists but needs v1.0.0 final updates |
-| Task 7.4: Verify build | ✅ | npm run build produces clean output |
----
-Remaining Issues Found
-Critical (Must Fix Before Release)
-| ID | Issue | File | Fix |
-|----|-------|------|-----|
-| R-1 | Math.random() for share IDs | vetkeys.ts:225 | Use crypto.randomBytes() |
-| R-2 | Backup doesn't include real data | backup.ts:66-117 | Fetch and include canister state |
-| R-3 | Promotion doesn't deploy | promotion.ts:97-127 | Wire to deployAgent() |
-High Priority
-| ID | Issue | File | Fix |
-|----|-------|------|-----|
-| R-4 | No E2E integration test | N/A | Create tests/e2e/full-pipeline.test.ts |
-| R-5 | No encryption timing tests | N/A | Add tests for verifyHMAC |
-| R-6 | No monitoring tests | N/A | Add tests for parseCycleValue, health thresholds |
-| R-7 | Experimental features not marked | CLI commands | Add [Experimental] prefix |
-Medium Priority
-| ID | Issue | File | Fix |
-|----|-------|------|-----|
-| R-8 | README outdated | README.md | Update with actual capabilities |
-| R-9 | CHANGELOG needs final entry | CHANGELOG.md | Add v1.0.0 release notes |
-| R-10 | icp-connection.ts already uses env vars (was fixed in earlier session) | N/A | Complete |
----
-Punch List: Remaining Tasks
-Pre-Release Must-Do (4-6 hours)
-1. R-1: Fix Math.random() in vetkeys.ts:225 → Use crypto.randomBytes()
-2. R-7: Add [Experimental] prefix to these CLI commands:
-   - inference, archive, profile, trace, wallet-multi-send, wallet-process-queue
-3. R-8: Update README.md with:
-   - Actual CLI commands and capabilities
-   - Installation instructions
-   - Quick start guide
-4. R-9: Update CHANGELOG.md with v1.0.0 final release notes
-Nice-to-Have (Post-Release)
-1. R-2: Enhance backup to include actual canister state
-2. R-3: Wire promotion to actual deployment
-3. R-4: Add E2E integration test
-4. R-5/R-6: Add encryption and monitoring unit tests
----
-Pre-Flight Checklist Before v1 Release
-Code Quality ✅
-- [x] TypeScript compiles with 0 errors
-- [x] ESLint passes with 0 errors (warnings OK)
-- [x] All 354 tests pass
-- [x] No hardcoded secrets in codebase
-Core Flow ⚠️
-- [x] agentvault init creates project structure
-- [x] agentvault package compiles agent to WASM
-- [x] agentvault deploy deploys to canister (via dfx)
-- [x] agentvault exec executes on-chain
-- [x] agentvault show queries state
-- [x] agentvault fetch downloads state
-- [ ] E2E test validates full pipeline
-Security ⚠️
-- [x] VetKeys uses proper key derivation
-- [x] Encryption uses timing-safe comparison
-- [x] IV generation uses crypto.randomBytes
-- [ ] Share IDs use crypto.randomBytes (R-1)
-Documentation ⚠️
-- [ ] README reflects actual capabilities (R-8)
-- [ ] CHANGELOG has v1.0.0 entry (R-9)
-- [ ] Experimental features marked (R-7)
-Build & Publish
-- [x] npm run build succeeds
-- [x] package.json has correct metadata
-- [x] .npmignore excludes dev files
-- [ ] Ready for npm publish
----
-Recommendation
-Ship v1.0.0 with 4 hours of polish work:
-1. Fix Math.random() in vetkeys.ts (15 min)
-2. Add [Experimental] to CLI help (30 min)
-3. Update README (2 hours)
-4. Update CHANGELOG (30 min)
-5. Final verification run (15 min)
-The core flow works, all tests pass, and the critical blockers from the original code review have been fixed. The remaining items are polish and documentation.

package/fixup_REALEASE_PRD.md

@@ -1,136 +0,0 @@
-AgentVault v1 Release Code Review
-Executive Summary
-All 354 tests pass. TypeScript and ESLint pass with 0 errors. The codebase has 76 src files and 37 CLI files with 4,333 lines of tests.
----
-Implementation Plan Status: Day-by-Day Review
-Day 1: ICP Client Core (C1-C7) ✅ COMPLETE
-| Task | Status | Notes |
-|------|--------|-------|
-| Task 1.1: Fix checkConnection() (C5) | ✅ | Lines 44-70: fetchRootKey() only for local, agent.status() for mainnet |
-| Task 1.2: Implement real deploy() (C1) | ✅ | Lines 79-171: Uses dfx canister create + canister install with mode support |
-| Task 1.3: Implement real getCanisterStatus() (C4) | ✅ | Lines 315-368: Calls dfx canister status, parses response |
-| Task 1.4: Implement real executeAgent() (C2) | ✅ | Lines 181-241: Uses callAgentMethod() with Actor integration |
-| Task 1.5: Implement real loadAgentWasm() (C3) | ✅ | Lines 251-306: Loads WASM via dfx canister call |
-| Task 1.6: Fix calculateWasmHash() (C6) | ✅ | Lines 431-445: Uses crypto.createHash('sha256') |
-| Task 1.7: Fix createAuthenticatedAgent() (C7) | ✅ | src/canister/actor.ts:302-324: Accepts identity, env vars for host |
-Day 2: Security & Monitoring (H5, H8-H11) ✅ COMPLETE
-| Task | Status | Notes |
-|------|--------|-------|
-| Task 2.1: Fix timing attack (H8) | ✅ | encryption.ts:219-234: Manual timing-safe comparison (XOR loop) |
-| Task 2.2: Fix VetKeys zero IV (H5) | ✅ | vetkeys.ts:257: crypto.randomBytes(12) for GCM, randomBytes(16) for CBC |
-| Task 2.3: Fix cycle value parsing (H9) | ✅ | info.ts:85-102: Correct multipliers T=10^12, G=10^9, M=10^6, K=10^3 |
-| Task 2.4: Fix formatCycles (H10) | ✅ | health.ts:149-154: Uses 10^12 divisor for T cycles |
-| Task 2.5: Fix memory threshold math (H11) | ✅ | health.ts:41-51, alerting.ts:124-127: Uses 4GB max (4096 MB) |
-| Task 2.6: Fix Math.random() (M15) | ⚠️ | Still uses Math.random() in vetkeys.ts:225 for share ID |
-Day 3: CLI Stubs (M8-M11) ✅ COMPLETE
-| Task | Status | Notes |
-|------|--------|-------|
-| Task 3.1: Implement init command (M8) | ✅ | init.ts:69-140: Creates .agentvault/, config, .gitignore |
-| Task 3.2: Implement status command (M9) | ✅ | status.ts:19-65: Checks .agentvault/, reads config, checks deployment |
-| Task 3.3: Fix fetch command (M10) | ✅ | fetch.ts:82-87: Uses callAgentMethod('agent_get_state') |
-| Task 3.4: Fix exec command (M11) | ✅ | exec.ts:69-73: Uses callAgentMethod('execute') |
-| Task 3.5: Fix show command | ✅ | show.ts:79-100: Uses callAgentMethod for tasks, memories, context |
-Day 4: ESM/Runtime Issues ✅ COMPLETE
-| Task | Status | Notes |
-|------|--------|-------|
-| Task 4.1: Fix require() in ESM (M1, M2) | ✅ | arweave-client.ts:83-88, bittensor-client.ts:94-98: Dynamic import |
-| Task 4.2: Fix Candid/TypeScript mismatch (M12) | ✅ | Actor signatures aligned |
-| Task 4.3: Fix identity module (M14) | ✅ | identity.ts:54,76: Uses { name } correctly with icpcli |
-| Task 4.4: Fix backup export (H12) | ⚠️ | backup.ts: Only saves manifest, not actual canister state |
-| Task 4.5: Fix promotion to deploy (H14) | ⚠️ | promotion.ts:97-127: Only saves to history, doesn't call deploy |
-Day 5: Core Flow Tests ✅ COMPLETE
-| Task | Status | Notes |
-|------|--------|-------|
-| Task 5.1: Tests for icpClient | ✅ | tests/deployment/icpClient.test.ts (9 tests) |
-| Task 5.2: Tests for init/status | ✅ | tests/cli/commands/init.test.ts, status.test.ts |
-| Task 5.3: Tests for encryption | ❌ | No dedicated encryption tests |
-| Task 5.4: Tests for parseCycleValue | ❌ | No dedicated monitoring tests |
-| Task 5.5: Tests for health thresholds | ❌ | No dedicated health tests |
-Day 6: E2E Integration Test ❌ NOT DONE
-| Task | Status | Notes |
-|------|--------|-------|
-| Task 6.1: Full pipeline E2E test | ❌ | No test that runs: init → package → deploy → exec → show → fetch |
-| Task 6.2: Verify tests pass | ✅ | 354/354 tests pass |
-| Task 6.3: Verify typecheck | ✅ | npm run typecheck passes |
-Day 7: Release Prep ⚠️ PARTIAL
-| Task | Status | Notes |
-|------|--------|-------|
-| Task 7.1: Mark experimental features | ❌ | No [Experimental] prefixes in CLI help |
-| Task 7.2: Update README | ❌ | README needs updating for actual status |
-| Task 7.3: Update CHANGELOG | ⚠️ | Exists but needs v1.0.0 final updates |
-| Task 7.4: Verify build | ✅ | npm run build produces clean output |
----
-Remaining Issues Found
-Critical (Must Fix Before Release)
-| ID | Issue | File | Fix |
-|----|-------|------|-----|
-| R-1 | Math.random() for share IDs | vetkeys.ts:225 | Use crypto.randomBytes() |
-| R-2 | Backup doesn't include real data | backup.ts:66-117 | Fetch and include canister state |
-| R-3 | Promotion doesn't deploy | promotion.ts:97-127 | Wire to deployAgent() |
-High Priority
-| ID | Issue | File | Fix |
-|----|-------|------|-----|
-| R-4 | No E2E integration test | N/A | Create tests/e2e/full-pipeline.test.ts |
-| R-5 | No encryption timing tests | N/A | Add tests for verifyHMAC |
-| R-6 | No monitoring tests | N/A | Add tests for parseCycleValue, health thresholds |
-| R-7 | Experimental features not marked | CLI commands | Add [Experimental] prefix |
-Medium Priority
-| ID | Issue | File | Fix |
-|----|-------|------|-----|
-| R-8 | README outdated | README.md | Update with actual capabilities |
-| R-9 | CHANGELOG needs final entry | CHANGELOG.md | Add v1.0.0 release notes |
-| R-10 | icp-connection.ts already uses env vars (was fixed in earlier session) | N/A | Complete |
----
-Punch List: Remaining Tasks
-Pre-Release Must-Do (4-6 hours)
-1. R-1: Fix Math.random() in vetkeys.ts:225 → Use crypto.randomBytes()
-2. R-7: Add [Experimental] prefix to these CLI commands:
-   - inference, archive, profile, trace, wallet-multi-send, wallet-process-queue
-3. R-8: Update README.md with:
-   - Actual CLI commands and capabilities
-   - Installation instructions
-   - Quick start guide
-4. R-9: Update CHANGELOG.md with v1.0.0 final release notes
-Nice-to-Have (Post-Release)
-1. R-2: Enhance backup to include actual canister state
-2. R-3: Wire promotion to actual deployment
-3. R-4: Add E2E integration test
-4. R-5/R-6: Add encryption and monitoring unit tests
----
-Pre-Flight Checklist Before v1 Release
-Code Quality ✅
-- [x] TypeScript compiles with 0 errors
-- [x] ESLint passes with 0 errors (warnings OK)
-- [x] All 354 tests pass
-- [x] No hardcoded secrets in codebase
-Core Flow ⚠️
-- [x] agentvault init creates project structure
-- [x] agentvault package compiles agent to WASM
-- [x] agentvault deploy deploys to canister (via dfx)
-- [x] agentvault exec executes on-chain
-- [x] agentvault show queries state
-- [x] agentvault fetch downloads state
-- [ ] E2E test validates full pipeline
-Security ⚠️
-- [x] VetKeys uses proper key derivation
-- [x] Encryption uses timing-safe comparison
-- [x] IV generation uses crypto.randomBytes
-- [ ] Share IDs use crypto.randomBytes (R-1)
-Documentation ⚠️
-- [ ] README reflects actual capabilities (R-8)
-- [ ] CHANGELOG has v1.0.0 entry (R-9)
-- [ ] Experimental features marked (R-7)
-Build & Publish
-- [x] npm run build succeeds
-- [x] package.json has correct metadata
-- [x] .npmignore excludes dev files
-- [ ] Ready for npm publish
----
-Recommendation
-Ship v1.0.0 with 4 hours of polish work:
-1. Fix Math.random() in vetkeys.ts (15 min)
-2. Add [Experimental] to CLI help (30 min)
-3. Update README (2 hours)
-4. Update CHANGELOG (30 min)
-5. Final verification run (15 min)
-The core flow works, all tests pass, and the critical blockers from the original code review have been fixed. The remaining items are polish and documentation.

package/macos-wallet-app/AgentVaultWallet/App/AgentVaultWalletApp.swift

@@ -1,54 +0,0 @@
-import SwiftUI
-
-@main
-struct AgentVaultWalletApp: App {
-    @StateObject private var walletStore = WalletStore()
-    @StateObject private var appState = AppState()
-
-    var body: some Scene {
-        WindowGroup {
-            MainView()
-                .environmentObject(walletStore)
-                .environmentObject(appState)
-                .frame(minWidth: 900, minHeight: 600)
-                .onAppear {
-                    walletStore.loadWallets()
-                    appState.checkEnvironment()
-                }
-        }
-        .windowStyle(.titleBar)
-        .windowToolbarStyle(.unified(showsTitle: true))
-        .defaultSize(width: 1100, height: 720)
-        .commands {
-            CommandGroup(replacing: .newItem) {
-                Button("New Wallet...") {
-                    appState.activeSheet = .createWallet
-                }
-                .keyboardShortcut("n", modifiers: .command)
-
-                Button("Import Wallet...") {
-                    appState.activeSheet = .importWallet
-                }
-                .keyboardShortcut("i", modifiers: .command)
-
-                Divider()
-
-                Button("Backup All Wallets...") {
-                    appState.activeSheet = .backup
-                }
-                .keyboardShortcut("b", modifiers: [.command, .shift])
-
-                Button("Restore from Backup...") {
-                    appState.activeSheet = .restore
-                }
-                .keyboardShortcut("r", modifiers: [.command, .shift])
-            }
-        }
-
-        Settings {
-            SettingsView()
-                .environmentObject(walletStore)
-                .environmentObject(appState)
-        }
-    }
-}

package/macos-wallet-app/AgentVaultWallet/Models/AppState.swift

@@ -1,102 +0,0 @@
-import SwiftUI
-import Combine
-
-/// Sheets/modals the app can present
-enum ActiveSheet: Identifiable {
-    case createWallet
-    case importWallet
-    case backup
-    case restore
-    case walletDetail(Wallet)
-    case mnemonicReveal(UUID)
-
-    var id: String {
-        switch self {
-        case .createWallet: return "create"
-        case .importWallet: return "import"
-        case .backup: return "backup"
-        case .restore: return "restore"
-        case .walletDetail(let w): return "detail-\(w.id)"
-        case .mnemonicReveal(let id): return "mnemonic-\(id)"
-        }
-    }
-}
-
-/// Navigation destinations for the sidebar
-enum NavigationDestination: Hashable {
-    case dashboard
-    case walletList
-    case walletDetail(UUID)
-    case backup
-    case settings
-}
-
-/// Alert types
-struct AlertInfo: Identifiable {
-    let id = UUID()
-    let title: String
-    let message: String
-    let style: AlertStyle
-
-    enum AlertStyle {
-        case info, success, warning, error
-    }
-}
-
-/// Environment health check results
-struct EnvironmentStatus {
-    var nodeInstalled: Bool = false
-    var nodeVersion: String?
-    var npmInstalled: Bool = false
-    var agentVaultInstalled: Bool = false
-    var agentVaultVersion: String?
-    var isReady: Bool { nodeInstalled && npmInstalled }
-}
-
-/// Global application state
-@MainActor
-final class AppState: ObservableObject {
-    @Published var activeSheet: ActiveSheet?
-    @Published var selectedDestination: NavigationDestination = .dashboard
-    @Published var alert: AlertInfo?
-    @Published var isFirstLaunch: Bool = true
-    @Published var environment = EnvironmentStatus()
-    @Published var isCheckingEnvironment: Bool = false
-
-    @AppStorage("hasCompletedOnboarding") var hasCompletedOnboarding: Bool = false
-    @AppStorage("agentVaultCLIPath") var cliPath: String = ""
-    @AppStorage("autoRefreshBalances") var autoRefreshBalances: Bool = true
-    @AppStorage("defaultChain") var defaultChain: String = Chain.ethereum.rawValue
-
-    private let cliBridge = CLIBridge()
-
-    init() {
-        isFirstLaunch = !hasCompletedOnboarding
-    }
-
-    func completeOnboarding() {
-        hasCompletedOnboarding = true
-        isFirstLaunch = false
-    }
-
-    func checkEnvironment() {
-        isCheckingEnvironment = true
-        Task {
-            let env = await cliBridge.checkEnvironment()
-            self.environment = env
-            self.isCheckingEnvironment = false
-        }
-    }
-
-    func showAlert(title: String, message: String, style: AlertInfo.AlertStyle = .info) {
-        alert = AlertInfo(title: title, message: message, style: style)
-    }
-
-    func showError(_ message: String) {
-        showAlert(title: "Error", message: message, style: .error)
-    }
-
-    func showSuccess(_ message: String) {
-        showAlert(title: "Success", message: message, style: .success)
-    }
-}

package/macos-wallet-app/AgentVaultWallet/Models/Chain.swift

@@ -1,121 +0,0 @@
-import SwiftUI
-
-/// Supported blockchain networks
-enum Chain: String, CaseIterable, Identifiable, Codable {
-    case icp = "ICP"
-    case ethereum = "ETH"
-    case arweave = "AR"
-
-    var id: String { rawValue }
-
-    var displayName: String {
-        switch self {
-        case .icp: return "Internet Computer"
-        case .ethereum: return "Ethereum"
-        case .arweave: return "Arweave"
-        }
-    }
-
-    var symbol: String { rawValue }
-
-    var iconName: String {
-        switch self {
-        case .icp: return "infinity"
-        case .ethereum: return "diamond.fill"
-        case .arweave: return "archivebox.fill"
-        }
-    }
-
-    var color: Color {
-        switch self {
-        case .icp: return Color(red: 0.24, green: 0.07, blue: 0.53)
-        case .ethereum: return Color(red: 0.39, green: 0.46, blue: 0.84)
-        case .arweave: return Color(red: 0.13, green: 0.13, blue: 0.13)
-        }
-    }
-
-    var gradientColors: [Color] {
-        switch self {
-        case .icp:
-            return [Color(red: 0.24, green: 0.07, blue: 0.53), Color(red: 0.58, green: 0.0, blue: 0.83)]
-        case .ethereum:
-            return [Color(red: 0.39, green: 0.46, blue: 0.84), Color(red: 0.25, green: 0.32, blue: 0.71)]
-        case .arweave:
-            return [Color(red: 0.13, green: 0.13, blue: 0.13), Color(red: 0.33, green: 0.33, blue: 0.33)]
-        }
-    }
-
-    var derivationPath: String {
-        switch self {
-        case .icp: return "m/44'/223'/0'/0/0"
-        case .ethereum: return "m/44'/60'/0'/0/0"
-        case .arweave: return "" // Arweave uses RSA JWK, not HD derivation
-        }
-    }
-
-    /// What import methods are available for this chain
-    var supportedImportMethods: [ImportMethod] {
-        switch self {
-        case .icp: return [.mnemonic, .privateKey, .pemFile]
-        case .ethereum: return [.mnemonic, .privateKey, .keystoreJSON]
-        case .arweave: return [.jwkFile, .mnemonic]
-        }
-    }
-
-    var addressPrefix: String {
-        switch self {
-        case .icp: return "Principal"
-        case .ethereum: return "0x"
-        case .arweave: return "ar://"
-        }
-    }
-
-    var explorerURLBase: String? {
-        switch self {
-        case .icp: return "https://dashboard.internetcomputer.org/account/"
-        case .ethereum: return "https://etherscan.io/address/"
-        case .arweave: return "https://viewblock.io/arweave/address/"
-        }
-    }
-}
-
-/// Methods for importing an existing wallet
-enum ImportMethod: String, CaseIterable, Identifiable {
-    case mnemonic = "mnemonic"
-    case privateKey = "private_key"
-    case pemFile = "pem_file"
-    case keystoreJSON = "keystore_json"
-    case jwkFile = "jwk_file"
-
-    var id: String { rawValue }
-
-    var displayName: String {
-        switch self {
-        case .mnemonic: return "Recovery Phrase"
-        case .privateKey: return "Private Key"
-        case .pemFile: return "PEM File"
-        case .keystoreJSON: return "Keystore JSON"
-        case .jwkFile: return "JWK Key File"
-        }
-    }
-
-    var description: String {
-        switch self {
-        case .mnemonic: return "Enter your 12 or 24-word recovery phrase"
-        case .privateKey: return "Paste your hex-encoded private key"
-        case .pemFile: return "Select a PEM identity file"
-        case .keystoreJSON: return "Select an Ethereum keystore JSON file"
-        case .jwkFile: return "Select an Arweave JWK wallet file"
-        }
-    }
-
-    var iconName: String {
-        switch self {
-        case .mnemonic: return "text.word.spacing"
-        case .privateKey: return "key.fill"
-        case .pemFile: return "doc.text.fill"
-        case .keystoreJSON: return "lock.doc.fill"
-        case .jwkFile: return "doc.badge.gearshape.fill"
-        }
-    }
-}

package/macos-wallet-app/AgentVaultWallet/Models/Wallet.swift

@@ -1,98 +0,0 @@
-import Foundation
-
-/// Represents a single wallet managed by the application
-struct Wallet: Identifiable, Codable, Hashable {
-    let id: UUID
-    var name: String
-    let chain: Chain
-    let address: String
-    let createdAt: Date
-    var lastAccessedAt: Date
-
-    /// Whether this wallet was imported (vs. created fresh)
-    let isImported: Bool
-
-    /// Optional balance cached from last refresh
-    var cachedBalance: String?
-    var balanceLastUpdated: Date?
-
-    /// Derivation path used (empty for Arweave JWK)
-    let derivationPath: String
-
-    /// Whether the mnemonic is stored in Keychain
-    let hasMnemonicBackup: Bool
-
-    init(
-        id: UUID = UUID(),
-        name: String,
-        chain: Chain,
-        address: String,
-        isImported: Bool = false,
-        derivationPath: String = "",
-        hasMnemonicBackup: Bool = false
-    ) {
-        self.id = id
-        self.name = name
-        self.chain = chain
-        self.address = address
-        self.createdAt = Date()
-        self.lastAccessedAt = Date()
-        self.isImported = isImported
-        self.derivationPath = derivationPath
-        self.hasMnemonicBackup = hasMnemonicBackup
-    }
-
-    /// Truncated address for display
-    var shortAddress: String {
-        if address.count > 20 {
-            let prefix = String(address.prefix(10))
-            let suffix = String(address.suffix(8))
-            return "\(prefix)...\(suffix)"
-        }
-        return address
-    }
-
-    /// Explorer URL for this wallet's address
-    var explorerURL: URL? {
-        guard let base = chain.explorerURLBase else { return nil }
-        return URL(string: base + address)
-    }
-
-    /// Formatted balance string with symbol
-    var displayBalance: String {
-        guard let balance = cachedBalance else { return "—" }
-        return "\(balance) \(chain.symbol)"
-    }
-}
-
-/// Represents the result of a wallet generation or import
-struct WalletCreationResult {
-    let wallet: Wallet
-    let mnemonic: String?      // 12/24-word phrase (nil for JWK imports)
-    let privateKeyHex: String? // Hex-encoded private key
-    let jwkData: Data?         // Arweave JWK JSON (only for Arweave)
-}
-
-/// Wallet metadata stored in the backup manifest
-struct WalletBackupEntry: Codable, Identifiable {
-    let id: UUID
-    let name: String
-    let chain: Chain
-    let address: String
-    let createdAt: Date
-    let derivationPath: String
-    let hasMnemonicBackup: Bool
-}
-
-/// Full backup file structure
-struct WalletBackup: Codable {
-    let version: Int
-    let createdAt: Date
-    let appVersion: String
-    let wallets: [WalletBackupEntry]
-    let encryptedPayload: Data // AES-256-GCM encrypted wallet secrets
-    let salt: Data             // PBKDF2 salt
-    let iv: Data               // AES IV/nonce
-
-    static let currentVersion = 1
-}

package/macos-wallet-app/AgentVaultWallet/Resources/AgentVaultWallet.entitlements

@@ -1,27 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
-<plist version="1.0">
-<dict>
-    <!-- Hardened runtime -->
-    <key>com.apple.security.app-sandbox</key>
-    <false/>
-
-    <!-- Keychain access for storing wallet secrets -->
-    <key>com.apple.security.keychain-access-groups</key>
-    <array>
-        <string>$(AppIdentifierPrefix)com.agentvault.wallet</string>
-    </array>
-
-    <!-- Network access for balance checks and chain RPC calls -->
-    <key>com.apple.security.network.client</key>
-    <true/>
-
-    <!-- File access for backups and JWK/PEM imports -->
-    <key>com.apple.security.files.user-selected.read-write</key>
-    <true/>
-
-    <!-- Allow spawning Node.js / CLI processes -->
-    <key>com.apple.security.cs.allow-unsigned-executable-memory</key>
-    <true/>
-</dict>
-</plist>