agentsys 5.8.5 → 5.9.0

package/lib/patterns/cli-enhancers.js

@@ -6,11 +6,7 @@
  * Functions gracefully degrade when tools are not available.
  *
  * Supported languages: javascript, typescript, python, rust, go
- */
-
-const { truncate } = require('../cross-platform');
-
-/**
+ *
  * @module patterns/cli-enhancers
  * @author Avi Fenesh
  * @license MIT
@@ -384,7 +380,7 @@ function runDuplicateDetection(repoPath, options = {}) {
             secondLine: dup.secondFile?.start || 0,
             lines: dup.lines || 0,
             tokens: dup.tokens || 0,
-            fragment: truncate(dup.fragment || '', 100)
+            fragment: dup.fragment?.substring(0, 100) || ''
           });
         }
       }

package/lib/patterns/pipeline.js

@@ -7,11 +7,7 @@
  * - Phase 3 (LLM handoff): certainty-tagged findings for agent review
  *
  * Inherits modes from deslop: report (analyze only) vs apply (fix issues)
- */
-
-const { truncate } = require('../cross-platform');
-
-/**
+ *
  * @module patterns/pipeline
  * @author Avi Fenesh
  * @license MIT
@@ -360,7 +356,7 @@ function runPhase1(repoPath, targetFiles, language, fileContents) {
               certainty: CERTAINTY.HIGH,
               description: pattern.description,
               autoFix: pattern.autoFix,
-              content: truncate(line.trim(), 100),
+              content: line.trim().substring(0, 100),
               phase: 1
             });
           }
@@ -661,7 +657,7 @@ async function runMultiPassAnalyzers(repoPath, targetFiles, fileContents) {
           certainty: CERTAINTY.MEDIUM,
           description: `${shotgunPattern.description}: ${v.files.length} files change together ${v.count} times`,
           autoFix: shotgunPattern.autoFix,
-          content: truncate(v.files.join(', '), 100),
+          content: v.files.join(', ').substring(0, 100),
           phase: 1,
           details: { files: v.files, changeCount: v.count }
         });

package/lib/patterns/slop-analyzers.js

@@ -8,8 +8,6 @@
  * @license MIT
  */
 
-const { truncate } = require('../cross-platform');
-
 /**
  * Analyze JSDoc-to-function ratio to detect excessive documentation
  *
@@ -1881,7 +1879,7 @@ function analyzeDeadCode(content, options = {}) {
         line: j + 1, // 1-indexed
         terminationType: terminationType,
         terminationLine: i + 1,
-        content: truncate(nextTrimmed, 50),
+        content: nextTrimmed.substring(0, 50) + (nextTrimmed.length > 50 ? '...' : ''),
         severity: 'high'
       });
 

package/lib/platform/detect-platform.js

@@ -11,7 +11,6 @@
  */
 
 const fs = require('fs');
-const { truncate } = require('../cross-platform');
 const path = require('path');
 const { exec } = require('child_process');
 const { promisify } = require('util');
@@ -85,7 +84,7 @@ function withTimeout(promise, timeoutMs = DEFAULT_ASYNC_TIMEOUT_MS, operation =
  * @returns {Promise<{stdout: string, stderr: string}>}
  */
 async function execWithTimeout(cmd, options = {}, timeoutMs = DEFAULT_ASYNC_TIMEOUT_MS) {
-  return withTimeout(execAsync(cmd, options), timeoutMs, `exec: ${truncate(cmd, 50)}`);
+  return withTimeout(execAsync(cmd, options), timeoutMs, `exec: ${cmd.substring(0, 50)}`);
 }
 
 // Maximum cached file size constant

package/lib/repo-intel/queries.js

@@ -0,0 +1,300 @@
+'use strict';
+
+/**
+ * Typed wrappers over `agent-analyzer repo-intel query <type>` subcommands.
+ *
+ * Each function constructs the exact argv expected by the binary, delegates to
+ * `binary.runAnalyzer`, parses the JSON output, and returns the result.
+ *
+ * All functions throw `RepoIntelMissingError` when the repo-intel map file
+ * has not been generated yet (run `agentsys repo-intel update` first).
+ *
+ * @module lib/repo-intel/queries
+ */
+
+const fs = require('fs');
+const path = require('path');
+const { getStateDir } = require('../platform/state-dir');
+const binary = require('../binary');
+
+// ---------------------------------------------------------------------------
+// Error types
+// ---------------------------------------------------------------------------
+
+/**
+ * Thrown when the repo-intel map file is absent.
+ */
+class RepoIntelMissingError extends Error {
+  /**
+   * @param {string} mapFile - Expected path to the map file
+   */
+  constructor(mapFile) {
+    super(
+      `repo-intel map not found at ${mapFile}. ` +
+      'Run `agentsys repo-intel update` to generate it first.'
+    );
+    this.name = 'RepoIntelMissingError';
+    this.code = 'REPO_INTEL_MISSING';
+    this.mapFile = mapFile;
+  }
+}
+
+// ---------------------------------------------------------------------------
+// Internal helpers
+// ---------------------------------------------------------------------------
+
+const MAP_FILE_NAME = 'repo-intel.json';
+
+/**
+ * Resolve the map file path for a given project root.
+ * @param {string} cwd
+ * @returns {string}
+ */
+function resolveMapFile(cwd) {
+  const stateDir = getStateDir(cwd);
+  return path.join(cwd, stateDir, MAP_FILE_NAME);
+}
+
+/**
+ * Assert the map file exists, throwing `RepoIntelMissingError` if not.
+ * @param {string} cwd
+ * @returns {string} resolved map file path
+ */
+function requireMapFile(cwd) {
+  const mapFile = resolveMapFile(cwd);
+  if (!fs.existsSync(mapFile)) {
+    throw new RepoIntelMissingError(mapFile);
+  }
+  return mapFile;
+}
+
+/**
+ * Run a repo-intel query and parse JSON output.
+ * @param {string} queryName - The subcommand name (e.g. 'hotspots')
+ * @param {string[]} extraArgs - Additional argv elements
+ * @param {string} cwd - Project root
+ * @returns {*} Parsed JSON result
+ */
+function runQuery(queryName, extraArgs, cwd) {
+  const mapFile = requireMapFile(cwd);
+  const args = ['repo-intel', 'query', queryName, ...extraArgs, '--map-file', mapFile, cwd];
+  let raw;
+  try {
+    raw = binary.runAnalyzer(args);
+  } catch (err) {
+    throw new Error(
+      `repo-intel query failed [${queryName}]: ${err.message}`,
+      { cause: err }
+    );
+  }
+  let parsed;
+  try {
+    parsed = JSON.parse(raw);
+  } catch (_parseErr) {
+    const preview = raw.slice(0, 200);
+    throw new Error(
+      `repo-intel query [${queryName}] returned non-JSON output: ${preview}`
+    );
+  }
+  return parsed;
+}
+
+// ---------------------------------------------------------------------------
+// Query functions
+// ---------------------------------------------------------------------------
+
+/**
+ * Hotspot files by change frequency.
+ * @param {string} cwd
+ * @param {{ limit?: number }} [opts]
+ * @returns {Array}
+ */
+function hotspots(cwd, opts = {}) {
+  const extra = [];
+  if (opts.limit != null) extra.push('--top', String(opts.limit));
+  return runQuery('hotspots', extra, cwd);
+}
+
+/**
+ * Co-change coupling for a file.
+ * @param {string} cwd
+ * @param {string} file
+ * @param {{ limit?: number }} [opts]
+ * @returns {Array}
+ */
+function coupling(cwd, file, opts = {}) {
+  const extra = [file];
+  if (opts.limit != null) extra.push('--top', String(opts.limit));
+  return runQuery('coupling', extra, cwd);
+}
+
+/**
+ * Bus factor report.
+ * @param {string} cwd
+ * @param {{ adjustForAi?: boolean, limit?: number }} [opts]
+ * @returns {Object}
+ */
+function busFactor(cwd, opts = {}) {
+  const extra = [];
+  if (opts.adjustForAi) extra.push('--adjust-for-ai');
+  if (opts.limit != null) extra.push('--top', String(opts.limit));
+  return runQuery('bus-factor', extra, cwd);
+}
+
+/**
+ * Files with low test coverage relative to change frequency.
+ * @param {string} cwd
+ * @param {{ limit?: number, minChanges?: number }} [opts]
+ * @returns {Array}
+ */
+function testGaps(cwd, opts = {}) {
+  const extra = [];
+  if (opts.limit != null) extra.push('--top', String(opts.limit));
+  if (opts.minChanges != null) extra.push('--min-changes', String(opts.minChanges));
+  return runQuery('test-gaps', extra, cwd);
+}
+
+/**
+ * AI-authored ratio per file or project.
+ * @param {string} cwd
+ * @param {{ pathFilter?: string }} [opts]
+ * @returns {Object}
+ */
+function aiRatio(cwd, opts = {}) {
+  const extra = [];
+  if (opts.pathFilter != null) extra.push('--path-filter', opts.pathFilter);
+  return runQuery('ai-ratio', extra, cwd);
+}
+
+/**
+ * Risk score for a diff (set of changed files).
+ * @param {string} cwd
+ * @param {string[]} files
+ * @returns {Array}
+ */
+function diffRisk(cwd, files) {
+  if (!Array.isArray(files)) {
+    throw new TypeError('diffRisk: files must be an array of strings');
+  }
+  if (!files.every(f => typeof f === 'string')) {
+    throw new TypeError('diffRisk: all entries in files must be strings');
+  }
+  const joined = files.join(',');
+  if (joined.length > 30000) {
+    throw new RangeError(
+      `diffRisk: files argument exceeds 30000 character limit (got ${joined.length})`
+    );
+  }
+  const extra = ['--files', joined];
+  return runQuery('diff-risk', extra, cwd);
+}
+
+/**
+ * Call-graph dependents of a symbol.
+ * @param {string} cwd
+ * @param {string} symbol
+ * @param {string} [file] - Scope to a specific file
+ * @returns {Object}
+ */
+function dependents(cwd, symbol, file) {
+  const extra = [symbol];
+  if (file != null) extra.push('--file', file);
+  return runQuery('dependents', extra, cwd);
+}
+
+/**
+ * Bugspot risk scores.
+ * @param {string} cwd
+ * @param {{ limit?: number }} [opts]
+ * @returns {Array}
+ */
+function bugspots(cwd, opts = {}) {
+  const extra = [];
+  if (opts.limit != null) extra.push('--top', String(opts.limit));
+  return runQuery('bugspots', extra, cwd);
+}
+
+/**
+ * Project health summary.
+ * @param {string} cwd
+ * @returns {Object}
+ */
+function health(cwd) {
+  return runQuery('health', [], cwd);
+}
+
+// ---------------------------------------------------------------------------
+// Graph queries (Phase 5.1 - agent-analyzer v0.4.0+)
+// ---------------------------------------------------------------------------
+
+/**
+ * Louvain-discovered file communities.
+ * @param {string} cwd
+ * @returns {Array}
+ */
+function communities(cwd) {
+  return runQuery('communities', [], cwd);
+}
+
+/**
+ * Files bridging multiple communities (architectural seams).
+ * @param {string} cwd
+ * @param {{ limit?: number }} [opts]
+ * @returns {Array}
+ */
+function boundaries(cwd, opts = {}) {
+  const extra = [];
+  if (opts.limit != null) extra.push('--top', String(opts.limit));
+  return runQuery('boundaries', extra, cwd);
+}
+
+/**
+ * Which community a file belongs to.
+ * @param {string} cwd
+ * @param {string} file
+ * @returns {Object}
+ */
+function areaOf(cwd, file) {
+  return runQuery('area-of', [file], cwd);
+}
+
+/**
+ * Composite health roll-up for a community.
+ * @param {string} cwd
+ * @param {number} id - Community id (non-negative integer)
+ * @returns {Object}
+ */
+function communityHealth(cwd, id) {
+  if (typeof id !== 'number' || !Number.isInteger(id) || id < 0) {
+    throw new TypeError(
+      'communityHealth: id must be a non-negative integer'
+    );
+  }
+  return runQuery('community-health', [String(id)], cwd);
+}
+
+// ---------------------------------------------------------------------------
+// Exports
+// ---------------------------------------------------------------------------
+
+module.exports = {
+  // Error class
+  RepoIntelMissingError,
+
+  // Core queries
+  hotspots,
+  coupling,
+  busFactor,
+  testGaps,
+  aiRatio,
+  diffRisk,
+  dependents,
+  bugspots,
+  health,
+
+  // Graph queries
+  communities,
+  boundaries,
+  areaOf,
+  communityHealth,
+};

package/lib/sources/policy-questions.js

@@ -6,7 +6,6 @@
  */
 
 const sourceCache = require('./source-cache');
-const { truncate } = require('../cross-platform');
 const customHandler = require('./custom-handler');
 
 /**
@@ -43,7 +42,7 @@ function getPolicyQuestions() {
     // Truncate to fit within 30 chars: "X (last used)" where X can be max 17 chars
     const maxBaseLen = 30 - ' (last used)'.length; // 18 chars for base
     const truncatedLabel = cachedLabel.length > maxBaseLen
-      ? truncate(cachedLabel, maxBaseLen - 1) + '…'
+      ? cachedLabel.substring(0, maxBaseLen - 1) + '…'
       : cachedLabel;
 
     sourceOptions.push({
@@ -156,12 +155,12 @@ function parseAndCachePolicy(responses) {
       // Validate and merge follow-up responses
       const rawNum = String(responses.project.number).trim();
       if (!/^[1-9][0-9]*$/.test(rawNum)) {
-        const safeNum = truncate(String(responses.project.number).replace(/[^\x20-\x7E]/g, '?'), 32);
+        const safeNum = String(responses.project.number).replace(/[^\x20-\x7E]/g, '?').substring(0, 32);
         throw new Error(`Invalid project number: "${safeNum}". Must be a positive integer.`);
       }
       const num = Number(rawNum);
       const owner = String(responses.project.owner || '').trim();
-      const safeOwner = truncate(String(responses.project.owner || '').replace(/[^\x20-\x7E]/g, '?'), 64);
+      const safeOwner = String(responses.project.owner || '').replace(/[^\x20-\x7E]/g, '?').substring(0, 64);
       if (!owner || !/^(@me|[a-zA-Z0-9][a-zA-Z0-9_-]*)$/.test(owner)) {
         throw new Error(`Invalid project owner: "${safeOwner}" (use @me or an org/user name)`);
       }