agentsys 5.14.0 → 6.0.0

package/lib/enhance/auto-suppression.js

@@ -54,9 +54,12 @@ const PATTERN_HEURISTICS = {
     const contentLower = content.toLowerCase();
 
     // Check if file is pattern documentation describing vague language detection
+    // ReDoS fix: the .* runs never matched across newlines (. excludes \n), so
+    // bounding them to [^\n]{0,N} keeps the same "within one line, in order"
+    // semantics while removing the polynomial multi-.* backtracking.
     const isPatternDoc =
-      /pattern.*detect.*usually|example.*vague|fuzzy.*language.*like/i.test(content) ||
-      /vague.*terms.*like|"usually".*"sometimes"/i.test(content);
+      /pattern[^\n]{0,500}detect[^\n]{0,500}usually|example[^\n]{0,500}vague|fuzzy[^\n]{0,500}language[^\n]{0,500}like/i.test(content) ||
+      /vague[^\n]{0,500}terms[^\n]{0,500}like|"usually"[^\n]{0,500}"sometimes"/i.test(content);
 
     if (isPatternDoc) {
       return {
@@ -129,7 +132,10 @@ const PATTERN_HEURISTICS = {
     const isOrchestrator =
       fileNameLower.includes('orchestrator') ||
       fileNameLower.includes('coordinator') ||
-      /Task\s*\(\s*\{[\s\S]*subagent_type/i.test(content);
+      // ReDoS fix: bound the unbounded [\s\S]* so a "Task({" with no following
+      // subagent_type cannot drive polynomial backtracking; 50k chars covers any
+      // realistic Task(...) call body.
+      /Task\s{0,100}\(\s{0,100}\{[\s\S]{0,50000}subagent_type/i.test(content);
 
     if (isOrchestrator) {
       return {
@@ -140,7 +146,9 @@ const PATTERN_HEURISTICS = {
 
     // Check if workflow command that invokes agents
     const isWorkflowCommand =
-      /spawn.*agent|invoke.*agent|Task\s*\(\s*\{/i.test(content) &&
+      // ReDoS fix: bound the within-line .* runs and \s* runs ([^\n] == . here)
+      // to keep the same matches without polynomial backtracking.
+      /spawn[^\n]{0,500}agent|invoke[^\n]{0,500}agent|Task\s{0,100}\(\s{0,100}\{/i.test(content) &&
       fileNameLower.endsWith('.md');
 
     if (isWorkflowCommand) {
@@ -159,9 +167,11 @@ const PATTERN_HEURISTICS = {
    */
   missing_output_format: (finding, content, context) => {
     // Check if content spawns subagents with their own output specs
+    // ReDoS fix: bound the within-line .* and \s* runs ([^\n] == . here) so the
+    // same membership matches hold without polynomial backtracking.
     const spawnsSubagent =
-      /subagent_type|spawn.*agent|Task\s*\(\s*\{/i.test(content) ||
-      /enhance:.*-enhancer|enhance:.*-reporter/i.test(content);
+      /subagent_type|spawn[^\n]{0,500}agent|Task\s{0,100}\(\s{0,100}\{/i.test(content) ||
+      /enhance:[^\n]{0,500}-enhancer|enhance:[^\n]{0,500}-reporter/i.test(content);
 
     if (spawnsSubagent) {
       return {
@@ -180,7 +190,9 @@ const PATTERN_HEURISTICS = {
   missing_constraints: (finding, content, context) => {
     // Check for constraint section presence
     const hasConstraintSection =
-      /##\s*What\s+.*MUST\s+NOT\s+Do/i.test(content) ||
+      // ReDoS fix: bound the within-line .* and \s runs ([^\n] == . here) so the
+      // "## What ... MUST NOT Do" heading still matches without backtracking.
+      /##\s{0,100}What\s{1,100}[^\n]{0,500}MUST\s{1,100}NOT\s{1,100}Do/i.test(content) ||
       /##\s*Constraints/i.test(content) ||
       /<constraints>/i.test(content) ||
       /##\s*Critical\s+Constraints/i.test(content) ||

package/lib/enhance/cross-file-analyzer.js

@@ -114,8 +114,11 @@ const CRITICAL_PATTERNS = [
 const SUBAGENT_PATTERN = /subagent_type\s*[=:]\s*["']([^"']+)["']/g;
 
 /** Pre-compiled patterns for cleaning content */
-const BAD_EXAMPLE_TAG_PATTERN = /<bad[_\- ]?example>[\s\S]*?<\/bad[_\- ]?example>/gi;
-const BAD_EXAMPLE_CODE_PATTERN = /```[^\n]*bad[^\n]*\n[\s\S]*?```/gi;
+// ReDoS fix: bound the lazy [\s\S]*? bodies so an unterminated <bad-example> or
+// ``` fence cannot drive polynomial backtracking; 50k chars covers any realistic
+// example block, so the stripped regions are unchanged for real content.
+const BAD_EXAMPLE_TAG_PATTERN = /<bad[_\- ]?example>[\s\S]{0,50000}?<\/bad[_\- ]?example>/gi;
+const BAD_EXAMPLE_CODE_PATTERN = /```[^\n]{0,500}bad[^\n]{0,500}\n[\s\S]{0,50000}?```/gi;
 
 // ============================================
 // TOOL PATTERN CACHE
@@ -649,10 +652,14 @@ function analyzePromptConsistency(agents) {
 
       // Extract action keywords
       let action;
+      // ReDoS fix: bound the greedy prefix to non-newline chars. `line` is a single
+      // trimmed line (no newlines), so [^\n]{0,N} is equivalent to the prior `.*`:
+      // greedy match strips everything up to and including the LAST keyword plus its
+      // trailing whitespace, preserving the word-boundary semantics exactly.
       if (isAlways) {
-        action = line.replace(/.*\bALWAYS\b\s*/i, '').substring(0, ACTION_COMPARISON_LENGTH);
+        action = line.replace(/[^\n]{0,2000}\bALWAYS\b\s{0,200}/i, '').substring(0, ACTION_COMPARISON_LENGTH);
       } else {
-        action = line.replace(/.*\b(?:NEVER|DO NOT)\b\s*/i, '').substring(0, ACTION_COMPARISON_LENGTH);
+        action = line.replace(/[^\n]{0,2000}\b(?:NEVER|DO NOT)\b\s{0,200}/i, '').substring(0, ACTION_COMPARISON_LENGTH);
       }
 
       // Extract significant keywords from action

package/lib/enhance/docs-patterns.js

@@ -24,7 +24,9 @@ const docsPatterns = {
       if (!content || typeof content !== 'string') return null;
 
       // Find markdown links
-      const linkRegex = /\[([^\]]+)\]\(([^)]+)\)/g;
+      // ReDoS fix: bound the negated-class captures so the matcher is linear;
+      // bounds far exceed any realistic markdown link, so matches are unchanged.
+      const linkRegex = /\[([^\]]{1,2000})\]\(([^)]{1,4000})\)/g;
       const brokenLinks = [];
       let match;
 
@@ -40,7 +42,9 @@ const docsPatterns = {
         if (linkTarget.startsWith('#')) {
           const anchorId = linkTarget.slice(1).toLowerCase();
           // Generate expected heading anchors from content
-          const headings = content.match(/^#{1,6}\s+(.+)$/gm) || [];
+          // ReDoS fix: bound the \s+ run; line-anchored (.+) cannot cross newlines
+          // so the same headings match as before.
+          const headings = content.match(/^#{1,6}\s{1,1000}(.+)$/gm) || [];
           const anchors = headings.map(h => {
             return h.replace(/^#{1,6}\s+/, '')
               .toLowerCase()

package/lib/enhance/fixer.js

@@ -225,6 +225,16 @@ function applyFixes(issues, options = {}) {
   return results;
 }
 
+// Prototype-pollution guard: reject path segments that would reach
+// Object.prototype before they index/assign into `current`
+// (CodeQL js/prototype-polluting-assignment). The check is written as inline
+// `!==` comparisons against the literal dangerous keys - CodeQL recognizes
+// that exact shape as a sanitizing barrier, whereas a Set.has() indirection
+// is not traced through and leaves the assignment flagged.
+function isSafeKey(key) {
+  return key !== '__proto__' && key !== 'constructor' && key !== 'prototype';
+}
+
 function applyAtPath(obj, pathStr, fixFn) {
   const parts = pathStr.split('.');
   const result = structuredClone(obj);
@@ -235,10 +245,11 @@ function applyAtPath(obj, pathStr, fixFn) {
     if (part.includes('[')) {
       // Array access
       const match = part.match(/^((?!__proto__|constructor|prototype)[a-zA-Z_]\w*)\[(\d{1,10})\]$/);
-      if (match) {
+      if (match && match[1] !== '__proto__' && match[1] !== 'constructor' && match[1] !== 'prototype') {
         current = current[match[1]][parseInt(match[2], 10)];
       }
     } else {
+      if (!isSafeKey(part)) return result; // refuse prototype-polluting traversal
       current = current[part];
     }
   }
@@ -246,10 +257,14 @@ function applyAtPath(obj, pathStr, fixFn) {
   const lastPart = parts[parts.length - 1];
   if (lastPart.includes('[')) {
     const match = lastPart.match(/^((?!__proto__|constructor|prototype)[a-zA-Z_]\w*)\[(\d{1,10})\]$/);
-    if (match) {
-      current[match[1]][parseInt(match[2], 10)] = fixFn(current[match[1]][parseInt(match[2], 10)]);
+    // Inline literal guard (not the isSafeKey helper) so CodeQL traces the
+    // sanitizing barrier on the assignment below.
+    if (match && match[1] !== '__proto__' && match[1] !== 'constructor' && match[1] !== 'prototype') {
+      const key = match[1];
+      const idx = parseInt(match[2], 10);
+      current[key][idx] = fixFn(current[key][idx]);
     }
-  } else {
+  } else if (lastPart !== '__proto__' && lastPart !== 'constructor' && lastPart !== 'prototype') {
     current[lastPart] = fixFn(current[lastPart]);
   }
 
@@ -780,5 +795,7 @@ module.exports = {
   previewFixes,
   restoreFromBackup,
   cleanupBackups,
-  assertNotSymlink
+  assertNotSymlink,
+  // Exported for prototype-pollution regression tests.
+  applyAtPath
 };

package/lib/enhance/skill-patterns.js

@@ -76,11 +76,11 @@ const skillPatterns = {
                (content && p.test(content));
       });
 
-      const disableModelInvocation = frontmatter['disable-model-invocation'];
-      const isManualOnly = disableModelInvocation === true ||
-        (typeof disableModelInvocation === 'string' && disableModelInvocation.toLowerCase() === 'true');
-
-      if (hasSideEffects && !isManualOnly) {
+      // Accept both the YAML boolean `true` and the quoted string "true" -
+      // users commonly write `disable-model-invocation: "true"`, which YAML
+      // parses as a string; a strict `!== true` would wrongly re-flag it.
+      const dmi = frontmatter['disable-model-invocation'];
+      if (hasSideEffects && dmi !== true && dmi !== 'true') {
         return {
           issue: 'Skill with side effects should have disable-model-invocation: true',
           fix: 'Add "disable-model-invocation: true" to frontmatter for manual-only invocation'

package/lib/index.js

@@ -25,6 +25,7 @@ const customHandler = require('./sources/custom-handler');
 const policyQuestions = require('./sources/policy-questions');
 const crossPlatform = require('./cross-platform');
 const enhance = require('./enhance');
+const repoIntel = require('./repo-intel');
 const repoMap = require('./repo-map');
 const perf = require('./perf');
 const collectors = require('./collectors');
@@ -250,6 +251,7 @@ module.exports = {
   sources,
   xplat,
   enhance,
+  repoIntel,
   repoMap,
   perf,
   collectors,

package/lib/repo-intel/cache.js

@@ -0,0 +1,171 @@
+/**
+ * Repo map cache management
+ *
+ * @module lib/repo-intel/cache
+ */
+
+'use strict';
+
+const fs = require('fs');
+const path = require('path');
+const { getStateDirPath } = require('../platform/state-dir');
+const { writeJsonAtomic, writeFileAtomic } = require('../utils/atomic-write');
+
+const MAP_FILENAME = 'repo-map.json';
+const STALE_FILENAME = 'repo-map.stale';
+const INTEL_FILENAME = 'repo-intel.json';
+
+/**
+ * Get repo-map path (the converted view artifact).
+ * @param {string} basePath - Repository root
+ * @returns {string}
+ */
+function getMapPath(basePath) {
+  return path.join(getStateDirPath(basePath), MAP_FILENAME);
+}
+
+/**
+ * Get the RAW repo-intel.json path (the binary's native artifact).
+ * The embed submodule (orchestrator.js) feeds this to the embed binary's
+ * --map-file. In the standalone layout cache.getPath returned repo-intel.json;
+ * the fold renamed the converted-view accessor to getMapPath, so getPath keeps
+ * its original raw-artifact meaning. Mirrors index.js getIntelMapPath.
+ * @param {string} basePath - Repository root
+ * @returns {string}
+ */
+function getPath(basePath) {
+  return path.join(getStateDirPath(basePath), INTEL_FILENAME);
+}
+
+/**
+ * Get stale marker path
+ * @param {string} basePath - Repository root
+ * @returns {string}
+ */
+function getStalePath(basePath) {
+  return path.join(getStateDirPath(basePath), STALE_FILENAME);
+}
+
+/**
+ * Ensure state directory exists
+ * @param {string} basePath - Repository root
+ * @returns {string}
+ */
+function ensureStateDir(basePath) {
+  const stateDir = getStateDirPath(basePath);
+  if (!fs.existsSync(stateDir)) {
+    fs.mkdirSync(stateDir, { recursive: true });
+  }
+  return stateDir;
+}
+
+/**
+ * Load repo-map from cache
+ * @param {string} basePath - Repository root
+ * @returns {Object|null}
+ */
+function load(basePath) {
+  const mapPath = getMapPath(basePath);
+  if (!fs.existsSync(mapPath)) return null;
+
+  try {
+    const raw = fs.readFileSync(mapPath, 'utf8');
+    return JSON.parse(raw);
+  } catch {
+    return null;
+  }
+}
+
+/**
+ * Save repo-map to cache
+ * @param {string} basePath - Repository root
+ * @param {Object} map - Map object
+ */
+function save(basePath, map) {
+  ensureStateDir(basePath);
+  const mapPath = getMapPath(basePath);
+
+  const output = {
+    ...map,
+    updated: new Date().toISOString()
+  };
+
+  writeJsonAtomic(mapPath, output);
+
+  // Clear stale marker if present
+  clearStale(basePath);
+}
+
+/**
+ * Check if repo-map exists
+ * @param {string} basePath - Repository root
+ * @returns {boolean}
+ */
+function exists(basePath) {
+  return fs.existsSync(getMapPath(basePath));
+}
+
+/**
+ * Mark repo-map as stale
+ * @param {string} basePath - Repository root
+ */
+function markStale(basePath) {
+  ensureStateDir(basePath);
+  writeFileAtomic(getStalePath(basePath), new Date().toISOString());
+}
+
+/**
+ * Clear stale marker
+ * @param {string} basePath - Repository root
+ */
+function clearStale(basePath) {
+  const stalePath = getStalePath(basePath);
+  if (fs.existsSync(stalePath)) {
+    fs.unlinkSync(stalePath);
+  }
+}
+
+/**
+ * Check if stale marker exists
+ * @param {string} basePath - Repository root
+ * @returns {boolean}
+ */
+function isMarkedStale(basePath) {
+  return fs.existsSync(getStalePath(basePath));
+}
+
+/**
+ * Get basic status summary
+ * @param {string} basePath - Repository root
+ * @returns {Object|null}
+ */
+function getStatus(basePath) {
+  const map = load(basePath);
+  if (!map) return null;
+
+  return {
+    generated: map.generated,
+    updated: map.updated,
+    commit: map.git?.commit,
+    branch: map.git?.branch,
+    files: Object.keys(map.files || {}).length,
+    symbols: map.stats?.totalSymbols || 0,
+    languages: map.project?.languages || []
+  };
+}
+
+module.exports = {
+  load,
+  save,
+  exists,
+  getStatus,
+  getMapPath,
+  // getPath -> raw repo-intel.json (embed orchestrator); getStateDirPath
+  // re-exported for embed/preference.js. Both delegate to platform/state-dir
+  // and match the names the standalone cache exposed.
+  getPath,
+  getStateDirPath,
+  markStale,
+  clearStale,
+  isMarkedStale
+};

package/lib/repo-intel/converter.js

@@ -0,0 +1,130 @@
+'use strict';
+
+/**
+ * Convert agent-analyzer repo-intel.json format to repo-map.json format.
+ *
+ * agent-analyzer outputs: { symbols: { [filePath]: { exports, imports, definitions } } }
+ * repo-map expects:       { files: { [filePath]: { language, symbols, imports } } }
+ *
+ * @module lib/repo-intel/converter
+ */
+
+const path = require('path');
+
+const LANGUAGE_BY_EXTENSION = {
+  '.js': 'javascript', '.jsx': 'javascript', '.mjs': 'javascript', '.cjs': 'javascript',
+  '.ts': 'typescript', '.tsx': 'typescript', '.mts': 'typescript', '.cts': 'typescript',
+  '.py': 'python', '.pyw': 'python',
+  '.rs': 'rust',
+  '.go': 'go',
+  '.java': 'java'
+};
+
+// SymbolKind values from agent-analyzer (kebab-case serialized)
+const CLASS_KINDS = new Set(['class', 'struct', 'interface', 'enum', 'impl']);
+const TYPE_KINDS = new Set(['trait', 'type-alias']);
+const FUNCTION_LIKE_KINDS = new Set(['method', 'arrow', 'closure']);
+const CONSTANT_KINDS = new Set(['constant', 'variable', 'const', 'field', 'property']);
+
+function detectLanguage(filePath) {
+  return LANGUAGE_BY_EXTENSION[path.extname(filePath).toLowerCase()] || 'unknown';
+}
+
+function detectLanguagesFromFiles(filePaths) {
+  const langs = new Set();
+  for (const fp of filePaths) {
+    const lang = detectLanguage(fp);
+    if (lang !== 'unknown') langs.add(lang);
+  }
+  return Array.from(langs);
+}
+
+/**
+ * Convert a single file's symbols from repo-intel format to repo-map format.
+ * @param {string} filePath
+ * @param {Object} fileSym - { exports, imports, definitions }
+ * @returns {Object} repo-map file entry
+ */
+function convertFile(filePath, fileSym) {
+  const exportNames = new Set((fileSym.exports || []).map(e => e.name));
+
+  const exports = (fileSym.exports || []).map(e => ({
+    name: e.name,
+    kind: e.kind,
+    line: e.line
+  }));
+
+  const functions = [];
+  const classes = [];
+  const types = [];
+  const constants = [];
+
+  for (const def of fileSym.definitions || []) {
+    const entry = {
+      name: def.name,
+      kind: def.kind,
+      line: def.line,
+      exported: exportNames.has(def.name)
+    };
+    if (def.kind === 'function' || FUNCTION_LIKE_KINDS.has(def.kind)) {
+      functions.push(entry);
+    } else if (CLASS_KINDS.has(def.kind)) {
+      classes.push(entry);
+    } else if (TYPE_KINDS.has(def.kind)) {
+      types.push(entry);
+    } else if (CONSTANT_KINDS.has(def.kind)) {
+      constants.push(entry);
+    } else {
+      // Unknown kind - default to constants for backward compat
+      constants.push(entry);
+    }
+  }
+
+  // agent-analyzer imports: [{ from, names }] → repo-map imports: [{ source, kind, names }]
+  const imports = (fileSym.imports || []).map(imp => ({
+    source: imp.from,
+    kind: 'import',
+    names: imp.names || []
+  }));
+
+  return {
+    language: detectLanguage(filePath),
+    symbols: { exports, functions, classes, types, constants },
+    imports
+  };
+}
+
+/**
+ * Convert a full repo-intel data object to repo-map format.
+ * @param {Object} intel - RepoIntelData from agent-analyzer
+ * @returns {Object} repo-map.json compatible object
+ */
+function convertIntelToRepoMap(intel) {
+  const files = {};
+  let totalSymbols = 0;
+  let totalImports = 0;
+
+  for (const [filePath, fileSym] of Object.entries(intel.symbols || {})) {
+    files[filePath] = convertFile(filePath, fileSym);
+    const s = files[filePath].symbols;
+    totalSymbols += s.functions.length + s.classes.length +
+                    s.types.length + s.constants.length;
+    totalImports += files[filePath].imports.length;
+  }
+
+  return {
+    version: '2.0',
+    generated: intel.generated || new Date().toISOString(),
+    git: intel.git ? { commit: intel.git.analyzedUpTo } : undefined,
+    project: { languages: detectLanguagesFromFiles(Object.keys(files)) },
+    stats: {
+      totalFiles: Object.keys(files).length,
+      totalSymbols,
+      totalImports,
+      errors: []
+    },
+    files
+  };
+}
+
+module.exports = { convertIntelToRepoMap, convertFile, detectLanguage };