agentskillsdk 0.4.5 → 0.5.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agentskillsdk",
-  "version": "0.4.5",
+  "version": "0.5.0",
   "description": "Install agent skills from agentskills.dk",
   "type": "module",
   "bin": {

package/src/commands/add.js

@@ -1,11 +1,14 @@
 import chalk from 'chalk';
 import ora from 'ora';
+import { symlinkSync, mkdirSync } from 'node:fs';
+import { join, relative, dirname } from 'node:path';
+import { homedir } from 'node:os';
 import { fetchSkill, fetchSkills } from '../lib/api.js';
-import { detectAgents, AGENTS } from '../lib/detect-agent.js';
+import { detectAgents, AGENTS, getUniversalAgents, getNonUniversalAgents } from '../lib/detect-agent.js';
 import { downloadSkill } from '../lib/download.js';
 import { parseGithubSource } from '../lib/parse-source.js';
 import { selectPrompt, checkboxPrompt } from '../lib/prompt.js';
-import { printBanner, printCompletionSummary, step, error } from '../lib/ui.js';
+import { printBanner, printInstallPlan, printCompletionSummary, step, error } from '../lib/ui.js';
 
 export async function addCommand(skillName, options) {
   printBanner();
@@ -71,7 +74,7 @@ export async function addCommand(skillName, options) {
     spinner.succeed(`fundet skill: ${chalk.bold(skill.name)}`);
   }
 
-  // --- agent selection + scope prompt (with back navigation) ---
+  // --- agent selection + scope + confirmation (with back navigation) ---
   const detected = detectAgents(cwd);
   let agents;
   let scope;
@@ -135,7 +138,34 @@ export async function addCommand(skillName, options) {
       scope = result;
     }
 
-    break; // selection complete
+    // --- confirmation screen ---
+    const universalAgents = getUniversalAgents(agents);
+    const nonUniversalAgents = getNonUniversalAgents(agents);
+
+    const source = isGithub
+      ? `${skill.githubOwner}/${skill.githubRepo}`
+      : (skill.namespace || skill.name);
+
+    printInstallPlan({
+      skillName: installName,
+      source,
+      scope,
+      universalAgents,
+      symlinkAgents: nonUniversalAgents,
+    });
+
+    const confirm = await selectPrompt(chalk.bold('fortsæt med installation?'), [
+      { label: 'ja, installer', value: 'yes' },
+      { label: 'nej, annullér', value: 'no' },
+    ]);
+
+    if (confirm === null || confirm === 'no') {
+      // Esc or "nej" → back to scope selection (or exit if flags were set)
+      if (options.global || options.project) process.exit(0);
+      continue agentSelection;
+    }
+
+    break; // selection + confirmation complete
   }
 
   // --- step message ---
@@ -145,12 +175,46 @@ export async function addCommand(skillName, options) {
     step(`Agents: ${chalk.bold(agents.map(a => a.name).join(', '))}`);
   }
 
-  // --- download to each agent ---
+  // --- download to canonical .agents/skills/ then symlink ---
   const spinner = ora({ text: 'downloader skill-filer...', indent: 2 }).start();
+
+  const symlinkResults = { canonical: [], symlinked: [], copied: [] };
+
   try {
-    for (const agent of agents) {
-      const destDir = agent.path(installName, { cwd, scope });
-      await downloadSkill(skill, destDir);
+    // Canonical location: always .agents/skills/<name>/
+    const base = scope === 'global' ? homedir() : cwd;
+    const canonicalDir = join(base, '.agents', 'skills', installName);
+
+    // Download once to canonical
+    await downloadSkill(skill, canonicalDir);
+
+    // Track which agents got the canonical copy (universal agents using .agents/)
+    const universalAgents = getUniversalAgents(agents);
+    const nonUniversalAgents = getNonUniversalAgents(agents);
+
+    for (const a of universalAgents) {
+      symlinkResults.canonical.push(a);
+    }
+
+    // For each non-universal agent, symlink from their path → canonical
+    for (const agent of nonUniversalAgents) {
+      const agentDir = agent.path(installName, { cwd, scope });
+
+      if (agentDir === canonicalDir) {
+        symlinkResults.canonical.push(agent);
+        continue;
+      }
+
+      mkdirSync(dirname(agentDir), { recursive: true });
+      try {
+        const rel = relative(dirname(agentDir), canonicalDir);
+        symlinkSync(rel, agentDir);
+        symlinkResults.symlinked.push(agent);
+      } catch {
+        // Fallback: download again
+        await downloadSkill(skill, agentDir);
+        symlinkResults.copied.push(agent);
+      }
     }
   } catch (err) {
     spinner.fail('download fejlede');
@@ -166,5 +230,6 @@ export async function addCommand(skillName, options) {
     agents,
     isGithub,
     namespace: skill.namespace,
+    symlinkResults,
   });
 }

package/src/lib/detect-agent.js

@@ -2,7 +2,7 @@ import { existsSync } from 'node:fs';
 import { join } from 'node:path';
 import { homedir } from 'node:os';
 
-function makeAgent(name, folder, { globalFolder, detectFolder } = {}) {
+function makeAgent(name, folder, { globalFolder, detectFolder, universal } = {}) {
   const gFolder = globalFolder || folder;
   const dFolder = detectFolder || folder;
   return {
@@ -10,6 +10,7 @@ function makeAgent(name, folder, { globalFolder, detectFolder } = {}) {
     folder,
     globalFolder: gFolder,
     detectFolder: dFolder,
+    universal: !!universal,
     path: (skill, { cwd, scope }) => {
       if (scope === 'global') return join(homedir(), gFolder, 'skills', skill);
       return join(cwd, folder, 'skills', skill);
@@ -22,28 +23,32 @@ function makeAgent(name, folder, { globalFolder, detectFolder } = {}) {
 }
 
 export const AGENTS = [
+  makeAgent('Amp', '.agents', { detectFolder: '.config/amp', universal: true }),
   makeAgent('Cline', '.cline'),
   makeAgent('Claude Code', '.claude'),
   makeAgent('CodeBuddy', '.codebuddy'),
-  makeAgent('Codex CLI', '.agents', { globalFolder: '.codex' }),
+  makeAgent('Codex CLI', '.agents', { globalFolder: '.codex', universal: true }),
   makeAgent('Command Code', '.commandcode'),
   makeAgent('Continue', '.continue'),
   makeAgent('Crush', '.crush'),
-  makeAgent('Cursor', '.cursor'),
+  makeAgent('Cursor', '.agents', { globalFolder: '.cursor', universal: true }),
   makeAgent('Droid', '.factory'),
-  makeAgent('GitHub Copilot', '.github', { detectFolder: '.github/skills' }),
+  makeAgent('Gemini CLI', '.agents', { universal: true }),
+  makeAgent('GitHub Copilot', '.agents', { detectFolder: '.github/skills', globalFolder: '.github', universal: true }),
   makeAgent('Goose', '.goose'),
   makeAgent('Kilo Code', '.kilocode'),
+  makeAgent('Kimi CLI', '.agents', { universal: true }),
   makeAgent('Kiro CLI', '.kiro'),
   makeAgent('MCPJam', '.mcpjam'),
   makeAgent('Mux', '.mux'),
   makeAgent('Neovate', '.neovate'),
   makeAgent('OpenClaw', '.openclaw'),
-  makeAgent('OpenCode', '.opencode'),
+  makeAgent('OpenCode', '.agents', { globalFolder: '.opencode', universal: true }),
   makeAgent('OpenHands', '.openhands'),
   makeAgent('Pi', '.pi'),
   makeAgent('Qoder', '.qoder'),
   makeAgent('Qwen Code', '.qwen'),
+  makeAgent('Replit', '.agents', { universal: true }),
   makeAgent('Roo Code', '.roo'),
   makeAgent('Trae', '.trae'),
   makeAgent('Windsurf', '.windsurf'),
@@ -53,3 +58,11 @@ export const AGENTS = [
 export function detectAgents(cwd) {
   return AGENTS.filter(agent => existsSync(join(cwd, agent.detectFolder)));
 }
+
+export function getUniversalAgents(agentList) {
+  return agentList.filter(a => a.universal);
+}
+
+export function getNonUniversalAgents(agentList) {
+  return agentList.filter(a => !a.universal);
+}

package/src/lib/ui.js

@@ -43,16 +43,48 @@ export function printBanner() {
   console.log('');
 }
 
-// --- completion summary ---
+// --- install plan ---
 
-export function printCompletionSummary({ skillName, scope, agents, isGithub, namespace }) {
+export function printInstallPlan({ skillName, source, scope, universalAgents, symlinkAgents }) {
   const scopeLabel = scope === 'global'
     ? 'globalt (alle projekter)'
     : 'projekt (lokalt)';
 
-  const isSingle = agents.length === 1;
-  const agentNames = agents.map(a => a.name).join(', ');
-  const paths = agents.map(a => a.displayPath(skillName, scope));
+  const lines = [
+    chalk.bold('installationsplan:'),
+    '',
+    `  ${chalk.dim('skill:')}    ${skillName}`,
+    `  ${chalk.dim('kilde:')}    ${source}`,
+    `  ${chalk.dim('omfang:')}   ${scopeLabel}`,
+  ];
+
+  if (universalAgents.length > 0) {
+    lines.push('');
+    lines.push(chalk.dim('  ── Universal (.agents/skills/) ──'));
+    for (const a of universalAgents) {
+      lines.push(`  ${chalk.green('\u2713')} ${a.name}`);
+    }
+  }
+
+  if (symlinkAgents.length > 0) {
+    lines.push('');
+    lines.push(chalk.dim('  ── Symlink \u2192 .agents/skills/ ──'));
+    for (const a of symlinkAgents) {
+      lines.push(`  ${chalk.green('\u2713')} ${a.name}  ${chalk.dim(a.displayPath(skillName, scope))}`);
+    }
+  }
+
+  console.log('');
+  console.log(box(lines));
+  console.log('');
+}
+
+// --- completion summary ---
+
+export function printCompletionSummary({ skillName, scope, agents, isGithub, namespace, symlinkResults }) {
+  const scopeLabel = scope === 'global'
+    ? 'globalt (alle projekter)'
+    : 'projekt (lokalt)';
 
   const lines = [
     chalk.bold.green('skill installeret!'),
@@ -61,19 +93,52 @@ export function printCompletionSummary({ skillName, scope, agents, isGithub, nam
     `  ${chalk.dim('omfang:')}  ${scopeLabel}`,
   ];
 
-  if (isSingle) {
-    lines.push(`  ${chalk.dim('agent:')}   ${agentNames}`);
-    lines.push(`  ${chalk.dim('sti:')}     ${paths[0]}`);
+  if (symlinkResults) {
+    // Group by installation method
+    const { canonical, symlinked, copied } = symlinkResults;
+
+    if (canonical.length > 0) {
+      lines.push('');
+      lines.push(chalk.dim('  canonical (.agents/skills/):'));
+      for (const a of canonical) {
+        lines.push(`    ${chalk.green('\u2713')} ${a.name}`);
+      }
+    }
+
+    if (symlinked.length > 0) {
+      lines.push('');
+      lines.push(chalk.dim('  symlink:'));
+      for (const a of symlinked) {
+        lines.push(`    ${chalk.green('\u2713')} ${a.name}  ${chalk.dim(a.displayPath(skillName, scope) + ' \u2192 .agents/skills/')}`);
+      }
+    }
+
+    if (copied.length > 0) {
+      lines.push('');
+      lines.push(chalk.dim('  kopi (symlink fejlede):'));
+      for (const a of copied) {
+        lines.push(`    ${chalk.green('\u2713')} ${a.name}  ${chalk.dim(a.displayPath(skillName, scope))}`);
+      }
+    }
   } else {
-    lines.push(`  ${chalk.dim('agenter:')} ${agentNames}`);
-    lines.push(`  ${chalk.dim('stier:')}   ${paths[0]}`);
-    for (let i = 1; i < paths.length; i++) {
-      lines.push(`            ${paths[i]}`);
+    // Fallback: old-style summary
+    const agentNames = agents.map(a => a.name).join(', ');
+    const paths = agents.map(a => a.displayPath(skillName, scope));
+
+    if (agents.length === 1) {
+      lines.push(`  ${chalk.dim('agent:')}   ${agentNames}`);
+      lines.push(`  ${chalk.dim('sti:')}     ${paths[0]}`);
+    } else {
+      lines.push(`  ${chalk.dim('agenter:')} ${agentNames}`);
+      lines.push(`  ${chalk.dim('stier:')}   ${paths[0]}`);
+      for (let i = 1; i < paths.length; i++) {
+        lines.push(`            ${paths[i]}`);
+      }
     }
   }
 
   lines.push('');
-  if (isSingle) {
+  if (agents.length === 1) {
     lines.push(`start en ny ${agents[0].name}-session for at bruge den.`);
   } else {
     lines.push('start en ny session i en af disse agenter for at bruge den.');