agentplane 0.3.9 → 0.3.11

package/dist/commands/task/verify-record.js

@@ -1,12 +1,21 @@
 import { readFile } from "node:fs/promises";
 import path from "node:path";
 import { mapBackendError, mapCoreError } from "../../cli/error-map.js";
-import { backendNotSupportedMessage, successMessage } from "../../cli/output.js";
+import { backendNotSupportedMessage, infoMessage, successMessage } from "../../cli/output.js";
 import { CliError } from "../../shared/errors.js";
+import { writeJsonStableIfChanged } from "../../shared/write-if-changed.js";
+import { collectTaskIncidents, inspectTaskIncidents, renderIncidentCollectionPlanOutcome, } from "../incidents/shared.js";
 import { ensureReconciledBeforeMutation } from "../shared/reconcile-check.js";
 import { loadCommandContext } from "../shared/task-backend.js";
 import { applyTaskMutation } from "../shared/task-mutation.js";
-import { decodeEscapedTaskTextNewlines, executeTaskVerificationTransitionRequest, nowIso, } from "./shared.js";
+import { ensurePrArtifactsSynced } from "../pr/internal/sync.js";
+import { resolvePrPaths } from "../pr/internal/pr-paths.js";
+import { buildVerifiedPrMeta, parsePrMeta } from "../shared/pr-meta.js";
+import { buildStructuredFindingMutationPlan } from "./findings.js";
+import { assertVerifyStepsFilled, decodeEscapedTaskTextNewlines, executeTaskVerificationTransitionRequest, extractDocSection, nowIso, } from "./shared.js";
+function normalizeFileBackedVerifyNote(raw) {
+    return decodeEscapedTaskTextNewlines(raw).replaceAll(/\s+/gu, " ").trim();
+}
 async function recordVerificationResult(opts) {
     const ctx = opts.ctx ??
         (await loadCommandContext({ cwd: opts.cwd, rootOverride: opts.rootOverride ?? null }));
@@ -26,6 +35,14 @@ async function recordVerificationResult(opts) {
         ctx,
         taskId: opts.taskId,
         build: async (current) => {
+            const doc = (typeof current.doc === "string" ? current.doc : "") ||
+                (await backend.getTaskDoc(current.id));
+            assertVerifyStepsFilled({
+                taskId: current.id,
+                sectionText: extractDocSection(doc, "Verify Steps"),
+                action: "record verification",
+                guidance: "fill it before running `agentplane verify ...`",
+            });
             const execution = executeTaskVerificationTransitionRequest({
                 task: current,
                 at,
@@ -33,27 +50,119 @@ async function recordVerificationResult(opts) {
                 note: opts.note,
                 state: opts.state,
                 details: opts.details ?? null,
-                doc: (typeof current.doc === "string" ? current.doc : "") ||
-                    (await backend.getTaskDoc(current.id)),
+                doc,
                 requiredSections: config.tasks.doc.required_sections,
             });
-            return { intents: execution.intents };
+            const intents = [...execution.intents];
+            if (opts.finding) {
+                const findingPlan = buildStructuredFindingMutationPlan({
+                    current,
+                    config,
+                    observation: opts.finding.observation,
+                    impact: opts.finding.impact,
+                    resolution: opts.finding.resolution,
+                    promote: !opts.finding.localOnly,
+                    external: !opts.finding.localOnly,
+                    fixability: opts.finding.repoFixable ? "repo-fixable" : null,
+                    incidentScope: opts.finding.incidentScope,
+                    incidentTags: opts.finding.incidentTags ?? [],
+                    incidentMatch: opts.finding.incidentMatch ?? [],
+                    incidentAdvice: opts.finding.incidentAdvice,
+                    incidentRule: opts.finding.incidentRule,
+                });
+                if (findingPlan)
+                    intents.push(...findingPlan.intents);
+            }
+            return { intents };
         },
     });
+    if (config.workflow_mode === "branch_pr") {
+        const syncResult = await ensurePrArtifactsSynced({
+            ctx,
+            cwd: opts.cwd,
+            rootOverride: opts.rootOverride,
+            taskId: opts.taskId,
+            author: opts.by,
+        });
+        if (syncResult) {
+            const { metaPath } = await resolvePrPaths({
+                ctx,
+                cwd: opts.cwd,
+                rootOverride: opts.rootOverride,
+                taskId: opts.taskId,
+            });
+            const meta = parsePrMeta(await readFile(metaPath, "utf8"), opts.taskId);
+            await writeJsonStableIfChanged(metaPath, buildVerifiedPrMeta({
+                meta,
+                at,
+                state: opts.state === "ok" ? "pass" : "fail",
+            }));
+        }
+    }
+    let incidentSummary = null;
+    if (opts.collectIncidents === true) {
+        const collected = await collectTaskIncidents({
+            ctx,
+            taskId: opts.taskId,
+            write: true,
+        });
+        incidentSummary = renderIncidentCollectionPlanOutcome(collected.plan, {
+            wrote: collected.wrote,
+            context: "collect",
+            promotedIds: collected.plan.promotable.map((item) => item.entry.id),
+            registryPaths: collected.registryPaths,
+            taskId: opts.taskId,
+        });
+    }
+    else if (config.workflow_mode === "branch_pr") {
+        const inspected = await inspectTaskIncidents({
+            ctx,
+            taskId: opts.taskId,
+        });
+        incidentSummary = renderIncidentCollectionPlanOutcome(inspected.plan, {
+            wrote: false,
+            context: "verify",
+            taskId: opts.taskId,
+        });
+    }
     if (!opts.quiet) {
+        const findingState = opts.finding
+            ? opts.finding.localOnly
+                ? "task-local"
+                : "incident-candidate"
+            : null;
         const readmePath = path.join(resolved.gitRoot, config.paths.workflow_dir, opts.taskId, "README.md");
         const relReadmePath = path.relative(resolved.gitRoot, readmePath);
-        process.stdout.write(`${successMessage("verified", opts.taskId, `state=${opts.state} readme=${relReadmePath}`)}\n`);
+        const extra = findingState ? ` finding=${findingState}` : "";
+        process.stdout.write(`${successMessage("verified", opts.taskId, `state=${opts.state} readme=${relReadmePath}${extra}`)}\n`);
+        if (incidentSummary && config.workflow_mode === "branch_pr") {
+            process.stdout.write(`${infoMessage(incidentSummary)}\n`);
+        }
     }
 }
 async function resolveVerifyRecordInput(opts) {
     const by = String(opts.by ?? "").trim();
-    const note = String(opts.note ?? "").trim();
-    if (!by || !note) {
+    const inlineNote = String(opts.note ?? "").trim();
+    const noteFile = typeof opts.noteFile === "string" ? opts.noteFile.trim() : "";
+    if (!by) {
         throw new CliError({
             exitCode: 2,
             code: "E_USAGE",
-            message: "Missing required inputs: --by and --note.",
+            message: "Missing required input: --by.",
+        });
+    }
+    if (!inlineNote && !noteFile) {
+        throw new CliError({
+            exitCode: 2,
+            code: "E_USAGE",
+            message: "Provide exactly one of --note or --note-file.",
+        });
+    }
+    if (inlineNote && noteFile) {
+        throw new CliError({
+            exitCode: 2,
+            code: "E_USAGE",
+            message: "Options --note and --note-file are mutually exclusive.",
         });
     }
     if (typeof opts.details === "string" && typeof opts.file === "string") {
@@ -63,6 +172,22 @@ async function resolveVerifyRecordInput(opts) {
             message: "Options --details and --file are mutually exclusive.",
         });
     }
+    let note = inlineNote;
+    if (noteFile) {
+        try {
+            note = normalizeFileBackedVerifyNote(await readFile(path.resolve(opts.cwd, noteFile), "utf8"));
+        }
+        catch (err) {
+            throw mapCoreError(err, { command: opts.command, filePath: noteFile });
+        }
+    }
+    if (!note) {
+        throw new CliError({
+            exitCode: 2,
+            code: "E_USAGE",
+            message: "Verification note cannot be empty after normalization.",
+        });
+    }
     let details = typeof opts.details === "string" ? opts.details : null;
     if (typeof opts.file === "string") {
         try {
@@ -89,6 +214,8 @@ async function executeVerifyRecordCommand(opts) {
             by: input.by,
             note: input.note,
             details: input.details,
+            finding: opts.finding,
+            collectIncidents: opts.collectIncidents,
             quiet: opts.quiet,
         });
         return 0;
@@ -100,15 +227,70 @@ async function executeVerifyRecordCommand(opts) {
     }
 }
 export async function cmdTaskVerifyOk(opts) {
-    return await executeVerifyRecordCommand({ ...opts, state: "ok", command: "task verify ok" });
+    return await executeVerifyRecordCommand({
+        ...opts,
+        state: "ok",
+        command: "task verify ok",
+        finding: typeof opts.observation === "string" &&
+            typeof opts.impact === "string" &&
+            typeof opts.resolution === "string"
+            ? {
+                observation: opts.observation,
+                impact: opts.impact,
+                resolution: opts.resolution,
+                localOnly: opts.localOnly === true,
+                repoFixable: opts.repoFixable === true,
+                incidentScope: opts.incidentScope,
+                incidentTags: opts.incidentTags ?? [],
+                incidentMatch: opts.incidentMatch ?? [],
+                incidentAdvice: opts.incidentAdvice,
+                incidentRule: opts.incidentRule,
+            }
+            : null,
+    });
 }
 export async function cmdTaskVerifyRework(opts) {
     return await executeVerifyRecordCommand({
         ...opts,
         state: "needs_rework",
         command: "task verify rework",
+        finding: typeof opts.observation === "string" &&
+            typeof opts.impact === "string" &&
+            typeof opts.resolution === "string"
+            ? {
+                observation: opts.observation,
+                impact: opts.impact,
+                resolution: opts.resolution,
+                localOnly: opts.localOnly === true,
+                repoFixable: opts.repoFixable === true,
+                incidentScope: opts.incidentScope,
+                incidentTags: opts.incidentTags ?? [],
+                incidentMatch: opts.incidentMatch ?? [],
+                incidentAdvice: opts.incidentAdvice,
+                incidentRule: opts.incidentRule,
+            }
+            : null,
     });
 }
 export async function cmdVerifyParsed(opts) {
-    return await executeVerifyRecordCommand({ ...opts, command: "verify" });
+    return await executeVerifyRecordCommand({
+        ...opts,
+        command: "verify",
+        finding: typeof opts.observation === "string" &&
+            typeof opts.impact === "string" &&
+            typeof opts.resolution === "string"
+            ? {
+                observation: opts.observation,
+                impact: opts.impact,
+                resolution: opts.resolution,
+                localOnly: opts.localOnly === true,
+                repoFixable: opts.repoFixable === true,
+                incidentScope: opts.incidentScope,
+                incidentTags: opts.incidentTags ?? [],
+                incidentMatch: opts.incidentMatch ?? [],
+                incidentAdvice: opts.incidentAdvice,
+                incidentRule: opts.incidentRule,
+            }
+            : null,
+    });
 }

package/dist/commands/task/verify-rework.command.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"verify-rework.command.d.ts","sourceRoot":"","sources":["../../../src/commands/task/verify-rework.command.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,UAAU,EAAE,WAAW,EAAE,MAAM,wBAAwB,CAAC;AACtE,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AAGhE,OAAO,EAKL,KAAK,kBAAkB,EACxB,MAAM,4BAA4B,CAAC;AAEpC,MAAM,MAAM,sBAAsB,GAAG,kBAAkB,GAAG;IACxD,MAAM,EAAE,MAAM,CAAC;CAChB,CAAC;AAEF,eAAO,MAAM,oBAAoB,EAAE,WAAW,CAAC,sBAAsB,CAwBpE,CAAC;AAEF,wBAAgB,8BAA8B,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,MAAM,KAAK,OAAO,CAAC,cAAc,CAAC,IAC/E,KAAK,UAAU,EAAE,GAAG,sBAAsB,KAAG,OAAO,CAAC,MAAM,CAAC,CAa3E"}
+{"version":3,"file":"verify-rework.command.d.ts","sourceRoot":"","sources":["../../../src/commands/task/verify-rework.command.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,UAAU,EAAE,WAAW,EAAE,MAAM,wBAAwB,CAAC;AACtE,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AAGhE,OAAO,EAOL,KAAK,kBAAkB,EACxB,MAAM,4BAA4B,CAAC;AAEpC,MAAM,MAAM,sBAAsB,GAAG,kBAAkB,GAAG;IACxD,MAAM,EAAE,MAAM,CAAC;CAChB,CAAC;AAEF,eAAO,MAAM,oBAAoB,EAAE,WAAW,CAAC,sBAAsB,CAyBpE,CAAC;AAEF,wBAAgB,8BAA8B,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,MAAM,KAAK,OAAO,CAAC,cAAc,CAAC,IAC/E,KAAK,UAAU,EAAE,GAAG,sBAAsB,KAAG,OAAO,CAAC,MAAM,CAAC,CAyB3E"}

package/dist/commands/task/verify-rework.command.js

@@ -1,5 +1,5 @@
 import { cmdTaskVerifyRework } from "./verify-record.js";
-import { parseVerifyCommonOptions, validateVerifyDetailsFileExclusive, validateVerifyNonEmptyInput, verifyCommonOptions, } from "./verify-command-shared.js";
+import { parseVerifyCommonOptions, validateVerifyDetailsFileExclusive, validateVerifyFindingSource, validateVerifyNonEmptyInput, validateVerifyNoteSource, verifyCommonOptions, } from "./verify-command-shared.js";
 export const taskVerifyReworkSpec = {
     id: ["task", "verify", "rework"],
     group: "Task",
@@ -17,7 +17,8 @@ export const taskVerifyReworkSpec = {
             message: "Provide at most one of --details or --file.",
         });
         validateVerifyNonEmptyInput(raw, taskVerifyReworkSpec, "by");
-        validateVerifyNonEmptyInput(raw, taskVerifyReworkSpec, "note");
+        validateVerifyNoteSource(raw, taskVerifyReworkSpec);
+        validateVerifyFindingSource(raw, taskVerifyReworkSpec);
     },
     parse: (raw) => ({
         taskId: String(raw.args["task-id"]),
@@ -33,9 +34,21 @@ export function makeRunTaskVerifyReworkHandler(getCtx) {
             taskId: p.taskId,
             by: p.by,
             note: p.note,
+            noteFile: p.noteFile,
             details: p.details,
             file: p.file,
+            collectIncidents: p.collectIncidents,
             quiet: p.quiet,
+            observation: p.observation,
+            impact: p.impact,
+            resolution: p.resolution,
+            localOnly: p.localOnly,
+            repoFixable: p.repoFixable,
+            incidentScope: p.incidentScope,
+            incidentTags: p.incidentTags,
+            incidentMatch: p.incidentMatch,
+            incidentAdvice: p.incidentAdvice,
+            incidentRule: p.incidentRule,
         });
     };
 }

package/dist/commands/task/verify-show.command.d.ts

@@ -1,5 +1,5 @@
 import type { CommandCtx, CommandSpec } from "../../cli/spec/spec.js";
-import type { CommandContext } from "../shared/task-backend.js";
+import { type CommandContext } from "../shared/task-backend.js";
 export type TaskVerifyShowParsed = {
     taskId: string;
     quiet: boolean;

package/dist/commands/task/verify-show.command.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"verify-show.command.d.ts","sourceRoot":"","sources":["../../../src/commands/task/verify-show.command.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,UAAU,EAAE,WAAW,EAAE,MAAM,wBAAwB,CAAC;AACtE,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AAIhE,MAAM,MAAM,oBAAoB,GAAG;IACjC,MAAM,EAAE,MAAM,CAAC;IACf,KAAK,EAAE,OAAO,CAAC;CAChB,CAAC;AAEF,eAAO,MAAM,kBAAkB,EAAE,WAAW,CAAC,oBAAoB,CA6BhE,CAAC;AAEF,wBAAgB,4BAA4B,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,MAAM,KAAK,OAAO,CAAC,cAAc,CAAC,IAC7E,KAAK,UAAU,EAAE,GAAG,oBAAoB,KAAG,OAAO,CAAC,MAAM,CAAC,CAUzE"}
+{"version":3,"file":"verify-show.command.d.ts","sourceRoot":"","sources":["../../../src/commands/task/verify-show.command.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,UAAU,EAAE,WAAW,EAAE,MAAM,wBAAwB,CAAC;AAGtE,OAAO,EAAuB,KAAK,cAAc,EAAE,MAAM,2BAA2B,CAAC;AAKrF,MAAM,MAAM,oBAAoB,GAAG;IACjC,MAAM,EAAE,MAAM,CAAC;IACf,KAAK,EAAE,OAAO,CAAC;CAChB,CAAC;AAEF,eAAO,MAAM,kBAAkB,EAAE,WAAW,CAAC,oBAAoB,CA6BhE,CAAC;AAEF,wBAAgB,4BAA4B,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,MAAM,KAAK,OAAO,CAAC,cAAc,CAAC,IAC7E,KAAK,UAAU,EAAE,GAAG,oBAAoB,KAAG,OAAO,CAAC,MAAM,CAAC,CAkCzE"}

package/dist/commands/task/verify-show.command.js

@@ -1,4 +1,8 @@
+import { backendNotSupportedMessage } from "../../cli/output.js";
+import { CliError } from "../../shared/errors.js";
+import { loadTaskFromContext } from "../shared/task-backend.js";
 import { cmdTaskDocShow } from "./doc.js";
+import { assertVerifyStepsFilled, extractDocSection, isVerifyStepsFilled } from "./shared.js";
 export const taskVerifyShowSpec = {
     id: ["task", "verify-show"],
     group: "Task",
@@ -30,8 +34,31 @@ export const taskVerifyShowSpec = {
 };
 export function makeRunTaskVerifyShowHandler(getCtx) {
     return async (ctx, p) => {
+        const commandCtx = await getCtx("task verify-show");
+        const backend = commandCtx.taskBackend;
+        if (!backend.getTaskDoc) {
+            throw new CliError({
+                exitCode: 2,
+                code: "E_USAGE",
+                message: backendNotSupportedMessage("task docs"),
+            });
+        }
+        const task = await loadTaskFromContext({ ctx: commandCtx, taskId: p.taskId });
+        const doc = typeof task.doc === "string" ? task.doc : ((await backend.getTaskDoc(p.taskId)) ?? "");
+        const verifySteps = extractDocSection(doc, "Verify Steps");
+        if (!p.quiet) {
+            assertVerifyStepsFilled({
+                taskId: p.taskId,
+                sectionText: verifySteps,
+                action: "show Verify Steps",
+                guidance: "fill it before verification",
+            });
+        }
+        else if (!isVerifyStepsFilled(verifySteps)) {
+            return 0;
+        }
         return await cmdTaskDocShow({
-            ctx: await getCtx("task verify-show"),
+            ctx: commandCtx,
             cwd: ctx.cwd,
             rootOverride: ctx.rootOverride,
             taskId: p.taskId,

package/dist/commands/upgrade.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"upgrade.d.ts","sourceRoot":"","sources":["../../src/commands/upgrade.ts"],"names":[],"mappings":"AAgCA,MAAM,MAAM,YAAY,GAAG;IACzB,MAAM,CAAC,EAAE,MAAM,CAAC;IAChB,GAAG,CAAC,EAAE,MAAM,CAAC;IACb,MAAM,CAAC,EAAE,MAAM,CAAC;IAChB,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB,KAAK,CAAC,EAAE,MAAM,CAAC;IACf,aAAa,CAAC,EAAE,MAAM,CAAC;IACvB,IAAI,EAAE,OAAO,GAAG,MAAM,CAAC;IACvB,MAAM,EAAE,OAAO,CAAC;IAChB,YAAY,EAAE,OAAO,CAAC;IACtB,MAAM,EAAE,OAAO,CAAC;IAChB,MAAM,EAAE,OAAO,CAAC;IAChB,eAAe,EAAE,OAAO,CAAC;IACzB,GAAG,EAAE,OAAO,CAAC;CACd,CAAC;AAIF,wBAAsB,gBAAgB,CAAC,IAAI,EAAE;IAC3C,GAAG,EAAE,MAAM,CAAC;IACZ,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,KAAK,EAAE,YAAY,CAAC;CACrB,GAAG,OAAO,CAAC,MAAM,CAAC,CAoQlB;AAED,OAAO,EACL,kCAAkC,EAClC,qBAAqB,EACrB,iCAAiC,GAClC,MAAM,qBAAqB,CAAC"}
+{"version":3,"file":"upgrade.d.ts","sourceRoot":"","sources":["../../src/commands/upgrade.ts"],"names":[],"mappings":"AAgCA,MAAM,MAAM,YAAY,GAAG;IACzB,MAAM,CAAC,EAAE,MAAM,CAAC;IAChB,GAAG,CAAC,EAAE,MAAM,CAAC;IACb,MAAM,CAAC,EAAE,MAAM,CAAC;IAChB,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB,KAAK,CAAC,EAAE,MAAM,CAAC;IACf,aAAa,CAAC,EAAE,MAAM,CAAC;IACvB,IAAI,EAAE,OAAO,GAAG,MAAM,CAAC;IACvB,MAAM,EAAE,OAAO,CAAC;IAChB,YAAY,EAAE,OAAO,CAAC;IACtB,MAAM,EAAE,OAAO,CAAC;IAChB,MAAM,EAAE,OAAO,CAAC;IAChB,eAAe,EAAE,OAAO,CAAC;IACzB,GAAG,EAAE,OAAO,CAAC;CACd,CAAC;AAIF,wBAAsB,gBAAgB,CAAC,IAAI,EAAE;IAC3C,GAAG,EAAE,MAAM,CAAC;IACZ,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,KAAK,EAAE,YAAY,CAAC;CACrB,GAAG,OAAO,CAAC,MAAM,CAAC,CAyQlB;AAED,OAAO,EACL,kCAAkC,EAClC,qBAAqB,EACrB,iCAAiC,GAClC,MAAM,qBAAqB,CAAC"}

package/dist/commands/upgrade.js

@@ -62,7 +62,12 @@ export async function cmdUpgradeParsed(opts) {
     const ensureApproved = async (reason) => {
         if (networkApproved)
             return;
-        await ensureNetworkApproved({ config: loaded.config, yes: flags.yes, reason });
+        await ensureNetworkApproved({
+            action: "upgrade_apply",
+            config: loaded.config,
+            yes: flags.yes,
+            reason,
+        });
         networkApproved = true;
     };
     const hasBundle = Boolean(flags.bundle);

package/dist/commands/verify.run.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"verify.run.d.ts","sourceRoot":"","sources":["../../src/commands/verify.run.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,qBAAqB,CAAC;AACtD,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,0BAA0B,CAAC;AAG/D,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,kBAAkB,CAAC;AAErD,wBAAgB,oBAAoB,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,MAAM,KAAK,OAAO,CAAC,cAAc,CAAC,IACrE,KAAK,UAAU,EAAE,GAAG,YAAY,KAAG,OAAO,CAAC,MAAM,CAAC,CAcjE"}
+{"version":3,"file":"verify.run.d.ts","sourceRoot":"","sources":["../../src/commands/verify.run.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,qBAAqB,CAAC;AACtD,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,0BAA0B,CAAC;AAG/D,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,kBAAkB,CAAC;AAErD,wBAAgB,oBAAoB,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,MAAM,KAAK,OAAO,CAAC,cAAc,CAAC,IACrE,KAAK,UAAU,EAAE,GAAG,YAAY,KAAG,OAAO,CAAC,MAAM,CAAC,CA0BjE"}

package/dist/commands/verify.run.js

@@ -9,8 +9,20 @@ export function makeRunVerifyHandler(getCtx) {
             state: p.state,
             by: p.by,
             note: p.note,
+            noteFile: p.noteFile,
             details: p.details,
             file: p.file,
+            collectIncidents: p.collectIncidents,
+            observation: p.observation,
+            impact: p.impact,
+            resolution: p.resolution,
+            localOnly: p.localOnly,
+            repoFixable: p.repoFixable,
+            incidentScope: p.incidentScope,
+            incidentTags: p.incidentTags,
+            incidentMatch: p.incidentMatch,
+            incidentAdvice: p.incidentAdvice,
+            incidentRule: p.incidentRule,
             quiet: p.quiet,
         });
     };

package/dist/commands/verify.spec.d.ts

@@ -1,13 +1,9 @@
 import type { CommandSpec } from "../cli/spec/spec.js";
+import { type VerifyCommonParsed } from "./task/verify-command-shared.js";
 type VerifyState = "ok" | "needs_rework";
-export type VerifyParsed = {
+export type VerifyParsed = VerifyCommonParsed & {
     taskId: string;
     state: VerifyState;
-    by: string;
-    note: string;
-    details?: string;
-    file?: string;
-    quiet: boolean;
 };
 export declare const verifySpec: CommandSpec<VerifyParsed>;
 export {};

package/dist/commands/verify.spec.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"verify.spec.d.ts","sourceRoot":"","sources":["../../src/commands/verify.spec.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,qBAAqB,CAAC;AAOvD,KAAK,WAAW,GAAG,IAAI,GAAG,cAAc,CAAC;AAEzC,MAAM,MAAM,YAAY,GAAG;IACzB,MAAM,EAAE,MAAM,CAAC;IACf,KAAK,EAAE,WAAW,CAAC;IACnB,EAAE,EAAE,MAAM,CAAC;IACX,IAAI,EAAE,MAAM,CAAC;IACb,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,KAAK,EAAE,OAAO,CAAC;CAChB,CAAC;AAEF,eAAO,MAAM,UAAU,EAAE,WAAW,CAAC,YAAY,CAoFhD,CAAC"}
+{"version":3,"file":"verify.spec.d.ts","sourceRoot":"","sources":["../../src/commands/verify.spec.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,qBAAqB,CAAC;AAEvD,OAAO,EACL,KAAK,kBAAkB,EAOxB,MAAM,iCAAiC,CAAC;AAEzC,KAAK,WAAW,GAAG,IAAI,GAAG,cAAc,CAAC;AAEzC,MAAM,MAAM,YAAY,GAAG,kBAAkB,GAAG;IAC9C,MAAM,EAAE,MAAM,CAAC;IACf,KAAK,EAAE,WAAW,CAAC;CACpB,CAAC;AAEF,eAAO,MAAM,UAAU,EAAE,WAAW,CAAC,YAAY,CAiHhD,CAAC"}

package/dist/commands/verify.spec.js

@@ -1,9 +1,9 @@
 import { usageError } from "../cli/spec/errors.js";
-import { parseVerifyCommonOptions, validateVerifyDetailsFileExclusive, } from "./task/verify-command-shared.js";
+import { parseVerifyCommonOptions, validateVerifyDetailsFileExclusive, validateVerifyFindingSource, validateVerifyNonEmptyInput, validateVerifyNoteSource, verifyFindingOptions, } from "./task/verify-command-shared.js";
 export const verifySpec = {
     id: ["verify"],
     group: "Lifecycle",
-    summary: "Record a verification outcome for a task (record-only; does not execute commands).",
+    summary: "Record a verification outcome for a task; incident candidates stay task-local unless collected explicitly.",
     args: [
         {
             name: "task-id",
@@ -36,9 +36,14 @@ export const verifySpec = {
             kind: "string",
             name: "note",
             valueHint: "<text>",
-            required: true,
             description: "Short note describing the verification outcome.",
         },
+        {
+            kind: "string",
+            name: "note-file",
+            valueHint: "<path>",
+            description: "Read the verification note from a file path (mutually exclusive with --note).",
+        },
         {
             kind: "string",
             name: "details",
@@ -51,17 +56,36 @@ export const verifySpec = {
             valueHint: "<path>",
             description: "Read details from a file path (mutually exclusive with --details).",
         },
+        {
+            kind: "boolean",
+            name: "collect-incidents",
+            default: false,
+            description: "After recording verification, collect promotable findings into incidents.md immediately.",
+        },
         { kind: "boolean", name: "quiet", default: false, description: "Suppress output." },
+        ...verifyFindingOptions,
     ],
     examples: [
         {
             cmd: 'agentplane verify 202602030608-F1Q8AB --ok --by REVIEWER --note "Looks good" --quiet',
             why: "Record an OK verification outcome.",
         },
+        {
+            cmd: "agentplane verify 202602030608-F1Q8AB --ok --by REVIEWER --note-file ./verify-note.txt",
+            why: "Record an OK verification outcome using a file-backed note.",
+        },
         {
             cmd: 'agentplane verify 202602030608-F1Q8AB --rework --by REVIEWER --note "Needs changes" --details "Missing tests"',
             why: "Record a needs-rework outcome with details.",
         },
+        {
+            cmd: 'agentplane verify 202602030608-F1Q8AB --ok --by REVIEWER --note "Looks good" --observation "Repeated recovery was manual." --impact "Operators needed a second command." --resolution "Append structured findings during verify."',
+            why: "Record verification and append a promotable structured finding in one command.",
+        },
+        {
+            cmd: 'agentplane verify 202602030608-F1Q8AB --ok --by REVIEWER --note "Looks good" --collect-incidents',
+            why: "Record verification and collect promotable findings into incidents.md immediately.",
+        },
     ],
     validateRaw: (raw) => {
         const ok = raw.opts.ok === true;
@@ -74,6 +98,9 @@ export const verifySpec = {
             });
         }
         validateVerifyDetailsFileExclusive(raw, verifySpec, { command: "verify" });
+        validateVerifyNonEmptyInput(raw, verifySpec, "by");
+        validateVerifyNoteSource(raw, verifySpec, { command: "verify" });
+        validateVerifyFindingSource(raw, verifySpec, { command: "verify" });
     },
     parse: (raw) => {
         const ok = raw.opts.ok === true;

package/dist/policy/engine.d.ts

@@ -1,7 +1,9 @@
 import type { AgentplaneConfig } from "@agentplaneorg/core";
+import { type PolicyActionDescriptor } from "./taxonomy.js";
 import type { PolicyAction, PolicyContext, PolicyProblem } from "./types.js";
 export type PolicyDecision = {
     ok: boolean;
+    action: PolicyActionDescriptor;
     violations: PolicyViolation[];
 };
 export type PolicyViolation = {
@@ -10,7 +12,7 @@ export type PolicyViolation = {
     exitCode: number;
     message: string;
 };
-export type ActionId = PolicyAction | "task_list" | "task_new" | "upgrade_apply" | "doctor_fix" | (string & {});
+export type ActionId = PolicyAction | (string & {});
 export type PolicyEngineContext = Omit<PolicyContext, "action"> & {
     action: ActionId;
     config: AgentplaneConfig;

package/dist/policy/engine.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"engine.d.ts","sourceRoot":"","sources":["../../src/policy/engine.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,gBAAgB,EAAE,MAAM,qBAAqB,CAAC;AAG5D,OAAO,KAAK,EAAE,YAAY,EAAE,aAAa,EAAE,aAAa,EAAgB,MAAM,YAAY,CAAC;AAE3F,MAAM,MAAM,cAAc,GAAG;IAC3B,EAAE,EAAE,OAAO,CAAC;IACZ,UAAU,EAAE,eAAe,EAAE,CAAC;CAC/B,CAAC;AAEF,MAAM,MAAM,eAAe,GAAG;IAC5B,KAAK,EAAE,OAAO,GAAG,SAAS,CAAC;IAC3B,IAAI,EAAE,aAAa,CAAC,MAAM,CAAC,CAAC;IAC5B,QAAQ,EAAE,MAAM,CAAC;IACjB,OAAO,EAAE,MAAM,CAAC;CACjB,CAAC;AAEF,MAAM,MAAM,QAAQ,GAChB,YAAY,GACZ,WAAW,GACX,UAAU,GACV,eAAe,GACf,YAAY,GACZ,CAAC,MAAM,GAAG,EAAE,CAAC,CAAC;AAElB,MAAM,MAAM,mBAAmB,GAAG,IAAI,CAAC,aAAa,EAAE,QAAQ,CAAC,GAAG;IAChE,MAAM,EAAE,QAAQ,CAAC;IACjB,MAAM,EAAE,gBAAgB,CAAC;CAC1B,CAAC;AAkBF,qBAAa,YAAY;IACvB,QAAQ,CAAC,GAAG,EAAE,mBAAmB,GAAG,cAAc;CAkBnD"}
+{"version":3,"file":"engine.d.ts","sourceRoot":"","sources":["../../src/policy/engine.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,gBAAgB,EAAE,MAAM,qBAAqB,CAAC;AAG5D,OAAO,EAAiC,KAAK,sBAAsB,EAAE,MAAM,eAAe,CAAC;AAC3F,OAAO,KAAK,EAAE,YAAY,EAAE,aAAa,EAAE,aAAa,EAAgB,MAAM,YAAY,CAAC;AAE3F,MAAM,MAAM,cAAc,GAAG;IAC3B,EAAE,EAAE,OAAO,CAAC;IACZ,MAAM,EAAE,sBAAsB,CAAC;IAC/B,UAAU,EAAE,eAAe,EAAE,CAAC;CAC/B,CAAC;AAEF,MAAM,MAAM,eAAe,GAAG;IAC5B,KAAK,EAAE,OAAO,GAAG,SAAS,CAAC;IAC3B,IAAI,EAAE,aAAa,CAAC,MAAM,CAAC,CAAC;IAC5B,QAAQ,EAAE,MAAM,CAAC;IACjB,OAAO,EAAE,MAAM,CAAC;CACjB,CAAC;AAEF,MAAM,MAAM,QAAQ,GAAG,YAAY,GAAG,CAAC,MAAM,GAAG,EAAE,CAAC,CAAC;AAEpD,MAAM,MAAM,mBAAmB,GAAG,IAAI,CAAC,aAAa,EAAE,QAAQ,CAAC,GAAG;IAChE,MAAM,EAAE,QAAQ,CAAC;IACjB,MAAM,EAAE,gBAAgB,CAAC;CAC1B,CAAC;AAkBF,qBAAa,YAAY;IACvB,QAAQ,CAAC,GAAG,EAAE,mBAAmB,GAAG,cAAc;CAcnD"}

package/dist/policy/engine.js

@@ -1,4 +1,5 @@
 import { evaluatePolicy } from "./evaluate.js";
+import { resolvePolicyActionDescriptor } from "./taxonomy.js";
 function toViolations(result) {
     const out = [];
     for (const err of result.errors) {
@@ -17,16 +18,14 @@ function toViolations(result) {
 export class PolicyEngine {
     evaluate(ctx) {
         const action = ctx.action;
+        const descriptor = resolvePolicyActionDescriptor(action);
         // Delegate existing policy actions to the current rule engine.
-        if (action === "guard_commit" ||
-            action === "commit" ||
-            action === "hook_pre_commit" ||
-            action === "hook_commit_msg") {
+        if (descriptor.enforcement === "git_rules") {
             const result = evaluatePolicy(ctx);
-            return { ok: result.ok, violations: toViolations(result) };
+            return { ok: result.ok, action: descriptor, violations: toViolations(result) };
         }
         // Default: no-op. Usecases should still call into the engine so we can harden
         // policy coverage incrementally without duplicating checks across commands.
-        return { ok: true, violations: [] };
+        return { ok: true, action: descriptor, violations: [] };
     }
 }

package/dist/policy/taxonomy.d.ts

@@ -0,0 +1,17 @@
+export type KnownPolicyActionId = "guard_commit" | "commit" | "hook_pre_commit" | "hook_commit_msg" | "network_access" | "force_action" | "policy_write" | "config_write" | "dangerous_fs" | "git_push" | "task_list" | "task_new" | "task_mutation" | "task_status_transition" | "task_start" | "task_block" | "task_set_status" | "task_finish" | "task_plan_set" | "task_plan_approve" | "task_verify" | "task_run" | "scenario_execute" | "recipe_install" | "recipe_list_remote" | "backend_sync" | "backend_migrate_canonical_state" | "backend_inspect" | "upgrade_apply" | "release_apply" | "doctor_fix";
+export type PolicyActionId = KnownPolicyActionId | (string & {});
+export type PolicyActionFamily = "git" | "task" | "runner" | "recipe" | "backend" | "release" | "upgrade" | "workflow" | "network" | "policy" | "config" | "filesystem" | "diagnostics" | "custom";
+export type PolicyApprovalKind = "network_access" | "force_action" | "policy_write" | "config_write" | "dangerous_fs" | "git_push";
+export type PolicyActionDescriptor = {
+    id: PolicyActionId;
+    family: PolicyActionFamily;
+    summary: string;
+    mutates_state: boolean;
+    risky: boolean;
+    destructive: boolean;
+    approval: PolicyApprovalKind | null;
+    enforcement: "git_rules" | "approval_only" | "none";
+    source: "builtin" | "custom";
+};
+export declare function resolvePolicyActionDescriptor(action: PolicyActionId): PolicyActionDescriptor;
+//# sourceMappingURL=taxonomy.d.ts.map

package/dist/policy/taxonomy.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"taxonomy.d.ts","sourceRoot":"","sources":["../../src/policy/taxonomy.ts"],"names":[],"mappings":"AAAA,MAAM,MAAM,mBAAmB,GAC3B,cAAc,GACd,QAAQ,GACR,iBAAiB,GACjB,iBAAiB,GACjB,gBAAgB,GAChB,cAAc,GACd,cAAc,GACd,cAAc,GACd,cAAc,GACd,UAAU,GACV,WAAW,GACX,UAAU,GACV,eAAe,GACf,wBAAwB,GACxB,YAAY,GACZ,YAAY,GACZ,iBAAiB,GACjB,aAAa,GACb,eAAe,GACf,mBAAmB,GACnB,aAAa,GACb,UAAU,GACV,kBAAkB,GAClB,gBAAgB,GAChB,oBAAoB,GACpB,cAAc,GACd,iCAAiC,GACjC,iBAAiB,GACjB,eAAe,GACf,eAAe,GACf,YAAY,CAAC;AAEjB,MAAM,MAAM,cAAc,GAAG,mBAAmB,GAAG,CAAC,MAAM,GAAG,EAAE,CAAC,CAAC;AAEjE,MAAM,MAAM,kBAAkB,GAC1B,KAAK,GACL,MAAM,GACN,QAAQ,GACR,QAAQ,GACR,SAAS,GACT,SAAS,GACT,SAAS,GACT,UAAU,GACV,SAAS,GACT,QAAQ,GACR,QAAQ,GACR,YAAY,GACZ,aAAa,GACb,QAAQ,CAAC;AAEb,MAAM,MAAM,kBAAkB,GAC1B,gBAAgB,GAChB,cAAc,GACd,cAAc,GACd,cAAc,GACd,cAAc,GACd,UAAU,CAAC;AAEf,MAAM,MAAM,sBAAsB,GAAG;IACnC,EAAE,EAAE,cAAc,CAAC;IACnB,MAAM,EAAE,kBAAkB,CAAC;IAC3B,OAAO,EAAE,MAAM,CAAC;IAChB,aAAa,EAAE,OAAO,CAAC;IACvB,KAAK,EAAE,OAAO,CAAC;IACf,WAAW,EAAE,OAAO,CAAC;IACrB,QAAQ,EAAE,kBAAkB,GAAG,IAAI,CAAC;IACpC,WAAW,EAAE,WAAW,GAAG,eAAe,GAAG,MAAM,CAAC;IACpD,MAAM,EAAE,SAAS,GAAG,QAAQ,CAAC;CAC9B,CAAC;AA8RF,wBAAgB,6BAA6B,CAAC,MAAM,EAAE,cAAc,GAAG,sBAAsB,CAoB5F"}