agentplane 0.3.5 → 0.3.6

package/dist/commands/task/finish.js

@@ -28,6 +28,43 @@ async function clearDirectWorkLockIfMatches(opts) {
         // best-effort
     }
 }
+function assertTaskCanFinish(opts) {
+    if (!opts.force && String(opts.task.status || "TODO").toUpperCase() === "DONE") {
+        throw new CliError({
+            exitCode: 2,
+            code: "E_USAGE",
+            message: `Task is already DONE: ${opts.task.id} (use --force to override)`,
+        });
+    }
+    ensureVerificationSatisfiedIfRequired(opts.task, opts.config);
+    const normalizedDoc = ensureDocSections(typeof opts.task.doc === "string" ? opts.task.doc : "", opts.config.tasks.doc.required_sections);
+    ensureAgentFilledRequiredDocSections({
+        task: opts.task,
+        config: opts.config,
+        doc: normalizedDoc,
+        action: "finish task",
+    });
+    if (!opts.isMetaTask)
+        return;
+    const tags = Array.isArray(opts.task.tags)
+        ? opts.task.tags.filter((t) => typeof t === "string")
+        : [];
+    const isSpike = tags.includes("spike");
+    if (!isSpike && opts.taskCount === 1 && !opts.resultSummary) {
+        throw new CliError({
+            exitCode: 2,
+            code: "E_USAGE",
+            message: "Missing required --result for non-spike tasks.",
+        });
+    }
+    if (opts.resultProvided && !opts.resultSummary) {
+        throw new CliError({
+            exitCode: 2,
+            code: "E_USAGE",
+            message: "Invalid value for --result: empty.",
+        });
+    }
+}
 export async function cmdFinish(opts) {
     try {
         const ctx = opts.ctx ??
@@ -123,6 +160,7 @@ export async function cmdFinish(opts) {
         const shouldCloseCommit = opts.closeCommit === true || (defaultDirectCloseCommit && opts.noCloseCommit !== true);
         const metaTaskId = opts.taskIds.length === 1 ? (opts.taskIds[0] ?? "") : "";
         const wantMeta = typeof opts.result === "string" || typeof opts.risk === "string" || opts.breaking === true;
+        const resultProvided = typeof opts.result === "string";
         if (wantMeta && opts.taskIds.length !== 1) {
             throw new CliError({
                 exitCode: 2,
@@ -137,78 +175,87 @@ export async function cmdFinish(opts) {
         let primaryTag = null;
         for (const taskId of opts.taskIds) {
             const task = useStore ? await store.get(taskId) : await loadTaskFromContext({ ctx, taskId });
-            if (!opts.force) {
-                const currentStatus = String(task.status || "TODO").toUpperCase();
-                if (currentStatus === "DONE") {
-                    throw new CliError({
-                        exitCode: 2,
-                        code: "E_USAGE",
-                        message: `Task is already DONE: ${task.id} (use --force to override)`,
-                    });
-                }
-            }
+            assertTaskCanFinish({
+                task,
+                config: ctx.config,
+                taskCount: opts.taskIds.length,
+                isMetaTask: taskId === metaTaskId,
+                resultProvided,
+                resultSummary,
+                force: opts.force,
+            });
             if (taskId === primaryTaskId &&
                 (opts.commitFromComment || statusCommitRequested) &&
                 primaryStatusFrom === null) {
                 primaryStatusFrom = String(task.status || "TODO").toUpperCase();
                 primaryTag = resolvePrimaryTag(toStringArray(task.tags), ctx).primary;
             }
-            ensureVerificationSatisfiedIfRequired(task, ctx.config);
-            const normalizedDoc = ensureDocSections(typeof task.doc === "string" ? task.doc : "", ctx.config.tasks.doc.required_sections);
-            ensureAgentFilledRequiredDocSections({
-                task,
-                config: ctx.config,
-                doc: normalizedDoc,
-                action: "finish task",
-            });
-            if (taskId === metaTaskId) {
-                const tags = Array.isArray(task.tags)
-                    ? task.tags.filter((t) => typeof t === "string")
-                    : [];
-                const isSpike = tags.includes("spike");
-                if (!isSpike && opts.taskIds.length === 1 && !resultSummary) {
-                    throw new CliError({
-                        exitCode: 2,
-                        code: "E_USAGE",
-                        message: "Missing required --result for non-spike tasks.",
-                    });
-                }
-                if (typeof opts.result === "string" && !resultSummary) {
-                    throw new CliError({
-                        exitCode: 2,
-                        code: "E_USAGE",
-                        message: "Invalid value for --result: empty.",
+            const at = nowIso();
+            if (useStore) {
+                await store.patch(taskId, (current) => {
+                    assertTaskCanFinish({
+                        task: current,
+                        config: ctx.config,
+                        taskCount: opts.taskIds.length,
+                        isMetaTask: taskId === metaTaskId,
+                        resultProvided,
+                        resultSummary,
+                        force: opts.force,
                     });
-                }
+                    const currentStatus = String(current.status || "TODO").toUpperCase();
+                    return {
+                        task: {
+                            status: "DONE",
+                            commit: { hash: commitInfo.hash, message: commitInfo.message },
+                            ...(taskId === metaTaskId && resultSummary ? { result_summary: resultSummary } : {}),
+                            ...(taskId === metaTaskId && riskLevel ? { risk_level: riskLevel } : {}),
+                            ...(taskId === metaTaskId && breaking ? { breaking: true } : {}),
+                        },
+                        appendComments: [{ author: opts.author, body: opts.body }],
+                        appendEvents: [
+                            {
+                                type: "status",
+                                at,
+                                author: opts.author,
+                                from: currentStatus,
+                                to: "DONE",
+                                note: opts.body,
+                            },
+                        ],
+                        docMeta: {
+                            touch: true,
+                            updatedBy: opts.author,
+                            version: normalizeTaskDocVersion(current.doc_version),
+                        },
+                    };
+                });
+            }
+            else {
+                const existingComments = Array.isArray(task.comments)
+                    ? task.comments.filter((item) => !!item && typeof item.author === "string" && typeof item.body === "string")
+                    : [];
+                const nextTask = {
+                    ...task,
+                    status: "DONE",
+                    commit: { hash: commitInfo.hash, message: commitInfo.message },
+                    comments: [...existingComments, { author: opts.author, body: opts.body }],
+                    events: appendTaskEvent(task, {
+                        type: "status",
+                        at,
+                        author: opts.author,
+                        from: String(task.status || "TODO").toUpperCase(),
+                        to: "DONE",
+                        note: opts.body,
+                    }),
+                    result_summary: taskId === metaTaskId && resultSummary ? resultSummary : task.result_summary,
+                    risk_level: taskId === metaTaskId && riskLevel ? riskLevel : task.risk_level,
+                    breaking: taskId === metaTaskId && breaking ? true : task.breaking,
+                    doc_version: normalizeTaskDocVersion(task.doc_version),
+                    doc_updated_at: at,
+                    doc_updated_by: opts.author,
+                };
+                await ctx.taskBackend.writeTask(nextTask);
             }
-            const existingComments = Array.isArray(task.comments)
-                ? task.comments.filter((item) => !!item && typeof item.author === "string" && typeof item.body === "string")
-                : [];
-            const commentsValue = [...existingComments, { author: opts.author, body: opts.body }];
-            const at = nowIso();
-            const nextTask = {
-                ...task,
-                status: "DONE",
-                commit: { hash: commitInfo.hash, message: commitInfo.message },
-                comments: commentsValue,
-                events: appendTaskEvent(task, {
-                    type: "status",
-                    at,
-                    author: opts.author,
-                    from: String(task.status || "TODO").toUpperCase(),
-                    to: "DONE",
-                    note: opts.body,
-                }),
-                result_summary: taskId === metaTaskId && resultSummary ? resultSummary : task.result_summary,
-                risk_level: taskId === metaTaskId && riskLevel ? riskLevel : task.risk_level,
-                breaking: taskId === metaTaskId && breaking ? true : task.breaking,
-                doc_version: normalizeTaskDocVersion(task.doc_version),
-                doc_updated_at: at,
-                doc_updated_by: opts.author,
-            };
-            await (useStore
-                ? store.update(taskId, () => nextTask)
-                : ctx.taskBackend.writeTask(nextTask));
         }
         if (opts.commitFromComment || statusCommitRequested) {
             enforceStatusCommitPolicy({
@@ -233,6 +280,9 @@ export async function cmdFinish(opts) {
             }
         }
         if (opts.commitFromComment) {
+            if (!opts.quiet) {
+                process.stdout.write(`${infoMessage("task marked DONE; creating commit from verification comment")}\n`);
+            }
             if (typeof opts.commitEmoji === "string" && opts.commitEmoji.trim() !== "✅") {
                 throw new CliError({
                     exitCode: 2,
@@ -263,19 +313,28 @@ export async function cmdFinish(opts) {
             // commitFromComment creates the git commit and returns the actual head hash/subject.
             // Refresh task commit metadata to this hash and amend the same commit in local mode so
             // "task done" metadata does not require a manual follow-up close commit.
-            const taskAfterCommit = useStore
-                ? await store.get(primaryTaskId)
-                : await loadTaskFromContext({ ctx, taskId: primaryTaskId });
-            const updatedAfterCommit = {
-                ...taskAfterCommit,
-                commit: { hash: committed.hash, message: committed.message },
-                doc_version: normalizeTaskDocVersion(taskAfterCommit.doc_version),
-                doc_updated_at: nowIso(),
-                doc_updated_by: opts.author,
-            };
             await (useStore
-                ? store.update(primaryTaskId, () => updatedAfterCommit)
-                : ctx.taskBackend.writeTask(updatedAfterCommit));
+                ? store.patch(primaryTaskId, (current) => ({
+                    task: {
+                        commit: { hash: committed.hash, message: committed.message },
+                    },
+                    docMeta: {
+                        touch: true,
+                        updatedBy: opts.author,
+                        version: normalizeTaskDocVersion(current.doc_version),
+                    },
+                }))
+                : (async () => {
+                    const taskAfterCommit = await loadTaskFromContext({ ctx, taskId: primaryTaskId });
+                    const updatedAfterCommit = {
+                        ...taskAfterCommit,
+                        commit: { hash: committed.hash, message: committed.message },
+                        doc_version: normalizeTaskDocVersion(taskAfterCommit.doc_version),
+                        doc_updated_at: nowIso(),
+                        doc_updated_by: opts.author,
+                    };
+                    await ctx.taskBackend.writeTask(updatedAfterCommit);
+                })());
             if (backendWritesTaskReadmes) {
                 const workflowReadmeRelPath = path.join(ctx.config.paths.workflow_dir, primaryTaskId, "README.md");
                 await ctx.git.stage([workflowReadmeRelPath]);
@@ -294,6 +353,9 @@ export async function cmdFinish(opts) {
             }
         }
         if (statusCommitRequested) {
+            if (!opts.quiet) {
+                process.stdout.write(`${infoMessage("task marked DONE; creating status commit")}\n`);
+            }
             if (typeof opts.statusCommitEmoji === "string" && opts.statusCommitEmoji.trim() !== "✅") {
                 throw new CliError({
                     exitCode: 2,

package/dist/commands/task/migrate-doc.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"migrate-doc.d.ts","sourceRoot":"","sources":["../../../src/commands/task/migrate-doc.ts"],"names":[],"mappings":"AAiSA,wBAAsB,iBAAiB,CAAC,IAAI,EAAE;IAC5C,GAAG,EAAE,MAAM,CAAC;IACZ,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,GAAG,EAAE,OAAO,CAAC;IACb,KAAK,EAAE,OAAO,CAAC;IACf,OAAO,EAAE,MAAM,EAAE,CAAC;CACnB,GAAG,OAAO,CAAC,MAAM,CAAC,CAqDlB"}
+{"version":3,"file":"migrate-doc.d.ts","sourceRoot":"","sources":["../../../src/commands/task/migrate-doc.ts"],"names":[],"mappings":"AA2RA,wBAAsB,iBAAiB,CAAC,IAAI,EAAE;IAC5C,GAAG,EAAE,MAAM,CAAC;IACZ,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,GAAG,EAAE,OAAO,CAAC;IACb,KAAK,EAAE,OAAO,CAAC;IACf,OAAO,EAAE,MAAM,EAAE,CAAC;CACnB,GAAG,OAAO,CAAC,MAAM,CAAC,CAqDlB"}

package/dist/commands/task/migrate-doc.js

@@ -7,7 +7,7 @@ import { fileExists, getPathKind } from "../../cli/fs-utils.js";
 import { successMessage } from "../../cli/output.js";
 import { CliError } from "../../shared/errors.js";
 import { exportTaskProjectionSnapshot, loadCommandContext } from "../shared/task-backend.js";
-import { extractDocSection, extractTaskObservationSection, normalizeTaskDocVersion, normalizeVerificationSectionLayout, } from "./shared/docs.js";
+import { extractDocSection, extractTaskObservationSection, decodeEscapedTaskTextNewlines, normalizeTaskDocVersion, normalizeVerificationSectionLayout, } from "./shared/docs.js";
 import { defaultTaskDocV3 } from "./doc-template.js";
 const V3_CANONICAL_ORDER = [
     "Summary",
@@ -61,13 +61,7 @@ function renderMarkdownSections(sections) {
 function normalizeLiteralNewlinesInHumanSection(title, text) {
     if (!HUMAN_TEXT_SECTIONS.has(normalizeSectionKey(title)))
         return text.trimEnd();
-    let next = text.replaceAll("\r\n", "\n");
-    const escapedDoubleNewline = next.includes(String.raw `\n\n`) || next.includes(String.raw `\r\n\r\n`);
-    const escapedNewlineMatches = next.match(/\\n/g) ?? [];
-    if (escapedDoubleNewline || escapedNewlineMatches.length >= 2) {
-        next = next.replaceAll(String.raw `\r\n`, "\n").replaceAll(String.raw `\n`, "\n");
-    }
-    return next.trimEnd();
+    return decodeEscapedTaskTextNewlines(text).trimEnd();
 }
 function firstSectionText(sections, title) {
     const target = normalizeSectionKey(title);

package/dist/commands/task/plan-set.command.js

@@ -10,7 +10,7 @@ export const taskPlanSetSpec = {
             kind: "string",
             name: "text",
             valueHint: "<text>",
-            description: "Plan text to write into the task README Plan section.",
+            description: String.raw `Plan text to write into the task README Plan section. Literal escaped newlines (\n) are normalized for inline text.`,
         },
         {
             kind: "string",

package/dist/commands/task/plan.command.d.ts

@@ -0,0 +1,8 @@
+import type { CommandHandler, CommandSpec } from "../../cli/spec/spec.js";
+type TaskPlanGroupParsed = {
+    cmd: string[];
+};
+export declare const taskPlanSpec: CommandSpec<TaskPlanGroupParsed>;
+export declare const runTaskPlan: CommandHandler<TaskPlanGroupParsed>;
+export {};
+//# sourceMappingURL=plan.command.d.ts.map

package/dist/commands/task/plan.command.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"plan.command.d.ts","sourceRoot":"","sources":["../../../src/commands/task/plan.command.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAc,cAAc,EAAE,WAAW,EAAE,MAAM,wBAAwB,CAAC;AAItF,KAAK,mBAAmB,GAAG;IAAE,GAAG,EAAE,MAAM,EAAE,CAAA;CAAE,CAAC;AAI7C,eAAO,MAAM,YAAY,EAAE,WAAW,CAAC,mBAAmB,CAqBzD,CAAC;AAEF,eAAO,MAAM,WAAW,EAAE,cAAc,CAAC,mBAAmB,CAW3D,CAAC"}

package/dist/commands/task/plan.command.js

@@ -0,0 +1,37 @@
+import { usageError } from "../../cli/spec/errors.js";
+import { suggestOne } from "../../cli/spec/suggest.js";
+const TASK_PLAN_SUBCOMMANDS = ["set", "approve", "reject"];
+export const taskPlanSpec = {
+    id: ["task", "plan"],
+    group: "Task",
+    summary: "Task plan commands (set/approve/reject).",
+    synopsis: ["agentplane task plan <set|approve|reject> [args] [options]"],
+    args: [{ name: "cmd", required: false, variadic: true, valueHint: "<subcommand>" }],
+    examples: [
+        {
+            cmd: 'agentplane task plan set <task-id> --text "..." --updated-by ORCHESTRATOR',
+            why: "Write or replace the task plan.",
+        },
+        {
+            cmd: "agentplane task plan approve <task-id> --by ORCHESTRATOR",
+            why: "Approve the current task plan.",
+        },
+        {
+            cmd: 'agentplane task plan reject <task-id> --by ORCHESTRATOR --note "..."',
+            why: "Reject the current task plan with a note.",
+        },
+    ],
+    parse: (raw) => ({ cmd: (raw.args.cmd ?? []) }),
+};
+export const runTaskPlan = (_ctx, p) => {
+    const input = p.cmd.join(" ");
+    const suggestion = suggestOne(input, [...TASK_PLAN_SUBCOMMANDS]);
+    const suffix = suggestion ? ` Did you mean: ${suggestion}?` : "";
+    const message = p.cmd.length === 0 ? "Missing subcommand." : `Unknown subcommand: ${p.cmd[0]}.`;
+    throw usageError({
+        spec: taskPlanSpec,
+        command: "task plan",
+        message: `${message}${suffix}`,
+        context: { command: "task plan" },
+    });
+};

package/dist/commands/task/plan.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"plan.d.ts","sourceRoot":"","sources":["../../../src/commands/task/plan.ts"],"names":[],"mappings":"AASA,OAAO,EAGL,KAAK,cAAc,EACpB,MAAM,2BAA2B,CAAC;AAuDnC,wBAAsB,cAAc,CAAC,IAAI,EAAE;IACzC,GAAG,CAAC,EAAE,cAAc,CAAC;IACrB,GAAG,EAAE,MAAM,CAAC;IACZ,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,MAAM,EAAE,MAAM,CAAC;IACf,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,SAAS,CAAC,EAAE,MAAM,CAAC;CACpB,GAAG,OAAO,CAAC,MAAM,CAAC,CA6ElB;AAED,wBAAsB,kBAAkB,CAAC,IAAI,EAAE;IAC7C,GAAG,CAAC,EAAE,cAAc,CAAC;IACrB,GAAG,EAAE,MAAM,CAAC;IACZ,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,MAAM,EAAE,MAAM,CAAC;IACf,EAAE,EAAE,MAAM,CAAC;IACX,IAAI,CAAC,EAAE,MAAM,CAAC;CACf,GAAG,OAAO,CAAC,MAAM,CAAC,CA4FlB;AAED,wBAAsB,iBAAiB,CAAC,IAAI,EAAE;IAC5C,GAAG,CAAC,EAAE,cAAc,CAAC;IACrB,GAAG,EAAE,MAAM,CAAC;IACZ,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,MAAM,EAAE,MAAM,CAAC;IACf,EAAE,EAAE,MAAM,CAAC;IACX,IAAI,EAAE,MAAM,CAAC;CACd,GAAG,OAAO,CAAC,MAAM,CAAC,CAuDlB"}
+{"version":3,"file":"plan.d.ts","sourceRoot":"","sources":["../../../src/commands/task/plan.ts"],"names":[],"mappings":"AASA,OAAO,EAGL,KAAK,cAAc,EACpB,MAAM,2BAA2B,CAAC;AAkJnC,wBAAsB,cAAc,CAAC,IAAI,EAAE;IACzC,GAAG,CAAC,EAAE,cAAc,CAAC;IACrB,GAAG,EAAE,MAAM,CAAC;IACZ,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,MAAM,EAAE,MAAM,CAAC;IACf,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,SAAS,CAAC,EAAE,MAAM,CAAC;CACpB,GAAG,OAAO,CAAC,MAAM,CAAC,CA8HlB;AAED,wBAAsB,kBAAkB,CAAC,IAAI,EAAE;IAC7C,GAAG,CAAC,EAAE,cAAc,CAAC;IACrB,GAAG,EAAE,MAAM,CAAC;IACZ,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,MAAM,EAAE,MAAM,CAAC;IACf,EAAE,EAAE,MAAM,CAAC;IACX,IAAI,CAAC,EAAE,MAAM,CAAC;CACf,GAAG,OAAO,CAAC,MAAM,CAAC,CA2DlB;AAED,wBAAsB,iBAAiB,CAAC,IAAI,EAAE;IAC5C,GAAG,CAAC,EAAE,cAAc,CAAC;IACrB,GAAG,EAAE,MAAM,CAAC;IACZ,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,MAAM,EAAE,MAAM,CAAC;IACf,EAAE,EAAE,MAAM,CAAC;IACX,IAAI,EAAE,MAAM,CAAC;CACd,GAAG,OAAO,CAAC,MAAM,CAAC,CAkElB"}