agentplane 0.3.15 → 0.3.16

package/assets/policy/incidents.md

@@ -5,3 +5,10 @@
 - id: INC-20260417-02 | date: 2026-04-17 | scope: Remove version drift by updating packages/recipes version surfaces, dependency pins, and generated references to the current 0.3.13 workspace version. | tags: code, recipes, workflow | match: code, recipes, workflow, remove, version, drift, updating, packages, surfaces, dependency, pins, and, generated, references, the, current | failure: Aligned recipes version metadata, dependency pins, lockfile, and release check scripts so both parity and npm availability treat @agentplaneorg/recipes as a first-class release package. | advice: Updated release parity and npm availability scripts plus tests, then re-ran focused release checks. | rule: Analogous Remove version drift by updating packages/recipes version surfaces, dependency pins, and generated references to the current 0.3.13 workspace version. work MUST review and apply the recorded external incident advice before retrying. | evidence: task 202604171154-1WZZJK; commit 45ed50d51883 | enforcement: manual | fixability: external | state: open
 - id: INC-20260417-03 | date: 2026-04-17 | scope: Remove scenario-centric commands and help from the public recipes product surface so recipes stop presenting a second parallel runtime model. | tags: code, recipes, workflow | match: code, recipes, workflow, remove, scenario, centric, commands, and, help, from, the, public, product, surface, stop, presenting | failure: Removed recipes scenario commands from the public command catalog, regenerated CLI/docs inventory, and updated user/developer guidance plus help/tests to treat scenario assets as recipe-owned internals. | advice: Regenerated CLI reference and recipes inventory, updated prompt assets, and reran focused command-catalog/help tests plus freshness checks. | rule: Analogous Remove scenario-centric commands and help from the public recipes product surface so recipes stop presenting a second parallel runtime model. work MUST review and apply the recorded external incident advice before retrying. | evidence: task 202604171155-V21N6H; commit e6b8c732614a | enforcement: manual | fixability: external | state: open
 - id: INC-20260417-04 | date: 2026-04-17 | scope: Make overlay when matching conjunctive, propagate command context into runtime matching, and either fully support or remove dead command matching fields. | tags: code, recipes, workflow | match: code, recipes, workflow, make, overlay, when, matching, conjunctive, propagate, command, context, into, runtime, and, either, fully | failure: Overlay fragments with combined when predicates now require every configured predicate, and runner prompt assembly forwards command context. | advice: Replaced else-if matching with conjunctive checks, added command propagation from runner target, and covered both layers with focused tests. | rule: Analogous Make overlay when matching conjunctive, propagate command context into runtime matching, and either fully support or remove dead command matching fields. work MUST review and apply the recorded external incident advice before retrying. | evidence: task 202604171154-4M51J8; commit b09dcb42e0d3 | enforcement: manual | fixability: external | state: open
+- id: INC-20260419-01 | date: 2026-04-19 | scope: Make pr open tolerate an already-published branch and continue PR creation when remote HEAD already matches the local branch, instead of failing on an unnecessary internal push path. | tags: workflow | match: workflow, make, open, tolerate, already, published, branch, and, continue, creation, when, remote, head, matches, the, local | failure: pr open always retried git push before remote PR creation, even when origin already had the same branch head. | advice: Compare the local branch tip to the remote push target after a publish failure, accept an exact match, and cover it with a regression test. | rule: Analogous Make pr open tolerate an already-published branch and continue PR creation when remote HEAD already matches the local branch, instead of failing on an unnecessary internal push path. work MUST review and apply the recorded external incident advice before retrying. | evidence: task 202604191200-N6XPEJ; commit 7ed61866fbab | enforcement: manual | fixability: external | state: open
+- id: INC-20260419-02 | date: 2026-04-19 | scope: Short-circuit manual close-tail and hosted-close-pr flows when the canonical close commit is already present on main, so branch_pr users cannot create obsolete closure PRs after hosted automation has already closed the task. | tags: workflow | match: workflow, short, circuit, manual, close, tail, and, hosted, flows, when, the, canonical, commit, already, present, main | failure: After hosted closure landed on main, both manual finish --close-commit and task hosted-close-pr could still generate obsolete closure tails or PRs. | advice: Treat base-side canonical closure as a first-class no-op condition: skip branch_pr close-tail materialization when no fresh task artifacts remain, and short-circuit hosted-close-pr before any remote recovery calls when task status/commit already match the merged commit. | rule: Analogous Short-circuit manual close-tail and hosted-close-pr flows when the canonical close commit is already present on main, so branch_pr users cannot create obsolete closure PRs after hosted automation has already closed the task. work MUST review and apply the recorded external incident advice before retrying. | evidence: task 202604191200-G7YHZY; commit fbc5422f0dfb | enforcement: manual | fixability: external | state: open
+- id: INC-20260419-03 | date: 2026-04-19 | scope: Epic E′. Migrate the remaining CLI test consumers away from run-cli.test-helpers.ts and delete the shim once no imports remain. | tags: code, refactor, testkit | match: code, refactor, testkit, epic, migrate, the, remaining, cli, test, consumers, away, from, run, helpers, and, delete | failure: No imports reference run-cli.test-helpers.js under packages/agentplane/src; heavy CLI suites passed after rerunning unstable PR-flow files in single-worker mode; framework bootstrap refreshed the repo-local runtime after shim deletion. | advice: Validated the migrated CLI batches, removed the shim, rebuilt the repo-local runtime, and recorded the single-worker workaround needed for the two slow PR-flow suites. | rule: Analogous Epic E′. Migrate the remaining CLI test consumers away from run-cli.test-helpers.ts and delete the shim once no imports remain. work MUST review and apply the recorded external incident advice before retrying. | evidence: task 202604191639-7SDT2H; commit e32f55f97171 | enforcement: manual | fixability: external | state: open
+- id: INC-20260419-04 | date: 2026-04-19 | scope: Epic E′. Add shared tempRepo, mockTaskBackend, mockPrApi, and mockConfig fixtures in @agentplane/testkit and replace duplicated local helpers. | tags: code, refactor, testkit | match: code, refactor, testkit, epic, add, shared, temprepo, mocktaskbackend, mockprapi, and, mockconfig, fixtures, agentplane, replace, duplicated, local | failure: Introduced tempRepo, mockConfig, mockTaskBackend, and fake GH PR helpers in @agentplane/testkit; extended the agentplane testing compatibility layer; task-backend and targeted pr-flow PR consumers now use the shared fixtures and pass. | advice: Added shared fixture modules, exported them through testkit and the compatibility layer, then validated the new surface with testkit build plus focused task-backend and pr-flow PR tests. | rule: Analogous Epic E′. Add shared tempRepo, mockTaskBackend, mockPrApi, and mockConfig fixtures in @agentplane/testkit and replace duplicated local helpers. work MUST review and apply the recorded external incident advice before retrying. | evidence: task 202604191639-DPNT53; commit 14c41a30bcdc | enforcement: manual | fixability: external | state: open
+- id: INC-20260419-05 | date: 2026-04-19 | scope: Epic E′. Move describeWhenEnvPresent, describeCritical, and describeWhenNotHook helpers into @agentplane/testkit with typed exports. | tags: code, refactor, testkit | match: code, refactor, testkit, epic, move, describewhenenvpresent, describecritical, and, describewhennothook, helpers, into, agentplane, with, typed, exports, publish | failure: Added describeWhenEnvPresent, describeWhenNotHook, and describeCritical to @agentplane/testkit, exported them through the compatibility surface, and migrated the current redmine live, release/upgrade hook-gated, and CLI critical suites. | advice: Implemented typed wrappers in testkit, added explicit compatibility re-exports, rebuilt testkit, and validated all current consumers with focused Vitest coverage. | rule: Analogous Epic E′. Move describeWhenEnvPresent, describeCritical, and describeWhenNotHook helpers into @agentplane/testkit with typed exports. work MUST review and apply the recorded external incident advice before retrying. | evidence: task 202604191639-PVRQFY; commit ad42ce782481 | enforcement: manual | fixability: external | state: open
+- id: INC-20260419-06 | date: 2026-04-19 | scope: Epic A′. Switch config loading to the canonical Zod validator and keep compare-mode safety where still needed. | tags: code, refactor, schemas | match: code, refactor, schemas, epic, switch, config, loading, the, canonical, zod, validator, and, keep, compare, mode, safety | failure: Focused config tests, core typecheck, and core build all passed after the import and export surface change. | advice: No further action in this atom; remaining A′ work can build on the direct config-zod surface. | rule: Analogous Epic A′. Switch config loading to the canonical Zod validator and keep compare-mode safety where still needed. work MUST review and apply the recorded external incident advice before retrying. | evidence: task 202604191639-STZFC6; commit 82a313b2cab1 | enforcement: manual | fixability: external | state: open
+- id: INC-20260420-01 | date: 2026-04-20 | scope: Audit CLI path resolution for global-install style layouts, fix any repo-local script path defects, and add regression tests that fail when installed CLI code resolves repository scripts from the global package location. | tags: bugfix, code, hooks | match: bugfix, code, hooks, audit, cli, path, resolution, for, global, install, style, layouts, fix, any, repo, local | failure: Audited import.meta.url/fileURLToPath candidates touching scripts/bin paths. The real repo-script risk was pre-push fallback returning a non-existent global prefix path; workflow-playbook's bin path is package-bundled and covered by existing workflow tests. | advice: Pre-push script resolution now returns repository-local script first, existing bundled fallback second, otherwise null with an actionable repository-local error message. | rule: Analogous Audit CLI path resolution for global-install style layouts, fix any repo-local script path defects, and add regression tests that fail when installed CLI code resolves repository scripts from the global package location. work MUST review and apply the recorded external incident advice before retrying. | evidence: task 202604200850-9T6FTC; commit d30a706ce568 | enforcement: manual | fixability: external | state: open

package/bin/agentplane.js

@@ -290,7 +290,7 @@ async function assertDistUpToDate() {
         "warning: linked development binary has a stale build, but current working directory is outside the agentplane checkout.\n" +
           "proceeding with existing dist output.\n" +
           `detected: ${staleReasons.join(", ")}\n` +
-          "tip: rebuild (`bun run --filter=@agentplaneorg/core build && bun run --filter=agentplane build`) or reinstall from npm for stable global usage.\n",
+          "tip: rebuild (`bun run --filter=@agentplaneorg/core build && bun run --filter=agentplane build && bun run --filter=@agentplane/testkit build`) or reinstall from npm for stable global usage.\n",
       );
       return true;
     }

package/bin/framework-dev-contract.js

@@ -4,6 +4,7 @@ export const FRAMEWORK_DEV_MANUAL_REPAIR_COMMANDS = [
   "git submodule update --init --recursive agentplane-recipes",
   "bun run --filter=@agentplaneorg/core build",
   "bun run --filter=agentplane build",
+  "bun run --filter=@agentplane/testkit build",
 ];
 export const FRAMEWORK_DEV_REPO_LOCAL_VERIFY_COMMAND =
   "node packages/agentplane/bin/agentplane.js runtime explain";