agentplane 0.3.10 → 0.3.12

package/dist/commands/task/verify-ok.command.js

@@ -1,5 +1,5 @@
 import { cmdTaskVerifyOk } from "./verify-record.js";
-import { parseVerifyCommonOptions, validateVerifyDetailsFileExclusive, validateVerifyNonEmptyInput, verifyCommonOptions, } from "./verify-command-shared.js";
+import { parseVerifyCommonOptions, validateVerifyDetailsFileExclusive, validateVerifyFindingSource, validateVerifyNonEmptyInput, validateVerifyNoteSource, verifyCommonOptions, } from "./verify-command-shared.js";
 export const taskVerifyOkSpec = {
     id: ["task", "verify", "ok"],
     group: "Task",
@@ -17,7 +17,8 @@ export const taskVerifyOkSpec = {
             message: "Provide at most one of --details or --file.",
         });
         validateVerifyNonEmptyInput(raw, taskVerifyOkSpec, "by");
-        validateVerifyNonEmptyInput(raw, taskVerifyOkSpec, "note");
+        validateVerifyNoteSource(raw, taskVerifyOkSpec);
+        validateVerifyFindingSource(raw, taskVerifyOkSpec);
     },
     parse: (raw) => ({
         taskId: String(raw.args["task-id"]),
@@ -33,9 +34,21 @@ export function makeRunTaskVerifyOkHandler(getCtx) {
             taskId: p.taskId,
             by: p.by,
             note: p.note,
+            noteFile: p.noteFile,
             details: p.details,
             file: p.file,
+            collectIncidents: p.collectIncidents,
             quiet: p.quiet,
+            observation: p.observation,
+            impact: p.impact,
+            resolution: p.resolution,
+            localOnly: p.localOnly,
+            repoFixable: p.repoFixable,
+            incidentScope: p.incidentScope,
+            incidentTags: p.incidentTags,
+            incidentMatch: p.incidentMatch,
+            incidentAdvice: p.incidentAdvice,
+            incidentRule: p.incidentRule,
         });
     };
 }

package/dist/commands/task/verify-record.d.ts

@@ -7,8 +7,20 @@ export declare function cmdTaskVerifyOk(opts: {
     taskId: string;
     by: string;
     note: string;
+    noteFile?: string;
     details?: string;
     file?: string;
+    collectIncidents?: boolean;
+    observation?: string;
+    impact?: string;
+    resolution?: string;
+    localOnly: boolean;
+    repoFixable: boolean;
+    incidentScope?: string;
+    incidentTags: string[];
+    incidentMatch: string[];
+    incidentAdvice?: string;
+    incidentRule?: string;
     quiet: boolean;
 }): Promise<number>;
 export declare function cmdTaskVerifyRework(opts: {
@@ -18,8 +30,20 @@ export declare function cmdTaskVerifyRework(opts: {
     taskId: string;
     by: string;
     note: string;
+    noteFile?: string;
     details?: string;
     file?: string;
+    collectIncidents?: boolean;
+    observation?: string;
+    impact?: string;
+    resolution?: string;
+    localOnly?: boolean;
+    repoFixable?: boolean;
+    incidentScope?: string;
+    incidentTags?: string[];
+    incidentMatch?: string[];
+    incidentAdvice?: string;
+    incidentRule?: string;
     quiet: boolean;
 }): Promise<number>;
 export declare function cmdVerifyParsed(opts: {
@@ -30,8 +54,20 @@ export declare function cmdVerifyParsed(opts: {
     state: VerifyState;
     by: string;
     note: string;
+    noteFile?: string;
     details?: string;
     file?: string;
+    collectIncidents?: boolean;
+    observation?: string;
+    impact?: string;
+    resolution?: string;
+    localOnly?: boolean;
+    repoFixable?: boolean;
+    incidentScope?: string;
+    incidentTags?: string[];
+    incidentMatch?: string[];
+    incidentAdvice?: string;
+    incidentRule?: string;
     quiet: boolean;
 }): Promise<number>;
 export {};

package/dist/commands/task/verify-record.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"verify-record.d.ts","sourceRoot":"","sources":["../../../src/commands/task/verify-record.ts"],"names":[],"mappings":"AAQA,OAAO,EAAsB,KAAK,cAAc,EAAE,MAAM,2BAA2B,CAAC;AAYpF,KAAK,WAAW,GAAG,IAAI,GAAG,cAAc,CAAC;AA0KzC,wBAAsB,eAAe,CAAC,IAAI,EAAE;IAC1C,GAAG,CAAC,EAAE,cAAc,CAAC;IACrB,GAAG,EAAE,MAAM,CAAC;IACZ,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,MAAM,EAAE,MAAM,CAAC;IACf,EAAE,EAAE,MAAM,CAAC;IACX,IAAI,EAAE,MAAM,CAAC;IACb,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,KAAK,EAAE,OAAO,CAAC;CAChB,GAAG,OAAO,CAAC,MAAM,CAAC,CAElB;AAED,wBAAsB,mBAAmB,CAAC,IAAI,EAAE;IAC9C,GAAG,CAAC,EAAE,cAAc,CAAC;IACrB,GAAG,EAAE,MAAM,CAAC;IACZ,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,MAAM,EAAE,MAAM,CAAC;IACf,EAAE,EAAE,MAAM,CAAC;IACX,IAAI,EAAE,MAAM,CAAC;IACb,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,KAAK,EAAE,OAAO,CAAC;CAChB,GAAG,OAAO,CAAC,MAAM,CAAC,CAMlB;AAED,wBAAsB,eAAe,CAAC,IAAI,EAAE;IAC1C,GAAG,CAAC,EAAE,cAAc,CAAC;IACrB,GAAG,EAAE,MAAM,CAAC;IACZ,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,MAAM,EAAE,MAAM,CAAC;IACf,KAAK,EAAE,WAAW,CAAC;IACnB,EAAE,EAAE,MAAM,CAAC;IACX,IAAI,EAAE,MAAM,CAAC;IACb,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,KAAK,EAAE,OAAO,CAAC;CAChB,GAAG,OAAO,CAAC,MAAM,CAAC,CAElB"}
+{"version":3,"file":"verify-record.d.ts","sourceRoot":"","sources":["../../../src/commands/task/verify-record.ts"],"names":[],"mappings":"AAaA,OAAO,EAAsB,KAAK,cAAc,EAAE,MAAM,2BAA2B,CAAC;AAepF,KAAK,WAAW,GAAG,IAAI,GAAG,cAAc,CAAC;AAoSzC,wBAAsB,eAAe,CAAC,IAAI,EAAE;IAC1C,GAAG,CAAC,EAAE,cAAc,CAAC;IACrB,GAAG,EAAE,MAAM,CAAC;IACZ,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,MAAM,EAAE,MAAM,CAAC;IACf,EAAE,EAAE,MAAM,CAAC;IACX,IAAI,EAAE,MAAM,CAAC;IACb,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,gBAAgB,CAAC,EAAE,OAAO,CAAC;IAC3B,WAAW,CAAC,EAAE,MAAM,CAAC;IACrB,MAAM,CAAC,EAAE,MAAM,CAAC;IAChB,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,SAAS,EAAE,OAAO,CAAC;IACnB,WAAW,EAAE,OAAO,CAAC;IACrB,aAAa,CAAC,EAAE,MAAM,CAAC;IACvB,YAAY,EAAE,MAAM,EAAE,CAAC;IACvB,aAAa,EAAE,MAAM,EAAE,CAAC;IACxB,cAAc,CAAC,EAAE,MAAM,CAAC;IACxB,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,KAAK,EAAE,OAAO,CAAC;CAChB,GAAG,OAAO,CAAC,MAAM,CAAC,CAuBlB;AAED,wBAAsB,mBAAmB,CAAC,IAAI,EAAE;IAC9C,GAAG,CAAC,EAAE,cAAc,CAAC;IACrB,GAAG,EAAE,MAAM,CAAC;IACZ,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,MAAM,EAAE,MAAM,CAAC;IACf,EAAE,EAAE,MAAM,CAAC;IACX,IAAI,EAAE,MAAM,CAAC;IACb,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,gBAAgB,CAAC,EAAE,OAAO,CAAC;IAC3B,WAAW,CAAC,EAAE,MAAM,CAAC;IACrB,MAAM,CAAC,EAAE,MAAM,CAAC;IAChB,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,SAAS,CAAC,EAAE,OAAO,CAAC;IACpB,WAAW,CAAC,EAAE,OAAO,CAAC;IACtB,aAAa,CAAC,EAAE,MAAM,CAAC;IACvB,YAAY,CAAC,EAAE,MAAM,EAAE,CAAC;IACxB,aAAa,CAAC,EAAE,MAAM,EAAE,CAAC;IACzB,cAAc,CAAC,EAAE,MAAM,CAAC;IACxB,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,KAAK,EAAE,OAAO,CAAC;CAChB,GAAG,OAAO,CAAC,MAAM,CAAC,CAuBlB;AAED,wBAAsB,eAAe,CAAC,IAAI,EAAE;IAC1C,GAAG,CAAC,EAAE,cAAc,CAAC;IACrB,GAAG,EAAE,MAAM,CAAC;IACZ,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,MAAM,EAAE,MAAM,CAAC;IACf,KAAK,EAAE,WAAW,CAAC;IACnB,EAAE,EAAE,MAAM,CAAC;IACX,IAAI,EAAE,MAAM,CAAC;IACb,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,gBAAgB,CAAC,EAAE,OAAO,CAAC;IAC3B,WAAW,CAAC,EAAE,MAAM,CAAC;IACrB,MAAM,CAAC,EAAE,MAAM,CAAC;IAChB,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,SAAS,CAAC,EAAE,OAAO,CAAC;IACpB,WAAW,CAAC,EAAE,OAAO,CAAC;IACtB,aAAa,CAAC,EAAE,MAAM,CAAC;IACvB,YAAY,CAAC,EAAE,MAAM,EAAE,CAAC;IACxB,aAAa,CAAC,EAAE,MAAM,EAAE,CAAC;IACzB,cAAc,CAAC,EAAE,MAAM,CAAC;IACxB,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,KAAK,EAAE,OAAO,CAAC;CAChB,GAAG,OAAO,CAAC,MAAM,CAAC,CAsBlB"}

package/dist/commands/task/verify-record.js

@@ -1,16 +1,21 @@
 import { readFile } from "node:fs/promises";
 import path from "node:path";
 import { mapBackendError, mapCoreError } from "../../cli/error-map.js";
-import { backendNotSupportedMessage, successMessage } from "../../cli/output.js";
+import { backendNotSupportedMessage, infoMessage, successMessage } from "../../cli/output.js";
 import { CliError } from "../../shared/errors.js";
 import { writeJsonStableIfChanged } from "../../shared/write-if-changed.js";
+import { collectTaskIncidents, inspectTaskIncidents, renderIncidentCollectionPlanOutcome, } from "../incidents/shared.js";
 import { ensureReconciledBeforeMutation } from "../shared/reconcile-check.js";
 import { loadCommandContext } from "../shared/task-backend.js";
 import { applyTaskMutation } from "../shared/task-mutation.js";
 import { ensurePrArtifactsSynced } from "../pr/internal/sync.js";
 import { resolvePrPaths } from "../pr/internal/pr-paths.js";
 import { buildVerifiedPrMeta, parsePrMeta } from "../shared/pr-meta.js";
-import { decodeEscapedTaskTextNewlines, executeTaskVerificationTransitionRequest, nowIso, } from "./shared.js";
+import { buildStructuredFindingMutationPlan } from "./findings.js";
+import { assertVerifyStepsFilled, decodeEscapedTaskTextNewlines, executeTaskVerificationTransitionRequest, extractDocSection, nowIso, } from "./shared.js";
+function normalizeFileBackedVerifyNote(raw) {
+    return decodeEscapedTaskTextNewlines(raw).replaceAll(/\s+/gu, " ").trim();
+}
 async function recordVerificationResult(opts) {
     const ctx = opts.ctx ??
         (await loadCommandContext({ cwd: opts.cwd, rootOverride: opts.rootOverride ?? null }));
@@ -30,6 +35,14 @@ async function recordVerificationResult(opts) {
         ctx,
         taskId: opts.taskId,
         build: async (current) => {
+            const doc = (typeof current.doc === "string" ? current.doc : "") ||
+                (await backend.getTaskDoc(current.id));
+            assertVerifyStepsFilled({
+                taskId: current.id,
+                sectionText: extractDocSection(doc, "Verify Steps"),
+                action: "record verification",
+                guidance: "fill it before running `agentplane verify ...`",
+            });
             const execution = executeTaskVerificationTransitionRequest({
                 task: current,
                 at,
@@ -37,11 +50,30 @@ async function recordVerificationResult(opts) {
                 note: opts.note,
                 state: opts.state,
                 details: opts.details ?? null,
-                doc: (typeof current.doc === "string" ? current.doc : "") ||
-                    (await backend.getTaskDoc(current.id)),
+                doc,
                 requiredSections: config.tasks.doc.required_sections,
             });
-            return { intents: execution.intents };
+            const intents = [...execution.intents];
+            if (opts.finding) {
+                const findingPlan = buildStructuredFindingMutationPlan({
+                    current,
+                    config,
+                    observation: opts.finding.observation,
+                    impact: opts.finding.impact,
+                    resolution: opts.finding.resolution,
+                    promote: !opts.finding.localOnly,
+                    external: !opts.finding.localOnly,
+                    fixability: opts.finding.repoFixable ? "repo-fixable" : null,
+                    incidentScope: opts.finding.incidentScope,
+                    incidentTags: opts.finding.incidentTags ?? [],
+                    incidentMatch: opts.finding.incidentMatch ?? [],
+                    incidentAdvice: opts.finding.incidentAdvice,
+                    incidentRule: opts.finding.incidentRule,
+                });
+                if (findingPlan)
+                    intents.push(...findingPlan.intents);
+            }
+            return { intents };
         },
     });
     if (config.workflow_mode === "branch_pr") {
@@ -67,20 +99,70 @@ async function recordVerificationResult(opts) {
             }));
         }
     }
+    let incidentSummary = null;
+    if (opts.collectIncidents === true) {
+        const collected = await collectTaskIncidents({
+            ctx,
+            taskId: opts.taskId,
+            write: true,
+        });
+        incidentSummary = renderIncidentCollectionPlanOutcome(collected.plan, {
+            wrote: collected.wrote,
+            context: "collect",
+            promotedIds: collected.plan.promotable.map((item) => item.entry.id),
+            registryPaths: collected.registryPaths,
+            taskId: opts.taskId,
+        });
+    }
+    else if (config.workflow_mode === "branch_pr") {
+        const inspected = await inspectTaskIncidents({
+            ctx,
+            taskId: opts.taskId,
+        });
+        incidentSummary = renderIncidentCollectionPlanOutcome(inspected.plan, {
+            wrote: false,
+            context: "verify",
+            taskId: opts.taskId,
+        });
+    }
     if (!opts.quiet) {
+        const findingState = opts.finding
+            ? opts.finding.localOnly
+                ? "task-local"
+                : "incident-candidate"
+            : null;
         const readmePath = path.join(resolved.gitRoot, config.paths.workflow_dir, opts.taskId, "README.md");
         const relReadmePath = path.relative(resolved.gitRoot, readmePath);
-        process.stdout.write(`${successMessage("verified", opts.taskId, `state=${opts.state} readme=${relReadmePath}`)}\n`);
+        const extra = findingState ? ` finding=${findingState}` : "";
+        process.stdout.write(`${successMessage("verified", opts.taskId, `state=${opts.state} readme=${relReadmePath}${extra}`)}\n`);
+        if (incidentSummary && config.workflow_mode === "branch_pr") {
+            process.stdout.write(`${infoMessage(incidentSummary)}\n`);
+        }
     }
 }
 async function resolveVerifyRecordInput(opts) {
     const by = String(opts.by ?? "").trim();
-    const note = String(opts.note ?? "").trim();
-    if (!by || !note) {
+    const inlineNote = String(opts.note ?? "").trim();
+    const noteFile = typeof opts.noteFile === "string" ? opts.noteFile.trim() : "";
+    if (!by) {
+        throw new CliError({
+            exitCode: 2,
+            code: "E_USAGE",
+            message: "Missing required input: --by.",
+        });
+    }
+    if (!inlineNote && !noteFile) {
         throw new CliError({
             exitCode: 2,
             code: "E_USAGE",
-            message: "Missing required inputs: --by and --note.",
+            message: "Provide exactly one of --note or --note-file.",
+        });
+    }
+    if (inlineNote && noteFile) {
+        throw new CliError({
+            exitCode: 2,
+            code: "E_USAGE",
+            message: "Options --note and --note-file are mutually exclusive.",
         });
     }
     if (typeof opts.details === "string" && typeof opts.file === "string") {
@@ -90,6 +172,22 @@ async function resolveVerifyRecordInput(opts) {
             message: "Options --details and --file are mutually exclusive.",
         });
     }
+    let note = inlineNote;
+    if (noteFile) {
+        try {
+            note = normalizeFileBackedVerifyNote(await readFile(path.resolve(opts.cwd, noteFile), "utf8"));
+        }
+        catch (err) {
+            throw mapCoreError(err, { command: opts.command, filePath: noteFile });
+        }
+    }
+    if (!note) {
+        throw new CliError({
+            exitCode: 2,
+            code: "E_USAGE",
+            message: "Verification note cannot be empty after normalization.",
+        });
+    }
     let details = typeof opts.details === "string" ? opts.details : null;
     if (typeof opts.file === "string") {
         try {
@@ -116,6 +214,8 @@ async function executeVerifyRecordCommand(opts) {
             by: input.by,
             note: input.note,
             details: input.details,
+            finding: opts.finding,
+            collectIncidents: opts.collectIncidents,
             quiet: opts.quiet,
         });
         return 0;
@@ -127,15 +227,70 @@ async function executeVerifyRecordCommand(opts) {
     }
 }
 export async function cmdTaskVerifyOk(opts) {
-    return await executeVerifyRecordCommand({ ...opts, state: "ok", command: "task verify ok" });
+    return await executeVerifyRecordCommand({
+        ...opts,
+        state: "ok",
+        command: "task verify ok",
+        finding: typeof opts.observation === "string" &&
+            typeof opts.impact === "string" &&
+            typeof opts.resolution === "string"
+            ? {
+                observation: opts.observation,
+                impact: opts.impact,
+                resolution: opts.resolution,
+                localOnly: opts.localOnly === true,
+                repoFixable: opts.repoFixable === true,
+                incidentScope: opts.incidentScope,
+                incidentTags: opts.incidentTags ?? [],
+                incidentMatch: opts.incidentMatch ?? [],
+                incidentAdvice: opts.incidentAdvice,
+                incidentRule: opts.incidentRule,
+            }
+            : null,
+    });
 }
 export async function cmdTaskVerifyRework(opts) {
     return await executeVerifyRecordCommand({
         ...opts,
         state: "needs_rework",
         command: "task verify rework",
+        finding: typeof opts.observation === "string" &&
+            typeof opts.impact === "string" &&
+            typeof opts.resolution === "string"
+            ? {
+                observation: opts.observation,
+                impact: opts.impact,
+                resolution: opts.resolution,
+                localOnly: opts.localOnly === true,
+                repoFixable: opts.repoFixable === true,
+                incidentScope: opts.incidentScope,
+                incidentTags: opts.incidentTags ?? [],
+                incidentMatch: opts.incidentMatch ?? [],
+                incidentAdvice: opts.incidentAdvice,
+                incidentRule: opts.incidentRule,
+            }
+            : null,
     });
 }
 export async function cmdVerifyParsed(opts) {
-    return await executeVerifyRecordCommand({ ...opts, command: "verify" });
+    return await executeVerifyRecordCommand({
+        ...opts,
+        command: "verify",
+        finding: typeof opts.observation === "string" &&
+            typeof opts.impact === "string" &&
+            typeof opts.resolution === "string"
+            ? {
+                observation: opts.observation,
+                impact: opts.impact,
+                resolution: opts.resolution,
+                localOnly: opts.localOnly === true,
+                repoFixable: opts.repoFixable === true,
+                incidentScope: opts.incidentScope,
+                incidentTags: opts.incidentTags ?? [],
+                incidentMatch: opts.incidentMatch ?? [],
+                incidentAdvice: opts.incidentAdvice,
+                incidentRule: opts.incidentRule,
+            }
+            : null,
+    });
 }

package/dist/commands/task/verify-rework.command.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"verify-rework.command.d.ts","sourceRoot":"","sources":["../../../src/commands/task/verify-rework.command.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,UAAU,EAAE,WAAW,EAAE,MAAM,wBAAwB,CAAC;AACtE,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AAGhE,OAAO,EAKL,KAAK,kBAAkB,EACxB,MAAM,4BAA4B,CAAC;AAEpC,MAAM,MAAM,sBAAsB,GAAG,kBAAkB,GAAG;IACxD,MAAM,EAAE,MAAM,CAAC;CAChB,CAAC;AAEF,eAAO,MAAM,oBAAoB,EAAE,WAAW,CAAC,sBAAsB,CAwBpE,CAAC;AAEF,wBAAgB,8BAA8B,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,MAAM,KAAK,OAAO,CAAC,cAAc,CAAC,IAC/E,KAAK,UAAU,EAAE,GAAG,sBAAsB,KAAG,OAAO,CAAC,MAAM,CAAC,CAa3E"}
+{"version":3,"file":"verify-rework.command.d.ts","sourceRoot":"","sources":["../../../src/commands/task/verify-rework.command.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,UAAU,EAAE,WAAW,EAAE,MAAM,wBAAwB,CAAC;AACtE,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AAGhE,OAAO,EAOL,KAAK,kBAAkB,EACxB,MAAM,4BAA4B,CAAC;AAEpC,MAAM,MAAM,sBAAsB,GAAG,kBAAkB,GAAG;IACxD,MAAM,EAAE,MAAM,CAAC;CAChB,CAAC;AAEF,eAAO,MAAM,oBAAoB,EAAE,WAAW,CAAC,sBAAsB,CAyBpE,CAAC;AAEF,wBAAgB,8BAA8B,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,MAAM,KAAK,OAAO,CAAC,cAAc,CAAC,IAC/E,KAAK,UAAU,EAAE,GAAG,sBAAsB,KAAG,OAAO,CAAC,MAAM,CAAC,CAyB3E"}

package/dist/commands/task/verify-rework.command.js

@@ -1,5 +1,5 @@
 import { cmdTaskVerifyRework } from "./verify-record.js";
-import { parseVerifyCommonOptions, validateVerifyDetailsFileExclusive, validateVerifyNonEmptyInput, verifyCommonOptions, } from "./verify-command-shared.js";
+import { parseVerifyCommonOptions, validateVerifyDetailsFileExclusive, validateVerifyFindingSource, validateVerifyNonEmptyInput, validateVerifyNoteSource, verifyCommonOptions, } from "./verify-command-shared.js";
 export const taskVerifyReworkSpec = {
     id: ["task", "verify", "rework"],
     group: "Task",
@@ -17,7 +17,8 @@ export const taskVerifyReworkSpec = {
             message: "Provide at most one of --details or --file.",
         });
         validateVerifyNonEmptyInput(raw, taskVerifyReworkSpec, "by");
-        validateVerifyNonEmptyInput(raw, taskVerifyReworkSpec, "note");
+        validateVerifyNoteSource(raw, taskVerifyReworkSpec);
+        validateVerifyFindingSource(raw, taskVerifyReworkSpec);
     },
     parse: (raw) => ({
         taskId: String(raw.args["task-id"]),
@@ -33,9 +34,21 @@ export function makeRunTaskVerifyReworkHandler(getCtx) {
             taskId: p.taskId,
             by: p.by,
             note: p.note,
+            noteFile: p.noteFile,
             details: p.details,
             file: p.file,
+            collectIncidents: p.collectIncidents,
             quiet: p.quiet,
+            observation: p.observation,
+            impact: p.impact,
+            resolution: p.resolution,
+            localOnly: p.localOnly,
+            repoFixable: p.repoFixable,
+            incidentScope: p.incidentScope,
+            incidentTags: p.incidentTags,
+            incidentMatch: p.incidentMatch,
+            incidentAdvice: p.incidentAdvice,
+            incidentRule: p.incidentRule,
         });
     };
 }

package/dist/commands/task/verify-show.command.d.ts

@@ -1,5 +1,5 @@
 import type { CommandCtx, CommandSpec } from "../../cli/spec/spec.js";
-import type { CommandContext } from "../shared/task-backend.js";
+import { type CommandContext } from "../shared/task-backend.js";
 export type TaskVerifyShowParsed = {
     taskId: string;
     quiet: boolean;

package/dist/commands/task/verify-show.command.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"verify-show.command.d.ts","sourceRoot":"","sources":["../../../src/commands/task/verify-show.command.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,UAAU,EAAE,WAAW,EAAE,MAAM,wBAAwB,CAAC;AACtE,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAC;AAIhE,MAAM,MAAM,oBAAoB,GAAG;IACjC,MAAM,EAAE,MAAM,CAAC;IACf,KAAK,EAAE,OAAO,CAAC;CAChB,CAAC;AAEF,eAAO,MAAM,kBAAkB,EAAE,WAAW,CAAC,oBAAoB,CA6BhE,CAAC;AAEF,wBAAgB,4BAA4B,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,MAAM,KAAK,OAAO,CAAC,cAAc,CAAC,IAC7E,KAAK,UAAU,EAAE,GAAG,oBAAoB,KAAG,OAAO,CAAC,MAAM,CAAC,CAUzE"}
+{"version":3,"file":"verify-show.command.d.ts","sourceRoot":"","sources":["../../../src/commands/task/verify-show.command.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,UAAU,EAAE,WAAW,EAAE,MAAM,wBAAwB,CAAC;AAGtE,OAAO,EAAuB,KAAK,cAAc,EAAE,MAAM,2BAA2B,CAAC;AAKrF,MAAM,MAAM,oBAAoB,GAAG;IACjC,MAAM,EAAE,MAAM,CAAC;IACf,KAAK,EAAE,OAAO,CAAC;CAChB,CAAC;AAEF,eAAO,MAAM,kBAAkB,EAAE,WAAW,CAAC,oBAAoB,CA6BhE,CAAC;AAEF,wBAAgB,4BAA4B,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,MAAM,KAAK,OAAO,CAAC,cAAc,CAAC,IAC7E,KAAK,UAAU,EAAE,GAAG,oBAAoB,KAAG,OAAO,CAAC,MAAM,CAAC,CAkCzE"}

package/dist/commands/task/verify-show.command.js

@@ -1,4 +1,8 @@
+import { backendNotSupportedMessage } from "../../cli/output.js";
+import { CliError } from "../../shared/errors.js";
+import { loadTaskFromContext } from "../shared/task-backend.js";
 import { cmdTaskDocShow } from "./doc.js";
+import { assertVerifyStepsFilled, extractDocSection, isVerifyStepsFilled } from "./shared.js";
 export const taskVerifyShowSpec = {
     id: ["task", "verify-show"],
     group: "Task",
@@ -30,8 +34,31 @@ export const taskVerifyShowSpec = {
 };
 export function makeRunTaskVerifyShowHandler(getCtx) {
     return async (ctx, p) => {
+        const commandCtx = await getCtx("task verify-show");
+        const backend = commandCtx.taskBackend;
+        if (!backend.getTaskDoc) {
+            throw new CliError({
+                exitCode: 2,
+                code: "E_USAGE",
+                message: backendNotSupportedMessage("task docs"),
+            });
+        }
+        const task = await loadTaskFromContext({ ctx: commandCtx, taskId: p.taskId });
+        const doc = typeof task.doc === "string" ? task.doc : ((await backend.getTaskDoc(p.taskId)) ?? "");
+        const verifySteps = extractDocSection(doc, "Verify Steps");
+        if (!p.quiet) {
+            assertVerifyStepsFilled({
+                taskId: p.taskId,
+                sectionText: verifySteps,
+                action: "show Verify Steps",
+                guidance: "fill it before verification",
+            });
+        }
+        else if (!isVerifyStepsFilled(verifySteps)) {
+            return 0;
+        }
         return await cmdTaskDocShow({
-            ctx: await getCtx("task verify-show"),
+            ctx: commandCtx,
             cwd: ctx.cwd,
             rootOverride: ctx.rootOverride,
             taskId: p.taskId,

package/dist/commands/verify.run.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"verify.run.d.ts","sourceRoot":"","sources":["../../src/commands/verify.run.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,qBAAqB,CAAC;AACtD,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,0BAA0B,CAAC;AAG/D,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,kBAAkB,CAAC;AAErD,wBAAgB,oBAAoB,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,MAAM,KAAK,OAAO,CAAC,cAAc,CAAC,IACrE,KAAK,UAAU,EAAE,GAAG,YAAY,KAAG,OAAO,CAAC,MAAM,CAAC,CAcjE"}
+{"version":3,"file":"verify.run.d.ts","sourceRoot":"","sources":["../../src/commands/verify.run.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,qBAAqB,CAAC;AACtD,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,0BAA0B,CAAC;AAG/D,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,kBAAkB,CAAC;AAErD,wBAAgB,oBAAoB,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,MAAM,KAAK,OAAO,CAAC,cAAc,CAAC,IACrE,KAAK,UAAU,EAAE,GAAG,YAAY,KAAG,OAAO,CAAC,MAAM,CAAC,CA0BjE"}

package/dist/commands/verify.run.js

@@ -9,8 +9,20 @@ export function makeRunVerifyHandler(getCtx) {
             state: p.state,
             by: p.by,
             note: p.note,
+            noteFile: p.noteFile,
             details: p.details,
             file: p.file,
+            collectIncidents: p.collectIncidents,
+            observation: p.observation,
+            impact: p.impact,
+            resolution: p.resolution,
+            localOnly: p.localOnly,
+            repoFixable: p.repoFixable,
+            incidentScope: p.incidentScope,
+            incidentTags: p.incidentTags,
+            incidentMatch: p.incidentMatch,
+            incidentAdvice: p.incidentAdvice,
+            incidentRule: p.incidentRule,
             quiet: p.quiet,
         });
     };

package/dist/commands/verify.spec.d.ts

@@ -1,13 +1,9 @@
 import type { CommandSpec } from "../cli/spec/spec.js";
+import { type VerifyCommonParsed } from "./task/verify-command-shared.js";
 type VerifyState = "ok" | "needs_rework";
-export type VerifyParsed = {
+export type VerifyParsed = VerifyCommonParsed & {
     taskId: string;
     state: VerifyState;
-    by: string;
-    note: string;
-    details?: string;
-    file?: string;
-    quiet: boolean;
 };
 export declare const verifySpec: CommandSpec<VerifyParsed>;
 export {};

package/dist/commands/verify.spec.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"verify.spec.d.ts","sourceRoot":"","sources":["../../src/commands/verify.spec.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,qBAAqB,CAAC;AAOvD,KAAK,WAAW,GAAG,IAAI,GAAG,cAAc,CAAC;AAEzC,MAAM,MAAM,YAAY,GAAG;IACzB,MAAM,EAAE,MAAM,CAAC;IACf,KAAK,EAAE,WAAW,CAAC;IACnB,EAAE,EAAE,MAAM,CAAC;IACX,IAAI,EAAE,MAAM,CAAC;IACb,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,KAAK,EAAE,OAAO,CAAC;CAChB,CAAC;AAEF,eAAO,MAAM,UAAU,EAAE,WAAW,CAAC,YAAY,CAoFhD,CAAC"}
+{"version":3,"file":"verify.spec.d.ts","sourceRoot":"","sources":["../../src/commands/verify.spec.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,qBAAqB,CAAC;AAEvD,OAAO,EACL,KAAK,kBAAkB,EAOxB,MAAM,iCAAiC,CAAC;AAEzC,KAAK,WAAW,GAAG,IAAI,GAAG,cAAc,CAAC;AAEzC,MAAM,MAAM,YAAY,GAAG,kBAAkB,GAAG;IAC9C,MAAM,EAAE,MAAM,CAAC;IACf,KAAK,EAAE,WAAW,CAAC;CACpB,CAAC;AAEF,eAAO,MAAM,UAAU,EAAE,WAAW,CAAC,YAAY,CAiHhD,CAAC"}

package/dist/commands/verify.spec.js

@@ -1,9 +1,9 @@
 import { usageError } from "../cli/spec/errors.js";
-import { parseVerifyCommonOptions, validateVerifyDetailsFileExclusive, } from "./task/verify-command-shared.js";
+import { parseVerifyCommonOptions, validateVerifyDetailsFileExclusive, validateVerifyFindingSource, validateVerifyNonEmptyInput, validateVerifyNoteSource, verifyFindingOptions, } from "./task/verify-command-shared.js";
 export const verifySpec = {
     id: ["verify"],
     group: "Lifecycle",
-    summary: "Record a verification outcome for a task (record-only; does not execute commands).",
+    summary: "Record a verification outcome for a task; incident candidates stay task-local unless collected explicitly.",
     args: [
         {
             name: "task-id",
@@ -36,9 +36,14 @@ export const verifySpec = {
             kind: "string",
             name: "note",
             valueHint: "<text>",
-            required: true,
             description: "Short note describing the verification outcome.",
         },
+        {
+            kind: "string",
+            name: "note-file",
+            valueHint: "<path>",
+            description: "Read the verification note from a file path (mutually exclusive with --note).",
+        },
         {
             kind: "string",
             name: "details",
@@ -51,17 +56,36 @@ export const verifySpec = {
             valueHint: "<path>",
             description: "Read details from a file path (mutually exclusive with --details).",
         },
+        {
+            kind: "boolean",
+            name: "collect-incidents",
+            default: false,
+            description: "After recording verification, collect promotable findings into incidents.md immediately.",
+        },
         { kind: "boolean", name: "quiet", default: false, description: "Suppress output." },
+        ...verifyFindingOptions,
     ],
     examples: [
         {
             cmd: 'agentplane verify 202602030608-F1Q8AB --ok --by REVIEWER --note "Looks good" --quiet',
             why: "Record an OK verification outcome.",
         },
+        {
+            cmd: "agentplane verify 202602030608-F1Q8AB --ok --by REVIEWER --note-file ./verify-note.txt",
+            why: "Record an OK verification outcome using a file-backed note.",
+        },
         {
             cmd: 'agentplane verify 202602030608-F1Q8AB --rework --by REVIEWER --note "Needs changes" --details "Missing tests"',
             why: "Record a needs-rework outcome with details.",
         },
+        {
+            cmd: 'agentplane verify 202602030608-F1Q8AB --ok --by REVIEWER --note "Looks good" --observation "Repeated recovery was manual." --impact "Operators needed a second command." --resolution "Append structured findings during verify."',
+            why: "Record verification and append a promotable structured finding in one command.",
+        },
+        {
+            cmd: 'agentplane verify 202602030608-F1Q8AB --ok --by REVIEWER --note "Looks good" --collect-incidents',
+            why: "Record verification and collect promotable findings into incidents.md immediately.",
+        },
     ],
     validateRaw: (raw) => {
         const ok = raw.opts.ok === true;
@@ -74,6 +98,9 @@ export const verifySpec = {
             });
         }
         validateVerifyDetailsFileExclusive(raw, verifySpec, { command: "verify" });
+        validateVerifyNonEmptyInput(raw, verifySpec, "by");
+        validateVerifyNoteSource(raw, verifySpec, { command: "verify" });
+        validateVerifyFindingSource(raw, verifySpec, { command: "verify" });
     },
     parse: (raw) => {
         const ok = raw.opts.ok === true;

package/dist/runtime/incidents/index.d.ts

@@ -1,3 +1,3 @@
-export type { IncidentAdviceMatch, IncidentAdviceQuery, IncidentCollectionPlan, IncidentFindingCandidate, IncidentPromotionDraft, IncidentPromotionIssue, IncidentPromotionTaskContext, IncidentRegistry, IncidentRegistryEntry, IncidentRegistryEntryState, } from "./types.js";
+export type { IncidentAdviceMatch, IncidentAdviceQuery, IncidentCollectionPlan, IncidentFindingCandidate, IncidentSkippedFinding, IncidentPromotionDraft, IncidentPromotionIssue, IncidentPromotionTaskContext, IncidentRegistry, IncidentRegistryEntry, IncidentRegistryEntryState, } from "./types.js";
 export { appendIncidentRegistryEntries, buildIncidentAdviceQueryFromTask, createIncidentRegistrySkeleton, extractIncidentCandidatesFromFindings, formatIncidentRegistryEntry, parseIncidentRegistry, planIncidentCollection, renderIncidentAdvice, resolveIncidentAdviceMatches, } from "./resolve.js";
 //# sourceMappingURL=index.d.ts.map

package/dist/runtime/incidents/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../../src/runtime/incidents/index.ts"],"names":[],"mappings":"AAAA,YAAY,EACV,mBAAmB,EACnB,mBAAmB,EACnB,sBAAsB,EACtB,wBAAwB,EACxB,sBAAsB,EACtB,sBAAsB,EACtB,4BAA4B,EAC5B,gBAAgB,EAChB,qBAAqB,EACrB,0BAA0B,GAC3B,MAAM,YAAY,CAAC;AACpB,OAAO,EACL,6BAA6B,EAC7B,gCAAgC,EAChC,8BAA8B,EAC9B,qCAAqC,EACrC,2BAA2B,EAC3B,qBAAqB,EACrB,sBAAsB,EACtB,oBAAoB,EACpB,4BAA4B,GAC7B,MAAM,cAAc,CAAC"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../../src/runtime/incidents/index.ts"],"names":[],"mappings":"AAAA,YAAY,EACV,mBAAmB,EACnB,mBAAmB,EACnB,sBAAsB,EACtB,wBAAwB,EACxB,sBAAsB,EACtB,sBAAsB,EACtB,sBAAsB,EACtB,4BAA4B,EAC5B,gBAAgB,EAChB,qBAAqB,EACrB,0BAA0B,GAC3B,MAAM,YAAY,CAAC;AACpB,OAAO,EACL,6BAA6B,EAC7B,gCAAgC,EAChC,8BAA8B,EAC9B,qCAAqC,EACrC,2BAA2B,EAC3B,qBAAqB,EACrB,sBAAsB,EACtB,oBAAoB,EACpB,4BAA4B,GAC7B,MAAM,cAAc,CAAC"}

package/dist/runtime/incidents/resolve.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"resolve.d.ts","sourceRoot":"","sources":["../../../src/runtime/incidents/resolve.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EACV,mBAAmB,EACnB,mBAAmB,EACnB,sBAAsB,EACtB,wBAAwB,EAGxB,4BAA4B,EAC5B,gBAAgB,EAChB,qBAAqB,EAEtB,MAAM,YAAY,CAAC;AAuGpB,wBAAgB,8BAA8B,IAAI,MAAM,CAgCvD;AAED,wBAAgB,qBAAqB,CAAC,IAAI,EAAE,MAAM,GAAG,gBAAgB,CAkFpE;AAED,wBAAgB,2BAA2B,CAAC,KAAK,EAAE,qBAAqB,GAAG,MAAM,CAgBhF;AAED,wBAAgB,6BAA6B,CAC3C,WAAW,EAAE,MAAM,EACnB,OAAO,EAAE,SAAS,qBAAqB,EAAE,GACxC,MAAM,CAQR;AAED,wBAAgB,qCAAqC,CACnD,QAAQ,EAAE,MAAM,GACf,wBAAwB,EAAE,CAwF5B;AA4DD,wBAAgB,sBAAsB,CAAC,IAAI,EAAE;IAC3C,IAAI,EAAE,4BAA4B,CAAC;IACnC,QAAQ,EAAE,MAAM,CAAC;IACjB,QAAQ,EAAE,gBAAgB,CAAC;IAC3B,GAAG,CAAC,EAAE,IAAI,CAAC;CACZ,GAAG,sBAAsB,CAiCzB;AAED,wBAAgB,gCAAgC,CAAC,IAAI,EAAE;IACrD,MAAM,EAAE,MAAM,CAAC;IACf,KAAK,EAAE,MAAM,CAAC;IACd,WAAW,EAAE,MAAM,CAAC;IACpB,KAAK,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;IACtB,IAAI,EAAE,SAAS,MAAM,EAAE,CAAC;CACzB,GAAG,mBAAmB,CAQtB;AAED,wBAAgB,4BAA4B,CAAC,IAAI,EAAE;IACjD,KAAK,EAAE,mBAAmB,CAAC;IAC3B,QAAQ,EAAE,gBAAgB,CAAC;IAC3B,KAAK,CAAC,EAAE,MAAM,CAAC;CAChB,GAAG,mBAAmB,EAAE,CA4BxB;AAED,wBAAgB,oBAAoB,CAAC,OAAO,EAAE,SAAS,mBAAmB,EAAE,GAAG,MAAM,CAcpF"}
+{"version":3,"file":"resolve.d.ts","sourceRoot":"","sources":["../../../src/runtime/incidents/resolve.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EACV,mBAAmB,EACnB,mBAAmB,EACnB,sBAAsB,EACtB,wBAAwB,EAIxB,4BAA4B,EAC5B,gBAAgB,EAChB,qBAAqB,EAEtB,MAAM,YAAY,CAAC;AAmNpB,wBAAgB,8BAA8B,IAAI,MAAM,CAkCvD;AAED,wBAAgB,qBAAqB,CAAC,IAAI,EAAE,MAAM,GAAG,gBAAgB,CAkFpE;AAED,wBAAgB,2BAA2B,CAAC,KAAK,EAAE,qBAAqB,GAAG,MAAM,CAEhF;AAiJD,wBAAgB,6BAA6B,CAC3C,WAAW,EAAE,MAAM,EACnB,OAAO,EAAE,SAAS,qBAAqB,EAAE,GACxC,MAAM,CAOR;AAED,wBAAgB,qCAAqC,CACnD,QAAQ,EAAE,MAAM,GACf,wBAAwB,EAAE,CAI5B;AA8KD,wBAAgB,sBAAsB,CAAC,IAAI,EAAE;IAC3C,IAAI,EAAE,4BAA4B,CAAC;IACnC,QAAQ,EAAE,MAAM,CAAC;IACjB,QAAQ,EAAE,gBAAgB,CAAC;IAC3B,GAAG,CAAC,EAAE,IAAI,CAAC;CACZ,GAAG,sBAAsB,CAyDzB;AAED,wBAAgB,gCAAgC,CAAC,IAAI,EAAE;IACrD,MAAM,EAAE,MAAM,CAAC;IACf,KAAK,EAAE,MAAM,CAAC;IACd,WAAW,EAAE,MAAM,CAAC;IACpB,KAAK,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;IACtB,IAAI,EAAE,SAAS,MAAM,EAAE,CAAC;CACzB,GAAG,mBAAmB,CAQtB;AAED,wBAAgB,4BAA4B,CAAC,IAAI,EAAE;IACjD,KAAK,EAAE,mBAAmB,CAAC;IAC3B,QAAQ,EAAE,gBAAgB,CAAC;IAC3B,KAAK,CAAC,EAAE,MAAM,CAAC;CAChB,GAAG,mBAAmB,EAAE,CAgCxB;AAED,wBAAgB,oBAAoB,CAAC,OAAO,EAAE,SAAS,mBAAmB,EAAE,GAAG,MAAM,CAcpF"}