agentlas 1.0.65 → 1.0.67

package/engine/project/career-graph.cjs

@@ -182,6 +182,7 @@ async function runCareerGraphCli(args, opts) {
   const sub = normalizedArgs[0] || "status";
   const passivePaths = careerGraphPathsForCli(projectPath);
   if (sub === "status" || sub === "list") {
+    if (normalizedArgs.length > 1) throw new Error(`usage: career-graph ${sub}`);
     if (!initializedAgentlasProjectPathCli(projectPath)) {
       return [
         ko ? "커리어 그래프: 초기화되지 않음" : "Career Graph: not initialized",
@@ -192,7 +193,10 @@ async function runCareerGraphCli(args, opts) {
     }
     return formatCareerGraphStatusCli(passivePaths, opts.lang);
   }
-  if (sub === "help" || sub === "--help" || sub === "-h") return careerGraphUsageLinesCli(opts.lang);
+  if (sub === "help" || sub === "--help" || sub === "-h") {
+    if (normalizedArgs.length > 1) throw new Error("usage: career-graph help");
+    return careerGraphUsageLinesCli(opts.lang);
+  }
   if (["ingest", "query", "verify", "trace"].includes(String(sub))) {
     return [
       ko
@@ -207,6 +211,15 @@ async function runCareerGraphCli(args, opts) {
     const parsed = await parseOntologyNaturalArgsCli(normalizedArgs.join(" "), cwd);
     return runCareerGraphCli(parsed, opts);
   }
+  let directFlags = null;
+  if (sub === "open") {
+    if (normalizedArgs.length !== 1) throw new Error("usage: career-graph open");
+  } else if (sub === "add") {
+    directFlags = parseFlagsCli(normalizedArgs.slice(1));
+    if (directFlags._.length < 1 || directFlags._.length > 3) throw new Error("usage: career-graph add <path> [kind] [scope] [--kind <kind>] [--scope <scope>]");
+    if (directFlags.kind !== undefined && directFlags._[1] !== undefined) throw new Error("kind was provided twice; use either the positional value or --kind");
+    if (directFlags.scope !== undefined && directFlags._[2] !== undefined) throw new Error("scope was provided twice; use either the positional value or --scope");
+  }
   const paths = ensureCareerGraphCli(projectPath, opts.lang);
   if (sub === "open") {
     const opened = opts.noOpen ? true : openLocalPathCli(paths.inboxPath, opts.notify);
@@ -215,7 +228,7 @@ async function runCareerGraphCli(args, opts) {
       : (ko ? "커리어 그래프 수신함을 자동으로 열지 못했습니다. 직접 여세요" : "Could not open Career Graph inbox automatically; open it manually")}: ${paths.inboxPath}`];
   }
   if (sub === "add") {
-    const flags = parseFlagsCli(normalizedArgs.slice(1));
+    const flags = directFlags;
     const source = flags._[0];
     const kind = inferOntologyKindCli(flags.kind || flags._[1], normalizedArgs.join(" "));
     const scope = inferOntologyScopeCli(flags.scope || flags._[2], normalizedArgs.join(" "), kind);

package/engine/project/controller.cjs

@@ -4,6 +4,30 @@ const fs = require("node:fs");
 const path = require("node:path");
 const { listRoutableAgents } = require("../agents/registry.cjs");
 
+const MAX_AGENT_POOL_MEMBERS = 64;
+const MAX_AGENT_POOL_BYTES = 256 * 1024;
+const MAX_AGENT_POOL_MEMBER_BYTES = 8 * 1024;
+const MAX_AGENT_ID_BYTES = 512;
+const MAX_RELEASE_ID_BYTES = 512;
+const MAX_MEMBER_NAME_BYTES = 4 * 1024;
+const MAX_PROJECT_NAME_BYTES = 4 * 1024;
+const MAX_SYSTEM_PROMPT_BYTES = 256 * 1024;
+const MAX_COMBINED_SYSTEM_PROMPT_BYTES = 512 * 1024;
+
+function projectError(code, message) {
+  return Object.assign(new Error(message), { code, honestStop: true });
+}
+
+function boundedText(value, maxBytes, label, { allowEmpty = false } = {}) {
+  if (typeof value !== "string") throw projectError("project_team_unreadable", `This project's ${label} is invalid.`);
+  const text = value.trim();
+  if (!allowEmpty && !text) throw projectError("project_team_unreadable", `This project's ${label} is empty.`);
+  if (Buffer.byteLength(text, "utf8") > maxBytes || /[\u0000\u0001-\u0008\u000b\u000c\u000e-\u001f\u007f]/.test(text)) {
+    throw projectError("project_team_unreadable", `This project's ${label} is invalid or too large.`);
+  }
+  return text;
+}
+
 function canonicalPath(value) {
   const resolved = path.resolve(String(value || ""));
   try {
@@ -27,19 +51,80 @@ function projectColumns(db) {
 }
 
 function parseAgentPool(raw) {
+  if (raw !== undefined && raw !== null && typeof raw !== "string") {
+    throw projectError("project_team_unreadable", "This project's agent team cannot be read. Open the project in Agentlas Desktop and save its team again.");
+  }
+  const encoded = raw === undefined || raw === null ? "[]" : raw;
+  if (Buffer.byteLength(encoded, "utf8") > MAX_AGENT_POOL_BYTES) {
+    throw projectError("project_team_unreadable", "This project's agent team is too large. Open the project in Agentlas Desktop and save its team again.");
+  }
   let parsed;
   try {
-    parsed = JSON.parse(raw || "[]");
+    parsed = JSON.parse(encoded || "[]");
   } catch {
-    throw Object.assign(new Error("This project's agent team cannot be read. Open the project in Agentlas Desktop and save its team again."), { code: "project_team_unreadable", honestStop: true });
+    throw projectError("project_team_unreadable", "This project's agent team cannot be read. Open the project in Agentlas Desktop and save its team again.");
   }
   if (!Array.isArray(parsed)) {
-    throw Object.assign(new Error("This project's agent team cannot be read. Open the project in Agentlas Desktop and save its team again."), { code: "project_team_unreadable", honestStop: true });
+    throw projectError("project_team_unreadable", "This project's agent team cannot be read. Open the project in Agentlas Desktop and save its team again.");
   }
-  return parsed.filter((member) => member && typeof member === "object"
-    && typeof member.agentId === "string" && member.agentId.trim()
-    && ["local", "cloud", "hub"].includes(member.source)
-    && typeof member.nameSnapshot === "string");
+  if (parsed.length > MAX_AGENT_POOL_MEMBERS) {
+    throw projectError("project_team_too_large", "This project's agent team has too many members. Open the project in Agentlas Desktop and save its team again.");
+  }
+  const seen = new Set();
+  return parsed.map((member, index) => {
+    if (!member || typeof member !== "object" || Array.isArray(member)) {
+      throw projectError("project_team_unreadable", `This project's agent team member ${index + 1} is invalid.`);
+    }
+    if (Buffer.byteLength(JSON.stringify(member), "utf8") > MAX_AGENT_POOL_MEMBER_BYTES) {
+      throw projectError("project_team_unreadable", `This project's agent team member ${index + 1} is too large.`);
+    }
+    const keys = Object.keys(member).sort();
+    const legacyKeys = ["agentId", "nameSnapshot", "releaseId", "source"];
+    const canonicalKeys = ["agentId", "controllerAgentId", "entityKind", "firmId", "nameSnapshot", "releaseId", "source", "targetId"];
+    const isLegacy = keys.length === legacyKeys.length && keys.every((key, keyIndex) => key === legacyKeys[keyIndex]);
+    const isCanonical = keys.length === canonicalKeys.length && keys.every((key, keyIndex) => key === canonicalKeys[keyIndex]);
+    if (!isLegacy && !isCanonical) {
+      throw projectError("project_team_unreadable", `This project's agent team member ${index + 1} is incomplete.`);
+    }
+    const nameSnapshot = boundedText(member.nameSnapshot, MAX_MEMBER_NAME_BYTES, `agent team member ${index + 1} name`);
+    if (!["local", "cloud", "hub"].includes(member.source)) {
+      throw projectError("project_team_unreadable", `This project's agent team member ${index + 1} has an invalid source.`);
+    }
+    const releaseId = member.releaseId === null
+      ? null
+      : boundedText(member.releaseId, MAX_RELEASE_ID_BYTES, `agent team member ${index + 1} release`);
+    if (isLegacy) {
+      const agentId = boundedText(member.agentId, MAX_AGENT_ID_BYTES, `agent team member ${index + 1} agentId`);
+      const key = `${member.source}:agent:${agentId}:${releaseId || ""}`;
+      if (seen.has(key)) throw projectError("project_team_unreadable", `This project's agent team member ${index + 1} is duplicated.`);
+      seen.add(key);
+      return {
+        entityKind: "agent", targetId: agentId, agentId, firmId: null, controllerAgentId: null,
+        source: member.source, releaseId, nameSnapshot,
+      };
+    }
+
+    if (member.entityKind !== "agent" && member.entityKind !== "team") {
+      throw projectError("project_team_unreadable", `This project's agent team member ${index + 1} has an invalid entity kind.`);
+    }
+    const optionalId = (value, label) => value === null
+      ? null
+      : boundedText(value, MAX_AGENT_ID_BYTES, `agent team member ${index + 1} ${label}`);
+    const targetId = boundedText(member.targetId, MAX_AGENT_ID_BYTES, `agent team member ${index + 1} targetId`);
+    const agentId = optionalId(member.agentId, "agentId");
+    const firmId = optionalId(member.firmId, "firmId");
+    const controllerAgentId = optionalId(member.controllerAgentId, "controllerAgentId");
+    if (member.entityKind === "agent" && (firmId !== null || controllerAgentId !== null || (member.source === "local" && agentId === null))) {
+      throw projectError("project_team_unreadable", `This project's agent team member ${index + 1} has inconsistent agent identity fields.`);
+    }
+    if (member.entityKind === "team" && (agentId !== null || (member.source === "local" && firmId === null))) {
+      throw projectError("project_team_unreadable", `This project's agent team member ${index + 1} has inconsistent team identity fields.`);
+    }
+    const key = `${member.source}:${member.entityKind}:${targetId}:${releaseId || ""}`;
+    if (seen.has(key)) throw projectError("project_team_unreadable", `This project's agent team member ${index + 1} is duplicated.`);
+    seen.add(key);
+    return { entityKind: member.entityKind, targetId, agentId, firmId, controllerAgentId, source: member.source, releaseId, nameSnapshot };
+  });
 }
 
 function resolveProjectForCwd(db, cwd) {
@@ -64,7 +149,23 @@ function resolveProjectForCwd(db, cwd) {
   if (best.length !== 1) {
     throw Object.assign(new Error("More than one Agentlas project is connected to this folder. Keep one source connection, then retry."), { code: "project_ambiguous", honestStop: true });
   }
-  return { ...best[0].row, rootPath: best[0].root, agentPool: parseAgentPool(best[0].row.agent_pool_json) };
+  const row = best[0].row;
+  boundedText(row.name, MAX_PROJECT_NAME_BYTES, "name");
+  if (row.system_prompt !== null && row.system_prompt !== undefined) {
+    boundedText(row.system_prompt, MAX_SYSTEM_PROMPT_BYTES, "system prompt", { allowEmpty: true });
+  }
+  return { ...row, rootPath: best[0].root, agentPool: parseAgentPool(row.agent_pool_json) };
+}
+
+function exactInstalledRelease(db, agentId) {
+  try {
+    const row = db.prepare(
+      "SELECT agent_release_id FROM installed_agent_hub_bindings WHERE installed_agent_id=?",
+    ).get(agentId);
+    return row && typeof row.agent_release_id === "string" ? row.agent_release_id : null;
+  } catch {
+    return null;
+  }
 }
 
 function resolveProjectController(db, cwd) {
@@ -73,10 +174,19 @@ function resolveProjectController(db, cwd) {
     throw Object.assign(new Error("This project has no agent team. Drag agents into the project in Desktop Work, then retry."), { code: "project_team_empty", honestStop: true });
   }
   const controllerRef = project.agentPool[0];
-  if (controllerRef.source !== "local") {
+  const controllerAgentId = controllerRef.entityKind === "team"
+    ? controllerRef.controllerAgentId
+    : controllerRef.agentId;
+  if (!controllerAgentId) {
     throw Object.assign(new Error(`The project controller “${controllerRef.nameSnapshot}” is not installed locally for Terminal execution. Install that exact release locally or reorder the project team.`), { code: "controller_not_installed", honestStop: true });
   }
-  const controller = listRoutableAgents(db).find((agent) => agent.id === controllerRef.agentId) || null;
+  if (controllerRef.entityKind === "team" && controllerRef.source !== "local" && controllerRef.releaseId !== null) {
+    throw projectError("controller_release_unavailable", `The project controller team “${controllerRef.nameSnapshot}” needs its exact team release restored before Terminal can execute it.`);
+  }
+  if (controllerRef.entityKind === "agent" && controllerRef.releaseId !== null && exactInstalledRelease(db, controllerAgentId) !== controllerRef.releaseId) {
+    throw projectError("controller_release_unavailable", `The project controller “${controllerRef.nameSnapshot}” is pinned to an unavailable exact release. Restore that release or explicitly choose a new first agent in Desktop Work.`);
+  }
+  const controller = listRoutableAgents(db).find((agent) => agent.id === controllerAgentId) || null;
   if (!controller) {
     throw Object.assign(new Error(`The project controller “${controllerRef.nameSnapshot}” is unavailable. Restore that agent or explicitly choose a new first agent in Desktop Work.`), { code: "controller_unavailable", honestStop: true });
   }
@@ -84,22 +194,30 @@ function resolveProjectController(db, cwd) {
 }
 
 function withProjectControllerContext(controller, project) {
+  const projectName = boundedText(project.name, MAX_PROJECT_NAME_BYTES, "name");
   const team = project.agentPool.map((member, index) =>
     `${index + 1}. ${member.nameSnapshot} (${member.source}${member.releaseId ? `, exact release ${member.releaseId}` : ""})`,
   ).join("\n");
-  const projectInstruction = String(project.system_prompt || "").trim();
+  const projectInstruction = project.system_prompt === null || project.system_prompt === undefined
+    ? ""
+    : boundedText(project.system_prompt, MAX_SYSTEM_PROMPT_BYTES, "system prompt", { allowEmpty: true });
+  const controllerPrompt = boundedText(controller.systemPrompt || "", MAX_SYSTEM_PROMPT_BYTES, "controller system prompt", { allowEmpty: true });
   const ownership = [
-    `You are the controller for the Agentlas Work project “${project.name}”.`,
+    `You are the controller for the Agentlas Work project “${projectName}”.`,
     "You own this task. The remaining ordered project members are eligible sub-agents for task-scoped WorkOrders only.",
     "Do not transfer task ownership, silently substitute an unavailable member, or claim a sub-agent ran without an assignment and execution receipt.",
     "Project team:",
     team,
   ].join("\n");
+  const systemPrompt = [controllerPrompt, projectInstruction && `Project system prompt:\n${projectInstruction}`, ownership]
+    .filter(Boolean)
+    .join("\n\n");
+  if (Buffer.byteLength(systemPrompt, "utf8") > MAX_COMBINED_SYSTEM_PROMPT_BYTES) {
+    throw projectError("project_context_too_large", "This project's controller context is too large to execute safely.");
+  }
   return {
     ...controller,
-    systemPrompt: [controller.systemPrompt, projectInstruction && `Project system prompt:\n${projectInstruction}`, ownership]
-      .filter(Boolean)
-      .join("\n\n"),
+    systemPrompt,
   };
 }