agentlas 1.0.65 → 1.0.66

package/engine/cloud-assets/commands.cjs

@@ -166,30 +166,80 @@ function writePurposeRepairCopy(root, projection) {
   return tempRoot;
 }
 
-function parseCloudFlags(args) {
+const CLOUD_VALUE_FLAGS = ["limit", "name", "purpose", "scope", "slug", "visibility"];
+const CLOUD_BOOLEAN_FLAGS = ["dry-run", "json", "llm-review", "overwrite", "strict"];
+
+function cloudArgumentError(message) {
+  const error = new Error(message);
+  error.code = "INVALID_ARGUMENT";
+  return error;
+}
+
+function parseCloudFlags(args, spec = {}) {
+  const values = new Set(spec.values || CLOUD_VALUE_FLAGS);
+  const booleans = new Set(spec.booleans || CLOUD_BOOLEAN_FLAGS);
   const flags = { _: [] };
+  const seen = new Set();
+  let positionalOnly = false;
   for (let i = 0; i < args.length; i++) {
     const a = args[i];
-    if (a && a.startsWith("--")) {
-      const key = a.slice(2);
-      const next = args[i + 1];
-      if (next !== undefined && !String(next).startsWith("--")) {
-        flags[key] = next;
-        i++;
-      } else {
-        flags[key] = true;
-      }
-    } else {
+    if (positionalOnly) {
       flags._.push(a);
+      continue;
     }
+    if (a === "--") {
+      positionalOnly = true;
+      continue;
+    }
+    if (!String(a).startsWith("-")) {
+      flags._.push(a);
+      continue;
+    }
+    if (!String(a).startsWith("--")) throw cloudArgumentError(`unknown option: ${a}`);
+    const equal = String(a).indexOf("=");
+    const key = String(a).slice(2, equal === -1 ? undefined : equal);
+    if (!key || (!values.has(key) && !booleans.has(key))) throw cloudArgumentError(`unknown option: --${key || ""}`);
+    if (seen.has(key)) throw cloudArgumentError(`duplicate option: --${key}`);
+    seen.add(key);
+    if (booleans.has(key)) {
+      if (equal !== -1) throw cloudArgumentError(`--${key} does not take a value`);
+      flags[key] = true;
+      continue;
+    }
+    let value;
+    if (equal !== -1) {
+      value = String(a).slice(equal + 1);
+    } else {
+      const next = args[i + 1];
+      if (next === undefined || String(next).startsWith("--")) throw cloudArgumentError(`--${key} requires a value`);
+      value = String(next);
+      i++;
+    }
+    if (!value) throw cloudArgumentError(`--${key} requires a non-empty value`);
+    flags[key] = value;
   }
   return flags;
 }
 
+function requireCloudPositionals(flags, min, max, usage) {
+  if (flags._.length < min || flags._.length > max) throw cloudArgumentError(usage);
+  return flags;
+}
+
+function positiveIntegerFlag(value, fallback, name, max) {
+  if (value == null) return fallback;
+  if (!/^\d+$/.test(String(value))) throw cloudArgumentError(`--${name} must be a positive integer`);
+  const parsed = Number(value);
+  if (!Number.isSafeInteger(parsed) || parsed < 1 || parsed > max) {
+    throw cloudArgumentError(`--${name} must be between 1 and ${max}`);
+  }
+  return parsed;
+}
+
 function cloudVisibilityFlag(value) {
   if (value == null) return null;
   if (value === "private-link" || value === "marketplace") return value;
-  throw new Error("--visibility must be private-link or marketplace");
+  throw cloudArgumentError("--visibility must be private-link or marketplace");
 }
 
 function cloudVisibilityForAction(sub, flags) {
@@ -213,7 +263,10 @@ function cloudVisibilityForAction(sub, flags) {
 
 /** 최상위 `upload`의 실제 동작 결정: 기본 save, 명시적 marketplace만 publish. */
 function cloudActionForTopLevelUpload(args) {
-  const flags = parseCloudFlags(args);
+  const flags = requireCloudPositionals(parseCloudFlags(args, {
+    values: ["purpose", "slug", "visibility"],
+    booleans: ["dry-run", "json", "llm-review", "overwrite"],
+  }), 1, 1, "usage: agentlas upload <path> [--visibility marketplace]");
   return cloudVisibilityFlag(flags.visibility) === "marketplace" ? "publish" : "save";
 }
 
@@ -269,17 +322,20 @@ const CLOUD_HELP = [
 async function runCloud(ctx, args) {
   const sub = args[0] || "help";
   if (sub === "help" || sub === "--help" || sub === "-h") {
+    requireCloudPositionals(parseCloudFlags(args.slice(1), { values: [], booleans: ["json"] }), 0, 0, "usage: agentlas cloud help");
     ctx.out(CLOUD_HELP);
     return 0;
   }
   if (sub === "search") {
-    const flags = parseCloudFlags(args.slice(1));
+    const flags = requireCloudPositionals(parseCloudFlags(args.slice(1), {
+      values: ["limit"], booleans: ["json"],
+    }), 1, Number.MAX_SAFE_INTEGER, 'usage: agentlas cloud search "<what you need>" [--limit 10]');
     const query = flags._.join(" ").trim();
     if (!query) {
       ctx.err('usage: agentlas cloud search "<what you need>" [--limit 10]');
       return 1;
     }
-    const limit = Math.max(1, Math.min(30, Number(flags.limit) || 10));
+    const limit = positiveIntegerFlag(flags.limit, 10, "limit", 30);
     let result;
     try {
       result = await callHubTool("marketplace.search_agents", { q: query, limit });
@@ -287,6 +343,7 @@ async function runCloud(ctx, args) {
       ctx.err(e instanceof HubError ? e.message : `Marketplace connection failed: ${(e && e.message) || e}`);
       return 1;
     }
+    if (flags.json) { ctx.out(JSON.stringify(result, null, 2)); return 0; }
     const items = (result && (result.results || result.agents || result.items)) || [];
     if (!Array.isArray(items) || !items.length) {
       ctx.out(`No results for "${query}"`);
@@ -298,8 +355,10 @@ async function runCloud(ctx, args) {
     return 0;
   }
   if (sub === "list") {
-    const flags = parseCloudFlags(args.slice(1));
-    const result = await listOwnedCloudAgents(Number(flags.limit || 100));
+    const flags = requireCloudPositionals(parseCloudFlags(args.slice(1), {
+      values: ["limit"], booleans: ["json"],
+    }), 0, 0, "usage: agentlas cloud list [--limit 100] [--json]");
+    const result = await listOwnedCloudAgents(positiveIntegerFlag(flags.limit, 100, "limit", 1000));
     if (flags.json) { ctx.out(JSON.stringify(result, null, 2)); return 0; }
     const agents = Array.isArray(result.results) ? result.results : [];
     if (!agents.length) { ctx.out("No agents are stored in Private Agent Cloud."); return 0; }
@@ -332,7 +391,9 @@ async function runCloud(ctx, args) {
     return 0;
   }
   if (sub === "restore") {
-    const flags = parseCloudFlags(args.slice(1));
+    const flags = requireCloudPositionals(parseCloudFlags(args.slice(1), {
+      values: [], booleans: ["json"],
+    }), 1, 1, "usage: agentlas cloud restore <slug> [--json]");
     const slug = flags._[0];
     if (!slug) { ctx.err("usage: agentlas cloud restore <slug> [--json]"); return 1; }
     const result = await restoreOwnedCloudAgent(ctx.db(), slug);
@@ -344,7 +405,9 @@ async function runCloud(ctx, args) {
     return 0;
   }
   if (sub === "delete" || sub === "unpublish") {
-    const flags = parseCloudFlags(args.slice(1));
+    const flags = requireCloudPositionals(parseCloudFlags(args.slice(1), {
+      values: ["scope"], booleans: ["json"],
+    }), 1, 1, `usage: agentlas cloud ${sub} <slug> [--scope owner-private|hub-public] [--json]`);
     const slug = flags._[0];
     if (!slug) { ctx.err(`usage: agentlas cloud ${sub} <slug> [--json]`); return 1; }
     const result = await deleteCloudAgent(slug, { scope: flags.scope });
@@ -356,7 +419,9 @@ async function runCloud(ctx, args) {
   }
   // ── agentlas-cloud-runtime 소비 지점 (스캔/매니페스트/lazy-read/필드테스트) ──
   if (sub === "wizard") {
-    const flags = parseCloudFlags(args.slice(1));
+    const flags = requireCloudPositionals(parseCloudFlags(args.slice(1), {
+      values: ["name"], booleans: ["json"],
+    }), 1, 1, "usage: agentlas cloud wizard <path> [--name name] [--json]");
     const root = flags._[0];
     if (!root) { ctx.err("usage: agentlas cloud wizard <path> [--name name]"); return 1; }
     const result = cloudRuntime.runWizard(root, { name: typeof flags.name === "string" ? flags.name : undefined });
@@ -365,7 +430,9 @@ async function runCloud(ctx, args) {
   }
   if (sub === "security") {
     if (args[1] !== "scan") { ctx.err("usage: agentlas cloud security scan <path> [--strict]"); return 1; }
-    const flags = parseCloudFlags(args.slice(2));
+    const flags = requireCloudPositionals(parseCloudFlags(args.slice(2), {
+      values: [], booleans: ["json", "strict"],
+    }), 1, 1, "usage: agentlas cloud security scan <path> [--strict]");
     const root = flags._[0];
     if (!root) { ctx.err("usage: agentlas cloud security scan <path> [--strict]"); return 1; }
     const report = cloudRuntime.scanFolder(root);
@@ -375,15 +442,18 @@ async function runCloud(ctx, args) {
   if (sub === "runtime") {
     const action = args[1];
     if (action === "bundle") {
-      const root = args[2];
-      if (!root) { ctx.err("usage: agentlas cloud runtime bundle <path>"); return 1; }
+      const flags = requireCloudPositionals(parseCloudFlags(args.slice(2), {
+        values: [], booleans: ["json"],
+      }), 1, 1, "usage: agentlas cloud runtime bundle <path> [--json]");
+      const root = flags._[0];
       ctx.out(JSON.stringify(cloudRuntime.compileBundle(root), null, 2));
       return 0;
     }
     if (action === "read-agent-file") {
-      const root = args[2];
-      const targetPath = args[3];
-      if (!root || !targetPath) { ctx.err("usage: agentlas cloud runtime read-agent-file <path> <file>"); return 1; }
+      const flags = requireCloudPositionals(parseCloudFlags(args.slice(2), {
+        values: [], booleans: ["json"],
+      }), 2, 2, "usage: agentlas cloud runtime read-agent-file <path> <file> [--json]");
+      const [root, targetPath] = flags._;
       ctx.out(JSON.stringify(cloudRuntime.readAgentFile(root, targetPath), null, 2));
       return 0;
     }
@@ -391,15 +461,20 @@ async function runCloud(ctx, args) {
     return 1;
   }
   if (sub === "field-test") {
-    const flags = parseCloudFlags(args.slice(1));
+    const flags = requireCloudPositionals(parseCloudFlags(args.slice(1), {
+      values: [], booleans: ["json"],
+    }), 0, 0, "usage: agentlas cloud field-test [--json]");
     const result = cloudRuntime.runFieldTest();
     ctx.out(flags.json ? JSON.stringify(result, null, 2) : `${result.suite}: ${result.status}`);
     return result.status === "PASS" ? 0 : 1;
   }
   if (sub === "install") {
-    const slug = args[1];
-    if (!slug) { ctx.err("usage: agentlas cloud install <slug>"); return 1; }
+    const flags = requireCloudPositionals(parseCloudFlags(args.slice(1), {
+      values: [], booleans: ["json"],
+    }), 1, 1, "usage: agentlas cloud install <slug> [--json]");
+    const slug = flags._[0];
     const agent = await installHubAgent(ctx.db(), slug);
+    if (flags.json) { ctx.out(JSON.stringify(agent, null, 2)); return 0; }
     ctx.out(`${ctx.ui.green("✓")} Hub installed ${agent.slug} — ${agent.name}`);
     if (agent.localPath) ctx.out(`  files: ${agent.localPath}`);
     return 0;
@@ -408,7 +483,10 @@ async function runCloud(ctx, args) {
     ctx.err("usage: agentlas cloud <save|publish|package|list|restore|install|delete|field-test> ...");
     return 1;
   }
-  const flags = parseCloudFlags(args.slice(1));
+  const flags = requireCloudPositionals(parseCloudFlags(args.slice(1), {
+    values: ["purpose", "slug", "visibility"],
+    booleans: ["dry-run", "json", "llm-review", "overwrite"],
+  }), 1, 1, `usage: agentlas cloud ${sub} <path>`);
   const root = flags._[0];
   if (!root) { ctx.err(`usage: agentlas cloud ${sub} <path>`); return 1; }
   const visibility = cloudVisibilityForAction(sub, flags);

package/engine/cloud-assets/package.cjs

@@ -52,6 +52,7 @@ const cas = require("./cas.cjs");
 // 터미널 업로드가 그 파일들을 아예 열지 않았다.
 const CLOUD_TEXT_EXTS = new Set(SECRET_SCAN_TEXT_EXTENSIONS);
 const CLOUD_AGENT_FILES = new Set(UPLOAD_AGENT_DEFINITION_FILES);
+const CLOUD_AGENT_FILE_KEYS = new Set([...CLOUD_AGENT_FILES].map((name) => name.toLowerCase()));
 const CLOUD_SKIP_DIRS = new Set(UPLOAD_SKIP_DIRECTORIES);
 const CLOUD_BLOCKED_FILE_RE = [/^\.env(?:\..*)?$/i, /^id_rsa(?:\.pub)?$/i, /^credentials(?:\..*)?$/i, /^secrets?(?:\..*)?$/i, /^cloud-asset-state\.v1\.json$/i, /(?:^|[._-])service-account(?:[._-]|$)/i, /\.(?:key|pem|p12|pfx|mobileprovision)$/i];
 const CLOUD_ROUTING_CARD_PATH = ".agentlas/routing-card.json";
@@ -385,7 +386,11 @@ const CLOUD_BULK_DATA_RE = /\.(log|jsonl|csv|tsv|lock)$/;
 function cloudTrimRank(rel, bytes) {
   const lower = String(rel || "").toLowerCase();
   const base = lower.split("/").pop() || lower;
-  if (CLOUD_AGENT_FILES.has(base)) return 0;
+  // The generated catalog intentionally carries case-distinct root names
+  // (`AGENTS.md`, `AGENT.md`, `agent.md`).  Ranking lower-cases paths, so the
+  // lookup must lower-case the catalog as well.  Otherwise a package at the
+  // byte limit can evict AGENTS.md while retaining an unrelated cache file.
+  if (CLOUD_AGENT_FILE_KEYS.has(base)) return 0;
   if (lower.startsWith(".agentlas/")) return 0;
   if (base === "agentlas.json" || base === "manifest.json" || base === "package.json") return 0;
   if (CLOUD_CAPABILITY_DIR_RE.test(lower)) return 0;
@@ -427,13 +432,16 @@ function scanCloudFolder(rootPath) {
     let freed = 0;
     while (totalBytes - freed + needBytes > CLOUD_MAX_TOTAL_BYTES) {
       let victimIndex = -1;
-      let victimRank = 0;
+      let victimRank = Number.POSITIVE_INFINITY;
       let victimBytes = -1;
       for (let index = 0; index < included.length; index += 1) {
         const candidate = included[index];
         const rank = cloudTrimRank(candidate.path, candidate.bytes);
         if (rank === 0) continue;
-        if (rank > victimRank || (rank === victimRank && candidate.bytes > victimBytes)) {
+        // Rank 1 is disposable build/cache output; larger numbers are closer
+        // to ordinary authored content.  Desktop's canonical trimmer removes
+        // the smallest positive rank first, then the largest file in that tier.
+        if (rank < victimRank || (rank === victimRank && candidate.bytes > victimBytes)) {
           victimIndex = index;
           victimRank = rank;
           victimBytes = candidate.bytes;
@@ -709,6 +717,60 @@ function scanCloudFolder(rootPath) {
   return { files, included, findings, omissions, totalBytes, localPackageMarker };
 }
 
+/**
+ * Generated metadata is added after the stable source scan.  Re-apply the
+ * public package limits at that exact boundary so injecting agentlas.json (or
+ * replacing a redacted public card) cannot turn a valid 400-file scan into a
+ * 401-file bundle that the server will reject.
+ */
+function cloudFitGeneratedMetadataToLimits(scan) {
+  const removeVictim = () => {
+    let victimIndex = -1;
+    let victimRank = Number.POSITIVE_INFINITY;
+    let victimBytes = -1;
+    for (let index = 0; index < scan.included.length; index += 1) {
+      const candidate = scan.included[index];
+      const rank = cloudTrimRank(candidate.path, candidate.bytes);
+      if (rank === 0) continue;
+      if (rank < victimRank || (rank === victimRank && candidate.bytes > victimBytes)) {
+        victimIndex = index;
+        victimRank = rank;
+        victimBytes = candidate.bytes;
+      }
+    }
+    if (victimIndex < 0) return false;
+    const victim = scan.included.splice(victimIndex, 1)[0];
+    scan.omissions.push({
+      path: victim.path,
+      reason: "trimmed-for-package-limits",
+      sourceBytes: victim.bytes,
+      sourceSha256: victim.sha256,
+      sourceHashKind: "content",
+    });
+    const record = scan.files.find((item) => item.path === victim.path && item.included);
+    if (record) {
+      record.included = false;
+      record.reason = "trimmed-for-package-limits";
+    }
+    return true;
+  };
+
+  scan.totalBytes = scan.included.reduce((sum, file) => sum + file.bytes, 0);
+  while (scan.included.length > CLOUD_MAX_FILES || scan.totalBytes > CLOUD_MAX_TOTAL_BYTES) {
+    if (!removeVictim()) {
+      const error = new Error(
+        "Agent Cloud package cannot fit required agent metadata within the package limits. " +
+        "Reduce the number or size of capability files and retry.",
+      );
+      error.code = "AGENTLAS_CLOUD_PACKAGE_LIMITS";
+      throw error;
+    }
+    scan.totalBytes = scan.included.reduce((sum, file) => sum + file.bytes, 0);
+  }
+  scan.included.sort(cloudCodePointPathOrder);
+  scan.omissions.sort(cloudCodePointPathOrder);
+}
+
 function cloudOmissionReceipt(omissions) {
   if (!Array.isArray(omissions) || omissions.length === 0) return undefined;
   const entries = omissions.map((entry) => ({
@@ -1074,6 +1136,7 @@ async function packageCloudAgent(db, root, opts = {}) {
   }
   // 신원은 해시 계산 전에 채운다 — 클라우드 해시는 agentlas.json 을 포함한다.
   cloudEnsureAgentIdentity(scan, snapshot, rootPath.split("/").pop());
+  cloudFitGeneratedMetadataToLimits(scan);
   snapshot = cloudPackageSnapshot(scan.included);
   const routingCard = isPublicHubPublish ? readCloudRoutingCard(snapshot) : {};
   if (routingCard.finding) scan.findings.push(routingCard.finding);

package/engine/cloud-assets/restore.cjs

@@ -30,15 +30,18 @@ async function listOwnedCloudAgents(limit = 100) {
   };
   if (!Array.isArray(result.results)) throw new Error("Agent Cloud list returned an invalid results contract.");
   if (result.results.length) {
-    const stateValue = state.readCloudAssetState();
-    for (const raw of result.results) {
-      const descriptor = normalizeCloudAssetDescriptor(raw, "Agent Cloud list result");
-      const key = state.cloudDescriptorKey(descriptor);
-      const previous = stateValue.assets[key];
-      const preserveRoots = previous && previous.descriptor.cloudId === descriptor.cloudId && previous.descriptor.revision === descriptor.revision;
-      stateValue.assets[key] = { descriptor, sourceRoots: preserveRoots ? previous.sourceRoots : [] };
-    }
-    state.writeCloudAssetState(stateValue);
+    const descriptors = result.results.map((raw) => normalizeCloudAssetDescriptor(raw, "Agent Cloud list result"));
+    state.updateCloudAssetState((stateValue) => {
+      for (const descriptor of descriptors) {
+        const key = state.cloudDescriptorKey(descriptor);
+        const previous = stateValue.assets[key];
+        // A list response may race a save that completed after the server made
+        // the list snapshot. Never regress a newer locally observed receipt.
+        if (previous && Date.parse(previous.descriptor.updatedAt) > Date.parse(descriptor.updatedAt)) continue;
+        const preserveRoots = previous && previous.descriptor.cloudId === descriptor.cloudId && previous.descriptor.revision === descriptor.revision;
+        stateValue.assets[key] = { descriptor, sourceRoots: preserveRoots ? previous.sourceRoots : [] };
+      }
+    });
   }
   return result;
 }