agentlas 1.0.64 → 1.0.66

package/engine/commands/workforce.cjs

@@ -27,9 +27,9 @@ function resolvePermission(ctx) {
   // persistent()가 fail-closed 로 강등한다.
   try {
     const policy = require("../agentlas-permissions.cjs");
-    return policy.persistent(ctx && ctx.prefs && ctx.prefs.permission, "write");
+    return policy.persistent(ctx && ctx.prefs && ctx.prefs.permission, "read");
   } catch {
-    return "write";
+    return "read";
   }
 }
 
@@ -37,16 +37,56 @@ function resolvePermission(ctx) {
 function splitRuntimeOverride(args) {
   const rest = [];
   let runtimeOverride = null;
+  let seen = false;
+  let passthrough = false;
   for (let i = 0; i < args.length; i += 1) {
-    if (args[i] === "--runtime" && args[i + 1]) {
-      runtimeOverride = String(args[++i]);
+    const token = String(args[i]);
+    if (passthrough) { rest.push(token); continue; }
+    if (token === "--") { passthrough = true; rest.push(token); continue; }
+    if (token === "--runtime" || token.startsWith("--runtime=")) {
+      if (seen) throw new Error("duplicate option: --runtime");
+      seen = true;
+      const inline = token.startsWith("--runtime=");
+      const value = inline ? token.slice(10) : args[++i];
+      if (value === undefined || value === "" || (!inline && String(value).startsWith("--"))) {
+        throw new Error("--runtime requires a value");
+      }
+      runtimeOverride = String(value);
       continue;
     }
-    rest.push(args[i]);
+    rest.push(token);
   }
   return { rest, runtimeOverride };
 }
 
+function validateWorkforceArgs(args) {
+  const seen = new Set();
+  let passthrough = false;
+  let hasTask = false;
+  for (let i = 0; i < args.length; i += 1) {
+    const token = String(args[i]);
+    if (passthrough) { hasTask = true; continue; }
+    if (token === "--") { passthrough = true; continue; }
+    if (token === "--benchmark" || token === "--json") {
+      const key = token.slice(2);
+      if (seen.has(key)) return { error: `duplicate option: ${token}`, hasTask };
+      seen.add(key);
+    } else if (token === "--parallel" || token === "-n" || token.startsWith("--parallel=")) {
+      if (seen.has("parallel")) return { error: "duplicate option: --parallel", hasTask };
+      seen.add("parallel");
+      const inline = token.startsWith("--parallel=");
+      const raw = inline ? token.slice(11) : args[++i];
+      const value = Number(raw);
+      if (raw === undefined || raw === "" || (!inline && String(raw).startsWith("--")) || !Number.isInteger(value) || value < 1 || value > 8) {
+        return { error: "--parallel requires a positive integer (maximum 8)", hasTask };
+      }
+    } else if (token.startsWith("-")) {
+      return { error: `unknown option: ${token} (use -- before a task token that starts with '-')`, hasTask };
+    } else hasTask = true;
+  }
+  return { error: null, hasTask };
+}
+
 /**
  * command 별 디스패치. commands/index.cjs 는 명령 이름을 별도 인자로 넘기지 않으므로
  * run()이 기본 "workforce" 로 진입하고, 별칭 배선 시 이 dispatch 를 직접 쓴다.
@@ -56,13 +96,15 @@ async function dispatch(ctx, command, args) {
     case "workforce":
     case "network":
     case "taskforce": {
-      const { rest, runtimeOverride } = splitRuntimeOverride(args);
+      let parsed;
+      try { parsed = splitRuntimeOverride(args); }
+      catch (error) { ctx.err(String((error && error.message) || error)); return 1; }
+      const { rest, runtimeOverride } = parsed;
+      const validation = validateWorkforceArgs(rest);
+      if (validation.error) { ctx.err(validation.error); return 1; }
       // usage 경로(작업 텍스트 없음)는 SQLite를 열 이유가 없다 — cmdWorkforce 의
       // parseArgs 와 동일한 판정: 플래그가 아닌 토큰이 하나도 없으면 빈 작업이다.
-      const hasTask = rest.some((token, i) =>
-        !["--benchmark", "--json", "--parallel", "-n"].includes(String(token))
-        && !(i > 0 && ["--parallel", "-n"].includes(String(rest[i - 1]))));
-      if (!hasTask) {
+      if (!validation.hasTask) {
         ctx.err("usage: agentlas workforce <task> [--parallel N] [--benchmark] [--json] [--runtime <kind>]");
         return 1;
       }
@@ -107,11 +149,13 @@ async function dispatch(ctx, command, args) {
     case "hep-hub": {
       const sourceScope = command.slice(4); // network|local|cloud|hub
       const ko = ctx.lang !== "en";
-      const { rest, runtimeOverride } = splitRuntimeOverride(args);
-      const hasTask = rest.some((token, i) =>
-        !["--benchmark", "--json", "--parallel", "-n"].includes(String(token))
-        && !(i > 0 && ["--parallel", "-n"].includes(String(rest[i - 1]))));
-      if (!hasTask) {
+      let parsed;
+      try { parsed = splitRuntimeOverride(args); }
+      catch (error) { ctx.err(String((error && error.message) || error)); return 1; }
+      const { rest, runtimeOverride } = parsed;
+      const validation = validateWorkforceArgs(rest);
+      if (validation.error) { ctx.err(validation.error); return 1; }
+      if (!validation.hasTask) {
         ctx.err(`usage: agentlas ${command} "<task>" [--parallel N] [--json] [--runtime <kind>]`);
         return 1;
       }
@@ -162,4 +206,4 @@ function run(ctx, args) {
   return dispatch(ctx, "workforce", args);
 }
 
-module.exports = { run, dispatch };
+module.exports = { run, dispatch, splitRuntimeOverride, validateWorkforceArgs };

package/engine/core/capability-grants.cjs

@@ -55,7 +55,9 @@ function patternMatches(pattern, detail) {
   if (pattern === null || pattern === undefined || pattern === "") return true;
   if (!detail) return false;
   const text = String(pattern);
-  if (text.endsWith("*")) return String(detail).startsWith(text.slice(0, -1).trimEnd());
+  // Keep the separator before `*`. Removing it turns `git push *` into the
+  // broader prefix `git push`, which also authorizes unrelated `git pushx`.
+  if (text.endsWith("*")) return String(detail).startsWith(text.slice(0, -1));
   return String(detail) === text;
 }
 
@@ -126,7 +128,10 @@ function recordCapabilityGrant(db, input) {
   if (!capabilityGrantsAvailable(db)) {
     return { ok: false, available: false, reason: UNAVAILABLE_REASON };
   }
-  const decision = input && input.decision === "deny" ? "deny" : "allow";
+  const decision = input && input.decision;
+  if (decision !== "allow" && decision !== "deny") {
+    return { ok: false, available: true, reason: "capability_grants decision must be allow or deny" };
+  }
   try {
     db.prepare(
       `INSERT INTO ${TABLE} (capability, pattern, decision, scope, source, created_at)

package/engine/core/daemon-client.cjs

@@ -17,9 +17,12 @@
  */
 const net = require("node:net");
 const crypto = require("node:crypto");
+const fs = require("node:fs");
 const path = require("node:path");
 const { userDataDir } = require("./paths.cjs");
 
+const DAEMON_MAX_RESPONSE_BYTES = 16 * 1024 * 1024;
+
 /** 데몬 소켓 주소 — control-socket.ts 의 defaultControlSocketPath 와 같은 규칙. */
 function daemonSocketPath() {
   const dir = userDataDir();
@@ -41,11 +44,13 @@ function callDaemon(method, params, timeoutMs) {
   return new Promise((resolve, reject) => {
     const socket = net.connect(daemonSocketPath());
     const id = crypto.randomUUID();
-    let buffer = "";
+    let buffer = Buffer.alloc(0);
+    let responseBytes = 0;
     let settled = false;
     const finish = (fn) => {
       if (settled) return;
       settled = true;
+      buffer = Buffer.alloc(0);
       clearTimeout(timer);
       socket.destroy();
       fn();
@@ -56,10 +61,19 @@ function callDaemon(method, params, timeoutMs) {
     );
     socket.on("connect", () => socket.write(`${JSON.stringify({ id, method, params })}\n`));
     socket.on("data", (chunk) => {
-      buffer += chunk.toString("utf8");
+      if (settled) return;
+      const bytes = Buffer.isBuffer(chunk) ? chunk : Buffer.from(chunk);
+      responseBytes += bytes.length;
+      if (responseBytes > DAEMON_MAX_RESPONSE_BYTES) {
+        const error = new Error(`daemon response exceeded ${DAEMON_MAX_RESPONSE_BYTES} bytes`);
+        error.code = "DAEMON_RESPONSE_BODY_LIMIT";
+        finish(() => reject(error));
+        return;
+      }
+      buffer = buffer.length ? Buffer.concat([buffer, bytes]) : bytes;
       let nl;
-      while ((nl = buffer.indexOf("\n")) >= 0) {
-        const line = buffer.slice(0, nl).trim();
+      while (!settled && (nl = buffer.indexOf(0x0a)) >= 0) {
+        const line = buffer.subarray(0, nl).toString("utf8").trim();
         buffer = buffer.slice(nl + 1);
         if (!line) continue;
         let message;
@@ -109,8 +123,23 @@ function sharesOurStore(pong) {
     );
     return false;
   }
-  const path = require("node:path");
-  if (path.resolve(theirs) === path.resolve(ours)) return true;
+  let oursStat;
+  let theirsStat;
+  try {
+    oursStat = fs.statSync(path.resolve(ours));
+    theirsStat = fs.statSync(path.resolve(theirs));
+  } catch {
+    console.error(
+      `[daemon] could not verify the database identity (${theirs}) against this command (${ours}).\n`
+      + "[daemon] Running the graph locally instead, so the work cannot land in a different store.",
+    );
+    return false;
+  }
+  if (
+    oursStat.isFile() && theirsStat.isFile() &&
+    String(oursStat.dev) === String(theirsStat.dev) &&
+    String(oursStat.ino) === String(theirsStat.ino)
+  ) return true;
   console.error(
     `[daemon] the daemon opened a different database (${theirs}) than this command (${ours}).\n`
     + "[daemon] Running the graph locally instead, so the work cannot land in a different store.",
@@ -118,4 +147,4 @@ function sharesOurStore(pong) {
   return false;
 }
 
-module.exports = { daemonSocketPath, callDaemon, daemonAvailable, sharesOurStore };
+module.exports = { daemonSocketPath, callDaemon, daemonAvailable, sharesOurStore, DAEMON_MAX_RESPONSE_BYTES };

package/engine/core/db.cjs

@@ -14,6 +14,7 @@
  * 정직하게 거절한다(승급은 여전히 데스크탑의 일이다).
  */
 const fs = require("node:fs");
+const { pathToFileURL } = require("node:url");
 const { configureSqliteConnection } = require("../agentlas-sqlite-policy.cjs");
 const { parseSemVer, compareSemVer } = require("../semver.cjs");
 const { dbPath } = require("./paths.cjs");
@@ -38,13 +39,16 @@ function loadNodeSqliteQuietly() {
 function openRaw(file) {
   try {
     const Database = require("better-sqlite3");
-    const db = new Database(file);
+    const db = new Database(file, { fileMustExist: true });
     configureSqliteConnection(db);
     db.__driver = "better-sqlite3";
     return db;
   } catch { /* optional dep 미설치/ABI 불일치 → node:sqlite */ }
   const { DatabaseSync } = loadNodeSqliteQuietly();
-  const db = new DatabaseSync(file);
+  // DatabaseSync does not expose better-sqlite3's `fileMustExist` option. A
+  // SQLite URI with mode=rw opens an existing file read/write but refuses to
+  // create it when an existsSync check races with deletion.
+  const db = new DatabaseSync(`${pathToFileURL(file).href}?mode=rw`);
   configureSqliteConnection(db);
   db.__driver = "node:sqlite";
   return db;
@@ -125,9 +129,13 @@ function columnExists(db, table, col) {
 }
 
 function runWriteTransaction(db, fn) {
+  if (!db || typeof fn !== "function") throw new TypeError("SQLite connection and transaction callback are required");
   db.exec("BEGIN IMMEDIATE");
   try {
     const result = fn();
+    if (result && typeof result.then === "function") {
+      throw new TypeError("SQLite write transactions must be synchronous");
+    }
     db.exec("COMMIT");
     return result;
   } catch (e) {