agentic-workflow-manager 9.7.0 → 9.7.1

package/dist/tests/core/bundles.test.js

@@ -21,7 +21,7 @@ function makeFixture() {
     }));
     fs_1.default.writeFileSync(path_1.default.join(content, 'bundles', 'dev', 'bundle.json'), JSON.stringify({
         name: 'dev', version: '1.0.0', description: 'Dev core', scope: 'baseline', dependsOn: [],
-        skills: ['brainstorming', { name: 'architecture-advisor', onSignal: true }],
+        skills: ['brainstorming', 'architecture-advisor'],
         workflows: ['development-process'], agents: ['development-process'],
     }));
     fs_1.default.writeFileSync(path_1.default.join(content, 'bundles', 'frontend', 'bundle.json'), JSON.stringify({
@@ -47,17 +47,86 @@ describe('readCatalog', () => {
     });
 });
 describe('discoverBundles', () => {
-    it('loads each bundle and normalizes skill refs (string | object)', () => {
+    it('loads each bundle with canonical skill names', () => {
         const content = makeFixture();
         const bundles = (0, bundles_1.discoverBundles)(content);
         const dev = bundles.find((b) => b.name === 'dev');
-        expect(dev.skills).toEqual([
-            { name: 'brainstorming', onSignal: false },
-            { name: 'architecture-advisor', onSignal: true },
-        ]);
+        expect(dev.skills).toEqual(['brainstorming', 'architecture-advisor']);
         expect(dev.scope).toBe('baseline');
         expect(dev.dependsOn).toEqual([]);
     });
+    it('canonicalizes legacy skill objects and reports one bounded migration diagnostic per manifest', () => {
+        const content = makeFixture();
+        const manifest = path_1.default.join(content, 'bundles', 'dev', 'bundle.json');
+        fs_1.default.writeFileSync(manifest, JSON.stringify({
+            name: 'dev', version: '1.0.0', scope: 'baseline',
+            skills: [
+                { name: 'brainstorming', onSignal: true },
+                { name: 'architecture-advisor', onSignal: false },
+            ],
+        }));
+        const { inspectBundles } = require('../../src/core/bundles');
+        const result = inspectBundles(content);
+        expect(result.bundles[0].skills).toEqual(['brainstorming', 'architecture-advisor']);
+        expect(result.diagnostics).toHaveLength(1);
+        expect(result.diagnostics[0]).toContain('bundle.json');
+        expect(result.diagnostics[0]).toContain('skills: ["skill-name"]');
+        expect(result.diagnostics[0]).toMatch(/v10/i);
+        expect(result.diagnostics[0]).not.toMatch(/[\x00-\x1f\x7f-\x9f]/);
+        expect(result.diagnostics[0]).not.toContain('{"name"');
+        expect(result.diagnostics[0].length).toBeLessThanOrEqual(512);
+    });
+    it('forwards one deduplicated legacy diagnostic to an injected reporter', () => {
+        const content = makeFixture();
+        const manifest = path_1.default.join(content, 'bundles', 'dev', 'bundle.json');
+        fs_1.default.writeFileSync(manifest, JSON.stringify({
+            name: 'dev', version: '1.0.0', scope: 'baseline',
+            skills: [{ name: 'brainstorming', onSignal: true }, { name: 'architecture-advisor', onSignal: false }],
+        }));
+        const diagnostics = [];
+        const bundles = (0, bundles_1.discoverBundles)(content, (diagnostic) => diagnostics.push(diagnostic));
+        expect(bundles[0].skills).toEqual(['brainstorming', 'architecture-advisor']);
+        expect(diagnostics).toHaveLength(1);
+    });
+    it('creates a command-scoped warning reporter that suppresses repeated diagnostics', () => {
+        const warnings = [];
+        const report = (0, bundles_1.createBundleDiagnosticReporter)((warning) => warnings.push(warning));
+        report('legacy warning');
+        report('legacy warning');
+        expect(warnings).toEqual(['warning: legacy warning']);
+    });
+    it('sanitizes, bounds, and then deduplicates caller-provided diagnostics', () => {
+        const warnings = [];
+        const report = (0, bundles_1.createBundleDiagnosticReporter)((warning) => warnings.push(warning));
+        const payload = `legacy\x1b\n${'x'.repeat(600)}`;
+        report(payload);
+        report(`legacy ${'x'.repeat(600)}`);
+        expect(warnings).toHaveLength(1);
+        expect(warnings[0]).toMatch(/^warning: legacy /);
+        expect(warnings[0]).not.toMatch(/[\x00-\x1f\x7f-\x9f]/);
+        expect(warnings[0].length).toBeLessThanOrEqual('warning: '.length + 512);
+    });
+    it.each([
+        ['missing skills', undefined, /skills/],
+        ['a non-array skills value', 'brainstorming', /skills/],
+        ['an empty string skill', [''], /skills\[0\]/],
+        ['an array skill', [['brainstorming']], /skills\[0\]/],
+        ['a null skill', [null], /skills\[0\]/],
+        ['an object missing name', [{ onSignal: true }], /skills\[0\]/],
+        ['an object with an empty name', [{ name: '', onSignal: true }], /skills\[0\]/],
+        ['an object with a non-string name', [{ name: 1, onSignal: true }], /skills\[0\]/],
+        ['an object with a non-boolean onSignal', [{ name: 'brainstorming', onSignal: 'true' }], /skills\[0\]/],
+        ['an object with an unknown key', [{ name: 'brainstorming', extra: true }], /skills\[0\]/],
+    ])('rejects %s with a safe manifest identity', (_case, skills, location) => {
+        const content = makeFixture();
+        const manifest = path_1.default.join(content, 'bundles', 'dev', 'bundle.json');
+        const bundle = { name: 'dev', version: '1.0.0', scope: 'baseline' };
+        if (skills !== undefined)
+            bundle.skills = skills;
+        fs_1.default.writeFileSync(manifest, JSON.stringify(bundle));
+        expect(() => (0, bundles_1.discoverBundles)(content)).toThrow(/bundle\.json/);
+        expect(() => (0, bundles_1.discoverBundles)(content)).toThrow(location);
+    });
     it('returns [] when catalog is missing', () => {
         const empty = fs_1.default.mkdtempSync(path_1.default.join(os_1.default.tmpdir(), 'awm-empty-'));
         expect((0, bundles_1.discoverBundles)(empty)).toEqual([]);

package/dist/tests/core/diagnostics/context.test.js

@@ -9,7 +9,7 @@ const path_1 = __importDefault(require("path"));
 function bundle(name, scope, skills) {
     return {
         name, description: '', version: '1.0.0', scope, visibility: 'public',
-        dependsOn: [], skills: skills.map((s) => ({ name: s, onSignal: false })),
+        dependsOn: [], skills,
         workflows: [], agents: [],
     };
 }
@@ -86,7 +86,7 @@ describe('gatherContext', () => {
     it('machine: devCore surfaces a missing per-agent artifact even when the shared skill link is already present', () => {
         const bundleWithAgent = () => ({
             name: 'dev-core', description: '', version: '1.0.0', scope: 'baseline', visibility: 'public',
-            dependsOn: [], skills: [{ name: 'development-process', onSignal: false }],
+            dependsOn: [], skills: ['development-process'],
             workflows: [], agents: ['development-process'],
         });
         // Simulate OpenCode having already linked the shared ~/.agents/skills dir.

package/dist/tests/core/export/engine.test.js

@@ -21,7 +21,7 @@ function makeRoot() {
     }));
     fs_1.default.writeFileSync(path_1.default.join(root, 'bundles/dev/bundle.json'), JSON.stringify({
         name: 'dev', version: '1.0.0', scope: 'baseline', dependsOn: [],
-        skills: ['proc-skill', { name: 'mermaid', onSignal: true }, { name: 'ported', onSignal: true }],
+        skills: ['proc-skill', 'mermaid', 'ported'],
         workflows: [], agents: [],
     }));
     const mk = (name, fm) => {

package/dist/tests/core/export/resolve.test.js

@@ -17,7 +17,7 @@ function makeRoot() {
     }));
     fs_1.default.writeFileSync(path_1.default.join(root, 'bundles/dev/bundle.json'), JSON.stringify({
         name: 'dev', version: '1.0.0', scope: 'baseline', dependsOn: [],
-        skills: ['proc-skill', { name: 'mermaid', onSignal: true }, { name: 'ported', onSignal: true }],
+        skills: ['proc-skill', 'mermaid', 'ported'],
         workflows: [], agents: [],
     }));
     const mk = (name, fm) => {

package/dist/tests/core/init/mutation-targets.test.js

@@ -23,7 +23,7 @@ const tmp_1 = require("../../support/tmp");
 function bundle(name, scope, skills) {
     return {
         name, description: '', version: '1.0.0', scope, visibility: 'public',
-        dependsOn: [], skills: skills.map((s) => ({ name: s, onSignal: false })),
+        dependsOn: [], skills,
         workflows: [], agents: [],
     };
 }

package/dist/tests/core/init/orchestrator.test.js

@@ -31,7 +31,7 @@ function seedRegistry(contentRoot) {
     fs_1.default.mkdirSync(path_1.default.join(contentRoot, 'bundles', 'dev'), { recursive: true });
     fs_1.default.writeFileSync(path_1.default.join(contentRoot, 'bundles', 'dev', 'bundle.json'), JSON.stringify({
         name: 'dev', version: '1.0.0', scope: 'baseline', dependsOn: [],
-        skills: [{ name: 'brainstorming' }, { name: 'using-awm' }], workflows: [], agents: [],
+        skills: ['brainstorming', 'using-awm'], workflows: [], agents: [],
     }));
     // Seed .git in the content root so gatherMachine.registryCache.present is true.
     fs_1.default.mkdirSync(path_1.default.join(contentRoot, '.git'), { recursive: true });

package/dist/tests/core/init/steps.test.js

@@ -12,7 +12,7 @@ const context_1 = require("../../../src/core/diagnostics/context");
 function bundle(name, scope, skills) {
     return {
         name, description: '', version: '1.0.0', scope, visibility: 'public',
-        dependsOn: [], skills: skills.map((s) => ({ name: s, onSignal: false })),
+        dependsOn: [], skills,
         workflows: [], agents: [],
     };
 }

package/dist/tests/core/reconciliation.test.js

@@ -17,7 +17,7 @@ function writeBundle(contentRoot, name, scope, skills, dependsOn = []) {
     fs_1.default.mkdirSync(path_1.default.join(contentRoot, 'bundles', name), { recursive: true });
     fs_1.default.writeFileSync(path_1.default.join(contentRoot, 'bundles', name, 'bundle.json'), JSON.stringify({
         name, version: '1.0.0', scope, dependsOn,
-        skills: skills.map((s) => ({ name: s })), workflows: [], agents: [],
+        skills, workflows: [], agents: [],
     }));
     for (const skill of skills) {
         fs_1.default.mkdirSync(path_1.default.join(contentRoot, 'skills', skill), { recursive: true });

package/dist/tests/core/sync-profile-atomicity.test.js

@@ -27,7 +27,7 @@ const bundle_install_1 = require("../../src/core/bundle-install");
 function bundle(name, skills, contentRoot) {
     return {
         name, description: '', version: '1.0.0', scope: 'project', visibility: 'public',
-        dependsOn: [], skills: skills.map(n => ({ name: n })), workflows: [], agents: [],
+        dependsOn: [], skills, workflows: [], agents: [],
         source: `bundles/${name}`, contentRoot,
     };
 }

package/dist/tests/structural/bundle-skill-reference-contract.test.js

@@ -0,0 +1,56 @@
+"use strict";
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+const fs_1 = __importDefault(require("fs"));
+const path_1 = __importDefault(require("path"));
+const ROOT = path_1.default.resolve(__dirname, '../../..');
+const BUNDLES_SOURCE = path_1.default.join(ROOT, 'cli/src/core/bundles.ts');
+const GUIDE = path_1.default.join(ROOT, 'docs/guides/authoring-a-registry-with-an-orchestrator.md');
+const read = (file) => fs_1.default.readFileSync(file, 'utf8');
+function sourceFiles(dir) {
+    return fs_1.default.readdirSync(dir, { withFileTypes: true }).flatMap((entry) => {
+        const file = path_1.default.join(dir, entry.name);
+        if (entry.isDirectory())
+            return sourceFiles(file);
+        return entry.isFile() && file.endsWith('.ts') ? [file] : [];
+    });
+}
+function jsonFences(markdown) {
+    return Array.from(markdown.matchAll(/```json\n([\s\S]*?)\n```/g), ([, json]) => json);
+}
+describe('bundle skill-reference contract', () => {
+    it('keeps active bundle consumers string-only, without BundleSkillRef', () => {
+        const source = read(BUNDLES_SOURCE);
+        const bundleSkillRefs = sourceFiles(path_1.default.join(ROOT, 'cli/src'))
+            .filter((file) => /\bBundleSkillRef\b/.test(read(file)));
+        expect(bundleSkillRefs).toEqual([]);
+        expect(source).toMatch(/interface BundleDefinition\s*\{[\s\S]*?\bskills:\s*string\[\];/);
+    });
+    it('uses canonical string skill references in the active authoring guide', () => {
+        const guide = read(GUIDE);
+        const bundleExample = jsonFences(guide).find((json) => JSON.parse(json).name === 'mi-proceso');
+        expect(bundleExample).toBeDefined();
+        const skills = JSON.parse(bundleExample).skills;
+        expect(skills).toEqual(['mi-proceso']);
+        expect(skills.every((skill) => typeof skill === 'string')).toBe(true);
+    });
+    it('places the CLI 9 migration boundary immediately after the bundle example', () => {
+        const guide = read(GUIDE);
+        const bundleFence = '```json\n{\n  "name": "mi-proceso"';
+        const start = guide.indexOf(bundleFence);
+        const end = guide.indexOf('```', start) + 3;
+        const following = guide.slice(end, guide.indexOf('## 5.', end));
+        expect(start).toBeGreaterThanOrEqual(0);
+        expect(following).toMatch(/CLI 9[\s\S]*(?:legacy object|objeto legacy)[\s\S]*\{\s*name\s*,\s*onSignal:\s*true\s*\}/i);
+        expect(following).toMatch(/ignor(?:e|a)[\s\S]*boolean[\s\S]*onSignal/i);
+        expect(following).toMatch(/warning/i);
+        expect(following).toMatch(/CLI 10[\s\S]*(?:rejects?|rechaza)[\s\S]*(?:objects?|objetos?)/i);
+    });
+    it('keeps every JSON fence in the touched guide parseable', () => {
+        for (const json of jsonFences(read(GUIDE))) {
+            expect(() => JSON.parse(json)).not.toThrow();
+        }
+    });
+});

package/dist/tests/utils/grouping.test.js

@@ -7,10 +7,10 @@ const bundle = (over) => ({
 });
 const processes = [
     bundle({ name: 'core-dev', description: 'Core development skills',
-        skills: [{ name: 'brainstorming', onSignal: false }, { name: 'shared-skill', onSignal: false }],
+        skills: ['brainstorming', 'shared-skill'],
         workflows: [], agents: [] }),
     bundle({ name: 'docs', description: 'Documentation skills',
-        skills: [{ name: 'docs-assistant', onSignal: false }, { name: 'shared-skill', onSignal: false }],
+        skills: ['docs-assistant', 'shared-skill'],
         workflows: [], agents: [] }),
 ];
 const formatLabel = (c) => c.baseName;

package/dist/tests/utils/registry-view.test.js

@@ -10,10 +10,10 @@ const bundle = (over) => ({
 });
 const processes = [
     bundle({ name: 'core-dev', description: 'Dev lifecycle', scope: 'baseline',
-        skills: [{ name: 'brainstorming', onSignal: false }, { name: 'shared', onSignal: false }],
+        skills: ['brainstorming', 'shared'],
         workflows: ['exec'], agents: ['plan'] }),
     bundle({ name: 'docs', description: 'Docs as code',
-        skills: [{ name: 'shared', onSignal: false }] }),
+        skills: ['shared'] }),
 ];
 describe('buildPackageView', () => {
     it('groups artifacts under their package with correct counts and install names', () => {
@@ -108,7 +108,7 @@ describe('visibility', () => {
     it('marks a private bundle on its PackageView', () => {
         const priv = [
             bundle({ name: 'secret', description: 'private', visibility: 'private',
-                skills: [{ name: 'a', onSignal: false }] }),
+                skills: ['a'] }),
         ];
         const view = (0, registry_view_1.buildPackageView)([skill('a')], [], [], priv);
         expect(view.find((p) => p.name === 'secret').visibility).toBe('private');
@@ -121,7 +121,7 @@ describe('visibility', () => {
 describe('packageSummaryLines width-awareness', () => {
     it('truncates the description column when a width is given', () => {
         const view = (0, registry_view_1.buildPackageView)([skill('brainstorming', 'x'.repeat(200))], [], [], [
-            bundle({ name: 'core-dev', description: 'x'.repeat(200), skills: [{ name: 'brainstorming', onSignal: false }] }),
+            bundle({ name: 'core-dev', description: 'x'.repeat(200), skills: ['brainstorming'] }),
         ]);
         const lines = (0, registry_view_1.packageSummaryLines)(view, 60);
         for (const l of lines)
@@ -130,7 +130,7 @@ describe('packageSummaryLines width-awareness', () => {
     });
     it('does not truncate when no width is given (piped output)', () => {
         const view = (0, registry_view_1.buildPackageView)([skill('brainstorming', 'y'.repeat(200))], [], [], [
-            bundle({ name: 'core-dev', description: 'z'.repeat(200), skills: [{ name: 'brainstorming', onSignal: false }] }),
+            bundle({ name: 'core-dev', description: 'z'.repeat(200), skills: ['brainstorming'] }),
         ]);
         const lines = (0, registry_view_1.packageSummaryLines)(view); // no width
         expect(lines.some((l) => l.includes('z'.repeat(200)))).toBe(true);
@@ -139,7 +139,7 @@ describe('packageSummaryLines width-awareness', () => {
 describe('artifactPickerItems', () => {
     it('prepends an "install entire package" sentinel item, then one per artifact', () => {
         const view = (0, registry_view_1.buildPackageView)([skill('a', 'desc a'), skill('b', 'desc b')], [], [], [
-            bundle({ name: 'p', description: 'pkg', skills: [{ name: 'a', onSignal: false }, { name: 'b', onSignal: false }] }),
+            bundle({ name: 'p', description: 'pkg', skills: ['a', 'b'] }),
         ]);
         const items = (0, registry_view_1.artifactPickerItems)(view.find((p) => p.name === 'p'));
         expect(items[0].value).toBe(registry_view_1.ALL_SENTINEL);
@@ -150,7 +150,7 @@ describe('artifactPickerItems', () => {
 describe('packagePickerItems', () => {
     it('builds one item per package with a count+description summary', () => {
         const view = (0, registry_view_1.buildPackageView)([skill('a')], [], [], [
-            bundle({ name: 'p', description: 'pkg desc', skills: [{ name: 'a', onSignal: false }] }),
+            bundle({ name: 'p', description: 'pkg desc', skills: ['a'] }),
         ]);
         const items = (0, registry_view_1.packagePickerItems)(view);
         expect(items[0].value).toBe('p');

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agentic-workflow-manager",
-  "version": "9.7.0",
+  "version": "9.7.1",
   "main": "dist/src/index.js",
   "bin": {
     "awm": "./dist/src/index.js"