agentic-workflow-manager 9.6.1 → 9.7.1

package/dist/tests/core/tracks/protocol.test.js

@@ -34,6 +34,109 @@ describe('parallel-track protocol model', () => {
         expect(() => (0, protocol_1.observeProtocolEffect)(s, { kind: 'enter-serial', reason: 'x' }, { kind: 'effect-applied', effect: { kind: 'enter-serial', reason: 'x' } }))
             .toThrow(/SERIAL prohíbe recursos paralelos activos/);
     });
+    test.each([
+        {
+            name: 'observación de ownership ajeno',
+            observation: { kind: 'teardown-observation', trackId: 'cli', foreignWorktree: true },
+        },
+        {
+            name: 'fallo de begin-teardown',
+            observation: {
+                kind: 'effect-failed', trackId: 'cli', effect: 'begin-teardown', detail: 'ownership indemostrable',
+            },
+        },
+    ])('teardown indemostrable bloquea track y cohorte: $name (TR-REQ-05)', ({ observation }) => {
+        const s = (0, protocol_1.initialCohort)('journal-1', ids);
+        s.cohortPhase = 'FALLBACK_PENDING';
+        s.fallbackReason = 'controller-requested:cli';
+        s.tracks.cli.phase = 'TEARDOWN_REQUESTED';
+        s.tracks.docs.phase = 'REMOVED';
+        const out = (0, protocol_1.reconcileProtocol)(s, observation);
+        expect(out.tracks.cli.phase).toBe('BLOCKED');
+        expect(out.cohortPhase).toBe('BLOCKED');
+        expect((0, protocol_1.nextProtocolEffect)(out)).toBeNull();
+    });
+    test('fallo de begin-teardown para track inexistente falla cerrado (TR-REQ-05)', () => {
+        const s = (0, protocol_1.initialCohort)('journal-1', ids);
+        s.cohortPhase = 'FALLBACK_PENDING';
+        expect(() => (0, protocol_1.reconcileProtocol)(s, {
+            kind: 'effect-failed', trackId: 'missing', effect: 'begin-teardown', detail: 'ownership indemostrable',
+        })).toThrow('track desconocido: missing');
+    });
+    test('remove cancela toda la cohorte activa y conserva DECLARED/BLOCKED (TR-REQ-03, TR-REQ-05)', () => {
+        const s = (0, protocol_1.initialCohort)('journal-1', ['active', 'declared', 'blocked']);
+        s.cohortPhase = 'ACTIVE';
+        s.tracks.active.phase = 'ACTIVE';
+        s.tracks.declared.phase = 'DECLARED';
+        s.tracks.blocked.phase = 'BLOCKED';
+        const out = (0, protocol_1.reconcileProtocol)(s, { kind: 'teardown-requested', trackId: 'active' });
+        expect(out.cohortPhase).toBe('FALLBACK_PENDING');
+        expect(out.fallbackReason).toBe('controller-requested:active');
+        expect(out.tracks.active.phase).toBe('TEARDOWN_REQUESTED');
+        expect(out.tracks.declared.phase).toBe('DECLARED');
+        expect(out.tracks.blocked.phase).toBe('BLOCKED');
+        expect((0, protocol_1.nextProtocolEffect)(out)).toBeNull();
+    });
+    test('remove durante FINAL_INTERLOCK invalida evidencia final antes de pedir teardown (issue #93)', () => {
+        const s = (0, protocol_1.initialCohort)('journal-1', ids);
+        s.cohortPhase = 'FINAL_INTERLOCK';
+        s.globalQaHeadSha = 'qa-head';
+        s.finalIntegrationJobId = 'integration-job';
+        for (const track of Object.values(s.tracks)) {
+            track.phase = 'MERGED_UNVERIFIED';
+            track.frozenHeadSha = `${track.trackId}-head`;
+        }
+        const out = (0, protocol_1.reconcileProtocol)(s, { kind: 'teardown-requested', trackId: 'cli' });
+        expect(out.cohortPhase).toBe('FALLBACK_PENDING');
+        expect(out.globalQaHeadSha).toBeUndefined();
+        expect(out.finalIntegrationJobId).toBeUndefined();
+        expect(Object.values(out.tracks).every((track) => track.phase === 'TEARDOWN_REQUESTED')).toBe(true);
+    });
+    test('remove repetido no rebobina teardown ni reemplaza la causa (TR-REQ-08)', () => {
+        const s = (0, protocol_1.initialCohort)('journal-1', ids);
+        s.cohortPhase = 'FALLBACK_PENDING';
+        s.fallbackReason = 'controller-requested:cli';
+        s.tracks.cli.phase = 'SUPERVISOR_STOPPED';
+        s.tracks.docs.phase = 'TEARDOWN_REQUESTED';
+        const out = (0, protocol_1.reconcileProtocol)(s, { kind: 'teardown-requested', trackId: 'docs' });
+        expect(out.fallbackReason).toBe('controller-requested:cli');
+        expect(out.tracks.cli.phase).toBe('SUPERVISOR_STOPPED');
+        expect(out.tracks.docs.phase).toBe('TEARDOWN_REQUESTED');
+    });
+    test.each(['SERIAL', 'COMPLETE'])('remove es no-op protocolar en cohorte terminal %s (TR-REQ-09)', (cohortPhase) => {
+        const s = (0, protocol_1.initialCohort)('journal-1', ids);
+        s.cohortPhase = cohortPhase;
+        for (const track of Object.values(s.tracks)) {
+            track.phase = cohortPhase === 'SERIAL' ? 'REMOVED' : 'JOINED';
+            if (cohortPhase === 'COMPLETE')
+                track.frozenHeadSha = `${track.trackId}-head`;
+        }
+        expect((0, protocol_1.reconcileProtocol)(s, { kind: 'teardown-requested', trackId: 'cli' })).toEqual(s);
+    });
+    test('remove es no-op protocolar en cohorte BLOCKED y no reanuda teardown (TR-REQ-10)', () => {
+        const s = (0, protocol_1.initialCohort)('journal-1', ids);
+        s.cohortPhase = 'BLOCKED';
+        s.tracks.cli.phase = 'BLOCKED';
+        s.tracks.cli.blockedReason = 'ownership indemostrable';
+        s.tracks.docs.phase = 'REMOVED';
+        const out = (0, protocol_1.reconcileProtocol)(s, { kind: 'teardown-requested', trackId: 'docs' });
+        expect(out).toEqual(s);
+        expect(out.cohortPhase).toBe('BLOCKED');
+        expect((0, protocol_1.nextProtocolEffect)(out)).toBeNull();
+    });
+    test('remove converge a serial solo después de desmontar la cohorte (TR-REQ-06)', () => {
+        let s = (0, protocol_1.initialCohort)('journal-1', ids);
+        for (const track of Object.values(s.tracks))
+            track.phase = 'ACTIVE';
+        s.cohortPhase = 'ACTIVE';
+        s = (0, protocol_1.reconcileProtocol)(s, { kind: 'teardown-requested', trackId: 'cli' });
+        expect((0, protocol_1.nextProtocolEffect)(s)).toEqual({ kind: 'begin-teardown', trackId: 'cli' });
+        s.tracks.cli.phase = 'REMOVED';
+        s.tracks.docs.phase = 'REMOVED';
+        expect((0, protocol_1.nextProtocolEffect)(s)).toEqual({
+            kind: 'enter-serial', reason: 'controller-requested:cli',
+        });
+    });
     test('ningún merge empieza antes de que todos los tracks estén FROZEN (C3)', () => {
         const s = (0, protocol_1.initialCohort)('journal-1', ids);
         s.cohortPhase = 'JOINING';

package/dist/tests/structural/bundle-skill-reference-contract.test.js

@@ -0,0 +1,56 @@
+"use strict";
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+const fs_1 = __importDefault(require("fs"));
+const path_1 = __importDefault(require("path"));
+const ROOT = path_1.default.resolve(__dirname, '../../..');
+const BUNDLES_SOURCE = path_1.default.join(ROOT, 'cli/src/core/bundles.ts');
+const GUIDE = path_1.default.join(ROOT, 'docs/guides/authoring-a-registry-with-an-orchestrator.md');
+const read = (file) => fs_1.default.readFileSync(file, 'utf8');
+function sourceFiles(dir) {
+    return fs_1.default.readdirSync(dir, { withFileTypes: true }).flatMap((entry) => {
+        const file = path_1.default.join(dir, entry.name);
+        if (entry.isDirectory())
+            return sourceFiles(file);
+        return entry.isFile() && file.endsWith('.ts') ? [file] : [];
+    });
+}
+function jsonFences(markdown) {
+    return Array.from(markdown.matchAll(/```json\n([\s\S]*?)\n```/g), ([, json]) => json);
+}
+describe('bundle skill-reference contract', () => {
+    it('keeps active bundle consumers string-only, without BundleSkillRef', () => {
+        const source = read(BUNDLES_SOURCE);
+        const bundleSkillRefs = sourceFiles(path_1.default.join(ROOT, 'cli/src'))
+            .filter((file) => /\bBundleSkillRef\b/.test(read(file)));
+        expect(bundleSkillRefs).toEqual([]);
+        expect(source).toMatch(/interface BundleDefinition\s*\{[\s\S]*?\bskills:\s*string\[\];/);
+    });
+    it('uses canonical string skill references in the active authoring guide', () => {
+        const guide = read(GUIDE);
+        const bundleExample = jsonFences(guide).find((json) => JSON.parse(json).name === 'mi-proceso');
+        expect(bundleExample).toBeDefined();
+        const skills = JSON.parse(bundleExample).skills;
+        expect(skills).toEqual(['mi-proceso']);
+        expect(skills.every((skill) => typeof skill === 'string')).toBe(true);
+    });
+    it('places the CLI 9 migration boundary immediately after the bundle example', () => {
+        const guide = read(GUIDE);
+        const bundleFence = '```json\n{\n  "name": "mi-proceso"';
+        const start = guide.indexOf(bundleFence);
+        const end = guide.indexOf('```', start) + 3;
+        const following = guide.slice(end, guide.indexOf('## 5.', end));
+        expect(start).toBeGreaterThanOrEqual(0);
+        expect(following).toMatch(/CLI 9[\s\S]*(?:legacy object|objeto legacy)[\s\S]*\{\s*name\s*,\s*onSignal:\s*true\s*\}/i);
+        expect(following).toMatch(/ignor(?:e|a)[\s\S]*boolean[\s\S]*onSignal/i);
+        expect(following).toMatch(/warning/i);
+        expect(following).toMatch(/CLI 10[\s\S]*(?:rejects?|rechaza)[\s\S]*(?:objects?|objetos?)/i);
+    });
+    it('keeps every JSON fence in the touched guide parseable', () => {
+        for (const json of jsonFences(read(GUIDE))) {
+            expect(() => JSON.parse(json)).not.toThrow();
+        }
+    });
+});

package/dist/tests/utils/grouping.test.js

@@ -7,10 +7,10 @@ const bundle = (over) => ({
 });
 const processes = [
     bundle({ name: 'core-dev', description: 'Core development skills',
-        skills: [{ name: 'brainstorming', onSignal: false }, { name: 'shared-skill', onSignal: false }],
+        skills: ['brainstorming', 'shared-skill'],
         workflows: [], agents: [] }),
     bundle({ name: 'docs', description: 'Documentation skills',
-        skills: [{ name: 'docs-assistant', onSignal: false }, { name: 'shared-skill', onSignal: false }],
+        skills: ['docs-assistant', 'shared-skill'],
         workflows: [], agents: [] }),
 ];
 const formatLabel = (c) => c.baseName;

package/dist/tests/utils/registry-view.test.js

@@ -10,10 +10,10 @@ const bundle = (over) => ({
 });
 const processes = [
     bundle({ name: 'core-dev', description: 'Dev lifecycle', scope: 'baseline',
-        skills: [{ name: 'brainstorming', onSignal: false }, { name: 'shared', onSignal: false }],
+        skills: ['brainstorming', 'shared'],
         workflows: ['exec'], agents: ['plan'] }),
     bundle({ name: 'docs', description: 'Docs as code',
-        skills: [{ name: 'shared', onSignal: false }] }),
+        skills: ['shared'] }),
 ];
 describe('buildPackageView', () => {
     it('groups artifacts under their package with correct counts and install names', () => {
@@ -108,7 +108,7 @@ describe('visibility', () => {
     it('marks a private bundle on its PackageView', () => {
         const priv = [
             bundle({ name: 'secret', description: 'private', visibility: 'private',
-                skills: [{ name: 'a', onSignal: false }] }),
+                skills: ['a'] }),
         ];
         const view = (0, registry_view_1.buildPackageView)([skill('a')], [], [], priv);
         expect(view.find((p) => p.name === 'secret').visibility).toBe('private');
@@ -121,7 +121,7 @@ describe('visibility', () => {
 describe('packageSummaryLines width-awareness', () => {
     it('truncates the description column when a width is given', () => {
         const view = (0, registry_view_1.buildPackageView)([skill('brainstorming', 'x'.repeat(200))], [], [], [
-            bundle({ name: 'core-dev', description: 'x'.repeat(200), skills: [{ name: 'brainstorming', onSignal: false }] }),
+            bundle({ name: 'core-dev', description: 'x'.repeat(200), skills: ['brainstorming'] }),
         ]);
         const lines = (0, registry_view_1.packageSummaryLines)(view, 60);
         for (const l of lines)
@@ -130,7 +130,7 @@ describe('packageSummaryLines width-awareness', () => {
     });
     it('does not truncate when no width is given (piped output)', () => {
         const view = (0, registry_view_1.buildPackageView)([skill('brainstorming', 'y'.repeat(200))], [], [], [
-            bundle({ name: 'core-dev', description: 'z'.repeat(200), skills: [{ name: 'brainstorming', onSignal: false }] }),
+            bundle({ name: 'core-dev', description: 'z'.repeat(200), skills: ['brainstorming'] }),
         ]);
         const lines = (0, registry_view_1.packageSummaryLines)(view); // no width
         expect(lines.some((l) => l.includes('z'.repeat(200)))).toBe(true);
@@ -139,7 +139,7 @@ describe('packageSummaryLines width-awareness', () => {
 describe('artifactPickerItems', () => {
     it('prepends an "install entire package" sentinel item, then one per artifact', () => {
         const view = (0, registry_view_1.buildPackageView)([skill('a', 'desc a'), skill('b', 'desc b')], [], [], [
-            bundle({ name: 'p', description: 'pkg', skills: [{ name: 'a', onSignal: false }, { name: 'b', onSignal: false }] }),
+            bundle({ name: 'p', description: 'pkg', skills: ['a', 'b'] }),
         ]);
         const items = (0, registry_view_1.artifactPickerItems)(view.find((p) => p.name === 'p'));
         expect(items[0].value).toBe(registry_view_1.ALL_SENTINEL);
@@ -150,7 +150,7 @@ describe('artifactPickerItems', () => {
 describe('packagePickerItems', () => {
     it('builds one item per package with a count+description summary', () => {
         const view = (0, registry_view_1.buildPackageView)([skill('a')], [], [], [
-            bundle({ name: 'p', description: 'pkg desc', skills: [{ name: 'a', onSignal: false }] }),
+            bundle({ name: 'p', description: 'pkg desc', skills: ['a'] }),
         ]);
         const items = (0, registry_view_1.packagePickerItems)(view);
         expect(items[0].value).toBe('p');

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agentic-workflow-manager",
-  "version": "9.6.1",
+  "version": "9.7.1",
   "main": "dist/src/index.js",
   "bin": {
     "awm": "./dist/src/index.js"