agentic-workflow-manager 4.1.1 → 5.0.0

package/dist/src/commands/init.js

@@ -270,8 +270,20 @@ async function runInit(opts = {}) {
             json: opts.json,
         });
     }
-    // `result` mirrors the exit code, so a consumer can branch on one field
-    // instead of correlating stdout with $?: ok → 0, degraded → 1, failed → 2.
+    // `result` distinguishes `ok` from `degraded` in the JSON; the EXIT CODE does
+    // not, on purpose (D-008).
+    //
+    // `degraded` used to exit `1`. It does not mean init failed — it means the
+    // harness still has `pending` steps, which is the NORMAL outcome of a first run:
+    // `CONSTITUTION.md` and `AGENTS.md` are written by an agent session, not by the
+    // CLI. So a run where nothing broke reported failure, and `awm init --yes && …`
+    // died under `set -e` — in the one command whose entire job is bootstrapping a
+    // script. Three independent readers called it a bug before it was one; the docs
+    // had grown a warning box asking people to ignore the exit code.
+    //
+    // The exit code now answers "did init do its job?". "Is the harness fully
+    // healthy?" is `awm doctor`'s question, and `result` still carries it here for
+    // any consumer that wants to branch on it.
     const result = outcome.after.overall === 'healthy' ? 'ok' : 'degraded';
     if (opts.json) {
         process.stdout.write(JSON.stringify({ result, ...outcome }, null, 2) + '\n');
@@ -279,7 +291,7 @@ async function runInit(opts = {}) {
     else {
         process.stdout.write(renderInitOutcome(outcome) + '\n');
     }
-    return result === 'ok' ? 0 : 1;
+    return 0;
 }
 // ---------------------------------------------------------------------------
 // Extension confirmation factory

package/dist/tests/commands/init.test.js

@@ -109,14 +109,17 @@ describe('runInit', () => {
             expect(caveatCalls).toHaveLength(0);
         });
     });
-    it('returns exit 1 on a bare HOME and never prompts with --yes (cache stubbed)', async () => {
+    it('returns exit 0 on a bare HOME and never prompts with --yes (cache stubbed)', async () => {
         const { runInit } = require('../../src/commands/init');
         const code = await runInit({
             cwd: tmpHome,
             yes: true,
             actions: { syncCache: async () => { }, installHook: () => ({ status: 'installed' }) },
         });
-        expect(code).toBe(1); // cache/hook/devCore siguen ausentes (syncCache no-op) → degradado
+        // Degradado (cache/hook/devCore siguen ausentes con syncCache no-op) pero NADA
+        // fallo, y el exit code de `init` responde por init, no por la salud del
+        // harness — ver D-008. Esto salia 1 y rompia `awm init --yes && …` bajo `set -e`.
+        expect(code).toBe(0);
     });
     it('--json emits a parseable InitOutcome', async () => {
         const { runInit } = require('../../src/commands/init');
@@ -131,7 +134,10 @@ describe('runInit', () => {
         expect(Array.isArray(parsed.steps)).toBe(true);
         expect(parsed.after.overall).toBe('degraded');
         expect(parsed.result).toBe('degraded'); // success envelope is self-describing too
-        expect(code).toBe(1);
+        // El exit code deja de duplicar `result`: la distincion ok/degradado sigue
+        // disponible para quien la quiera, en el campo, no en `$?` (D-008).
+        expect(parsed.failed).toBe(0);
+        expect(code).toBe(0);
     });
     const prefsFile = () => path_1.default.join(process.env.AWM_HOME, 'preferences.json');
     const readPreferences = () => JSON.parse(fs_1.default.readFileSync(prefsFile(), 'utf-8'));
@@ -239,6 +245,40 @@ describe('runInit', () => {
             .toEqual(['claude-code', 'codex', 'opencode']);
     });
     // -----------------------------------------------------------------------
+    // D-008 — el exit code de `init` responde por init, no por la salud del harness
+    // -----------------------------------------------------------------------
+    //
+    // El contrato entero en un solo lugar, porque el sitio que lo rompia era el
+    // ausente: ningun test preguntaba "¿un script puede encadenar `awm init &&`?".
+    // Habia dos assertions de `toBe(1)`, y las dos *documentaban* el bug en vez de
+    // detenerlo. Tres lectores independientes lo reportaron como fallo antes de que
+    // lo fuera, y la doc habia crecido un recuadro pidiendo ignorar el exit code.
+    it('a degraded-but-successful run exits 0, so `awm init && next` survives set -e', async () => {
+        const { runInit } = require('../../src/commands/init');
+        const code = await runInit({
+            cwd: tmpHome,
+            yes: true,
+            json: true,
+            actions: { syncCache: async () => { }, installHook: () => ({ status: 'installed' }) },
+        });
+        const parsed = JSON.parse(writeSpy.mock.calls.map((c) => c[0]).join(''));
+        // Las tres afirmaciones juntas son el punto: degradado, sin nada fallado, exit 0.
+        // Cualquiera de las tres sola se puede satisfacer sin el fix.
+        expect(parsed.result).toBe('degraded');
+        expect(parsed.failed).toBe(0);
+        expect(code).toBe(0);
+    });
+    it('still refuses with exit 2 when a gate rejects — 0 does not mean "always succeed"', async () => {
+        const { runInit } = require('../../src/commands/init');
+        const code = await runInit({
+            cwd: tmpHome,
+            agent: 'codex',
+            yes: true,
+            assertProviderSupported: () => { throw new Error('requires Codex >= 0.145.0'); },
+        });
+        expect(code).toBe(2);
+    });
+    // -----------------------------------------------------------------------
     // Step 1 — gate ordering, backup/rollback atomicity, Codex/Claude coexistence
     // -----------------------------------------------------------------------
     it('gates Codex before preferences or provider writes', async () => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agentic-workflow-manager",
-  "version": "4.1.1",
+  "version": "5.0.0",
   "main": "dist/src/index.js",
   "bin": {
     "awm": "./dist/src/index.js"