agentic-workflow-manager 3.13.3 → 3.13.5

package/dist/tests/core/renderers/skill-source-block-scalar.test.js

@@ -0,0 +1,117 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+// Regresion: `description: >-` (YAML block scalar) rompia `awm add <bundle>
+// -a copilot|cursor` contra un skill REAL del registry baseline
+// (skills/extract-design-md/SKILL.md, que usa exactamente esta forma).
+//
+// Un block scalar es YAML perfectamente valido: el indicador (`>-`, `|`, ...)
+// va en la linea de la clave y el texto real vive en las lineas indentadas
+// que siguen. El parser trataba el indicador como si fuera el valor, lo
+// detectaba como "no es una descripcion de verdad", y lo colapsaba a ''  —
+// que en `parseSkillSource` significa throw ("requires a non-empty
+// description") y en `readArtifactDescription` significa degradar en
+// silencio a descripcion vacia. Ninguno de los dos leia jamas las lineas
+// siguientes, que es donde estaba el texto todo el tiempo.
+const skill_source_1 = require("../../../src/core/renderers/skill-source");
+const cursor_mdc_1 = require("../../../src/core/renderers/cursor-mdc");
+const copilot_instructions_1 = require("../../../src/core/renderers/copilot-instructions");
+// Copia fiel del frontmatter de skills/extract-design-md/SKILL.md en
+// awm-baseline-registry — el caso real que dispara el bug, no un fixture
+// inventado.
+const realBlockScalarSkill = `---
+name: extract-design-md
+version: "1.0.1"
+description: >-
+  Extract a comprehensive design system (DESIGN.md) directly from frontend source
+  code — React, Vue, Svelte, Angular, plain HTML/CSS, or any web framework.
+---
+
+# Extract Design MD
+
+Body content.
+`;
+describe('parseSkillSource: descripciones en block scalar (regresion real del registry)', () => {
+    it('lee el texto de las lineas indentadas de un `>-`, en vez de tratar el indicador como el valor', () => {
+        const { description } = (0, skill_source_1.parseSkillSource)(realBlockScalarSkill);
+        expect(description).toBe('Extract a comprehensive design system (DESIGN.md) directly from frontend source ' +
+            'code — React, Vue, Svelte, Angular, plain HTML/CSS, or any web framework.');
+    });
+    it('pliega (folded, `>`) las lineas en espacios — no conserva los saltos de linea del fuente', () => {
+        const source = `---
+name: folded
+description: >
+  primera linea
+  segunda linea
+---
+
+Body.
+`;
+        expect((0, skill_source_1.parseSkillSource)(source).description).toBe('primera linea segunda linea');
+    });
+    it('conserva los saltos de linea de un literal (`|`) — semantica YAML distinta de `>`', () => {
+        const source = `---
+name: literal
+description: |
+  primera linea
+  segunda linea
+---
+
+Body.
+`;
+        expect((0, skill_source_1.parseSkillSource)(source).description).toBe('primera linea\nsegunda linea');
+    });
+    it('trata una linea en blanco dentro de un folded como separador de parrafo, no como espacio', () => {
+        const source = `---
+name: folded-parrafos
+description: >-
+  parrafo uno
+
+  parrafo dos
+---
+
+Body.
+`;
+        expect((0, skill_source_1.parseSkillSource)(source).description).toBe('parrafo uno\nparrafo dos');
+    });
+    it('no absorbe las claves siguientes del frontmatter como parte del bloque (corta en la primera linea no indentada)', () => {
+        const source = `---
+description: >-
+  solo esto pertenece al bloque
+name: no-soy-parte-del-bloque
+version: "9.9.9"
+---
+
+Body.
+`;
+        expect((0, skill_source_1.parseSkillSource)(source).description).toBe('solo esto pertenece al bloque');
+    });
+    it('resuelve el bloque igual con line endings CRLF (el repo es CRLF-tolerante y corre CI en windows-latest)', () => {
+        const source = '---\r\nname: crlf\r\ndescription: >-\r\n  linea uno\r\n  linea dos\r\n---\r\n\r\nBody aqui.\r\n';
+        expect((0, skill_source_1.parseSkillSource)(source).description).toBe('linea uno linea dos');
+    });
+    it('sigue lanzando si el bloque esta genuinamente vacio — un indicador sin lineas indentadas NO es una descripcion', () => {
+        const source = `---
+name: bloque-vacio
+description: >-
+name: otra-clave
+---
+
+Body.
+`;
+        expect(() => (0, skill_source_1.parseSkillSource)(source)).toThrow(/non-empty description/);
+    });
+});
+describe('renderers: el skill real del registry se renderiza para ambos providers', () => {
+    it('renderCursorMdc emite la descripcion real, nunca el indicador `>-` literal', () => {
+        const rendered = (0, cursor_mdc_1.renderCursorMdc)(realBlockScalarSkill);
+        expect(rendered).toContain('Extract a comprehensive design system');
+        // El modo de fallo que este test ancla: emitir el indicador crudo.
+        expect(rendered).not.toContain('description: >-');
+        expect(rendered).not.toContain('description: ""');
+    });
+    it('renderCopilotInstructions no crashea (no necesita la descripcion, pero parseSkillSource la exigia igual)', () => {
+        const rendered = (0, copilot_instructions_1.renderCopilotInstructions)(realBlockScalarSkill);
+        expect(rendered).toContain('applyTo: "**"');
+        expect(rendered).toContain('# Extract Design MD');
+    });
+});

package/dist/tests/core/sync-gates.test.js

@@ -14,6 +14,31 @@ const path_1 = __importDefault(require("path"));
 const os_1 = __importDefault(require("os"));
 const child_process_1 = require("child_process");
 const GIT = (cwd, cmd) => (0, child_process_1.execSync)(`git -c user.email=t@t.t -c user.name=t -c tag.gpgSign=false ${cmd}`, { cwd, stdio: 'pipe' });
+// Real `git init`/clone-adjacent work per test, several times over — on
+// windows-latest CI this is measurably slower than on POSIX and the jest
+// default of 5000ms proved too tight in real CI (regression: real
+// windows-latest run, "Exceeded timeout of 5000 ms"). Same class of issue
+// already fixed in registries-sync.test.ts earlier this session — this
+// sibling file has the identical real-git-fixture pattern and was missed.
+jest.setTimeout(30000);
+/** git en win32 puede mantener un handle abierto sobre `.git/hooks`/`.git/objects`
+ *  por un instante despues de que el proceso `git` retorna — rmSync inmediato
+ *  entonces produce EBUSY/ENOTEMPTY (regresion: real windows-latest CI). Mismo
+ *  patron ya aplicado en registries-sync.test.ts y runner.test.ts. */
+async function rmSyncRetryingBusy(target, attempts = 10, delayMs = 100) {
+    for (let i = 0; i < attempts; i++) {
+        try {
+            fs_1.default.rmSync(target, { recursive: true, force: true });
+            return;
+        }
+        catch (error) {
+            const code = error.code;
+            if ((code !== 'EBUSY' && code !== 'ENOTEMPTY') || i === attempts - 1)
+                throw error;
+            await new Promise((resolve) => setTimeout(resolve, delayMs));
+        }
+    }
+}
 function makeRegistryWithManifest(base, name, manifest) {
     const dir = path_1.default.join(base, name);
     fs_1.default.mkdirSync(dir, { recursive: true });
@@ -37,9 +62,9 @@ describe('verifyMinCliVersions (gate de awm sync / awm update)', () => {
         process.env.AWM_HOME = path_1.default.join(tmpHome, '.awm');
         jest.resetModules();
     });
-    afterEach(() => {
-        fs_1.default.rmSync(tmpHome, { recursive: true, force: true });
-        fs_1.default.rmSync(tmpWork, { recursive: true, force: true });
+    afterEach(async () => {
+        await rmSyncRetryingBusy(tmpHome);
+        await rmSyncRetryingBusy(tmpWork);
         if (originalHome === undefined)
             delete process.env.HOME;
         else

package/dist/tests/integration/copilot-init-isolated.test.js

@@ -0,0 +1,203 @@
+"use strict";
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+// cli/tests/integration/copilot-init-isolated.test.ts
+//
+// Regression E2E for a confirmed, 100%-reproducible production bug:
+// `awm init --agent copilot` crashed deterministically with
+// "machine.devCore: skill global scope is not supported by Copilot..." and
+// rolled back the ENTIRE init transaction (even project-local artifacts like
+// AGENTS.md).
+//
+// Root cause: Copilot has no global skill directory
+// (providers/index.ts's `skill.global === null`), so
+// diagnostics/context.ts's `gatherMachine` computed `devCore.present` as
+// permanently `false` for Copilot (no way to ever satisfy it). That made
+// `stepDevCore` (init/steps.ts) fall through on every run and call
+// `installBundle` at GLOBAL scope, which throws for a provider with no
+// global skill mechanism — an install that was always guaranteed to fail.
+//
+// Fixed in diagnostics/context.ts: when `skillsDir === null`, there is no
+// global-scope devCore/baseline-bundle concept to satisfy for this agent at
+// all, so `devCorePresent` is now reported `true` (N/A treated as
+// satisfied) — mirroring how `globalSkills` already treats the same
+// null-skillsDir case as trivially healthy. `stepDevCore`'s existing
+// `present && brokenLinks.length === 0 -> skip` guard then naturally never
+// falls through to the doomed install, with no redundant guard needed in
+// steps.ts itself.
+//
+// This test lets `awm init --agent copilot` run its REAL, unstubbed
+// pipeline end-to-end against a hand-seeded registry fixture (same pattern
+// as codex-provider-isolated.test.ts) — never against the real `~/.awm`
+// (CLAUDE.md's "never touch ~/.awm" rule; HOME/AWM_HOME are isolated
+// tmpdirs for the whole test).
+const fs_1 = __importDefault(require("fs"));
+const os_1 = __importDefault(require("os"));
+const path_1 = __importDefault(require("path"));
+describe('copilot provider — isolated home E2E (devCore global-scope guard regression)', () => {
+    let tmpHome;
+    let tmpWork;
+    let originalHome;
+    let originalAwmHome;
+    let writeSpy;
+    beforeEach(() => {
+        tmpHome = fs_1.default.mkdtempSync(path_1.default.join(os_1.default.tmpdir(), 'awm-copilot-e2e-home-'));
+        tmpWork = fs_1.default.mkdtempSync(path_1.default.join(os_1.default.tmpdir(), 'awm-copilot-e2e-work-'));
+        originalHome = process.env.HOME;
+        originalAwmHome = process.env.AWM_HOME;
+        process.env.HOME = tmpHome;
+        process.env.AWM_HOME = path_1.default.join(tmpHome, '.awm');
+        jest.resetModules();
+        writeSpy = jest.spyOn(process.stdout, 'write').mockImplementation(() => true);
+    });
+    afterEach(() => {
+        writeSpy.mockRestore();
+        fs_1.default.rmSync(tmpHome, { recursive: true, force: true });
+        fs_1.default.rmSync(tmpWork, { recursive: true, force: true });
+        if (originalHome === undefined)
+            delete process.env.HOME;
+        else
+            process.env.HOME = originalHome;
+        if (originalAwmHome === undefined)
+            delete process.env.AWM_HOME;
+        else
+            process.env.AWM_HOME = originalAwmHome;
+    });
+    /** Same fixture shape as codex-provider-isolated.test.ts's seedPublicRegistryFixture:
+     *  a real content-root registry (no git repo needed) with the bootstrap skill and one
+     *  baseline bundle. Copilot needs no hooks (providers/index.ts has no `hooks` config
+     *  for it) and no native agent renderer (`agent: null`), so the fixture is intentionally
+     *  smaller than Codex's. */
+    function seedPublicRegistryFixture(root) {
+        fs_1.default.mkdirSync(path_1.default.join(root, 'hooks'), { recursive: true });
+        fs_1.default.writeFileSync(path_1.default.join(root, 'hooks/session-start'), '#!/bin/sh\necho "{}"\n', { mode: 0o755 });
+        fs_1.default.writeFileSync(path_1.default.join(root, 'hooks/run-hook.cmd'), '#!/bin/sh\nexec sh "$1"\n', { mode: 0o755 });
+        fs_1.default.mkdirSync(path_1.default.join(root, 'skills/using-awm'), { recursive: true });
+        fs_1.default.writeFileSync(path_1.default.join(root, 'skills/using-awm/SKILL.md'), '---\nname: using-awm\n---\nMUST invoke skills.');
+        fs_1.default.mkdirSync(path_1.default.join(root, 'skills/development-process'), { recursive: true });
+        fs_1.default.writeFileSync(path_1.default.join(root, 'skills/development-process/SKILL.md'), '---\nname: development-process\n---\nOrchestrates the dev lifecycle.');
+        fs_1.default.writeFileSync(path_1.default.join(root, 'catalog.json'), JSON.stringify({
+            version: 1,
+            bundles: [{ name: 'dev-core', source: 'bundles/dev-core', version: '1.0.0', scope: 'baseline', visibility: 'public' }],
+        }));
+        fs_1.default.mkdirSync(path_1.default.join(root, 'bundles/dev-core'), { recursive: true });
+        fs_1.default.writeFileSync(path_1.default.join(root, 'bundles/dev-core/bundle.json'), JSON.stringify({
+            name: 'dev-core', description: '', version: '1.0.0', scope: 'baseline', visibility: 'public',
+            dependsOn: [], skills: ['development-process'], workflows: [], agents: [],
+        }));
+        fs_1.default.mkdirSync(path_1.default.join(tmpHome, '.awm'), { recursive: true });
+        fs_1.default.writeFileSync(path_1.default.join(tmpHome, '.awm/registries.json'), JSON.stringify([{ name: 'baseline', remote: 'https://example.invalid/baseline.git' }], null, 2));
+    }
+    function readPrefs() {
+        return JSON.parse(fs_1.default.readFileSync(path_1.default.join(tmpHome, '.awm/preferences.json'), 'utf8'));
+    }
+    it('completes without crashing/rolling back (real bug repro) and delivers content via AGENTS.md, not a doomed global-scope install', async () => {
+        seedPublicRegistryFixture(path_1.default.join(tmpHome, '.awm/registries/baseline'));
+        const { runInit } = require('../../src/commands/init');
+        // Real, full, unstubbed init for copilot. Before the fix, this threw
+        // "machine.devCore: skill global scope is not supported by Copilot: GitHub
+        // Copilot has no user-level skill discovery mechanism — skills must be
+        // installed per-project." and rolled back the whole transaction (exit 2,
+        // AGENTS.md reverted, preferences never committed).
+        const code = await runInit({ cwd: tmpWork, yes: true, agent: 'copilot' });
+        // 0 (healthy) or 1 (degraded-but-completed) — NOT 2 (failed/rolled back).
+        expect(code).toBeLessThanOrEqual(1);
+        // The transaction actually committed: copilot is now a real enabled agent.
+        expect(readPrefs().enabledAgents).toEqual(['copilot']);
+        // Copilot has no global skill directory at all — confirm nothing was
+        // (wrongly) written there, and no ~/.github tree was invented.
+        expect(fs_1.default.existsSync(path_1.default.join(tmpHome, '.github'))).toBe(false);
+        // Content delivery for Copilot happens via its managed-agents-md injection
+        // mechanism at PROJECT scope (stepContextInjection, globalPath === null ->
+        // scope 'local') — confirm that path is unaffected by this fix and still
+        // really delivers the using-awm skill content into the project AGENTS.md.
+        const agentsMd = fs_1.default.readFileSync(path_1.default.join(tmpWork, 'AGENTS.md'), 'utf8');
+        expect(agentsMd).toContain('MUST invoke skills.');
+    });
+    // Regression for the SAME structural bug as the devCore one above, in the
+    // sibling `ambient` computation (diagnostics/context.ts's `gatherMachine`,
+    // a few lines below devCorePresent): before the fix, `installed` was
+    // forced to `[]` unconditionally whenever `skillsDir === null` (Copilot),
+    // regardless of what `~/.awm/config.json`'s `ambient` array wanted. That
+    // made stepAmbient (init/steps.ts) treat every wanted ambient bundle as
+    // permanently missing and call installBundle at GLOBAL scope for
+    // Copilot — throwing "skill global scope is not supported by Copilot"
+    // and rolling back the whole init transaction, exactly like the devCore
+    // bug. Nothing in the current CLI writes `ambient` into
+    // `~/.awm/config.json` automatically, but it IS read unconditionally by
+    // production code and is a real, documented mechanism a user/script can
+    // populate — so this hand-seeds it, same as a real machine config would.
+    it('with a machine-level ambient bundle configured, completes without crashing/rolling back (ambient sibling of the devCore bug)', async () => {
+        const registryRoot = path_1.default.join(tmpHome, '.awm/registries/baseline');
+        seedPublicRegistryFixture(registryRoot);
+        // Add an ambient-scope bundle to the registry fixture so `wanted`
+        // resolves to real skills (resolveBundleSkills needs the bundle to
+        // actually exist in `bundles`, discovered via discoverAllBundles()).
+        fs_1.default.mkdirSync(path_1.default.join(registryRoot, 'skills/ambient-skill'), { recursive: true });
+        fs_1.default.writeFileSync(path_1.default.join(registryRoot, 'skills/ambient-skill/SKILL.md'), '---\nname: ambient-skill\ndescription: An ambient bundle skill.\n---\nAmbient.');
+        const catalog = JSON.parse(fs_1.default.readFileSync(path_1.default.join(registryRoot, 'catalog.json'), 'utf8'));
+        catalog.bundles.push({ name: 'personal-notion', source: 'bundles/personal-notion', version: '1.0.0', scope: 'ambient', visibility: 'public' });
+        fs_1.default.writeFileSync(path_1.default.join(registryRoot, 'catalog.json'), JSON.stringify(catalog));
+        fs_1.default.mkdirSync(path_1.default.join(registryRoot, 'bundles/personal-notion'), { recursive: true });
+        fs_1.default.writeFileSync(path_1.default.join(registryRoot, 'bundles/personal-notion/bundle.json'), JSON.stringify({
+            name: 'personal-notion', description: '', version: '1.0.0', scope: 'ambient', visibility: 'public',
+            dependsOn: [], skills: ['ambient-skill'], workflows: [], agents: [],
+        }));
+        // Seed the machine-level ambient config exactly as a user/script would.
+        fs_1.default.writeFileSync(path_1.default.join(tmpHome, '.awm/config.json'), JSON.stringify({ ambient: ['personal-notion'] }));
+        const { runInit } = require('../../src/commands/init');
+        // Before the fix, this threw "machine.ambient: skill global scope is
+        // not supported by Copilot..." (same class as the devCore crash) and
+        // rolled back the whole transaction (exit 2, AGENTS.md reverted,
+        // preferences never committed).
+        const code = await runInit({ cwd: tmpWork, yes: true, agent: 'copilot' });
+        // 0 (healthy) or 1 (degraded-but-completed) — NOT 2 (failed/rolled back).
+        expect(code).toBeLessThanOrEqual(1);
+        // The transaction actually committed.
+        expect(readPrefs().enabledAgents).toEqual(['copilot']);
+        // Copilot has no global skill directory at all — confirm the ambient
+        // bundle was NOT (wrongly) installed at global scope either.
+        expect(fs_1.default.existsSync(path_1.default.join(tmpHome, '.github'))).toBe(false);
+    });
+    it('a subsequent `awm add <bundle> -a copilot` works once init has actually committed', async () => {
+        seedPublicRegistryFixture(path_1.default.join(tmpHome, '.awm/registries/baseline'));
+        // Add a second, non-baseline bundle the project can explicitly activate
+        // locally (Copilot only supports local-scope skill delivery — providers/
+        // index.ts's `skill.local: '.github/instructions'`).
+        const registryRoot = path_1.default.join(tmpHome, '.awm/registries/baseline');
+        fs_1.default.mkdirSync(path_1.default.join(registryRoot, 'skills/extra-skill'), { recursive: true });
+        fs_1.default.writeFileSync(path_1.default.join(registryRoot, 'skills/extra-skill/SKILL.md'), '---\nname: extra-skill\ndescription: An extra project skill.\n---\nExtra.');
+        fs_1.default.mkdirSync(path_1.default.join(registryRoot, 'bundles/extra'), { recursive: true });
+        fs_1.default.writeFileSync(path_1.default.join(registryRoot, 'bundles/extra/bundle.json'), JSON.stringify({
+            name: 'extra', description: '', version: '1.0.0', scope: 'project', visibility: 'public',
+            dependsOn: [], skills: ['extra-skill'], workflows: [], agents: [],
+        }));
+        const catalog = JSON.parse(fs_1.default.readFileSync(path_1.default.join(registryRoot, 'catalog.json'), 'utf8'));
+        catalog.bundles.push({ name: 'extra', source: 'bundles/extra', version: '1.0.0', scope: 'project', visibility: 'public' });
+        fs_1.default.writeFileSync(path_1.default.join(registryRoot, 'catalog.json'), JSON.stringify(catalog));
+        // findProjectRoot needs a real project marker (.git/, package.json, or
+        // .awm/profile.json) — a bare tmpdir isn't one (same pattern as
+        // tests/commands/add.test.ts).
+        fs_1.default.writeFileSync(path_1.default.join(tmpWork, 'package.json'), JSON.stringify({ name: 'fixture' }));
+        const { runInit } = require('../../src/commands/init');
+        const initCode = await runInit({ cwd: tmpWork, yes: true, agent: 'copilot' });
+        expect(initCode).toBeLessThanOrEqual(1);
+        expect(readPrefs().enabledAgents).toEqual(['copilot']);
+        // This was "permanently blocked" per the bug report — it requires a prior
+        // COMMITTED `awm init --agent copilot` (resolveAgentTargetsOrError rejects
+        // any agent not in enabledAgents), which never happened before the fix
+        // because every copilot init rolled back before saving preferences.
+        const { runAddBundleCore } = require('../../src/commands/add');
+        const { loadPreferences } = require('../../src/utils/config');
+        const { discoverAllBundles } = require('../../src/core/bundles');
+        const { prefs } = loadPreferences('copilot');
+        const bundles = discoverAllBundles();
+        const result = runAddBundleCore({ name: 'extra', agent: 'copilot', cwd: tmpWork }, prefs, bundles);
+        expect(result.code).toBe(0);
+        expect(result.result?.installed.length).toBeGreaterThan(0);
+        const instructionsDir = path_1.default.join(tmpWork, '.github/instructions');
+        expect(fs_1.default.existsSync(instructionsDir)).toBe(true);
+    });
+});

package/dist/tests/ui/text.test.js

@@ -44,6 +44,15 @@ describe('truncate', () => {
     it('returns empty for non-positive width', () => {
         expect((0, text_1.truncate)('abc', 0)).toBe('');
     });
+    it('colapsa saltos de linea a un espacio — la celda es de UNA linea', () => {
+        // Regresion: `displayWidth` cuenta `\n` como ancho 1, asi que una string
+        // multilinea corta pasaba el chequeo y se emitia cruda, partiendo la fila
+        // de `awm list` y desalineando todo lo siguiente. Alcanzable desde que el
+        // lector de frontmatter resuelve block scalars literales (`|`).
+        expect((0, text_1.truncate)('linea uno\nlinea dos', 80)).toBe('linea uno linea dos');
+        expect((0, text_1.truncate)('a\r\n  b', 80)).toBe('a b');
+        expect((0, text_1.truncate)('linea uno\nlinea dos', 12)).toBe('linea uno l…');
+    });
 });
 describe('wrap', () => {
     it('breaks text at word boundaries within width', () => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agentic-workflow-manager",
-  "version": "3.13.3",
+  "version": "3.13.5",
   "main": "dist/src/index.js",
   "bin": {
     "awm": "./dist/src/index.js"
@@ -43,10 +43,12 @@
   },
   "devDependencies": {
     "@types/jest": "^30.0.0",
+    "@types/js-yaml": "4.0.9",
     "@types/node": "^25.3.0",
     "dependency-cruiser": "^17.4.3",
     "eslint": "^10.4.1",
     "jest": "^30.2.0",
+    "js-yaml": "4.1.0",
     "ts-jest": "^29.4.6",
     "typescript": "^5.9.3"
   }