agentic-qe 3.9.21 → 3.9.23

package/dist/learning/rvf-pattern-store.js

@@ -112,10 +112,20 @@ export class RvfPatternStore {
         if (pattern.confidence < this.config.minConfidence) {
             return err(new Error(`Pattern confidence ${pattern.confidence} below threshold ${this.config.minConfidence}`));
         }
-        // Persist metadata to SQLite
+        // Persist metadata to SQLite. #447: capture the returned id — ON CONFLICT
+        // on (name, qe_domain, pattern_type) preserves the existing row's id, so
+        // we must align pattern.id with what's actually stored before ingesting
+        // into HNSW or returning to callers (otherwise recordOutcome later fails
+        // with "Pattern not found" and qe_pattern_usage stays empty).
         if (this.sqliteStore) {
             try {
-                this.sqliteStore.storePattern(pattern, pattern.embedding);
+                const actualId = this.sqliteStore.storePattern(pattern, pattern.embedding);
+                if (actualId && actualId !== pattern.id) {
+                    // QEPattern.id is `readonly` for callers, but inside the store
+                    // we own the lifecycle and must align it with the persisted row
+                    // before HNSW ingest (otherwise the index keys diverge from SQLite).
+                    pattern.id = actualId;
+                }
             }
             catch (error) {
                 console.warn(`[RvfPatternStore] SQLite persist failed for ${pattern.id}:`, toErrorMessage(error));

package/dist/learning/sqlite-persistence.js

@@ -390,7 +390,14 @@ export class SQLitePatternStore {
             }
         });
         transaction();
-        return id;
+        // #447: ON CONFLICT(name, qe_domain, pattern_type) preserves the existing
+        // row's id, so the new `id` we just tried to insert may not be what's
+        // actually stored. SELECT the actual id back so callers (rvf-pattern-store,
+        // qe-hooks) can stay consistent with HNSW and downstream usage tables.
+        const actualRow = this.db
+            .prepare('SELECT id FROM qe_patterns WHERE name = ? AND qe_domain = ? AND pattern_type = ?')
+            .get(pattern.name, pattern.qeDomain ?? '', pattern.patternType ?? '');
+        return actualRow ? actualRow.id : id;
     }
     /**
      * Get a pattern by ID