agentic-qe 3.6.2 → 3.6.3

package/.claude/skills/brutal-honesty-review/scripts/validate.sh

@@ -1,130 +0,0 @@
-#!/bin/bash
-# =============================================================================
-# AQE Skill Validator: brutal-honesty-review v1.0.0
-# =============================================================================
-set -euo pipefail
-
-SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-SKILL_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
-PROJECT_ROOT="$(cd "$SKILL_DIR/../../.." && pwd)"
-
-for lib_path in "$PROJECT_ROOT/.claude/skills/.validation/templates/validator-lib.sh" "$SKILL_DIR/scripts/validator-lib.sh"; do
-  [[ -f "$lib_path" ]] && source "$lib_path" && break
-done
-
-SKILL_NAME="brutal-honesty-review"
-SKILL_VERSION="1.0.0"
-REQUIRED_TOOLS=("jq")
-SCHEMA_PATH="$SKILL_DIR/schemas/output.json"
-REQUIRED_FIELDS=("skillName" "status" "output" "output.summary" "output.reviewFindings" "output.codeQuality")
-MUST_CONTAIN_TERMS=("review" "code")
-MUST_NOT_CONTAIN_TERMS=("TODO" "FIXME")
-ENUM_VALIDATIONS=(".status:success,partial,failed,skipped")
-
-validate_skill_specific() {
-  local output_file="$1"
-  local has_errors=false
-
-  # Validate review findings
-  local finding_count
-  finding_count=$(jq '.output.reviewFindings | length' "$output_file" 2>/dev/null || echo "0")
-
-  if [[ "$finding_count" -eq 0 ]]; then
-    warn "No review findings - brutal honesty review should have at least one finding"
-  else
-    local invalid_findings
-    invalid_findings=$(jq '[.output.reviewFindings[]? | select(.id == null or .title == null or .severity == null or .category == null or .honestAssessment == null)] | length' "$output_file" 2>/dev/null || echo "0")
-
-    if [[ "$invalid_findings" -gt 0 ]]; then
-      warn "$invalid_findings finding(s) missing required fields (id, title, severity, category, honestAssessment)"
-    fi
-
-    # Validate finding ID pattern
-    local invalid_ids
-    invalid_ids=$(jq '[.output.reviewFindings[]?.id // empty | select(test("^REV-[0-9]{3,6}$") | not)] | length' "$output_file" 2>/dev/null || echo "0")
-
-    if [[ "$invalid_ids" -gt 0 ]]; then
-      warn "$invalid_ids finding(s) have invalid ID format (should be REV-NNN)"
-    fi
-
-    # Validate severity enum
-    local valid_severities="critical high medium low nitpick"
-    local severities
-    severities=$(jq -r '.output.reviewFindings[]?.severity // empty' "$output_file" 2>/dev/null || true)
-
-    for sev in $severities; do
-      if ! echo "$valid_severities" | grep -qw "$sev"; then
-        error "Invalid severity: $sev"
-        has_errors=true
-      fi
-    done
-
-    # Ensure honest assessment is substantial (min 20 chars)
-    local short_assessments
-    short_assessments=$(jq '[.output.reviewFindings[]?.honestAssessment // "" | select(length < 20)] | length' "$output_file" 2>/dev/null || echo "0")
-
-    if [[ "$short_assessments" -gt 0 ]]; then
-      warn "$short_assessments finding(s) have assessment shorter than 20 characters"
-    fi
-  fi
-
-  # Validate code quality
-  local has_quality
-  has_quality=$(jq '.output.codeQuality | has("overallScore") and has("grade")' "$output_file" 2>/dev/null)
-
-  if [[ "$has_quality" != "true" ]]; then
-    error "Code quality missing required fields (overallScore, grade)"
-    has_errors=true
-  else
-    # Validate score range
-    local score
-    score=$(jq '.output.codeQuality.overallScore' "$output_file" 2>/dev/null)
-
-    if [[ -n "$score" && "$score" != "null" ]]; then
-      if (( $(echo "$score < 0 || $score > 100" | bc -l 2>/dev/null || echo "0") )); then
-        error "Overall score $score out of range (0-100)"
-        has_errors=true
-      fi
-    fi
-
-    # Validate grade pattern
-    local grade
-    grade=$(jq -r '.output.codeQuality.grade // ""' "$output_file" 2>/dev/null)
-
-    if [[ -n "$grade" && ! "$grade" =~ ^[A-F][+-]?$ ]]; then
-      error "Invalid grade format: $grade (should be A-F with optional +/-)"
-      has_errors=true
-    fi
-  fi
-
-  # Validate verdict if present
-  local verdict
-  verdict=$(jq -r '.output.verdict // ""' "$output_file" 2>/dev/null)
-
-  if [[ -n "$verdict" && "$verdict" != "null" ]]; then
-    local valid_verdicts="ship-it needs-work major-issues do-not-merge rewrite-needed"
-    if ! echo "$valid_verdicts" | grep -qw "$verdict"; then
-      error "Invalid verdict: $verdict"
-      has_errors=true
-    fi
-  fi
-
-  if [[ "$has_errors" == "true" ]]; then return 1; fi
-  success "Brutal honesty review validation passed"
-  return 0
-}
-
-OUTPUT_FILE="${1:-}"
-[[ -z "$OUTPUT_FILE" ]] && { echo "Usage: $0 <output-file>"; exit 1; }
-[[ ! -f "$OUTPUT_FILE" ]] && { echo "ERROR: File not found: $OUTPUT_FILE"; exit 1; }
-
-echo "Validating $SKILL_NAME output..."
-jq empty "$OUTPUT_FILE" 2>/dev/null || { echo "ERROR: Invalid JSON"; exit 1; }
-
-if validate_skill_specific "$OUTPUT_FILE"; then
-  echo "PASSED: $SKILL_NAME validation"
-  exit 0
-else
-  echo "FAILED: $SKILL_NAME validation"
-  exit 1
-fi

package/.claude/skills/bug-reporting-excellence/scripts/validate.sh

@@ -1,108 +0,0 @@
-#!/bin/bash
-# =============================================================================
-# AQE Skill Validator: bug-reporting-excellence v1.0.0
-# =============================================================================
-set -euo pipefail
-
-SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-SKILL_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
-PROJECT_ROOT="$(cd "$SKILL_DIR/../../.." && pwd)"
-
-for lib_path in "$PROJECT_ROOT/.claude/skills/.validation/templates/validator-lib.sh" "$SKILL_DIR/scripts/validator-lib.sh"; do
-  [[ -f "$lib_path" ]] && source "$lib_path" && break
-done
-
-SKILL_NAME="bug-reporting-excellence"
-SKILL_VERSION="1.0.0"
-REQUIRED_TOOLS=("jq")
-SCHEMA_PATH="$SKILL_DIR/schemas/output.json"
-REQUIRED_FIELDS=("skillName" "status" "output" "output.summary" "output.bugReports" "output.reportQuality")
-MUST_CONTAIN_TERMS=("bug" "steps")
-MUST_NOT_CONTAIN_TERMS=("TODO" "FIXME")
-ENUM_VALIDATIONS=(".status:success,partial,failed,skipped")
-
-validate_skill_specific() {
-  local output_file="$1"
-  local has_errors=false
-
-  # Validate bug reports
-  local report_count
-  report_count=$(jq '.output.bugReports | length' "$output_file" 2>/dev/null || echo "0")
-
-  if [[ "$report_count" -eq 0 ]]; then
-    error "No bug reports found - at least one bug report is required"
-    has_errors=true
-  else
-    local invalid_reports
-    invalid_reports=$(jq '[.output.bugReports[]? | select(.id == null or .title == null or .severity == null or .stepsToReproduce == null or .expectedBehavior == null or .actualBehavior == null)] | length' "$output_file" 2>/dev/null || echo "0")
-
-    if [[ "$invalid_reports" -gt 0 ]]; then
-      error "$invalid_reports bug report(s) missing required fields"
-      has_errors=true
-    fi
-
-    # Validate bug ID pattern
-    local invalid_ids
-    invalid_ids=$(jq '[.output.bugReports[]?.id // empty | select(test("^BUG-[0-9]{3,6}$") | not)] | length' "$output_file" 2>/dev/null || echo "0")
-
-    if [[ "$invalid_ids" -gt 0 ]]; then
-      warn "$invalid_ids bug report(s) have invalid ID format (should be BUG-NNN)"
-    fi
-
-    # Validate severity enum
-    local valid_severities="critical high medium low trivial"
-    local severities
-    severities=$(jq -r '.output.bugReports[]?.severity // empty' "$output_file" 2>/dev/null || true)
-
-    for sev in $severities; do
-      if ! echo "$valid_severities" | grep -qw "$sev"; then
-        error "Invalid severity: $sev"
-        has_errors=true
-      fi
-    done
-
-    # Validate steps to reproduce is an array with at least one step
-    local reports_without_steps
-    reports_without_steps=$(jq '[.output.bugReports[]? | select((.stepsToReproduce | length) == 0)] | length' "$output_file" 2>/dev/null || echo "0")
-
-    if [[ "$reports_without_steps" -gt 0 ]]; then
-      warn "$reports_without_steps bug report(s) have empty steps to reproduce"
-    fi
-
-    # Validate title length (min 15 chars)
-    local short_titles
-    short_titles=$(jq '[.output.bugReports[]?.title // "" | select(length < 15)] | length' "$output_file" 2>/dev/null || echo "0")
-
-    if [[ "$short_titles" -gt 0 ]]; then
-      warn "$short_titles bug report(s) have title shorter than 15 characters"
-    fi
-  fi
-
-  # Validate report quality
-  local has_quality
-  has_quality=$(jq '.output.reportQuality | has("overallScore") and has("grade")' "$output_file" 2>/dev/null)
-
-  if [[ "$has_quality" != "true" ]]; then
-    error "Report quality missing required fields (overallScore, grade)"
-    has_errors=true
-  fi
-
-  if [[ "$has_errors" == "true" ]]; then return 1; fi
-  success "Bug reporting excellence validation passed"
-  return 0
-}
-
-OUTPUT_FILE="${1:-}"
-[[ -z "$OUTPUT_FILE" ]] && { echo "Usage: $0 <output-file>"; exit 1; }
-[[ ! -f "$OUTPUT_FILE" ]] && { echo "ERROR: File not found: $OUTPUT_FILE"; exit 1; }
-
-echo "Validating $SKILL_NAME output..."
-jq empty "$OUTPUT_FILE" 2>/dev/null || { echo "ERROR: Invalid JSON"; exit 1; }
-
-if validate_skill_specific "$OUTPUT_FILE"; then
-  echo "PASSED: $SKILL_NAME validation"
-  exit 0
-else
-  echo "FAILED: $SKILL_NAME validation"
-  exit 1
-fi