agentic-qe 3.15.7 → 3.15.8

package/dist/learning/dream/rvcow-branch-manager.d.ts

@@ -13,6 +13,14 @@
  *   - mergeBranch   -> RELEASE SAVEPOINT
  *   - discardBranch -> ROLLBACK TO SAVEPOINT
  *
+ * WARNING (#1060): a SAVEPOINT covers every write on its connection, not just
+ * the dream's. Use an isolated connection, or keep the branch open only
+ * across synchronous work. If it stays open across `await`s on the
+ * process-wide shared connection, foreground writes made in the meantime
+ * (memory_store and other acknowledged writes) join the savepoint and are
+ * rolled back by a discard, or lost if the connection closes before
+ * RELEASE. DreamEngine therefore defaults `enableBranching` to false.
+ *
  * @module learning/dream/rvcow-branch-manager
  */
 import type { Database as DatabaseType } from 'better-sqlite3';

package/dist/learning/dream/rvcow-branch-manager.js

@@ -13,6 +13,14 @@
  *   - mergeBranch   -> RELEASE SAVEPOINT
  *   - discardBranch -> ROLLBACK TO SAVEPOINT
  *
+ * WARNING (#1060): a SAVEPOINT covers every write on its connection, not just
+ * the dream's. Use an isolated connection, or keep the branch open only
+ * across synchronous work. If it stays open across `await`s on the
+ * process-wide shared connection, foreground writes made in the meantime
+ * (memory_store and other acknowledged writes) join the savepoint and are
+ * rolled back by a discard, or lost if the connection closes before
+ * RELEASE. DreamEngine therefore defaults `enableBranching` to false.
+ *
  * @module learning/dream/rvcow-branch-manager
  */
 import { existsSync, unlinkSync } from 'fs';

package/dist/learning/dream/speculative-dreamer.d.ts

@@ -69,6 +69,14 @@ export declare const BUILT_IN_STRATEGIES: DreamStrategy[];
  * are executed one at a time but each in its own savepoint. The branch manager
  * ensures that failed strategies leave no trace in the database.
  *
+ * WARNING (#1060): a SAVEPOINT covers every write on its connection, not just
+ * the dream's. Use an isolated connection, or keep the branch open only
+ * across synchronous work. If it stays open across `await`s on the
+ * process-wide shared connection, foreground writes made in the meantime
+ * (memory_store and other acknowledged writes) join the savepoint and are
+ * rolled back by a discard, or lost if the connection closes before
+ * RELEASE. DreamEngine therefore defaults `enableBranching` to false.
+ *
  * @example
  * ```typescript
  * const dreamer = new SpeculativeDreamer(db);

package/dist/learning/dream/speculative-dreamer.js

@@ -61,6 +61,14 @@ export const BUILT_IN_STRATEGIES = [
  * are executed one at a time but each in its own savepoint. The branch manager
  * ensures that failed strategies leave no trace in the database.
  *
+ * WARNING (#1060): a SAVEPOINT covers every write on its connection, not just
+ * the dream's. Use an isolated connection, or keep the branch open only
+ * across synchronous work. If it stays open across `await`s on the
+ * process-wide shared connection, foreground writes made in the meantime
+ * (memory_store and other acknowledged writes) join the savepoint and are
+ * rolled back by a discard, or lost if the connection closes before
+ * RELEASE. DreamEngine therefore defaults `enableBranching` to false.
+ *
  * @example
  * ```typescript
  * const dreamer = new SpeculativeDreamer(db);

package/dist/mcp/background-workers.d.ts

@@ -0,0 +1,15 @@
+/**
+ * Agentic QE v3 - MCP background worker startup (IMP-10, #1061)
+ *
+ * Starts the worker daemon and the QualityDaemon for the MCP server, unless
+ * `AQE_WORKERS_ENABLED` is set to a falsy value (`false`, `0`, `off`, `no`).
+ * `aqe init --no-database` writes `AQE_WORKERS_ENABLED=false` (#533); before
+ * #1061 the variable was written but never read.
+ *
+ * All output goes through `log`, which the MCP entry binds to the original
+ * stderr writer so stdout stays reserved for JSON-RPC.
+ */
+import { type WorkerEnv } from '../workers/worker-env.js';
+export type BackgroundWorkersOutcome = 'disabled' | 'started' | 'failed';
+export declare function startBackgroundWorkers(log: (message: string) => void, env?: WorkerEnv): Promise<BackgroundWorkersOutcome>;
+//# sourceMappingURL=background-workers.d.ts.map

package/dist/mcp/background-workers.js

@@ -0,0 +1,71 @@
+/**
+ * Agentic QE v3 - MCP background worker startup (IMP-10, #1061)
+ *
+ * Starts the worker daemon and the QualityDaemon for the MCP server, unless
+ * `AQE_WORKERS_ENABLED` is set to a falsy value (`false`, `0`, `off`, `no`).
+ * `aqe init --no-database` writes `AQE_WORKERS_ENABLED=false` (#533); before
+ * #1061 the variable was written but never read.
+ *
+ * All output goes through `log`, which the MCP entry binds to the original
+ * stderr writer so stdout stays reserved for JSON-RPC.
+ */
+import { isWorkersEnabled } from '../workers/worker-env.js';
+export async function startBackgroundWorkers(log, env = process.env) {
+    if (!isWorkersEnabled(env)) {
+        log(`[MCP] Background workers disabled (AQE_WORKERS_ENABLED=${env.AQE_WORKERS_ENABLED}); ` +
+            'worker daemon and quality daemon not started\n');
+        return 'disabled';
+    }
+    // In database-free mode the workers run against the in-memory unified
+    // store, so they persist nothing to disk while keeping QualityDaemon/health
+    // functional.
+    try {
+        const { getDaemon } = await import('../workers/daemon.js');
+        // ADR-001 Bug A fix: use the canonical getDaemon() default. Passing
+        // `{ autoStart: false }` here would neuter workerManager.startAll() —
+        // the only call path that schedules per-worker setInterval timers, so
+        // workers would register but never tick. DEFAULT_CONFIG.autoStart=true
+        // (workers/daemon.ts) is the contracted default; matches the
+        // shutdownDaemon() call site in entry.ts.
+        const daemon = getDaemon();
+        await daemon.start();
+        const status = daemon.getStatus();
+        log(`[MCP] Background workers started (${status.workerManager.totalWorkers} workers)\n`);
+        // IMP-10: Start QualityDaemon with persistent memory (Finding 1 & 2 resolution)
+        try {
+            const { UnifiedMemoryManager } = await import('../kernel/unified-memory.js');
+            const { PersistentWorkerMemory } = await import('../workers/quality-daemon/persistent-memory.js');
+            const { isPrivateIp } = await import('../hooks/security/ssrf-guard.js');
+            const unifiedMemory = await UnifiedMemoryManager.getInstanceAsync();
+            const persistentMemory = new PersistentWorkerMemory(unifiedMemory);
+            const qualityDaemon = daemon.getQualityDaemon({
+                notifications: {
+                    // IMP-07 SSRF guard: block private IPs in webhook URLs (Finding 5)
+                    urlValidator: (url) => {
+                        try {
+                            const parsed = new URL(url);
+                            const hostname = parsed.hostname.replace(/^\[|\]$/g, '');
+                            return !isPrivateIp(hostname);
+                        }
+                        catch {
+                            return false;
+                        }
+                    },
+                },
+            });
+            await qualityDaemon.start(persistentMemory);
+            log(`[MCP] Quality daemon started\n`);
+        }
+        catch (qdError) {
+            log(`[MCP] WARNING: Quality daemon failed to start: ${qdError}\n`);
+            // Non-fatal — MCP continues without quality daemon
+        }
+        return 'started';
+    }
+    catch (daemonError) {
+        log(`[MCP] WARNING: Background workers failed to start: ${daemonError}\n`);
+        // Non-fatal — MCP server continues without background workers
+        return 'failed';
+    }
+}
+//# sourceMappingURL=background-workers.js.map