agentic-qe 3.14.3 → 3.14.5

package/dist/coordination/queen-coordinator.js

@@ -351,13 +351,19 @@ export class QueenCoordinator {
         const execution = this.tasks.get(taskId);
         if (!execution)
             return err(new Error(`Task not found: ${taskId}`));
+        // Repeated cancellation is one decision, not another event or capacity release.
+        if (execution.status === 'cancelled')
+            return ok(undefined);
         if (execution.status === 'completed' || execution.status === 'failed') {
             return err(new Error(`Task already finished: ${taskId}`));
         }
-        if (execution.status === 'running' || execution.status === 'assigned') {
-            this.runningTaskCounter = Math.max(0, this.runningTaskCounter - 1);
-        }
-        this.tasks.set(taskId, { ...execution, status: 'cancelled', completedAt: new Date() });
+        const cancellationResultPending = execution.status === 'running' || execution.status === 'assigned';
+        // Keep the capacity slot until the outstanding result arrives. Stopping an
+        // agent does not necessarily stop a domain plugin or its child process.
+        this.tasks.set(taskId, {
+            ...execution, status: 'cancelled', completedAt: new Date(),
+            cancellationResultPending,
+        });
         removeFromQueues(this.taskQueue, this.domainQueues, execution.task);
         for (const agentId of execution.assignedAgents) {
             await this.agentCoordinator.stop(agentId);

package/dist/coordination/queen-event-handlers.js

@@ -7,6 +7,7 @@
 import { getCrossPhaseHookExecutor } from '../hooks/cross-phase-hooks.js';
 // Governance
 import { queenGovernanceAdapter } from '../governance/index.js';
+import { settleCancelledTask } from './cancelled-task-settlement.js';
 // ============================================================================
 // Event subscription
 // ============================================================================
@@ -51,6 +52,14 @@ async function handleDomainEvent(ctx, event) {
 // ============================================================================
 export async function handleTaskCompleted(ctx, event) {
     const { taskId, result } = event.payload;
+    const cancelled = settleCancelledTask(ctx.tasks, taskId);
+    if (cancelled.ignored) {
+        if (cancelled.settledNow) {
+            ctx.runningTaskCounter = Math.max(0, ctx.runningTaskCounter - 1);
+            await ctx.processQueue();
+        }
+        return;
+    }
     const execution = ctx.tasks.get(taskId);
     if (execution) {
         // CC-002 FIX: Decrement the atomic counter when task completes
@@ -154,6 +163,14 @@ export async function handleTaskCompleted(ctx, event) {
 // ============================================================================
 export async function handleTaskFailed(ctx, event) {
     const { taskId, error } = event.payload;
+    const cancelled = settleCancelledTask(ctx.tasks, taskId);
+    if (cancelled.ignored) {
+        if (cancelled.settledNow) {
+            ctx.runningTaskCounter = Math.max(0, ctx.runningTaskCounter - 1);
+            await ctx.processQueue();
+        }
+        return;
+    }
     const execution = ctx.tasks.get(taskId);
     if (execution) {
         // CC-002 FIX: Decrement the atomic counter when task fails

package/dist/coordination/queen-task-management.js

@@ -7,6 +7,7 @@ import { v4 as uuidv4 } from 'uuid';
 import { ok, err } from '../shared/types/index.js';
 import { binaryInsert, createdAtComparator } from '../shared/utils/index.js';
 import { TASK_DOMAIN_MAP } from './queen-types.js';
+import { settleCancelledTask } from './cancelled-task-settlement.js';
 // ============================================================================
 // Task comparator for priority queue binary insertion
 // ============================================================================
@@ -214,6 +215,14 @@ export async function assignTaskToDomain(ctx, task, domain) {
         ...(routeDecision?.triggerMultiModel ? ['advisor:triggerMultiModel'] : []),
     ];
     const spawnResult = await ctx.requestAgentSpawn(domain, agentType, spawnCapabilities);
+    // A queued task can be cancelled while routing or agent spawn is awaiting.
+    // Do not recreate it as running or dispatch its plugin afterward.
+    if (ctx.tasks.get(task.id)?.status === 'cancelled') {
+        if (spawnResult.success)
+            await ctx.agentCoordinator.stop(spawnResult.value);
+        ctx.runningTaskCounter = Math.max(0, ctx.runningTaskCounter - 1);
+        return ok(task.id);
+    }
     const agentIds = [];
     if (spawnResult.success) {
         agentIds.push(spawnResult.value);
@@ -252,6 +261,14 @@ export async function assignTaskToDomain(ctx, task, domain) {
             };
             const execResult = await plugin.executeTask(request, (result) => handleTaskCompletionCallback(ctx, result));
             if (!execResult.success) {
+                const cancelled = settleCancelledTask(ctx.tasks, task.id);
+                if (cancelled.ignored) {
+                    if (cancelled.settledNow) {
+                        ctx.runningTaskCounter = Math.max(0, ctx.runningTaskCounter - 1);
+                        await processQueue(ctx);
+                    }
+                    return ok(task.id);
+                }
                 ctx.tasks.set(task.id, {
                     ...execution,
                     status: 'failed',
@@ -298,6 +315,14 @@ async function handleTaskCompletionCallback(ctx, result) {
         console.warn(`[Queen] Received completion for unknown task: ${result.taskId}`);
         return;
     }
+    const cancelled = settleCancelledTask(ctx.tasks, result.taskId);
+    if (cancelled.ignored) {
+        if (cancelled.settledNow) {
+            ctx.runningTaskCounter = Math.max(0, ctx.runningTaskCounter - 1);
+            await processQueue(ctx);
+        }
+        return;
+    }
     const updated = {
         ...execution,
         status: result.success ? 'completed' : 'failed',

package/dist/coordination/queen-types.d.ts

@@ -42,6 +42,8 @@ export interface TaskExecution {
     readonly assignedAgents: string[];
     readonly startedAt?: Date;
     readonly completedAt?: Date;
+    /** True until an already-running task result arrives after cancellation. */
+    readonly cancellationResultPending?: boolean;
     readonly result?: unknown;
     readonly error?: string;
     readonly retryCount: number;

package/dist/coordination/task-executor.js

@@ -16,6 +16,7 @@ import { v4 as uuidv4 } from 'uuid';
 import { toErrorMessage } from '../shared/error-utils.js';
 import { createResultSaver } from './result-saver.js';
 import { createLogger } from '../logging/logger-factory.js';
+import { getClaudeModelForTier } from '../shared/llm/model-registry.js';
 // ADR-051: Agent Booster integration for Tier 0 tasks
 import { createAgentBoosterAdapter, } from '../integrations/agentic-flow/agent-booster/index.js';
 // ADR-051: Task Router for outcome recording
@@ -60,14 +61,9 @@ function resolveQualityAnalyzerService(memory) {
  * Per ADR-026: 3-tier model routing
  */
 function getModelForTier(tier) {
-    switch (tier) {
-        case 0: return 'agent-booster'; // Special case - WASM transforms
-        case 1: return 'claude-haiku-4-5-20251001';
-        case 2: return 'claude-sonnet-4-6';
-        case 3: return 'claude-sonnet-4-6'; // Extended thinking
-        case 4: return 'claude-opus-4-7';
-        default: return 'claude-sonnet-4-6';
-    }
+    if (tier === 0)
+        return 'agent-booster'; // Special case - WASM transforms
+    return getClaudeModelForTier(tier); // Tier 3 = extended thinking, same model as tier 2
 }
 /**
  * Map task type and code context to transform type for Agent Booster

package/dist/coordination/workflow-composition.d.ts

@@ -0,0 +1,19 @@
+/** Pure output-path conflict detection and payload-free composition hashing. */
+import type { ParallelCompositionReceipt, WorkflowStepDefinition } from './workflow-types.js';
+interface WritePath {
+    stepId: string;
+    path: string;
+    segments: string[];
+}
+/** Include the implicit `results[step.id]` write as well as declared mappings. */
+export declare function parallelWritePaths(step: WorkflowStepDefinition): WritePath[];
+export declare function parallelOutputConflicts(steps: WorkflowStepDefinition[]): ParallelCompositionReceipt['conflicts'];
+/** A declared read of a concurrently runnable sibling needs an explicit dependency. */
+export declare function parallelUndeclaredReads(steps: WorkflowStepDefinition[]): Array<{
+    stepId: string;
+    sourcePath: string;
+    otherStepId: string;
+}>;
+export declare function hashWorkflowValue(value: unknown): string;
+export {};
+//# sourceMappingURL=workflow-composition.d.ts.map

package/dist/coordination/workflow-composition.js

@@ -0,0 +1,114 @@
+/** Pure output-path conflict detection and payload-free composition hashing. */
+import { createHash } from 'node:crypto';
+/** Include the implicit `results[step.id]` write as well as declared mappings. */
+export function parallelWritePaths(step) {
+    if (['__proto__', 'constructor', 'prototype'].includes(step.id)) {
+        throw new Error(`parallel_output_invalid_path: unsafe step ID ${step.id}`);
+    }
+    const paths = [{ stepId: step.id, path: step.id, segments: [step.id] }];
+    for (const target of Object.values(step.outputMapping ?? {}).sort()) {
+        const segments = target.split('.');
+        if (segments.some(part => !part || ['__proto__', 'constructor', 'prototype'].includes(part))) {
+            throw new Error(`parallel_output_invalid_path: ${step.id} maps to ${target}`);
+        }
+        paths.push({ stepId: step.id, path: target, segments });
+    }
+    return paths;
+}
+export function parallelOutputConflicts(steps) {
+    const writes = steps.flatMap(parallelWritePaths);
+    const conflicts = [];
+    for (let i = 0; i < writes.length; i++) {
+        for (let j = i + 1; j < writes.length; j++) {
+            const a = writes[i];
+            const b = writes[j];
+            if (a.stepId === b.stepId)
+                continue;
+            const shared = Math.min(a.segments.length, b.segments.length);
+            if (!a.segments.slice(0, shared).every((part, index) => part === b.segments[index]))
+                continue;
+            conflicts.push({
+                pathA: a.path, stepA: a.stepId, pathB: b.path, stepB: b.stepId,
+                kind: a.segments.length === b.segments.length ? 'exact' : 'ancestor-descendant',
+            });
+        }
+    }
+    return conflicts;
+}
+/** A declared read of a concurrently runnable sibling needs an explicit dependency. */
+export function parallelUndeclaredReads(steps) {
+    const reads = [];
+    for (const step of steps) {
+        const paths = [
+            ...Object.values(step.inputMapping ?? {}),
+            step.condition?.path,
+            step.skipCondition?.path,
+        ].filter((path) => typeof path === 'string');
+        for (const sourcePath of paths) {
+            for (const sibling of steps) {
+                if (sibling.id === step.id)
+                    continue;
+                if (sourcePath === 'results') {
+                    reads.push({ stepId: step.id, sourcePath, otherStepId: sibling.id });
+                    continue;
+                }
+                if (!sourcePath.startsWith('results.'))
+                    continue;
+                const readSegments = sourcePath.slice('results.'.length).split('.');
+                const readsSiblingWrite = parallelWritePaths(sibling).some(write => {
+                    const shared = Math.min(readSegments.length, write.segments.length);
+                    return write.segments.slice(0, shared).every((segment, index) => segment === readSegments[index]);
+                });
+                if (readsSiblingWrite) {
+                    reads.push({ stepId: step.id, sourcePath, otherStepId: sibling.id });
+                }
+            }
+        }
+    }
+    return reads;
+}
+/** Canonical, cycle-detecting representation of structured-cloneable values. */
+function canonical(value, ancestors) {
+    if (value === null || typeof value === 'string' || typeof value === 'boolean')
+        return value;
+    if (typeof value === 'number')
+        return ['number', String(value)];
+    if (typeof value === 'bigint')
+        return ['bigint', String(value)];
+    if (value === undefined)
+        return ['undefined'];
+    if (typeof value !== 'object')
+        throw new Error('parallel_output_unhashable');
+    if (ancestors.has(value))
+        throw new Error('parallel_output_cyclic');
+    ancestors.add(value);
+    try {
+        if (value instanceof Date)
+            return ['date', value.toISOString()];
+        if (value instanceof ArrayBuffer)
+            return ['bytes', Buffer.from(value).toString('base64')];
+        if (ArrayBuffer.isView(value)) {
+            return ['bytes', value.constructor.name, Buffer.from(value.buffer, value.byteOffset, value.byteLength).toString('base64')];
+        }
+        if (Array.isArray(value))
+            return ['array', value.map(item => canonical(item, ancestors))];
+        if (value instanceof Set) {
+            const entries = [...value].map(item => canonical(item, ancestors));
+            return ['set', entries.sort((a, b) => JSON.stringify(a).localeCompare(JSON.stringify(b)))];
+        }
+        if (value instanceof Map) {
+            const entries = [...value].map(([key, item]) => [canonical(key, ancestors), canonical(item, ancestors)]);
+            return ['map', entries.sort((a, b) => JSON.stringify(a).localeCompare(JSON.stringify(b)))];
+        }
+        const record = value;
+        return ['object', Object.keys(record).sort().map(key => [key, canonical(record[key], ancestors)])];
+    }
+    finally {
+        ancestors.delete(value);
+    }
+}
+export function hashWorkflowValue(value) {
+    const payload = JSON.stringify(canonical(value, new Set()));
+    return createHash('sha256').update(payload).digest('hex');
+}
+//# sourceMappingURL=workflow-composition.js.map

package/dist/coordination/workflow-orchestrator.d.ts

@@ -10,7 +10,7 @@
 import { Result, DomainName } from '../shared/types/index.js';
 import { EventBus, MemoryBackend, AgentCoordinator } from '../kernel/interfaces.js';
 import type { BehaviorNode } from './behavior-tree/nodes.js';
-export type { StepExecutionMode, StepStatus, WorkflowStatus, ConditionOperator, StepCondition, WorkflowStepDefinition, WorkflowDefinition, WorkflowTrigger, StepExecutionResult, WorkflowContext, WorkflowExecutionStatus, WorkflowListItem, WorkflowStartedPayload, WorkflowCompletedPayload, WorkflowFailedPayload, StepEventPayload, StepAwaitingApprovalPayload, IWorkflowOrchestrator, DomainAction, DomainActionRegistry, WorkflowOrchestratorConfig, } from './workflow-types.js';
+export type { StepExecutionMode, StepStatus, WorkflowStatus, ConditionOperator, StepCondition, WorkflowStepDefinition, WorkflowDefinition, WorkflowTrigger, StepExecutionResult, ParallelCompositionReceipt, WorkflowContext, WorkflowExecutionStatus, WorkflowListItem, WorkflowStartedPayload, WorkflowCompletedPayload, WorkflowFailedPayload, StepEventPayload, StepAwaitingApprovalPayload, IWorkflowOrchestrator, DomainAction, DomainActionRegistry, WorkflowOrchestratorConfig, } from './workflow-types.js';
 export { WorkflowEvents, DEFAULT_WORKFLOW_CONFIG, } from './workflow-types.js';
 import type { WorkflowDefinition, WorkflowExecutionStatus, WorkflowListItem, IWorkflowOrchestrator, DomainAction, WorkflowOrchestratorConfig } from './workflow-types.js';
 export declare class WorkflowOrchestrator implements IWorkflowOrchestrator {
@@ -93,8 +93,9 @@ export declare class WorkflowOrchestrator implements IWorkflowOrchestrator {
     private loadPersistedWorkflows;
     private persistWorkflows;
     private persistExecution;
+    private closeApprovalGates;
     /**
-     * Wait for external approval (or auto-approve after timeout).
+     * Wait for external approval. An unanswered gate expires without approval.
      * Returns an object with approved status and optional rejection reason.
      */
     private waitForApproval;