agentic-orchestrator 0.1.28 → 0.2.0

package/apps/control-plane/test/collision-command-handler.spec.ts

@@ -0,0 +1,182 @@
+import { describe, expect, it, vi } from 'vitest';
+import { CollisionCommandHandler } from '../src/cli/collision-command-handler.js';
+import { ERROR_CODES } from '../src/core/error-codes.js';
+
+function makeHandler(overrides: Record<string, unknown> = {}) {
+  const kernel = {
+    collisionOverrideAllow: vi.fn(async () => ({
+      override_id: 'colovr_1',
+      feature_ids: ['feature_a', 'feature_b'],
+      collision_fingerprint: 'fp_1',
+      approved_paths: ['src/shared.ts'],
+      resumed: true,
+    })),
+    collisionOverrideList: vi.fn(async () => [
+      {
+        override_id: 'colovr_1',
+        feature_ids: ['feature_a', 'feature_b'],
+        status: 'active',
+      },
+    ]),
+    collisionOverrideRevoke: vi.fn(async () => ({
+      override_id: 'colovr_1',
+      status: 'revoked',
+    })),
+    ...overrides,
+  };
+
+  return {
+    kernel,
+    handler: new CollisionCommandHandler(kernel as never, 'run:test'),
+  };
+}
+
+describe('CollisionCommandHandler', () => {
+  it('routes --allow to the kernel and returns structured output', async () => {
+    const { handler, kernel } = makeHandler();
+
+    const result = await handler.execute({
+      command: 'collision',
+      allow: true,
+      feature_id: 'feature_a',
+      with_feature_id: 'feature_b',
+      reason: 'intentional overlap',
+      resume_after_collision_override: true,
+    });
+
+    expect(kernel.collisionOverrideAllow).toHaveBeenCalledWith(
+      'feature_a',
+      'feature_b',
+      'intentional overlap',
+      true,
+      'run:test',
+    );
+    expect(result).toMatchObject({
+      ok: true,
+      data: {
+        command: 'collision',
+        action: 'allow',
+        override_id: 'colovr_1',
+      },
+    });
+  });
+
+  it('routes --list to the kernel and supports an optional feature filter', async () => {
+    const { handler, kernel } = makeHandler();
+
+    const result = await handler.execute({
+      command: 'collision',
+      list: true,
+      feature_id: 'feature_a',
+    });
+
+    expect(kernel.collisionOverrideList).toHaveBeenCalledWith('feature_a');
+    expect(result).toMatchObject({
+      ok: true,
+      data: {
+        command: 'collision',
+        action: 'list',
+        overrides: [{ override_id: 'colovr_1' }],
+      },
+    });
+  });
+
+  it('routes --revoke to the kernel', async () => {
+    const { handler, kernel } = makeHandler();
+
+    const result = await handler.execute({
+      command: 'collision',
+      revoke: true,
+      override_id: 'colovr_1',
+    });
+
+    expect(kernel.collisionOverrideRevoke).toHaveBeenCalledWith('colovr_1', 'run:test');
+    expect(result).toMatchObject({
+      ok: true,
+      data: {
+        command: 'collision',
+        action: 'revoke',
+        override: { override_id: 'colovr_1', status: 'revoked' },
+      },
+    });
+  });
+
+  it('rejects invalid action combinations', async () => {
+    const { handler } = makeHandler();
+
+    await expect(
+      handler.execute({
+        command: 'collision',
+        allow: true,
+        list: true,
+      }),
+    ).rejects.toMatchObject({
+      code: ERROR_CODES.INVALID_CLI_ARGS,
+      details: expect.objectContaining({
+        reason: 'Exactly one of --allow, --list, or --revoke is required',
+      }),
+    });
+  });
+
+  it('rejects malformed allow requests and invalid feature ids', async () => {
+    const { handler } = makeHandler();
+
+    await expect(
+      handler.execute({
+        command: 'collision',
+        allow: true,
+        feature_id: 'feature_a',
+        with_feature_id: 'feature_b',
+      }),
+    ).rejects.toMatchObject({
+      code: ERROR_CODES.INVALID_CLI_ARGS,
+      details: expect.objectContaining({
+        reason: '--allow requires --feature-id, --with-feature-id, and --reason',
+      }),
+    });
+
+    await expect(
+      handler.execute({
+        command: 'collision',
+        allow: true,
+        feature_id: 'Feature A',
+        with_feature_id: 'feature_b',
+        reason: 'intentional overlap',
+      }),
+    ).rejects.toMatchObject({
+      code: ERROR_CODES.INVALID_CLI_ARGS,
+      details: expect.objectContaining({
+        reason: 'Invalid feature id for collision override',
+      }),
+    });
+  });
+
+  it('rejects invalid list filters and missing revoke ids', async () => {
+    const { handler } = makeHandler();
+
+    await expect(
+      handler.execute({
+        command: 'collision',
+        list: true,
+        feature_id: 'Feature A',
+      }),
+    ).rejects.toMatchObject({
+      code: ERROR_CODES.INVALID_CLI_ARGS,
+      details: expect.objectContaining({
+        reason: 'Invalid --feature-id value',
+      }),
+    });
+
+    await expect(
+      handler.execute({
+        command: 'collision',
+        revoke: true,
+      }),
+    ).rejects.toMatchObject({
+      code: ERROR_CODES.INVALID_CLI_ARGS,
+      details: expect.objectContaining({
+        reason: '--revoke requires --override-id',
+      }),
+    });
+  });
+});