agentic-orchestrator 0.1.2 → 0.1.4

package/apps/control-plane/test/instance-isolation.spec.ts

@@ -0,0 +1,83 @@
+import path from 'node:path';
+import { describe, it, expect, beforeEach } from 'vitest';
+import { AopKernel } from '../src/index.js';
+import { AopPathLayout } from '../src/core/path-layout.js';
+import { computeInstanceId, defaultConfigPath } from '../src/application/services/instance-isolation-service.js';
+import { makeTempRepo } from './helpers.js';
+import type { RuntimeSessionsSnapshot } from '../src/core/runtime-sessions.js';
+
+let repoRoot: string;
+
+beforeEach(async () => {
+  repoRoot = await makeTempRepo(process.cwd());
+});
+
+describe('G11: Hash-Based Multi-Instance Isolation', () => {
+  describe('computeInstanceId', () => {
+    it('returns a 12-character hex string', () => {
+      const id = computeInstanceId('/some/path/to/policy.yaml');
+      expect(id).toMatch(/^[0-9a-f]{12}$/);
+    });
+
+    it('is deterministic for the same input', () => {
+      const path1 = '/workspace/project-a/agentic/orchestrator/policy.yaml';
+      expect(computeInstanceId(path1)).toBe(computeInstanceId(path1));
+    });
+
+    it('produces different IDs for different paths', () => {
+      const idA = computeInstanceId('/workspace/project-a/agentic/orchestrator/policy.yaml');
+      const idB = computeInstanceId('/workspace/project-b/agentic/orchestrator/policy.yaml');
+      expect(idA).not.toBe(idB);
+    });
+  });
+
+  describe('defaultConfigPath', () => {
+    it('returns path under repo root', () => {
+      const cp = defaultConfigPath('/workspace/my-repo');
+      expect(cp).toBe('/workspace/my-repo/agentic/orchestrator/policy.yaml');
+    });
+  });
+
+  describe('Kernel run-lease isolation', () => {
+    it('two kernels with different instanceIds write to different run-lease files', async () => {
+      const kernelA = new AopKernel(repoRoot, 'instance-aaa');
+      const kernelB = new AopKernel(repoRoot, 'instance-bbb');
+      await kernelA.ensureLoaded();
+      await kernelB.ensureLoaded();
+
+      const base: RuntimeSessionsSnapshot = {
+        run_id: 'run:base', orchestrator_session_id: 'unknown', provider: 'null', model: 'null', provider_config_ref_hash: 'x', owner_instance_id: 'none', lease_id: 'none', started_at: new Date().toISOString(), last_heartbeat_at: new Date().toISOString(), lease_expires_at: new Date(Date.now() + 60000).toISOString(), orchestrator_epoch: 0, feature_sessions: {}
+      };
+      const leaseA: RuntimeSessionsSnapshot = { ...base, run_id: 'run:aaa', owner_instance_id: 'owner:aaa' };
+      const leaseB: RuntimeSessionsSnapshot = { ...base, run_id: 'run:bbb', owner_instance_id: 'owner:bbb' };
+
+      await kernelA.writeRunLease(leaseA);
+      await kernelB.writeRunLease(leaseB);
+
+      const readA = await kernelA.readRunLease();
+      const readB = await kernelB.readRunLease();
+
+      expect(readA.run_id).toBe('run:aaa');
+      expect(readB.run_id).toBe('run:bbb');
+    });
+
+    it('run-lease file path is namespaced under instanceId directory', () => {
+      const layout = new AopPathLayout(repoRoot);
+      expect(layout.runLeaseFilePath('abc123')).toBe(
+        path.join(repoRoot, '.aop', 'runtime', 'abc123', 'run-lease.json')
+      );
+    });
+
+    it('kernel with default instanceId reads/writes .aop/runtime/default/run-lease.json', async () => {
+      const kernel = new AopKernel(repoRoot);
+      await kernel.ensureLoaded();
+      const base: RuntimeSessionsSnapshot = {
+        run_id: 'run:base', orchestrator_session_id: 'unknown', provider: 'null', model: 'null', provider_config_ref_hash: 'x', owner_instance_id: 'none', lease_id: 'none', started_at: new Date().toISOString(), last_heartbeat_at: new Date().toISOString(), lease_expires_at: new Date(Date.now() + 60000).toISOString(), orchestrator_epoch: 0, feature_sessions: {}
+      };
+      const lease: RuntimeSessionsSnapshot = { ...base, run_id: 'run:default-test' };
+      await kernel.writeRunLease(lease);
+      const read = await kernel.readRunLease();
+      expect(read.run_id).toBe('run:default-test');
+    });
+  });
+});