agentic-mermaid 0.1.1 → 0.1.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (336) hide show
  1. package/CHANGELOG.md +144 -4
  2. package/LICENSES/Apache-2.0.txt +202 -0
  3. package/README.md +25 -32
  4. package/THIRD_PARTY_NOTICES.md +29 -0
  5. package/dist/agent-core.d.ts +463 -0
  6. package/dist/agent-core.js +397 -0
  7. package/dist/agent.d.ts +73 -1868
  8. package/dist/agent.js +336 -37325
  9. package/dist/agentic-mermaid-mcp.js +7 -38399
  10. package/dist/am.js +33632 -40445
  11. package/dist/chunk-4QECACIA.js +4702 -0
  12. package/dist/chunk-CDPKJ2BQ.js +37 -0
  13. package/dist/chunk-QKDLMOJJ.js +3487 -0
  14. package/dist/chunk-WI35L7IR.js +615 -0
  15. package/dist/chunk-WN3YDOBG.js +149 -0
  16. package/dist/chunk-ZYMMKQ3I.js +62637 -0
  17. package/dist/index-D54dqSdC.d.ts +6777 -0
  18. package/dist/index.d.ts +1 -1
  19. package/dist/index.js +310 -33014
  20. package/dist/mcp-cli-SBQSTJFC.js +17 -0
  21. package/docs/README.md +14 -6
  22. package/docs/schemas/style-spec.schema.json +1221 -30
  23. package/examples/styles/catalog.json +54 -0
  24. package/examples/styles/cloudflare-workers-inspired-prototype.mmd +9 -0
  25. package/examples/styles/cloudflare-workers-inspired-prototype.style.json +110 -0
  26. package/examples/styles/cupertino-prototype.mmd +10 -0
  27. package/examples/styles/cupertino-prototype.style.json +63 -0
  28. package/examples/styles/mid-century-report.style.json +2 -2
  29. package/examples/styles/star-chart-atlas.style.json +2 -1
  30. package/examples/styles/transit-route-map.style.json +2 -2
  31. package/examples/styles/vercel-inspired-prototype.mmd +6 -0
  32. package/examples/styles/vercel-inspired-prototype.style.json +87 -0
  33. package/package.json +68 -43
  34. package/server.json +2 -2
  35. package/skills/agentic-mermaid-diagram-workflow/SKILL.md +17 -36
  36. package/skills/agentic-mermaid-diagram-workflow/references/cli.md +4 -5
  37. package/skills/agentic-mermaid-diagram-workflow/references/code-mode.md +15 -31
  38. package/skills/agentic-mermaid-diagram-workflow/references/sequence.md +10 -14
  39. package/skills/agentic-mermaid-live-editor/SKILL.md +100 -206
  40. package/AGENT_NATIVE.md +0 -607
  41. package/Instructions_for_agents.md +0 -89
  42. package/TODO.md +0 -684
  43. package/assets/hero.png +0 -0
  44. package/dist/index-wjRjbsP-.d.ts +0 -1102
  45. package/docs/agent-api-cookbook.md +0 -308
  46. package/docs/agent-mutation-policy.md +0 -104
  47. package/docs/agent-workflow-examples.md +0 -46
  48. package/docs/api.md +0 -211
  49. package/docs/ascii.md +0 -103
  50. package/docs/assets/improvements/box-start-connector.png +0 -0
  51. package/docs/assets/improvements/comment-dropped-lint.png +0 -0
  52. package/docs/assets/improvements/er-content-loss.png +0 -0
  53. package/docs/assets/improvements/fan-in-trunks.png +0 -0
  54. package/docs/assets/improvements/gantt-family.png +0 -0
  55. package/docs/assets/improvements/gantt-milestone-clamp.png +0 -0
  56. package/docs/assets/improvements/gantt-verify-seam.png +0 -0
  57. package/docs/assets/improvements/subgraph-container-edges.png +0 -0
  58. package/docs/assets/improvements/wrapper-frontmatter.png +0 -0
  59. package/docs/assets/improvements/wrapper-init-directive.png +0 -0
  60. package/docs/assets/improvements/wrapper-leading-comment.png +0 -0
  61. package/docs/assets/style-cookbook/mid-century-report.png +0 -0
  62. package/docs/assets/style-cookbook/star-chart-atlas.png +0 -0
  63. package/docs/assets/style-cookbook/transit-route-map.png +0 -0
  64. package/docs/comparison.md +0 -94
  65. package/docs/config.md +0 -105
  66. package/docs/contributing/adding-diagram-types.md +0 -144
  67. package/docs/contributing/diagram-family-citizenship.matrix.json +0 -2127
  68. package/docs/contributing/diagram-family-citizenship.md +0 -82
  69. package/docs/contributing/harvesting-upstream-tests.md +0 -126
  70. package/docs/contributing/lessons-learned.md +0 -276
  71. package/docs/contributing/releasing.md +0 -82
  72. package/docs/contributing/visual-review-evidence.md +0 -53
  73. package/docs/custom-style-cookbook.md +0 -154
  74. package/docs/design/families/README.md +0 -26
  75. package/docs/design/families/architecture-beta.md +0 -48
  76. package/docs/design/families/flowchart-parser-conformance.md +0 -22
  77. package/docs/design/families/gantt-research.md +0 -137
  78. package/docs/design/families/gantt.md +0 -329
  79. package/docs/design/families/journey-agentic-cards-before.png +0 -0
  80. package/docs/design/families/journey-experience-curve-implementation.png +0 -0
  81. package/docs/design/families/journey-mermaid-classic-implementation.png +0 -0
  82. package/docs/design/families/journey-mermaid-classic-prototype.png +0 -0
  83. package/docs/design/families/journey-mermaid-classic-prototype.svg +0 -163
  84. package/docs/design/families/journey-mermaid-classic-prototype.svg.png +0 -0
  85. package/docs/design/families/journey-migration-parity.md +0 -439
  86. package/docs/design/families/journey-section-overlap-after.png +0 -0
  87. package/docs/design/families/journey-section-overlap-before.png +0 -0
  88. package/docs/design/families/journey-usage-research.md +0 -423
  89. package/docs/design/families/journey.md +0 -153
  90. package/docs/design/families/xychart.md +0 -85
  91. package/docs/design/system/README.md +0 -45
  92. package/docs/design/system/abstraction-audit.md +0 -224
  93. package/docs/design/system/abstraction-recommendations.md +0 -655
  94. package/docs/design/system/architecture.mmd +0 -29
  95. package/docs/design/system/architecture.svg +0 -137
  96. package/docs/design/system/layout-guarantees-and-robustness.md +0 -351
  97. package/docs/design/system/layout-rubric.md +0 -138
  98. package/docs/design/system/route-contracts.md +0 -848
  99. package/docs/design/system/source-preservation-ladder.md +0 -52
  100. package/docs/design/system/styles-rollout.md +0 -216
  101. package/docs/design/system/ugly-layouts.md +0 -119
  102. package/docs/diagram-families.md +0 -193
  103. package/docs/features.md +0 -147
  104. package/docs/fork-differences.md +0 -130
  105. package/docs/getting-started.md +0 -175
  106. package/docs/issue-derived-test-cases.md +0 -156
  107. package/docs/layout-characterization/README.md +0 -245
  108. package/docs/layout-characterization/contact-sheet-families.md +0 -498
  109. package/docs/layout-characterization/contact-sheet.md +0 -638
  110. package/docs/layout-characterization/properties.md +0 -281
  111. package/docs/layout-characterization/visual-quality.md +0 -160
  112. package/docs/layout-characterization/visual-snapshots/architecture.svg +0 -79
  113. package/docs/layout-characterization/visual-snapshots/class.svg +0 -60
  114. package/docs/layout-characterization/visual-snapshots/er.svg +0 -61
  115. package/docs/layout-characterization/visual-snapshots/flowchart.svg +0 -58
  116. package/docs/layout-characterization/visual-snapshots/gantt.svg +0 -52
  117. package/docs/layout-characterization/visual-snapshots/journey.svg +0 -98
  118. package/docs/layout-characterization/visual-snapshots/pie.svg +0 -36
  119. package/docs/layout-characterization/visual-snapshots/quadrant.svg +0 -47
  120. package/docs/layout-characterization/visual-snapshots/sequence.svg +0 -59
  121. package/docs/layout-characterization/visual-snapshots/state.svg +0 -52
  122. package/docs/layout-characterization/visual-snapshots/timeline.svg +0 -64
  123. package/docs/layout-characterization/visual-snapshots/xychart.svg +0 -97
  124. package/docs/mcp-code-mode-rationale.md +0 -101
  125. package/docs/mcp-http-transport.md +0 -223
  126. package/docs/mermaid-layout-complaints.md +0 -837
  127. package/docs/mutation-testing.md +0 -206
  128. package/docs/project/divergences.md +0 -98
  129. package/docs/project/dogfooding-docs-strategy.md +0 -66
  130. package/docs/project/hosted-mcp-cloudflare-plan.md +0 -338
  131. package/docs/project/lessons-learned.md +0 -1019
  132. package/docs/project/remove-role-styling-plan.md +0 -176
  133. package/docs/quality.md +0 -215
  134. package/docs/react.md +0 -97
  135. package/docs/style-authoring.md +0 -133
  136. package/docs/testing-strategy.md +0 -335
  137. package/docs/theming.md +0 -162
  138. package/examples/agent-improve-auth-flow.ts +0 -206
  139. package/examples/agent-loop.ts +0 -53
  140. package/examples/mcp-vs-cli-complex-diagrams.ts +0 -133
  141. package/llms.txt +0 -104
  142. package/skill-evals/README.md +0 -77
  143. package/skill-evals/fixtures/architecture-cache/input.mmd +0 -5
  144. package/skill-evals/fixtures/class-payment/input.mmd +0 -4
  145. package/skill-evals/fixtures/er-orders/input.mmd +0 -10
  146. package/skill-evals/fixtures/flowchart-cache/input.mmd +0 -3
  147. package/skill-evals/fixtures/gantt-release/input.mmd +0 -7
  148. package/skill-evals/fixtures/journey-checkout/input.mmd +0 -6
  149. package/skill-evals/fixtures/pie-exports/input.mmd +0 -5
  150. package/skill-evals/fixtures/quadrant-priorities/input.mmd +0 -11
  151. package/skill-evals/fixtures/sequence-retry/input.mmd +0 -8
  152. package/skill-evals/fixtures/state-lifecycle/input.mmd +0 -5
  153. package/skill-evals/fixtures/timeline-release/input.mmd +0 -6
  154. package/skill-evals/fixtures/xychart-growth/input.mmd +0 -5
  155. package/skill-evals/shared-benchmark.json +0 -510
  156. package/src/agent/analyze.ts +0 -157
  157. package/src/agent/apply.ts +0 -146
  158. package/src/agent/architecture-body.ts +0 -458
  159. package/src/agent/certificates.ts +0 -110
  160. package/src/agent/class-body.ts +0 -319
  161. package/src/agent/core.ts +0 -207
  162. package/src/agent/create.ts +0 -106
  163. package/src/agent/describe.ts +0 -368
  164. package/src/agent/er-body.ts +0 -224
  165. package/src/agent/facts.ts +0 -360
  166. package/src/agent/families-builtin.ts +0 -920
  167. package/src/agent/families.ts +0 -232
  168. package/src/agent/family-layouts.ts +0 -832
  169. package/src/agent/flowchart-body.ts +0 -372
  170. package/src/agent/flowchart-unsupported.ts +0 -243
  171. package/src/agent/font-coverage.ts +0 -288
  172. package/src/agent/gantt-body.ts +0 -495
  173. package/src/agent/index.ts +0 -10
  174. package/src/agent/journey-body.ts +0 -374
  175. package/src/agent/label-metrics.ts +0 -28
  176. package/src/agent/layout-to-rendered.ts +0 -63
  177. package/src/agent/mutate.ts +0 -97
  178. package/src/agent/mutation-ops.ts +0 -51
  179. package/src/agent/op-schema.ts +0 -443
  180. package/src/agent/parse.ts +0 -223
  181. package/src/agent/pie-body.ts +0 -270
  182. package/src/agent/png.ts +0 -171
  183. package/src/agent/quadrant-body.ts +0 -336
  184. package/src/agent/quality.ts +0 -363
  185. package/src/agent/readability-audit.ts +0 -92
  186. package/src/agent/rendered-route-audit.ts +0 -61
  187. package/src/agent/sequence-body.ts +0 -345
  188. package/src/agent/serialize.ts +0 -214
  189. package/src/agent/state-body.ts +0 -589
  190. package/src/agent/structural-count.ts +0 -150
  191. package/src/agent/timeline-body.ts +0 -280
  192. package/src/agent/trace-log.ts +0 -43
  193. package/src/agent/types.ts +0 -995
  194. package/src/agent/verify.ts +0 -603
  195. package/src/agent/xychart-body.ts +0 -472
  196. package/src/architecture/config.ts +0 -282
  197. package/src/architecture/layout.ts +0 -496
  198. package/src/architecture/parser.ts +0 -375
  199. package/src/architecture/renderer.ts +0 -611
  200. package/src/architecture/types.ts +0 -113
  201. package/src/ascii/ansi.ts +0 -423
  202. package/src/ascii/architecture.ts +0 -210
  203. package/src/ascii/canvas.ts +0 -443
  204. package/src/ascii/class-diagram.ts +0 -697
  205. package/src/ascii/converter.ts +0 -475
  206. package/src/ascii/draw.ts +0 -1693
  207. package/src/ascii/edge-bundling.ts +0 -328
  208. package/src/ascii/edge-routing.ts +0 -330
  209. package/src/ascii/er-diagram.ts +0 -439
  210. package/src/ascii/gantt.ts +0 -276
  211. package/src/ascii/grid.ts +0 -747
  212. package/src/ascii/index.ts +0 -196
  213. package/src/ascii/journey.ts +0 -169
  214. package/src/ascii/meta.ts +0 -244
  215. package/src/ascii/multiline-utils.ts +0 -80
  216. package/src/ascii/pathfinder.ts +0 -301
  217. package/src/ascii/pie.ts +0 -67
  218. package/src/ascii/quadrant.ts +0 -158
  219. package/src/ascii/reverse.ts +0 -216
  220. package/src/ascii/sequence.ts +0 -499
  221. package/src/ascii/shapes/circle.ts +0 -27
  222. package/src/ascii/shapes/corners.ts +0 -143
  223. package/src/ascii/shapes/diamond.ts +0 -27
  224. package/src/ascii/shapes/hexagon.ts +0 -27
  225. package/src/ascii/shapes/index.ts +0 -106
  226. package/src/ascii/shapes/rectangle.ts +0 -168
  227. package/src/ascii/shapes/rounded.ts +0 -27
  228. package/src/ascii/shapes/special.ts +0 -332
  229. package/src/ascii/shapes/stadium.ts +0 -110
  230. package/src/ascii/shapes/state.ts +0 -192
  231. package/src/ascii/shapes/types.ts +0 -73
  232. package/src/ascii/timeline.ts +0 -141
  233. package/src/ascii/types.ts +0 -312
  234. package/src/ascii/validate.ts +0 -120
  235. package/src/ascii/width.ts +0 -81
  236. package/src/ascii/wrap.ts +0 -131
  237. package/src/ascii/xychart.ts +0 -919
  238. package/src/browser.ts +0 -29
  239. package/src/class/layout.ts +0 -240
  240. package/src/class/parser.ts +0 -332
  241. package/src/class/renderer.ts +0 -638
  242. package/src/class/types.ts +0 -129
  243. package/src/cli/agent-instructions.ts +0 -1
  244. package/src/cli/am-bin.ts +0 -6
  245. package/src/cli/exit-codes.ts +0 -18
  246. package/src/cli/index.ts +0 -1132
  247. package/src/cli/init-agent.ts +0 -147
  248. package/src/cli/run-entrypoint.ts +0 -10
  249. package/src/color-resolver.ts +0 -152
  250. package/src/elk-instance.ts +0 -114
  251. package/src/er/layout.ts +0 -187
  252. package/src/er/parser.ts +0 -226
  253. package/src/er/renderer.ts +0 -792
  254. package/src/er/types.ts +0 -99
  255. package/src/family-rubric.ts +0 -425
  256. package/src/font-manifest.ts +0 -31
  257. package/src/gantt/layout.ts +0 -365
  258. package/src/gantt/parser.ts +0 -282
  259. package/src/gantt/pipeline.ts +0 -27
  260. package/src/gantt/renderer.ts +0 -414
  261. package/src/gantt/schedule.ts +0 -513
  262. package/src/gantt/types.ts +0 -255
  263. package/src/index.ts +0 -368
  264. package/src/journey/layout.ts +0 -554
  265. package/src/journey/parse-core.ts +0 -251
  266. package/src/journey/parser.ts +0 -101
  267. package/src/journey/renderer.ts +0 -917
  268. package/src/journey/types.ts +0 -144
  269. package/src/layout/geometry.ts +0 -182
  270. package/src/layout/pass.ts +0 -142
  271. package/src/layout/passes/index.ts +0 -3916
  272. package/src/layout-engine.ts +0 -1565
  273. package/src/layout-rubric.ts +0 -659
  274. package/src/mcp/artifacts.ts +0 -137
  275. package/src/mcp/dynamic-harness.ts +0 -31
  276. package/src/mcp/dynamic-modules.d.ts +0 -7
  277. package/src/mcp/facade.ts +0 -608
  278. package/src/mcp/harness-runtime.ts +0 -203
  279. package/src/mcp/hosted-server.ts +0 -468
  280. package/src/mcp/mcp-bin.ts +0 -3
  281. package/src/mcp/mcp-cli.ts +0 -82
  282. package/src/mcp/protocol.ts +0 -13
  283. package/src/mcp/sandbox.ts +0 -195
  284. package/src/mcp/sdk-decl.ts +0 -391
  285. package/src/mcp/server.ts +0 -362
  286. package/src/mcp/tool-surface.ts +0 -146
  287. package/src/mermaid-source.ts +0 -655
  288. package/src/multiline-utils.ts +0 -228
  289. package/src/parser.ts +0 -1031
  290. package/src/pie/layout.ts +0 -168
  291. package/src/pie/parser.ts +0 -136
  292. package/src/pie/renderer.ts +0 -234
  293. package/src/pie/types.ts +0 -82
  294. package/src/quadrant/layout.ts +0 -191
  295. package/src/quadrant/parser.ts +0 -183
  296. package/src/quadrant/renderer.ts +0 -322
  297. package/src/quadrant/types.ts +0 -113
  298. package/src/render-family-hooks.ts +0 -244
  299. package/src/renderer.ts +0 -1099
  300. package/src/route-contracts.ts +0 -2723
  301. package/src/scene/backend.ts +0 -76
  302. package/src/scene/fidelity.ts +0 -183
  303. package/src/scene/hybrid-backend.ts +0 -174
  304. package/src/scene/ir.ts +0 -181
  305. package/src/scene/marks.ts +0 -127
  306. package/src/scene/rough-backend.ts +0 -378
  307. package/src/scene/seed.ts +0 -46
  308. package/src/scene/style-registry.ts +0 -556
  309. package/src/sequence/layout.ts +0 -456
  310. package/src/sequence/parser.ts +0 -255
  311. package/src/sequence/renderer.ts +0 -604
  312. package/src/sequence/types.ts +0 -154
  313. package/src/shape-clipping.ts +0 -351
  314. package/src/shared/accessibility-directives.ts +0 -22
  315. package/src/shared/batched.ts +0 -61
  316. package/src/shared/color-math.ts +0 -93
  317. package/src/shared/svg-a11y.ts +0 -29
  318. package/src/shared/syntax-error.ts +0 -17
  319. package/src/shared/unicode-ranges.ts +0 -135
  320. package/src/styles.ts +0 -318
  321. package/src/svg-paths.ts +0 -28
  322. package/src/text-metrics.ts +0 -248
  323. package/src/theme.ts +0 -710
  324. package/src/timeline/layout.ts +0 -381
  325. package/src/timeline/parser.ts +0 -215
  326. package/src/timeline/renderer.ts +0 -538
  327. package/src/timeline/types.ts +0 -105
  328. package/src/types.ts +0 -462
  329. package/src/website-worker-modules.d.ts +0 -18
  330. package/src/xychart/axis-utils.ts +0 -109
  331. package/src/xychart/colors.ts +0 -124
  332. package/src/xychart/config.ts +0 -88
  333. package/src/xychart/layout.ts +0 -656
  334. package/src/xychart/parser.ts +0 -504
  335. package/src/xychart/renderer.ts +0 -640
  336. package/src/xychart/types.ts +0 -282
@@ -1,363 +0,0 @@
1
- // ============================================================================
2
- // Perceptual quality metrics for rendered diagrams.
3
- //
4
- // Deterministic, layout-derived metrics — meant for CI gating. The numeric
5
- // results are stable across runs because they depend only on the ELK layout
6
- // (which is itself deterministic, see AGENT_NATIVE.md § determinism).
7
- //
8
- // What's measured:
9
- // - edgeCrossings: number of pairwise edge-segment intersections (excluding
10
- // shared endpoints). Lower is better.
11
- // - labelLegibility: fraction of node labels whose rendered length fits the
12
- // node's width at a 12px font baseline.
13
- // - whitespaceBalance: ratio of node-occupied area to total canvas area
14
- // (0..1). Targets a band — too dense AND too sparse both lose points.
15
- // - labelEdgeProximity: min pixel distance between any edge-label bbox and
16
- // the nearest non-attached node bbox, other edge-label bbox, or non-own
17
- // edge path. Lower means labels overlap nodes, edges, or each other.
18
- // - aspectRatio: canvas width/height. Used as a sanity check, not a gate.
19
- // ============================================================================
20
-
21
- import type { RenderedLayout, RenderedLayoutNode, RenderedLayoutEdge } from './types.ts'
22
- import { measureMultilineText } from '../text-metrics.ts'
23
- import { FONT_SIZES, FONT_WEIGHTS } from '../styles.ts'
24
-
25
- export interface QualityMetrics {
26
- edgeCrossings: number
27
- labelLegibility: number // 0..1 — fraction of labels that fit
28
- whitespaceBalance: number // 0..1 — fill ratio
29
- labelEdgeProximity: number // pixels; Infinity if no edge labels
30
- aspectRatio: number // w/h; Infinity if h=0
31
- nodeCount: number
32
- edgeCount: number
33
- }
34
-
35
- export interface QualityBounds {
36
- /** Max edge crossings per (edge × edge) pair. Default 0.05 = 5%. */
37
- maxCrossingsRatio?: number
38
- /** Min label legibility. Default 0.85 = 85% of labels fit. */
39
- minLabelLegibility?: number
40
- /** Whitespace fill band [min, max]. Default [0.05, 0.55]. */
41
- whitespaceBand?: [number, number]
42
- /** Min pixels between any edge-label bbox and a non-attached node, another edge-label, or another edge path. Default 4. */
43
- minLabelEdgeProximity?: number
44
- /** Aspect ratio band [min, max]. Default [0.2, 5.0]. */
45
- aspectBand?: [number, number]
46
- }
47
-
48
- export const DEFAULT_BOUNDS: Required<QualityBounds> = {
49
- maxCrossingsRatio: 0.05,
50
- minLabelLegibility: 0.85,
51
- whitespaceBand: [0.05, 0.55],
52
- minLabelEdgeProximity: 4,
53
- aspectBand: [0.2, 5.0],
54
- }
55
-
56
- // ---- provenance + severity -------------------------------------------------
57
- //
58
- // The bands above are a mix of evidence-backed and chosen thresholds, and
59
- // pretending they are equally well-founded is dishonest (quality.md: "we do
60
- // not claim our metrics match a human designer's eye"). The graph-drawing
61
- // aesthetics literature — Purchase, "Which Aesthetic Has the Greatest Effect
62
- // on Human Understanding?" (GD 1997) and "Metrics for Graph Drawing
63
- // Aesthetics" (JVLC 2002) — measured, with human subjects, that minimizing
64
- // EDGE CROSSINGS dominates comprehension; bends and symmetry matter far less;
65
- // and aspect ratio is a sanity bound, not an aesthetic. We record that
66
- // provenance here so a reader knows which violation to weight, and so future
67
- // recalibration starts from the evidence rather than from feel.
68
-
69
- export type BoundBasis =
70
- | 'evidence' // backed by human-subject graph-drawing studies
71
- | 'derived' // mechanical correctness (labels must physically fit)
72
- | 'chosen' // plausible heuristic, not validated against human perception
73
- | 'sanity' // a guardrail against the absurd, not an aesthetic target
74
-
75
- export type ViolationSeverity =
76
- | 'primary' // the aesthetic with the strongest evidence of impact
77
- | 'secondary' // measurable but weaker human-comprehension impact
78
- | 'sanity' // out-of-range guardrail, not a quality verdict
79
-
80
- export interface BoundProvenance {
81
- basis: BoundBasis
82
- severity: ViolationSeverity
83
- note: string
84
- }
85
-
86
- /** Per-metric provenance. Keyed by the QualityMetrics field each bound gates. */
87
- export const BOUND_PROVENANCE: Record<
88
- 'edgeCrossings' | 'labelLegibility' | 'whitespaceBalance' | 'labelEdgeProximity' | 'aspectRatio',
89
- BoundProvenance
90
- > = {
91
- edgeCrossings: {
92
- basis: 'evidence', severity: 'primary',
93
- note: 'Crossings are the single aesthetic with the strongest human-subject evidence (Purchase 1997/2002). Weight this violation highest.',
94
- },
95
- labelLegibility: {
96
- basis: 'derived', severity: 'secondary',
97
- note: 'Labels that exceed node width are mechanically unreadable; the 7px/char model under-estimates fit under condensed fonts.',
98
- },
99
- labelEdgeProximity: {
100
- basis: 'chosen', severity: 'secondary',
101
- note: 'Edge-labels overlapping nodes hurt readability, but the 4px floor is chosen, not validated against perception.',
102
- },
103
- whitespaceBalance: {
104
- basis: 'chosen', severity: 'secondary',
105
- note: 'A node/canvas fill band is a rough proxy for "too sparse / too dense"; the literature gives weak support and the band is hand-set.',
106
- },
107
- aspectRatio: {
108
- basis: 'sanity', severity: 'sanity',
109
- note: 'Aspect ratio is a guardrail against absurd canvases, not an aesthetic; Purchase did not find it drives comprehension.',
110
- },
111
- }
112
-
113
- // JUSTIFIED / SYMMETRIC BEND — a bend in the aesthetic hierarchy.
114
- //
115
- // Purchase found bends matter for comprehension, but not every bend is a defect.
116
- // A bend that is part of a SYMMETRIC convergence (a fan-out/fan-in bundle, or a
117
- // co-ranked mixed-label fan-in's converging dogleg) is "as good as" a straight
118
- // line and must NOT be penalized: the bend is structurally necessary to converge
119
- // (you cannot merge N spokes into one node without a turn), and the symmetry it
120
- // buys — every reference layered drawer routes a fan this way, and our own
121
- // fan-out emitter applySymmetricFanoutEmissions does too — offsets the small bend
122
- // cost. Only UNJUSTIFIED / lone bends still cost. The geometric rubric encodes
123
- // this exactly (src/layout-rubric.ts): bundle-certified bends are excluded from
124
- // totalBends/maxBendsPerEdge — the SAME edges findRouteHitches treats as
125
- // non-hitches — so the bend penalty and the HARD hitch-invariant agree on what
126
- // counts as justified, while an off-lane jog with a clear straight lane (hitches)
127
- // or a bend on a 'straight'-certified edge (unexplainedBends) stays a violation.
128
-
129
- const CHAR_PX = 7 // approx character width at 12px font
130
- const EDGE_LABEL_BOX_PADDING = 8
131
- const GEOM_EPS = 1e-9
132
-
133
- export function measureQuality(layout: RenderedLayout): QualityMetrics {
134
- return {
135
- edgeCrossings: countEdgeCrossings(layout.edges),
136
- labelLegibility: measureLabelLegibility(layout.nodes),
137
- whitespaceBalance: measureWhitespaceBalance(layout),
138
- labelEdgeProximity: measureLabelEdgeProximity(layout),
139
- aspectRatio: layout.bounds.h > 0 ? layout.bounds.w / layout.bounds.h : Infinity,
140
- nodeCount: layout.nodes.length,
141
- edgeCount: layout.edges.length,
142
- }
143
- }
144
-
145
- export interface RankedViolation {
146
- metric: keyof typeof BOUND_PROVENANCE
147
- severity: ViolationSeverity
148
- message: string
149
- }
150
-
151
- export interface QualityVerdict {
152
- ok: boolean
153
- metrics: QualityMetrics
154
- /** Human-readable violation strings. Backward-compatible. */
155
- violations: string[]
156
- /**
157
- * The same violations, each tagged with its evidence-based severity so a
158
- * consumer can weight a crossings violation above a whitespace one
159
- * (Purchase 1997/2002). Ordered primary → secondary → sanity.
160
- */
161
- ranked: RankedViolation[]
162
- }
163
-
164
- export function checkQuality(layout: RenderedLayout, bounds: QualityBounds = {}): QualityVerdict {
165
- const b = { ...DEFAULT_BOUNDS, ...bounds }
166
- const m = measureQuality(layout)
167
- const ranked: RankedViolation[] = []
168
- const flag = (metric: keyof typeof BOUND_PROVENANCE, message: string) =>
169
- ranked.push({ metric, severity: BOUND_PROVENANCE[metric].severity, message })
170
- const pairs = Math.max(1, m.edgeCount * (m.edgeCount - 1) / 2)
171
- if (m.edgeCrossings / pairs > b.maxCrossingsRatio) {
172
- flag('edgeCrossings', `edge crossings ${m.edgeCrossings}/${pairs} (${(m.edgeCrossings / pairs * 100).toFixed(1)}%) > cap ${(b.maxCrossingsRatio * 100).toFixed(1)}%`)
173
- }
174
- if (m.labelLegibility < b.minLabelLegibility) {
175
- flag('labelLegibility', `label legibility ${(m.labelLegibility * 100).toFixed(0)}% < min ${(b.minLabelLegibility * 100).toFixed(0)}%`)
176
- }
177
- if (m.whitespaceBalance < b.whitespaceBand[0] || m.whitespaceBalance > b.whitespaceBand[1]) {
178
- flag('whitespaceBalance', `whitespace balance ${(m.whitespaceBalance * 100).toFixed(1)}% outside band [${b.whitespaceBand[0] * 100}–${b.whitespaceBand[1] * 100}]%`)
179
- }
180
- if (m.labelEdgeProximity < b.minLabelEdgeProximity) {
181
- flag('labelEdgeProximity', `edge-label clearance ${m.labelEdgeProximity}px < min ${b.minLabelEdgeProximity}px`)
182
- }
183
- if (m.aspectRatio < b.aspectBand[0] || m.aspectRatio > b.aspectBand[1]) {
184
- flag('aspectRatio', `aspect ratio ${m.aspectRatio.toFixed(2)} outside band [${b.aspectBand[0]}–${b.aspectBand[1]}]`)
185
- }
186
- const order: Record<ViolationSeverity, number> = { primary: 0, secondary: 1, sanity: 2 }
187
- ranked.sort((x, y) => order[x.severity] - order[y.severity])
188
- return { ok: ranked.length === 0, metrics: m, violations: ranked.map(v => v.message), ranked }
189
- }
190
-
191
- // ---- crossings -----------------------------------------------------------
192
-
193
- function countEdgeCrossings(edges: RenderedLayoutEdge[]): number {
194
- let count = 0
195
- for (let i = 0; i < edges.length; i++) {
196
- for (let j = i + 1; j < edges.length; j++) {
197
- const a = edges[i]!, b = edges[j]!
198
- // Shared endpoints — not a "crossing" in the visual sense.
199
- const shared = a.from === b.from || a.from === b.to || a.to === b.from || a.to === b.to
200
- const ap = a.path, bp = b.path
201
- for (let ai = 0; ai < ap.length - 1; ai++) {
202
- for (let bi = 0; bi < bp.length - 1; bi++) {
203
- if (shared && (ai === 0 || ai === ap.length - 2) && (bi === 0 || bi === bp.length - 2)) continue
204
- if (segmentsCross(ap[ai]!, ap[ai + 1]!, bp[bi]!, bp[bi + 1]!)) count++
205
- }
206
- }
207
- }
208
- }
209
- return count
210
- }
211
-
212
- function segmentsCross(p1: [number, number], p2: [number, number], p3: [number, number], p4: [number, number]): boolean {
213
- const d = (a: [number, number], b: [number, number], c: [number, number]): number =>
214
- (b[0] - a[0]) * (c[1] - a[1]) - (b[1] - a[1]) * (c[0] - a[0])
215
- const d1 = d(p3, p4, p1), d2 = d(p3, p4, p2)
216
- const d3 = d(p1, p2, p3), d4 = d(p1, p2, p4)
217
- return ((d1 > 0 && d2 < 0) || (d1 < 0 && d2 > 0)) && ((d3 > 0 && d4 < 0) || (d3 < 0 && d4 > 0))
218
- }
219
-
220
- // ---- label legibility -----------------------------------------------------
221
-
222
- function measureLabelLegibility(nodes: RenderedLayoutNode[]): number {
223
- if (nodes.length === 0) return 1
224
- let fits = 0
225
- for (const n of nodes) {
226
- if (!n.label) { fits++; continue }
227
- const renderedWidth = n.label.length * CHAR_PX
228
- if (renderedWidth <= n.w) fits++
229
- }
230
- return fits / nodes.length
231
- }
232
-
233
- // ---- whitespace balance --------------------------------------------------
234
-
235
- function measureWhitespaceBalance(layout: RenderedLayout): number {
236
- const total = layout.bounds.w * layout.bounds.h
237
- if (total <= 0) return 0
238
- let filled = 0
239
- for (const n of layout.nodes) filled += n.w * n.h
240
- return Math.min(1, filled / total)
241
- }
242
-
243
- // ---- edge-label proximity ------------------------------------------------
244
-
245
- interface Rect { x: number; y: number; w: number; h: number }
246
- type Point = [number, number]
247
-
248
- function nodeBox(n: RenderedLayoutNode): Rect {
249
- return { x: n.x, y: n.y, w: n.w, h: n.h }
250
- }
251
-
252
- function edgeLabelBox(label: NonNullable<RenderedLayoutEdge['label']>): Rect {
253
- const metrics = measureMultilineText(label.text, FONT_SIZES.edgeLabel, FONT_WEIGHTS.edgeLabel)
254
- const w = metrics.width + EDGE_LABEL_BOX_PADDING * 2
255
- const h = metrics.height + EDGE_LABEL_BOX_PADDING * 2
256
- return { x: label.x - w / 2, y: label.y - h / 2, w, h }
257
- }
258
-
259
- function rectDistance(a: Rect, b: Rect): number {
260
- const dx = Math.max(0, Math.max(a.x - (b.x + b.w), b.x - (a.x + a.w)))
261
- const dy = Math.max(0, Math.max(a.y - (b.y + b.h), b.y - (a.y + a.h)))
262
- return Math.hypot(dx, dy)
263
- }
264
-
265
- function pointInRect(p: Point, r: Rect): boolean {
266
- return p[0] >= r.x && p[0] <= r.x + r.w && p[1] >= r.y && p[1] <= r.y + r.h
267
- }
268
-
269
- function pointToRectDistance(p: Point, r: Rect): number {
270
- const dx = Math.max(0, Math.max(r.x - p[0], p[0] - (r.x + r.w)))
271
- const dy = Math.max(0, Math.max(r.y - p[1], p[1] - (r.y + r.h)))
272
- return Math.hypot(dx, dy)
273
- }
274
-
275
- function pointToSegmentDistance(p: Point, a: Point, b: Point): number {
276
- const dx = b[0] - a[0]
277
- const dy = b[1] - a[1]
278
- const lenSq = dx * dx + dy * dy
279
- if (lenSq === 0) return Math.hypot(p[0] - a[0], p[1] - a[1])
280
-
281
- const t = Math.max(0, Math.min(1, ((p[0] - a[0]) * dx + (p[1] - a[1]) * dy) / lenSq))
282
- const projX = a[0] + t * dx
283
- const projY = a[1] + t * dy
284
- return Math.hypot(p[0] - projX, p[1] - projY)
285
- }
286
-
287
- function segmentsIntersectInclusive(a: Point, b: Point, c: Point, d: Point): boolean {
288
- const orient = (p: Point, q: Point, r: Point): number =>
289
- (q[0] - p[0]) * (r[1] - p[1]) - (q[1] - p[1]) * (r[0] - p[0])
290
- const onSegment = (p: Point, q: Point, r: Point): boolean =>
291
- q[0] >= Math.min(p[0], r[0]) - GEOM_EPS && q[0] <= Math.max(p[0], r[0]) + GEOM_EPS &&
292
- q[1] >= Math.min(p[1], r[1]) - GEOM_EPS && q[1] <= Math.max(p[1], r[1]) + GEOM_EPS
293
-
294
- const o1 = orient(a, b, c)
295
- const o2 = orient(a, b, d)
296
- const o3 = orient(c, d, a)
297
- const o4 = orient(c, d, b)
298
- if (Math.abs(o1) <= GEOM_EPS && onSegment(a, c, b)) return true
299
- if (Math.abs(o2) <= GEOM_EPS && onSegment(a, d, b)) return true
300
- if (Math.abs(o3) <= GEOM_EPS && onSegment(c, a, d)) return true
301
- if (Math.abs(o4) <= GEOM_EPS && onSegment(c, b, d)) return true
302
- return (o1 > 0) !== (o2 > 0) && (o3 > 0) !== (o4 > 0)
303
- }
304
-
305
- function segmentIntersectsRect(a: Point, b: Point, r: Rect): boolean {
306
- if (pointInRect(a, r) || pointInRect(b, r)) return true
307
-
308
- const topLeft: Point = [r.x, r.y]
309
- const topRight: Point = [r.x + r.w, r.y]
310
- const bottomRight: Point = [r.x + r.w, r.y + r.h]
311
- const bottomLeft: Point = [r.x, r.y + r.h]
312
- return segmentsIntersectInclusive(a, b, topLeft, topRight) ||
313
- segmentsIntersectInclusive(a, b, topRight, bottomRight) ||
314
- segmentsIntersectInclusive(a, b, bottomRight, bottomLeft) ||
315
- segmentsIntersectInclusive(a, b, bottomLeft, topLeft)
316
- }
317
-
318
- function rectToSegmentDistance(r: Rect, a: Point, b: Point): number {
319
- if (segmentIntersectsRect(a, b, r)) return 0
320
-
321
- const corners: Point[] = [
322
- [r.x, r.y],
323
- [r.x + r.w, r.y],
324
- [r.x + r.w, r.y + r.h],
325
- [r.x, r.y + r.h],
326
- ]
327
- return Math.min(
328
- pointToRectDistance(a, r),
329
- pointToRectDistance(b, r),
330
- ...corners.map(c => pointToSegmentDistance(c, a, b)),
331
- )
332
- }
333
-
334
- function measureLabelEdgeProximity(layout: RenderedLayout): number {
335
- let min = Infinity
336
- const labels = layout.edges
337
- .filter((e): e is RenderedLayoutEdge & { label: NonNullable<RenderedLayoutEdge['label']> } => e.label !== undefined)
338
- .map(e => ({ edge: e, box: edgeLabelBox(e.label) }))
339
-
340
- for (const { edge, box } of labels) {
341
- for (const n of layout.nodes) {
342
- if (n.id === edge.from || n.id === edge.to) continue
343
- const d = rectDistance(box, nodeBox(n))
344
- if (d < min) min = d
345
- }
346
- }
347
- for (let i = 0; i < labels.length; i++) {
348
- for (let j = i + 1; j < labels.length; j++) {
349
- const d = rectDistance(labels[i]!.box, labels[j]!.box)
350
- if (d < min) min = d
351
- }
352
- }
353
- for (const { edge, box } of labels) {
354
- for (const other of layout.edges) {
355
- if (other === edge) continue
356
- for (let i = 0; i < other.path.length - 1; i++) {
357
- const d = rectToSegmentDistance(box, other.path[i]!, other.path[i + 1]!)
358
- if (d < min) min = d
359
- }
360
- }
361
- }
362
- return min
363
- }
@@ -1,92 +0,0 @@
1
- // Readability audit over the public RenderedLayout.
2
- //
3
- // "Readable" here means every text element can actually be read: its glyphs are
4
- // neither occluded by foreign geometry nor clipped off the canvas. This is the
5
- // invariant the before/after fan-out screenshots violated — the "yes" label
6
- // rendered as a clipped "es" because a node box was drawn over it.
7
- //
8
- // Two codes, both family-agnostic (they read only the rendered geometry):
9
- // • LABEL_OCCLUDED — a text element overlaps foreign geometry that hides its
10
- // glyphs: an edge-label pill over a non-incident node or another edge label,
11
- // or a LABELLED node's box overlapped by another node.
12
- // • LABEL_CLIPPED — a text element extends beyond the diagram bounds.
13
- //
14
- // A small overlap tolerance (TOL) ignores grazes — a 1px touch is not a
15
- // readability defect, an occluded glyph is.
16
-
17
- import type { RenderedLayout, RenderedLayoutNode } from './types.ts'
18
- import { measureMultilineText } from '../text-metrics.ts'
19
- import { resolveRenderStyle } from '../styles.ts'
20
-
21
- export type ReadabilityFinding =
22
- | { code: 'LABEL_OCCLUDED'; element: string; by: string }
23
- | { code: 'LABEL_CLIPPED'; element: string }
24
-
25
- interface Box { x: number; y: number; w: number; h: number }
26
-
27
- const TOL = 2 // an overlap must exceed this on BOTH axes to count (ignore grazes)
28
- const PILL_PAD = 8
29
- const BOUNDS_TOL = 1
30
-
31
- // Node-LABEL occlusion is only meaningful where a node's `label` is drawn as
32
- // glyphs inside its box — the node-link families. Chart families render a node's
33
- // `label` as axis/series metadata (a bar's category lives on the x-axis, not on
34
- // the bar), so two marks sharing a column is not a text-occlusion. This is a
35
- // category rule about rendering models, not a per-diagram exception; EDGE-label
36
- // checks below still run for every family.
37
- const NODE_LINK_KINDS = new Set(['flowchart', 'state', 'class', 'er', 'architecture'])
38
-
39
- const overlaps = (a: Box, b: Box): boolean =>
40
- Math.min(a.x + a.w, b.x + b.w) - Math.max(a.x, b.x) > TOL &&
41
- Math.min(a.y + a.h, b.y + b.h) - Math.max(a.y, b.y) > TOL
42
-
43
- const nodeBox = (n: RenderedLayoutNode): Box => ({ x: n.x, y: n.y, w: n.w, h: n.h })
44
- const hasText = (label: string | undefined): boolean => !!label && label.trim().length > 0
45
-
46
- export function auditReadability(layout: RenderedLayout): ReadabilityFinding[] {
47
- const style = resolveRenderStyle({})
48
- const findings: ReadabilityFinding[] = []
49
- const within = (b: Box): boolean =>
50
- b.x >= -BOUNDS_TOL && b.y >= -BOUNDS_TOL &&
51
- b.x + b.w <= layout.bounds.w + BOUNDS_TOL && b.y + b.h <= layout.bounds.h + BOUNDS_TOL
52
-
53
- // Edge labels: pill must be in-bounds and clear of non-incident nodes and
54
- // other edge labels.
55
- const labelBoxes: Array<{ id: string; box: Box }> = []
56
- for (const e of layout.edges) {
57
- if (!e.label) continue
58
- const m = measureMultilineText(e.label.text, style.edgeLabelFontSize, style.edgeLabelFontWeight)
59
- const box: Box = { x: e.label.x - (m.width + 2 * PILL_PAD) / 2, y: e.label.y - (m.height + 2 * PILL_PAD) / 2, w: m.width + 2 * PILL_PAD, h: m.height + 2 * PILL_PAD }
60
- if (!within(box)) findings.push({ code: 'LABEL_CLIPPED', element: e.id })
61
- for (const n of layout.nodes) {
62
- if (n.id === e.from || n.id === e.to) continue
63
- if (overlaps(box, nodeBox(n))) { findings.push({ code: 'LABEL_OCCLUDED', element: e.id, by: n.id }); break }
64
- }
65
- for (const other of labelBoxes) {
66
- if (overlaps(box, other.box)) { findings.push({ code: 'LABEL_OCCLUDED', element: e.id, by: other.id }); break }
67
- }
68
- labelBoxes.push({ id: e.id, box })
69
- }
70
-
71
- // Node labels: a labelled node's box must be in-bounds and not overlapped by
72
- // another node (which would draw over its text). We only consider nodes whose
73
- // box actually FITS the rendered label — i.e. the text is drawn as glyphs
74
- // inside the box. This exempts marks whose `label` is metadata rendered
75
- // elsewhere (a chart bar's category lives on the axis, not on the bar), by the
76
- // principled "is text drawn here" test rather than a per-family exception.
77
- const labelFitsBox = (n: RenderedLayoutNode): boolean => {
78
- const m = measureMultilineText(n.label!, style.nodeLabelFontSize, style.nodeLabelFontWeight)
79
- return n.w + 1 >= m.width && n.h + 1 >= m.height
80
- }
81
- for (const n of NODE_LINK_KINDS.has(layout.kind) ? layout.nodes : []) {
82
- if (!hasText(n.label) || !labelFitsBox(n)) continue
83
- const box = nodeBox(n)
84
- if (!within(box)) findings.push({ code: 'LABEL_CLIPPED', element: n.id })
85
- for (const other of layout.nodes) {
86
- if (other.id === n.id) continue
87
- if (overlaps(box, nodeBox(other))) { findings.push({ code: 'LABEL_OCCLUDED', element: n.id, by: other.id }); break }
88
- }
89
- }
90
-
91
- return findings
92
- }
@@ -1,61 +0,0 @@
1
- // Family-agnostic route audit over the public RenderedLayout.
2
- //
3
- // auditRouteContracts (route-contracts.ts) audits the ELK route pipeline using
4
- // route certificates, so it only applies to the graph families that flow
5
- // through layoutGraphSync (flowchart, state, legacy). This audits the route
6
- // invariant that EVERY family's edges must satisfy at the rendered level — an
7
- // edge label may not sit on a segment that runs collinear with, and overlapping,
8
- // another edge's segment (ROUTE_LABEL_ON_SHARED_TRUNK, route-contracts §11.4):
9
- // the reader cannot tell which edge such a label names. It runs on any family's
10
- // layoutMermaid() output, so the label-on-shared-trunk class can no longer hide
11
- // in sequence / class / ER / architecture / … layouts the graph audit can't see.
12
-
13
- import type { RenderedLayout } from './types.ts'
14
- import { measureMultilineText } from '../text-metrics.ts'
15
- import { resolveRenderStyle } from '../styles.ts'
16
-
17
- export type RenderedRouteFinding = { code: 'ROUTE_LABEL_ON_SHARED_TRUNK'; edge: string; sharedWith: string }
18
-
19
- const EPS = 0.01
20
- const CLEARANCE = 4
21
- const PILL_PAD = 8 // matches route-contracts LABEL_PILL_PADDING
22
-
23
- export function auditRenderedRoutes(layout: RenderedLayout): RenderedRouteFinding[] {
24
- const style = resolveRenderStyle({})
25
- const findings: RenderedRouteFinding[] = []
26
- for (const edge of layout.edges) {
27
- if (!edge.label) continue
28
- const m = measureMultilineText(edge.label.text, style.edgeLabelFontSize, style.edgeLabelFontWeight)
29
- const pw = m.width + 2 * PILL_PAD, ph = m.height + 2 * PILL_PAD
30
- const px = edge.label.x - pw / 2, py = edge.label.y - ph / 2
31
- let flagged: string | null = null
32
- for (const other of layout.edges) {
33
- if (other === edge || flagged) continue
34
- for (let i = 1; i < other.path.length && !flagged; i++) {
35
- const a = other.path[i - 1]!, b = other.path[i]!
36
- const vertical = Math.abs(a[0] - b[0]) < EPS
37
- const horizontal = Math.abs(a[1] - b[1]) < EPS
38
- if (!vertical && !horizontal) continue
39
- const sxLo = Math.min(a[0], b[0]), sxHi = Math.max(a[0], b[0])
40
- const syLo = Math.min(a[1], b[1]), syHi = Math.max(a[1], b[1])
41
- if (!(sxHi >= px && sxLo <= px + pw && syHi >= py && syLo <= py + ph)) continue
42
- // Shared trunk only when one of THIS edge's segments is collinear with
43
- // the other's; a plain perpendicular crossing under the pill is fine.
44
- for (let j = 1; j < edge.path.length && !flagged; j++) {
45
- const c = edge.path[j - 1]!, d = edge.path[j]!
46
- const sameAxis = vertical
47
- ? Math.abs(c[0] - d[0]) < EPS && Math.abs(c[0] - a[0]) < CLEARANCE
48
- : Math.abs(c[1] - d[1]) < EPS && Math.abs(c[1] - a[1]) < CLEARANCE
49
- if (!sameAxis) continue
50
- const cLo = vertical ? Math.min(c[1], d[1]) : Math.min(c[0], d[0])
51
- const cHi = vertical ? Math.max(c[1], d[1]) : Math.max(c[0], d[0])
52
- const oLo = vertical ? syLo : sxLo
53
- const oHi = vertical ? syHi : sxHi
54
- if (Math.min(cHi, oHi) - Math.max(cLo, oLo) > EPS) flagged = other.id
55
- }
56
- }
57
- }
58
- if (flagged) findings.push({ code: 'ROUTE_LABEL_ON_SHARED_TRUNK', edge: edge.id, sharedWith: flagged })
59
- }
60
- return findings
61
- }