agentic-loop 3.4.2 → 3.4.4

package/README.md

@@ -24,6 +24,8 @@ Ralph reads the PRD and implements each story autonomously. It spawns Claude, ru
 - `/vibe-check`, `/review` - On-demand quality and security checks
 - Pre-commit hooks - Block secrets, hardcoded URLs, debug statements
 - Claude Code hooks - Real-time warnings while coding
+- GitHub Actions CI/CD - Fast PR checks + comprehensive nightly tests
+- Test file enforcement - Fails if new code lacks corresponding tests
 
 ---
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agentic-loop",
-  "version": "3.4.2",
+  "version": "3.4.4",
   "description": "Autonomous AI coding loop - PRD-driven development with Claude Code",
   "author": "Allie Jones <allie@allthrive.ai>",
   "license": "MIT",

package/ralph/ci.sh

@@ -19,6 +19,7 @@ ralph_ci() {
       echo "Commands:"
       echo "  install  - Install GitHub Actions workflows"
       echo "  status   - Check CI status"
+      return 1
       ;;
   esac
 }

package/ralph/loop.sh

@@ -325,12 +325,12 @@ run_loop() {
     timeout_seconds=$(get_config '.maxSessionSeconds' "$DEFAULT_TIMEOUT_SECONDS")
 
     # Run Claude - first story gets fresh session, subsequent continue the session
-    local claude_cmd="claude -p --dangerously-skip-permissions --verbose"
+    local -a claude_args=(-p --dangerously-skip-permissions --verbose)
     if [[ "$session_started" == "true" ]]; then
-      claude_cmd="claude --continue -p --dangerously-skip-permissions --verbose"
+      claude_args=(--continue "${claude_args[@]}")
     fi
 
-    if ! cat "$prompt_file" | run_with_timeout "$timeout_seconds" $claude_cmd; then
+    if ! cat "$prompt_file" | run_with_timeout "$timeout_seconds" claude "${claude_args[@]}"; then
       print_warning "Claude session ended (timeout or error)"
       log_progress "$story" "TIMEOUT" "Claude session ended after ${timeout_seconds}s"
       rm -f "$prompt_file"

package/ralph/test.sh

@@ -14,8 +14,6 @@ ralph_test() {
   echo ""
 
   local failed=0
-  local total=0
-  local passed=0
 
   case "$mode" in
     all)
@@ -76,11 +74,18 @@ run_full_test_suite() {
   echo "Running: $test_cmd"
   echo ""
 
-  if eval "$test_cmd"; then
+  local log_file
+  log_file=$(mktemp)
+
+  if safe_exec "$test_cmd" "$log_file"; then
     print_success "Unit tests passed"
+    rm -f "$log_file"
     return 0
   else
     print_error "Unit tests failed"
+    echo ""
+    tail -50 "$log_file"
+    rm -f "$log_file"
     return 1
   fi
 }
@@ -131,13 +136,16 @@ run_all_prd_tests() {
 
       echo -n "  $step... "
 
-      if eval "$step" >/dev/null 2>&1; then
+      local step_log
+      step_log=$(mktemp)
+      if safe_exec "$step" "$step_log"; then
         print_success "passed"
         ((passed++))
       else
         print_error "failed"
         ((failed++))
       fi
+      rm -f "$step_log"
     done <<< "$test_steps"
 
     echo ""

package/ralph/verify/tests.sh

@@ -4,26 +4,81 @@
 
 # Check that new/modified source files have corresponding test files
 # This catches the case where Claude writes code but forgets tests
+# Config: .checks.requireTests = true|false (default: false)
 verify_test_files_exist() {
   local story_type="${RALPH_STORY_TYPE:-general}"
 
+  # Check if this check is enabled in config
+  local require_tests
+  require_tests=$(get_config '.checks.requireTests' "false")
+  if [[ "$require_tests" != "true" ]]; then
+    return 0
+  fi
+
   # Skip for frontend stories (handled differently with .test.tsx pattern)
   [[ "$story_type" == "frontend" ]] && return 0
 
   echo -n "    Test files exist for new code... "
 
+  local missing_tests=()
+  local checked=0
+
+  # Check Python files if this is a Python project
+  if [[ -f "pyproject.toml" ]] || [[ -f "requirements.txt" ]] || [[ -f "setup.py" ]]; then
+    _check_python_test_files missing_tests checked
+  fi
+
+  # Check Go files if this is a Go project
+  if [[ -f "go.mod" ]]; then
+    _check_go_test_files missing_tests checked
+  fi
+
+  # If nothing to check, skip
+  if [[ $checked -eq 0 ]]; then
+    print_success "skipped (no new source files)"
+    return 0
+  fi
+
+  if [[ ${#missing_tests[@]} -eq 0 ]]; then
+    print_success "passed ($checked files checked)"
+    return 0
+  else
+    print_error "missing tests"
+    echo ""
+    echo "    The following files need test files:"
+    for file in "${missing_tests[@]}"; do
+      echo "      $file"
+    done
+    echo ""
+    echo "    Create test files for new code before completing the story."
+    echo "    To disable this check: set .checks.requireTests = false in config.json"
+
+    # Save for failure context
+    {
+      echo "Missing test files for new code:"
+      for file in "${missing_tests[@]}"; do
+        echo "  $file"
+      done
+    } > "$RALPH_DIR/last_test_existence_failure.log"
+
+    return 1
+  fi
+}
+
+# Helper: Check Python files have corresponding test files
+# Usage: _check_python_test_files <missing_array_name> <checked_var_name>
+_check_python_test_files() {
+  local -n _missing=$1
+  local -n _checked=$2
+
   # Get list of modified Python files (excluding tests themselves)
   local modified_files
   modified_files=$(git diff --name-only HEAD~1 2>/dev/null | grep '\.py$' | grep -v 'test_' | grep -v '_test\.py' | grep -v '/tests/' || true)
 
-  # If no Python files modified, skip
-  if [[ -z "$modified_files" ]]; then
-    print_success "skipped (no new Python files)"
-    return 0
-  fi
+  [[ -z "$modified_files" ]] && return 0
 
-  local missing_tests=()
-  local checked=0
+  local backend_dir
+  backend_dir=$(get_config '.directories.backend' "")
 
   while IFS= read -r src_file; do
     [[ -z "$src_file" ]] && continue
@@ -35,11 +90,11 @@ verify_test_files_exist() {
     [[ "$src_file" == *"/alembic/"* ]] && continue
     [[ "$src_file" == *"config"* ]] && continue
     [[ "$src_file" == *"settings"* ]] && continue
+    [[ "$src_file" == *"conftest"* ]] && continue
 
-    ((checked++))
+    ((_checked++))
 
-    # Determine expected test file location
-    local base_name dir_name test_file
+    local base_name dir_name
     base_name=$(basename "$src_file" .py)
     dir_name=$(dirname "$src_file")
 
@@ -52,9 +107,6 @@ verify_test_files_exist() {
       "tests/${base_name}_test.py"
     )
 
-    # Check for backend dir patterns
-    local backend_dir
-    backend_dir=$(get_config '.directories.backend' "")
     if [[ -n "$backend_dir" ]]; then
       possible_tests+=(
         "$backend_dir/tests/test_${base_name}.py"
@@ -71,35 +123,46 @@ verify_test_files_exist() {
     done
 
     if [[ "$found" == "false" ]]; then
-      missing_tests+=("$src_file")
+      _missing+=("$src_file → test_${base_name}.py")
     fi
   done <<< "$modified_files"
+}
 
-  if [[ ${#missing_tests[@]} -eq 0 ]]; then
-    print_success "passed ($checked files checked)"
-    return 0
-  else
-    print_error "missing tests"
-    echo ""
-    echo "    The following files need test files:"
-    for file in "${missing_tests[@]}"; do
-      local base_name
-      base_name=$(basename "$file" .py)
-      echo "      $file → test_${base_name}.py"
-    done
-    echo ""
-    echo "    Create test files for new code before completing the story."
+# Helper: Check Go files have corresponding test files
+# Usage: _check_go_test_files <missing_array_name> <checked_var_name>
+_check_go_test_files() {
+  local -n _missing=$1
+  local -n _checked=$2
 
-    # Save for failure context
-    {
-      echo "Missing test files for new code:"
-      for file in "${missing_tests[@]}"; do
-        echo "  $file"
-      done
-    } > "$RALPH_DIR/last_test_existence_failure.log"
+  # Get list of modified Go files (excluding tests themselves)
+  local modified_files
+  modified_files=$(git diff --name-only HEAD~1 2>/dev/null | grep '\.go$' | grep -v '_test\.go$' || true)
 
-    return 1
-  fi
+  [[ -z "$modified_files" ]] && return 0
+
+  while IFS= read -r src_file; do
+    [[ -z "$src_file" ]] && continue
+    [[ ! -f "$src_file" ]] && continue
+
+    # Skip generated files, main.go, etc.
+    [[ "$src_file" == *"_generated.go" ]] && continue
+    [[ "$src_file" == *"/vendor/"* ]] && continue
+    [[ "$(basename "$src_file")" == "main.go" ]] && continue
+    [[ "$(basename "$src_file")" == "doc.go" ]] && continue
+
+    ((_checked++))
+
+    local base_name dir_name
+    base_name=$(basename "$src_file" .go)
+    dir_name=$(dirname "$src_file")
+
+    # Go convention: foo.go -> foo_test.go in same directory
+    local test_file="$dir_name/${base_name}_test.go"
+
+    if [[ ! -f "$test_file" ]]; then
+      _missing+=("$src_file → ${base_name}_test.go")
+    fi
+  done <<< "$modified_files"
 }
 
 # Run unit tests

package/templates/PROMPT.md

@@ -24,19 +24,24 @@ For each story, you must:
 
 **Every new code file MUST have a corresponding test file.**
 
-For **backend** stories (Python/API):
+For **Python** backend stories:
 - New file `foo.py` → create `tests/test_foo.py`
 - Test each public function/method
 - Test error cases (invalid input, missing data, API failures)
 - Test edge cases (empty lists, None values, boundary conditions)
 - Use pytest fixtures for database/API mocking
 
+For **Go** projects:
+- New file `foo.go` → create `foo_test.go` in same directory
+- Use table-driven tests for multiple cases
+- Test error paths and edge cases
+
 For **frontend** stories (TypeScript/React):
 - New component `Foo.tsx` → create `Foo.test.tsx`
 - Test rendering, user interactions, error states
 - Test loading states and empty states
 
-**Do NOT skip tests.** If you create code without tests, verification will fail.
+**Do NOT skip tests.** If test enforcement is enabled, verification will fail without tests.
 
 ### 3. Verify It Actually Works
 

package/templates/github/workflows/nightly.yml

@@ -79,7 +79,7 @@ jobs:
 
       # PRD testSteps (if ralph is set up)
       - name: Install ralph
-        run: npm install -g thrivekit 2>/dev/null || true
+        run: npm install -g agentic-loop 2>/dev/null || true
 
       - name: Run PRD tests
         if: hashFiles('.ralph/prd.json') != ''