agentic-loop 3.18.0 → 3.18.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agentic-loop",
-  "version": "3.18.0",
+  "version": "3.18.2",
   "description": "Autonomous AI coding loop - PRD-driven development with Claude Code",
   "author": "Allie Jones <allie@allthrive.ai>",
   "license": "MIT",

package/ralph/code-check.sh

@@ -247,7 +247,7 @@ _detect_structural_errors() {
   local error_content
   error_content=$(cat "$context_file")
 
-  # Schema/column errors - suggest DB reset
+  # Schema/column errors - detect and flag for Claude context
   # Only show if not already detected (avoid duplicate markers on retry)
   if echo "$error_content" | grep -qiE "(column.*does not exist|relation.*does not exist|no such column|unknown column|undefined column)" && \
      ! grep -q ">>> STRUCTURAL ISSUE: Database schema mismatch" "$context_file" 2>/dev/null; then
@@ -256,28 +256,17 @@ _detect_structural_errors() {
     echo ""
     echo "  The test database is missing columns/tables that the code expects."
     echo "  This usually happens when:"
-    echo "    - Migrations were added but test DB wasn't reset"
+    echo "    - Migrations were added but test DB wasn't updated"
     echo "    - Models were modified without running migrations"
     echo ""
-    echo "  SUGGESTED FIX (don't retry code - fix the schema):"
-    local reset_cmd
-    reset_cmd=$(get_config '.commands.resetDb' "")
-    if [[ -n "$reset_cmd" ]]; then
-      echo "    $reset_cmd"
-    else
-      echo "    # Add to .ralph/config.json:"
-      echo "    {\"commands\": {\"resetDb\": \"npm run db:reset:test\"}}"
-      echo ""
-      echo "    # Or run manually:"
-      echo "    dropdb test_db && createdb test_db && alembic upgrade head"
-    fi
+    echo "  Run pending migrations to fix the schema."
     echo ""
 
     # Append suggestion to failure context for Claude
     {
       echo ""
       echo ">>> STRUCTURAL ISSUE: Database schema mismatch"
-      echo ">>> ACTION NEEDED: Reset test database, don't just retry code"
+      echo ">>> ACTION NEEDED: Run pending migrations to update the schema"
       echo ">>> This is NOT a code bug - the test DB is missing schema changes"
     } >> "$context_file"
   fi

package/ralph/loop.sh

@@ -391,6 +391,10 @@ PATTERN: <pattern>"
 }
 
 run_loop() {
+  # Trap Ctrl+C so it stops the entire loop, not just the current child process.
+  # Without this, SIGINT only kills the pipeline (claude|tee) and the while loop continues.
+  trap 'echo ""; print_warning "Ctrl+C received — stopping loop..."; trap - INT; kill -INT $$' INT
+
   local max_iterations="$DEFAULT_MAX_ITERATIONS"
   local specific_story=""
   local fast_mode=false
@@ -950,6 +954,36 @@ startup_checklist() {
   fi
 }
 
+# Helper: Check if files listed in a story's files.create/files.modify already exist on disk
+# Returns newline-separated list of existing files (empty string if none)
+_check_story_files_exist() {
+  local story_id="$1"
+  local prd_file="$RALPH_DIR/prd.json"
+  [[ ! -f "$prd_file" ]] && return
+
+  local file_list
+  file_list=$(jq -r --arg id "$story_id" '
+    .stories[] | select(.id == $id) |
+    ((.files.create // []) + (.files.modify // [])) | .[]
+  ' "$prd_file" 2>/dev/null) || return
+
+  [[ -z "$file_list" ]] && return
+
+  local existing=""
+  while IFS= read -r f; do
+    [[ -z "$f" ]] && continue
+    if [[ -f "$f" ]]; then
+      if [[ -z "$existing" ]]; then
+        existing="$f"
+      else
+        existing="$existing"$'\n'"$f"
+      fi
+    fi
+  done <<< "$file_list"
+
+  [[ -n "$existing" ]] && echo "$existing"
+}
+
 # Helper: Build delta prompt for continuing session
 # Minimal context - just story ID + any failure info
 _build_delta_prompt() {
@@ -964,6 +998,15 @@ _build_delta_prompt() {
   if [[ -n "$failure_context" ]]; then
     echo "## Retry: Fix the errors below"
     echo ""
+
+    # Check if story files already exist — if so, skip re-implementation
+    local existing_files
+    existing_files=$(_check_story_files_exist "$story")
+    if [[ -n "$existing_files" ]]; then
+      echo "**The code is ALREADY WRITTEN.** Do NOT rewrite. Fix ONLY the errors below, then verify."
+      echo ""
+    fi
+
     echo "Read \`.ralph/last_failure.txt\` for full error details."
     echo ""
     echo '```'
@@ -1039,6 +1082,20 @@ build_prompt() {
     echo ""
     echo "## Previous Iteration Failed"
     echo ""
+
+    # Check if story files already exist — if so, skip re-implementation
+    local existing_files
+    existing_files=$(_check_story_files_exist "$story")
+    if [[ -n "$existing_files" ]]; then
+      echo "**IMPORTANT: The code for this story is ALREADY WRITTEN.** These files exist:"
+      echo '```'
+      echo "$existing_files"
+      echo '```'
+      echo "Do NOT rewrite or re-implement. Read the existing code, then fix ONLY the"
+      echo "specific errors below. Go straight to verification after fixing."
+      echo ""
+    fi
+
     echo "Read \`.ralph/last_failure.txt\` for details. Key error:"
     echo ""
     echo '```'

package/ralph/prd-check.sh

@@ -46,10 +46,6 @@
 #   LIST ENDPOINTS (get all, index):
 #     - Has pagination criteria (limit, page params)
 #
-#   MIGRATION STORIES (alembic, migrations, models):
-#     - Has prerequisites array with DB reset command
-#     - Prevents infinite retries on schema mismatch errors
-#
 #   CUSTOM CHECKS (.ralph/checks/prd/):
 #     - User-provided scripts that receive story JSON on stdin
 #     - Output issue descriptions to stdout (one per line)
@@ -69,7 +65,6 @@
 #     - Missing mcp on frontend → ["playwright", "devtools"]
 #     - Bare pytest → prefixed with detected runner (uv/poetry/pipenv)
 #     - Missing camelCase note → standard text appended to .notes
-#     - Missing migration prerequisites → template prerequisite array
 #     - Server-only testSteps → offline fallback appended
 #
 #   Tier 2 — Parallel Claude subagents (one per story, concurrent):
@@ -344,7 +339,7 @@ _validate_and_fix_stories() {
   local cnt_no_tests=0 cnt_backend_curl=0 cnt_backend_contract=0
   local cnt_frontend_tsc=0 cnt_frontend_url=0 cnt_frontend_context=0 cnt_frontend_mcp=0
   local cnt_auth_security=0 cnt_list_pagination=0 cnt_prose_steps=0
-  local cnt_migration_prereq=0 cnt_naming_convention=0 cnt_bare_pytest=0
+  local cnt_naming_convention=0 cnt_bare_pytest=0
   local cnt_server_only=0
   local cnt_custom=0
 
@@ -466,19 +461,6 @@ _validate_and_fix_stories() {
       fi
     fi
 
-    # Check 6: Migration stories need DB prerequisites
-    # If story creates migration files or modifies models, it needs resetDb prerequisite
-    local story_files
-    story_files=$(jq -r --arg id "$story_id" '.stories[] | select(.id==$id) | (.files.create // []) + (.files.modify // []) | join(" ")' "$prd_file")
-    if echo "$story_files" | grep -qiE "(alembic/versions|migrations/|\.migration\.|models\.py|models/|schema\.)"; then
-      local has_prereq
-      has_prereq=$(jq -r --arg id "$story_id" '.stories[] | select(.id==$id) | .prerequisites // [] | length' "$prd_file")
-      if [[ "$has_prereq" == "0" ]]; then
-        story_issues+="migration story needs prerequisites (DB reset), "
-        cnt_migration_prereq=$((cnt_migration_prereq + 1))
-      fi
-    fi
-
     # Check 7: Frontend stories consuming APIs need naming convention notes
     # If story is frontend/general AND mentions API/fetch/axios, ensure notes include camelCase guidance
     if [[ "$story_type" == "frontend" || "$story_type" == "general" ]]; then
@@ -563,7 +545,6 @@ _validate_and_fix_stories() {
     [[ $cnt_frontend_mcp -gt 0 ]] && echo "    ${cnt_frontend_mcp}x frontend: add mcp browser tools"
     [[ $cnt_auth_security -gt 0 ]] && echo "    ${cnt_auth_security}x auth: add security criteria"
     [[ $cnt_list_pagination -gt 0 ]] && echo "    ${cnt_list_pagination}x list: add pagination"
-    [[ $cnt_migration_prereq -gt 0 ]] && echo "    ${cnt_migration_prereq}x migration: add prerequisites (DB reset)"
     [[ $cnt_naming_convention -gt 0 ]] && echo "    ${cnt_naming_convention}x API consumer: add camelCase transformation note"
     [[ $cnt_bare_pytest -gt 0 ]] && echo "    ${cnt_bare_pytest}x use 'uv run pytest' not bare 'pytest'"
     [[ $cnt_server_only -gt 0 ]] && echo "    ${cnt_server_only}x all testSteps need live server (add offline fallback)"
@@ -740,18 +721,6 @@ _apply_mechanical_fixes() {
       fi
     fi
 
-    # Fix: Migration story missing prerequisites
-    local story_files
-    story_files=$(jq -r --arg id "$story_id" '.stories[] | select(.id==$id) | (.files.create // []) + (.files.modify // []) | join(" ")' "$prd_file")
-    if echo "$story_files" | grep -qiE "(alembic/versions|migrations/|\.migration\.|models\.py|models/|schema\.)"; then
-      local has_prereq
-      has_prereq=$(jq -r --arg id "$story_id" '.stories[] | select(.id==$id) | .prerequisites // [] | length' "$prd_file")
-      if [[ "$has_prereq" == "0" ]]; then
-        update_json "$prd_file" --arg id "$story_id" \
-          '(.stories[] | select(.id==$id) | .prerequisites) = [{"name": "Reset test DB", "command": "npm run db:reset:test", "when": "schema changes"}]' && fixed=$((fixed + 1))
-      fi
-    fi
-
     # Fix: All testSteps are server-dependent → append offline test step
     local test_steps
     test_steps=$(jq -r --arg id "$story_id" '.stories[] | select(.id==$id) | .testSteps // [] | join(" ")' "$prd_file")
@@ -1005,17 +974,6 @@ validate_stories_quick() {
       fi
     fi
 
-    # Check 6: Migration stories need prerequisites
-    local story_files
-    story_files=$(jq -r --arg id "$story_id" '.stories[] | select(.id==$id) | (.files.create // []) + (.files.modify // []) | join(" ")' "$prd_file")
-    if echo "$story_files" | grep -qiE "(alembic/versions|migrations/|\.migration\.|models\.py|models/|schema\.)"; then
-      local has_prereq
-      has_prereq=$(jq -r --arg id "$story_id" '.stories[] | select(.id==$id) | .prerequisites // [] | length' "$prd_file")
-      if [[ "$has_prereq" == "0" ]]; then
-        issues+="$story_id: migration needs prerequisites, "
-      fi
-    fi
-
     # Check 7: Frontend/general stories consuming APIs need naming convention notes
     if [[ "$story_type" == "frontend" || "$story_type" == "general" ]]; then
       local story_desc

package/templates/config/elixir.json

@@ -26,7 +26,7 @@
     "dev": "mix phx.server",
     "install": "mix deps.get",
     "seed": "mix run priv/repo/seeds.exs",
-    "resetDb": "mix ecto.reset"
+    "migrate": "mix ecto.migrate"
   },
 
   "migrations": {

package/templates/config/fastmcp.json

@@ -32,7 +32,7 @@
     "typecheck": "uv run mypy src/",
     "test": "uv run pytest",
     "seed": "",
-    "resetDb": ""
+    "migrate": ""
   },
 
   "checks": {

package/templates/config/fullstack.json

@@ -28,7 +28,7 @@
     "devBackend": "python manage.py runserver",
     "install": "npm install && pip install -r requirements.txt",
     "seed": "",
-    "resetDb": ""
+    "migrate": ""
   },
 
   "migrations": {

package/templates/config/go.json

@@ -26,7 +26,7 @@
     "dev": "go run .",
     "install": "go mod download",
     "seed": "",
-    "resetDb": ""
+    "migrate": ""
   },
 
   "migrations": {

package/templates/config/minimal.json

@@ -26,7 +26,7 @@
     "dev": "",
     "install": "",
     "seed": "",
-    "resetDb": ""
+    "migrate": ""
   },
 
   "migrations": {

package/templates/config/node.json

@@ -26,7 +26,7 @@
     "dev": "npm run dev",
     "install": "npm install",
     "seed": "",
-    "resetDb": ""
+    "migrate": ""
   },
 
   "migrations": {

package/templates/config/python.json

@@ -26,7 +26,7 @@
     "dev": "uvicorn main:app --reload",
     "install": "pip install -r requirements.txt",
     "seed": "",
-    "resetDb": ""
+    "migrate": ""
   },
 
   "migrations": {

package/templates/config/rust.json

@@ -26,7 +26,7 @@
     "dev": "cargo run",
     "install": "cargo build",
     "seed": "",
-    "resetDb": ""
+    "migrate": ""
   },
 
   "migrations": {