agentic-loop 3.1.6 → 3.2.1

package/ralph/playwright.sh

@@ -1,238 +0,0 @@
-#!/usr/bin/env bash
-# shellcheck shell=bash
-# playwright.sh - Playwright test integration for ralph
-
-# Ensure Playwright is installed and configured
-ensure_playwright() {
-  # Check if playwright config exists
-  if [[ ! -f "playwright.config.ts" ]] && [[ ! -f "playwright.config.js" ]]; then
-    print_info "Playwright not configured, initializing..."
-
-    # Check if npx is available
-    if ! command -v npx &>/dev/null; then
-      print_error "npx not found - cannot install Playwright"
-      return 1
-    fi
-
-    # Install Playwright package and browsers
-    npm install playwright 2>/dev/null && npx playwright install chromium 2>/dev/null || {
-      print_warning "Could not install Playwright - run: npm install playwright && npx playwright install chromium"
-    }
-
-    # Create minimal config if it doesn't exist
-    if [[ ! -f "playwright.config.ts" ]] && [[ ! -f "playwright.config.js" ]]; then
-      print_info "Creating playwright.config.ts..."
-      cat > playwright.config.ts << 'EOF'
-import { defineConfig, devices } from '@playwright/test';
-
-export default defineConfig({
-  testDir: './tests/e2e',
-  fullyParallel: true,
-  forbidOnly: !!process.env.CI,
-  retries: process.env.CI ? 2 : 0,
-  workers: process.env.CI ? 1 : undefined,
-  reporter: 'html',
-  use: {
-    baseURL: process.env.BASE_URL || 'http://localhost:3000',
-    trace: 'on-first-retry',
-    screenshot: 'only-on-failure',
-  },
-  projects: [
-    {
-      name: 'chromium',
-      use: { ...devices['Desktop Chrome'] },
-    },
-    {
-      name: 'mobile',
-      use: { ...devices['iPhone 13'] },
-    },
-  ],
-});
-EOF
-    fi
-
-    # Create test directory
-    mkdir -p tests/e2e
-
-    print_success "Playwright initialized"
-  fi
-
-  return 0
-}
-
-# Find test file for a story - uses explicit config or story-level testFile
-find_story_test_file() {
-  local story="$1"
-  local test_dir="$2"
-
-  # 1. Check story for explicit testFile path (preferred)
-  local explicit_file
-  explicit_file=$(jq -r --arg id "$story" '.stories[] | select(.id==$id) | .testFile // empty' "$RALPH_DIR/prd.json" 2>/dev/null)
-  if [[ -n "$explicit_file" && -f "$explicit_file" ]]; then
-    echo "$explicit_file"
-    return 0
-  fi
-
-  # 2. Check config.json for e2e test directory pattern
-  local config_test_dir
-  config_test_dir=$(get_config '.playwright.testDir' "")
-  if [[ -n "$config_test_dir" ]]; then
-    test_dir="$config_test_dir"
-  fi
-
-  # 3. Standard naming: {testDir}/{story-id}.spec.ts
-  if [[ -f "${test_dir}/${story}.spec.ts" ]]; then
-    echo "${test_dir}/${story}.spec.ts"
-    return 0
-  fi
-  if [[ -f "${test_dir}/${story}.spec.js" ]]; then
-    echo "${test_dir}/${story}.spec.js"
-    return 0
-  fi
-
-  # 4. Slug-based naming from story title
-  local story_slug
-  story_slug=$(jq -r --arg id "$story" '.stories[] | select(.id==$id) | .title // ""' "$RALPH_DIR/prd.json" 2>/dev/null | \
-    tr '[:upper:]' '[:lower:]' | sed 's/[^a-z0-9]/-/g' | sed 's/--*/-/g' | sed 's/^-//' | sed 's/-$//')
-
-  if [[ -n "$story_slug" && -f "${test_dir}/${story_slug}.spec.ts" ]]; then
-    echo "${test_dir}/${story_slug}.spec.ts"
-    return 0
-  fi
-
-  return 1
-}
-
-# Run Playwright tests for a specific story or all tests
-run_playwright_tests() {
-  local story="$1"
-
-  # Check if Playwright is enabled in config
-  local pw_enabled
-  pw_enabled=$(get_config '.playwright.enabled' "true")
-  if [[ "$pw_enabled" == "false" ]]; then
-    echo "    (Playwright disabled in config, skipping)"
-    return 0
-  fi
-
-  # Ensure Playwright is set up
-  if ! ensure_playwright; then
-    return 1
-  fi
-
-  # Check if npx is available
-  if ! command -v npx &>/dev/null; then
-    print_error "npx not found - cannot run Playwright"
-    return 1
-  fi
-
-  # Get test directory from config or use default
-  local test_dir
-  test_dir=$(get_config '.playwright.testDir' "tests/e2e")
-
-  # Find the test file for this story
-  local test_file
-  test_file=$(find_story_test_file "$story" "$test_dir")
-
-  local log_file
-  log_file=$(create_temp_file ".log") || return 1
-
-  echo -n "  Running Playwright tests... "
-
-  if [[ -n "$test_file" && -f "$test_file" ]]; then
-    # Run story-specific test
-    echo -n "(${test_file##*/}) "
-    if npx playwright test "$test_file" --reporter=line > "$log_file" 2>&1; then
-      print_success "passed"
-      rm -f "$log_file"
-      return 0
-    fi
-  else
-    # No story-specific test - check if e2e was expected
-    local e2e_required
-    e2e_required=$(jq -r --arg id "$story" '.stories[] | select(.id==$id) | .e2e // false' "$RALPH_DIR/prd.json" 2>/dev/null)
-
-    if [[ "$e2e_required" == "true" ]]; then
-      # Show where we looked and how to fix
-      print_warning "missing (e2e: true but no test file found)"
-      echo ""
-      echo "    Looked for: ${test_dir}/${story}.spec.ts"
-      echo ""
-      echo "    Fix options:"
-      echo "    1. Add 'testFile' to story: \"testFile\": \"apps/web/tests/e2e/my-test.spec.ts\""
-      echo "    2. Set testDir in .ralph/config.json: \"playwright\": {\"testDir\": \"apps/web/tests/e2e\"}"
-      echo "    3. Name test file: ${test_dir}/${story}.spec.ts"
-      rm -f "$log_file"
-      return 1  # Fail if e2e was expected but not created
-    fi
-
-    # Check if any tests exist to run
-    if [[ -z "$(find "$test_dir" -name '*.spec.ts' -o -name '*.spec.js' 2>/dev/null | head -1)" ]]; then
-      echo "skipped (not required for this story)"
-      rm -f "$log_file"
-      return 0
-    fi
-
-    # Run all tests
-    if npx playwright test --reporter=line > "$log_file" 2>&1; then
-      print_success "passed"
-      rm -f "$log_file"
-      return 0
-    fi
-  fi
-
-  # Tests failed
-  print_error "failed"
-  echo ""
-  echo "  Playwright output (last $MAX_LOG_LINES lines):"
-  tail -"$MAX_LOG_LINES" "$log_file" | sed 's/^/    /'
-
-  # Save failure for context
-  cp "$log_file" "$RALPH_DIR/last_playwright_failure.log"
-
-  rm -f "$log_file"
-  return 1
-}
-
-# Run Playwright with accessibility checks
-run_playwright_a11y() {
-  local story="$1"
-  local url="$2"
-
-  # Check if @axe-core/playwright is available
-  if ! npm list @axe-core/playwright &>/dev/null 2>&1; then
-    print_info "Installing @axe-core/playwright for accessibility testing..."
-    npm install -D @axe-core/playwright 2>/dev/null || {
-      print_warning "Could not install axe-core, skipping a11y tests"
-      return 0
-    }
-  fi
-
-  # a11y tests are typically part of the Playwright tests
-  # This function can be extended to run standalone a11y audits
-  return 0
-}
-
-# Run Playwright at specific viewport (for mobile testing)
-run_playwright_mobile() {
-  local story="$1"
-
-  local log_file
-  log_file=$(create_temp_file ".log") || return 1
-
-  echo -n "  Running mobile viewport tests... "
-
-  # Run tests with mobile project
-  if npx playwright test --project=mobile --reporter=line > "$log_file" 2>&1; then
-    print_success "passed"
-    rm -f "$log_file"
-    return 0
-  else
-    print_error "failed"
-    echo ""
-    echo "  Mobile test output:"
-    tail -"$MAX_OUTPUT_PREVIEW_LINES" "$log_file" | sed 's/^/    /'
-    rm -f "$log_file"
-    return 1
-  fi
-}

package/ralph/verify/browser.sh

@@ -1,324 +0,0 @@
-#!/usr/bin/env bash
-# shellcheck shell=bash
-# browser.sh - Browser validation module for ralph
-
-# Browser validation for frontend stories using Playwright
-run_browser_validation() {
-  local story="$1"
-
-  # Check if browser validation is enabled in config
-  local browser_enabled
-  browser_enabled=$(get_config '.verification.browserEnabled' "true")
-  if [[ "$browser_enabled" == "false" ]]; then
-    echo "    (browser validation disabled in config, skipping)"
-    return 0
-  fi
-
-  # Get base URL from config (required for relative URLs)
-  local base_url
-  base_url=$(get_config '.testUrlBase' "")
-
-  # Check if Docker mode - Playwright needs special handling
-  local docker_enabled
-  docker_enabled=$(get_config '.docker.enabled' "false")
-  if [[ "$docker_enabled" == "true" ]]; then
-    echo "    (Docker mode: using curl check - set verification.browserEnabled=false to hide this)"
-    # In Docker, fall back to curl unless they've set up remote browser
-    local url
-    url=$(jq -r --arg id "$story" '.stories[] | select(.id==$id) | .testUrl // empty' "$RALPH_DIR/prd.json" 2>/dev/null)
-    if [[ -n "$url" ]]; then
-      # Check for unsubstituted template variables
-      if [[ "$url" =~ \{[a-zA-Z_][a-zA-Z0-9_]*\} ]]; then
-        print_warning "    testUrl has unsubstituted variable: $url"
-        return 0
-      fi
-      # Handle relative URLs
-      if [[ "$url" =~ ^/ ]]; then
-        if [[ -z "$base_url" ]]; then
-          print_error "testUrlBase not set in config.json (needed for relative URL: $url)"
-          return 1
-        fi
-        url="${base_url}${url}"
-      fi
-      return run_curl_check "$url"
-    fi
-    return 0
-  fi
-
-  local url
-  url=$(jq -r --arg id "$story" '.stories[] | select(.id==$id) | .testUrl // empty' "$RALPH_DIR/prd.json" 2>/dev/null)
-
-  if [[ -z "$url" ]]; then
-    echo "    skipped (no testUrl - infrastructure or backend story)"
-    return 0
-  fi
-
-  # Check for unsubstituted template variables like {collectionId}
-  if [[ "$url" =~ \{[a-zA-Z_][a-zA-Z0-9_]*\} ]]; then
-    print_warning "    testUrl has unsubstituted variable: $url"
-    echo "    Add concrete ID to testUrl in PRD, or set in .ralph/config.json testUrlVars"
-    echo "    skipped"
-    return 0
-  fi
-
-  # Handle relative URLs by prepending base URL from config
-  if [[ "$url" =~ ^/ ]]; then
-    if [[ -z "$base_url" ]]; then
-      print_error "testUrlBase not set in config.json (needed for relative URL: $url)"
-      return 1
-    fi
-    url="${base_url}${url}"
-  fi
-
-  if ! validate_url "$url"; then
-    print_error "Invalid URL: $url"
-    return 1
-  fi
-
-  echo "    URL: $url"
-
-  # Check if npx is available
-  if ! command -v npx &>/dev/null; then
-    print_warning "    npx not found, skipping browser validation"
-    return 0
-  fi
-
-  # Check if Playwright package is installed
-  local playwright_installed=false
-  if npm list playwright &>/dev/null || npm list -g playwright &>/dev/null; then
-    playwright_installed=true
-  fi
-
-  # Check if browser binaries are installed (look for chromium in cache)
-  # macOS uses ~/Library/Caches, Linux uses ~/.cache
-  local browser_installed=false
-  local playwright_cache=""
-  if [[ -d "$HOME/Library/Caches/ms-playwright" ]]; then
-    playwright_cache="$HOME/Library/Caches/ms-playwright"
-  elif [[ -d "$HOME/.cache/ms-playwright" ]]; then
-    playwright_cache="$HOME/.cache/ms-playwright"
-  fi
-  if [[ -n "$playwright_cache" ]] && ls "$playwright_cache"/chromium-* &>/dev/null; then
-    browser_installed=true
-  fi
-
-  # If either is missing, auto-install (Ralph runs autonomously)
-  if [[ "$playwright_installed" == "false" ]] || [[ "$browser_installed" == "false" ]]; then
-    echo ""
-    print_info "    Installing Playwright for browser verification (~150MB)..."
-    if npm install playwright &>/dev/null && npx playwright install chromium &>/dev/null; then
-      print_success "    Playwright installed!"
-    else
-      print_warning "    Installation failed, falling back to curl check"
-      return run_curl_check "$url"
-    fi
-  fi
-
-  # Get selectors to check from story (if defined)
-  local selectors
-  selectors=$(jq -r --arg id "$story" '.stories[] | select(.id==$id) | .selectors // [] | @json' "$RALPH_DIR/prd.json" 2>/dev/null)
-  if [[ "$selectors" == "null" || -z "$selectors" ]]; then
-    selectors="[]"
-  fi
-
-  # Screenshot path
-  mkdir -p "$RALPH_DIR/screenshots"
-  local screenshot_path="$RALPH_DIR/screenshots/${story}.png"
-
-  # Check mobile too?
-  local check_mobile
-  check_mobile=$(jq -r --arg id "$story" '.stories[] | select(.id==$id) | .mobile // empty' "$RALPH_DIR/prd.json" 2>/dev/null)
-
-  # Build command - use the browser-verify skill
-  local verify_script="$RALPH_LIB/browser-verify/verify.ts"
-
-  if [[ ! -f "$verify_script" ]]; then
-    print_warning "    browser-verify.ts not found, falling back to curl check"
-    return run_curl_check "$url"
-  fi
-
-  # Check for auth config (env vars take precedence over config file)
-  local auth_login=""
-  local login_url
-  local test_user
-  local test_password
-  login_url=$(get_config '.auth.loginUrl' "")
-  test_user="${RALPH_TEST_USER:-$(get_config '.auth.testUser' "")}"
-  test_password="${RALPH_TEST_PASSWORD:-$(get_config '.auth.testPassword' "")}"
-
-  if [[ -n "$login_url" && -n "$test_user" && -n "$test_password" ]]; then
-    # Build auth login JSON
-    local username_selector
-    local password_selector
-    local submit_selector
-    local success_indicator
-    username_selector=$(get_config '.auth.usernameSelector' "input[name='email'], input[name='username'], input[type='email']")
-    password_selector=$(get_config '.auth.passwordSelector' "input[name='password'], input[type='password']")
-    submit_selector=$(get_config '.auth.submitSelector' "button[type='submit'], input[type='submit']")
-    success_indicator=$(get_config '.auth.successIndicator' "")
-
-    auth_login=$(jq -n \
-      --arg loginUrl "$login_url" \
-      --arg usernameSelector "$username_selector" \
-      --arg passwordSelector "$password_selector" \
-      --arg submitSelector "$submit_selector" \
-      --arg username "$test_user" \
-      --arg password "$test_password" \
-      --arg successIndicator "$success_indicator" \
-      '{
-        loginUrl: $loginUrl,
-        usernameSelector: $usernameSelector,
-        passwordSelector: $passwordSelector,
-        submitSelector: $submitSelector,
-        username: $username,
-        password: $password,
-        successIndicator: (if $successIndicator == "" then null else $successIndicator end)
-      }')
-  fi
-
-  echo "    Running Playwright verification..."
-
-  local result
-  local exit_code=0
-
-  # Build the command with optional auth
-  local cmd_args=(
-    npx tsx "$verify_script" "$url"
-    --selectors "$selectors"
-    --screenshot "$screenshot_path"
-    --timeout "$BROWSER_PAGE_TIMEOUT_MS"
-  )
-
-  if [[ -n "$auth_login" ]]; then
-    cmd_args+=(--auth-login "$auth_login")
-  fi
-
-  # Run browser verification with wrapper timeout (in case Playwright hangs)
-  result=$(run_with_timeout "$BROWSER_TIMEOUT_SECONDS" "${cmd_args[@]}" 2>&1) || exit_code=$?
-
-  # Check for timeout
-  if [[ $exit_code -eq 124 ]]; then
-    print_error "failed (timed out after ${BROWSER_TIMEOUT_SECONDS}s)"
-    echo "    The page may be stuck loading or the dev server isn't responding."
-    echo "    Check: curl -I $url"
-    return run_curl_check "$url"
-  fi
-
-  # Check if we got any output
-  if [[ -z "$result" ]]; then
-    print_error "failed (no output from Playwright)"
-    echo "    Exit code: $exit_code"
-    echo "    This usually means Playwright crashed or isn't installed correctly."
-    echo "    Try: npm install playwright && npx playwright install chromium"
-    return run_curl_check "$url"
-  fi
-
-  # Check if result is valid JSON
-  if ! echo "$result" | jq -e . >/dev/null 2>&1; then
-    print_error "failed (invalid response)"
-    echo "    Raw output:"
-    echo "$result" | head -20 | sed 's/^/      /'
-    return run_curl_check "$url"
-  fi
-
-  # Parse result
-  local passed
-  passed=$(echo "$result" | jq -r '.pass // false' 2>/dev/null)
-
-  if [[ "$passed" == "true" ]]; then
-    local load_time
-    load_time=$(echo "$result" | jq -r '.loadTime // 0' 2>/dev/null)
-    print_success "passed (${load_time}ms)"
-
-    # Show any warnings
-    local warnings
-    warnings=$(echo "$result" | jq -r '.warnings[]?' 2>/dev/null)
-    if [[ -n "$warnings" ]]; then
-      echo "$warnings" | sed 's/^/      Warning: /'
-    fi
-
-    # Run mobile check if required
-    if [[ -n "$check_mobile" ]]; then
-      echo -n "    Mobile viewport... "
-      local mobile_result
-      mobile_result=$(run_with_timeout "$BROWSER_TIMEOUT_SECONDS" npx tsx "$verify_script" "$url" \
-        --selectors "$selectors" \
-        --screenshot "$RALPH_DIR/screenshots/${story}-mobile.png" \
-        --mobile \
-        2>&1) || true
-
-      local mobile_passed
-      mobile_passed=$(echo "$mobile_result" | jq -r '.pass // false' 2>/dev/null)
-
-      if [[ "$mobile_passed" == "true" ]]; then
-        print_success "passed"
-      else
-        print_warning "issues found"
-        echo "$mobile_result" | jq -r '.errors[]?' 2>/dev/null | head -3 | sed 's/^/      /'
-      fi
-    fi
-
-    return 0
-  else
-    print_error "failed"
-    echo ""
-
-    # Show errors
-    echo "    Errors:"
-    echo "$result" | jq -r '.errors[]?' 2>/dev/null | sed 's/^/      /'
-
-    # Show console errors if any
-    local console_errors
-    console_errors=$(echo "$result" | jq -r '.consoleErrors[]?' 2>/dev/null)
-    if [[ -n "$console_errors" ]]; then
-      echo ""
-      echo "    Console errors:"
-      echo "$console_errors" | head -5 | sed 's/^/      /'
-    fi
-
-    # Show missing elements if any
-    local missing
-    missing=$(echo "$result" | jq -r '.elementsMissing[]?' 2>/dev/null)
-    if [[ -n "$missing" ]]; then
-      echo ""
-      echo "    Missing elements:"
-      echo "$missing" | sed 's/^/      /'
-    fi
-
-    # Save for failure context
-    echo "$result" > "$RALPH_DIR/last_browser_failure.json"
-
-    return 1
-  fi
-}
-
-# Fallback curl check when Playwright isn't available
-run_curl_check() {
-  local url="$1"
-
-  local http_response
-  http_response=$(curl -s -o /dev/null -w "%{http_code}" --max-time "$CURL_TIMEOUT_SECONDS" "$url" 2>/dev/null) || http_response="000"
-
-  if [[ "$http_response" == "000" ]]; then
-    print_error "Cannot reach $url - server not responding"
-    return 1
-  elif [[ "$http_response" -ge 500 ]]; then
-    print_error "Server error $http_response at $url"
-    return 1
-  elif [[ "$http_response" -ge 400 ]]; then
-    print_warning "HTTP $http_response (may be expected for auth pages)"
-    return 0
-  fi
-
-  # Check for error messages in response
-  local page_content
-  page_content=$(curl -s --max-time "$CURL_TIMEOUT_SECONDS" "$url" 2>/dev/null)
-
-  if echo "$page_content" | grep -qi "something went wrong\|error.*occurred\|500 internal\|503 service\|oops\!" 2>/dev/null; then
-    print_error "Page contains error message"
-    return 1
-  fi
-
-  print_success "HTTP $http_response"
-  return 0
-}