agentic-loop 3.1.4 → 3.1.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agentic-loop",
-  "version": "3.1.4",
+  "version": "3.1.6",
   "description": "Autonomous AI coding loop - PRD-driven development with Claude Code",
   "author": "Allie Jones <allie@allthrive.ai>",
   "license": "MIT",

package/ralph/hooks/protect-prd.sh

@@ -3,6 +3,7 @@
 # Hook: PreToolUse matcher: "Edit|Write"
 #
 # Allows: /prd, /idea commands (they create .prd-edit-allowed marker)
+# Allows: Ralph loop fixing test steps (detected by last_failure.txt)
 # Blocks: Accidental edits during normal coding
 
 set -euo pipefail
@@ -19,6 +20,16 @@ if [[ "$FILE_PATH" == *"prd.json"* ]]; then
     exit 0
   fi
 
+  # Allow if Ralph is in a retry loop with a RECENT failure (within 10 min)
+  # This lets Ralph fix broken test steps, but not stale failures from old sessions
+  if [[ -f ".ralph/last_failure.txt" ]]; then
+    file_age=$(( $(date +%s) - $(stat -f %m ".ralph/last_failure.txt" 2>/dev/null || echo 0) ))
+    if [[ $file_age -lt 600 ]]; then  # 10 minutes
+      echo '{"continue": true}'
+      exit 0
+    fi
+  fi
+
   echo "BLOCKED: prd.json is managed by Ralph. Use /prd or /idea to add stories." >&2
   exit 2  # Exit code 2 = blocking error
 fi

package/ralph/loop.sh

@@ -337,24 +337,17 @@ run_loop() {
 
     # 6. Run verification pipeline
     echo ""
-    if run_verification "$story"; then
+    # Capture verification output for failure context
+    local verify_log="$RALPH_DIR/last_verification.log"
+    set -o pipefail
+    if run_verification "$story" 2>&1 | tee "$verify_log"; then
       # Mark story as complete
       update_json "$RALPH_DIR/prd.json" \
         --arg id "$story" '(.stories[] | select(.id==$id) | .passes) = true'
 
       # Clear failure context on success
       rm -f "$RALPH_DIR/last_failure.txt"
-      rm -f "$RALPH_DIR/last_migration_failure.log"
-      rm -f "$RALPH_DIR/last_review_failure.json"
-      rm -f "$RALPH_DIR/last_test_failure.log"
-      rm -f "$RALPH_DIR/last_lint_failure.log"
-      rm -f "$RALPH_DIR/last_typescript_failure.log"
-      rm -f "$RALPH_DIR/last_build_failure.log"
-      rm -f "$RALPH_DIR/last_go_failure.log"
-      rm -f "$RALPH_DIR/last_rust_failure.log"
-      rm -f "$RALPH_DIR/last_playwright_failure.log"
-      rm -f "$RALPH_DIR/last_browser_failure.json"
-      rm -f "$RALPH_DIR/last_precommit_failure.log"
+      rm -f "$RALPH_DIR/last_verification.log"
 
       # Auto-commit if git is available
       if command -v git &>/dev/null && [[ -d ".git" ]]; then
@@ -600,17 +593,11 @@ _inject_failure_context() {
   echo ""
   echo "## Previous Iteration Failed"
   echo ""
-  echo "**IMPORTANT:** The previous attempt at this story failed verification. Review the errors below and fix them."
+  echo "Fix the errors below. If a PRD test step is broken, you can fix it in .ralph/prd.json."
   echo ""
   echo '```'
   echo "$failure_context"
   echo '```'
-  echo ""
-  echo "### What to do:"
-  echo "1. Read the error messages carefully"
-  echo "2. Identify the root cause"
-  echo "3. Fix the issue (do not just retry the same approach)"
-  echo "4. Run verification again"
 }
 
 # Helper: Inject signs (learned patterns)

package/ralph/verify/tests.sh

@@ -58,8 +58,13 @@ verify_prd_criteria() {
 
   local failed=0
   local log_file
+  local prd_failure_log="$RALPH_DIR/last_prd_failure.log"
   log_file=$(create_temp_file ".log") || return 1
 
+  # Clear previous PRD failure log
+  rm -f "$prd_failure_log"
+
+  local step_index=0
   while IFS= read -r step; do
     [[ -z "$step" ]] && continue
 
@@ -72,8 +77,19 @@ verify_prd_criteria() {
       echo ""
       echo "    Output:"
       tail -"$MAX_OUTPUT_PREVIEW_LINES" "$log_file" | sed 's/^/      /'
+
+      # Save failure details for retry context
+      {
+        echo "PRD test step $step_index failed for $story:"
+        echo "  Command: $step"
+        echo "  Error output:"
+        tail -30 "$log_file" | sed 's/^/    /'
+        echo ""
+      } >> "$prd_failure_log"
+
       failed=1
     fi
+    ((step_index++)) || true
   done <<< "$test_steps"
 
   rm -f "$log_file"

package/ralph/verify.sh

@@ -197,138 +197,14 @@ run_verification() {
 # Save failure context for next iteration
 save_failure_context() {
   local story="$1"
-
   local context_file="$RALPH_DIR/last_failure.txt"
 
   {
-    echo "=== Failure Context for $story ==="
-    echo "Timestamp: $(date -Iseconds 2>/dev/null || date)"
+    echo "=== Verification failed for $story ==="
     echo ""
-
-    if [[ -f "$RALPH_DIR/last_migration_failure.log" ]]; then
-      echo "--- Migration Failure ---"
-      echo "Database migrations failed. Fix the migration or the code causing it:"
-      tail -50 "$RALPH_DIR/last_migration_failure.log"
-      echo ""
-    fi
-
-    if [[ -f "$RALPH_DIR/last_review_failure.json" ]]; then
-      echo "--- Code Review Failure ---"
-      echo "Issues found by code review:"
-      jq -r '.issues[] | "- [\(.severity)] \(.category): \(.message)\n  File: \(.file // "unknown"):\(.line // "?")\n  Fix: \(.suggestion // "See above")"' "$RALPH_DIR/last_review_failure.json" 2>/dev/null
-      echo ""
-    fi
-
-    if [[ -f "$RALPH_DIR/last_test_failure.log" ]]; then
-      echo "--- Test Failure ---"
-      tail -50 "$RALPH_DIR/last_test_failure.log"
-      echo ""
-    fi
-
-    if [[ -f "$RALPH_DIR/last_playwright_failure.log" ]]; then
-      echo "--- Playwright Failure ---"
-      tail -50 "$RALPH_DIR/last_playwright_failure.log"
-      echo ""
-    fi
-
-    if [[ -f "$RALPH_DIR/last_browser_failure.json" ]]; then
-      echo "--- Browser Validation Failure ---"
-      jq -r '"Errors: " + (.errors | join(", "))' "$RALPH_DIR/last_browser_failure.json" 2>/dev/null
-      jq -r '"Console errors: " + (.consoleErrors | join(", "))' "$RALPH_DIR/last_browser_failure.json" 2>/dev/null
-      jq -r '"Missing elements: " + (.elementsMissing | join(", "))' "$RALPH_DIR/last_browser_failure.json" 2>/dev/null
-      echo ""
-    fi
-
-    if [[ -f "$RALPH_DIR/last_lint_failure.log" ]]; then
-      echo "--- Lint Failure ---"
-      echo "Fix these lint errors. The auto-fixer couldn't resolve them, but you can:"
-      echo ""
-      cat "$RALPH_DIR/last_lint_failure.log"
-      echo ""
-      echo "Common fixes:"
-      echo "  - E722 bare except: Change 'except:' to 'except Exception:'"
-      echo "  - F401 unused import: Remove the unused import"
-      echo "  - F841 unused variable: Remove or use the variable"
-      echo ""
-    fi
-
-    if [[ -f "$RALPH_DIR/last_typescript_failure.log" ]]; then
-      echo "--- TypeScript Failure ---"
-      echo "Fix these TypeScript type errors:"
-      echo ""
-      cat "$RALPH_DIR/last_typescript_failure.log"
-      echo ""
-      echo "Common fixes:"
-      echo "  - TS2322: Type mismatch - ensure assigned value matches expected type"
-      echo "  - TS2339: Property not found - check spelling or add to interface"
-      echo "  - TS2345: Argument type mismatch - cast or fix the argument type"
-      echo "  - TS7006: Implicit any - add explicit type annotation"
-      echo ""
-    fi
-
-    if [[ -f "$RALPH_DIR/last_build_failure.log" ]]; then
-      echo "--- Build Failure ---"
-      echo "Fix these build errors:"
-      echo ""
-      cat "$RALPH_DIR/last_build_failure.log"
-      echo ""
-      echo "Common causes:"
-      echo "  - Import errors: Check file paths and exports"
-      echo "  - SSR issues (Next.js): Use dynamic imports for client-only code"
-      echo "  - Missing dependencies: Run npm install"
-      echo ""
-    fi
-
-    if [[ -f "$RALPH_DIR/last_go_failure.log" ]]; then
-      echo "--- Go Failure ---"
-      echo "Fix these Go errors:"
-      echo ""
-      cat "$RALPH_DIR/last_go_failure.log"
-      echo ""
-      echo "Common fixes:"
-      echo "  - Unused variable: Remove or use with _ prefix"
-      echo "  - Undefined: Check imports and spelling"
-      echo "  - Type mismatch: Ensure types align or use type assertion"
-      echo ""
-    fi
-
-    if [[ -f "$RALPH_DIR/last_rust_failure.log" ]]; then
-      echo "--- Rust Failure ---"
-      echo "Fix these Rust errors:"
-      echo ""
-      cat "$RALPH_DIR/last_rust_failure.log"
-      echo ""
-      echo "Common fixes:"
-      echo "  - Unused variable: Prefix with _ or remove"
-      echo "  - Borrow checker: Check ownership and lifetimes"
-      echo "  - Missing trait: Add #[derive(...)] or impl"
-      echo ""
-    fi
-
-    if [[ -f "$RALPH_DIR/last_precommit_failure.log" ]]; then
-      echo "--- Pre-commit / Lint Failure ---"
-      echo "Fix these errors before the story can be completed:"
-      echo ""
-      # Extract actual error lines (not warnings-only or file modification messages)
-      grep -E "^error:|: error:|Error:|SyntaxError|✖ [0-9]+ problems|^[^:]+:[0-9]+:[0-9]+: [EF][0-9]+" "$RALPH_DIR/last_precommit_failure.log" | head -30
-      # If no errors shown, show the full log tail
-      if ! grep -qE "^error:|: error:|Error:|SyntaxError|✖ [0-9]+ problems" "$RALPH_DIR/last_precommit_failure.log"; then
-        echo "(Full output):"
-        tail -40 "$RALPH_DIR/last_precommit_failure.log"
-      fi
-      echo ""
-    fi
-
-    if [[ -f "$RALPH_DIR/last_fastapi_response_check.log" ]]; then
-      echo "--- FastAPI Response Model Failure ---"
-      echo "Add Pydantic response_model to these endpoints for proper Swagger docs:"
-      echo ""
-      cat "$RALPH_DIR/last_fastapi_response_check.log"
-      echo ""
-      echo "Fix by adding response_model parameter or return type annotation:"
-      echo '  @router.get("/items", response_model=list[ItemSchema])'
-      echo "  async def get_items() -> list[ItemSchema]:"
-      echo ""
+    # Just include the verification output - Claude can figure out what went wrong
+    if [[ -f "$RALPH_DIR/last_verification.log" ]]; then
+      tail -100 "$RALPH_DIR/last_verification.log"
     fi
   } > "$context_file"
 }