agentic-loop 3.1.3 → 3.1.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agentic-loop",
-  "version": "3.1.3",
+  "version": "3.1.5",
   "description": "Autonomous AI coding loop - PRD-driven development with Claude Code",
   "author": "Allie Jones <allie@allthrive.ai>",
   "license": "MIT",

package/ralph/hooks/protect-prd.sh

@@ -3,6 +3,7 @@
 # Hook: PreToolUse matcher: "Edit|Write"
 #
 # Allows: /prd, /idea commands (they create .prd-edit-allowed marker)
+# Allows: Ralph loop fixing test steps (detected by last_failure.txt)
 # Blocks: Accidental edits during normal coding
 
 set -euo pipefail
@@ -19,6 +20,16 @@ if [[ "$FILE_PATH" == *"prd.json"* ]]; then
     exit 0
   fi
 
+  # Allow if Ralph is in a retry loop with a RECENT failure (within 10 min)
+  # This lets Ralph fix broken test steps, but not stale failures from old sessions
+  if [[ -f ".ralph/last_failure.txt" ]]; then
+    file_age=$(( $(date +%s) - $(stat -f %m ".ralph/last_failure.txt" 2>/dev/null || echo 0) ))
+    if [[ $file_age -lt 600 ]]; then  # 10 minutes
+      echo '{"continue": true}'
+      exit 0
+    fi
+  fi
+
   echo "BLOCKED: prd.json is managed by Ralph. Use /prd or /idea to add stories." >&2
   exit 2  # Exit code 2 = blocking error
 fi

package/ralph/loop.sh

@@ -265,7 +265,6 @@ run_loop() {
     local failure_context=""
     if [[ -f "$RALPH_DIR/last_failure.txt" ]]; then
       failure_context=$(cat "$RALPH_DIR/last_failure.txt")
-      echo "  (Passing failure context: $(echo "$failure_context" | wc -l | tr -d ' ') lines)"
     fi
 
     # Temporarily disable errexit to capture build_prompt errors
@@ -356,6 +355,7 @@ run_loop() {
       rm -f "$RALPH_DIR/last_playwright_failure.log"
       rm -f "$RALPH_DIR/last_browser_failure.json"
       rm -f "$RALPH_DIR/last_precommit_failure.log"
+      rm -f "$RALPH_DIR/last_prd_failure.log"
 
       # Auto-commit if git is available
       if command -v git &>/dev/null && [[ -d ".git" ]]; then
@@ -609,9 +609,16 @@ _inject_failure_context() {
   echo ""
   echo "### What to do:"
   echo "1. Read the error messages carefully"
-  echo "2. Identify the root cause"
+  echo "2. Identify the root cause - is it your implementation OR a flawed test step?"
   echo "3. Fix the issue (do not just retry the same approach)"
   echo "4. Run verification again"
+  echo ""
+  echo "### If the test step itself is broken:"
+  echo "If the error is in the PRD test step (not your implementation), you CAN fix it:"
+  echo "1. Read .ralph/prd.json to find the story index and broken testStep"
+  echo "2. Use jq to update: \`jq '.stories[IDX].testSteps[N] = \"fixed\"' .ralph/prd.json > tmp && mv tmp .ralph/prd.json\`"
+  echo "3. Common test step bugs: missing imports, str() triggering lazy loading, wrong paths"
+  echo "4. ONLY fix the test command - do NOT change acceptance criteria or story scope"
 }
 
 # Helper: Inject signs (learned patterns)

package/ralph/verify/tests.sh

@@ -58,8 +58,13 @@ verify_prd_criteria() {
 
   local failed=0
   local log_file
+  local prd_failure_log="$RALPH_DIR/last_prd_failure.log"
   log_file=$(create_temp_file ".log") || return 1
 
+  # Clear previous PRD failure log
+  rm -f "$prd_failure_log"
+
+  local step_index=0
   while IFS= read -r step; do
     [[ -z "$step" ]] && continue
 
@@ -72,8 +77,19 @@ verify_prd_criteria() {
       echo ""
       echo "    Output:"
       tail -"$MAX_OUTPUT_PREVIEW_LINES" "$log_file" | sed 's/^/      /'
+
+      # Save failure details for retry context
+      {
+        echo "PRD test step $step_index failed for $story:"
+        echo "  Command: $step"
+        echo "  Error output:"
+        tail -30 "$log_file" | sed 's/^/    /'
+        echo ""
+      } >> "$prd_failure_log"
+
       failed=1
     fi
+    ((step_index++)) || true
   done <<< "$test_steps"
 
   rm -f "$log_file"

package/ralph/verify.sh

@@ -188,11 +188,6 @@ run_verification() {
     return 0
   else
     print_error "=== Verification failed ==="
-    # Debug: Show which failure logs exist
-    echo "Saving failure context..."
-    [[ -f "$RALPH_DIR/last_lint_failure.log" ]] && echo "  - Found lint failure log"
-    [[ -f "$RALPH_DIR/last_test_failure.log" ]] && echo "  - Found test failure log"
-    [[ -f "$RALPH_DIR/last_typescript_failure.log" ]] && echo "  - Found typescript failure log"
     # Save failure context for next iteration
     save_failure_context "$story"
     return 1
@@ -335,5 +330,18 @@ save_failure_context() {
       echo "  async def get_items() -> list[ItemSchema]:"
       echo ""
     fi
+
+    if [[ -f "$RALPH_DIR/last_prd_failure.log" ]]; then
+      echo "--- PRD Test Step Failure ---"
+      echo "A test step in the PRD failed. Either fix your implementation OR fix the test step:"
+      echo ""
+      cat "$RALPH_DIR/last_prd_failure.log"
+      echo ""
+      echo "If the test step itself is broken (not your code), you can fix it:"
+      echo "  1. Read .ralph/prd.json to find the story and testSteps array"
+      echo "  2. Fix the command (e.g., add missing imports for SQLAlchemy models)"
+      echo "  3. Update with: jq '.stories[IDX].testSteps[N] = \"fixed command\"' .ralph/prd.json > tmp && mv tmp .ralph/prd.json"
+      echo ""
+    fi
   } > "$context_file"
 }